Re: [RFC PATCH 30/97] drm/i915/uc: turn on GuC/HuC auto mode by default

[Michal Wajdeczko]

On 06.05.2021 21:13, Matthew Brost wrote:
> From: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
> 
> This will enable HuC loading for Gen11+ by default if the binaries
> are available on the system. GuC submission still requires explicit
> enabling by the user.
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com>
> Signed-off-by: Matthew Brost <matthew.br...@intel.com>
> Cc: Michal Wajdeczko <michal.wajdec...@intel.com>
> Cc: John Harrison <john.c.harri...@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.h 
> b/drivers/gpu/drm/i915/i915_params.h
> index 14cd64cc61d0..a0575948ab61 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -59,7 +59,7 @@ struct drm_printer;
>       param(int, disable_power_well, -1, 0400) \
>       param(int, enable_ips, 1, 0600) \
>       param(int, invert_brightness, 0, 0600) \
> -     param(int, enable_guc, 0, 0400) \
> +     param(int, enable_guc, -1, 0400) \

you also want to update param description from

        "(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)");
to
        "(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)");

>       param(int, guc_log_level, -1, 0400) \
>       param(char *, guc_firmware_path, NULL, 0400) \
>       param(char *, huc_firmware_path, NULL, 0400) \
>