Re: [RFC PATCH 40/97] drm/i915/guc: Module load failure test for CT buffer creation

[Michal Wajdeczko]

On 06.05.2021 21:13, Matthew Brost wrote:
> From: John Harrison <john.c.harri...@intel.com>
> 
> Add several module failure load inject points in the CT buffer creation
> code path.
> 
> Signed-off-by: John Harrison <john.c.harri...@intel.com>
> Signed-off-by: Matthew Brost <matthew.br...@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c 
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> index d6895d29ed2d..586e6efc3558 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> @@ -177,6 +177,10 @@ static int ct_register_buffer(struct intel_guc_ct *ct, 
> u32 type,
>  {
>       int err;
>  
> +     err = i915_inject_probe_error(guc_to_gt(ct_to_guc(ct))->i915, -ENXIO);
> +     if (unlikely(err))
> +             return err;
> +
>       err = guc_action_register_ct_buffer(ct_to_guc(ct), type,
>                                           desc_addr, buff_addr, size);
>       if (unlikely(err))
> @@ -228,6 +232,10 @@ int intel_guc_ct_init(struct intel_guc_ct *ct)
>       u32 *cmds;
>       int err;
>  
> +     err = i915_inject_probe_error(guc_to_gt(guc)->i915, -ENXIO);
> +     if (err)
> +             return err;
> +
>       GEM_BUG_ON(ct->vma);
>  
>       blob_size = 2 * CTB_DESC_SIZE + CTB_H2G_BUFFER_SIZE + 
> CTB_G2H_BUFFER_SIZE;
> 

likely could be introduced earlier, maybe right after patch 5/97

Reviewed-by: Michal Wajdeczko <michal.wajdec...@intel.com>