[RESEND PATCH v5 2/2] drm/bridge: hx8837: add a Himax HX8837 display controller driver

2020-09-28 Thread Lubomir Rintel
Himax HX8837 is used to drive the LCD panel on OLPC platforms. It controls the panel backlight and is able to refresh it when the LCD controller (and the rest of the plaform) is powered off. It also converts regular RGB color data from the LCDC so that it looks reasonable on the OLPC LCD panel wi

Re: [PATCH] drm/msm/dp: DisplayPort PHY compliance tests fixup

2020-09-28 Thread Stephen Boyd
Quoting Tanmay Shah (2020-09-25 21:50:48) > Bandwidth code was being used as test link rate. Fix this by converting > bandwidth code to test link rate > > Do not reset voltage and pre-emphasis level during IRQ HPD attention > interrupt. Also fix pre-emphasis parsing during test link status process

[PATCH v2 3/7] drm/ingenic: Alloc F0 and F1 DMA descriptors at once

2020-09-28 Thread Paul Cercueil
Instead of calling dmam_alloc_coherent() once for each 4-bit DMA hardware descriptor, we can have them both in a physical memory page, as long as they are aligned to 16 bytes. This reduces memory consumption, and will make it easier to add more DMA descriptors in the future. Note that the old code

Re: [PATCH v2 1/2] drm/vc4: crtc: Rework a bit the CRTC state code

2020-09-28 Thread Maxime Ripard
Hi, On Wed, Sep 23, 2020 at 03:59:04PM +0100, Dave Stevenson wrote: > Hi Maxime > > On Wed, 23 Sep 2020 at 09:40, Maxime Ripard wrote: > > > > The current CRTC state reset hook in vc4 allocates a vc4_crtc_state > > structure as a drm_crtc_state, and relies on the fact that vc4_crtc_state > > emb

[PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings

2020-09-28 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) support for Unisoc's display subsystem. RFC v7: - Fix DTC unit name warnings - Fix the problem of maintainers Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- .../display/sprd/sprd,sharkl3-dsi-host.yaml

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-28 Thread Jason Gunthorpe
On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: > > > diff --git a/tools/testing/scatterlist/main.c > > > b/tools/testing/scatterlist/main.c > > > index 0a1464181226..4899359a31ac 100644 > > > +++ b/tools/testing/scatterlist/main.c > > > @@ -55,14 +55,13 @@ int main(void) > > >

[PATCH RFC v7 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-09-28 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem RFC v7: - Fix DTC unit name warnings - Fix the problem of maintainers Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevi

[PATCH 2/2] ARM: dts: rpi-4: disable wifi frequencies

2020-09-28 Thread Maxime Ripard
The RPi4 WiFi chip and HDMI outputs have some frequency overlap with crosstalk around 2.4GHz. Let's mark it as such so we can use some evasive maneuvers. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-28 Thread Jason Gunthorpe
On Fri, Sep 25, 2020 at 12:41:29PM +0100, Tvrtko Ursulin wrote: > > On 25/09/2020 08:13, Leon Romanovsky wrote: > > On Thu, Sep 24, 2020 at 09:21:20AM +0100, Tvrtko Ursulin wrote: > > > > > > On 22/09/2020 09:39, Leon Romanovsky wrote: > > > > From: Maor Gottlieb > > > > > > > > Extend __sg_all

[PATCH 1/2] drm/vc4: hdmi: Disable Wifi Frequencies

2020-09-28 Thread Maxime Ripard
There's cross-talk on the RPi4 between the 2.4GHz channels used by the WiFi chip and some resolutions, most notably 1440p at 60Hz. In such a case, we can either reject entirely the mode, or lower slightly the pixel frequency to remove the overlap. Let's go for the latter. Signed-off-by: Maxime Ri

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread Tetsuo Handa
On 2020/09/27 4:39, Peilin Ye wrote: > On Sun, Sep 27, 2020 at 01:25:17AM +0900, Tetsuo Handa wrote: >> Since I don't know the meaning of "struct vt_consize"->v_clin (which is >> commented >> with "/* number of pixel rows per character */" but does it mean font size >> ?), >> I don't know why we

Re: [PATCH] drm/vc4: Deleted the drm_device declaration

2020-09-28 Thread tiantao (H)
Hi : I alwaygs used scripts/get_maintainers.pl to get the recipient list.I don't know why miss maintainers for a given piece of code. tiantao@ubuntu:~$ git send-email -to e...@anholt.net -to airl...@linux.ie -to dan...@ffwll.ch -to sumit.sem...@linaro.org -to christian.koe...@amd.com -to dri-

[PATCH] drm/amd/display: make two symbols static

2020-09-28 Thread Jason Yan
This addresses the following sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6: warning: symbol 'dce110_set_cursor_position' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6: warning: symb

Re: [PATCH] drm/hisilicon: Deleted the drm_device declaration

2020-09-28 Thread tiantao (H)
在 2020/9/25 15:26, Thomas Zimmermann 写道: Hi Am 25.09.20 um 09:02 schrieb Thomas Zimmermann: Hi, just a few nits. Am 25.09.20 um 08:49 schrieb Tian Tao: drm_framebuffer.h contains drm/drm_device.h and struct drm_device is contains -> includes already declared in this file, so there is n

Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers

2020-09-28 Thread Peilin Ye
Hi all! On Fri, Sep 25, 2020 at 08:46:04AM +0200, Jiri Slaby wrote: > > In order to perform a reliable range check, fbcon_get_font() needs to know > > `FONTDATAMAX` for each built-in font under lib/fonts/. Unfortunately, we > > do not keep that information in our font descriptor, > > `struct conso

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread Tetsuo Handa
Well, vt_io_ioctl(PIO_FONT) initializes "struct console_font_op op;" with op.width = 8; op.height = 0; op.charcount = 256; and calls con_font_set() from con_font_op(). But the "/* Need to guess font height [compat] */" chunk in con_font_set() guesses font's height due to being initialized

[PATCH RFC v7 0/6] Add Unisoc's drm kms module

2020-09-28 Thread Kevin Tang
ChangeList: v1: 1. only upstream modeset and atomic at first commit. 2. remove some unused code; 3. use alpha and blend_mode properties; 3. add yaml support; 4. remove auto-adaptive panel driver; 5. bugfix v2: 1. add sprd crtc and plane module for KMS, preparing for multi crtc&encoder 2. remove g

[PATCH v2 5/7] drm/ingenic: Add support for paletted 8bpp

2020-09-28 Thread Paul Cercueil
On JZ4725B and newer, the F0 plane supports paletted 8bpp with a 256-entry palette. Add support for it. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 60 +-- 1 file changed, 56 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ingenic/

[PATCH] drm: of: fix leak of endpoint

2020-09-28 Thread Tobias Jordan
The for_each_child_of_node loop in drm_of_lvds_get_remote_pixels_type bails out in two occasions. Originally, both were calling of_node_put to clean up, but (probably a typo) for the wrong variable. One of these typos was fixed in commit 4ee48cc5586b ("drm: of: Fix double-free bug"), but that miss

[PATCH v2 7/7] drm/ingenic: Add support for 24-bit modes

2020-09-28 Thread Paul Cercueil
Starting from the JZ4725B SoC, the primary and overlay planes support 24-bit pixel modes (8 bits per color component, without dummy byte). Add support for these in the ingenic-drm driver. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 8 drivers/gpu/drm/ing

Re: [PATCH v2 1/2] drm/vc4: crtc: Rework a bit the CRTC state code

2020-09-28 Thread Maxime Ripard
Hi Dave, On Wed, Sep 23, 2020 at 03:59:04PM +0100, Dave Stevenson wrote: > Hi Maxime > > On Wed, 23 Sep 2020 at 09:40, Maxime Ripard wrote: > > > > The current CRTC state reset hook in vc4 allocates a vc4_crtc_state > > structure as a drm_crtc_state, and relies on the fact that vc4_crtc_state >

[PATCH RFC v7 2/6] drm/sprd: add Unisoc's drm kms master

2020-09-28 Thread Kevin Tang
Adds drm support for the Unisoc's display subsystem. This is drm kms driver, this driver provides support for the application framework in Android, Yocto and more. Application framework can access Unisoc's display internel peripherals through libdrm or libkms, it's test ok by modetest (DRM/KMS te

[PATCH v2] drm/hisilicon: Deleted the drm_device declaration

2020-09-28 Thread Tian Tao
drm_framebuffer.h includes drm/drm_device.h and struct drm_device is already defined in this file, so there is no need to define struct drm_device in hibmc_drm_drv.h. v2: fixed spelling errors in commit message. Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:171d4ff7 Merge tag 'mmc-v5.9-rc4-2' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13b41d0390 kernel config: https://syzkaller.appspot.com/x/.config?x=240e2eb

Re: [PATCH v3 1/1] drm/ingenic: Add support for paletted 8bpp

2020-09-28 Thread Paul Cercueil
Le dim. 27 sept. 2020 à 22:27, Sam Ravnborg a écrit : On Sun, Sep 27, 2020 at 09:36:45PM +0200, Paul Cercueil wrote: On JZ4725B and newer, the F0 plane supports paletted 8bpp with a 256-entry palette. Add support for it. v3: Only accept a full 256-entry palette. Signed-off-by: Paul Ce

[PATCH] drm/amd/display: make get_color_space_type() static

2020-09-28 Thread Jason Yan
This addresses the following sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26: warning: symbol 'get_color_space_type' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/core/dc_hw_sequ

[PATCH v2 1/7] drm/ingenic: Reset pixclock rate when parent clock rate changes

2020-09-28 Thread Paul Cercueil
Old Ingenic SoCs can overclock very well, up to +50% of their nominal clock rate, whithout requiring overvolting or anything like that, just by changing the rate of the main PLL. Unfortunately, all clocks on the system are derived from that PLL, and when the PLL rate is updated, so is our pixel clo

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-28 Thread Maor Gottlieb
On 9/25/2020 3:33 PM, Tvrtko Ursulin wrote: On 25/09/2020 13:18, Maor Gottlieb wrote: On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c index 0a146418

[PATCH v2 2/7] drm/ingenic: Add support for reserved memory

2020-09-28 Thread Paul Cercueil
Add support for static memory reserved from Device Tree. Since we're using GEM buffers backed by CMA, it is interesting to have an option to specify the CMA area where the GEM buffers will be allocated. v2: Don't abort probe if reserved memory cannot be obtained. The driver will still work fin

[PATCH RFC v7 4/6] drm/sprd: add Unisoc's drm display controller driver

2020-09-28 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. RFC v7: - Remove plane_update stuff, dpu handles all the HW update in crtc->atomic_flush RFC v6: - Access registers via readl/writel - Che

[PATCH RFC v7 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2020-09-28 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- drivers/gpu/drm/sprd/Makefil

[PATCH] drm: of: fix leak of port_node

2020-09-28 Thread Tobias Jordan
The for_each_child_of_node loop in drm_of_lvds_get_remote_pixels_type bails out in two occasions. Originally, both were calling of_node_put to clean up, but (probably a typo) for the wrong variable. One of these typos was fixed in commit 4ee48cc5586b ("drm: of: Fix double-free bug"), but that miss

[PATCH v2] drm/msm/dp: return correct connection status after suspend

2020-09-28 Thread Kuogee Hsieh
At dp_pm_resume, reinitialize both dp host controller and hpd block so that hpd connection can be detected at realtime by reading hpd state status register. Also hpd plug interrupt can be generated accordingly. Changes in v2: -- use container_of to cast correct dp_display_private pointer at bot

REGRESSION: [i915] kernel NULL pointer dereference

2020-09-28 Thread Tony Fischetti
I just tested the v5.9-rc7 release on two of my machines and on one of the machines, I got a bug/oops that prevents the video driver from working properly. This regression must have occurred somewhere between v5.9-rc8 and v5.9-rc9. I'm attempting to git bisect it, but I wanted to bring it to your

Re: [PATCH 2/3] drm/ingenic: Reset pixclock rate when parent clock rate changes

2020-09-28 Thread Paul Cercueil
Hi Sam, Le jeu. 24 sept. 2020 à 22:22, Sam Ravnborg a écrit : Hi Paul. On Tue, Sep 15, 2020 at 02:38:17PM +0200, Paul Cercueil wrote: Old Ingenic SoCs can overclock very well, up to +50% of their nominal clock rate, whithout requiring overvolting or anything like that, just by changing t

Re: [PATCH v2] drm/msm/dp: fix incorrect function prototype of dp_debug_get()

2020-09-28 Thread Stephen Boyd
Quoting Abhinav Kumar (2020-09-25 19:55:12) > Fix the incorrect function prototype for dp_debug_get() > in the dp_debug module to address compilation warning. > Also add prototype for msm_dp_debugfs_init() for fixing compilation > issue with other defconfigs. > > changes in v2: > - add pro

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-28 Thread Jason Gunthorpe
On Fri, Sep 25, 2020 at 01:29:49PM +0100, Tvrtko Ursulin wrote: > > On 25/09/2020 12:58, Jason Gunthorpe wrote: > > On Fri, Sep 25, 2020 at 12:41:29PM +0100, Tvrtko Ursulin wrote: > > > > > > On 25/09/2020 08:13, Leon Romanovsky wrote: > > > > On Thu, Sep 24, 2020 at 09:21:20AM +0100, Tvrtko Ursu

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-28 Thread Maor Gottlieb
On 9/25/2020 2:41 PM, Tvrtko Ursulin wrote: On 25/09/2020 08:13, Leon Romanovsky wrote: On Thu, Sep 24, 2020 at 09:21:20AM +0100, Tvrtko Ursulin wrote: On 22/09/2020 09:39, Leon Romanovsky wrote: From: Maor Gottlieb Extend __sg_alloc_table_from_pages to support dynamic allocation of SG ta

[PATCH v2 6/7] drm/ingenic: Add support for 30-bit modes

2020-09-28 Thread Paul Cercueil
Starting from the JZ4760 SoC, the primary and overlay planes support 30-bit pixel modes (10 bits per color component). Add support for these in the ingenic-drm driver. Signed-off-by: Paul Cercueil Acked-by: Sam Ravnborg --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 8 drivers/gpu/drm

[PATCH] drm/vc4: Deleted the drm_device declaration

2020-09-28 Thread Tian Tao
drm_modeset_lock.h already declares struct drm_device, so there's no need to declare it in vc4_drv.h Signed-off-by: Tian Tao --- drivers/gpu/drm/vc4/vc4_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index 8c8d96b..8717a1c 1

[PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2020-09-28 Thread Tetsuo Handa
syzbot is reporting UAF/OOB read at bit_putcs()/soft_cursor() [1][2], for vt_resizex() from ioctl(VT_RESIZEX) allows setting font height larger than actual font height calculated by con_font_set() from ioctl(PIO_FONT). Since fbcon_set_font() from con_font_set() allocates minimal amount of memory ba

[PATCH v3] drm/hisilicon: Deleted the drm_device declaration

2020-09-28 Thread Tian Tao
drm_framebuffer.h already declares struct drm_device, so there's no need to declare it in hibm_drm_drv.h v2: fixed spelling errors in commit message. v3: rewrite the commit message. Signed-off-by: Tian Tao Acked-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 --

[PATCH v2 4/7] drm/ingenic: Support handling different pixel formats in F0/F1 planes

2020-09-28 Thread Paul Cercueil
Until now the ingenic-drm driver supported the same pixel formats on the F0 and F1 planes, and across all SoCs. However, the F0 plane does support paletted 8bpp, while the F1 plane doesn't. Furthermore, the three SoCs currently supported all have different pixel formats available; 24bpp was added

[PATCH v2 0/7] Ingenic-drm improvements + new pixel formats

2020-09-28 Thread Paul Cercueil
Hi, This is a V2 of my small patchset "Small improvements to ingenic-drm" that I sent about two weeks ago. In that time, I worked on new improvements, so I thought I'd just add them to the patchset, since I needed a V2 anyway. Sam: the patches you acked have been all slightly modified, I kept you

[PATCH v3 0/1] 8bpp support for Ingenic-drm

2020-09-28 Thread Paul Cercueil
Final (?) version of my "small improvements to ingenic-drm" patchset. Most of the patches of V2 have been merged to drm-misc-next, except this one which required some more work. In the CRTC's .atomic_check callback, the size of the gamma LUT property is now checked, so that only a complete 256-en

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread Tetsuo Handa
A simplified reproducer and debug printk() patch shown below reported that vc_font.height is increased to 9 via ioctl(VT_RESIZEX) after it was once decreased from 16 to 2 via ioctl(PIO_FONT). Since vc_resize() with v.v_rows == 0 preserves current vc->vc_rows value, this reproducer is bypassing

Re: [Intel-gfx] [PATCH rdma-next v3 1/2] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-28 Thread Maor Gottlieb
On 9/25/2020 2:55 PM, Jason Gunthorpe wrote: On Fri, Sep 25, 2020 at 10:13:30AM +0300, Leon Romanovsky wrote: diff --git a/tools/testing/scatterlist/main.c b/tools/testing/scatterlist/main.c index 0a1464181226..4899359a31ac 100644 +++ b/tools/testing/scatterlist/main.c @@ -55,14 +55,13 @@ int

Re: [PATCH 0/3] Prevent out-of-bounds access for built-in font data buffers

2020-09-28 Thread Peilin Ye
On Fri, Sep 25, 2020 at 03:25:51PM +0200, Daniel Vetter wrote: > I think the only way to make this work is that we have one place which > takes in the userspace uapi struct, and then converts it once into a > kernel_console_font. With all the error checking. Ah, I didn't think of that! When trying

[RESEND PATCH v5 0/2] Add a Himax HX8837 display controller driver

2020-09-28 Thread Lubomir Rintel
Hi, please take a look at the patches chained to this messages and consider applying them. They add support for the controller that drives the panel on the OLPC XO laptops. The only change since the previous version is the Reviewed-by tag in DT bindings. Compared to v3 the bindings have been con

RE: [PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-28 Thread Swapnil Kashinath Jakhade
Hi Tomi, Thank you for the patch. > -Original Message- > From: Tomi Valkeinen > Sent: Wednesday, September 23, 2020 2:01 PM > To: dri-devel@lists.freedesktop.org; Swapnil Kashinath Jakhade > ; Yuti Suresh Amonkar > Cc: Stephen Rothwell ; Dave Airlie > ; Laurent Pinchart ; > Tomi Valkein

Re: [PATCH 3/9] drm: Add simplekms driver

2020-09-28 Thread Maxime Ripard
Hi Thomas, On Fri, Sep 25, 2020 at 05:01:23PM +0200, Thomas Zimmermann wrote: > >> + ARRAY_SIZE(simplekms_formats), > >> + simplekms_format_modifiers, > >> + connector); > >> + if (ret) > >

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread Peilin Ye
On Sun, Sep 27, 2020 at 01:25:17AM +0900, Tetsuo Handa wrote: > A simplified reproducer and debug printk() patch shown below reported that > vc_font.height is increased to 9 via ioctl(VT_RESIZEX) after it was once > decreased from 16 to 2 via ioctl(PIO_FONT). > > > > Since vc_resize() with v.v_r

Re: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-09-28 Thread Lad, Prabhakar
Hi Laurent, On Mon, Aug 24, 2020 at 1:48 AM Laurent Pinchart wrote: > > Hi Prabhakar, > > Thank you for the patch. > > On Thu, Aug 13, 2020 at 03:00:41PM +0100, Lad Prabhakar wrote: > > The iwg21d comes with a 7" capacitive touch screen, therefore > > add support for it. > > > > Signed-off-by: La

[PATCH RFC v7 3/6] dt-bindings: display: add Unisoc's dpu bindings

2020-09-28 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. RFC v7: - Fix DTC unit name warnings - Fix the problem of maintainers Cc: Orson Zhai Cc: Chunyan Zhang Signed

KASAN: global-out-of-bounds Read in bit_putcs (2)

2020-09-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:171d4ff7 Merge tag 'mmc-v5.9-rc4-2' of git://git.kernel.or.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=126e918d90 kernel config: https://syzkaller.appspot.com/x/.config?x=240e2ebab67245c7 das

[PATCH v3 1/1] drm/ingenic: Add support for paletted 8bpp

2020-09-28 Thread Paul Cercueil
On JZ4725B and newer, the F0 plane supports paletted 8bpp with a 256-entry palette. Add support for it. v3: Only accept a full 256-entry palette. Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 66 +-- 1 file changed, 62 insertions(+), 4 deletion

Re: KASAN: use-after-free Read in bit_putcs

2020-09-28 Thread Peilin Ye
On Sun, Sep 27, 2020 at 05:28:12PM +0900, Tetsuo Handa wrote: > Well, vt_io_ioctl(PIO_FONT) initializes "struct console_font_op op;" with > > op.width = 8; > op.height = 0; > op.charcount = 256; > > and calls con_font_set() from con_font_op(). But the "/* Need to guess font > height [compa

[PATCH] drm/vc4: hdmi: Block odd horizontal timings

2020-09-28 Thread Maxime Ripard
The FIFO between the pixelvalve and the HDMI controller runs at 2 pixels per clock cycle, and cannot deal with odd timings. Let's reject any mode with such timings. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 12 drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +++ 2 file

Re: [PATCH v2 0/7] Ingenic-drm improvements + new pixel formats

2020-09-28 Thread Paul Cercueil
Hi, Le sam. 26 sept. 2020 à 20:25, Sam Ravnborg a écrit : Hi Paul. On Sat, Sep 26, 2020 at 07:04:54PM +0200, Paul Cercueil wrote: Hi, This is a V2 of my small patchset "Small improvements to ingenic-drm" that I sent about two weeks ago. In that time, I worked on new improvements, so I

[RESEND PATCH v5 1/2] dt-bindings: display: himax, hx8837: Add Himax HX8837 bindings

2020-09-28 Thread Lubomir Rintel
Himax HX8837 is a secondary display controller used to drive the panel on OLPC platforms. Signed-off-by: Lubomir Rintel Reviewed-by: Rob Herring --- Changes since v4: - Rob's Reviewed-by Changes since v3: - Moved to bindings/display/ - Added the ports - Converted to YAML - Removed Pavel's Ack,

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Thomas Zimmermann
Hi Am 26.09.20 um 18:42 schrieb Daniel Vetter: > On Fri, Sep 25, 2020 at 4:55 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 29.06.20 um 10:40 schrieb Daniel Vetter: >>> On Thu, Jun 25, 2020 at 02:00:03PM +0200, Thomas Zimmermann wrote: The memcpy's destination buffer might have a different p

Re: [PATCH 3/9] drm: Add simplekms driver

2020-09-28 Thread Thomas Zimmermann
Hi Am 25.09.20 um 17:14 schrieb Maxime Ripard: > Hi Thomas, > > On Fri, Sep 25, 2020 at 05:01:23PM +0200, Thomas Zimmermann wrote: + ARRAY_SIZE(simplekms_formats), + simplekms_format_modifiers, +

Re: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-09-28 Thread Geert Uytterhoeven
Hi Prabhakar, On Sun, Sep 27, 2020 at 10:04 PM Laurent Pinchart wrote: > On Sun, Sep 27, 2020 at 02:01:50PM +0100, Lad, Prabhakar wrote: > > On Mon, Aug 24, 2020 at 1:48 AM Laurent Pinchart wrote: > > > On Thu, Aug 13, 2020 at 03:00:41PM +0100, Lad Prabhakar wrote: > > > > The iwg21d comes with a

Re: [PATCH] drm/stm: dsi: Use dev_ based logging

2020-09-28 Thread Yannick FERTRE
On 9/25/20 2:02 PM, Joe Perches wrote: > On Fri, 2020-09-25 at 12:22 +0200, Yannick Fertre wrote: >> Standardize on the dev_ based logging and drop the include of drm_print.h. >> Remove useless dsi_color_from_mipi function. > [] >> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c >> b/drivers

Re: [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 08:50 schrieb Christian König: > Am 27.09.20 um 21:16 schrieb Sam Ravnborg: >> Hi Thomas. >> struct simap {     union {     void __iomem *vaddr_iomem;     void *vaddr;     };     bool is_iomem; }; Wh

Re: [PATCH] drm/stm: dsi: Use dev_ based logging

2020-09-28 Thread Yannick FERTRE
On 9/25/20 4:51 PM, Sam Ravnborg wrote: > Hi Yannick. > > On Fri, Sep 25, 2020 at 12:22:33PM +0200, Yannick Fertre wrote: >> Standardize on the dev_ based logging and drop the include of drm_print.h. > The patchs filas to drop the include mentioned here. > >> Remove useless dsi_color_from_mipi

[PATCH] drm/rockchip: Include for drm_gem_cm_vm_ops

2020-09-28 Thread Thomas Zimmermann
Include to get drm_gem_cma_vm_ops. Fallout from the recent conversion to GEM object functions. Signed-off-by: Thomas Zimmermann Reported-by: kernel test robot Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs") Cc: Thomas Zimmermann Cc: Daniel Vetter Cc: Christian König Cc:

[PATCH 0/2] drm/i915/jsl: Update JasperLake Voltage swing table

2020-09-28 Thread Tejas Upadhyay
Patch series covers following things: 1. Split and differentiate between EhlkhartLake and JasperLake platfrom 2. Update voltage swing table for eDP on JasperLake platform BSpec: 21257 Tejas Upadhyay (2): drm/i915/jsl: Split EHL/JSL platform info and PCI ids drm/i915/edp/jsl: Update vswing

[PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Tejas Upadhyay
Split the basic platform definition, macros, and PCI IDs to differentiate between EHL and JSL platforms. Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/i915_drv.h | 4 +++- drivers/gpu/drm/i915/i915_pci.c | 9 + drivers/gpu/drm/i915/intel_device_info.c | 1 + dr

[PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Tejas Upadhyay
JSL has update in vswing table for eDP BSpec: 21257 Signed-off-by: Tejas Upadhyay --- drivers/gpu/drm/i915/display/intel_ddi.c | 67 ++-- 1 file changed, 64 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/in

Re: [PATCH] drm/rockchip: Include for drm_gem_cm_vm_ops

2020-09-28 Thread Sam Ravnborg
Hi Thomas. On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote: > Include to get drm_gem_cma_vm_ops. Fallout > from the recent conversion to GEM object functions. > > Signed-off-by: Thomas Zimmermann > Reported-by: kernel test robot > Fixes: 0d590af3140d ("drm/rockchip: Convert to

Re: [PATCH 8/9] drm: Add infrastructure for platform devices

2020-09-28 Thread Thomas Zimmermann
Hi Am 29.06.20 um 11:27 schrieb Daniel Vetter: > On Thu, Jun 25, 2020 at 02:00:10PM +0200, Thomas Zimmermann wrote: >> Platform devices might operate on firmware framebuffers, such as VESA or >> EFI. Before a native driver for the graphics hardware can take over the >> device, it has to remove any

Re: [PATCH] drm/hisilicon: Using the to_hibmc_drm_private to convert

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 10:32 schrieb Tian Tao: > Using the to_hibmc_drm_private to convert over all uses of dev_private > over to the function, and fix a little formatting issue. Sounds strange to me. Maybe remove "over to the function" and it should be better. > > Signed-off-by: Tian Tao Reviewed

Re: [PATCH] drm/rockchip: Include for drm_gem_cm_vm_ops

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 10:40 schrieb Sam Ravnborg: > Hi Thomas. > On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote: >> Include to get drm_gem_cma_vm_ops. Fallout >> from the recent conversion to GEM object functions. >> >> Signed-off-by: Thomas Zimmermann >> Reported-by: kernel test

Re: [PATCH 8/9] drm: Add infrastructure for platform devices

2020-09-28 Thread Daniel Vetter
On Mon, Sep 28, 2020 at 10:40 AM Thomas Zimmermann wrote: > > Hi > > Am 29.06.20 um 11:27 schrieb Daniel Vetter: > > On Thu, Jun 25, 2020 at 02:00:10PM +0200, Thomas Zimmermann wrote: > >> Platform devices might operate on firmware framebuffers, such as VESA or > >> EFI. Before a native driver for

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Daniel Vetter
On Mon, Sep 28, 2020 at 9:22 AM Thomas Zimmermann wrote: > > Hi > > Am 26.09.20 um 18:42 schrieb Daniel Vetter: > > On Fri, Sep 25, 2020 at 4:55 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 29.06.20 um 10:40 schrieb Daniel Vetter: > >>> On Thu, Jun 25, 2020 at 02:00:03PM +0200, Thom

Re: [PATCH 1/2] drm/vc4: hdmi: Disable Wifi Frequencies

2020-09-28 Thread Daniel Vetter
On Mon, Sep 28, 2020 at 9:06 AM Maxime Ripard wrote: > > There's cross-talk on the RPi4 between the 2.4GHz channels used by the WiFi > chip and some resolutions, most notably 1440p at 60Hz. > > In such a case, we can either reject entirely the mode, or lower slightly > the pixel frequency to remov

[PATCH] drm: prime: Potential Oops in drm_gem_map_dma_buf()

2020-09-28 Thread Dan Carpenter
This code doesn't check if the call to ->get_sg_table() fails so it could dereference an error pointer and Oops. Fixes: c614d7e66c6a ("drm: remove prime sg_table caching") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/drm_prime.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 10:53 schrieb Daniel Vetter: > On Mon, Sep 28, 2020 at 9:22 AM Thomas Zimmermann wrote: >> >> Hi >> >> Am 26.09.20 um 18:42 schrieb Daniel Vetter: >>> On Fri, Sep 25, 2020 at 4:55 PM Thomas Zimmermann >>> wrote: Hi Am 29.06.20 um 10:40 schrieb Daniel Vetter

Re: [PATCH 8/9] drm: Add infrastructure for platform devices

2020-09-28 Thread Thomas Zimmermann
Hi Am 28.09.20 um 10:50 schrieb Daniel Vetter: > On Mon, Sep 28, 2020 at 10:40 AM Thomas Zimmermann > wrote: >> >> Hi >> >> Am 29.06.20 um 11:27 schrieb Daniel Vetter: >>> On Thu, Jun 25, 2020 at 02:00:10PM +0200, Thomas Zimmermann wrote: Platform devices might operate on firmware framebuff

Re: remove alloc_vm_area v2

2020-09-28 Thread Joonas Lahtinen
+ Dave and Daniel + Stephen Quoting Christoph Hellwig (2020-09-26 09:29:59) > On Fri, Sep 25, 2020 at 07:43:49PM -0700, Andrew Morton wrote: > > On Thu, 24 Sep 2020 15:58:42 +0200 Christoph Hellwig wrote: > > > > > this series removes alloc_vm_area, which was left over from the big > > > vmalloc

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Gerd Hoffmann
Hi, > > I don't quite remember where exactly this was implemented. It was not a > > shared buffer, though. IIRC the buffer allocation code in one of the > > libs rounded the size towards multiples of 64. I remember thinking that > > it was probably done for tiled rendering. Happens when running

Re: [External] Re: [PATCH 2/2] sched: mark PRINTK_DEFERRED_CONTEXT_MASK in __schedule()

2020-09-28 Thread Peter Zijlstra
On Mon, Sep 28, 2020 at 06:04:23PM +0800, Chengming Zhou wrote: > Well, you are lucky. So it's a problem in our printk implementation. Not lucky; I just kicked it in the groin really hard: git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git debug/experimental > The deadlock path i

Re: [PATCH] drm/rockchip: Include for drm_gem_cm_vm_ops

2020-09-28 Thread Sam Ravnborg
On Mon, Sep 28, 2020 at 10:48:31AM +0200, Thomas Zimmermann wrote: > Hi > > Am 28.09.20 um 10:40 schrieb Sam Ravnborg: > > Hi Thomas. > > On Mon, Sep 28, 2020 at 10:16:43AM +0200, Thomas Zimmermann wrote: > >> Include to get drm_gem_cma_vm_ops. Fallout > >> from the recent conversion to GEM objec

Re: [PATCH] drm: prime: Potential Oops in drm_gem_map_dma_buf()

2020-09-28 Thread Christian König
Hi Dan, Am 28.09.20 um 11:07 schrieb Dan Carpenter: This code doesn't check if the call to ->get_sg_table() fails so it could dereference an error pointer and Oops. Fixes: c614d7e66c6a ("drm: remove prime sg_table caching") Signed-off-by: Dan Carpenter this patch is based on outdated code, p

Re: [PATCH] mm: do not rely on mm == current->mm in __get_user_pages_locked

2020-09-28 Thread Chris Wilson
Quoting Jason A. Donenfeld (2020-09-28 11:35:07) > It seems likely this block was pasted from internal_get_user_pages_fast, > which is not passed an mm struct and therefore uses current's. But > __get_user_pages_locked is passed an explicit mm, and current->mm is not > always valid. This was hit wh

Re: [PATCH v3 0/4] dma-buf: Flag vmap'ed memory as system or I/O memory

2020-09-28 Thread Christian König
Am 28.09.20 um 09:37 schrieb Thomas Zimmermann: Hi Am 28.09.20 um 08:50 schrieb Christian König: Am 27.09.20 um 21:16 schrieb Sam Ravnborg: Hi Thomas. struct simap {     union {     void __iomem *vaddr_iomem;     void *vaddr;     };     bool is_iomem;

Re: [PATCH 05/18] ARM/dma-mapping: Switch to iommu_dma_ops

2020-09-28 Thread Marek Szyprowski
Hi Robin, On 20.08.2020 17:08, Robin Murphy wrote: > With the IOMMU ops now looking much the same shape as iommu_dma_ops, > switch them out in favour of the iommu-dma library, currently enhanced > with temporary workarounds that allow it to also sit underneath the > arch-specific API. With that in

Re: [PATCH v10 0/8] Asynchronous flip implementation for i915

2020-09-28 Thread Ville Syrjälä
On Mon, Sep 21, 2020 at 04:32:02PM +0530, Karthik B S wrote: > Without async flip support in the kernel, fullscreen apps where game > resolution is equal to the screen resolution, must perform an extra blit > per frame prior to flipping. > > Asynchronous page flips will also boost the FPS of Mesa

Re: [PATCH] drm/nouveau/kms/nv50-: Fix clock checking algorithm in nv50_dp_mode_valid()

2020-09-28 Thread Ville Syrjälä
On Tue, Sep 22, 2020 at 05:05:10PM -0400, Lyude Paul wrote: > While I thought I had this correct (since it actually did reject modes > like I expected during testing), Ville Syrjala from Intel pointed out > that the logic here isn't correct. max_clock refers to the max symbol > rate supported by th

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Tejas Upadhyay wrote: > Split the basic platform definition, macros, and PCI IDs to > differentiate between EHL and JSL platforms. > > Signed-off-by: Tejas Upadhyay > --- > drivers/gpu/drm/i915/i915_drv.h | 4 +++- > drivers/gpu/drm/i915/i915_pci.c | 9 +++

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Tejas Upadhyay wrote: > JSL has update in vswing table for eDP I've thought the TLA for Jasper Lake is JSP, not JSL. At least we have PCH_JSP for Jasper Lake PCH. > > BSpec: 21257 > Signed-off-by: Tejas Upadhyay > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 67 ++

Re: [PATCH 1/9] drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip()

2020-09-28 Thread Pekka Paalanen
On Mon, 28 Sep 2020 12:24:28 +0200 Gerd Hoffmann wrote: > Hi, > > > > I don't quite remember where exactly this was implemented. It was not a > > > shared buffer, though. IIRC the buffer allocation code in one of the > > > libs rounded the size towards multiples of 64. I remember thinking that

Re: [PATCH] mm: do not rely on mm == current->mm in __get_user_pages_locked

2020-09-28 Thread Peter Xu
On Mon, Sep 28, 2020 at 12:35:07PM +0200, Jason A. Donenfeld wrote: > It seems likely this block was pasted from internal_get_user_pages_fast, > which is not passed an mm struct and therefore uses current's. But > __get_user_pages_locked is passed an explicit mm, and current->mm is not > always val

Re: [PATCH] drm/amd/display: make two symbols static

2020-09-28 Thread Harry Wentland
On 2020-09-27 10:35 p.m., Jason Yan wrote: > This addresses the following sparse warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6: > warning: symbol 'dce110_set_cursor_position' was not declared. Should it > be static? > drivers/gpu/drm/amd/amdgpu/../displa

Re: [PATCH] drm/amd/display: make get_color_space_type() static

2020-09-28 Thread Harry Wentland
On 2020-09-27 10:36 p.m., Jason Yan wrote: > This addresses the following sparse warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_sequencer.c:180:26: > warning: symbol 'get_color_space_type' was not declared. Should it be > static? > If you have multiple fixes of the same or simi

Re: [PATCH] drm/amd/display: add debugfs entry for trigger_hotplug

2020-09-28 Thread Harry Wentland
On 2020-09-28 10:06 a.m., Jason Yan wrote: > ping... > Fix by YueHaibing is already merged for this: commit 73b1acd54e13686fbb002afdf892c670177f0c57 Author: YueHaibing Date: Thu Sep 10 11:13:52 2020 +0800 drm/amd/display: Create trigger_hotplug entry Add trigger_hotplug debugfs entr

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread James Ausmus
On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: > On Mon, 28 Sep 2020, Tejas Upadhyay > wrote: > > JSL has update in vswing table for eDP > > I've thought the TLA for Jasper Lake is JSP, not JSL. At least we have > PCH_JSP for Jasper Lake PCH. JSP == Point (the PCH), JSL == Lake -

Re: [PATCH v2 1/3] iommu/io-pgtable-arm: Support coherency for Mali LPAE

2020-09-28 Thread Will Deacon
On Tue, Sep 22, 2020 at 03:16:48PM +0100, Robin Murphy wrote: > Midgard GPUs have ACE-Lite master interfaces which allows systems to > integrate them in an I/O-coherent manner. It seems that from the GPU's > viewpoint, the rest of the system is its outer shareable domain, and so > even when snoop s

Re: [RFC PATCH v1 3/3] dt-binding: display: Require two rests on mantix panel

2020-09-28 Thread Guido Günther
Hi Thierry, On Mon, Sep 28, 2020 at 08:50:39AM +0200, Thierry Reding wrote: > On Thu, Sep 24, 2020 at 09:38:07PM +0200, Sam Ravnborg wrote: > > Hi Guido. > > > > On Mon, Sep 21, 2020 at 06:55:52PM +0200, Guido Günther wrote: > > > We need to reset both for the panel to show an image. > > > > > >

  1   2   >