Re: [PATCH 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge

2020-07-26 Thread Sam Ravnborg
Hi Marek. On Sat, Jul 25, 2020 at 11:14:56PM +0200, Marek Vasut wrote: > Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this > one is used in the Raspberry Pi 7" touchscreen display unit. > > Signed-off-by: Marek Vasut > To: dri-devel@lists.freedesktop.org > Cc: Eric Anholt > Cc: Rob H

Re: [PATCH 2/2] drm/bridge: tc358762: Add basic driver for Toshiba TC358762 DSI-to-DPI bridge

2020-07-26 Thread Sam Ravnborg
Hi Marek. On Sat, Jul 25, 2020 at 11:14:57PM +0200, Marek Vasut wrote: > Add very basic driver for Toshiba TC358762 DSI-to-DPI bridge, derived > from tc358764 driver and panel-raspberrypi-touchscreen. This driver is > meant to replace the panel-raspberrypi-touchscreen too, as the bridge > connecti

Re: [PATCH] [video/fbdev] mbxfb_remove: fix null pointer dereference

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 8:26 AM Gaurav Singh wrote: > > Function mbxfb_debugfs_remove() accesses fbi->par without NULL check, > hence do the NULL check in the caller mbxfb_remove(). ... > @@ -1012,11 +1012,10 @@ static int mbxfb_remove(struct platform_device *dev) > > write_reg_dly(SYSRS

Re: [PATCH] [video/fbdev] fb_flashcursor: Remove redundant null check

2020-07-26 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 8:17 AM Gaurav Singh wrote: > > ops cannot be NULL as its being accessed later without it's > checks. Remove the redundant NULL check. Commit message doesn't clarify why your fix is the correct one. Maybe it's the other way around, missed check in the rest of the code th

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-26 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 9:29 PM Melissa Wen wrote: > > On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen wrote: > > > > > No, this very first warning continues (only once) :( > > > From here (drm_crtc_vblank_on): > > > if (atomic_read(&vblank->refcount) != 0 || drm_vblank_offdelay == > > > 0)

Re: [PATCH v2 0/5] drm: rockchip: various ports for older VOPs

2020-07-26 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 8:48 PM Alex Bee wrote: > > > Am 25.07.20 um 17:54 schrieb Daniel Vetter: > > On Sat, Jul 25, 2020 at 3:52 PM Alex Bee wrote: > >> > >> Am 22.07.20 um 23:43 schrieb Daniel Vetter: > >>> On Wed, Jul 22, 2020 at 8:13 PM Alex Bee wrote: > Hi, > > this series m

Re: [PATCH 9/9] soc/qcom: Add REVID driver

2020-07-26 Thread Greg Kroah-Hartman
On Sun, Jul 26, 2020 at 01:12:06PM +0200, Konrad Dybcio wrote: > From: Xiaozhe Shi > > Add the REVID device driver. The REVID driver will print out the PMIC > revision at probe time. Why do we need this noise in the kernel log? > --- /dev/null > +++ b/drivers/soc/qcom/qpnp-revid.c > @@ -0,0 +1,

Re: [PATCH 9/9] soc/qcom: Add REVID driver

2020-07-26 Thread Greg Kroah-Hartman
On Sun, Jul 26, 2020 at 01:40:46PM +0200, Konrad Dybcio wrote: > >Horrible global symbol name. Who calls this? > > Welcome to development on qcom platforms :D Yeah, I have seen :( > >This is the last patch in > >the series, so if there is no user for this, please don't export it. > > Other dow

[PATCH] [video/fbdev] fb_flashcursor: Remove redundant null check

2020-07-26 Thread Gaurav Singh
ops cannot be NULL as its being accessed later without checks. Remove the redundant NULL check. Signed-off-by: Gaurav Singh --- drivers/video/fbdev/core/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.

[PATCH] [video/fbdev] mbxfb_remove: fix null pointer dereference

2020-07-26 Thread Gaurav Singh
Function mbxfb_debugfs_remove() accesses fbi->par without NULL check, hence do the NULL check in the caller mbxfb_remove(). Signed-off-by: Gaurav Singh --- drivers/video/fbdev/mbx/mbxfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/driv

[PATCH 7/9] drm/msm/mdp5: Add MDP5 configuration for SDM636/660

2020-07-26 Thread Konrad Dybcio
This commit adds support for the MDP5 IP on Snapdragon 636/660. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 105 +++ 1 file changed, 105 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_

[PATCH -next] drm: xlnx: Fix typo in parameter description

2020-07-26 Thread Wei Yongjun
Fix typo in parameter description. Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH 4/9] drm/msm/dsi: Add phy configuration for SDM630/636/660

2020-07-26 Thread Konrad Dybcio
These SoCs make use of the 14nm phy, but at different addresses than other 14nm units. Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/dsi.txt| 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + drivers/gp

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-26 Thread Paul Menzel
Dear Kees, Am 24.07.20 um 00:32 schrieb Kees Cook: On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: When amdgpu_dm_atomic_commit_tail is running in the workqueue, drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is running, causing a race condition where state

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-26 Thread Yongqiang Niu
On Thu, 2020-07-23 at 17:40 +0200, Matthias Brugger wrote: > > On 23/07/2020 04:03, Yongqiang Niu wrote: > > This patch add support for mediatek SOC MT8183 > > 1.ovl_2l share driver with ovl > > 2.rdma1 share drive with rdma0, but fifo size is different > > 3.add mt8183 mutex private data, and mms

[PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-26 Thread Roger Pau Monne
To be used in order to create foreign mappings. This is based on the ZONE_DEVICE facility which is used by persistent memory devices in order to create struct pages and kernel virtual mappings for the IOMEM areas of such devices. Note that on kernels without support for ZONE_DEVICE Xen will fallbac

Re: [PATCH 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge

2020-07-26 Thread Marek Vasut
On 7/26/20 9:06 AM, Sam Ravnborg wrote: > Hi Marek. Hi, > On Sat, Jul 25, 2020 at 11:14:56PM +0200, Marek Vasut wrote: >> Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this >> one is used in the Raspberry Pi 7" touchscreen display unit. [...] > This looks like a candidate for the simple

[PATCH 3/3] drm/panel: simple: Add DT bindings for Powertip PH800480T013

2020-07-26 Thread Marek Vasut
Add support for Powertip PH800480T013 800x480 parallel LCD, this one is used in the Raspberry Pi 7" touchscreen display unit. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Eric Anholt Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- drivers/gpu/drm/pane

[PATCH 9/9] soc/qcom: Add REVID driver

2020-07-26 Thread Konrad Dybcio
From: Xiaozhe Shi Add the REVID device driver. The REVID driver will print out the PMIC revision at probe time. Signed-off-by: Xiaozhe Shi [konradyb...@gmail.com: Fast-forward the driver from kernel 4.14 to 5.8, convert binding to yaml] Signed-off-by: Konrad Dybcio --- .../bindings/soc/qcom/q

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-26 Thread Paul Menzel
Dear Kees, Am 24.07.20 um 19:33 schrieb Kees Cook: On Fri, Jul 24, 2020 at 09:45:18AM +0200, Paul Menzel wrote: Am 24.07.20 um 00:32 schrieb Kees Cook: On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: As Linux 5.8-rc7 is going to be released this Sunday, I wonder, if commit 3202f

Re: [v7, PATCH 7/7] drm/mediatek: add support for mediatek SOC MT8183

2020-07-26 Thread Yongqiang Niu
On Sat, 2020-07-25 at 07:24 +0800, Chun-Kuang Hu wrote: > Hi Yongqiang: > > Yongqiang Niu 於 2020年7月23日 週四 上午10:15寫道: > > > > This patch add support for mediatek SOC MT8183 > > 1.ovl_2l share driver with ovl > > I think this is done in [1], [2], [3], this patch just add the support > of mt8183-ov

[PATCH -next] vc: Fix build errors

2020-07-26 Thread Ming Li
Build errors are seen on MIPS platforms because of vc state separation and the following build erros were reported. ../linux/drivers/video/console/newport_con.c: In function ‘newport_clear’: ../linux/drivers/video/console/newport_con.c:365:15: error: ‘struct vc_data’ has no member named ‘vc_color’

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-26 Thread Mika Westerberg
On Thu, Jul 23, 2020 at 10:30:58PM +0200, Karol Herbst wrote: > On Wed, Jul 22, 2020 at 11:25 AM Mika Westerberg > wrote: > > > > On Tue, Jul 21, 2020 at 01:37:12PM -0500, Patrick Volkerding wrote: > > > On 7/21/20 10:27 AM, Mika Westerberg wrote: > > > > On Tue, Jul 21, 2020 at 11:01:55AM -0400,

[PATCH 2/2] drm/bridge: tc358762: Add basic driver for Toshiba TC358762 DSI-to-DPI bridge

2020-07-26 Thread Marek Vasut
Add very basic driver for Toshiba TC358762 DSI-to-DPI bridge, derived from tc358764 driver and panel-raspberrypi-touchscreen. This driver is meant to replace the panel-raspberrypi-touchscreen too, as the bridge connection can be described in DT too. Signed-off-by: Marek Vasut To: dri-devel@lists.

[PATCH] drm/sun4i: mixer: Enable register value caching

2020-07-26 Thread Jernej Skrabec
It was discovered in the past by Ondrej Jirman that mixer register read may occasionally return wrong value, most likely zero. It turns out that all mixer units are affected by this issue. This becomes especially obvious with applications like video player. After a few minutes of a playback visual

Re: [PATCH 5/5] drm: rockchip: use overlay windows as such

2020-07-26 Thread Paolo Sabatino
On 18/07/20 22:03, Alex Bee wrote: static const int rk3188_vop_intrs[] = { @@ -980,7 +980,7 @@ static const struct vop_win_data rk3228_vop_win_data[] = { { .base = 0x00, .phy = &rk3288_win01_data, .type = DRM_PLANE_TYPE_PRIMARY }, { .base = 0x40, .phy = &rk3288_win01_d

Re: [PATCH 9/9] soc/qcom: Add REVID driver

2020-07-26 Thread Konrad Dybcio
Hi Greg, thanks for your review! >Why do we need this noise in the kernel log? I guess it could be left there as a debug print? Knowing your hardware revision seems like a good, but yeah, not a necessary thing. >You can drop the GPL boilerplate text and add a proper SPDX line at the >top. Seems

Re: [PATCH 2/2] drm/bridge: tc358762: Add basic driver for Toshiba TC358762 DSI-to-DPI bridge

2020-07-26 Thread Marek Vasut
On 7/26/20 9:15 AM, Sam Ravnborg wrote: > Hi Marek. Hi, > On Sat, Jul 25, 2020 at 11:14:57PM +0200, Marek Vasut wrote: >> Add very basic driver for Toshiba TC358762 DSI-to-DPI bridge, derived >> from tc358764 driver and panel-raspberrypi-touchscreen. This driver is >> meant to replace the panel-r

[PATCH 1/9] clk: qcom: gcc-sdm660: Add missing modem reset

2020-07-26 Thread Konrad Dybcio
This will be required in order to support the modem upstream. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sdm660.c | 1 + include/dt-bindings/clock/qcom,gcc-sdm660.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc

Re: [PATCH] newport_con: vc_color is now in state

2020-07-26 Thread Sergei Shtylyov
On 24.07.2020 9:27, Jiri Slaby wrote: Since commit 28bc24fc46f9 (vc: separate state), vc->vc_color is known as Cgit says "Bad object id: 28bc24fc46f9" (in Linus' repo). Also, you should enclose the commit summary in (""), not just ()... vc->state.color. Somehow both me and 0-day bot misse

Re: [PATCH v2 0/5] drm: rockchip: various ports for older VOPs

2020-07-26 Thread Alex Bee
Am 25.07.20 um 17:54 schrieb Daniel Vetter: On Sat, Jul 25, 2020 at 3:52 PM Alex Bee wrote: Am 22.07.20 um 23:43 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 8:13 PM Alex Bee wrote: Hi, this series mainly ports existining functionality to older SoCs - most importantly enables alpha ble

[PATCH] video: fbdev: added driver for sharp memory lcd displays

2020-07-26 Thread Rodrigo Alencar
The supported displays are ls027b7dh01 (tested), ls044q7dh01, ls013b7dh05, ls013b7dh03 Signed-off-by: Rodrigo Alencar <455.rodrigo.alen...@gmail.com> --- .../devicetree/bindings/display/smemlcdfb.txt | 46 ++ drivers/video/fbdev/Kconfig | 14 + drivers/video/fbdev/Makefile

[PATCH 1/2] dt-bindings: Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge

2020-07-26 Thread Marek Vasut
Add DT bindings for Toshiba TC358762 DSI-to-DPI bridge, this one is used in the Raspberry Pi 7" touchscreen display unit. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Eric Anholt Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- .../display/bridge/toshi

Re: [v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-26 Thread Yongqiang Niu
On Thu, 2020-07-23 at 11:32 +0200, Enric Balletbo Serra wrote: > Hi Yongqiang Niu, > > Thank you for your patch. > > Missatge de Yongqiang Niu del dia dj., 23 > de jul. 2020 a les 4:05: > > > > add mmsys private data > > > > I think this change requires a better explanation of what you are > do

[PATCH 0/9] SDM630/36/60 driver enablement

2020-07-26 Thread Konrad Dybcio
Hi! This series brings most of the changes that have been brought to sdm630/636/660 SoCs apart from device tree part (I cannot add anything unless some [1] smmu quirks are merged.. blame qcom!) So far, the platform is shaping up nicely, though some peripherals seem to be living their own lives (I

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-26 Thread Duncan
On Sat, 25 Jul 2020 03:03:52 + Mazin Rezk wrote: > > Am 24.07.20 um 19:33 schrieb Kees Cook: > > > > > There was a fix to disable the async path for this driver that > > > worked around the bug too, yes? That seems like a safer and more > > > focused change that doesn't revert the SLUB defe

[PATCH 5/9] drm/msm/mdp5: Add MDP5 configuration for SDM630

2020-07-26 Thread Konrad Dybcio
This commit adds support for the MDP5 IP on Snapdragon 630. The configuration is different from SDM660's, as the latter one has two DSI outputs. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 93 1 file changed, 93 insertions(+) diff --git a

[PATCH 6/9] drm/msm/dsi: Add DSI configuration for SDM660

2020-07-26 Thread Konrad Dybcio
This also applies to sdm630/636 and their SDA counterparts. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 + drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/dr

[PATCH 1/3] dt-bindings: Add vendor prefix for Powertip

2020-07-26 Thread Marek Vasut
The Powertip Tech. Corp. is an LCD panel manufacturer. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Eric Anholt Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions

[PATCH 2/3] dt-bindings: Add DT bindings for Powertip PH800480T013

2020-07-26 Thread Marek Vasut
Add DT bindings for Powertip PH800480T013 800x480 parallel LCD, this one is used in the Raspberry Pi 7" touchscreen display unit. Signed-off-by: Marek Vasut To: dri-devel@lists.freedesktop.org Cc: Eric Anholt Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org --- .../panel/powert

[PATCH 8/9] clk: qcom: gcc-sdm660: Fix up gcc_mss_mnoc_bimc_axi_clk

2020-07-26 Thread Konrad Dybcio
Add missing halt_check, hwcg_reg and hwcg_bit properties. These were likely omitted when porting the driver upstream. Signed-off-by: Konrad Dybcio --- drivers/clk/qcom/gcc-sdm660.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc-sdm660.

[PATCH 3/9] drivers: usb: dwc3-qcom: Add sdm660 compatible

2020-07-26 Thread Konrad Dybcio
Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 + drivers/usb/dwc3/dwc3-qcom.c | 1 + 2 files changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qco

Re: [v7, PATCH 2/7] mtk-mmsys: add mmsys private data

2020-07-26 Thread Yongqiang Niu
On Sat, 2020-07-25 at 10:11 +0800, Chun-Kuang Hu wrote: > Hi, Yongqiang: > > Yongqiang Niu 於 2020年7月23日 週四 上午10:05寫道: > > > > add mmsys private data > > > > Feature: drm/mediatek > > Signed-off-by: Yongqiang Niu > > --- > > drivers/soc/mediatek/Makefile | 1 + > > drivers/soc/medi

[PATCH 2/9] phy: qcom-qusb2: Add support for SDM630/660

2020-07-26 Thread Konrad Dybcio
QUSB on these SoCs actually uses *almost* the same configuration that msm8996 does, so we can reuse the phy_cfg from there with just a single change (se clock scheme). Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 1 + drivers/phy/qualcomm/phy-qcom-

Re: [PATCH v2 0/5] drm: rockchip: various ports for older VOPs

2020-07-26 Thread Alex Bee
Am 22.07.20 um 23:43 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 8:13 PM Alex Bee wrote: Hi, this series mainly ports existining functionality to older SoCs - most importantly enables alpha blending for RK3036, RK3066, RK3126 and RK3188. Besides that, it also changes the window type from

Re: [PATCH v6 0/3] Add LT9611 DSI to HDMI bridge

2020-07-26 Thread Sam Ravnborg
Hi Vinod. On Thu, Jul 23, 2020 at 10:04:39PM +0530, Vinod Koul wrote: > Hi, > > This series adds driver and bindings for Lontium LT9611 bridge chip which > takes MIPI DSI as input and HDMI as output. > > This chip can be found in 96boards RB3 platform [1] commonly called DB845c. > > [1]: https:

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions v2

2020-07-26 Thread Sierra Guiza, Alejandro (Alex)
On 7/24/2020 10:01 AM, Felix Kuehling wrote: Am 2020-07-24 um 7:56 a.m. schrieb Christian König: We can't pipeline that during eviction because the memory needs to be available immediately. v2: fix how we cleanup the BOs resources Signed-off-by: Christian König Reviewed-by: Felix Kuehling

Re: [PATCH] drm/panel: Fix auo, kd101n80-45na horizontal noise on edges of panel

2020-07-26 Thread Sam Ravnborg
On Tue, Jul 14, 2020 at 08:33:32PM +0800, Jitao Shi wrote: > Fine tune the HBP and HFP to avoid the dot noise on the left and right edges. > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff -

Re: [PATCH] drm: panel: simple: Delay HPD checking on boe_nv133fhm_n61 for 15 ms

2020-07-26 Thread Sam Ravnborg
On Thu, Jul 16, 2020 at 01:21:22PM -0700, Douglas Anderson wrote: > On boe_nv133fhm_n62 (and presumably on boe_nv133fhm_n61) a scope shows > a small spike on the HPD line right when you power the panel on. The > picture looks something like this: > > +

Re: [PATCH v1 0/1] drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

2020-07-26 Thread Sam Ravnborg
Hi Guido. On Sat, Jul 18, 2020 at 08:26:36PM +0200, Guido Günther wrote: > > We don't create a connector but let panel_bridge handle that so there's > no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > This was prompted by Sam in > https://lore.kernel.org/dri-devel/20200718115734.ga2989..

Re: [PATCH] drm/mcde: Fix stability issue

2020-07-26 Thread Sam Ravnborg
Hi Linus. On Sun, Jul 19, 2020 at 01:33:22AM +0200, Linus Walleij wrote: > Whenener a display update was sent, apart from updating s/Whenener/Whenever > the memory base address we called mcde_display_send_one_frame() ^ insert comma? > which also sent a command to the disp

Re: [PATCH] drm/bridge/adv7511: set the bridge type properly

2020-07-26 Thread Sam Ravnborg
On Mon, Jul 20, 2020 at 03:42:27PM +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > After the drm_bridge_connector_init() helper function has been added, the ADV > driver has been changed accordingly. However, the 'type' field of the bridge > structure was left unset, which makes the hel

Re: [PATCH v10 08/13] drm/msm: Add a context pointer to the submitqueue

2020-07-26 Thread Rob Clark
On Mon, Jul 20, 2020 at 8:41 AM Jordan Crouse wrote: > > Each submitqueue is attached to a context. Add a pointer to the > context to the submitqueue at create time and refcount it so > that it stays around through the life of the queue. > > GPU submissions can access the active context via the su

Re: [PATCH] drm: of: Fix double-free bug

2020-07-26 Thread Sam Ravnborg
Hi Biju On Thu, Jul 23, 2020 at 12:10:54PM +0100, Biju Das wrote: > Fix double-free bug in the error path. > > Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order") > Reported-by: Pavel Machek > Signed-off-by: Biju Das > Cc: sta...@vger.kernel.org Thanks, applied to drm-mi

Re: [PATCH] video: fbdev: added driver for sharp memory lcd displays

2020-07-26 Thread Sam Ravnborg
Hi Rodrigo. On Fri, Jul 24, 2020 at 05:34:04PM -0300, Rodrigo Alencar wrote: > The supported displays are ls027b7dh01 (tested), ls044q7dh01, > ls013b7dh05, ls013b7dh03 > > Signed-off-by: Rodrigo Alencar <455.rodrigo.alen...@gmail.com> Thanks for submitting this driver. Unfortunately I have some

Re: [PATCH 1/2] drm/fourcc: fix Amlogic Video Framebuffer Compression macro

2020-07-26 Thread Sam Ravnborg
Hi Neil. On Thu, Jul 23, 2020 at 11:05:50AM +0200, Neil Armstrong wrote: > Fix the Amlogic Video Framebuffer Compression modifier macro to > correctly add the layout options, a pair of parenthesis was missing. > > Fixes: d6528ec88309 ("drm/fourcc: Add modifier definitions for describing > Amlogi

Re: [PATCH v7 1/3] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings

2020-07-26 Thread Sam Ravnborg
Hi Swapnil. On Wed, Jul 22, 2020 at 09:40:38AM +0200, Swapnil Jakhade wrote: > From: Yuti Amonkar > > Document the bindings used for the Cadence MHDP DPI/DP bridge in > yaml format. > > Signed-off-by: Yuti Amonkar > Signed-off-by: Swapnil Jakhade > Reviewed-by: Rob Herring > Reviewed-by: Lau

Re: [PATCH v7 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-07-26 Thread Sam Ravnborg
Hi Swapnil Thanks for submitting this driver. A few highlevel things. New bridge drivers shall be prepare for use in a chained bridge driver setup. This prompts you to add the following: - Reelvant bridge operations I noticed at least get_edid, and detect seems applicable. - Support the

Re: [PATCH v7 3/3] drm: bridge: cdns-mhdp: Add j721e wrapper

2020-07-26 Thread Sam Ravnborg
Hi Swapnil Small nits in the following. Sam On Wed, Jul 22, 2020 at 09:40:40AM +0200, Swapnil Jakhade wrote: > Add j721e wrapper for mhdp, which sets up the clock and data muxes. > > Signed-off-by: Jyri Sarha > Signed-off-by: Yuti Amonkar > Signed-off-by: Swapnil Jakhade > Reviewed-b

Re: [PATCH] drm/mcde: Fix stability issue

2020-07-26 Thread Stephan Gerhold
On Sun, Jul 19, 2020 at 01:33:22AM +0200, Linus Walleij wrote: > Whenener a display update was sent, apart from updating > the memory base address we called mcde_display_send_one_frame() > which also sent a command to the display requesting the TE IRQ > and enabling the FIFO. > > When continous up

Re: [PATCH v2 11/22] drm: mxsfb: Stop using DRM simple display pipeline helper

2020-07-26 Thread Laurent Pinchart
Hi Stefan, On Fri, Jul 17, 2020 at 05:06:55AM +0300, Laurent Pinchart wrote: > On Thu, Jul 09, 2020 at 12:25:42PM +0200, Stefan Agner wrote: > > On 2020-06-16 03:50, Laurent Pinchart wrote: > >> On Thu, Jun 11, 2020 at 09:33:11PM +0200, Stefan Agner wrote: > >>> On 2020-05-30 05:10, Laurent Pincha

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #95 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- Created attachment 290583 --> https://bugzilla.kernel.org/attachment.cgi?id=290583&action=edit 0001-drm-amd-display-Force-add-all-CRTCs-to-state-when-us.patch So the seq

[PATCH v9 08/12] device core: Introduce DMA range map, supplanting dma_pfn_offset

2020-07-26 Thread Jim Quinlan
The new field 'dma_range_map' in struct device is used to facilitate the use of single or multiple offsets between mapping regions of cpu addrs and dma addrs. It subsumes the role of "dev->dma_pfn_offset" which was only capable of holding a single uniform offset and had no region bounds checking.

[PATCH v9 00/12] PCI: brcmstb: enable PCIe for STB chips

2020-07-26 Thread Jim Quinlan
Patchset Summary: Enhance a PCIe host controller driver. Because of its unusual design we are foced to change dev->dma_pfn_offset into a more general role allowing multiple offsets. See the 'v1' notes below for more info. NOTE: ChristophH wanted the dma_set_offset_range() function

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-26 Thread Mazin Rezk
On Saturday, July 25, 2020 12:59 AM, Duncan <1i5t5.dun...@cox.net> wrote: > On Sat, 25 Jul 2020 03:03:52 + > Mazin Rezk mn...@protonmail.com wrote: > > > > Am 24.07.20 um 19:33 schrieb Kees Cook: > > > > > > > There was a fix to disable the async path for this driver that > > > > worked around

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-26 Thread Mazin Rezk
On Friday, July 24, 2020 5:19 PM, Paul Menzel wrote: > Dear Kees, > > Am 24.07.20 um 19:33 schrieb Kees Cook: > > > On Fri, Jul 24, 2020 at 09:45:18AM +0200, Paul Menzel wrote: > > > > > Am 24.07.20 um 00:32 schrieb Kees Cook: > > > > > > > On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wro

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-26 Thread Mazin Rezk
On Thursday, July 23, 2020 6:57 PM, Mazin Rezk wrote: > It seems that I spoke too soon. I ran the system for another hour after > submitting the patch and the bug just occurred. :/ > > Sadly, that means the bug isn't really fixed and that I have to go > investigate further. > > At the very least,

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #96 from mn...@protonmail.com --- (In reply to Nicholas Kazlauskas from comment #95) > Created attachment 290583 [details] > 0001-drm-amd-display-Force-add-all-CRTCs-to-state-when-us.patch > > So the sequence looks like the following:

Re: [PATCH v3 13/21] drm/bridge: megachips: add helper to create connector

2020-07-26 Thread Sam Ravnborg
On Sat, Jul 11, 2020 at 01:34:30AM +0300, Laurent Pinchart wrote: > Hi Sam, > > Thank you for the patch. > > On Fri, Jul 03, 2020 at 09:24:09PM +0200, Sam Ravnborg wrote: > > Factor out connector creation to a small helper function. > > > > Signed-off-by: Sam Ravnborg > > Cc: Peter Senna Tschud

[PATCH v4 09/15] drm/bridge: megachips: add helper to create connector

2020-07-26 Thread Sam Ravnborg
Factor out connector creation to a small helper function. Signed-off-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Cc: Peter Senna Tschudin Cc: Martin Donnelly Cc: Martyn Welch Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec --- .../bridge

[PATCH v4 07/15] drm/bridge: tc358767: add drm_panel_bridge support

2020-07-26 Thread Sam Ravnborg
With the bridge operations implemented the last step to prepare this driver for a chained setup is the use of the bridge panel driver. The bridge panel driver is only used when a prot@2 is present in the DT. So when the display driver request a connector support both situations: - connector create

[PATCH v4 12/15] drm/bridge: megachips: add get_edid bridge operation

2020-07-26 Thread Sam Ravnborg
To prepare for a chained bridge setup add support for the get_edid bridge operation. There is no need for a copy of the edid - so drop the pointer to the copy. v2: - Fix so we do not leak memory (Laurent) Signed-off-by: Sam Ravnborg Cc: Peter Senna Tschudin Cc: Martin Donnelly Cc: Martyn Wel

[PATCH v4 0/15] drm/bridge: support chained bridges + panel updates

2020-07-26 Thread Sam Ravnborg
The objective is that all bridge drivers shall support a chained setup connector creation is moved to the display drivers. This is just one step on this path. The general approach for the bridge drivers: - Introduce bridge operations - Introduce use of panel bridge and make connector creation opti

[PATCH v4 06/15] drm/bridge: tc358767: add get_edid bridge operation

2020-07-26 Thread Sam Ravnborg
Prepare for chained bridge with the addition of get_edid support. v2: - Fixed handling of edid storage (Laurent) Signed-off-by: Sam Ravnborg Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec --- drivers/gpu/drm/bridge/tc358767.c | 34 +

[PATCH v4 14/15] drm/bridge: nxp-ptn3460: add get_edid bridge operation

2020-07-26 Thread Sam Ravnborg
Add the get_edid() bridge operation to prepare for use as a chained bridge. Add helper function that is also used by the connector. v2: - Fix memory leak (Laurent) - Do not save a copy of edid, read it when needed Signed-off-by: Sam Ravnborg Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent

[PATCH v4 10/15] drm/bridge: megachips: get drm_device from bridge

2020-07-26 Thread Sam Ravnborg
Fix so drm_device is read from the bridge. This is a preparation for the connector being optional. Signed-off-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Cc: Peter Senna Tschudin Cc: Martin Donnelly Cc: Martyn Welch Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Kar

[PATCH v4 13/15] drm/bridge: megachips: make connector creation optional

2020-07-26 Thread Sam Ravnborg
Make the connector creation optional to enable usage of the megachips-stdp-ge-b850v3-fw bridge with the DRM bridge connector helper. v2: - Set bridge.type to DRM_MODE_CONNECTOR_DisplayPort Signed-off-by: Sam Ravnborg Cc: Peter Senna Tschudin Cc: Martin Donnelly Cc: Martyn Welch Cc: Andr

[PATCH v4 03/15] drm/bridge: tc358764: drop drm_connector_(un)register

2020-07-26 Thread Sam Ravnborg
Drop drm_connector handling that is not needed: - drm_dev_register() in the display controller driver takes care of registering connectors. So the call to drm_connector_register() call is not needed in the bridge driver. - Use of drm_connector_unregister() is only required for drivers that

[PATCH v4 04/15] drm/bridge: tc358764: add drm_panel_bridge support

2020-07-26 Thread Sam Ravnborg
Prepare the tc358764 bridge driver for use in a chained setup by replacing direct use of drm_panel with drm_panel_bridge support. The bridge panel will use the connector type reported by the panel, where the connector for this driver hardcodes DRM_MODE_CONNECTOR_LVDS. The tc358764 did not any add

[PATCH v4 08/15] drm/bridge: parade-ps8622: add drm_panel_bridge support

2020-07-26 Thread Sam Ravnborg
Prepare the bridge driver for use in a chained setup by replacing direct use of drm_panel with drm_panel_bridge support. The connecter is now either created by the panel bridge or the display driver. So all code for connector creation in this driver is no longer relevant and thus dropped. The con

[PATCH v4 02/15] drm/panel: panel-simple: add default connector_type

2020-07-26 Thread Sam Ravnborg
All panels shall report a connector type. panel-simple has a lot of panels with no connector_type, and for these fall back to DPI as the default. v2: - Rebased on top of validation of panel description Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Thierry Reding Cc: Sam Ravnborg ---

[PATCH v4 11/15] drm/bridge: megachips: enable detect bridge operation

2020-07-26 Thread Sam Ravnborg
To prepare for use in a chained bridge setup enable the detect operation. Signed-off-by: Sam Ravnborg Reviewed-by: Laurent Pinchart Cc: Peter Senna Tschudin Cc: Martin Donnelly Cc: Martyn Welch Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec

[PATCH v4 05/15] drm/bridge: tc358767: add detect bridge operation

2020-07-26 Thread Sam Ravnborg
Prepare the bridge driver for chained operation by adding support for the detect operation. v2: - Do not announce detect operation if there is no hpd pin (Laurent) Signed-off-by: Sam Ravnborg Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec --

[PATCH v4 15/15] drm/bridge: nxp-ptn3460: add drm_panel_bridge support

2020-07-26 Thread Sam Ravnborg
Prepare the bridge driver for use in a chained setup. - Replacing direct use of drm_panel with drm_panel_bridge support. - Make the connector creation optional Note: the bridge panel will use the connector type from the panel. v2: - Use panel_bridge for local variable name to align with other

[PATCH v4 01/15] drm/panel: panel-simple: validate panel description

2020-07-26 Thread Sam Ravnborg
Warn if we detect a panel with incomplete/wrong description. This is inspired by a similar patch by Laurent that introduced checks for LVDS panels - this extends the checks to the remaining type of connectors. This is known to warn for some of the existing panels but added despite this as we need

Re: [PATCH 2/2] drm/bridge: tc358762: Add basic driver for Toshiba TC358762 DSI-to-DPI bridge

2020-07-26 Thread Sam Ravnborg
Hi Marek. On Sun, Jul 26, 2020 at 12:17:46PM +0200, Marek Vasut wrote: > On 7/26/20 9:15 AM, Sam Ravnborg wrote: > > Hi Marek. > > Hi, > > > On Sat, Jul 25, 2020 at 11:14:57PM +0200, Marek Vasut wrote: > >> Add very basic driver for Toshiba TC358762 DSI-to-DPI bridge, derived > >> from tc358764

Re: [PATCH v4 01/15] drm/panel: panel-simple: validate panel description

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:10PM +0200, Sam Ravnborg wrote: > Warn if we detect a panel with incomplete/wrong description. > This is inspired by a similar patch by Laurent that introduced checks > for LVDS panels - this extends the checks to the remaining type o

Re: [PATCH v4 02/15] drm/panel: panel-simple: add default connector_type

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:11PM +0200, Sam Ravnborg wrote: > All panels shall report a connector type. > panel-simple has a lot of panels with no connector_type, > and for these fall back to DPI as the default. > > v2: > - Rebased on top of validation of pan

Re: [PATCH v4 05/15] drm/bridge: tc358767: add detect bridge operation

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:14PM +0200, Sam Ravnborg wrote: > Prepare the bridge driver for chained operation by adding > support for the detect operation. > > v2: > - Do not announce detect operation if there is no hpd pin (Laurent) > > Signed-off-by: Sam R

Re: [PATCH v4 04/15] drm/bridge: tc358764: add drm_panel_bridge support

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:13PM +0200, Sam Ravnborg wrote: > Prepare the tc358764 bridge driver for use in a chained setup by > replacing direct use of drm_panel with drm_panel_bridge support. > > The bridge panel will use the connector type reported by the pa

Re: [PATCH v4 06/15] drm/bridge: tc358767: add get_edid bridge operation

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:15PM +0200, Sam Ravnborg wrote: > Prepare for chained bridge with the addition of > get_edid support. > > v2: > - Fixed handling of edid storage (Laurent) > > Signed-off-by: Sam Ravnborg > Cc: Andrzej Hajda > Cc: Neil Armstrong

Re: [PATCH v4 07/15] drm/bridge: tc358767: add drm_panel_bridge support

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:16PM +0200, Sam Ravnborg wrote: > With the bridge operations implemented the last step to prepare > this driver for a chained setup is the use of the bridge panel driver. > > The bridge panel driver is only used when a prot@2 is pres

Re: [PATCH v4 08/15] drm/bridge: parade-ps8622: add drm_panel_bridge support

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:17PM +0200, Sam Ravnborg wrote: > Prepare the bridge driver for use in a chained setup by > replacing direct use of drm_panel with drm_panel_bridge support. > > The connecter is now either created by the panel bridge or the display >

Re: [PATCH v4 12/15] drm/bridge: megachips: add get_edid bridge operation

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:21PM +0200, Sam Ravnborg wrote: > To prepare for a chained bridge setup add support for the > get_edid bridge operation. > There is no need for a copy of the edid - so drop > the pointer to the copy. > > v2: > - Fix so we do not le

Re: [PATCH v4 13/15] drm/bridge: megachips: make connector creation optional

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:22PM +0200, Sam Ravnborg wrote: > Make the connector creation optional to enable usage of the > megachips-stdp-ge-b850v3-fw bridge with the DRM bridge connector > helper. > > v2: > - Set bridge.type to DRM_MODE_CONNECTOR_Displa

Re: [PATCH v4 14/15] drm/bridge: nxp-ptn3460: add get_edid bridge operation

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:23PM +0200, Sam Ravnborg wrote: > Add the get_edid() bridge operation to prepare for > use as a chained bridge. > Add helper function that is also used by the connector. > > v2: > - Fix memory leak (Laurent) > - Do not save a cop

Re: [PATCH v4 15/15] drm/bridge: nxp-ptn3460: add drm_panel_bridge support

2020-07-26 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Jul 26, 2020 at 10:33:24PM +0200, Sam Ravnborg wrote: > Prepare the bridge driver for use in a chained setup. > > - Replacing direct use of drm_panel with drm_panel_bridge support. > - Make the connector creation optional > > Note: the bridge panel will

[Bug 204181] NULL pointer dereference regression in amdgpu

2020-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 mn...@protonmail.com changed: What|Removed |Added CC||mn...@protonmail.com --- Comment #

[Bug 204181] NULL pointer dereference regression in amdgpu

2020-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 --- Comment #67 from mn...@protonmail.com --- (In reply to mnrzk from comment #66) > Created attachment 290589 [details] > drm/amd/display: Clear dm_state for fast updates > > Alright, the bug patch I mentioned in the last comment seems to be goo

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 mn...@protonmail.com changed: What|Removed |Added Attachment #290485|0 |1 is obsolete|

  1   2   >