Re: [PATCH] drm/sun41: Fix incorrect return type

2018-07-13 Thread Maxime Ripard
Hi Sean, On Thu, Jul 12, 2018 at 11:50:28AM -0400, Sean Paul wrote: > We're returning -errno instead of ERR_PTR(-errno). > > Fixes: af11942ee44e ("drm/sun4i: tcon-top: Cleanup clock handling") > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Maxime Ripard > Cc: dri-devel@lists.freedesktop.org > C

[PATCH] ARM: dts: imx6sl: Add vivante gpu nodes

2018-07-13 Thread Leonard Crestez
The imx6sl soc has gpu_2d and gpu_vg, no 3d support: etnaviv-gpu 220.gpu: model: GC320, revision: 5007 etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 The IP blocks are close enough to supported hardware that they "just work" with etnaviv and x11. Signed-off-by: Leonard Crestez ---

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-13 Thread Marek Vasut
On 07/12/2018 03:03 PM, Leonard Crestez wrote: > On Thu, 2018-07-12 at 11:21 +0200, Stefan Agner wrote: >> On 10.07.2018 11:11, Marek Vasut wrote: >>> On 07/10/2018 11:06 AM, Stefan Agner wrote: This is one of the situation where states quo is kinda the worst situation. Currentl

[PATCH 03/18] drm_property: change strncpy+truncation to strlcpy

2018-07-13 Thread Dominique Martinet
Using strlcpy fixes this new gcc warning: drivers/gpu/drm/drm_property.c: In function ‘drm_property_create’: drivers/gpu/drm/drm_property.c:125:2: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] strncpy(property->name, name, DRM_PROP_NAME_LEN);

Re: AMD graphics performance regression in 4.15 and later

2018-07-13 Thread Jean-Marc Valin
Hi Christian, Sorry for the delayed response, but I just thought I'd confirm that kernel 4.17 (4.17.3-100.fc27.x86_64 to be more precise) seems to be working fine for me, with no performance issue. Cheers, Jean-Marc On 04/09/2018 07:48 AM, Christian König wrote: > Am 06.04.2018 um 17:30

Re: [PATCH v2] console: Replace #if 1 with a bool to ignore

2018-07-13 Thread Petr Mladek
On Thu 2018-07-12 09:30:49, Steven Rostedt wrote: > On Thu, 12 Jul 2018 09:29:38 -0400 > Steven Rostedt wrote: > > > From: Steven Rostedt (VMware) > > > > There's been discussion on the fb list about the addition of > > WARN_CONSOLE_UNLOCKED() inside the fb code. The complaint is that when > >

Re: [PATCH 02/12] blk: use for_each_if

2018-07-13 Thread Jens Axboe
On 7/12/18 12:45 AM, Joe Perches wrote: > On Wed, 2018-07-11 at 20:50 +0200, Daniel Vetter wrote: >> On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: >>> On 7/11/18 10:45 AM, Tejun Heo wrote: On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > On Mon, Jul 09, 2018 at 10:36:40AM

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-13 Thread Leonard Crestez
On Thu, 2018-07-12 at 11:21 +0200, Stefan Agner wrote: > On 10.07.2018 11:11, Marek Vasut wrote: > > On 07/10/2018 11:06 AM, Stefan Agner wrote: > > > This is one of the situation where states quo is kinda the worst > > > situation. > > > > > > Currently imx_v6_v7_defconfig and mxs_defconfig actua

[PATCH 04/18] nouveau: change strncpy+truncation to strlcpy

2018-07-13 Thread Dominique Martinet
Generated by scripts/coccinelle/misc/strncpy_truncation.cocci Signed-off-by: Dominique Martinet --- Please see https://marc.info/?l=linux-kernel&m=153144450722324&w=2 (the first patch of the serie) for the motivation behind this patch drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 3 +-- 1 fil

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-13 Thread Dominique Martinet
Ville Syrjälä wrote on Thu, Jul 12, 2018: > On Wed, Jul 11, 2018 at 09:46:15AM +0200, Dominique Martinet wrote: > > This is effectively no-op as the next line writes a nul at the final > > What is "This". Please write self contained commit messages. This could either be 'this commit' as a whole o

[PATCH v3 1/1] drm/panel: Add support for Olimex LCD-OLinuXino panel

2018-07-13 Thread Stefan Mavrodiev
This patch adds Olimex Ltd. LCD-OLinuXino bridge panel driver. The panel is used with different LCDs (currently from 480x272 to 1280x800). Small EEPROM chip is used for identification, which holds some factory data and timing requirements. Signed-off-by: Stefan Mavrodiev --- Changes for v3: - C

Re: [Intel-gfx] [PATCH] i915/intel_tv_get_modes: fix strncpy truncation warning

2018-07-13 Thread Dominique Martinet
Ville Syrjälä wrote on Thu, Jul 12, 2018: > On Thu, Jul 12, 2018 at 03:55:26PM +0200, Dominique Martinet wrote: > > This could either be 'this commit' as a whole or if you look only at the > > commit message 'this strncpy fix' from the title (which is arguably the > > same), and both interpretation

[PULL] drm-intel-fixes

2018-07-13 Thread Rodrigo Vivi
Hi Dave, Things are still calm, but I'd like to add the GVT fix to this week pull for 4.18. Here goes drm-intel-fixes-2018-07-12: - GVT fix for KBL vGPU hang to update virtual register from LRI. - Fix hotplug irq ack on i965/g4x (Ville) There's a silent conflict with gvt-fixes and gvt-next, whic

Re: [PATCH 3/3] drm/scheduler: modify args of drm_sched_entity_init

2018-07-13 Thread Christian König
Am 12.07.2018 um 08:36 schrieb Nayan Deshmukh: replace run queue by a list of run queues and remove the sched arg as that is part of run queue itself Signed-off-by: Nayan Deshmukh Going over this I've found one more thing which needs to be fixed: [SNIP] diff --git a/drivers/gpu/drm/etnaviv/

Re: [PATCH 3/3] drm/scheduler: modify args of drm_sched_entity_init

2018-07-13 Thread Nayan Deshmukh
On Thu, Jul 12, 2018 at 11:21 PM Eric Anholt wrote: > > Nayan Deshmukh writes: > > diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c > > b/drivers/gpu/drm/scheduler/gpu_scheduler.c > > index 3dc1a4f07e3f..b2dbd1c1ba69 100644 > > --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c > > +++ b/driv

Re: [PATCH 3/3] drm/scheduler: modify args of drm_sched_entity_init

2018-07-13 Thread Christian König
Am 13.07.2018 um 09:20 schrieb Nayan Deshmukh: On Thu, Jul 12, 2018 at 11:21 PM Eric Anholt wrote: Nayan Deshmukh writes: diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 3dc1a4f07e3f..b2dbd1c1ba69 100644 --- a/drivers/gpu/drm/scheduler

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

2018-07-13 Thread Daniel Vetter
On Thu, Jul 12, 2018 at 03:14:57PM +0200, Marek Vasut wrote: > On 07/12/2018 03:03 PM, Leonard Crestez wrote: > > On Thu, 2018-07-12 at 11:21 +0200, Stefan Agner wrote: > >> On 10.07.2018 11:11, Marek Vasut wrote: > >>> On 07/10/2018 11:06 AM, Stefan Agner wrote: > This is one of the situation

[PULL] drm-misc-fixes

2018-07-13 Thread Maarten Lankhorst
Hi Dave, A single fix for building sun4i for v4.18-rc5. drm-misc-fixes-2018-07-13: Fixes for v4.18-rc5: - Single fix for a build error when the driver is builtin, but the backend is a loadable module. The following changes since commit 44f9a4b0dc7563669772198e5b226cab58a00167: drm/bridge/si

Re: More drm-panel help volunteers?

2018-07-13 Thread Daniel Vetter
On Wed, Jul 11, 2018 at 08:07:26PM +0200, Daniel Vetter wrote: > Hi all, > > I chatted a bit with Thierry about drm-panel, and state of things > still seems to be that when Thierry's on vacations/leave/busy patches > don't move. So I looked at people with a few patches who could be > volunteered t

Re: [PATCH] backlight: adp8860: Mark expected switch fall-through

2018-07-13 Thread Lee Jones
On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/video/backlight/adp8860_bl.c | 1 + > 1 file changed, 1 insertion(+) Applied,

[GIT PULL] Immutable branch between MFD and DRM/i915, Media and Platform due for the v4.19 merge window

2018-07-13 Thread Lee Jones
Enjoy! The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-i915-media-platform-v4.19 for you to fetch changes up to

[Bug 107082] With 4.18 rc kernel stop working video output on AMD GPU Vega 56

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107082 --- Comment #5 from Michel Dänzer --- (In reply to mikhail.v.gavrilov from comment #4) > The first that I did not like was that on the first monitor which was > connected via DisplayPort, the scaling setting was reset from 200% to 100%. Sounds

[Bug 107213] [amdgpu/DisplayPort] KDE Wayland session is segfaulting right after login

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107213 Michel Dänzer changed: What|Removed |Added CC||harry.wentl...@amd.com --- Comment #1 f

[PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters

2018-07-13 Thread Jim Qu
Signed-off-by: Jim Qu --- sound/pci/hda/hda_intel.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 1ae1850..e0064567 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -31,7 +31,7 @@

[PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread Jim Qu
On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio codec for HDMP/DP output. For some dGPU which is no output, audio codec usually is disabled. In currect HDA audio driver, it will set all codec as VGA_SWITCHEROO_DIS, the audio which is binded to U

[PATCH] drm/stm: Replace drm_dev_unref with drm_dev_put

2018-07-13 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann Acked-by: Philippe Cornu --- drivers/gpu/drm/stm/drv.c | 10 +- 1 file changed, 5

Re: More drm-panel help volunteers?

2018-07-13 Thread Lucas Stach
Hi Daniel, Am Mittwoch, den 11.07.2018, 20:07 +0200 schrieb Daniel Vetter: > Hi all, > > I chatted a bit with Thierry about drm-panel, and state of things > still seems to be that when Thierry's on vacations/leave/busy patches > don't move. So I looked at people with a few patches who could be >

Re: [PATCH] drm/sti: Replace drm_dev_unref with drm_dev_put

2018-07-13 Thread Benjamin Gaignard
2018-07-12 17:26 GMT+02:00 Thomas Zimmermann : > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > Signed-off-by: Thomas Zimmermann > Acked-by: Benjamin Gaignard App

Re: [PATCH] drm/stm: Replace drm_dev_unref with drm_dev_put

2018-07-13 Thread Benjamin Gaignard
2018-07-13 10:06 GMT+02:00 Thomas Zimmermann : > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > Signed-off-by: Thomas Zimmermann > Acked-by: Philippe Cornu Applie

Re: [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters

2018-07-13 Thread Lukas Wunner
On Fri, Jul 13, 2018 at 04:06:01PM +0800, Jim Qu wrote: > Signed-off-by: Jim Qu Empty commit message. Please add an explanation why the change is necessary so folks browsing the git history understand it's motivation. I think here the motivation is that the PCI class is sometimes PCI_CLASS_DISPL

Re: [alsa-devel] [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters

2018-07-13 Thread Takashi Iwai
On Fri, 13 Jul 2018 10:06:01 +0200, Jim Qu wrote: > > Signed-off-by: Jim Qu More explanations please. e.g. why is this needed? The code change itself looks good, but ... > @@ -31,7 +31,7 @@ > * CHANGES: > * > * 2004.12.01 Major rewrite by tiwai, merged the work of pshou > - * >

Re: More drm-panel help volunteers?

2018-07-13 Thread Daniel Vetter
On Fri, Jul 13, 2018 at 10:09 AM, Lucas Stach wrote: > Hi Daniel, > > Am Mittwoch, den 11.07.2018, 20:07 +0200 schrieb Daniel Vetter: >> Hi all, >> >> I chatted a bit with Thierry about drm-panel, and state of things >> still seems to be that when Thierry's on vacations/leave/busy patches >> don't

Re: [alsa-devel] [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread Takashi Iwai
On Fri, 13 Jul 2018 10:06:02 +0200, Jim Qu wrote: > > On modern laptop, there are more and more platforms > have two GPUs, and each of them maybe have audio codec > for HDMP/DP output. For some dGPU which is no output, > audio codec usually is disabled. > > In currect HDA audio driver, it will se

[PATCH] drm/hisilicon: Replace drm_dev_unref with drm_dev_put

2018-07-13 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++-- drivers/gpu/drm/hisilicon/ki

[Bug 107082] With 4.18 rc kernel stop working video output on AMD GPU Vega 56

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107082 --- Comment #6 from mikhail.v.gavri...@gmail.com --- (In reply to Michel Dänzer from comment #5) > > Sounds like a GNOME issue. The kernel driver doesn't do any implicit > scaling, it's all up to userspace. I don't believe that sshd can hang be

[Bug 107082] With 4.18 rc kernel stop working video output on AMD GPU Vega 56

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107082 --- Comment #7 from Michel Dänzer --- (In reply to mikhail.v.gavrilov from comment #6) > I don't believe that sshd can hang because of gnome-shell bug. Sure, I'm only talking about the scaling reset. -- You are receiving this mail because: Yo

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread Lukas Wunner
On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote: > On modern laptop, there are more and more platforms > have two GPUs, and each of them maybe have audio codec > for HDMP/DP output. For some dGPU which is no output, > audio codec usually is disabled. > > In currect HDA audio driver, it will

Re: [alsa-devel] [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters

2018-07-13 Thread Qu, Jim
See comments in line thanks JimQu 获取 Outlook for Android 发件人: Takashi Iwai 发送时间: 7月13日星期五 16:33 主题: Re: [alsa-devel] [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY tocover more display adapters 收件人: Qu, Jim 抄送: alsa-de...@alsa-project.org, dri-devel@lists.freedesktop

[Bug 87738] [OpenCL] Please add Image support

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87738 --- Comment #4 from Vasilis LIaskovitis --- I see there are clover patches for image support already upstream e.g. f2c52e392 clover: Implement CL1.2 clCreateImage(). 2518645f6 clover: Implement clCreateImage?D w/ clCreateImage. What is missing?

Re: [PATCH 02/12] blk: use for_each_if

2018-07-13 Thread Vlastimil Babka
On 07/12/2018 08:45 AM, Joe Perches wrote: > On Wed, 2018-07-11 at 20:50 +0200, Daniel Vetter wrote: >> On Wed, Jul 11, 2018 at 8:30 PM, Jens Axboe wrote: >>> On 7/11/18 10:45 AM, Tejun Heo wrote: On Wed, Jul 11, 2018 at 09:40:58AM -0700, Tejun Heo wrote: > On Mon, Jul 09, 2018 at 10:36:4

[Bug 107183] Enabling Glamor takes half a second

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107183 Paul Menzel changed: What|Removed |Added Product|DRI |xorg Version|XOrg git

[PATCH v2 2/2] drm/scheduler: modify args of drm_sched_entity_init

2018-07-13 Thread Nayan Deshmukh
replace run queue by a list of run queues and remove the sched arg as that is part of run queue itself Signed-off-by: Nayan Deshmukh Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 +-- drivers/gpu/drm/amd/amdg

[PATCH v2 1/2] drm/scheduler: add a pointer to scheduler in the rq

2018-07-13 Thread Nayan Deshmukh
This patch is in preparation for a better load balancing in scheduler. It allows us to associate entities with the run queues instead of binding them to a scheduler. Signed-off-by: Nayan Deshmukh --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 6 -- include/drm/gpu_scheduler.h

Re: [PATCH v2] drm/client: Fix double free in error path

2018-07-13 Thread Noralf Trønnes
Den 12.07.2018 17.04, skrev Noralf Trønnes: This fixes a static checker warning: drivers/gpu/drm/drm_client.c:289 drm_client_buffer_create() error: double free of 'buffer' Extend drm_client_buffer_delete() to handle the case when there's no dumb buffer attached and drop the ext

Re: [PATCH v4 02/11] media: vsp1: Remove packed attributes from aligned structures

2018-07-13 Thread Kieran Bingham
Hi Laurent, On 24/05/18 11:47, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 3 May 2018 16:36:13 EEST Kieran Bingham wrote: >> The use of the packed attribute can cause a performance penalty for >> all accesses to the struct members, as the compiler will assu

Re: [PATCH] drm: mxsfb: fix runtime PM handling

2018-07-13 Thread Stefan Agner
On 13.07.2018 11:12, Marek Vasut wrote: > On 07/13/2018 11:06 AM, Anson Huang wrote: > [...] >>> >>> On 07/13/2018 10:54 AM, Anson Huang wrote: As display power domain is combined with lcdif node on some i.MX platforms like i.MX6SL, when lcdif driver is enabled, the mxsfb_load is cal

Re: [PATCH] drm: mxsfb: fix runtime PM handling

2018-07-13 Thread Stefan Agner
On 13.07.2018 12:36, Marek Vasut wrote: > On 07/13/2018 12:33 PM, Stefan Agner wrote: >> On 13.07.2018 11:12, Marek Vasut wrote: >>> On 07/13/2018 11:06 AM, Anson Huang wrote: >>> [...] > > On 07/13/2018 10:54 AM, Anson Huang wrote: >> As display power domain is combined with lcdif node

Re: [PATCH v4 07/11] media: vsp1: Use header display lists for all WPF outputs linked to the DU

2018-07-13 Thread Kieran Bingham
On 24/05/18 12:10, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 3 May 2018 16:36:18 EEST Kieran Bingham wrote: >> Header mode display lists are now supported on all WPF outputs. To >> support extended headers and auto-fld capabilities for interlaced mode >> h

Re: [PATCH 1/2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-07-13 Thread Stefan Agner
On 05.06.2018 19:11, Leonard Crestez wrote: > Adding imx6sl/sx lcdif nodes in a power domain currently does work, it > results in black/corrupted screens or hangs. While the driver does > enable runtime pm it does not deal correctly with the block being > unpowered. > > Fix by adding pm_runtime_ge

Re: [PATCH 1/3 v4] ARM: dts: Modernize the Vexpress PL111 integration

2018-07-13 Thread Robin Murphy
On 13/07/18 10:50, Sudeep Holla wrote: It doesn't work. This change is breaking the working CLCD on the models. I just tested and CLCD driver returns It even fails to initialize CLCD on my TC2. clcd-pl11x 1c1f.clcd: PL111 designer 41 rev1 at 0x1c1f clcd-pl11x: probe of 1c1f.clcd f

[PATCH] drm/mxsfb: Replace drm_dev_unref with drm_dev_put

2018-07-13 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH] drm/qxl: Replace drm_dev_unref with drm_dev_put

2018-07-13 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Bug 107221] [Intel GFX CI] Plenty of "*ERROR* VCE not responding, trying to reset the ECPU!!!" in dmesg

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107221 Bug ID: 107221 Summary: [Intel GFX CI] Plenty of "*ERROR* VCE not responding, trying to reset the ECPU!!!" in dmesg Product: DRI Version: DRI git Hardware: Other

[Bug 107222] [Intel GFX CI] Many "*ERROR* amdgpu: IB test timed out." messages in dmesg

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107222 Bug ID: 107222 Summary: [Intel GFX CI] Many "*ERROR* amdgpu: IB test timed out." messages in dmesg Product: DRI Version: DRI git Hardware: Other OS: All

[PATCH] drm/msm: rework vblank event handling in dpu_crtc

2018-07-13 Thread Rajesh Yadav
The vblank on/off calls were missing in dpu_crtc leading to "driver forgot to call drm_crtc_vblank_off()" warning while entering suspend state. Also handle the state update completion event for a crtc being disabled in current atomic commit. This patch depends on https://www.spinics.net/lists/dri-

Re: [PATCH v2 1/2] drm/scheduler: add a pointer to scheduler in the rq

2018-07-13 Thread Nayan Deshmukh
I forgot to add these: On Fri, Jul 13, 2018 at 3:21 PM Nayan Deshmukh wrote: > > This patch is in preparation for a better load balancing in > scheduler. It allows us to associate entities with the > run queues instead of binding them to a scheduler. > > Signed-off-by: Nayan Deshmukh Reviewed-by:

Re: [PATCH v2 1/2] drm/scheduler: add a pointer to scheduler in the rq

2018-07-13 Thread Christian König
Am 13.07.2018 um 15:40 schrieb Nayan Deshmukh: I forgot to add these: Not a problem at all. It is actually my job to do this while committing the patches. BTW: I've pushed you patches to amd-staging-drm-next just a few minutes ago. Thanks for the help. I'm preparing quite a cleanup for am

Re: [Freedreno] [PATCH 05/13] drm: Add put callback for the coredump printer

2018-07-13 Thread Rob Clark
On Thu, Jul 12, 2018 at 2:59 PM, Jordan Crouse wrote: > Add a put function for the coredump printer to bypass printf() > for constant strings for a speed boost. s/put/puts/ (and in the $subject) BR, -R > > v2: Add EXPORT_SYMBOL for _drm_puts_coredump > Signed-off-by: Jordan Crouse > --- > dri

[PATCH] drm/tinydrm: Replace drm_dev_unref with drm_dev_put

2018-07-13 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tinydrm/core/tinydrm-core.c | 6 +++--- 1 file changed, 3 insertions(+

[PATCH v4 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-13 Thread Mahesh Kumar
This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional callback function and if driver implements this callback, driver should return a constant pointer to an array of crc sources list and update count according to the number o

[PATCH v4 03/10] drm/rockchip/crc: Implement verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rockchip drm driver. Changes since V1: - simplify the verification (Jani N) Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/roc

[PATCH 00/10] Improve crc-core driver interface

2018-07-13 Thread Mahesh Kumar
This series improves crc-core <-> driver interface. This series adds following functionality in the crc-core - Now control node will print all the available sources if implemented by driver along with current source. - Setting of sorce will fail if provided source is not supported - cleanup o

[PATCH v4 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + drivers/gpu/drm/amd/display/amdgpu_d

[PATCH v4 07/10] drm/i915/crc: implement get_crc_sources callback

2018-07-13 Thread Mahesh Kumar
This patch implements get_crc_sources callback, which returns list of all the valid crc sources supported by driver in current platform. Changes since V1: - Return array of crc sources Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/g

[PATCH v4 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node. This will help in avoiding setting of wrong string for source. Changes since V1: - do not yet verify_crc_source during open. Changes since V1: - improve callback descript

[PATCH v4 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-13 Thread Mahesh Kumar
This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in the function before setting the source or memory allocation. Now set_crc_source takes only two variable inputs, values_cnt we already gets as part of verify_crc_source. Ch

[PATCH v4 06/10] drm/i915/crc: implement verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch implements verify_crc_source callback function introduced earlier in this series. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/g

[PATCH v4 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-13 Thread Mahesh Kumar
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call. Suggested-by: Ville Syrjälä Signed-off-by: Mahesh Kumar Cc:

[PATCH v4 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-13 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for rcar drm driver. Changes Since V1: - avoid duplication of code Changes Since V2: - further optimize the code Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Reviewed-by: Maarten Lankhorst ---

[Bug 107213] [amdgpu/DisplayPort] KDE Wayland session is segfaulting right after login

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107213 --- Comment #2 from Shmerl --- Created attachment 140624 --> https://bugs.freedesktop.org/attachment.cgi?id=140624&action=edit dmesg output See attached dmesg output. Once thing to note, I consistently get a black screen after boot (the monit

[Bug 107153] 4.18-rc3 crash on hdmi (0010:dm_update_crtcs_state+0x41e/0x4a0)

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107153 --- Comment #9 from Patrik Kullman --- That's amazing! I'll try it out in a few hours! Thanks! -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-

[PATCH] fbdev: omapfb: off by one in omapfb_register_client()

2018-07-13 Thread Dan Carpenter
The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the > should be >= or we are one element beyond the end of the array. Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver") Signed-off-by: Dan Carpenter diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video

Re: [PATCH 05/15] drm: drop _mode_ from update_edit_property()

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:06AM +0200, Daniel Vetter wrote: > Just makes it longer, and for most things in drm_connector.[hc] we > just use the drm_connector_ prefix. Done with sed + a bit of manual > fixup for the indenting. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/amd/amdgpu

[PATCH] drm/etnaviv: fix some off by one bugs

2018-07-13 Thread Dan Carpenter
The ->nr_signal is the supposed to be the number of elements in the ->signal array. There was one place where it was 5 but it was supposed to be 4. That looks like a copy and paste bug. There were also two checks that were off by one. Fixes: 9e2c2e273012 ("drm/etnaviv: add infrastructure to que

Re: [PATCH 06/15] drm: drop _mode_ from drm_mode_connector_attach_encoder

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:07AM +0200, Daniel Vetter wrote: > Again to align with the usual prefix of just drm_connector_. Again > done with sed + manual fixup for indent issues. > > Signed-off-by: Daniel Vetter Reviewed-by: Sean Paul > --- > Documentation/gpu/drm-kms.rst

[PATCH] fbdev: omapfb: off by one in omapfb_register_client()

2018-07-13 Thread Dan Carpenter
The omapfb_register_client[] array has OMAPFB_PLANE_NUM elements so the > should be >= or we are one element beyond the end of the array. Fixes: 8b08cf2b64f5 ("OMAP: add TI OMAP framebuffer driver") Signed-off-by: Dan Carpenter diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video

Re: [PATCH 07/15] drm: drop _mode_ from remaining connector functions

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:08AM +0200, Daniel Vetter wrote: > Since there's very few callers of these I've decided to do them all in > one patch. With this the unecessarily long drm_mode_connector_ prefix > is gone from the codebase! The only exception being struct > drm_mode_connector_set_prope

no handling of fbdev patches till 23.07

2018-07-13 Thread Bartlomiej Zolnierkiewicz
Hi, I will be traveling / busy with other things / without access to my development setup till 23.07. When I'm back I will handle the rest of pending v4.19 changes, sorry for the inconvenience. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-13 Thread Takashi Iwai
On Wed, 11 Jul 2018 13:12:01 +0200, Takashi Iwai wrote: > > And the forced runtime PM is still an issue, and this would need the > other notification mechanism than the HD-audio unsolicited event as > AMD HDMI controller doesn't honor the HD-audio WAKEEN bit. Since we had a nice "hack week" in th

Re: [PATCH 08/15] drm: Switch drm_plane_state to inline kerneldoc style

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:09AM +0200, Daniel Vetter wrote: > For consistency and to encourage more detailed documentation. While > doing this also beefed up a few of the comments, linking at least to > the setup function. Plus fixed all the hyperlinks. > > Signed-off-by: Daniel Vetter Review

[PATCH v2 1/3] drm: writeback: Fix doc that says connector should be disconnected

2018-07-13 Thread Alexandru Gheorghe
During iteration process one of the proposed mechanism for not breaking existing userspace was to report writeback connectors as disconnected, however the final version used DRM_CLIENT_CAP_WRITEBACK_CONNECTORS for that purpose. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/drm_writeback.

[PATCH v2 2/3] drm: mali-dp: Report writeback connector as connected

2018-07-13 Thread Alexandru Gheorghe
Older version of this patch series reported writeback as disconnected to avoid confusing userspace not aware of writeback connectors. However, the version that got merged uses a special cap (DRM_CLIENT_CAP_WRITEBACK_CONNECTORS) for this purpose. This helps us avoid some special handling of writeba

[PATCH v2 3/3] drm: mali-dp: Set encoder possible_clones

2018-07-13 Thread Alexandru Gheorghe
Set possible_clones field to report that the writeback connector and the one driving the display could be enabled at the same time. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_drv.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_dr

Re: [PATCH 09/15] drm: switch drm_plane to inline comments

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:10AM +0200, Daniel Vetter wrote: > And use that opportunity to polish the kernel doc all around: > - Beef up some of the documentation. > - Intro text for drm_plane and better links > - Fix all the hyperlinks! > > v2: Fix linebreaks. > > Signed-off-by: Daniel Vetter

Re: [PATCH 10/15] drm: drop drmP.h include from drm_plane.c

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:11AM +0200, Daniel Vetter wrote: > Just a bit of missing includes and pre declarations. > > Note: This needs the patch to move for_each_if from drmP.h to kernel.h > or it won't compile. > > Signed-off-by: Daniel Vetter Reviewed-by: Sean Paul > --- > drivers/gpu/

[Bug 107066] [Regression] Tonga can't bring up > 1 display since DC enablement

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107066 --- Comment #8 from Mikita Lipski --- Created attachment 140625 --> https://bugs.freedesktop.org/attachment.cgi?id=140625&action=edit Don't share clk source between DP and other connectors Hi Paul, sorry for the previous comment that was a pa

[Bug 107066] [Regression] Tonga can't bring up > 1 display since DC enablement

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107066 --- Comment #9 from Mikita Lipski --- Created attachment 140626 --> https://bugs.freedesktop.org/attachment.cgi?id=140626&action=edit Update pix clk for HDMI connector with deep color -- You are receiving this mail because: You are the assig

[Bug 107066] [Regression] Tonga can't bring up > 1 display since DC enablement

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107066 --- Comment #10 from Mikita Lipski --- Created attachment 140627 --> https://bugs.freedesktop.org/attachment.cgi?id=140627&action=edit Disable clock source sharing -- You are receiving this mail because: You are the assignee for the bug.

Re: [alsa-devel] [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
在 2018/7/13 16:46, Takashi Iwai 写道: On Fri, 13 Jul 2018 10:06:02 +0200, Jim Qu wrote: On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio codec for HDMP/DP output. For some dGPU which is no output, audio codec usually is disabled. In currect HD

Re: [PATCH 11/15] drm/doc: move struct drm_crtc to in-line comments

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:12AM +0200, Daniel Vetter wrote: > And clean them up a bit, as usual. > > Signed-off-by: Daniel Vetter > --- > include/drm/drm_crtc.h | 126 +++-- > 1 file changed, 97 insertions(+), 29 deletions(-) > > diff --git a/include/drm/d

Re: [PATCH 13/15] drm/doc: Includ drm_of.c helpers

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:14AM +0200, Daniel Vetter wrote: > Fixes a dead link I spotted in the struct drm_crtc docs. Comments > themselves are in a surprisingly good state. > > Signed-off-by: Daniel Vetter In subject, s/Includ/Include/. With that, Reviewed-by: Sean Paul > --- > Documen

[Bug 107066] [Regression] Tonga can't bring up > 1 display since DC enablement

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107066 --- Comment #11 from Lyude Paul --- (In reply to Mikita Lipski from comment #10) > Created attachment 140627 [details] [review] > Disable clock source sharing Firing up an RPM build now, will have the results in a little bit -- You are receiv

Re: [PATCH 14/15] drm/doc: use inline kerneldoc style for drm_crtc_state

2018-07-13 Thread Sean Paul
On Mon, Jul 09, 2018 at 10:40:15AM +0200, Daniel Vetter wrote: > Lots of added text here since I think the various control flow bits > are worth explaining a bit better. > > Signed-off-by: Daniel Vetter The added docs surrounding enable/active will be most appreciated :-) Reviewed-by: Sean Paul

[PATCH] drm: Fix kerneldoc for DRM_MODE_PROP_IMMUTABLE

2018-07-13 Thread Sean Paul
Noticed this while browsing the docs. Signed-off-by: Sean Paul --- include/drm/drm_property.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h index 1d5c0b2a8956..c030f6ccab99 100644 --- a/include/drm/drm_property.h +

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
在 2018/7/13 17:27, Lukas Wunner 写道: On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote: On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio codec for HDMP/DP output. For some dGPU which is no output, audio codec usually is disabled. In curr

Re: [PATCH v2 1/3] drm: writeback: Fix doc that says connector should be disconnected

2018-07-13 Thread Sean Paul
On Fri, Jul 13, 2018 at 04:10:58PM +0100, Alexandru Gheorghe wrote: > During iteration process one of the proposed mechanism for not > breaking existing userspace was to report writeback connectors as > disconnected, however the final version used > DRM_CLIENT_CAP_WRITEBACK_CONNECTORS for that purp

Re: [PATCH v2 2/3] drm: mali-dp: Report writeback connector as connected

2018-07-13 Thread Sean Paul
On Fri, Jul 13, 2018 at 04:10:59PM +0100, Alexandru Gheorghe wrote: > Older version of this patch series reported writeback as disconnected > to avoid confusing userspace not aware of writeback connectors. > However, the version that got merged uses a special cap > (DRM_CLIENT_CAP_WRITEBACK_CONNECT

Re: [PATCH v2 3/3] drm: mali-dp: Set encoder possible_clones

2018-07-13 Thread Sean Paul
On Fri, Jul 13, 2018 at 04:11:00PM +0100, Alexandru Gheorghe wrote: > Set possible_clones field to report that the writeback connector and > the one driving the display could be enabled at the same time. > In future, please include a "Changes in vX" section so it's easier to tell what's changed.

Re: [PATCH v2 3/3] drm: mali-dp: Set encoder possible_clones

2018-07-13 Thread Sean Paul
On Fri, Jul 13, 2018 at 11:40:13AM -0400, Sean Paul wrote: > On Fri, Jul 13, 2018 at 04:11:00PM +0100, Alexandru Gheorghe wrote: > > Set possible_clones field to report that the writeback connector and > > the one driving the display could be enabled at the same time. > > > > In future, please in

[PATCH 1/4] drm: Move page_flip fb lookup earlier

2018-07-13 Thread Ville Syrjala
From: Ville Syrjälä No reason that I can see to delay the fb lookup this late. Moving it earlier allows us to keep it outside of the lock retry loop. This makes error handling and whatnot simpler. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_plane.c | 29 +++--

  1   2   >