On Fri, Jul 13, 2018 at 04:06:01PM +0800, Jim Qu wrote:
> Signed-off-by: Jim Qu <jim...@amd.com>

Empty commit message.  Please add an explanation why the change is
necessary so folks browsing the git history understand it's motivation.
I think here the motivation is that the PCI class is sometimes
PCI_CLASS_DISPLAY_3D or PCI_CLASS_DISPLAY_OTHER.


> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -31,7 +31,7 @@
>   *  CHANGES:
>   *
>   *  2004.12.01       Major rewrite by tiwai, merged the work of pshou
> - * 
> + *

Spurious unrelated change, please get rid of it, this clutters up
the git history unnecessarily.


> @@ -390,8 +390,8 @@ static char *driver_short_names[] = {
>       [AZX_DRIVER_SIS] = "HDA SIS966",
>       [AZX_DRIVER_ULI] = "HDA ULI M5461",
>       [AZX_DRIVER_NVIDIA] = "HDA NVidia",
> -     [AZX_DRIVER_TERA] = "HDA Teradici", 
> -     [AZX_DRIVER_CTX] = "HDA Creative", 
> +     [AZX_DRIVER_TERA] = "HDA Teradici",
> +     [AZX_DRIVER_CTX] = "HDA Creative",

Ditto.

Thanks,

Lukas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to