Re: Regression in Linux next-20171113 with fbdev timer conversion

2017-11-14 Thread Tony Lindgren
* Bartlomiej Zolnierkiewicz [171113 17:26]: > > On Monday, November 13, 2017 09:07:14 AM Tony Lindgren wrote: > > Hi, > > Hi Tony, > > > Looks like next-20171113 now has a NULL pointe dereference with commit > > 6c78935777d1 ("video: fbdev: Convert timers to use timer_setup()"). > > > > See th

Regression in Linux next-20171113 with fbdev timer conversion

2017-11-14 Thread Tony Lindgren
Hi, Looks like next-20171113 now has a NULL pointe dereference with commit 6c78935777d1 ("video: fbdev: Convert timers to use timer_setup()"). See the error below, any ideas? Regards, Tony 8< -- Unable to handle kernel NULL pointer dereference at virtual address 0214 pgd =

Re: 4.1 EOL

2017-11-14 Thread alexander . levin
I've cc'ed some folks in hopes to get this resolved upstream. Either way, 4.1's EoL was previously moved to about 6 months from now, so hopefully we'll have more than enough time to get this resolved. On Sat, Nov 11, 2017 at 10:13:55PM +, Tuncer Ayaz wrote: >The predicament I'm in on my machi

Re: [PATCH] drm/virtio: add create_handle support.

2017-11-14 Thread lepton
Ping. On Wed, Nov 8, 2017 at 10:42 AM, Lepton Wu wrote: > Add create_handle support to virtio fb. Without this, screenshot tool > in chromium OS can't work. > > Signed-off-by: Lepton Wu > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 12 > 1 file changed, 12 insertions(+) > > di

Re: linux-next: manual merge of the devicetree tree with the drm tree

2017-11-14 Thread Frank Rowand
Hi Jyri, On 11/13/17 07:40, Jyri Sarha wrote: > On 11/13/17 07:58, Stephen Rothwell wrote: >> Hi all, >> >> On Mon, 30 Oct 2017 20:37:56 + Mark Brown wrote: >>> >>> Today's linux-next merge of the devicetree tree got a conflict in: >>> >>> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c >>> >>

Re: video: fbdev: Convert timers to use timer_setup()

2017-11-14 Thread Kees Cook
On Mon, Nov 13, 2017 at 5:45 PM, Guenter Roeck wrote: > On Tue, Oct 24, 2017 at 08:20:26AM -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer poin

Re: video: fbdev: Convert timers to use timer_setup()

2017-11-14 Thread Guenter Roeck
On Tue, Oct 24, 2017 at 08:20:26AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. One tracking pointer was added, and > one in

Re: [PATCH libdrm v2] amdgpu: Add memory over allocation test.

2017-11-14 Thread Christian König
Am 13.11.2017 um 18:01 schrieb Andrey Grodzovsky: Allocates 1 TB of memory. Test is disabled by default since it's triggers OOM killer. v2: FIx the test to only alloc the BO and assert if return value not equal to -ENOMEM and remove test disable on start. Signed-off-by: Andrey Grodzovsky I w

Re: 4.1 EOL

2017-11-14 Thread Jani Nikula
Tuncer, where's your bug report? Can't find one. Please file your bug at the fdo bugzilla. Thanks, Jani. On Mon, 13 Nov 2017, alexander.le...@verizon.com wrote: > I've cc'ed some folks in hopes to get this resolved upstream. > > Either way, 4.1's EoL was previously moved to about 6 months from n

Re: [PATCH 2/2] drm/ttm: optimize ttm_mem_evict_first v4

2017-11-14 Thread Christian König
Am 14.11.2017 um 03:40 schrieb Chunming Zhou: On 2017年11月13日 17:54, Christian König wrote: Deleted BOs with the same reservation object can be reaped even if they can't be reserved. v2: rebase and we still need to remove/add the BO from/to the LRU. v3: fix remove/add one more time, cleanup th

Re: [PATCH/RFC 2/2] drm: rcar-du: Allow importing non-contiguous dma-buf with VSP

2017-11-14 Thread Liviu Dudau
On Tue, Nov 14, 2017 at 05:34:14AM +0200, Laurent Pinchart wrote: > Hi Liviu, Hi Laurent, > > On Monday, 13 November 2017 13:53:14 EET Liviu Dudau wrote: > > On Mon, Nov 13, 2017 at 12:32:28PM +0200, Laurent Pinchart wrote: > > > When the DU sources its frames from a VSP, it performs no memory a

Re: [PATCH 2/2] drm/ttm: optimize ttm_mem_evict_first v4

2017-11-14 Thread Michel Dänzer
On 13/11/17 10:54 AM, Christian König wrote: > Deleted BOs with the same reservation object can be reaped even if they > can't be reserved. > > v2: rebase and we still need to remove/add the BO from/to the LRU. > v3: fix remove/add one more time, cleanup the logic a bit > v4: we should still check

Re: [PATCH 1/2] drm/ttm: make unlocking in ttm_bo_cleanup_refs optional v2

2017-11-14 Thread Michel Dänzer
On 13/11/17 10:54 AM, Christian König wrote: > Needed for the next patch. > > v2: actually predicate all unlocks > > Signed-off-by: Christian König [...] > @@ -531,24 +533,28 @@ static int ttm_bo_cleanup_refs_and_unlock(struct > ttm_buffer_object *bo, > return -EBUSY; >

Re: [Intel-gfx] [PATCH] drm/debugfs: Fix framebuffer debugfs file init

2017-11-14 Thread Jani Nikula
On Tue, 14 Nov 2017, Dave Airlie wrote: > On 14 November 2017 at 09:12, Noralf Trønnes wrote: >> The introduction of: drm/framebuffer: Add framebuffer debugfs file >> broke vgem. That patch assumed that all drivers had initialized the >> dev->mode_config.fb_lock mutex which happens in drm_mode_co

Re: [PATCH] drm/virtio: add create_handle support.

2017-11-14 Thread Gerd Hoffmann
On Mon, Nov 13, 2017 at 02:19:29PM -0800, lepton wrote: > Ping. > > On Wed, Nov 8, 2017 at 10:42 AM, Lepton Wu wrote: > > Add create_handle support to virtio fb. Without this, screenshot tool > > in chromium OS can't work. Already queued up in drm-misc-next (the cirrus patch too). cheers, Ger

[PATCH 0/2] add support rk3126 vop support

2017-11-14 Thread Sandy Huang
The following patch add support RK3126 vop support, there is only one VOP at RK3126, and the RK3126 VOP register layout is similar with RK3036, so some feature can reuse with RK3036. Sandy Huang (2): dt-bindings: add document for rk3126-vop drm/rockchip: vop: add rk3126 vop support .../bindi

[PATCH 1/2] dt-bindings: add document for rk3126-vop

2017-11-14 Thread Sandy Huang
Signed-off-by: Sandy Huang --- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index

[PATCH 2/2] drm/rockchip: vop: add rk3126 vop support

2017-11-14 Thread Sandy Huang
RK3126 vop register layout is similar with rk3036, so some feature can reuse with rk3036. RK3126 support two overlay plane and one hwc plane, max output resolution is 1080p. it support IOMMU, and its IOMMU same as rk3288's Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_vop_reg

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-14 Thread Stefan Schake
On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt wrote: > Stefan Schake writes: > >> The overflow mem work callback vc4_overflow_mem_work reenables its >> associated interrupt upon completion. To ensure all interrupts are disabled >> when we return from vc4_irq_uninstall, we need to disable it again

Re: [radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 4/16] drivers/gpu//drm/ttm/ttm_page_alloc.c:923:5: error: redefinition of 'ttm_populate_and_map_pages'

2017-11-14 Thread Tom St Denis
Is this: commit 7a9667ae197460e6c9c3bb432fe68c708fce6259 Refs: v4.13-rc5-1195-g7a9667ae1974 Author: Tom St Denis AuthorDate: Tue Sep 5 07:30:59 2017 -0400 Commit: Alex Deucher CommitDate: Tue Sep 12 14:22:55 2017 -0400 drm/ttm: Fix configuration error around populate_and_map() func

[PATCH] drm/amdgpu: set f_mapping on exported DMA-bufs

2017-11-14 Thread Christian König
Otherwise we can't correctly CPU map TTM buffers. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c index 90a

Re: [PATCH 2/2] drm/ttm: optimize ttm_mem_evict_first v4

2017-11-14 Thread Christian König
Am 14.11.2017 um 11:02 schrieb Michel Dänzer: On 13/11/17 10:54 AM, Christian König wrote: Deleted BOs with the same reservation object can be reaped even if they can't be reserved. v2: rebase and we still need to remove/add the BO from/to the LRU. v3: fix remove/add one more time, cleanup the

[PATCH v2 2/3] drm/omap: dss: Add support for reporting memory bandwidth limitation

2017-11-14 Thread Peter Ujfalusi
The get_memory_bandwidth_limit() in dispc_ops can be used to query the memory bandwidth limit of dispc by upper layers. Signed-off-by: Peter Ujfalusi --- drivers/gpu/drm/omapdrm/dss/dispc.c | 13 + drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 ++ 2 files changed, 15 insertions(+) di

[PATCH v2 1/3] dt-bindings: display/ti: Add optional property to set memory bandwidth limit

2017-11-14 Thread Peter Ujfalusi
max-memory-bandwidth can be used to specify the maximum bandwidth dispc can use when reading display data from main memory. In some SoC (am437x for example) we have memory bandwidth limitation which causes underflow in the display subsystem. Signed-off-by: Peter Ujfalusi --- Documentation/devic

[PATCH v2 0/3] drm/omap: Support for dispc memory bandwidth limit

2017-11-14 Thread Peter Ujfalusi
Hi, Changes since v1: - Use the crtc->mode_valid and not connector->mode_valid as the limit is really posed by the 'crtc' (DISPC) - Bandwidth calculation changed: do the calculation in place + extended comment - looked for better place to document the max-memory-bandwidth, but can not find an

[PATCH v2 3/3] drm/omap: Filter displays mode based on bandwidth limit

2017-11-14 Thread Peter Ujfalusi
If we have memory bandwidth limit configured, reject the modes which would require more bandwidth than the limit if it is used with one full resolution plane (most common use case). This filtering is not providing full protection as it is possible that application would pick smaller crtc resolutio

Re: [radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 4/16] drivers/gpu//drm/ttm/ttm_page_alloc.c:923:5: error: redefinition of 'ttm_populate_and_map_pages'

2017-11-14 Thread S, Shirish
Please ignore all the kbuild bot related mails on this branch. As the purpose of this branch is chrome specific and in a very specific build environment. Regards, Shirish S From: StDenis, Tom Sent: Tuesday, November 14, 2017 4:58:48 PM To: kbuild test robot Cc:

Re: [PATCH libdrm v2] amdgpu: Add memory over allocation test.

2017-11-14 Thread Andrey Grodzovsky
On 11/14/2017 03:44 AM, Christian König wrote: Am 13.11.2017 um 18:01 schrieb Andrey Grodzovsky: Allocates 1 TB of memory. Test is disabled by default since it's triggers OOM killer. v2: FIx the test to only alloc the BO and assert if return value not equal to -ENOMEM and remove test disable

Re: [radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 4/16] drivers/gpu//drm/ttm/ttm_page_alloc.c:923:5: error: redefinition of 'ttm_populate_and_map_pages'

2017-11-14 Thread Fengguang Wu
Hi Shirish, Sorry for the noise! Do you have any branch pattern that I can add to blacklist? The regex could be 'chrome$' to match it in the end or just 'chrome' to match it anywhere in the branch name. Thanks, Fengguang On Tue, Nov 14, 2017 at 01:07:07PM +, S, Shirish wrote: Please ignore

Re: [radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 4/16] drivers/gpu//drm/ttm/ttm_page_alloc.c:923:5: error: redefinition of 'ttm_populate_and_map_pages'

2017-11-14 Thread Fengguang Wu
OK I'll blacklist all branches containing the "chrome" string. It's "grep -E" patterns. Here are some examples: wfg /c/lkp-tests% grep -hr blacklist repo blacklist_branch: master|revert- blacklist_branch: .* blacklist_branch: .* blacklist_branch: .* blacklist_branch: for-epmt blacklist_branch: m

Re: [PATCH libdrm v2] amdgpu: Add memory over allocation test.

2017-11-14 Thread Christian König
Am 14.11.2017 um 13:53 schrieb Andrey Grodzovsky: On 11/14/2017 03:44 AM, Christian König wrote: Am 13.11.2017 um 18:01 schrieb Andrey Grodzovsky: Allocates 1 TB of memory. Test is disabled by default since it's triggers OOM killer. v2: FIx the test to only alloc the BO and assert if return

Re: [radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 4/16] drivers/gpu//drm/ttm/ttm_page_alloc.c:923:5: error: redefinition of 'ttm_populate_and_map_pages'

2017-11-14 Thread S, Shirish
Thanks. (typed on mobile, kindly ignore typos) Regards, Shirish S From: Fengguang Wu Sent: Tuesday, November 14, 2017 6:52:03 PM To: S, Shirish Cc: StDenis, Tom; kbuild-...@01.org; dri-devel@lists.freedesktop.org; Koenig, Christian; Deucher, Alexander Subject:

[Bug 101483] A10-8780P (Carrizo) + R7 M260/M265 does not boot without any "workaround" parameter.

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101483 --- Comment #25 from FFAB --- Upstream kernel test - kernel 4.14 Installation, on which upstream kernel was installed: ubuntu 16.04.3, kernel4.10.0-38, updated 2017-11-14 1. booting without any workaround parameters 2. booting with kernel par

Re: [radeon-alex:upstream-4.14-drm-next-amd-dc-staging-chrome 4/16] drivers/gpu//drm/ttm/ttm_page_alloc.c:923:5: error: redefinition of 'ttm_populate_and_map_pages'

2017-11-14 Thread S, Shirish
Do you have a standard such reference for uniformity, else chrome keyword will do. (typed on mobile, kindly ignore typos) Regards, Shirish S From: Fengguang Wu Sent: Tuesday, November 14, 2017 6:41:41 PM To: S, Shirish Cc: StDenis, Tom; kbuild-...@01.org; dri-d

[Bug 101483] A10-8780P (Carrizo) + R7 M260/M265 does not boot without any "workaround" parameter.

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101483 FFAB changed: What|Removed |Added Attachment #135255|0 |1 is obsolete|

[Bug 101483] A10-8780P (Carrizo) + R7 M260/M265 does not boot without any "workaround" parameter.

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101483 --- Comment #27 from FFAB --- Created attachment 135448 --> https://bugs.freedesktop.org/attachment.cgi?id=135448&action=edit dmesg_20171114_4_14_iommu_soft.txt, kernel boot-parameter iommu=soft -- You are receiving this mail because: You ar

[PATCH libdrm] amdgpu: Disable deadlock test suite for Vega 10

2017-11-14 Thread Andrey Grodzovsky
The suite stalls the CP, until RCA is done the suite is disabled to not disrupt regression testing. Signed-off-by: Andrey Grodzovsky --- tests/amdgpu/amdgpu_test.c| 2 +- tests/amdgpu/amdgpu_test.h| 5 + tests/amdgpu/deadlock_tests.c | 19 +++ 3 files changed, 25 in

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-14 Thread Christian König
Am 06.11.2017 um 17:22 schrieb Chris Wilson: Quoting Christian König (2017-10-30 14:59:04) From: Christian König The amdgpu issue to also need signaled fences in the reservation objects should be fixed by now. Optimize the handling by replacing a signaled fence when adding a new shared one.

[PATCH 1/2] dma-buf: keep only not signaled fence in reservation_object_add_shared_replace v3

2017-11-14 Thread Christian König
The amdgpu issue to also need signaled fences in the reservation objects should be fixed by now. Optimize the list by keeping only the not signaled yet fences around. v2: temporary put the signaled fences at the end of the new container v3: put the old fence at the end of the new container as wel

[PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-14 Thread Christian König
The amdgpu issue to also need signaled fences in the reservation objects should be fixed by now. Optimize the handling by replacing a signaled fence when adding a new shared one. Signed-off-by: Christian König --- drivers/dma-buf/reservation.c | 18 +++--- 1 file changed, 15 inserti

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-14 Thread Chris Wilson
Quoting Christian König (2017-11-14 14:24:44) > Am 06.11.2017 um 17:22 schrieb Chris Wilson: > > Quoting Christian König (2017-10-30 14:59:04) > >> From: Christian König > >> > >> The amdgpu issue to also need signaled fences in the reservation objects > >> should > >> be fixed by now. > >> > >>

Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node

2017-11-14 Thread Andrzej Hajda
On 05.04.2017 14:04, Thierry Reding wrote: > On Wed, Apr 05, 2017 at 10:52:32AM +0200, Lucas Stach wrote: >> Hi Rob, >> >> Am Mittwoch, den 29.03.2017, 08:56 -0500 schrieb Rob Herring: >>> On Mon, Jan 23, 2017 at 10:33 AM, Thierry Reding >>> wrote: On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lu

Re: [PATCH 1/2] dma-buf: keep only not signaled fence in reservation_object_add_shared_replace v3

2017-11-14 Thread Chris Wilson
Quoting Christian König (2017-11-14 14:24:35) > The amdgpu issue to also need signaled fences in the reservation objects > should be fixed by now. > > Optimize the list by keeping only the not signaled yet fences around. > > v2: temporary put the signaled fences at the end of the new container >

Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace

2017-11-14 Thread Chris Wilson
Quoting Christian König (2017-11-14 14:24:36) > The amdgpu issue to also need signaled fences in the reservation objects > should > be fixed by now. > > Optimize the handling by replacing a signaled fence when adding a new > shared one. > > Signed-off-by: Christian König Reviewed-by: Chris Wil

Re: [PATCH 1/2] dma-buf: keep only not signaled fence in reservation_object_add_shared_replace v3

2017-11-14 Thread Chris Wilson
Quoting Chris Wilson (2017-11-14 14:39:29) > Quoting Christian König (2017-11-14 14:24:35) > > The amdgpu issue to also need signaled fences in the reservation objects > > should be fixed by now. > > > > Optimize the list by keeping only the not signaled yet fences around. > > > > v2: temporary p

[Bug 103519] wayland egl apps crash on start with mesa 17.2

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103519 --- Comment #7 from Apostolos B. --- @Emil Velikov It will be in for 17.3 right? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.f

[Bug 102358] WarThunder freezes at start, with activated vsync (vblank_mode=2)

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102358 --- Comment #39 from har...@gmx.de --- Thank you, problem fully solved for me. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freed

[Bug 103736] Sudden system freezes, dmesg errors

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103736 Bug ID: 103736 Summary: Sudden system freezes, dmesg errors Product: DRI Version: XOrg git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity:

Re: [PATCH v2 4/6] drm/fsl-dcu: Use drm_mode_config_helper_suspend/resume()

2017-11-14 Thread Stefan Agner
On 2017-11-10 19:06, Noralf Trønnes wrote: > Den 10.11.2017 17.39, skrev Stefan Agner: >> On 2017-11-09 17:49, Noralf Trønnes wrote: >>> Den 09.11.2017 15.34, skrev Stefan Agner: On 2017-11-06 20:18, Noralf Trønnes wrote: > Replace driver's code with the generic helpers that do the same th

[Bug 103700] Displayport link status failed on resume from suspend on eDP on RX580 with Asus GL702ZC

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103700 --- Comment #3 from Harry Wentland --- dwagner, these are different issue. This one was reported on a kernel without DC, the other with DC. -- You are receiving this mail because: You are the assignee for the bug.__

Re: [PATCH 2/2] drm/ttm: optimize ttm_mem_evict_first v4

2017-11-14 Thread Michel Dänzer
On 14/11/17 01:18 PM, Christian König wrote: > Am 14.11.2017 um 11:02 schrieb Michel Dänzer: >> On 13/11/17 10:54 AM, Christian König wrote: >>> >>> +    } else { >>> +    locked = reservation_object_trylock(bo->resv); >>> +    if (!locked) >>> +    c

[Bug 103519] wayland egl apps crash on start with mesa 17.2

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103519 --- Comment #8 from Derek Foreman --- Oops, I've dropped the ball on this. I need to send it to the list for further review (and potentially revision in response to that) - will do that today. -- You are receiving this mail because: You are t

Re: [PATCH v2 4/6] drm/fsl-dcu: Use drm_mode_config_helper_suspend/resume()

2017-11-14 Thread Noralf Trønnes
Den 14.11.2017 16.23, skrev Stefan Agner: On 2017-11-10 19:06, Noralf Trønnes wrote: Den 10.11.2017 17.39, skrev Stefan Agner: On 2017-11-09 17:49, Noralf Trønnes wrote: Den 09.11.2017 15.34, skrev Stefan Agner: On 2017-11-06 20:18, Noralf Trønnes wrote: Replace driver's code with the gener

[Bug 103519] wayland egl apps crash on start with mesa 17.2

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103519 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 103519] wayland egl apps crash on start with mesa 17.2

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103519 --- Comment #10 from Derek Foreman --- Thanks Emil! sorry for the noise on list. :( -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@list

Re: [PATCH v2 5/6] drm/tinydrm: Use drm_mode_config_helper_suspend/resume()

2017-11-14 Thread Stefan Agner
On 2017-11-06 20:18, Noralf Trønnes wrote: > Replace driver's code with the generic helpers that do the same thing. > Remove todo entry. This patch looks good to me: Reviewed-by: Stefan Agner One question below though: > > Signed-off-by: Noralf Trønnes > --- > Documentation/gpu/todo.rst

Re: [PATCH] drm/amdgpu: set f_mapping on exported DMA-bufs

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 7:13 AM, Christian König wrote: > Otherwise we can't correctly CPU map TTM buffers. > > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a

[Bug 103736] Sudden system freezes, dmesg errors

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103736 Michel Dänzer changed: What|Removed |Added CC||andre...@gmail.com --- Comment #1 from

Re: [PATCH v2 4/6] drm/fsl-dcu: Use drm_mode_config_helper_suspend/resume()

2017-11-14 Thread Stefan Agner
On 2017-11-14 16:40, Noralf Trønnes wrote: > Den 14.11.2017 16.23, skrev Stefan Agner: >> On 2017-11-10 19:06, Noralf Trønnes wrote: >>> Den 10.11.2017 17.39, skrev Stefan Agner: On 2017-11-09 17:49, Noralf Trønnes wrote: > Den 09.11.2017 15.34, skrev Stefan Agner: >> On 2017-11-06 20:

Re: [PATCH v2 5/6] drm/tinydrm: Use drm_mode_config_helper_suspend/resume()

2017-11-14 Thread Noralf Trønnes
Den 14.11.2017 16.40, skrev Stefan Agner: On 2017-11-06 20:18, Noralf Trønnes wrote: Replace driver's code with the generic helpers that do the same thing. Remove todo entry. This patch looks good to me: Reviewed-by: Stefan Agner Thanks! One question below though: Signed-off-by: Noralf

Re: [PATCH v2 4/6] drm/fsl-dcu: Use drm_mode_config_helper_suspend/resume()

2017-11-14 Thread Noralf Trønnes
Den 14.11.2017 16.56, skrev Stefan Agner: On 2017-11-14 16:40, Noralf Trønnes wrote: Den 14.11.2017 16.23, skrev Stefan Agner: On 2017-11-10 19:06, Noralf Trønnes wrote: Den 10.11.2017 17.39, skrev Stefan Agner: On 2017-11-09 17:49, Noralf Trønnes wrote: Den 09.11.2017 15.34, skrev Stefan

[PATCH] dma-buf/fence: Fix lock inversion within dma-fence-array

2017-11-14 Thread Chris Wilson
Ages ago Rob Clark noted, "Currently with fence-array, we have a potential deadlock situation. If we fence_add_callback() on an array-fence, the array-fence's lock is acquired first, and in it's ->enable_signaling() callback, it will install cbs on it's array-member fences, so the array-member's

[PATCH v2 1/2] drm/fsl-dcu: avoid disabling pixel clock twice on suspend

2017-11-14 Thread Stefan Agner
With commit 0a70c998d0c5 ("drm/fsl-dcu: enable pixel clock when enabling CRTC") the pixel clock is controlled by the CRTC code. Disabling the pixel clock in suspend leads to a warning due to the second clk_disable_unprepare call: WARNING: CPU: 0 PID: 359 at drivers/clk/clk.c:594 clk_core_disable+

[PATCH v2 2/2] drm/fsl-dcu: enable IRQ before drm_atomic_helper_resume()

2017-11-14 Thread Stefan Agner
The resume helpers wait for a vblank to occurre hence IRQ need to be enabled. This avoids a warning as follows during resume: WARNING: CPU: 0 PID: 314 at drivers/gpu/drm/drm_atomic_helper.c:1249 drm_atomic_helper_wait_for_vblanks.part.1+0x284/0x288 [CRTC:28:crtc-0] vblank wait timed out Signe

Re: [PATCH] dma-buf/fence: Fix lock inversion within dma-fence-array

2017-11-14 Thread Christian König
Am 14.11.2017 um 17:27 schrieb Chris Wilson: Ages ago Rob Clark noted, "Currently with fence-array, we have a potential deadlock situation. If we fence_add_callback() on an array-fence, the array-fence's lock is acquired first, and in it's ->enable_signaling() callback, it will install cbs on i

[Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103743 Bug ID: 103743 Summary: Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103743 --- Comment #1 from Philip Rebohle --- Created attachment 135458 --> https://bugs.freedesktop.org/attachment.cgi?id=135458&action=edit Frame 2400 with artifacts -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103743 --- Comment #2 from Philip Rebohle --- Created attachment 135459 --> https://bugs.freedesktop.org/attachment.cgi?id=135459&action=edit Frame 2400 without artifacts -- You are receiving this mail because: You are the assignee for the bug.

[Bug 103743] Nier:Automata - "if" in fragment shader incorrectly evaluated, causes artifacts

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103743 --- Comment #3 from Philip Rebohle --- PS: While bug 102218 is not directly related to this one, that's another case where two shaders that *should* be functionally equivalent yield different results. In the second screenshot, workarounds for bo

[PATCH 02/10] drm/uapi: Validate the mode flags/type

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä Currently userspace is allowed to feed in any king of garbage in the high bits of the mode flags/type, as are drivers when probing modes. Reject any mode with bogus flags/type. Hopefully this won't break any current userspace... Cc: Jose Abreu Cc: Adam Jackson Cc: Keith Pa

[PATCH 00/10] drm/uapi: Validate mode flags/type, and deprecate some of them

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä I recently realized that we're not validating the mode flags/type passed in from userspace. Let's try to fix that. I'd also like to entirely eliminate some of the more crazy mode flags. PIXMUX and BCAST look pretty easy, so I've targetted them first. Ideally I'd like to kill

[PATCH 03/10] drm/uapi: Deprecate DRM_MODE_FLAG_PIXMUX

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä Reject any mode with DRM_MODE_FLAG_PIXMUX. We have no code that even checks for this flag hence it can't possibly do any good. Looks like this flag had something to do the the controller<->ramdac interface with some ancient S3 graphics adapters. Why someone though it would be

[PATCH 05/10] drm/modes: Fix description of DRM_MODE_TYPE_USERDEF

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä These days DRM_MODE_TYPE_USERDEF is used to flag modes defined via the kernel command line. Update the docs to reflect that fact. Signed-off-by: Ville Syrjälä --- include/drm/drm_modes.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/drm/drm_

[PATCH 04/10] drm/uapi: Deprecate DRM_MODE_FLAG_BCAST

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä Reject any mode with DRM_MODE_FLAG_BCAST. We have no code that even checks for this flag hence it can't possibly do any good. I think this maybe originated from fbdev where it was supposed to indicate PAL/NTSC broadcast timings. I have no idea why those would have to be ident

[PATCH 01/10] drm/modes: Move 3D stereo flag check into drm_mode_validate_basic()

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä Currently we don't sanity check the 3D stereo flags for modes filled out by the kernel. Move the check from drm_mode_convert_umode() into drm_mode_validate_basic() so that we get the same check going both ways. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_modes.c |

[PATCH 06/10] drm/modes: Kill off the oddball DRM_MODE_TYPE_CRTC_C vs. DRM_MODE_TYPE_BUILTIN handling

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä For some reason drm_mode_set_crtcinfo() does nothing of the mode has the DRM_MODE_TYPE_BUILTIN flag set without the other bit from DRM_MODE_TYPE_CRTC_C also set. I have zero idea what that is supposed to achieve, but since we have no users for neither flag bit let's kill this

[PATCH 08/10] drm/uapi: Deprecate nonsense kms mode types

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä BUILTIN, CRTC_C, CLOCK_C, and DEFULT mode types are unused. Let's refuse to generate them or accept them from userspace either. A cursory check didn't reveal any userspace code that would depend on these. Cc: Jose Abreu Cc: Adam Jackson Cc: Keith Packard Signed-off-by: Vil

[PATCH 07/10] drm/modes: Kill DRM_MODE_TYPE_CLOCK_CRTC_C define

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä No idea what the DRM_MODE_TYPE_CLOCK_CRTC_C define is supposed to achieve. Totally unused so kill if off. Signed-off-by: Ville Syrjälä --- include/drm/drm_modes.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h index 8

[PATCH 09/10] drm/modes: Provide global mode_valid hook

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä Allow drivers to provide a device wide .mode_valid() hook in addition to the already existing crtc/encoder/bridge/connector hooks. This can be used to validate device/driver wide constraings without having to add those to the other hooks. And since we call this hook also for u

[PATCH 10/10] drm/i915: Provide a device level .mode_valid() hook

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä We never support certain mode flags etc. Reject those early on in the mode_config.mode_valid() hook. That allows us to remove some duplicated checks from the connector .mode_valid() hooks, and it guarantees that we never see those flags even from user mode as the mode_config.m

[Bug 103736] Sudden system freezes, dmesg errors

2017-11-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103736 --- Comment #2 from Andres Rodriguez --- > FWIW, Andres Rodriguez reported similar symptoms with a Ryzen system on IRC, > and raising voltages / disabling Cool'n'Quiet / disabling C6 states fixed > them for him. I raised the memory and the cor

Re: [Intel-gfx] [PATCH 02/10] drm/uapi: Validate the mode flags/type

2017-11-14 Thread Chris Wilson
Quoting Ville Syrjala (2017-11-14 18:32:50) > From: Ville Syrjälä > > Currently userspace is allowed to feed in any king of garbage in the > high bits of the mode flags/type, as are drivers when probing modes. > Reject any mode with bogus flags/type. > > Hopefully this won't break any current us

Re: [Intel-gfx] [PATCH 06/10] drm/modes: Kill off the oddball DRM_MODE_TYPE_CRTC_C vs. DRM_MODE_TYPE_BUILTIN handling

2017-11-14 Thread Chris Wilson
Quoting Ville Syrjala (2017-11-14 18:32:54) > From: Ville Syrjälä > > For some reason drm_mode_set_crtcinfo() does nothing of the mode has s/of/if/ > the DRM_MODE_TYPE_BUILTIN flag set without the other bit from > DRM_MODE_TYPE_CRTC_C also set. I have zero idea what that is supposed > to achieve

Re: [Intel-gfx] [PATCH 02/10] drm/uapi: Validate the mode flags/type

2017-11-14 Thread Ville Syrjälä
On Tue, Nov 14, 2017 at 06:42:06PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2017-11-14 18:32:50) > > From: Ville Syrjälä > > > > Currently userspace is allowed to feed in any king of garbage in the > > high bits of the mode flags/type, as are drivers when probing modes. > > Reject any

[PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä Add the missing kerneldoc for modifiers and modifier_count. Cc: Ben Widawsky Cc: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- include/drm/drm_plane.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_plane.h b/include/drm

[PATCH 2/3] drm/syncobj: Fix kerneldocs

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä Document the drm_syncobj_get_handle() function parameters. Cc: Marek Olšák Cc: Dave Airlie Cc: Alex Deucher Cc: Daniel Vetter Suggested-by: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_syncobj.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs

2017-11-14 Thread Ville Syrjala
From: Ville Syrjälä Use the correct name for the function argument in the docs. Cc: Noralf Trønnes Cc: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_gem_cma_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c

Re: [PATCH 03/10] drm/uapi: Deprecate DRM_MODE_FLAG_PIXMUX

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 1:32 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Reject any mode with DRM_MODE_FLAG_PIXMUX. We have no code that even > checks for this flag hence it can't possibly do any good. > > Looks like this flag had something to do the the controller<->ramdac > interface wit

Re: [PATCH 04/10] drm/uapi: Deprecate DRM_MODE_FLAG_BCAST

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 1:32 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Reject any mode with DRM_MODE_FLAG_BCAST. We have no code that even > checks for this flag hence it can't possibly do any good. > > I think this maybe originated from fbdev where it was supposed to > indicate PAL/NTSC

Re: [Intel-gfx] [PATCH 06/10] drm/modes: Kill off the oddball DRM_MODE_TYPE_CRTC_C vs. DRM_MODE_TYPE_BUILTIN handling

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 1:43 PM, Chris Wilson wrote: > Quoting Ville Syrjala (2017-11-14 18:32:54) >> From: Ville Syrjälä >> >> For some reason drm_mode_set_crtcinfo() does nothing of the mode has > s/of/if/ With the typo fixed: Reviewed-by: Alex Deucher > >> the DRM_MODE_TYPE_BUILTIN flag set

[PATCH] drm/bridge: Fix lvds-encoder since the panel_bridge rework.

2017-11-14 Thread Eric Anholt
The panel_bridge bridge attaches to the panel's OF node, not the lvds-encoder's node. Put in a little no-op bridge of our own so that our consumers can still find a bridge where they expect. This also fixes an unintended unregistration and leak of the panel-bridge on module remove. Signed-off-by

Re: [PATCH 07/10] drm/modes: Kill DRM_MODE_TYPE_CLOCK_CRTC_C define

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 1:32 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > No idea what the DRM_MODE_TYPE_CLOCK_CRTC_C define is supposed to > achieve. Totally unused so kill if off. > > Signed-off-by: Ville Syrjälä Reviewed-by: Alex Deucher > --- > include/drm/drm_modes.h | 3 --- > 1

Re: [PATCH 08/10] drm/uapi: Deprecate nonsense kms mode types

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 1:32 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > BUILTIN, CRTC_C, CLOCK_C, and DEFULT mode types are unused. Let's > refuse to generate them or accept them from userspace either. A > cursory check didn't reveal any userspace code that would depend > on these. > > Cc

Re: [PATCH 01/10] drm/modes: Move 3D stereo flag check into drm_mode_validate_basic()

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 1:32 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Currently we don't sanity check the 3D stereo flags for modes filled out > by the kernel. Move the check from drm_mode_convert_umode() into > drm_mode_validate_basic() so that we get the same check going both ways. >

Re: [PATCH 2/3] drm/syncobj: Fix kerneldocs

2017-11-14 Thread Marek Olšák
On Tue, Nov 14, 2017 at 8:10 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Document the drm_syncobj_get_handle() function parameters. > > Cc: Marek Olšák > Cc: Dave Airlie > Cc: Alex Deucher > Cc: Daniel Vetter > Suggested-by: Daniel Vetter > Signed-off-by: Ville Syrjälä > --- > drive

Re: [PATCH 3/3] drm: Fix kerneldocs for drm_plane modifiers

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 2:10 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Add the missing kerneldoc for modifiers and modifier_count. > > Cc: Ben Widawsky > Cc: Daniel Vetter > Suggested-by: Daniel Vetter > Signed-off-by: Ville Syrjälä Series is: Reviewed-by: Alex Deucher > --- > in

Re: [PATCH 05/10] drm/modes: Fix description of DRM_MODE_TYPE_USERDEF

2017-11-14 Thread Alex Deucher
On Tue, Nov 14, 2017 at 1:32 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > These days DRM_MODE_TYPE_USERDEF is used to flag modes defined via the > kernel command line. Update the docs to reflect that fact. > > Signed-off-by: Ville Syrjälä Acked-by: Alex Deucher > --- > include/drm/drm_

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-14 Thread Eric Anholt
Stefan Schake writes: > On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt wrote: >> Stefan Schake writes: >> >>> The overflow mem work callback vc4_overflow_mem_work reenables its >>> associated interrupt upon completion. To ensure all interrupts are disabled >>> when we return from vc4_irq_uninstal

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-14 Thread Daniel Thompson
On 14/11/17 18:05, Johan Hovold wrote: On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: On 13/11/17 10:20, Johan Hovold wrote: Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at the parent rather than just matching on its c

Re: [PATCH 1/3] drm/gem-cma-helper: Fix kerneldocs

2017-11-14 Thread Noralf Trønnes
Den 14.11.2017 20.10, skrev Ville Syrjala: From: Ville Syrjälä Use the correct name for the function argument in the docs. Cc: Noralf Trønnes Cc: Daniel Vetter Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/drm_gem_cma_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

  1   2   >