Re: [PATCH v5 15/24] drm/msm/dsi/phy: Define PHY_CMN_CTRL_0 bitfields

2025-05-21 Thread Krzysztof Kozlowski
On 20/05/2025 23:23, Dmitry Baryshkov wrote: >> >> There is no checkpatch --strict warning here exactly for the reason I >> was saying. For readability there should be no empty line after because >> such statements are expected to be together. I don't mind of course >> adding one, so I will impleme

Re: [PATCH v5 15/24] drm/msm/dsi/phy: Define PHY_CMN_CTRL_0 bitfields

2025-05-20 Thread Dmitry Baryshkov
On Tue, May 20, 2025 at 12:57:25PM +0200, Krzysztof Kozlowski wrote: > On 03/05/2025 00:44, Dmitry Baryshkov wrote: > > On Wed, Apr 30, 2025 at 03:00:45PM +0200, Krzysztof Kozlowski wrote: > >> Add bitfields for PHY_CMN_CTRL_0 registers to avoid hard-coding bit > >> masks and shifts and make the co

Re: [PATCH v5 15/24] drm/msm/dsi/phy: Define PHY_CMN_CTRL_0 bitfields

2025-05-20 Thread Krzysztof Kozlowski
On 03/05/2025 00:44, Dmitry Baryshkov wrote: > On Wed, Apr 30, 2025 at 03:00:45PM +0200, Krzysztof Kozlowski wrote: >> Add bitfields for PHY_CMN_CTRL_0 registers to avoid hard-coding bit >> masks and shifts and make the code a bit more readable. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >

Re: [PATCH v5 15/24] drm/msm/dsi/phy: Define PHY_CMN_CTRL_0 bitfields

2025-05-05 Thread Dmitry Baryshkov
On 05/05/2025 09:17, Krzysztof Kozlowski wrote: On 03/05/2025 00:44, Dmitry Baryshkov wrote: On Wed, Apr 30, 2025 at 03:00:45PM +0200, Krzysztof Kozlowski wrote: Add bitfields for PHY_CMN_CTRL_0 registers to avoid hard-coding bit masks and shifts and make the code a bit more readable. Signed-o

Re: [PATCH v5 15/24] drm/msm/dsi/phy: Define PHY_CMN_CTRL_0 bitfields

2025-05-04 Thread Krzysztof Kozlowski
On 03/05/2025 00:44, Dmitry Baryshkov wrote: > On Wed, Apr 30, 2025 at 03:00:45PM +0200, Krzysztof Kozlowski wrote: >> Add bitfields for PHY_CMN_CTRL_0 registers to avoid hard-coding bit >> masks and shifts and make the code a bit more readable. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >

Re: [PATCH v5 15/24] drm/msm/dsi/phy: Define PHY_CMN_CTRL_0 bitfields

2025-05-02 Thread Dmitry Baryshkov
On Wed, Apr 30, 2025 at 03:00:45PM +0200, Krzysztof Kozlowski wrote: > Add bitfields for PHY_CMN_CTRL_0 registers to avoid hard-coding bit > masks and shifts and make the code a bit more readable. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes in v5: > 1. New patch > --- > drivers/