Re: [PATCH] ttm/pool: allow debugfs dumps for numa pools.

2025-06-03 Thread Dave Airlie
On Tue, 3 Jun 2025 at 18:50, Christian König wrote: > > On 6/3/25 09:52, David Airlie wrote: > > On Tue, Jun 3, 2025 at 5:47 PM Christian König > > wrote: > >> > >> On 6/2/25 22:40, Dave Airlie wrote: > >>> From: Dave Airlie > >>> > >>> Currently you can't see per-device numa aware pools proper

Re: [PATCH] ttm/pool: allow debugfs dumps for numa pools.

2025-06-03 Thread Christian König
On 6/3/25 09:52, David Airlie wrote: > On Tue, Jun 3, 2025 at 5:47 PM Christian König > wrote: >> >> On 6/2/25 22:40, Dave Airlie wrote: >>> From: Dave Airlie >>> >>> Currently you can't see per-device numa aware pools properly. >>> >>> Cc: Christian König >>> Signed-off-by: Dave Airlie >> >>

Re: [PATCH] ttm/pool: allow debugfs dumps for numa pools.

2025-06-03 Thread David Airlie
On Tue, Jun 3, 2025 at 5:47 PM Christian König wrote: > > On 6/2/25 22:40, Dave Airlie wrote: > > From: Dave Airlie > > > > Currently you can't see per-device numa aware pools properly. > > > > Cc: Christian König > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König > > Any follow u

Re: [PATCH] ttm/pool: allow debugfs dumps for numa pools.

2025-06-03 Thread Christian König
On 6/2/25 22:40, Dave Airlie wrote: > From: Dave Airlie > > Currently you can't see per-device numa aware pools properly. > > Cc: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Christian König Any follow up patch to wire this up in amdgpu? Regards, Christian. > --- > drivers/g

[PATCH] ttm/pool: allow debugfs dumps for numa pools.

2025-06-02 Thread Dave Airlie
From: Dave Airlie Currently you can't see per-device numa aware pools properly. Cc: Christian König Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_pool.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/t

Re: [PATCH] ttm/ttm_device.h: fix a trival typo

2023-03-03 Thread Christian König
Am 03.03.23 um 11:12 schrieb suijingfeng: should replace '@' with '*' Signed-off-by: suijingfeng I've just reviewed and pushed the patch to drm-misc-next. Just please use your full (first and last) name for author and signed-off-by tags in the future. Thanks, Christian. --- include/

[PATCH] ttm/ttm_device.h: fix a trival typo

2023-03-03 Thread suijingfeng
should replace '@' with '*' Signed-off-by: suijingfeng --- include/drm/ttm/ttm_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/ttm/ttm_device.h b/include/drm/ttm/ttm_device.h index 4f3e81eac6f3..56e82ba2d046 100644 --- a/include/drm/ttm/ttm_device.h +++

Re: [PATCH] ttm: remove check of list iterator against head outside the loop

2022-03-21 Thread Christian König
Am 19.03.22 um 08:31 schrieb Xiaomeng Tong: When list_for_each_entry() completes the iteration over the whole list without breaking the loop, the iterator value will be a bogus pointer computed based on the head element. While it is safe to use the pointer to determine if it was computed based o

[PATCH] ttm: remove check of list iterator against head outside the loop

2022-03-19 Thread Xiaomeng Tong
When list_for_each_entry() completes the iteration over the whole list without breaking the loop, the iterator value will be a bogus pointer computed based on the head element. While it is safe to use the pointer to determine if it was computed based on the head element with &pos->member == head,

Re: [PATCH] ttm: ttm_bo_swapout_all doesn't use it's argument.

2020-07-30 Thread Roland Scheidegger
Patch looks good to me too. Reviewed-by: Roland Scheidegger Seems indeed like we should do some cleanup. Roland Am 28.07.20 um 09:37 schrieb Christian König: > Am 28.07.20 um 05:42 schrieb Dave Airlie: >> From: Dave Airlie >> >> Just drop the argument from this. >> >> This does ask the questio

Re: [PATCH] ttm: ttm_bo_swapout_all doesn't use it's argument.

2020-07-28 Thread Zack Rusin
> On Jul 27, 2020, at 11:42 PM, Dave Airlie wrote: > > From: Dave Airlie > > Just drop the argument from this. > > This does ask the question if this is the function vmwgfx > should be using or should it be doing an evict all like > the other drivers. Yea, it really should. This code is real

Re: [PATCH] ttm: ttm_bo_swapout_all doesn't use it's argument.

2020-07-28 Thread daniel
On Tue, Jul 28, 2020 at 01:42:54PM +1000, Dave Airlie wrote: > From: Dave Airlie > > Just drop the argument from this. > > This does ask the question if this is the function vmwgfx > should be using or should it be doing an evict all like > the other drivers. Yeah this looks a bit like ttm_bo_s

Re: [PATCH] ttm: ttm_bo_swapout_all doesn't use it's argument.

2020-07-28 Thread Christian König
Am 28.07.20 um 05:42 schrieb Dave Airlie: From: Dave Airlie Just drop the argument from this. This does ask the question if this is the function vmwgfx should be using or should it be doing an evict all like the other drivers. Signed-off-by: Dave Airlie Reviewed-by: Christian König ---

[PATCH] ttm: ttm_bo_swapout_all doesn't use it's argument.

2020-07-27 Thread Dave Airlie
From: Dave Airlie Just drop the argument from this. This does ask the question if this is the function vmwgfx should be using or should it be doing an evict all like the other drivers. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c| 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_drv

Re: [PATCH] ttm

2019-08-14 Thread Chris Wilson
Quoting Chris Wilson (2019-08-14 19:22:54) You saw nothing; wrong experimental branch. -Chris ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] ttm

2019-08-14 Thread Chris Wilson
--- drivers/gpu/drm/i915/Makefile | 7 + drivers/gpu/drm/i915/ttm/Makefile | 5 + drivers/gpu/drm/i915/ttm/i915_ttm_drv.c | 4 + drivers/gpu/drm/i915/ttm/i915_ttm_drv.h | 12 ++ drivers/gpu/drm/i915/ttm/i915_ttm_ppgtt.c | 174 ++ drivers/gpu/drm/i

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread Christian König
adding a wrapper for pin function as below? amdgpu_get_pin_bo_timeout() { do { amdgpo_bo_reserve(); r=amdgpu_bo_pin(); if(!r)     break; amdgpu_bo_unreserve(); timeout--; } while(timeout>0); } Original Message Subject: Re: [PATCH] ttm: wait mem space if user allow

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread zhoucm1
u_bo_pin(); if(!r)     break; amdgpu_bo_unreserve(); timeout--; } while(timeout>0); } Original Message Subject: Re: [PATCH] ttm: wait mem space if user allow while gpu busy From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,&qu

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread Koenig, Christian
in ttm has this risk, how about just adding a wrapper for pin function as below? amdgpu_get_pin_bo_timeout() { do { amdgpo_bo_reserve(); r=amdgpu_bo_pin(); if(!r) break; amdgpu_bo_unreserve(); timeout--; } while(timeout>0); } Original Message Subject: Re: [PATCH]

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread zhoucm1
ssage -------- Subject: Re: [PATCH] ttm: wait mem space if user allow while gpu busy From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,"Liang, Prike" ,dri-devel@lists.freedesktop.org CC: Well that's not so easy of hand. The basic problem here

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread Christian König
erve(); r=amdgpu_bo_pin(); if(!r)     break; amdgpu_bo_unreserve(); timeout--; } while(timeout>0); } Original Message -------- Subject: Re: [PATCH] ttm: wait mem space if user allow while gpu busy From: Christian König To: "Zhou, David(ChunMing)" ,"Koeni

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread Koenig, Christian
y not trivial, but doable as far as I can see. >> >> Have fun :) >> Christian. >> >> Am 23.04.19 um 15:19 schrieb Zhou, David(ChunMing): >> >> How about adding more condition ctx->resv inline to address your concern? As >> well as don't wait from same user, s

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread Daniel Vetter
fun :) > Christian. > > Am 23.04.19 um 15:19 schrieb Zhou, David(ChunMing): > > How about adding more condition ctx->resv inline to address your concern? As > well as don't wait from same user, shouldn't lead to deadlock. > > Otherwise, any other idea? &g

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread zhoucm1
function as below? amdgpu_get_pin_bo_timeout() { do { amdgpo_bo_reserve(); r=amdgpu_bo_pin(); if(!r)     break; amdgpu_bo_unreserve(); timeout--; } while(timeout>0); } Original Message ---- Subject: Re: [PATCH] ttm: wait mem space if user allow while gpu busy From: Christian K

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread Christian König
u_bo_pin(); if(!r)     break; amdgpu_bo_unreserve(); timeout--; } while(timeout>0); } Original Message ---- Subject: Re: [PATCH] ttm: wait mem space if user allow while gpu busy From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,"L

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread zhoucm1
has this risk, how about just adding a wrapper for pin function as below? amdgpu_get_pin_bo_timeout() { do { amdgpo_bo_reserve(); r=amdgpu_bo_pin(); if(!r)     break; amdgpu_bo_unreserve(); timeout--; } while(timeout>0); } Original Message ---- Subject: Re: [PATCH] ttm: w

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-24 Thread Christian König
timeout--; } while(timeout>0); } Original Message Subject: Re: [PATCH] ttm: wait mem space if user allow while gpu busy From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,"Liang, Prike" ,dri-devel@lists.freedesktop.org CC: We

Re:[PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-23 Thread Zhou, David(ChunMing)
l Message Subject: Re: [PATCH] ttm: wait mem space if user allow while gpu busy From: Christian König To: "Zhou, David(ChunMing)" ,"Koenig, Christian" ,"Liang, Prike" ,dri-devel@lists.freedesktop.org CC: Well that's not so easy of hand. The basic problem here is t

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-23 Thread Christian König
eb Zhou, David(ChunMing): How about adding more condition ctx->resv inline to address your concern? As well as don't wait from same user, shouldn't lead to deadlock. Otherwise, any other idea? Original Message Subject: Re: [PATCH] ttm: wait mem space if user allow

Re:[PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-23 Thread Zhou, David(ChunMing)
How about adding more condition ctx->resv inline to address your concern? As well as don't wait from same user, shouldn't lead to deadlock. Otherwise, any other idea? Original Message Subject: Re: [PATCH] ttm: wait mem space if user allow while gpu busy From: Ch

Re: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-23 Thread Christian König
Sent: Monday, April 22, 2019 6:39 PM To: dri-devel@lists.freedesktop.org Cc: Liang, Prike ; Zhou, David(ChunMing) Subject: [PATCH] ttm: wait mem space if user allow while gpu busy heavy gpu job could occupy memory long time, which could lead to other user fail to get memory. Chan

RE: [PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-22 Thread Liang, Prike
Acked-by: Prike Liang Thanks, Prike -Original Message- From: Chunming Zhou Sent: Monday, April 22, 2019 6:39 PM To: dri-devel@lists.freedesktop.org Cc: Liang, Prike ; Zhou, David(ChunMing) Subject: [PATCH] ttm: wait mem space if user allow while gpu busy heavy gpu job could occupy

[PATCH] ttm: wait mem space if user allow while gpu busy

2019-04-22 Thread Chunming Zhou
heavy gpu job could occupy memory long time, which could lead to other user fail to get memory. Change-Id: I0b322d98cd76e5ac32b00462bbae8008d76c5e11 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/ttm/ttm_bo.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[PATCH] ttm/drm: constify ttm_backend_func structures

2015-12-11 Thread Christian König
On 11.12.2015 14:37, Julia Lawall wrote: > The ttm_backend_func structures are never modified, so declare them as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Reviewed-by: Christian König > > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |2 +- > driver

[PATCH] ttm/drm: constify ttm_backend_func structures

2015-12-11 Thread Julia Lawall
The ttm_backend_func structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c |2 +- drivers/gpu/drm/ast/ast_ttm.c |2 +- drivers/gpu/drm/bochs/bochs_mm.c|2 +

[PATCH] ttm: use NULL instead of 0 for ttm_bo_reserve()'s pointer arg.

2014-06-16 Thread Jingoo Han
On Sunday, June 15, 2014 9:11 AM, Martin Kepplinger wrote: > > Fix a sparse warning: ttm_bo_reserve()'s last argument is a > pointer to a struct, so use NULL as nullpointer. > > Signed-off-by: Martin Kepplinger Reviewed-by: Jingoo Han Best regards, Jingoo Han > --- > this applies to next-201

[PATCH] ttm: use NULL instead of 0 for ttm_bo_reserve()'s pointer arg.

2014-06-15 Thread Martin Kepplinger
Fix a sparse warning: ttm_bo_reserve()'s last argument is a pointer to a struct, so use NULL as nullpointer. Signed-off-by: Martin Kepplinger --- this applies to next-20140613. Please ignore if annoyingly irrelevant. drivers/gpu/drm/ttm/ttm_bo.c | 14 +++--- 1 file changed, 7 insertio

[PATCH] ttm: on move memory failure don't leave a node dangling

2013-01-16 Thread Dave Airlie
if we have a move notify callback, when moving fails, we call move notify the opposite way around, however this ends up with *mem containing the mm_node from the bo, which means we double free it. This is a follow on to the previous fix. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.

[PATCH] ttm: don't destroy old mm_node on memcpy failure

2013-01-16 Thread Dave Airlie
When we are using memcpy to move objects around, and we fail to memcpy due to lack of memory to populate or failure to finish the copy, we don't want to destroy the mm_node that has been copied into old_copy. While working on a new kms driver that uses memcpy, if I overallocated bo's up to the mem

[PATCH] ttm: on move memory failure don't leave a node dangling

2013-01-16 Thread Jerome Glisse
On Wed, Jan 16, 2013 at 1:01 AM, Dave Airlie wrote: > if we have a move notify callback, when moving fails, we call move notify > the opposite way around, however this ends up with *mem containing the mm_node > from the bo, which means we double free it. This is a follow on to the > previous > fi

[PATCH] ttm: don't destroy old mm_node on memcpy failure

2013-01-16 Thread Jerome Glisse
On Tue, Jan 15, 2013 at 11:28 PM, Dave Airlie wrote: > When we are using memcpy to move objects around, and we fail to memcpy > due to lack of memory to populate or failure to finish the copy, we don't > want to destroy the mm_node that has been copied into old_copy. > > While working on a new kms

Re: [PATCH] ttm: on move memory failure don't leave a node dangling

2013-01-16 Thread Jerome Glisse
On Wed, Jan 16, 2013 at 1:01 AM, Dave Airlie wrote: > if we have a move notify callback, when moving fails, we call move notify > the opposite way around, however this ends up with *mem containing the mm_node > from the bo, which means we double free it. This is a follow on to the > previous > fi

Re: [PATCH] ttm: don't destroy old mm_node on memcpy failure

2013-01-16 Thread Jerome Glisse
On Tue, Jan 15, 2013 at 11:28 PM, Dave Airlie wrote: > When we are using memcpy to move objects around, and we fail to memcpy > due to lack of memory to populate or failure to finish the copy, we don't > want to destroy the mm_node that has been copied into old_copy. > > While working on a new kms

[PATCH] ttm: on move memory failure don't leave a node dangling

2013-01-15 Thread Dave Airlie
if we have a move notify callback, when moving fails, we call move notify the opposite way around, however this ends up with *mem containing the mm_node from the bo, which means we double free it. This is a follow on to the previous fix. Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.

[PATCH] ttm: don't destroy old mm_node on memcpy failure

2013-01-15 Thread Dave Airlie
When we are using memcpy to move objects around, and we fail to memcpy due to lack of memory to populate or failure to finish the copy, we don't want to destroy the mm_node that has been copied into old_copy. While working on a new kms driver that uses memcpy, if I overallocated bo's up to the mem

[PATCH] ttm/dma: Remove the WARN() which is not useful.

2012-01-12 Thread Jerome Glisse
On Thu, Jan 12, 2012 at 11:50:26AM -0500, Konrad Rzeszutek Wilk wrote: > . It was useful during development, but now on a production system > we can get this (if the user forgot to upload the firmware): > > [drm] radeon: irq initialized. > [drm] GART: num cpu pages 131072, num gpu pages 131072 > [

Re: [PATCH] ttm/dma: Remove the WARN() which is not useful.

2012-01-12 Thread Jerome Glisse
On Thu, Jan 12, 2012 at 11:50:26AM -0500, Konrad Rzeszutek Wilk wrote: > . It was useful during development, but now on a production system > we can get this (if the user forgot to upload the firmware): > > [drm] radeon: irq initialized. > [drm] GART: num cpu pages 131072, num gpu pages 131072 > [

[PATCH] ttm/dma: Remove the WARN() which is not useful.

2012-01-12 Thread Konrad Rzeszutek Wilk
. It was useful during development, but now on a production system we can get this (if the user forgot to upload the firmware): [drm] radeon: irq initialized. [drm] GART: num cpu pages 131072, num gpu pages 131072 [drm] radeon: ib pool ready. [drm] Loading SUMO Microcode r600_cp: Failed to load fi

[PATCH] ttm/dma: Remove the WARN() which is not useful.

2012-01-12 Thread Konrad Rzeszutek Wilk
. It was useful during development, but now on a production system we can get this (if the user forgot to upload the firmware): [drm] radeon: irq initialized. [drm] GART: num cpu pages 131072, num gpu pages 131072 [drm] radeon: ib pool ready. [drm] Loading SUMO Microcode r600_cp: Failed to load fi

[PATCH] TTM-DEBUG-PRINTK

2012-01-06 Thread Jerome Glisse
--- drivers/gpu/drm/nouveau/nouveau_bo.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 724b41a..326b64a 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nou

[PATCH] ttm: fix agp since ttm tt rework

2012-01-03 Thread Jerome Glisse
ttm tt rework modified the way we allocate and populate the ttm_tt structure, the AGP side was missing some bit to properly work. Fix those and fix radeon and nouveau AGP support. Tested on radeon only so far. Signed-off-by: Jerome Glisse --- drivers/gpu/drm/nouveau/nouveau_bo.c | 13 +++

[PATCH] TTM DMA pool v2.1

2011-10-31 Thread Jerome Glisse
On Wed, Oct 19, 2011 at 06:19:21PM -0400, Konrad Rzeszutek Wilk wrote: > [.. and this is what I said in v1 post]: > > Way back in January this patchset: > http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html > was merged in, but pieces of it had to be reverted b/c they did not

Re: [PATCH] TTM DMA pool v2.1

2011-10-31 Thread Jerome Glisse
On Wed, Oct 19, 2011 at 06:19:21PM -0400, Konrad Rzeszutek Wilk wrote: > [.. and this is what I said in v1 post]: > > Way back in January this patchset: > http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html > was merged in, but pieces of it had to be reverted b/c they did not

[PATCH] TTM DMA pool v2.1

2011-10-19 Thread Konrad Rzeszutek Wilk
On Wed, Oct 19, 2011 at 06:19:21PM -0400, Konrad Rzeszutek Wilk wrote: Hmm, seems a part of this got eaten by the Internet monsters. Since v2.0: [not posted] - Redid the registration/override to be tightly integrated with the 'struct ttm_backend_func' per Thomas's suggestion. Since v1.9: [not

Re: [PATCH] TTM DMA pool v2.1

2011-10-19 Thread Konrad Rzeszutek Wilk
On Wed, Oct 19, 2011 at 06:19:21PM -0400, Konrad Rzeszutek Wilk wrote: Hmm, seems a part of this got eaten by the Internet monsters. Since v2.0: [not posted] - Redid the registration/override to be tightly integrated with the 'struct ttm_backend_func' per Thomas's suggestion. Since v1.9: [not

[PATCH] TTM DMA pool v2.1

2011-10-19 Thread Konrad Rzeszutek Wilk
[.. and this is what I said in v1 post]: Way back in January this patchset: http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html was merged in, but pieces of it had to be reverted b/c they did not work properly under PowerPC, ARM, and when swapping out pages to disk. After a b

[PATCH] TTM DMA pool v2.1

2011-10-19 Thread Konrad Rzeszutek Wilk
[.. and this is what I said in v1 post]: Way back in January this patchset: http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html was merged in, but pieces of it had to be reverted b/c they did not work properly under PowerPC, ARM, and when swapping out pages to disk. After a b

[PATCH] TTM DMA pool v1.8

2011-10-03 Thread Thomas Hellstrom
On 10/03/2011 06:46 PM, Konrad Rzeszutek Wilk wrote: > > It does now (I had a spinlock mishap).. which reminds me - how > do I test these patches with your vmwgfx driver? I've an old version > of VMWare Workstation 8, would that do? > VMware workstation 8 is OK (it's actually the latest versio

[PATCH] TTM DMA pool v1.8

2011-10-03 Thread Thomas Hellstrom
On 09/30/2011 04:09 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: > >> Konrad, >> >> I'm really sorry for taking so long to review this. >> > That is OK. We all are busy - and it gave me some time to pretty > up the code even more. >

[PATCH] TTM DMA pool v1.8

2011-10-03 Thread Konrad Rzeszutek Wilk
On Mon, Oct 03, 2011 at 06:35:42PM +0200, Thomas Hellstrom wrote: > On 09/30/2011 04:09 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: > >>Konrad, > >> > >>I'm really sorry for taking so long to review this. > >That is OK. We all are busy - and

Re: [PATCH] TTM DMA pool v1.8

2011-10-03 Thread Thomas Hellstrom
On 10/03/2011 06:46 PM, Konrad Rzeszutek Wilk wrote: It does now (I had a spinlock mishap).. which reminds me - how do I test these patches with your vmwgfx driver? I've an old version of VMWare Workstation 8, would that do? VMware workstation 8 is OK (it's actually the latest version of

Re: [PATCH] TTM DMA pool v1.8

2011-10-03 Thread Konrad Rzeszutek Wilk
On Mon, Oct 03, 2011 at 06:35:42PM +0200, Thomas Hellstrom wrote: > On 09/30/2011 04:09 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: > >>Konrad, > >> > >>I'm really sorry for taking so long to review this. > >That is OK. We all are busy - and

Re: [PATCH] TTM DMA pool v1.8

2011-10-03 Thread Thomas Hellstrom
On 09/30/2011 04:09 PM, Konrad Rzeszutek Wilk wrote: On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: Konrad, I'm really sorry for taking so long to review this. That is OK. We all are busy - and it gave me some time to pretty up the code even more. I'd like to

[PATCH] TTM DMA pool v1.8

2011-09-30 Thread Konrad Rzeszutek Wilk
On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: > Konrad, > > I'm really sorry for taking so long to review this. That is OK. We all are busy - and it gave me some time to pretty up the code even more. > > I'd like to go through a couple of high-level things first before > rev

[PATCH] TTM DMA pool v1.8

2011-09-30 Thread Thomas Hellstrom
Konrad, I'm really sorry for taking so long to review this. I'd like to go through a couple of high-level things first before reviewing the coding itself. The page_alloc_func structure looks nice, but I'd like to have it per ttm backend, we would just need to make sure that the backend is aliv

Re: [PATCH] TTM DMA pool v1.8

2011-09-30 Thread Konrad Rzeszutek Wilk
On Fri, Sep 30, 2011 at 08:59:52AM +0200, Thomas Hellstrom wrote: > Konrad, > > I'm really sorry for taking so long to review this. That is OK. We all are busy - and it gave me some time to pretty up the code even more. > > I'd like to go through a couple of high-level things first before > rev

Re: [PATCH] TTM DMA pool v1.8

2011-09-30 Thread Thomas Hellstrom
Konrad, I'm really sorry for taking so long to review this. I'd like to go through a couple of high-level things first before reviewing the coding itself. The page_alloc_func structure looks nice, but I'd like to have it per ttm backend, we would just need to make sure that the backend is al

[PATCH] TTM DMA pool v1.8

2011-09-29 Thread Konrad Rzeszutek Wilk
[.. and this is what I said in v1 post]: Way back in January this patchset: http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html was merged in, but pieces of it had to be reverted b/c they did not work properly under PowerPC, ARM, and when swapping out pages to disk. After a b

[PATCH] TTM DMA pool v1.8

2011-09-29 Thread Konrad Rzeszutek Wilk
[.. and this is what I said in v1 post]: Way back in January this patchset: http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html was merged in, but pieces of it had to be reverted b/c they did not work properly under PowerPC, ARM, and when swapping out pages to disk. After a b

[PATCH] TTM DMA v1.8

2011-09-13 Thread Konrad Rzeszutek Wilk
Since v1.7: [https://lkml.org/lkml/2011/8/30/460] - Fixed checking the DMA address in radeon/nouveau code. Since v1: [http://lwn.net/Articles/456246/] - Ran it through the gauntlet of SubmitChecklist and fixed issues - Made radeon/nouveau driver set coherent_dma (which is required for dmapool)

[PATCH] TTM DMA v1.8

2011-09-13 Thread Konrad Rzeszutek Wilk
Since v1.7: [https://lkml.org/lkml/2011/8/30/460] - Fixed checking the DMA address in radeon/nouveau code. Since v1: [http://lwn.net/Articles/456246/] - Ran it through the gauntlet of SubmitChecklist and fixed issues - Made radeon/nouveau driver set coherent_dma (which is required for dmapool)

[PATCH] TTM DMA pool v1.7

2011-08-30 Thread Konrad Rzeszutek Wilk
Since v1: [http://lwn.net/Articles/456246/] - Ran it through the gauntlet of SubmitChecklist and fixed issues - Made radeon/nouveau driver set coherent_dma (which is required for dmapool) [.. and this is what I said in v1 post]: Way back in January this patchset: http://lists.freedesktop.org/ar

[PATCH] TTM DMA pool v1.7

2011-08-30 Thread Konrad Rzeszutek Wilk
Since v1: [http://lwn.net/Articles/456246/] - Ran it through the gauntlet of SubmitChecklist and fixed issues - Made radeon/nouveau driver set coherent_dma (which is required for dmapool) [.. and this is what I said in v1 post]: Way back in January this patchset: http://lists.freedesktop.org/ar

[RFC PATCH] TTM DMA pool v1

2011-08-25 Thread Michel Dänzer
On Mit, 2011-08-24 at 13:16 -0400, Konrad Rzeszutek Wilk wrote: > > My PowerPC has issues with booting a virgin 3.0 kernel (something about > "ELF image not correct") so I don't have that yet covered. I tested your patches on my PowerBook with a Radeon. Tested-by: Michel D?nzer -- Earthling

[RFC PATCH] TTM DMA pool v1

2011-08-25 Thread Konrad Rzeszutek Wilk
On Thu, Aug 25, 2011 at 05:28:09PM +0200, Michel D?nzer wrote: > On Mit, 2011-08-24 at 13:16 -0400, Konrad Rzeszutek Wilk wrote: > > > > My PowerPC has issues with booting a virgin 3.0 kernel (something about > > "ELF image not correct") so I don't have that yet covered. > > I tested your patches

Re: [RFC PATCH] TTM DMA pool v1

2011-08-25 Thread Konrad Rzeszutek Wilk
On Thu, Aug 25, 2011 at 05:28:09PM +0200, Michel Dänzer wrote: > On Mit, 2011-08-24 at 13:16 -0400, Konrad Rzeszutek Wilk wrote: > > > > My PowerPC has issues with booting a virgin 3.0 kernel (something about > > "ELF image not correct") so I don't have that yet covered. > > I tested your patches

Re: [RFC PATCH] TTM DMA pool v1

2011-08-25 Thread Michel Dänzer
On Mit, 2011-08-24 at 13:16 -0400, Konrad Rzeszutek Wilk wrote: > > My PowerPC has issues with booting a virgin 3.0 kernel (something about > "ELF image not correct") so I don't have that yet covered. I tested your patches on my PowerBook with a Radeon. Tested-by: Michel Dänzer -- Earthling

[RFC PATCH] TTM DMA pool v1

2011-08-24 Thread Konrad Rzeszutek Wilk
Way back in January this patchset: http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html was merged in, but pieces of it had to be reverted b/c they did not work properly under PowerPC, ARM, and when swapping out pages to disk. After a bit of discussion on the mailing list http:

[RFC PATCH] TTM DMA pool v1

2011-08-24 Thread Konrad Rzeszutek Wilk
Way back in January this patchset: http://lists.freedesktop.org/archives/dri-devel/2011-January/006905.html was merged in, but pieces of it had to be reverted b/c they did not work properly under PowerPC, ARM, and when swapping out pages to disk. After a bit of discussion on the mailing list http:

[PATCH] ttm: Fix spelling mistakes and remove unused #ifdef

2011-06-08 Thread Konrad Rzeszutek Wilk
. and some comments to make it easier to understand. Ackedby: Randy Dunlap [v2: Added some more updates from Randy Dunlap] Signed-off-by: Konrad Rzeszutek Wilk --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 16 include/drm/ttm/ttm_bo_api.h |3 --- include/drm/ttm/ttm_

[PATCH] ttm: Do not increment the amount of pages in a pool by the current amount

2011-06-08 Thread Konrad Rzeszutek Wilk
.instead increment it by the count of pages that we want to splice into the pool list. In other words we were incrementing the pool->npages by the wrong amount. This bug was observed from code inspection. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/gpu/drm/ttm/ttm_page_alloc.c |2 +- 1

[PATCH] ttm: Fix spelling mistakes and remove unused #ifdef

2011-06-08 Thread Konrad Rzeszutek Wilk
. and some comments to make it easier to understand. Ackedby: Randy Dunlap [v2: Added some more updates from Randy Dunlap] Signed-off-by: Konrad Rzeszutek Wilk --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 16 include/drm/ttm/ttm_bo_api.h |3 --- include/drm/ttm/ttm_

[PATCH] ttm: Do not increment the amount of pages in a pool by the current amount

2011-06-08 Thread Konrad Rzeszutek Wilk
.instead increment it by the count of pages that we want to splice into the pool list. In other words we were incrementing the pool->npages by the wrong amount. This bug was observed from code inspection. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/gpu/drm/ttm/ttm_page_alloc.c |2 +- 1

[PATCH] ttm: Fix spelling mistakes and remove unused #ifdef

2011-06-07 Thread Konrad Rzeszutek Wilk
. and some comments to make it easier to understand. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 14 +++--- include/drm/ttm/ttm_bo_api.h |3 --- include/drm/ttm/ttm_bo_driver.h |6 +++--- include/drm/ttm/ttm_memory.h |

Re: [PATCH] ttm: Fix spelling mistakes and remove unused #ifdef

2011-06-07 Thread Randy Dunlap
On Tue, 7 Jun 2011 14:35:52 -0400 Konrad Rzeszutek Wilk wrote: > . and some comments to make it easier to understand. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > drivers/gpu/drm/ttm/ttm_page_alloc.c | 14 +++--- > include/drm/ttm/ttm_bo_api.h |3 --- > include/drm/tt

[PATCH] ttm: Fix spelling mistakes and remove unused #ifdef

2011-06-07 Thread Randy Dunlap
On Tue, 7 Jun 2011 14:35:52 -0400 Konrad Rzeszutek Wilk wrote: > . and some comments to make it easier to understand. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > drivers/gpu/drm/ttm/ttm_page_alloc.c | 14 +++--- > include/drm/ttm/ttm_bo_api.h |3 --- > include/drm/tt

[PATCH] ttm: Fix spelling mistakes and remove unused #ifdef

2011-06-07 Thread Konrad Rzeszutek Wilk
. and some comments to make it easier to understand. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 14 +++--- include/drm/ttm/ttm_bo_api.h |3 --- include/drm/ttm/ttm_bo_driver.h |6 +++--- include/drm/ttm/ttm_memory.h |

[PATCH] TTM: fix the issue that user buffers are not

2010-06-29 Thread Austin Yuan
populuated due to the wrong state Signed-off-by: Austin Yuan Signed-off-by: Elaine Wang --- drivers/gpu/drm/ttm/ttm_tt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index a7bab87..4ea44c2 100644 --- a/driv