Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-18 Thread Thomas Zimmermann
Hi Am 18.06.20 um 03:40 schrieb Rong Chen: > > > On 6/17/20 8:29 PM, Thomas Zimmermann wrote: >> Hi >> >> Am 17.06.20 um 11:22 schrieb Rong Chen: >>> On Wed, Jun 17, 2020 at 08:28:02AM +0200, Thomas Zimmermann wrote: Hi Emil Am 16.06.20 um 17:14 schrieb Emil Velikov: > Hi Thom

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Rong Chen
On 6/17/20 8:29 PM, Thomas Zimmermann wrote: Hi Am 17.06.20 um 11:22 schrieb Rong Chen: On Wed, Jun 17, 2020 at 08:28:02AM +0200, Thomas Zimmermann wrote: Hi Emil Am 16.06.20 um 17:14 schrieb Emil Velikov: Hi Thomas, On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: The original m

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Emil Velikov
On Wed, 17 Jun 2020 at 07:28, Thomas Zimmermann wrote: > Maybe I can write a better commit message to highlight the change. > That would be amazing, thank you. Emil ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.or

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Thomas Zimmermann
Hi Am 17.06.20 um 11:22 schrieb Rong Chen: > On Wed, Jun 17, 2020 at 08:28:02AM +0200, Thomas Zimmermann wrote: >> Hi Emil >> >> Am 16.06.20 um 17:14 schrieb Emil Velikov: >>> Hi Thomas, >>> >>> On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: The original modesetting code set MIS

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-17 Thread Rong Chen
On Wed, Jun 17, 2020 at 08:28:02AM +0200, Thomas Zimmermann wrote: > Hi Emil > > Am 16.06.20 um 17:14 schrieb Emil Velikov: > > Hi Thomas, > > > > On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: > >> > >> The original modesetting code set MISC to 0x2d, which is , > >> and > >> > >> With

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-16 Thread Thomas Zimmermann
Hi Emil Am 16.06.20 um 17:14 schrieb Emil Velikov: > Hi Thomas, > > On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: >> >> The original modesetting code set MISC to 0x2d, which is , >> and >> >> With the conversion to atomic modesetting, accidentally >> got enabled as well. Revert this

Re: [PATCH] drm/mgag200: Don't set in MISC

2020-06-16 Thread Emil Velikov
Hi Thomas, On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann wrote: > > The original modesetting code set MISC to 0x2d, which is , > and > > With the conversion to atomic modesetting, accidentally > got enabled as well. Revert this change and initialize MISC with a > constant value of and . The

[PATCH] drm/mgag200: Don't set in MISC

2020-06-16 Thread Thomas Zimmermann
The original modesetting code set MISC to 0x2d, which is , and With the conversion to atomic modesetting, accidentally got enabled as well. Revert this change and initialize MISC with a constant value of and . The bits are set in mga_crtc_set_plls(), sync flags are set in mgag200_set_mode_reg