Hi Emil Am 16.06.20 um 17:14 schrieb Emil Velikov: > Hi Thomas, > > On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann <tzimmerm...@suse.de> wrote: >> >> The original modesetting code set MISC to 0x2d, which is <hpgoddev>, >> <clksel> and <ioaddsel> >> >> With the conversion to atomic modesetting, <rammapen> accidentally >> got enabled as well. Revert this change and initialize MISC with a >> constant value of <hgoddev> and <ioaddsel>. The <clksel> bits are set >> in mga_crtc_set_plls(), sync flags are set in mgag200_set_mode_regs(). >> > > Let's keep the remove (restoring original functionality) and rename > (cosmetics) separate patches. The read has also disappeared, which > should be safe although might be better on it's own.
I'm waiting for Rong Chen's performance results on this patch. Moving the rename into a separate patch makes sense, but removing the read is part of restoring the original behavior. I think it should be in this patch. Maybe I can write a better commit message to highlight the change. Best regards Thomas > > Thanks > Emil > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
