Re: [PATCH v7 3/3] arm64: dts: imx8mm-phyboard-polis-peb-av-10: Set lvds-vod-swing

2025-04-21 Thread Shawn Guo
On Mon, Dec 16, 2024 at 09:54:10AM +0100, Andrej Picej wrote: > Set custom differential output voltage for LVDS, to fulfill requirements > of the connected display. LVDS differential voltage for data-lanes and > clock output has to be between 200 mV and 600 mV. > Driver sets 200 Ohm near-end termin

Re: [PATCH v2 00/10] arm64: dts: imx8mp-skov: flesh out device trees

2025-02-17 Thread Shawn Guo
play/lvds-codec: add ti,sn65lvds822 Applied all except this bindings change which I assume display or DT folks will pick up. Shawn > arm64: dts: imx8mp-skov: configure uart1 for RS485 > > Oleksij Rempel (5): > arm64: dts: imx8mp-skov: describe HDMI display pipeline >

Re: [PATCH 1/2] ARM: dts: imx7s: Move csi-mux to below root

2025-02-17 Thread Shawn Guo
On Tue, Jan 07, 2025 at 10:49:41AM +0100, Alexander Stein wrote: > fsl,imx-iomuxc-gpr.yaml only contains the mux-controller but the actual > video-mux is not part of it. So move it below root node. > Fixes the dtbs_check warning: > arch/arm/boot/dts/nxp/imx/imx7s-mba7.dtb: iomuxc-gpr@3034: 'csi

Re: [PATCH v2 2/2] arm64: dts: imx8mm-phg: Add LVDS compatible string

2024-12-29 Thread Shawn Guo
On Tue, Dec 10, 2024 at 07:57:05AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > The imx8mm-phg board has an AUO G084SN05 V9 8.4" 800x600 LVDS panel. > > Improve the devicetree description by passing the LVDS compatible > string to fix the following dt-schema warning: > > imx8mm-phg.dtb

Re: [PATCH v6 7/7] arm64: defconfig: Enable ITE IT6263 driver

2024-12-09 Thread Shawn Guo
On Tue, Nov 12, 2024 at 06:05:47PM +0800, Liu Ying wrote: > ITE IT6263 LVDS to HDMI converter is populated on NXP IMX-LVDS-HDMI > and IMX-DLVDS-HDMI adapter cards. The adapter cards can connect to > i.MX8MP EVK base board to support video output through HDMI connectors. > Build the ITE IT6263 driv

Re: [PATCH v6 1/7] arm64: dts: imx8mp-skov-revb-mi1010ait-1cp1: Set "media_disp2_pix" clock rate to 70MHz

2024-12-09 Thread Shawn Guo
On Tue, Nov 12, 2024 at 06:05:41PM +0800, Liu Ying wrote: > The LVDS panel "multi-inno,mi1010ait-1cp" used on this platform has > a typical pixel clock rate of 70MHz. Set "media_disp2_pix" clock rate > to that rate, instead of the original 68.9MHz. The LVDS serial clock > is controlled by "media_

Re: [PATCH v3 0/4] arm64: dts: imx8mm-kontron: Add HDMI and LVDS display support

2024-10-21 Thread Shawn Guo
On Tue, Oct 08, 2024 at 04:37:42PM +0200, Frieder Schrempf wrote: > Frieder Schrempf (4): ... > arm64: dts: imx8mm-kontron: Add support for display bridges on BL > i.MX8MM > arm64: dts: imx8mm-kontron: Add DL (Display-Line) overlay with LVDS > support Applied both, thanks!

Re: [PATCH v2 0/4] arm64: dts: imx8mm-kontron: Add HDMI and LVDS display support

2024-10-08 Thread Shawn Guo
Jenson > > BL-JT60050-01A > > arm64: dts: imx8mm-kontron: Add support for display bridges on BL > > i.MX8MM > > arm64: dts: imx8mm-kontron: Add DL (Display-Line) overlay with LVDS > > support > > Gentle ping for this series. Neil proposed to apply p

[PATCH] drm/mediatek: Remove less-than-zero comparison of an unsigned value

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Fix a Coverity error that less-than-zero comparison of an unsigned value is never true. Fixes: 0d9eee9118b7 ("drm/mediatek: Add drm ovl_adaptor sub driver for MT8195") Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 +- 1 file changed, 1 i

[PATCH v9 08/21] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support RGBA and RGBX formats in OVL on MT8195. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediate

[PATCH v9 19/21] drm/mediatek: Support CRC in display driver

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Register CRC related function pointers to support CRC retrieval. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 279 drivers/gpu/drm/mediatek/mtk_crtc.h | 38 drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 5

[PATCH v9 07/21] drm/mediatek: Support more 10bit formats in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support more 10bit formats in OVL. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 32 ++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH v9 06/21] drm/mediatek: Turn off the layers with zero width or height

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such a situation. Fixes: 777b7bc86a0a ("UPSTREAM: drm/mediatek: Add ovl_adaptor support for MT8195") Fixes: fa97fe71f6

[PATCH v9 18/21] drm/mediatek: Support alpha blending in display driver

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" and "None" blend mode on MediaTek's chips by adding correct blend mode property when the planes init. Before this patch, only the "Coverage" mode (default) is supported. For more information, there are three pixel blend modes in DRM driver: "None",

[PATCH v9 20/21] drm/mediatek: Support CRC in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung We choose OVL as the CRC generator from other hardware components that are also capable of calculating CRCs, since its frame done event triggers vblanks, it can be used as a signal to know when is safe to retrieve CRC of the frame. Please note that position of the hardware

[PATCH v9 14/21] drm/mediatek: Support "None" blending in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/

[PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode on in OVL. Before this patch, only the "coverage" mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 42 - 1 file changed, 34 insertions(+), 8 deletions(-)

[PATCH v9 15/21] drm/mediatek: Support "None" blending in Mixer

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_et

[PATCH v9 12/21] drm/mediatek: Support DRM plane alpha in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Set the plane alpha according to DRM plane property. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/

[PATCH v9 13/21] drm/mediatek: Support DRM plane alpha in Mixer

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Set the plane alpha according to DRM plane property. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_et

[PATCH v9 05/21] drm/mediatek: Set DRM mode configs accordingly

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Set DRM mode configs limitation according to the hardware capabilities and pass the IGT checks as below: - The test "graphics.IgtKms.kms_plane" requires a frame buffer with width of 4512 pixels (> 4096). - The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor si

[PATCH v9 21/21] drm/mediatek: Support CRC in OVL adaptor

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung We choose Mixer as CRC generator in OVL adaptor since its frame done event will trigger vblanks, we can know when is safe to retrieve CRC of the frame. In OVL adaptor, there's no image procession after Mixer, unlike the OVL in VDOSYS0, Mixer's CRC will include all the effe

[PATCH v9 17/21] drm/mediatek: Support "Pre-multiplied" blending in Mixer

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode in Mixer. Before this patch, only the coverage mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v9 00/21] Support IGT in display driver

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung This series adds support for running IGT (Intel GPU Tool) tests with MediaTek display driver. The following changes will be applied: 1. Add a new API for creating GCE thread loop to retrieve CRCs from the hardware component 2. Support hardware CRC calculation in both VD

[PATCH v9 10/21] drm/mediatek: Fix XRGB setting error in Mixer

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Although the alpha channel in XRGB formats can be ignored, ALPHA_CON must be configured accordingly when using XRGB formats or it will still affects CRC generation. Fixes: d886c0009bd0 ("drm/mediatek: Add ETHDR support for MT8195") Signed-off-by: Hsiao Chien Sung --- dri

[PATCH v9 09/21] drm/mediatek: Fix XRGB setting error in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung CONST_BLD must be enabled for XRGB formats although the alpha channel can be ignored, or OVL will still read the value from memory. This error only affects CRC generation. Fixes: c410fa9b07c3 ("drm/mediatek: Add AFBC support to Mediatek DRM driver") Signed-off-by: Hsiao Ch

[PATCH v9 11/21] drm/mediatek: Add new color format MACROs in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Define new color formats to hide the bit operation in the MACROs to make the switch statement more concise. Change the MACROs to align the naming rule in DRM. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 14 -- 1 file changed,

[PATCH v9 04/21] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Always add DRM_MODE_ROTATE_0 to rotation property to meet IGT's (Intel GPU Tools) requirement. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 6 +- drivers/gpu/drm/mediatek/

[PATCH v9 03/21] drm/mediatek: Add missing plane settings when async update

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Fix an issue that plane coordinate was not saved when calling async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/d

[PATCH v9 01/21] soc: mediatek: Disable 9-bit alpha in ETHDR

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung When 9-bit alpha is enabled, its value will be converted from 0-255 to 0-256 (255 = not defined). This is designed for special HDR related calculation, which should be disabled by default, otherwise, alpha blending will not work correctly. Reviewed-by: AngeloGioacchino Del

[PATCH v9 02/21] drm/mediatek: Add OVL compatible name for MT8195

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 ins

[PATCH v8 00/16] Support IGT in display driver

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Based-on: commit 1613e604df0c ("Linux 6.10-rc1") This series adds support for running IGT (Intel GPU Tool) tests with MediaTek display driver. The following changes will be applied: 1. Add a new API for creating GCE thread loop to retrieve CRCs from the hardware compon

[PATCH v8 08/16] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support RGBA and RGBX formats in OVL on MT8195. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c in

[PATCH v8 15/16] drm/mediatek: Support CRC in OVL

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung We choose OVL as the CRC generator from other hardware components that are also capable of calculating CRCs, since its frame done event triggers vblanks, it can be used as a signal to know when is safe to retrieve CRC of the frame. Please note that position of the hardware

[PATCH v8 07/16] drm/mediatek: Support more 10bit formats in OVL

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support more 10bit formats in OVL. Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 32 ++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/dr

[PATCH v8 14/16] drm/mediatek: Support CRC in display driver

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Register CRC related function pointers to support CRC retrieval. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 280 drivers/gpu/drm/mediatek/mtk_crtc.h | 38 drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 5

[PATCH v8 05/16] drm/mediatek: Set DRM mode configs accordingly

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Set DRM mode configs limitation according to the hardware capabilities and pass the IGT checks as below: - The test "graphics.IgtKms.kms_plane" requires a frame buffer with width of 4512 pixels (> 4096). - The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor si

[PATCH v8 13/16] drm/mediatek: Support alpha blending in display driver

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" and "None" blend mode on MediaTek's chips by adding correct blend mode property when the planes init. Before this patch, only the "Coverage" mode (default) is supported. For more information, there are three pixel blend modes in DRM driver: "None",

[PATCH v8 04/16] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Always add DRM_MODE_ROTATE_0 to rotation property to meet IGT's (Intel GPU Tools) requirement. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 6 +- drivers/gpu/drm/mediatek/

[PATCH v8 12/16] drm/mediatek: Support "Pre-multiplied" blending in Mixer

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode in Mixer. Before this patch, only the coverage mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH v8 06/16] drm/mediatek: Turn off the layers with zero width or height

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such a situation. Fixes: 777b7bc86a0a ("UPSTREAM: drm/mediatek: Add ovl_adaptor support for MT8195") Fixes: fa97fe71f6

[PATCH v8 09/16] drm/mediatek: Support "None" blending in OVL

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gp

[PATCH v8 16/16] drm/mediatek: Support CRC in OVL adaptor

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung We choose Mixer as CRC generator in OVL adaptor since its frame done event will trigger vblanks, we can know when is safe to retrieve CRC of the frame. In OVL adaptor, there's no image procession after Mixer, unlike the OVL in VDOSYS0, Mixer's CRC will include all the effe

[PATCH v8 02/16] drm/mediatek: Add OVL compatible name for MT8195

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 ins

[PATCH v8 10/16] drm/mediatek: Support "None" blending in Mixer

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/me

[PATCH v8 03/16] drm/mediatek: Add missing plane settings when async update

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Fix an issue that plane coordinate was not saved when calling async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/d

[PATCH v8 11/16] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode on in OVL. Before this patch, only the "coverage" mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 40 + 1 file changed, 34 insertions(+), 6 deletions(-)

[PATCH v8 01/16] soc: mediatek: Disable 9-bit alpha in ETHDR

2024-06-06 Thread Shawn Sung
From: Hsiao Chien Sung When 9-bit alpha is enabled, its value will be converted from 0-255 to 0-256 (255 = not defined). This is designed for special HDR related calculation, which should be disabled by default, otherwise, alpha blending will not work correctly. Reviewed-by: AngeloGioacchino Del

Re: [PATCH V2 2/2] arm64: dts: imx8mp-beacon-kit: Enable HDMI bridge HPD

2024-06-02 Thread Shawn Guo
On Mon, Mar 04, 2024 at 06:48:58PM -0600, Adam Ford wrote: > The DSI to HDMI bridge supports hot-plut-detect, but the > driver didn't previously support a shared IRQ GPIO. With > the driver updated, the interrupt can be added to the bridge. > > Signed-off-by: Adam Ford > Reviewed-by: Laurent Pin

[PATCH v7 16/18] drm/mediatek: Support CRC in display driver

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Register CRC related function pointers to support CRC retrieval. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 260 drivers/gpu/drm/mediatek/mtk_crtc.h | 38 drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 3

[PATCH v7 17/18] drm/mediatek: Support CRC in OVL

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung We choose OVL as the CRC generator from other hardware components that are also capable of calculating CRCs, since its frame done event triggers vblanks, it can be used as a signal to know when is safe to retrieve CRC of the frame. Please note that position of the hardware

[PATCH v7 01/18] soc: mediatek: Disable 9-bit alpha in ETHDR

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung ETHDR 9-bit alpha should be disabled by default, otherwise alpha blending will not work. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mtk-mmsys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/mediate

[PATCH v7 14/18] drm/mediatek: Support "None" blending in Mixer

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_eth

[PATCH v7 10/18] drm/mediatek: Support constant blending in Mixer

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support constant blending in Mixer. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_ethdr.c ind

[PATCH v7 15/18] drm/mediatek: Support alpha blending in display driver

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" and "None" blend mode on MediaTek's chips by adding correct blend mode property when the planes init. Before this patch, only the "Coverage" mode (default) is supported. For more information, there are three pixel blend modes in DRM driver: "None",

[PATCH v7 11/18] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode on in OVL. Before this patch, only the "coverage" mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 41 + 1 file changed, 35 insertions(+), 6 deletions(-)

[PATCH v7 03/18] drm/mediatek: Add missing plane settings when async update

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Fix an issue that plane coordinate was not saved when calling async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/d

[PATCH v7 07/18] drm/mediatek: Support more 10bit formats in OVL

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support more 10bit formats in OVL. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 32 ++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediat

[PATCH v7 18/18] drm/mediatek: Support CRC in OVL adaptor

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung We choose Mixer as CRC generator in OVL adaptor since its frame done event will trigger vblanks, we can know when is safe to retrieve CRC of the frame. In OVL adaptor, there's no image procession after Mixer, unlike the OVL in VDOSYS0, Mixer's CRC will include all the effe

[PATCH v7 00/18] Support IGT in display driver

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung This series is based on 20240307013458.23550-1-jason-jh@mediatek.com This series adds support for running IGT (Intel GPU Tool) tests with MediaTek display driver. The following changes will be applied: 1. Add a new API for creating GCE thread loop to retrieve CRCs

[PATCH v7 12/18] drm/mediatek: Support "Pre-multiplied" blending in Mixer

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode in Mixer. Before this patch, only the coverage mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/dr

[PATCH v7 13/18] drm/mediatek: Support "None" blending in OVL

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/driver

[PATCH v7 05/18] drm/mediatek: Set DRM mode configs accordingly

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Set DRM mode configs limitation according to the hardware capabilities and pass the IGT checks as below: - The test "graphics.IgtKms.kms_plane" requires a frame buffer with width of 4512 pixels (> 4096). - The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor si

[PATCH v7 04/18] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Always add DRM_MODE_ROTATE_0 to rotation property to meet IGT's (Intel GPU Tools) requirement. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 6 +- drivers/gpu/drm/mediatek/

[PATCH v7 08/18] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support RGBA and RGBX formats in OVL. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index d970cd

[PATCH v7 09/18] drm/mediatek: Support constant blending in OVL

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Support constant alpha blending in OVL. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_o

[PATCH v7 06/18] drm/mediatek: Turn off the layers with zero width or height

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such a situation. Fixes: 777b7bc86a0a ("UPSTREAM: drm/mediatek: Add ovl_adaptor support for MT8195") Fixes: fa97fe71f6

[PATCH v7 02/18] drm/mediatek: Add OVL compatible name for MT8195

2024-05-02 Thread Shawn Sung
From: Hsiao Chien Sung Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 ins

Re: [PATCH 3/7] ARM: configs: imx_v6_v7: Enable DRM_DW_HDMI

2024-04-21 Thread Shawn Guo
e > sure it's still enabled. > > Fixes: 4fc8cb47fcfd ("drm/display: Move HDMI helpers into display-helper > module") > Reported-by: Mark Brown > Reported-by: Alexander Stein > Signed-off-by: Maxime Ripard Acked-by: Shawn Guo

[PATCH v5 9/9] drm/mediatek: Add cmdq_insert_backup_cookie before secure pkt finalize

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add cmdq_insert_backup_cookie to append some commands before EOC: 1. Get GCE HW thread execute count from the GCE HW register. 2. Add 1 to the execute count and then store into a shared memory. 3. Set a software event siganl as secure irq to GCE HW. Since the value of execut

[PATCH v5 4/9] drm/mediatek: Add mtk_ddp_sec_write to config secure buffer info

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add mtk_ddp_sec_write to configure secure buffer information to cmdq secure packet data. Then secure cmdq driver will use these information to configure curresponding secure DRAM address to HW overlay in secure world. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien S

[PATCH v5 2/9] drm/mediatek: Add secure buffer control flow to mtk_drm_gem

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add secure buffer control flow to mtk_drm_gem. When user space takes DRM_MTK_GEM_CREATE_ENCRYPTED flag and size to create a mtk_drm_gem object, mtk_drm_gem will find a matched size dma buffer from secure dma-heap and bind it to mtk_drm_gem object. Signed-off-by: Jason-JH.Li

[PATCH v5 8/9] drm/mediatek: Add secure flow support to mediatek-drm

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" To add secure flow support for mediatek-drm, each crtc have to create a secure cmdq mailbox channel. Then cmdq packets with display HW configuration will be sent to secure cmdq mailbox channel and configured in the secure world. Each crtc have to use secure cmdq interface to

[PATCH v5 5/9] drm/mediatek: Add get_sec_port interface to mtk_ddp_comp

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add get_sec_port interface to ddp_comp to get the secure port settings from ovl and ovl_adaptor. Then mediatek-drm will use secure cmdq driver to configure DRAM access permission in secure world by their secure port settings. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao

[PATCH v5 7/9] drm/mediatek: Add secure layer config support for ovl_adaptor

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add secure layer config support for ovl_adaptor and sub driver mdp_rdma. Signed-off-by: Jason-JH.Lin Signed-off-by: Jason Chen Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1

[PATCH v5 0/9] Add mediate-drm secure flow for SVP

2024-04-03 Thread Shawn Sung
From: Hsiao Chien Sung Memory Definitions: secure memory - Memory allocated in the TEE (Trusted Execution Environment) which is inaccessible in the REE (Rich Execution Environment, i.e. linux kernel/userspace). secure handle - Integer value which acts as reference to 'secure memory'. Used in comm

[PATCH v5 6/9] drm/mediatek: Add secure layer config support for ovl

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add secure layer config support for ovl. TODO: 1. Move DISP_REG_OVL_SECURE setting to secure world. 2. Change the parameter addr in mtk_ddp_sec_write() to subsys. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 1

[PATCH v5 3/9] drm/mediatek: Add secure identify flag and funcution to mtk_drm_plane

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add is_sec flag to identify current mtk_drm_plane is secure. Add mtk_plane_is_sec_fb() to check current drm_framebuffer is secure. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_plane.c | 18 ++ drivers/gpu/drm

[PATCH v5 1/9] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATE_ENCRYPTED flag

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate a secure buffer to support secure video path feature. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- include/uapi/drm/mediatek_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/includ

[PATCH v4 6/9] drm/mediatek: Add secure layer config support for ovl_adaptor

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add secure layer config support for ovl_adaptor and sub driver mdp_rdma. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu/drm/mediate

[PATCH v4 8/9] drm/mediatek: Add secure flow support to mediatek-drm

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" To add secure flow support for mediatek-drm, each crtc have to create a secure cmdq mailbox channel. Then cmdq packets with display HW configuration will be sent to secure cmdq mailbox channel and configured in the secure world. Each crtc have to use secure cmdq interface to

[PATCH v4 9/9] drm/mediatek: Add cmdq_insert_backup_cookie before secure pkt finalize

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add cmdq_insert_backup_cookie to append some commands before EOC: 1. Get GCE HW thread execute count from the GCE HW register. 2. Add 1 to the execute count and then store into a shared memory. 3. Set a software event siganl as secure irq to GCE HW. Since the value of execut

[PATCH v4 5/9] drm/mediatek: Add get_sec_port interface to mtk_ddp_comp

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add get_sec_port interface to ddp_comp to get the secure port settings from ovl and ovl_adaptor. Then mediatek-drm will use secure cmdq driver to configure DRAM access permission in secure world by their secure port settings. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao

[PATCH v4 2/9] drm/mediatek: Add secure buffer control flow to mtk_drm_gem

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add secure buffer control flow to mtk_drm_gem. When user space takes DRM_MTK_GEM_CREATE_ENCRYPTED flag and size to create a mtk_drm_gem object, mtk_drm_gem will find a matched size dma buffer from secure dma-heap and bind it to mtk_drm_gem object. Signed-off-by: Jason-JH.Li

[PATCH v4 3/9] drm/mediatek: Add secure identify flag and funcution to mtk_drm_plane

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add is_sec flag to identify current mtk_drm_plane is secure. Add mtk_plane_is_sec_fb() to check current drm_framebuffer is secure. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_plane.c | 18 ++ drivers/gpu/drm

[PATCH v4 0/9] Add mediate-drm secure flow for SVP

2024-04-03 Thread Shawn Sung
From: Hsiao Chien Sung Memory Definitions: secure memory - Memory allocated in the TEE (Trusted Execution Environment) which is inaccessible in the REE (Rich Execution Environment, i.e. linux kernel/userspace). secure handle - Integer value which acts as reference to 'secure memory'. Used in comm

[PATCH v4 4/9] drm/mediatek: Add mtk_ddp_sec_write to config secure buffer info

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add mtk_ddp_sec_write to configure secure buffer information to cmdq secure packet data. Then secure cmdq driver will use these information to configure curresponding secure DRAM address to HW overlay in secure world. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien S

[PATCH v4 1/9] drm/mediatek/uapi: Add DRM_MTK_GEM_CREATE_ENCRYPTED flag

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add DRM_MTK_GEM_CREATE_ENCRYPTED flag to allow user to allocate a secure buffer to support secure video path feature. Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Chien Sung --- include/uapi/drm/mediatek_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/includ

[PATCH v4 7/9] drm/mediatek: Add secure layer config support for ovl

2024-04-03 Thread Shawn Sung
From: "Jason-JH.Lin" Add secure layer config support for ovl. TODO: 1. Move DISP_REG_OVL_SECURE setting to secure world. 2. Change the parameter register address in mtk_ddp_sec_write() from "u32 addr" to "struct cmdq_client_reg *cmdq_reg". Signed-off-by: Jason-JH.Lin Signed-off-by: Hsiao Ch

Re: [PATCH v4 03/14] drm/mediatek: Rename "mtk_drm_plane" to "mtk_plane"

2024-03-22 Thread Shawn Sung
Hi Angelo, On Fri, Mar 22, 2024 at 4:46 PM AngeloGioacchino Del Regno < angelogioacchino.delre...@collabora.com> wrote: > Il 22/03/24 02:27, Shawn Sung ha scritto: > > From: Hsiao Chien Sung > > > > Rename all "mtk_drm_plane" to "mtk_plane": >

[PATCH v5 02/14] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_ddp_comp" to "mtk_ddp_comp": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 +++- driv

[PATCH v5 14/14] drm/mediatek: Rename mtk_ddp_comp functions

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename functions of mtk_ddp_comp: - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 45 ++--- drivers/gpu/dr

[PATCH v5 12/14] drm/mediatek: Rename files "mtk_drm_gem.h" to "mtk_gem.h"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_gem.h to mtk_gem.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c| 2 +- drivers/

[PATCH v5 06/14] drm/mediatek: Rename files "mtk_drm_crtc.h" to "mtk_crtc.h"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_crtc.h to mtk_crtc.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/{mtk_drm_crtc.h => mtk_crtc.h} | 0 drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- drive

[PATCH v5 04/14] drm/mediatek: Rename "mtk_drm_gem" to "mtk_gem"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_gem" to "mtk_gem": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +-- drivers/gpu/drm/mediatek/mtk_d

[PATCH v5 01/14] drm/mediatek: Rename "mtk_drm_crtc" to "mtk_crtc"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_crtc" to "mtk_crtc" due to the following benefits: - Lower the matches when searching the native drm_crtc* codes - Reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/m

[PATCH v5 05/14] drm/mediatek: Rename "mtk_drm_hdmi" to "mtk_hdmi"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_hdmi" to "mtk_hdmi": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 +++--- 1 file changed, 7 inse

[PATCH v5 10/14] drm/mediatek: Rename files "mtk_drm_plane.h" to "mtk_plane.h"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_plane.h to mtk_plane.h. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_crtc.h | 2

[PATCH v5 03/14] drm/mediatek: Rename "mtk_drm_plane" to "mtk_plane"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_plane" to "mtk_plane": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 6 +++--- drivers/gpu/drm/mediatek

[PATCH v5 11/14] drm/mediatek: Rename files "mtk_drm_plane.c" to "mtk_plane.c"

2024-03-22 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_plane.c to mtk_plane.c and modify the Makefile accordingly. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm/mediatek

  1   2   3   4   5   6   7   >