Re: [PATCH v2] drm/bridge: it6505: support hdmi_codec_ops for audio stream setup

2025-02-04 Thread Pin-yen Lin
Hi Hermes, On Tue, Feb 4, 2025 at 11:49 AM wrote: > > Hi > > > >-Original Message- > >From: Dmitry Baryshkov > >Sent: Tuesday, February 4, 2025 1:28 AM > >To: Hermes Wu (吳佳宏) > >Cc: Andrzej Hajda ; Neil Armstrong > >; Robert Foss ; Laurent > >Pinchart ; Jonas Karlman > >; Jernej Skra

Re: [PATCH] drm/bridge: it6505: fix HDCP V match check is not performed correctly

2025-01-08 Thread Pin-yen Lin
Hi Hermes, On Thu, Jan 9, 2025 at 10:36 AM wrote: > > hi > > > >-Original Message- > >From: Dmitry Baryshkov > >Sent: Wednesday, January 8, 2025 6:43 PM > >To: Hermes Wu (吳佳宏) > >Cc: Andrzej Hajda ; Neil Armstrong > >; Robert Foss ; Laurent > >Pinchart ; Jonas Karlman > >; Jernej Skr

Re: [PATCH v4] drm/bridge:anx7625: Update HDCP content status

2024-12-19 Thread Pin-yen Lin
Change HDCP content value to DESIRED if HDCP status is ENABLE in bridge > interface .atomic_enable(). > > v3: > - Move hdcp content value checking from bridge interface > .atomic_check() to .atomic_enable() > > v2: > - Add more details in commit message > > Signed-off

Re: [PATCH v3] drm/bridge:anx7625: Update HDCP status at atomic_enable()

2024-12-16 Thread Pin-yen Lin
Hi Dmitry, On Mon, Dec 16, 2024 at 7:59 PM Dmitry Baryshkov wrote: > > On Mon, Dec 16, 2024 at 08:33:23AM +, Xin Ji wrote: > > > -Original Message- > > > From: Dmitry Baryshkov > > > Sent: Friday, December 13, 2024 9:17 PM > > > To: Xin Ji > > > Cc: Andrzej Hajda ; Neil Armstrong >

Re: [PATCH v2 3/3] dts: arm64: mediatek: mt8195: Remove MT8183 compatible for OVL

2024-12-13 Thread Pin-yen Lin
Hi Jason, On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin wrote: > > The OVL hardware capabilities have changed starting from MT8195, > making the MT8183 compatible no longer applicable. > Therefore, it is necessary to remove the MT8183 compatible for OVL. Similar to patch 2/3, we need a: Fixes: b

Re: [PATCH v2 2/3] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

2024-12-13 Thread Pin-yen Lin
Hi Jason, On Fri, Dec 13, 2024 at 5:50 PM Jason-JH.Lin wrote: > > The OVL hardware capabilities have changed starting from MT8195, > making the MT8183 compatible no longer applicable. > Therefore, it is necessary to update the OVL compatible from MT8183 to > MT8195. This probably doesn't need an

Re: [PATCH 1/2] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

2024-12-12 Thread Pin-yen Lin
Hi Jason, On Thu, Dec 12, 2024 at 11:33 PM Jason-JH.Lin wrote: > > From: Hsiao Chien Sung > > Modify rules for both MT8195 and MT8188. > Hardware capabilities include color formats and AFBC are > changed since MT8195, stop using the settings of MT8183. > > Acked-by: Rob Herring > Reviewed-by: A

Re: [PATCH v2] drm/bridge:anx7625: Update HDCP status at atomic_disable()

2024-12-11 Thread Pin-yen Lin
Hi Dimitry, Thanks for the review. On Wed, Dec 11, 2024 at 5:44 PM Dmitry Baryshkov wrote: > > On Mon, Dec 09, 2024 at 02:46:32PM +0800, Xin Ji wrote: > > When user enabled HDCP feature, upper layer will set HDCP content > > to DRM_MODE_CONTENT_PROTECTION_DESIRED. Next, anx7625 will update > > H

Re: [PATCH] drm/bridge:anx7625: Update HDCP status at atomic_disable()

2024-11-26 Thread Pin-yen Lin
On Wed, Nov 27, 2024 at 11:02 AM Xin Ji wrote: > > Update HDCP content_protection to DRM_MODE_CONTENT_PROTECTION_UNDESIRED > in bridge .atomic_disable(). > > Signed-off-by: Xin Ji Tested-by: Pin-yen Lin > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 25

Re: [PATCH v6 00/10] drm/bridge: it6505: fix HDCP CTS fail items and add MCCS support

2024-10-16 Thread Pin-yen Lin
Hi, On Wed, Oct 16, 2024 at 10:10 PM wrote: > > > > > > >-Original Message----- > >From: Pin-yen Lin > >Sent: Thursday, October 17, 2024 5:52 AM > >To: Hermes Wu (吳佳宏) > >Cc: Andrzej Hajda ; Neil Armstrong > >; Robert Foss ; Lauren

Re: [PATCH v6 00/10] drm/bridge: it6505: fix HDCP CTS fail items and add MCCS support

2024-10-16 Thread Pin-yen Lin
Hi Hermes, On Wed, Oct 16, 2024 at 3:54 AM Hermes Wu via B4 Relay wrote: > > This is a v6 patch-set. > > There are lots of failure items while running HDCP CTS using UNIGRAF DPR-100. > In Order to fix those failures, HDCP flow needs to be changed. > > The DisplayPort AUX protocol supports I2C tra

[PATCH v2 2/2] drm/bridge: it6505: Drop EDID cache on bridge power off

2024-09-26 Thread Pin-yen Lin
hen there is no EDID read after it is powered on. Drop the cache to force an EDID read after system resume to fix this. Fixes: 11feaef69d0c ("drm/bridge: it6505: Add caching for EDID") Signed-off-by: Pin-yen Lin Reviewed-by: Dmitry Baryshkov Reviewed-by: Douglas Anderson --- Change

[PATCH v2 1/2] drm/bridge: anx7625: Drop EDID cache on bridge power off

2024-09-26 Thread Pin-yen Lin
hen there is no EDID read after it is powered on. Drop the cache to force an EDID read after system resume to fix this. Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") Signed-off-by: Pin-yen Lin Reviewed-by: Dmitry Baryshkov --- Changes in v2: - Only drop t

[PATCH v2 0/2] Drop EDID cache for it6505/anx7625 when the bridge is powered off

2024-09-26 Thread Pin-yen Lin
x27;s powered on. This patch also works around the problem by always triggering the EDID read after the system resume. Changes in v2: - Only drop the EDID cache for anx7625 when it's not in eDP mode - Collect review tags Pin-yen Lin (2): drm/bridge: anx7625: Drop EDID cache on bridge power

Re: [PATCH 2/2] drm/bridge: it6505: Drop EDID cache on bridge power off

2024-09-24 Thread Pin-yen Lin
Hi, On Wed, Sep 25, 2024 at 1:48 AM Doug Anderson wrote: > > Hi, > > On Mon, Sep 23, 2024 at 8:53 PM Pin-yen Lin wrote: > > > > The bridge might miss the display change events when it's powered off. > > This happens when a user changes the external monitor w

Re: [PATCH 1/2] drm/bridge: anx7625: Drop EDID cache on bridge power off

2024-09-24 Thread Pin-yen Lin
Hi, On Wed, Sep 25, 2024 at 12:43 AM Doug Anderson wrote: > > Hi, > > On Mon, Sep 23, 2024 at 8:53 PM Pin-yen Lin wrote: > > > > The bridge might miss the display change events when it's powered off. > > This happens when a user changes the external monitor w

[PATCH 2/2] drm/bridge: it6505: Drop EDID cache on bridge power off

2024-09-23 Thread Pin-yen Lin
hen there is no EDID read after it is powered on. Drop the cache to force an EDID read after system resume to fix this. Fixes: 11feaef69d0c ("drm/bridge: it6505: Add caching for EDID") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 2 ++ 1 file changed, 2 inser

[PATCH 1/2] drm/bridge: anx7625: Drop EDID cache on bridge power off

2024-09-23 Thread Pin-yen Lin
hen there is no EDID read after it is powered on. Drop the cache to force an EDID read after system resume to fix this. Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/analogix/anx7625.c | 1 + 1 file

[PATCH 0/2] Drop EDID cache for it6505/anx7625 when the bridge is powered off

2024-09-23 Thread Pin-yen Lin
x27;s powered on. This patch also works around the problem by always triggering the EDID read after the system resume. Pin-yen Lin (2): drm/bridge: anx7625: Drop EDID cache on bridge power off drm/bridge: it6505: Drop EDID cache on bridge power off drivers/gpu/drm/bridge/analogix/anx7625.

Re: [PATCH v3 2/3] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-23 Thread Pin-yen Lin
On Tue, Sep 24, 2024 at 10:57 AM wrote: > > >On Mon, Sep 23, 2024 at 10:45:49AM GMT, hermes...@ite.com.tw wrote: > >> >On Mon, Sep 23, 2024 at 05:48:28PM GMT, Hermes Wu wrote: > >> >> From: Hermes Wu > >> >> > >> >> Changes in v3: > >> >> -add detials about fail item and changes. > >> >> > >> >>

Re: [PATCH v1] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-23 Thread Pin-yen Lin
assume you mean something needs to be a separate patch...? I don't really get this sentence. > Won't it become more complicate? > > it goes like this? > > Patch V1 aux > Patch V3 HDCP > Patch V3 MCCS The whole series should share the same version number, so y

Re: [PATCH v1 1/2] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-20 Thread Pin-yen Lin
Hi Hermes, On Thu, Sep 19, 2024 at 5:20 PM Hermes Wu wrote: > > From: allen chen > > Fix HDCP CTS items on UNIGRAF DPR-100. > > Change-Id: I03f0758779f73164c8ae2fdf61e41dc693e27605 > > Change-Id: Ib7a8fabaeccd56d3bd7c8adc7384a363b0f7b88d Remove the Change-Id's as mentioned in the other patch. > S

Re: [PATCH v1 2/2] drm/bridge: it6505: Add MSSC suport

2024-09-20 Thread Pin-yen Lin
On Thu, Sep 19, 2024 at 5:20 PM Hermes Wu wrote: > > From: "Hermes.Wu" > > add AUX-I2C functionality to support MCCS. > > Change-Id: I63e1a0e5da67526f89f35605a82944be67dee8ac Remove the Change-Id line. If you run scripts/checkpatch.pl, the script should catch this for you. > Signed-off-by: Herme

Re: [PATCH v1] drm/bridge: it6505: HDCP CTS fail on repeater items

2024-09-19 Thread Pin-yen Lin
On Thu, Sep 19, 2024 at 10:58 AM wrote: > > From: Hermes Wu > > Fix HDCP CTS items on UNIGRAF DPR-100. > > Signed-off-by: Hermes Wu Reviewed-by: Pin-yen Lin > --- > drivers/gpu/drm/bridge/ite-it6505.c | 152 ++-- > 1 file changed, 101

[PATCH 2/2] arm64: dts: mt8183: Add port node to dpi node

2024-09-12 Thread Pin-yen Lin
Add the port node to fix the binding schema check. Fixes: 009d855a26fd ("arm64: dts: mt8183: add dpi node to mt8183") Signed-off-by: Pin-yen Lin Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202409110843.hm5w9upr-...@intel.com/ --- arch/arm64/boot/dt

[PATCH 1/2] dt-bindings: display: mediatek: dpi: Add power-domains to the bindings

2024-09-12 Thread Pin-yen Lin
The power-domains property is used by most DT nodes using mediatek,dpi bindings. Add this to the bindings to fix the schema check error. Signed-off-by: Pin-yen Lin --- .../bindings/display/mediatek/mediatek,dpi.yaml | 8 1 file changed, 8 insertions(+) diff --git a

[PATCH 0/2] Fix dtcheck warnings for mediatek,dpi binding

2024-09-12 Thread Pin-yen Lin
This series fixes two binding schema errors in mediatek,dpi binding. The first patch adds the power-domain property to the binding, and the second patch adds the port node as it's required by the binding. Pin-yen Lin (2): dt-bindings: display: mediatek: dpi: Add power-domains to the bin

[PATCH] drm/bridge: it6505: Disable IRQ when powered off

2024-07-19 Thread Pin-yen Lin
When the bridge is powered off, disable the IRQ until the next power on to workaround an interrupt storm on some badly-designed hardware. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a

[PATCH 2/2] drm/panel-edp: Add more panels with conservative timings

2024-05-27 Thread Pin-yen Lin
r panels of the same vendor. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 2688ff1eb14f..f5060c9f821d 100644 --- a/drivers/gpu/drm/panel/panel-edp

[PATCH 1/2] drm/panel-edp: Add support for several panels

2024-05-27 Thread Pin-yen Lin
Add support for the following models: AUO B140HTN02.0 BOE NT116WHM-N21 V4.1 BOE NT116WHM-N21 Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index

[PATCH 0/2] Support more panels used by MT8173 Chromebooks in edp-panel

2024-05-27 Thread Pin-yen Lin
commit 7c8690d8fc80 ("drm/panel-edp: Add some panels with conservative timings") and the related mailing list discussion[1]. [1]: https://lore.kernel.org/all/CAD=FV=V=K9L=bjinvfj+k_dhutpxa4wtukxa+e_vw6uihe8...@mail.gmail.com/ Pin-yen Lin (2): drm/panel-edp: Add support for several pa

[PATCH] drm/panel-edp: Add AUO B120XAN01.0

2024-03-25 Thread Pin-yen Lin
Add support for the AUO B120XAN01.0 panel. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index c4f851200aa2..1a4a1ffea2c1 100644 --- a/drivers/gpu/drm

Re: [PATCH v4 1/1] drm/bridge: it6505: fix hibernate to resume no display issue

2024-03-08 Thread Pin-yen Lin
Hi Kuro, On Fri, Mar 8, 2024 at 4:54 PM kuro wrote: > > From: Kuro > > ITE added a FIFO reset bit for input video. When system power resume, > the TTL input of it6505 may get some noise before video signal stable > and the hardware function reset is required. > But the input FIFO reset will also

Re: [PATCH v3 1/1] UPSTREAM: drm/bridge: it6505: fix hibernate to resume no display issue

2024-03-06 Thread Pin-yen Lin
Hi Kuro, Following up my comments from v2 [1]: On Wed, Mar 6, 2024 at 10:09 AM kuro wrote: > > From: kuro chung > > ITE added a FIFO reset bit for input video. When system power resume, > the TTL input of it6505 may get some noise before video signal stable > and the hardware function reset is

Re: [PATCH v2 1/1] UPSTREAM: drm/bridge: it6505: fix hibernate to resume no display issue

2024-03-04 Thread Pin-yen Lin
Hi Kuro, On Mon, Mar 4, 2024 at 11:08 AM kuro wrote: > > From: kuro chung > > ITE added a FIFO reset bit for input video. When system power resume, > the TTL input of it6505 may get some noise before video signal stable > and the hardware function reset is required. > But the input FIFO reset wi

Re: [PATCH] drm/bridge: it6505: fix hibernate to resume no display issue

2024-02-21 Thread Pin-yen Lin
Hi Kuro, On Wed, Feb 21, 2024 at 3:53 PM kuro wrote: > > From: kuro chung > > ITE added a FIFO reset bit for input video. When system power resume, > the TTL input of it6505 may get some noise before video signal stable > and the hardware function reset is required. > But the input FIFO reset wi

Re: [PATCH] drm/bridge: anx7625: Ensure bridge is suspended in disable()

2024-01-17 Thread Pin-yen Lin
@@ -475,6 +475,8 @@ struct anx7625_data { > struct workqueue_struct *hdcp_workqueue; > /* Lock for hdcp work queue */ > struct mutex hdcp_wq_lock; > + /* Lock for aux transfer and disable */ > + struct mutex aux_lock; > char edid_block; > struct display_timing dt; > u8 display_timing_valid; > -- > 2.43.0.381.gb435a96ce8-goog > Reviewed-by: Pin-yen Lin

Re: [PATCH v2] drm/bridge: parade-ps8640: Ensure bridge is suspended in .post_disable()

2024-01-17 Thread Pin-yen Lin
Hi Doug, On Thu, Jan 18, 2024 at 2:37 AM Doug Anderson wrote: > > Hi, > > On Wed, Jan 17, 2024 at 9:34 AM Doug Anderson wrote: > > > > Hi, > > > > On Tue, Jan 9, 2024 at 8:52 AM Doug Anderson wrote: > > > > > > Hi, > &g

[PATCH v2] drm/bridge: parade-ps8640: Ensure bridge is suspended in .post_disable()

2024-01-09 Thread Pin-yen Lin
the bridge is really powered off. Fixes: 826cff3f7ebb ("drm/bridge: parade-ps8640: Enable runtime power management") Signed-off-by: Pin-yen Lin --- Changes in v2: - Use mutex instead of the completion and autosuspend hack drivers/gpu/drm/bridge/parade-ps8640.c | 16 ++

Re: [PATCH] drm/bridge: parade-ps8640: Ensure bridge is suspended in .post_disable()

2024-01-09 Thread Pin-yen Lin
Hi Doug, On Tue, Jan 9, 2024 at 6:46 AM Doug Anderson wrote: > > Hi, > > On Wed, Dec 27, 2023 at 2:43 AM Pin-yen Lin wrote: > > > > Disable the autosuspend of runtime PM and use completion to make sure > > ps8640_suspend() is called in ps8640_atomic_post_disabl

[PATCH] drm/bridge: parade-ps8640: Ensure bridge is suspended in .post_disable()

2023-12-27 Thread Pin-yen Lin
current ps8640_aux_transfer() completes. Fixes: 826cff3f7ebb ("drm/bridge: parade-ps8640: Enable runtime power management") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/parade-ps8640.c | 33 +- 1 file changed, 32 insertions(+), 1 deletion(-) di

Re: [PATCH] drm/bridge: parade-ps8640: Wait for HPD when doing an AUX transfer

2023-12-25 Thread Pin-yen Lin
Hi, On Fri, Dec 22, 2023 at 11:34 PM Doug Anderson wrote: > > Hi, > > On Fri, Dec 22, 2023 at 2:29 AM Pin-yen Lin wrote: > > > > Hi Douglas, > > > > On Fri, Dec 22, 2023 at 5:56 AM Douglas Anderson > > wrote: > > > > > > Unlike what

Re: [PATCH] drm/bridge: parade-ps8640: Wait for HPD when doing an AUX transfer

2023-12-22 Thread Pin-yen Lin
Hi Douglas, On Fri, Dec 22, 2023 at 5:56 AM Douglas Anderson wrote: > > Unlike what is claimed in commit f5aa7d46b0ee ("drm/bridge: > parade-ps8640: Provide wait_hpd_asserted() in struct drm_dp_aux"), if > someone manually tries to do an AUX transfer (like via `i2cdump ${bus} > 0x50 i`) while the

[PATCH v3 3/3] drm/panel-edp: Add some panels with conservative timings

2023-12-14 Thread Pin-yen Lin
ame vendor. The panels should still work under those timings, and we can save some delays and suppress the warnings. Signed-off-by: Pin-yen Lin Reviewed-by: Douglas Anderson --- Changes in v3: - Update the commit message. - Collect review tag. drivers/gpu/drm/panel/p

[PATCH v3 2/3] drm/edp-panel: Add panels delay entries

2023-12-14 Thread Pin-yen Lin
Add panels used by Mediatek MT8173 Chromebooks. Signed-off-by: Pin-yen Lin Reviewed-by: Douglas Anderson --- Changes in v3: - Collect review tag. drivers/gpu/drm/panel/panel-edp.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/gpu/drm/panel

[PATCH v3 1/3] drm/panel-edp: Add powered_on_to_enable delay

2023-12-14 Thread Pin-yen Lin
Add the support of powered_on_to_enable delay as the minimum time that needs to have passed between the panel powered on and enable may begin. This delay is seen in BOE panels as the minimum delay of T3+T4+T5+T6+T8 in the eDP timing diagrams. Signed-off-by: Pin-yen Lin Reviewed-by: Douglas

[PATCH v3 0/3] Support panels used by MT8173 Chromebooks in edp-panel

2023-12-14 Thread Pin-yen Lin
the commit message. Changes in v2: - Add a new patch to sort the list, and rebase the rest patches. Pin-yen Lin (3): drm/panel-edp: Add powered_on_to_enable delay drm/edp-panel: Add panels delay entries drm/panel-edp: Add some panels with conservative timings drivers/gpu/drm/panel/panel

Re: [PATCH v2 4/4] drm/panel-edp: Add some panels with conservative timings

2023-12-14 Thread Pin-yen Lin
On Thu, Dec 14, 2023 at 12:23 AM Doug Anderson wrote: > > Hi, > > On Wed, Dec 13, 2023 at 7:34 AM Maxime Ripard wrote: > > > > > > > Repeating my comments from v1 here too, since I expect this patch to > > > > > sit on the lists for a little while: > > > > > > > > > > > > > > > This is OK w/ me,

[PATCH v2 4/4] drm/panel-edp: Add some panels with conservative timings

2023-12-07 Thread Pin-yen Lin
from other panels of the same vendor. The panels should still work under those timings, and we can save some delays and suppress the warnings. Signed-off-by: Pin-yen Lin --- (no changes since v1) drivers/gpu/drm/panel/panel-edp.c | 31 +++ 1 file changed, 31 inser

[PATCH v2 3/4] drm/edp-panel: Add panels delay entries

2023-12-07 Thread Pin-yen Lin
Add panels used by Mediatek MT8173 Chromebooks. Signed-off-by: Pin-yen Lin --- (no changes since v1) drivers/gpu/drm/panel/panel-edp.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c

[PATCH v2 2/4] drm/panel-edp: Add powered_on_to_enable delay

2023-12-07 Thread Pin-yen Lin
Add the support of powered_on_to_enable delay as the minimum time that needs to have passed between the panel powered on and enable may begin. This delay is seen in BOE panels as the minimum delay of T3+T4+T5+T6+T8 in the eDP timing diagrams. Signed-off-by: Pin-yen Lin --- (no changes since v1

[PATCH v2 1/4] drm/edp-panel: Move the KDC panel to a separate group

2023-12-07 Thread Pin-yen Lin
Move the KDC panel entry to make the list sorted by the vendor string. Signed-off-by: Pin-yen Lin --- (no changes since v1) drivers/gpu/drm/panel/panel-edp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel

[PATCH v2 0/4] Support panels used by MT8173 Chromebooks in edp-panel

2023-12-07 Thread Pin-yen Lin
data sheets but used to work in older kernel version without any specified delays. Changes in v2: - Add a new patch to sort the list, and rebase the rest patches. Pin-yen Lin (4): drm/edp-panel: Move the KDC panel to a separate group drm/panel-edp: Add powered_on_to_enable delay drm/edp

[PATCH 4/4] drm/panel-edp: Add some panels with conservative timings

2023-12-05 Thread Pin-yen Lin
from other panels of the same vendor. The panels should still work under those timings, and we can save some delays and suppress the warnings. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 31 +++ 1 file changed, 31 insertions(+) diff --

[PATCH 3/4] drm/edp-panel: Add panels delay entries

2023-12-05 Thread Pin-yen Lin
Add panels used by Mediatek MT8173 Chromebooks. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index e0a18e17d3a2

[PATCH 2/4] drm/edp-panel: Sort the panel entries

2023-12-05 Thread Pin-yen Lin
Move the order of CMN 0x14e5 to make the list sorted. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/panel/panel-edp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 819fe8115c08..e0a18e17d3a2

[PATCH 1/4] drm/panel-edp: Add powered_on_to_enable delay

2023-12-05 Thread Pin-yen Lin
Add the support of powered_on_to_enable delay as the minimum time that needs to have passed between the panel powered on and enable may begin. This delay is seen in BOE panels as the minimum delay of T3+T4+T5+T6+T8 in the eDP timing diagrams. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm

[PATCH 0/4] Support panels used by MT8173 Chromebooks in edp-panel

2023-12-05 Thread Pin-yen Lin
data sheets but used to work in older kernel version without any specified delays. Pin-yen Lin (4): drm/panel-edp: Add powered_on_to_enable delay drm/edp-panel: Sort the panel entries drm/edp-panel: Add panels delay entries drm/panel-edp: Add some panels with conservative timings drivers

[PATCH] drm/bridge: it6505: Check power state with it6505->powered in IRQ handler

2023-07-27 Thread Pin-yen Lin
the driver struct fixes this because it always gets updated when it6505_poweron is called. Fixes: 5eb9a4314053 ("drm/bridge: it6505: Guard bridge power in IRQ handler") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/ite-it6505.c | 4 +++- 1 file changed, 3 insertions(+), 1 dele

Re: [PATCH] drm/bridge: ps8640: Drop the ability of ps8640 to fetch the EDID

2023-06-15 Thread Pin-yen Lin
Hi Doug, On Thu, Jun 15, 2023 at 5:31 AM Doug Anderson wrote: > > Hi, > > On Wed, Jun 14, 2023 at 1:22 AM AngeloGioacchino Del Regno > wrote: > > > > Il 13/06/23 01:32, Douglas Anderson ha scritto: > > > In order to read the EDID from an eDP panel, you not only need to > > > power on the bridge

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-05-29 Thread Pin-yen Lin
On Fri, May 12, 2023 at 1:30 AM Stephen Boyd wrote: > > Quoting Pin-yen Lin (2023-05-09 20:41:54) > > On Sat, Apr 29, 2023 at 12:47 PM Stephen Boyd wrote: > > > > > > Good point. I'm suggesting to make the drm bridge chain into a tree. We > > > need to

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-05-09 Thread Pin-yen Lin
+Jagan who worked on a similar design and initiated the thread. Hi Stephen, On Sat, Apr 29, 2023 at 12:47 PM Stephen Boyd wrote: > > Quoting Pin-yen Lin (2023-04-20 02:10:46) > > On Thu, Apr 20, 2023 at 2:10 PM Stephen Boyd wrote: > > > > > > Quoting Ste

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-27 Thread Pin-yen Lin
On Thu, Apr 20, 2023 at 5:10 PM Pin-yen Lin wrote: > > On Thu, Apr 20, 2023 at 2:10 PM Stephen Boyd wrote: > > > > Quoting Stephen Boyd (2023-04-13 17:22:46) > > > Quoting Pin-yen Lin (2023-04-13 02:50:44) > > > > > > > > Actuall

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-20 Thread Pin-yen Lin
On Thu, Apr 20, 2023 at 2:10 PM Stephen Boyd wrote: > > Quoting Stephen Boyd (2023-04-13 17:22:46) > > Quoting Pin-yen Lin (2023-04-13 02:50:44) > > > > > > Actually the `mode-switch` property here is mainly because > > > `fwnode_typec_mux_get`[1] and `

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-13 Thread Pin-yen Lin
Hi Stephen, On Wed, Apr 12, 2023 at 10:38 AM Stephen Boyd wrote: > > Quoting Pin-yen Lin (2023-03-31 02:11:39) > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > b/Documentation/devicetree/bindings/display/bridge/analogi

Re: [PATCH v15 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-04-06 Thread Pin-yen Lin
Hi Rob, Thanks for the review. On Fri, Apr 7, 2023 at 12:15 AM Rob Herring wrote: > > On Fri, Mar 31, 2023 at 05:11:43PM +0800, Pin-yen Lin wrote: > > ITE IT6505 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayP

[PATCH v15 10/10] drm/bridge: it6505: Register Type C mode switches

2023-03-31 Thread Pin-yen Lin
chip. Signed-off-by: Pin-yen Lin --- Changes in v15: - Add comments about the completion - Fix style issues - Abort the mux_set callback when the switch is unregistered Changes in v14: - Fix style issues Changes in v13: - Fix style issues Changes in v12: - Fixes style issues in it6505 drive

[PATCH v15 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-03-31 Thread Pin-yen Lin
. Signed-off-by: Pin-yen Lin --- (no changes since v12) Changes in v12: - Fixed the schema of "data-lanes" property for it6505 - Reworded the description of the mode-switch property Changes in v11: - Updated the description of the endpoints in the bindings - Referenced video-interfaces.ya

[PATCH v15 09/10] drm/bridge: it6505: Fix Kconfig indentation

2023-03-31 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v10) Changes in v10: - Collected Reviewed-by tag Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1

[PATCH v15 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-31 Thread Pin-yen Lin
different orientations of a single USB Type-C connector, but the orientation switch is not implemented yet. A TODO is added for this. Signed-off-by: Pin-yen Lin --- Changes in v15: - Swap the definitions in anx7625_typec_port_data - Add comments about the completion - Abort the mux_set callbac

[PATCH v15 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-03-31 Thread Pin-yen Lin
These two drivers embed a i2c_client in their private driver data, but only strict device is actually needed. Replace the i2c_client reference with a struct device one. Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko Reviewed-by: AngeloGioacchino Del Regno --- Changes in v15

[PATCH v15 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-03-31 Thread Pin-yen Lin
n the port endpoint, and skip panel registration completely if so. Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko Reviewed-by: AngeloGioacchino Del Regno --- Changes in v15: - Collect review tag Changes in v14: - Collect review tag Changes in v13: - Use the new typec_mode_switch_node_co

[PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-03-31 Thread Pin-yen Lin
. Also include the link to the product brief in the bindings. Signed-off-by: Pin-yen Lin Reviewed-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v12) Changes in v12: - Removed the 4-lane binding in

[PATCH v15 03/10] drm/display: Add Type-C switch helpers

2023-03-31 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "reg" properties are available in Device Tre

[PATCH v15 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-03-31 Thread Pin-yen Lin
ff-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Tsai Acked-by: Heikki Krogerus --- Changes in v15: - Collected Reviewed-by tags Changes in v11: - Collected Acked-by tag Changes in v10: - Collected Reviewed-b

[PATCH v15 01/10] device property: Add remote endpoint to devcon matcher

2023-03-31 Thread Pin-yen Lin
. This is required when a device supports two mode switches in its endpoints, so we can't simply register the mode switch with the parent node. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko Reviewed-by: Sakari Ailus Reviewed-by: Heikki Krogerus ---

[PATCH v15 00/10] Register Type-C mode-switch in DP bridge endpoints

2023-03-31 Thread Pin-yen Lin
se endpoints and data-lanes properties to describe the pin connections - Added new patches (patch 1,2,4) to fix probing issues - Changed the bindings of it6505/anx7625 and modified the drivers accordingly - Merged it6505/anx7625 driver changes into a single patch Pin-yen Lin (8): drm/display

Re: [PATCH v14 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-31 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Wed, Mar 22, 2023 at 8:16 PM Andy Shevchenko wrote: > > On Wed, Mar 22, 2023 at 06:46:36PM +0800, Pin-yen Lin wrote: > > Register USB Type-C mode switches when the "mode-switch" property and > > relevant ports are available i

Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers

2023-03-30 Thread Pin-yen Lin
On Fri, Mar 31, 2023 at 11:36 AM Pin-yen Lin wrote: > > Hi Andy, > > Thanks for the review. > > On Wed, Mar 22, 2023 at 8:01 PM Andy Shevchenko > wrote: > > > > On Wed, Mar 22, 2023 at 06:46:32PM +0800, Pin-yen Lin wrote: > > > Add helpers to register an

[PATCH] drm/bridge: ps8640: Use constant sleep time for polling hpd

2023-03-30 Thread Pin-yen Lin
The default hpd_wait_us in panel_edp.c is 2 seconds. This makes the sleep time in the polling of _ps8640_wait_hpd_asserted become 200ms. Change it to a constant 20ms to speed up the function. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/parade-ps8640.c | 2 +- 1 file changed, 1

Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers

2023-03-30 Thread Pin-yen Lin
Hi Dmitry, Thanks for the review. On Thu, Mar 23, 2023 at 7:39 AM Dmitry Baryshkov wrote: > > On Wed, 22 Mar 2023 at 12:47, Pin-yen Lin wrote: > > > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their out

Re: [PATCH v14 03/10] drm/display: Add Type-C switch helpers

2023-03-30 Thread Pin-yen Lin
Hi Andy, Thanks for the review. On Wed, Mar 22, 2023 at 8:01 PM Andy Shevchenko wrote: > > On Wed, Mar 22, 2023 at 06:46:32PM +0800, Pin-yen Lin wrote: > > Add helpers to register and unregister Type-C "switches" for bridges > > capable of switching their output be

[PATCH] drm/bridge: ps8640: Return NULL immediately when EDID read fail

2023-03-23 Thread Pin-yen Lin
drm_edid_read returns NULL on error, so feeding it directly into drm_edid_duplicate may lead to NULL pointer dereference. Add a check to guard this. Fixes: 6a17b4d1b52f ("drm/bridge: ps8640: Add a cache for EDID") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/parade-ps

[PATCH v14 10/10] drm/bridge: it6505: Register Type C mode switches

2023-03-22 Thread Pin-yen Lin
chip. Signed-off-by: Pin-yen Lin --- Changes in v14: - Fix style issues Changes in v13: - Fix style issues Changes in v12: - Fixes style issues in it6505 driver - Replaced &it6505->client->dev with it6505->dev - Updated the error logs when parsing data-lanes property Changes

[PATCH v14 09/10] drm/bridge: it6505: Fix Kconfig indentation

2023-03-22 Thread Pin-yen Lin
Replace the spaces with tab characters in the Kconfig file. Signed-off-by: Pin-yen Lin Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v10) Changes in v10: - Collected Reviewed-by tag Changes in v7: - New in v7 drivers/gpu/drm/bridge/Kconfig | 20 ++-- 1

[PATCH v14 07/10] drm/bridge: anx7625: Register Type C mode switches

2023-03-22 Thread Pin-yen Lin
different orientations of a single USB Type-C connector, but the orientation switch is not implemented yet. A TODO is added for this. Signed-off-by: Pin-yen Lin --- Changes in v14: - Fix style issues Changes in v12: - Fixed style issues in anx7625 driver - Fixed the inverted orientation

[PATCH v14 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-03-22 Thread Pin-yen Lin
. Signed-off-by: Pin-yen Lin --- (no changes since v12) Changes in v12: - Fixed the schema of "data-lanes" property for it6505 - Reworded the description of the mode-switch property Changes in v11: - Updated the description of the endpoints in the bindings - Referenced video-interfaces.ya

[PATCH v14 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505

2023-03-22 Thread Pin-yen Lin
These two drivers embed a i2c_client in their private driver data, but only strict device is actually needed. Replace the i2c_client reference with a struct device one. Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko --- (no changes since v13) Changes in v13: - Update a typo in the

[PATCH v14 05/10] drm/bridge: anx7625: Check for Type-C during panel registration

2023-03-22 Thread Pin-yen Lin
n the port endpoint, and skip panel registration completely if so. Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko --- Changes in v14: - Collect review tag Changes in v13: - Use the new typec_mode_switch_node_count helper Changes in v12: - Updated to use fwnode_for_each_typec_mode_sw

[PATCH v14 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-03-22 Thread Pin-yen Lin
. Also include the link to the product brief in the bindings. Signed-off-by: Pin-yen Lin Reviewed-by: Krzysztof Kozlowski Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno --- (no changes since v12) Changes in v12: - Removed the 4-lane binding in

[PATCH v14 03/10] drm/display: Add Type-C switch helpers

2023-03-22 Thread Pin-yen Lin
Add helpers to register and unregister Type-C "switches" for bridges capable of switching their output between two downstream devices. The helper registers USB Type-C mode switches when the "mode-switch" and the "reg" properties are available in Device Tre

[PATCH v14 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks

2023-03-22 Thread Pin-yen Lin
ff-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Chen-Yu Tsai Tested-by: Chen-Yu Tsai Acked-by: Heikki Krogerus --- (no changes since v11) Changes in v11: - Collected Acked-by tag Changes in v10: - Collected Reviewed-by and Tested-by tags Changes in v7: - Fix the long comment

[PATCH v14 01/10] device property: Add remote endpoint to devcon matcher

2023-03-22 Thread Pin-yen Lin
. This is required when a device supports two mode switches in its endpoints, so we can't simply register the mode switch with the parent node. Signed-off-by: Prashant Malani Signed-off-by: Pin-yen Lin Reviewed-by: Andy Shevchenko Reviewed-by: Sakari Ailus Reviewed-by: Heikki Kro

[PATCH v14 00/10] Register Type-C mode-switch in DP bridge endpoints

2023-03-22 Thread Pin-yen Lin
t drm-misc patches - Changed the driver implementation to accommodate with the new binding - Dropped typec-switch binding and use endpoints and data-lanes properties to describe the pin connections - Added new patches (patch 1,2,4) to fix probing issues - Changed the bindings of it6505/anx7625

Re: [PATCH 1/2] drm/bridge: ps8640: Skip redundant bridge enable

2023-03-16 Thread Pin-yen Lin
Hi, On Thu, Mar 16, 2023 at 5:34 AM Doug Anderson wrote: > > Hi, > > On Tue, Mar 14, 2023 at 8:28 PM Pin-yen Lin wrote: > > > > Hi Doug, > > > > On Wed, Mar 15, 2023 at 5:31 AM Doug Anderson wrote: > > > > > > Hi, > > >

[PATCH v2 2/2] drm/bridge: ps8640: Add a cache for EDID

2023-03-14 Thread Pin-yen Lin
When there are multiple EDID reads, the bridge will be repeatedly enabled and disabled. Add a cache for EDID to speed this up. Signed-off-by: Pin-yen Lin Reviewed-by: Robert Foss Reviewed-by: Douglas Anderson --- Changes in v2: - Remove the NULL assignment in ps8640_remove drivers/gpu/drm

[PATCH v2 1/2] drm/bridge: ps8640: Skip redundant bridge enable

2023-03-14 Thread Pin-yen Lin
Skip the drm_bridge_chain_pre_enable call when the bridge is already pre_enabled. This make pre_enable and post_disable (thus pm_runtime_get/put) symmetric. Fixes: 46f206304db0 ("drm/bridge: ps8640: Rework power state handling") Signed-off-by: Pin-yen Lin Reviewed-by: Robert Foss R

Re: [PATCH 1/2] drm/bridge: ps8640: Skip redundant bridge enable

2023-03-14 Thread Pin-yen Lin
Hi Doug, On Wed, Mar 15, 2023 at 5:31 AM Doug Anderson wrote: > > Hi, > > On Tue, Mar 14, 2023 at 4:00 AM Pin-yen Lin wrote: > > > > Skip the drm_bridge_chain_pre_enable call when the bridge is already > > pre_enabled. This make pre_enable and post_disabl

[PATCH 2/2] drm/bridge: ps8640: Add a cache for EDID

2023-03-14 Thread Pin-yen Lin
When there are multiple EDID reads, the bridge will be repeatedly enabled and disabled. Add a cache for EDID to speed this up. Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bridge/parade-ps8640.c | 61 -- 1 file changed, 37 insertions(+), 24 deletions(-) diff --git a

[PATCH 1/2] drm/bridge: ps8640: Skip redundant bridge enable

2023-03-14 Thread Pin-yen Lin
Skip the drm_bridge_chain_pre_enable call when the bridge is already pre_enabled. This make pre_enable and post_disable (thus pm_runtime_get/put) symmetric. Fixes: 46f206304db0 ("drm/bridge: ps8640: Rework power state handling") Signed-off-by: Pin-yen Lin --- drivers/gpu/drm/bri

  1   2   3   >