Hi Jason,
On Thu, Dec 12, 2024 at 11:33 PM Jason-JH.Lin <jason-jh....@mediatek.com> wrote:
>
> From: Hsiao Chien Sung <shawn.s...@mediatek.com>
>
> Modify rules for both MT8195 and MT8188.
> Hardware capabilities include color formats and AFBC are
> changed since MT8195, stop using the settings of MT8183.
>
> Acked-by: Rob Herring <r...@kernel.org>
> Reviewed-by: AngeloGioacchino Del Regno
> <angelogioacchino.delre...@collabora.com>
> Signed-off-by: Hsiao Chien Sung <shawn.s...@mediatek.com>
> Signed-off-by: Jason-JH.Lin <jason-jh....@mediatek.com>
> Reviewed-by: CK Hu <ck...@mediatek.com>
> ---
> .../bindings/display/mediatek/mediatek,ovl.yaml | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> index 9ea796a033b2..0ace12bbb623 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yaml
> @@ -36,16 +36,14 @@ properties:
> - enum:
> - mediatek,mt6795-disp-ovl
> - const: mediatek,mt8173-disp-ovl
> - - items:
> - - enum:
> - - mediatek,mt8188-disp-ovl
> - - mediatek,mt8195-disp-ovl
> - - const: mediatek,mt8183-disp-ovl
This breaks the schema check for mt8195.dtsi, which is currently using
`compatible = "mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl";`
IIUC this is supposed to be a RESEND of [1], which actually added a
binding for "mediatek,mt8195-disp-ovl". However [1] still breaks
mt8195.dtsi because it only allows `compatible =
"mediatek,mt8195-disp-ovl"` But not `compatible =
"mediatek,mt8195-disp-ovl", "mediatek,mt8183-disp-ovl"`.
If "mediatek,mt8183-disp-ovl" is a reasonable fallback for
"mediatek,mt8195-disp-ovl", please keep a binding like:
- items:
- const: mediatek,mt8195-disp-ovl
- const: mediatek,mt8183-disp-ovl
Or, fix mt8195.dtsi instead in the same series.
[1]:
https://patchwork.kernel.org/project/linux-mediatek/patch/20231212121957.19231-4-shawn.s...@mediatek.com/
> - items:
> - enum:
> - mediatek,mt8186-disp-ovl
> - mediatek,mt8365-disp-ovl
> - const: mediatek,mt8192-disp-ovl
> + - items:
> + - const: mediatek,mt8188-disp-ovl
> + - const: mediatek,mt8195-disp-ovl
>
> reg:
> maxItems: 1
Regards,
Pin-yen
