[PATCH 13/27] mm: export access_remote_vm symbol for debugger use

2025-01-13 Thread Mika Kuoppala
oonas Lahtinen Cc: Simona Vetter Signed-off-by: Mika Kuoppala --- mm/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memory.c b/mm/memory.c index 398c031be9ba..9b7c71c83db5 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -6690,6 +6690,7 @@ int access_remote_vm(struct mm_struc

[PATCH 14/27] drm/xe/eudebug: userptr vm access pread/pwrite

2025-01-13 Thread Mika Kuoppala
Lahtinen Cc: Simona Vetter Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_eudebug.c b/drivers/gpu/drm/xe/xe_eudebug.c index 210d9eeab1a7..25f18aa5447b 100644 --- a/drivers/gpu/drm/xe

[PATCH 14/27] drm/xe/eudebug: userptr vm access pread/pwrite

2025-01-13 Thread Mika Kuoppala
Lahtinen Cc: Simona Vetter Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_eudebug.c b/drivers/gpu/drm/xe/xe_eudebug.c index 210d9eeab1a7..25f18aa5447b 100644 --- a/drivers/gpu/drm/xe

[PATCH 13/27] mm: export access_remote_vm symbol for debugger use

2025-01-13 Thread Mika Kuoppala
oonas Lahtinen Cc: Simona Vetter Signed-off-by: Mika Kuoppala --- mm/memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memory.c b/mm/memory.c index 398c031be9ba..9b7c71c83db5 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -6690,6 +6690,7 @@ int access_remote_vm(struct mm_struc

Re: [PATCH 13/26] RFC drm/xe/eudebug: userptr vm pread/pwrite

2025-01-13 Thread Mika Kuoppala
Thomas Hellström writes: > On Fri, 2024-12-20 at 13:31 +0200, Mika Kuoppala wrote: >> Implement debugger vm access for userptrs. >> >> When bind is done, take ref to current task so that >> we know from which vm the address was bound. Then during >> debugger pre

Re: [PATCH 14/26] drm/xe/eudebug: implement userptr_vma access

2024-12-20 Thread Mika Kuoppala
Joonas Lahtinen writes: > Quoting Joonas Lahtinen (2024-12-11 14:59:33) >> Quoting Christian König (2024-12-10 16:03:14) > > > >> > If you really want to expose an interface to userspace which walks the >> > process >> > page table, installs an MMU notifier, kmaps the resulting page and then >

[PATCH 13/26] RFC drm/xe/eudebug: userptr vm pread/pwrite

2024-12-20 Thread Mika Kuoppala
Thomas, Joonas and Simona. v2: need to add offset into vma (Dominik) Cc: Matthew Brost Cc: Andrzej Hajda Cc: Thomas Hellström Cc: Dominik Grzegorzek Cc: Christian König Cc: Joonas Lahtinen Cc: Simona Vetter Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 13

[PATCH 13/26] RFC drm/xe/eudebug: userptr vm pread/pwrite

2024-12-16 Thread Mika Kuoppala
Thomas, Joonas and Simona. Cc: Matthew Brost Cc: Andrzej Hajda Cc: Thomas Hellström Cc: Christian König Cc: Joonas Lahtinen Cc: Simona Vetter Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 12 drivers/gpu/drm/xe/xe_vm.c | 11 +++ drivers/gpu

[PATCH 17/26] drm/xe/eudebug: Add debug metadata support for xe_eudebug

2024-12-09 Thread Mika Kuoppala
Xe EU Debugger on VM BIND will inform about VMA metadata attachements during bind IOCTL sending proper OP event. v2: - checkpatch (Maciej, Tilak) - struct alignment (Matthew) - Kconfig (Mika) Signed-off-by: Dominik Grzegorzek Signed-off-by: Maciej Patelczyk Signed-off-by: Mika Kuo

[PATCH 15/26] drm/xe: Debug metadata create/destroy ioctls

2024-12-09 Thread Mika Kuoppala
established by l0+gdb. v2: - include uapi/drm/xe_drm.h - metadata behind kconfig (Mika) - dont leak args->id on error (Matt Auld) Cc: Matthew Auld Signed-off-by: Dominik Grzegorzek Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/Makefile | 3 +- drivers/gpu/

[PATCH 06/26] drm/xe/eudebug: hw enablement for eudebug

2024-12-09 Thread Mika Kuoppala
suits better for dynamic manipulation of those register we do later in the series. v3: get rid of undefining XE_MCR_REG (Mika) Signed-off-by: Dominik Grzegorzek Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/regs/xe_engine_regs.h | 4 ++ drivers/gpu/drm/xe/regs/xe_gt_regs.h | 10

[PATCH 24/26] drm/xe/eudebug: Introduce EU pagefault handling interface

2024-12-09 Thread Mika Kuoppala
additional breakpoints or interrupts occur in addition to the existing pagefault by comparing the eu threads where the pagefault occurred with the eu threads where the attention bit is newly enabled. Signed-off-by: Gwan-gyeong Mun Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c

[PATCH 23/26] drm/xe/eudebug: Add read/count/compare helper for eu attention

2024-12-09 Thread Mika Kuoppala
-off-by: Gwan-gyeong Mun Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_gt_debug.c | 64 drivers/gpu/drm/xe/xe_gt_debug.h | 15 2 files changed, 79 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_gt_debug.c b/drivers/gpu/drm/xe/xe_gt_debug.c index

[PATCH 26/26] drm/xe/eudebug: Enable EU pagefault handling

2024-12-09 Thread Mika Kuoppala
recoverable pagefault code path. Signed-off-by: Gwan-gyeong Mun Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_gt_pagefault.c | 83 +--- 1 file changed, 75 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe

[PATCH 25/26] drm/xe/vm: Support for adding null page VMA to VM on request

2024-12-09 Thread Mika Kuoppala
el-xe/20230829231648.4438-1-yu.bruce.ch...@intel.com/ Cc: Oak Zeng Cc: Niranjana Vishwanathapura Cc: Stuart Summers Cc: Matthew Brost Co-developed-by: Bruce Chang Signed-off-by: Bruce Chang Signed-off-by: Gwan-gyeong Mun Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_vm.c

[PATCH 22/26] drm/xe/eudebug/ptl: Add RCU_DEBUG_1 register support for xe3

2024-12-09 Thread Mika Kuoppala
From: Dominik Grzegorzek Format of Register_RenderControlUnitDebug1 is different from previous gens. Adjust it so it matches PTL/xe3 format. Acked-by: Mika Kuoppala Signed-off-by: Dominik Grzegorzek Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 13 + 1 file

[PATCH 12/26] drm/xe/eudebug: vm open/pread/pwrite

2024-12-09 Thread Mika Kuoppala
a (Matthew) v3: - fw ref, ttm_bo_access - timeout boundary check (Dominik) - dont try to copy to user on zero bytes (Mika) Cc: Matthew Brost Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/regs/xe_gt_regs.h | 24 ++ drivers/gpu/drm/xe/xe_eudebug.c

[PATCH 18/26] drm/xe/eudebug: Implement vm_bind_op discovery

2024-12-09 Thread Mika Kuoppala
Follow the vm bind, vm_bind op sequence for discovery process of a vm with the vmas it has. Send events for ops and attach metadata if available. v2: - Fix bad op ref seqno (Christoph) - with discovery semaphore, we dont need vm lock (Matthew) Cc: Matthew Brost Signed-off-by: Mika Kuoppala

[PATCH 16/26] drm/xe: Attach debug metadata to vma

2024-12-09 Thread Mika Kuoppala
. v2: move vma metadata handling behind Kconfig (Mika) Signed-off-by: Dominik Grzegorzek Signed-off-by: Maciej Patelczyk Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_debug_metadata.c | 120 + drivers/gpu/drm/xe/xe_debug_metadata.h | 52 +++ drivers/gpu

[PATCH 10/26] drm/xe/eudebug: Add vm bind and vm bind ops

2024-12-09 Thread Mika Kuoppala
full successful chain of operations can be relayed to debugger. Signed-off-by: Christoph Manszewski Co-developed-by: Mika Kuoppala Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 318 +- drivers/gpu/drm/xe/xe_eudebug.h | 13 ++ drivers/gpu

[PATCH 20/26] drm/xe/eudebug_test: Introduce xe_eudebug wa kunit test

2024-12-09 Thread Mika Kuoppala
From: Christoph Manszewski Introduce kunit test for eudebug. For now it checks the dynamic application of WAs. v2: adapt to removal of call_for_each_device (Mika) v3: s/FW_RENDER/FORCEWAKE_ALL (Mika) Signed-off-by: Christoph Manszewski Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe

[PATCH 21/26] drm/xe/eudebug/ptl: Add support for extra attention register

2024-12-09 Thread Mika Kuoppala
From: Dominik Grzegorzek xe3 can set bits within an additional attention bit register EU_ATT1. Recalculate bitmask and make sure we read all required data. Signed-off-by: Dominik Grzegorzek Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 4 ++-- drivers/gpu/drm/xe

[PATCH 19/26] drm/xe/eudebug: Dynamically toggle debugger functionality

2024-12-09 Thread Mika Kuoppala
d as such it accepts inputs as documented by this function, in particular '0' and '1'. v2: use new discovery_lock to gain exclusivity (Mika) v3: remove init_late and init_hw_engine (Dominik) Signed-off-by: Christoph Manszewski Signed-off-by: Dominik Grzegorzek Signed-off-by: Maciej

[PATCH 14/26] drm/xe/eudebug: implement userptr_vma access

2024-12-09 Thread Mika Kuoppala
f DMA, fixes iommu enabled - s/xe_uvma_access/xe_vm_uvma_access/ (Matt) Signed-off-by: Andrzej Hajda Signed-off-by: Maciej Patelczyk Signed-off-by: Mika Kuoppala Reviewed-by: Jonathan Cavitt #v1 --- drivers/gpu/drm/xe/xe_eudebug.c | 3 ++- drivers/gpu/drm/xe/xe_vm.c

[PATCH 09/26] drm/xe/eudebug: Introduce EU control interface

2024-12-09 Thread Mika Kuoppala
: Maciej Patelczyk Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/regs/xe_gt_regs.h | 2 + drivers/gpu/drm/xe/xe_eudebug.c | 515 +- drivers/gpu/drm/xe/xe_eudebug_types.h | 24 ++ drivers/gpu/drm/xe/xe_gt_debug.c | 12 +- drivers/gpu/drm/xe/xe_gt_debug.h

[PATCH 13/26] drm/xe: add system memory page iterator support to xe_res_cursor

2024-12-09 Thread Mika Kuoppala
From: Andrzej Hajda Currently xe_res_cursor allows iteration only over DMA side of scatter gatter tables. Signed-off-by: Andrzej Hajda Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_res_cursor.h | 51 +++--- 1 file changed, 39 insertions(+), 12 deletions

[PATCH 11/26] drm/xe/eudebug: Add UFENCE events with acks

2024-12-09 Thread Mika Kuoppala
ack (ioctl) is received for the corresponding seqno, signal ufence. v2: - return err instead of 0 to guarantee signalling (Dominik) - checkpatch (Tilak) - Kconfig (Mika, Andrzej) - use lock instead of cmpxchg (Mika) Signed-off-by: Mika Kuoppala Signed-off-by: Andrzej Hajda --- drivers

[PATCH 03/26] drm/xe/eudebug: Introduce discovery for resources

2024-12-09 Thread Mika Kuoppala
-by: Mika Kuoppala Acked-by: Matthew Brost #locking --- drivers/gpu/drm/xe/xe_device.c| 10 +- drivers/gpu/drm/xe/xe_device.h| 34 +++ drivers/gpu/drm/xe/xe_device_types.h | 6 ++ drivers/gpu/drm/xe/xe_eudebug.c | 135 +- drivers/gpu/drm/xe

[PATCH 08/26] drm/xe/eudebug: Introduce per device attention scan worker

2024-12-09 Thread Mika Kuoppala
during list traversal v3: - engine status per gen improvements, force_wake ref - __counted_by (Mika) Signed-off-by: Dominik Grzegorzek Signed-off-by: Christoph Manszewski Signed-off-by: Maciej Patelczyk Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/Makefile | 1

[PATCH 07/26] drm/xe: Add EUDEBUG_ENABLE exec queue property

2024-12-09 Thread Mika Kuoppala
engine init Cc: Matthew Brost Signed-off-by: Dominik Grzegorzek Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 4 +-- drivers/gpu/drm/xe/xe_exec_queue.c | 46 ++-- drivers/gpu/drm/xe/xe_exec_queue.h | 2 ++ drivers/gpu/drm/xe

[PATCH 02/26] drm/xe/eudebug: Introduce eudebug support

2024-12-09 Thread Mika Kuoppala
(Christoph) Cc: Maarten Lankhorst Cc: Lucas De Marchi Cc: Dominik Grzegorzek Cc: Andi Shyti Cc: Matt Roper Cc: Matthew Brost Cc: Zbigniew Kempczyński Cc: Andrzej Hajda Signed-off-by: Mika Kuoppala Signed-off-by: Maciej Patelczyk Signed-off-by: Dominik Grzegorzek Signed-off-by: Jonathan

[PATCH 05/26] drm/xe/eudebug: Introduce exec queue placements event

2024-12-09 Thread Mika Kuoppala
: Dominik Grzegorzek Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 99 --- drivers/gpu/drm/xe/xe_eudebug_types.h | 26 +++ include/uapi/drm/xe_drm_eudebug.h | 17 + 3 files changed, 133 insertions(+), 9 deletions(-) diff --git a

[PATCH 04/26] drm/xe/eudebug: Introduce exec_queue events

2024-12-09 Thread Mika Kuoppala
: - Only track long running queues - Checkpatch (Tilak) v3: __counted_by added Signed-off-by: Dominik Grzegorzek Signed-off-by: Maciej Patelczyk Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/xe/xe_eudebug.c | 189 +- drivers/gpu/drm/xe/xe_eudebug.h

[PATCH 00/26] Intel Xe GPU debug support (eudebug) v3

2024-12-09 Thread Mika Kuoppala
troduce EU pagefault handling interface drm/xe/vm: Support for adding null page VMA to VM on request drm/xe/eudebug: Enable EU pagefault handling Mika Kuoppala (6): ptrace: export ptrace_may_access drm/xe/eudebug: Introduce eudebug support drm/xe/eudebug: Introduce discovery for resources drm/

[PATCH 01/26] ptrace: export ptrace_may_access

2024-12-09 Thread Mika Kuoppala
: Oleg Nesterov Cc: linux-ker...@vger.kernel.org Cc: Dave Airlie CC: Lucas De Marchi Cc: Matthew Brost CC: Andi Shyti Cc: Joonas Lahtinen CC: Maciej Patelczyk Cc: Dominik Grzegorzek Signed-off-by: Mika Kuoppala Signed-off-by: Jonathan Cavitt Reviewed-by: Andi Shyti --- kernel/ptrace.c | 1

Re: [PATCH v5 2/9] drm/ttm: Add ttm_bo_access

2024-10-24 Thread Mika Kuoppala
Matthew Brost writes: > On Tue, Oct 22, 2024 at 12:18:52PM +0300, Mika Kuoppala wrote: >> Matthew Brost writes: >> >> > Non-contiguous VRAM cannot easily be mapped in TTM nor can non-visible >> > VRAM easily be accessed. Add ttm_bo_access, which is similar to

Re: [PATCH v5 2/9] drm/ttm: Add ttm_bo_access

2024-10-22 Thread Mika Kuoppala
checkpatch warnings (CI) > > Reported-by: Christoph Manszewski > Suggested-by: Thomas Hellström > Signed-off-by: Matthew Brost With the igt/xe_eudebug* coverage, Tested-by: Mika Kuoppala > --- > drivers/gpu/drm/ttm/ttm_bo_util.c | 86 +++

Re: [RFC PATCH] dma-buf: Fix dma reservation with zero fences

2023-12-15 Thread Mika Kuoppala
Christian König writes: > Am 14.12.23 um 13:08 schrieb Mika Kuoppala: >> Driver can initialize without any fences. If so >> roundup_power_of_two will overflow as it will try to >> subtract one from initial value before shift, >> (1 << fls_long(-1)). > > A

[RFC PATCH] dma-buf: Fix dma reservation with zero fences

2023-12-14 Thread Mika Kuoppala
would need a callsite comb. Caught-by: UBSAN Cc: Christian König Cc: Thomas Hellström Signed-off-by: Mika Kuoppala --- drivers/dma-buf/dma-resv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c index 38b411

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

2023-10-17 Thread Mika Kuoppala
d lead to unwanted side effects. >*/ > - if (mode & EMIT_FLUSH) > + if ((mode & EMIT_FLUSH) && > + !(IS_GFX_GT_IP_RANGE(gt, IP_VER(12, 70), IP_VER(12, 71)))) > bit_group_

Re: [Intel-gfx] [PATCH] drm/i915: Simplify internal helper function signature

2022-11-10 Thread Mika Kuoppala
lin > Cc: Andrzej Hajda Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c > b/drivers/gpu/drm/i915/gt/intel_workaroun

Re: [PATCH 2/2] drm/i915: Don't use DRM_DEBUG_WARN_ON for ring unexpectedly not idle

2022-05-05 Thread Mika Kuoppala
that it will catch all possible error conditions. Use drm_warn instead. > > Signed-off-by: Tvrtko Ursulin > Cc: Mika Kuoppala > Cc: Jani Nikula Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 4 +++- > 1 file changed, 3 insertions(+),

Re: [PATCH] drm/i915/gtt: add some flushing for the 64K GTT path

2021-09-03 Thread Mika Kuoppala
the updated entry. > > Signed-off-by: Matthew Auld > Cc: Mika Kuoppala Makes sense to follow the same pattern as the other writes. Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drive

Re: [PATCH v2 1/2] drm/i915: document caching related bits

2021-08-02 Thread Mika Kuoppala
; > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Ville Syrjälä > Cc: Mika Kuoppala > --- > .../gpu/drm/i915/gem/i915_gem_object_types.h | 173 +- > drivers/gpu/drm/i915/i915_drv.h | 9 - > 2 files changed, 169 insertions(+), 13

Re: [Intel-gfx] [PATCH 1/5] drm/i915: document caching related bits

2021-07-13 Thread Mika Kuoppala
Matthew Auld writes: > Try to document the object caching related bits, like cache_coherent and > cache_dirty. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > --- > .../gpu/drm/i915/gem/i915_gem_object_types.h | 135 +- > drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] [PATCH] drm/i915: Take request reference before arming the watchdog timer

2021-03-26 Thread Mika Kuoppala
ot;drm/i915: Request watchdog infrastructure") > Cc: Daniel Vetter Reviewed-by: Mika Kuoppala > --- > Test-with: 20210318162400.2065097-1-tvrtko.ursu...@linux.intel.com > --- > drivers/gpu/drm/i915/i915_request.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] drm/i915/selftests: Fix wrong return value of perf_series_engines()

2020-11-17 Thread Mika Kuoppala
Reported-by: Hulk Robot > Signed-off-by: Zhang Xiaoxu Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c > b/drivers/gpu/

Re: [PATCH] drm/i915/selftests: Fix wrong return value of perf_request_latency()

2020-11-17 Thread Mika Kuoppala
> Signed-off-by: Zhang Xiaoxu Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c > b/drivers/gpu/drm/i915/selftests/i915_

[PATCH 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-01-17 Thread Mika Kuoppala
context, we do want to track the current context in the ring. In doing so, we need to be careful to only record a context switch when we are sure the next request will be emitted. v2: elide optimization patch squashed, courtesy of Chris Wilson Signed-off-by: Mika Kuoppala Signed-off-by: Akeem G

[PATCH 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-01-17 Thread Mika Kuoppala
context, we do want to track the current context in the ring. In doing so, we need to be careful to only record a context switch when we are sure the next request will be emitted. v2: elide optimization patch squashed, courtesy of Chris Wilson Signed-off-by: Mika Kuoppala Signed-off-by: Akeem G

Re: [PATCH 1/2] drm/i915: Add mechanism to submit a context WA on ring submission

2020-01-17 Thread Mika Kuoppala
Mika Kuoppala writes: >Subject: Re: [PATCH 1/2] drm/i915: Add mechanism to submit a context WA >on ring submission I forgot to add RFC into patch subject. This should carry the RFC status as it is v2 on a RFC patch. This patch squashes Chris Wilson's ctx switch optimization and the

Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-27 Thread Mika Kuoppala
Dan Carpenter writes: > The live_context() function returns error pointers. It never returns > NULL. > > Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding requests to a full > GGTT") > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala i915_req

Re: [Intel-gfx] [PATCH 3/7] drm/leases: Don't init to 0 in drm_master_create

2019-03-03 Thread Mika Kuoppala
Daniel Vetter writes: > We kzalloc. > > Cc: Keith Packard > Signed-off-by: Daniel Vetter Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/drm_auth.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_auth.c b/drivers/gpu/drm/drm_

[Intel-gfx] [PATCH 06/64] drm: Restore double clflush on the last partial cacheline

2016-07-13 Thread Mika Kuoppala
fea6 (drm: Avoid the double clflush on the last cache...) >> Testcase: igt/gem_concurrent_blit >> Testcase: igt/gem_partial_pread_pwrite >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92845 >> Signed-off-by: Chris Wilson >> Cc: dri-devel at lists.freedesktop.org >> Cc:

[patch] drm/i915/mocs: || vs | typo in get_mocs_settings()

2016-06-13 Thread Mika Kuoppala
Dan Carpenter writes: > It seems pretty clear that bitwise OR was intended here and not logical > OR. > > Fixes: 6fc29133eafb ('drm/i915/gen9: Add WaDisableSkipCaching') > Signed-off-by: Dan Carpenter Pushed to drm-intel-next-queued. Thanks for patch. -Mika > > diff --git a/drivers/gpu/drm/i9

[patch] drm/i915/mocs: || vs | typo in get_mocs_settings()

2016-06-13 Thread Mika Kuoppala
Dan Carpenter writes: > It seems pretty clear that bitwise OR was intended here and not logical > OR. > > Fixes: 6fc29133eafb ('drm/i915/gen9: Add WaDisableSkipCaching') > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala > > diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH] drm: Restore double clflush on the last partial cacheline

2016-05-02 Thread Mika Kuoppala
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92845 > Signed-off-by: Chris Wilson > Cc: dri-devel at lists.freedesktop.org > Cc: Akash Goel > Cc: Imre Deak > Cc: Daniel Vetter > Cc: Jason Ekstrand > Cc: stable at vger.kernel.org Reviewed-by: Mika Kuoppala >

[PATCH] fbcon: when font is freed, clear also vc_font.data

2013-04-22 Thread Mika Kuoppala
y freed, we need to clear the data so that we don't reload font from dangling pointer. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=892340 Signed-off-by: Mika Kuoppala --- drivers/video/console/fbcon.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/console/f

[PATCH] fbcon: when font is freed, clear also vc_font.data

2013-04-22 Thread Mika Kuoppala
y freed, we need to clear the data so that we don't reload font from dangling pointer. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=892340 Signed-off-by: Mika Kuoppala --- drivers/video/console/fbcon.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/console/f

[PATCH] drm: Fix kdoc comment for drm_crtc_convert_umode

2012-10-09 Thread mika . kuoppala
From: Mika Kuoppala Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/drm_crtc.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index ef1b221..bb4c686 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu

[PATCH v2] Documentation: kernel-parameters.txt Add drm_kms_helper.poll

2012-10-09 Thread mika . kuoppala
From: Mika Kuoppala Possibility to disable polling to find connected displays was introduced by commit [1]: commit e58f637bb96d5a0ae0919b9998b891d1ba7e47c9 Author: Chris Wilson Date: Fri Aug 20 09:13:36 2010 +0100 drm/kms: Add a module parameter to disable polling Add description for

[PATCH] Documentation: kernel-parameters.txt Add drm_kms_helper.poll

2012-10-04 Thread mika . kuoppala
From: Mika Kuoppala Add description for drm_kms_helper.poll module parameter introduced by commit: e58f637bb96d5a0ae0919b9998b891d1ba7e47c9 Signed-off-by: Mika Kuoppala --- Documentation/kernel-parameters.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation