[PATCH v5 9/9] MAINTAINERS: Add entry for i.MX94 DCIF driver

2025-09-20 Thread Laurentiu Palcu
The driver is part of DRM subsystem and is located in drivers/gpu/drm/imx/dcif. Signed-off-by: Laurentiu Palcu Reviewed-by: Frank Li --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8cf4990a8ff65cabe22cbe13d410de241b790320

[PATCH v5 1/9] dt-bindings: display: fsl,ldb: Add i.MX94 LDB

2025-09-20 Thread Laurentiu Palcu
i.MX94 has a single LVDS port and share similar LDB and LVDS control registers as i.MX8MP and i.MX93. Signed-off-by: Laurentiu Palcu Reviewed-by: Frank Li Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 2 ++ 1 file changed, 2 insertions

[PATCH v5 7/9] arm64: dts: imx943: Add display pipeline nodes

2025-09-17 Thread Laurentiu Palcu
Add display controller and LDB support in imx943. Signed-off-by: Laurentiu Palcu --- arch/arm64/boot/dts/freescale/imx943.dtsi | 53 ++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx943.dtsi b/arch/arm64/boot/dts

[PATCH v5 8/9] arm64: dts: imx943-evk: Add display support using IT6263

2025-09-13 Thread Laurentiu Palcu
The ITE IT6263 based NXP LVDS to HDMI converter can be attached to the i.MX943 EVK board LVDS port using the mini-SAS connector. Since this is the default configuration for the EVK, add support for it here. Signed-off-by: Laurentiu Palcu Reviewed-by: Frank Li --- arch/arm64/boot/dts/freescale

[PATCH v5 6/9] dt-bindings: clock: nxp, imx95-blk-ctl: Add ldb child node

2025-09-11 Thread Laurentiu Palcu
Since the BLK CTL registers, like the LVDS CSR, can be used to control the LVDS Display Bridge controllers, add 'ldb' child node to handle these use cases. Signed-off-by: Laurentiu Palcu --- .../bindings/clock/nxp,imx95-blk-ctl.yaml | 26 ++ 1 file c

[PATCH v5 3/9] drm/bridge: fsl-ldb: Add support for i.MX94

2025-09-11 Thread Laurentiu Palcu
ned-off-by: Laurentiu Palcu Reviewed-by: Frank Li --- drivers/gpu/drm/bridge/fsl-ldb.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 665053d0cb79d2b4f50e69c397863a

[PATCH v5 5/9] drm/imx: Add support for i.MX94 DCIF

2025-09-11 Thread Laurentiu Palcu
; - programmable background color; - embedded alpha and global alpha; * Data output with CRC checksum for 4 programmable regions; Signed-off-by: Sandor Yu Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/Kconfig | 1 + drivers/gpu/drm/imx/Makefile | 1

[PATCH v5 4/9] dt-bindings: display: imx: Add i.MX94 DCIF

2025-09-11 Thread Laurentiu Palcu
DCIF is the i.MX94 Display Controller Interface which is used to drive a TFT LCD panel or connects to a display interface depending on the chip configuration. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx94-dcif.yaml | 82 ++ 1 file changed, 82

[PATCH v5 2/9] drm/bridge: fsl-ldb: Get the next non-panel bridge

2025-09-11 Thread Laurentiu Palcu
panel bridge only. Signed-off-by: Liu Ying Signed-off-by: Laurentiu Palcu Reviewed-by: Dmitry Baryshkov Reviewed-by: Frank Li --- drivers/gpu/drm/bridge/fsl-ldb.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl

[PATCH v5 0/9] Add support for i.MX94 DCIF

2025-09-11 Thread Laurentiu Palcu
reworked the BLK_CTL patch and split in 2 to make it easier for review; - split the dts and dtsi patch in 2 separate ones; - addressed Frank's comments in DCIF driver; - addressed Rob's comments for the bindings files; - addressed a couple of checkpatch issues; - Link to v1: https:/

Re: [PATCH v4 4/9] dt-bindings: display: imx: Add bindings for i.MX94 DCIF

2025-09-04 Thread Laurentiu Palcu
On Thu, Sep 04, 2025 at 09:24:57AM +0200, Krzysztof Kozlowski wrote: > On Wed, Sep 03, 2025 at 03:33:22PM +0300, Laurentiu Palcu wrote: > > DCIF is the i.MX94 Display Controller Interface which is used to > > drive a TFT LCD panel or connects to a display interface depending

[PATCH v4 5/9] drm/imx: Add support for i.MX94 DCIF

2025-09-03 Thread Laurentiu Palcu
; - programmable background color; - embedded alpha and global alpha; * Data output with CRC checksum for 4 programmable regions; Signed-off-by: Sandor Yu Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/Kconfig | 1 + drivers/gpu/drm/imx/Makefile | 1

[PATCH v4 4/9] dt-bindings: display: imx: Add bindings for i.MX94 DCIF

2025-09-03 Thread Laurentiu Palcu
DCIF is the i.MX94 Display Controller Interface which is used to drive a TFT LCD panel or connects to a display interface depending on the chip configuration. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx94-dcif.yaml | 82 +++ 1 file changed, 82 insertions

[PATCH v4 2/9] drm/bridge: fsl-ldb: Get the next non-panel bridge

2025-09-03 Thread Laurentiu Palcu
panel bridge only. Signed-off-by: Liu Ying Signed-off-by: Laurentiu Palcu Reviewed-by: Dmitry Baryshkov Reviewed-by: Frank Li --- drivers/gpu/drm/bridge/fsl-ldb.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl

[PATCH v4 3/9] drm/bridge: fsl-ldb: Add support for i.MX94

2025-09-03 Thread Laurentiu Palcu
ned-off-by: Laurentiu Palcu Reviewed-by: Frank Li --- drivers/gpu/drm/bridge/fsl-ldb.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 665053d0cb79d..4052e1ea9201f 100644 --- a/drivers/gpu/

[PATCH v4 1/9] dt-bindings: display: fsl,ldb: Add i.MX94 LDB

2025-09-03 Thread Laurentiu Palcu
i.MX94 has a single LVDS port and share similar LDB and LVDS control registers as i.MX8MP and i.MX93. Signed-off-by: Laurentiu Palcu Reviewed-by: Frank Li Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 2 ++ 1 file changed, 2 insertions

[PATCH v4 0/9] Add support for i.MX94 DCIF

2025-09-03 Thread Laurentiu Palcu
in DCIF driver; * addressed Rob's comments for the bindings files; * addressed a couple of checkpatch issues; Thanks, Laurentiu [1] https://lkml.org/lkml/2025/7/7/84 [2] https://www.spinics.net/lists/kernel/msg5791546.html [3] https://lkml.org/lkml/2024/11/14/262 Laurentiu Palcu (7):

Re: [PATCH v2 17/37] drm/imx-dcss: Switch to drm_atomic_get_new_crtc_state()

2025-09-02 Thread Laurentiu Palcu
d. The existing state thus points to the new state, and > we can use drm_atomic_get_new_crtc_state() instead. > > Signed-off-by: Maxime Ripard Reviewed-by: Laurentiu Palcu Thanks, Laurentiu > > --- > To: Laurentiu Palcu > To: Shawn Guo > To: Sascha Hauer > Cc:

Re: [PATCH v2] drm/imx: Remove goto label that are only used once

2025-08-08 Thread Laurentiu Palcu
On Wed, Aug 06, 2025 at 08:35:45PM +0800, Liao Yuanhong wrote: > Remove unnecessary goto labels to improve code readability. > > Signed-off-by: Liao Yuanhong Reviewed-by: Laurentiu Palcu Thanks, Laurentiu > --- > Changes in v2: > Further simplify the return value by u

Re: [PATCH v3 5/9] drm/imx: Add support for i.MX94 DCIF

2025-08-07 Thread Laurentiu Palcu
On Wed, Aug 06, 2025 at 11:43:50AM -0400, Frank Li wrote: > On Wed, Aug 06, 2025 at 06:05:12PM +0300, Laurentiu Palcu wrote: > > From: Sandor Yu > > > > The i.MX94 Display Control Interface features: > > * Up to maximum 3 layers of alpha blending: > >

Re: [PATCH v3 0/9] Add support for i.MX94 DCIF

2025-08-07 Thread Laurentiu Palcu
On Thu, Aug 07, 2025 at 09:26:55AM +0200, Krzysztof Kozlowski wrote: > On Wed, Aug 06, 2025 at 06:05:07PM +0300, Laurentiu Palcu wrote: > > Hi, > > > > This patch-set adds support for the i.MX94 Display Control Interface. > > It depends on Peng Fan's DTS patch [

Re: [PATCH v3 4/9] dt-bindings: display: imx: Add bindings for i.MX94 DCIF

2025-08-07 Thread Laurentiu Palcu
On Wed, Aug 06, 2025 at 11:27:44AM -0400, Frank Li wrote: > On Wed, Aug 06, 2025 at 06:05:11PM +0300, Laurentiu Palcu wrote: > > DCIF is the i.MX94 Display Controller Interface which is used to > > drive a TFT LCD panel or connects to a display interface depending > > on t

[PATCH v3 2/9] drm/bridge: fsl-ldb: Get the next non-panel bridge

2025-08-06 Thread Laurentiu Palcu
panel bridge only. Signed-off-by: Liu Ying Signed-off-by: Laurentiu Palcu Reviewed-by: Dmitry Baryshkov Reviewed-by: Frank Li --- drivers/gpu/drm/bridge/fsl-ldb.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl

[PATCH v3 5/9] drm/imx: Add support for i.MX94 DCIF

2025-08-06 Thread Laurentiu Palcu
; - programmable background color; - embedded alpha and global alpha; * Data output with CRC checksum for 4 programmable regions; Signed-off-by: Sandor Yu Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/Kconfig | 1 + drivers/gpu/drm/imx/Makefile | 1

[PATCH v3 1/9] dt-bindings: display: fsl,ldb: Add i.MX94 LDB

2025-08-06 Thread Laurentiu Palcu
i.MX94 has a single LVDS port and share similar LDB and LVDS control registers as i.MX8MP and i.MX93. Signed-off-by: Laurentiu Palcu Reviewed-by: Frank Li Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 2 ++ 1 file changed, 2 insertions

[PATCH v3 4/9] dt-bindings: display: imx: Add bindings for i.MX94 DCIF

2025-08-06 Thread Laurentiu Palcu
DCIF is the i.MX94 Display Controller Interface which is used to drive a TFT LCD panel or connects to a display interface depending on the chip configuration. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx94-dcif.yaml | 82 +++ 1 file changed, 82 insertions

[PATCH v3 3/9] drm/bridge: fsl-ldb: Add support for i.MX94

2025-08-06 Thread Laurentiu Palcu
ned-off-by: Laurentiu Palcu Reviewed-by: Frank Li --- drivers/gpu/drm/bridge/fsl-ldb.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 665053d0cb79d..4052e1ea9201f 100644 --- a/drivers/gpu/

[PATCH v3 0/9] Add support for i.MX94 DCIF

2025-08-06 Thread Laurentiu Palcu
Thanks, Laurentiu [1] https://lkml.org/lkml/2025/7/7/84 [2] https://www.spinics.net/lists/kernel/msg5791546.html [3] https://lkml.org/lkml/2024/11/14/262 Laurentiu Palcu (7): dt-bindings: display: fsl,ldb: Add i.MX94 LDB drm/bridge: fsl-ldb: Add support for i.MX94 dt-bindings: display

Re: [PATCH 3/4] drm/imx: Remove goto label that are only used once

2025-08-06 Thread Laurentiu Palcu
Hi Liao, On Tue, Aug 05, 2025 at 03:46:18PM +0800, Liao Yuanhong wrote: > Remove unnecessary goto labels to improve code readability. > > Signed-off-by: Liao Yuanhong > --- > drivers/gpu/drm/imx/dcss/dcss-drv.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/d

Re: [PATCH v2 07/10] drm/imx: Add support for i.MX94 DCIF

2025-07-17 Thread Laurentiu Palcu
Hi Frank, On Wed, Jul 16, 2025 at 02:58:34PM -0400, Frank Li wrote: > On Wed, Jul 16, 2025 at 11:15:11AM +0300, Laurentiu Palcu wrote: > > From: Sandor Yu > > > > The i.MX94 Display Control Interface features: > > * Up to maximum 3 layers of alpha blending: > >

Re: [PATCH v2 02/10] clk: imx95-blk-ctl: Save/restore registers when RPM routines are called

2025-07-17 Thread Laurentiu Palcu
Hi Frank, On Wed, Jul 16, 2025 at 02:29:01PM -0400, Frank Li wrote: > On Wed, Jul 16, 2025 at 11:15:06AM +0300, Laurentiu Palcu wrote: > > If runtime PM is used for the clock providers and they're part of a > > power domain, then the power domain supply will be cut off when r

[PATCH v2 10/10] MAINTAINERS: Add entry for i.MX94 DCIF driver

2025-07-16 Thread Laurentiu Palcu
The driver is part of DRM subsystem and is located in drivers/gpu/drm/imx/dcif. Signed-off-by: Laurentiu Palcu --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e3b849ed34fde..89ce22c6a8862 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH v2 05/10] drm/bridge: fsl-ldb: Add support for i.MX94

2025-07-16 Thread Laurentiu Palcu
ned-off-by: Laurentiu Palcu --- drivers/gpu/drm/bridge/fsl-ldb.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c index 665053d0cb79d..4052e1ea9201f 100644 --- a/drivers/gpu/drm/bridge/fsl-ldb.c +++

[PATCH v2 09/10] arm64: dts: imx943-evk: Add display support using IT6263

2025-07-16 Thread Laurentiu Palcu
The ITE IT6263 based NXP LVDS to HDMI converter can be attached to the i.MX943 EVK board LVDS port using the mini-SAS connector. Signed-off-by: Laurentiu Palcu --- arch/arm64/boot/dts/freescale/imx943-evk.dts | 123 +++ 1 file changed, 123 insertions(+) diff --git a/arch/arm64

[PATCH v2 06/10] dt-bindings: display: imx: Add bindings for i.MX94 DCIF

2025-07-16 Thread Laurentiu Palcu
DCIF is the i.MX94 Display Controller Interface which is used to drive a TFT LCD panel or connects to a display interface depending on the chip configuration. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx94-dcif.yaml | 93 +++ 1 file changed, 93 insertions

[PATCH v2 03/10] dt-bindings: display: fsl,ldb: Add i.MX94 LDB

2025-07-16 Thread Laurentiu Palcu
i.MX94 has a single LVDS port and share similar LDB and LVDS control registers as i.MX8MP and i.MX93. Signed-off-by: Laurentiu Palcu --- Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v2 08/10] arm64: dts: imx943: Add display pipeline nodes

2025-07-16 Thread Laurentiu Palcu
Add display controller and LDB support in imx943. Signed-off-by: Laurentiu Palcu --- arch/arm64/boot/dts/freescale/imx943.dtsi | 56 ++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx943.dtsi b/arch/arm64/boot/dts/freescale

[PATCH v2 07/10] drm/imx: Add support for i.MX94 DCIF

2025-07-16 Thread Laurentiu Palcu
; - programmable background color; - embedded alpha and global alpha; * Data output with CRC checksum for 4 programmable regions; Signed-off-by: Sandor Yu Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/Kconfig | 1 + drivers/gpu/drm/imx/Makefile | 1

[PATCH v2 04/10] drm/bridge: fsl-ldb: Get the next non-panel bridge

2025-07-16 Thread Laurentiu Palcu
panel bridge only. Signed-off-by: Liu Ying Reviewed-by: Dmitry Baryshkov Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/bridge/fsl-ldb.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm

[PATCH v2 00/10] Add support for i.MX94 DCIF

2025-07-16 Thread Laurentiu Palcu
//lkml.org/lkml/2024/11/14/262 Laurentiu Palcu (8): clk: imx95-blk-ctl: Save platform data in imx95_blk_ctl structure clk: imx95-blk-ctl: Save/restore registers when RPM routines are called dt-bindings: display: fsl,ldb: Add i.MX94 LDB drm/bridge: fsl-ldb: Add support for i.MX94 dt-bi

[PATCH v2 02/10] clk: imx95-blk-ctl: Save/restore registers when RPM routines are called

2025-07-16 Thread Laurentiu Palcu
them in resume. Also, fix the suspend/resume routines and make sure we disable/enable the clock correctly. Signed-off-by: Laurentiu Palcu --- drivers/clk/imx/clk-imx95-blk-ctl.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/clk/imx/clk-

[PATCH v2 01/10] clk: imx95-blk-ctl: Save platform data in imx95_blk_ctl structure

2025-07-16 Thread Laurentiu Palcu
Currently, besides probe(), the platform data is read in both suspend() and resume(). Let's avoid this by making pdata a member of imx95_blk_ctl structure. Signed-off-by: Laurentiu Palcu --- drivers/clk/imx/clk-imx95-blk-ctl.c | 36 +++-- 1 file changed, 13 inser

Re: [PATCH 7/8] arm64: dts: imx943-evk: Add support for DCIF and LVDS

2025-07-15 Thread Laurentiu Palcu
Hi Frank, On Fri, Jul 11, 2025 at 01:07:06AM -0400, Frank Li wrote: > On Wed, Jul 09, 2025 at 03:23:26PM +0300, Laurentiu Palcu wrote: > > Add DT nodes for DCIF and LVDS in imx943.dtsi and activate them in > > imx943-evk.dts. > > > > Signed-off-by: Laurentiu Palcu &

Re: [PATCH 6/8] drm/imx: Add support for i.MX94 DCIF

2025-07-15 Thread Laurentiu Palcu
Hi Frank, On Fri, Jul 11, 2025 at 01:01:20AM -0400, Frank Li wrote: > On Wed, Jul 09, 2025 at 03:23:25PM +0300, Laurentiu Palcu wrote: > > From: Sandor Yu > > > > This patch adds support for the i.MX94 Display Control Interface. > > Needn't word "this patc

Re: [PATCH 1/8] clk: imx95-blk-ctl: Cache registers when RPM routines are called

2025-07-15 Thread Laurentiu Palcu
Hi Frank, On Fri, Jul 11, 2025 at 12:03:22AM -0400, Frank Li wrote: > Subject: > save and store registers at suspend()/resume() function > > On Wed, Jul 09, 2025 at 03:23:20PM +0300, Laurentiu Palcu wrote: > > If runtime PM is used for the clock providers and they're par

[PATCH 8/8] MAINTAINERS: Add entry for i.MX94 DCIF driver

2025-07-09 Thread Laurentiu Palcu
The driver is part of DRM subsystem and is located in drivers/gpu/drm/imx/dcif. Signed-off-by: Laurentiu Palcu --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8be3e0fbe72b8..fbec7e42e693b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH 7/8] arm64: dts: imx943-evk: Add support for DCIF and LVDS

2025-07-09 Thread Laurentiu Palcu
Add DT nodes for DCIF and LVDS in imx943.dtsi and activate them in imx943-evk.dts. Signed-off-by: Laurentiu Palcu --- arch/arm64/boot/dts/freescale/imx943-evk.dts | 126 +++ arch/arm64/boot/dts/freescale/imx943.dtsi| 56 - 2 files changed, 181 insertions(+), 1

[PATCH 6/8] drm/imx: Add support for i.MX94 DCIF

2025-07-09 Thread Laurentiu Palcu
From: Sandor Yu This patch adds support for the i.MX94 Display Control Interface. Signed-off-by: Sandor Yu Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/Kconfig | 1 + drivers/gpu/drm/imx/Makefile | 1 + drivers/gpu/drm/imx/dcif/Kconfig | 12 + drivers

[PATCH 5/8] dt-bindings: display: imx: Add bindings for i.MX94 DCIF

2025-07-09 Thread Laurentiu Palcu
DCIF is the i.MX94 Display Controller Interface which is used to drive a TFT LCD panel or connects to a display interface depending on the chip configuration. Signed-off-by: Laurentiu Palcu --- .../bindings/display/imx/nxp,imx94-dcif.yaml | 101 ++ 1 file changed, 101

[PATCH 4/8] drm/bridge: fsl-ldb: Add support for i.MX94

2025-07-09 Thread Laurentiu Palcu
Since i.MX94 series LDB controller is compatible, add support for it. Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/bridge/fsl-ldb.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c

[PATCH 3/8] drm/bridge: fsl-ldb: Get the next non-panel bridge

2025-07-09 Thread Laurentiu Palcu
panel bridge only. Signed-off-by: Liu Ying Reviewed-by: Dmitry Baryshkov Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/bridge/fsl-ldb.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm

[PATCH 1/8] clk: imx95-blk-ctl: Cache registers when RPM routines are called

2025-07-09 Thread Laurentiu Palcu
ng up the consumer clock settings. Also, fix the suspend/resume routines as well, as the clock was left ON when going to suspend. Fixes: 5224b189462f ("clk: imx: add i.MX95 BLK CTL clk driver") Signed-off-by: Laurentiu Palcu --- drivers/clk/imx/clk-imx95-blk-ctl.c | 55 +

[PATCH 2/8] dt-bindings: display: fsl,ldb: Add binding for i.MX94

2025-07-09 Thread Laurentiu Palcu
i.MX94 LDB controller is compatible with i.MX93. Signed-off-by: Laurentiu Palcu --- Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree

[PATCH 0/8] Add support for i.MX94 DCIF

2025-07-09 Thread Laurentiu Palcu
/2025/7/7/78 [2] https://lkml.org/lkml/2024/11/14/262 Laurentiu Palcu (6): clk: imx95-blk-ctl: Cache registers when RPM routines are called dt-bindings: display: fsl,ldb: Add binding for i.MX94 drm/bridge: fsl-ldb: Add support for i.MX94 dt-bindings: display: imx: Add bindings for i.MX94

Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header

2024-11-04 Thread Laurentiu Palcu
DRM_BRIDGE_ATTACH_NO_CONNECTOR); > | ^ > > Include the header directly. > > Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y") > Signed-off-by: Arnd Bergmann Reviewed-by: Laurentiu Palcu Unfortun

Re: [PATCH v2 07/10] drm/imx/dcss: Allow build with COMPILE_TEST=y

2024-10-04 Thread Laurentiu Palcu
Hi, On Thu, Oct 03, 2024 at 02:18:48PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Allow imx/dcss to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. > > Cc: Laurentiu Palcu > Cc: Lucas Stach > Signed-off-by: Vill

Re: [PATCH v2 06/10] drm/imx/dcss: Fix 64bit divisions

2024-10-04 Thread Laurentiu Palcu
Hi, On Thu, Oct 03, 2024 at 02:18:47PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use the appropriate 64bit division helpers to make the code > build on 32bit architectures. > > Cc: Laurentiu Palcu > Cc: Lucas Stach > Signed-off-by: Ville Syrjälä Revi

Re: [PATCH v2 2/5] drm/imx/dcss: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-20 Thread Laurentiu Palcu
initial support for DCSS on iMX8MQ") > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Jinjie Ruan Reviewed-by: Laurentiu Palcu Thanks, Laurentiu > --- > v2: > - Add Reviewed-by. > --- > drivers/gpu/drm/imx/dcss/dcss-dtg.c | 4 +--- > 1 file changed, 1 insertion

Re: [PATCH v2 1/5] drm/imx: Use IRQF_NO_AUTOEN flag in request_irq()

2024-09-20 Thread Laurentiu Palcu
drm/imx: Add initial support for DCSS on iMX8MQ") > Signed-off-by: Jinjie Ruan I think the commit subject should start with drm/imx/dcss. Not sure if this is worth another patch set just for that. I suppose the commiter could fix it before pushing. Other than that: Reviewed-by: Laurent

Re: [PATCH] drm/imx/dcss: fix resource size calculation

2024-02-28 Thread Laurentiu Palcu
> > Fixes: 90393c9b5408 ("drm/imx/dcss: request memory region") > Signed-off-by: Dan Carpenter Reviewed-by: Laurentiu Palcu And pushed to drm-misc-next-fixes. Thanks, Laurentiu > --- > From static analysis. Not tested. > > drivers/gpu/drm/imx/dcss/dcss

Re: [PATCH v4 0/2] drm/imx/dcss: implement region request and devres

2024-02-02 Thread Laurentiu Palcu
Hi Philipp, Applied series to drm-misc-next. Thanks, Laurentiu On Wed, Jan 24, 2024 at 12:19:03PM +0100, Philipp Stanner wrote: > @Laurentiu: > Thank you very much for the review. I was indeed on an older branch. As > Linus's master is currently broken for ARM64 [1], unfortunately, I built > it

Re: [PATCH v4 2/2] drm/imx/dcss: have all init functions use devres

2024-02-02 Thread Laurentiu Palcu
> > Port all memory allocations and ioremap() calls to the devres > counterparts. > > Signed-off-by: Philipp Stanner Reviewed-by: Laurentiu Palcu Thanks, Laurentiu > --- > drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 13 ++--- > drivers/gpu/drm/imx/dcss/dcss-ctxld

Re: [PATCH v3 2/2] drm/imx/dcss: have all init functions use devres

2024-01-17 Thread Laurentiu Palcu
Hi Philipp, Several minor comments below. On Thu, Jan 11, 2024 at 11:13:47AM +0100, Philipp Stanner wrote: > dcss currently allocates and ioremaps quite a few resources in its probe > function's call graph. Devres now provides convenient functions which > perform the same task but do the cleanup

Re: [PATCH v3 1/2] drm/imx/dcss: request memory region

2024-01-17 Thread Laurentiu Palcu
egion-request through the corresponding managed > devres-function. > > Signed-off-by: Philipp Stanner Reviewed-by: Laurentiu Palcu Thanks, Laurentiu > --- > drivers/gpu/drm/imx/dcss/dcss-dev.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/

Re: [PATCH] MAINTAINERS: Document that the NXP i.MX 8MQ DCSS driver goes thru drm-misc

2023-09-25 Thread Laurentiu Palcu
...@fsr-ub1664-121.ea.freescale.net > > Signed-off-by: Douglas Anderson Acked-by: Laurentiu Palcu Thanks, Laurentiu > --- > > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d72d3af551fb..d20a375ecd7d 1

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-24 Thread Laurentiu Palcu
Hi Doug, On Fri, Sep 22, 2023 at 08:44:16AM -0700, Doug Anderson wrote: > Hi, > > On Fri, Sep 22, 2023 at 12:56 AM Laurentiu Palcu > wrote: > > > > Hi, > > > > On Thu, Sep 21, 2023 at 12:26:44PM -0700, Douglas Anderson wrote: > > > Based on greppin

Re: [RFT PATCH v2 01/12] drm/imx/dcss: Call drm_atomic_helper_shutdown() at shutdown time

2023-09-22 Thread Laurentiu Palcu
> Reviewed-by: Maxime Ripard > Signed-off-by: Douglas Anderson No issues found on i.MX8MQ. Tested-by: Laurentiu Palcu Reviewed-by: Laurentiu Palcu Thanks, Laurentiu > --- > This commit is only compile-time tested. > > (no changes since v1) > > drivers/gpu/drm/imx/dc

Re: [PATCH 1/1] drm/imx/dcss: Use dev_err_probe

2023-07-28 Thread Laurentiu Palcu
Hi, On Mon, Jul 17, 2023 at 11:29:50AM +0200, Alexander Stein wrote: > This helps identifying problems with downstream pipeline devices, like > HDMI/DP output. > > Signed-off-by: Alexander Stein Reviewed-by: Laurentiu Palcu Pushed to drm-misc-next. Thanks, Laurentiu > --- >

Re: [PATCH v2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-18 Thread Laurentiu Palcu
vice+0xe0/0x164 > __device_attach_driver+0xc0/0x13c > bus_for_each_drv+0x84/0xe0 > __device_attach+0xa4/0x1a0 > device_initial_probe+0x1c/0x30 > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0x90/0xd0 > process_one_work+0x200/0x474 > worker_thread+0x74/0x43c

Re: [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Laurentiu Palcu
xf0 > driver_probe_device+0xe0/0x164 > __device_attach_driver+0xc0/0x13c > bus_for_each_drv+0x84/0xe0 > __device_attach+0xa4/0x1a0 > device_initial_probe+0x1c/0x30 > bus_probe_device+0xa4/0xb0 > deferred_probe_work_func+0x90/0xd0 > process_one_work+0x200/0x474 >

Re: [PATCH 2/2] drm/imx/dcss: Don't call dev_set_drvdata(..., NULL);

2023-01-10 Thread Laurentiu Palcu
Hi, On Fri, Dec 30, 2022 at 02:00:25PM +0100, Uwe Kleine-König wrote: > The driver core takes care about removing driver data, so this can be > dropped from the driver. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurentiu Palcu Pushed to drm-misc-next. Thank

Re: [PATCH 1/2] drm/imx/dcss: Drop if blocks with always false condition

2023-01-10 Thread Laurentiu Palcu
L. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Laurentiu Palcu Pushed to drm-misc-next. Thanks, laurentiu > --- > drivers/gpu/drm/imx/dcss/dcss-drv.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/imx/dcss/dcss-drv.c > b/drive

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-09 Thread Laurentiu Palcu
Hi, On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > Hi, > > On 09/01/2023 18:21, Laurentiu Palcu wrote: > > Hi Dmitry, > > > > It looks like there are some issues with this patchset... :/ I just > > fetched the drm-tip and, with thes

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-01-09 Thread Laurentiu Palcu
Hi Dmitry, It looks like there are some issues with this patchset... :/ I just fetched the drm-tip and, with these patches included, the "Hot plug detection already enabled" warning is back for i.MX DCSS. After a short investigation, it seems that we end up calling drm_bridge_hpd_enable() from bo

Re: [PATCH 10/26] drm: imx/dcss: Remove #ifdef guards for PM related functions

2022-11-11 Thread Laurentiu Palcu
t having to use #ifdef > guards. > > This has the advantage of always compiling these functions in, > independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. > > Signed-off-by: Paul Cercueil Reviewed-by: Laurentiu Palcu

Re: [PATCH] drm/imx/dcss: get rid of HPD warning message

2022-08-04 Thread Laurentiu Palcu
On Thu, Jul 21, 2022 at 03:25:02PM +0300, Laurent Pinchart wrote: > Hi Laurentiu, > > Thank you for the patch. > > On Thu, Jul 21, 2022 at 03:09:12PM +0300, Laurentiu Palcu wrote: > > When DCSS + MIPI_DSI is used, and the last bridge in the chain supports > >

[PATCH] drm/imx/dcss: get rid of HPD warning message

2022-07-21 Thread Laurentiu Palcu
ion, which made the drm_bridge_connector_enable_hpd() call, in DCSS init path, redundant. So, let's remove that call. Fixes: 09077bc311658 ("drm/bridge_connector: enable HPD by default if supported") Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/dcss/dcss-kms.c | 2 -

Re: [PATCH v2] drm/imx/dcss: Add missing of_node_put() in fail path

2022-07-20 Thread Laurentiu Palcu
/imx: Add initial support for DCSS on iMX8MQ") > Signed-off-by: Liang He Reviewed-by: Laurentiu Palcu Applied to drm-misc-fixes. Thanks, Laurentiu > --- > changelog: > > v2: add of_node_put() in dcss_dev_destroy() advised by Laurentiu > v1: only fix bug in dcss_dev_

Re: [PATCH] drm/imx/dcss: Add missing of_node_put() in fail path

2022-07-14 Thread Laurentiu Palcu
Hi Liang, Thanks for the patch. The patch is ok but, since you're at it, maybe add of_node_put() in the dcss_dev_destroy() too? Thanks, laurentiu On Thu, Jul 07, 2022 at 10:32:14AM +0800, Liang He wrote: > In dcss_dev_create(), we should call of_node_put() in fail path for > of_graph_get_port_b

Re: [PATCH] drm/imx/dcss: i.MX8MQ DCSS select DRM_GEM_CMA_HELPER

2022-02-18 Thread Laurentiu Palcu
Hi Rudi, On Wed, Feb 16, 2022 at 09:22:28PM +, Rudi Heitbaum wrote: > Without DRM_GEM_CMA_HELPER i.MX8MQ DCSS won't build. This needs to be > there. > > Signed-off-by: Rudi Heitbaum Reviewed-by: Laurentiu Palcu ...and pushed to drm-misc-fixes. Thanks, laurentiu > --

Re: [PATCH 2/2] drm/imx/dcss: select DRM_KMS_HELPER

2021-12-13 Thread Laurentiu Palcu
Hi Lucas, On Sat, Dec 11, 2021 at 11:18:48PM +0100, Lucas Stach wrote: > DCSS can not be built without the DRM_KMS_HELPERs being available. > Select this symbol to disallow this invalid configuration. > > Signed-off-by: Lucas Stach Reviewed-by: Laurentiu Palcu Can you also

Re: [PATCH 1/2] drm/imx/dcss: add missing drm_bridge.h include

2021-12-13 Thread Laurentiu Palcu
Hi Lucas, On Sat, Dec 11, 2021 at 11:18:47PM +0100, Lucas Stach wrote: > This has been pulled in via some other include before, which is no > longer true. > > Signed-off-by: Lucas Stach > --- Reviewed-by: Laurentiu Palcu > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 + &g

Re: [PATCH v2 09/22] drm/imx: Don't set struct drm_device.irq_enabled

2021-06-22 Thread Laurentiu Palcu
ms.c | 3 --- Not sure if it's worth the effort but, since DCSS is a completely self-contained driver, maybe it would be good to split this patch in 2 as well. Anyway, for DCSS bit: Acked-by: Laurentiu Palcu Thanks, laurentiu > drivers/gpu/drm/imx/imx-drm-core.c | 11 --- &

Re: [PATCH v9 6/6] MAINTAINERS: add maintainer for i.MX8qxp DPU DRM driver

2021-04-21 Thread Laurentiu Palcu
Hi, On Mon, Mar 29, 2021 at 01:57:26PM +0800, Liu Ying wrote: > Add myself as the maintainer of the i.MX8qxp DPU DRM driver. > > Signed-off-by: Liu Ying Acked-by: Laurentiu Palcu Thanks, laurentiu > --- > v8->v9: > * No change. > > v7->v8: > * No change. &g

Re: [PATCH] drm/imx/dcss: Use device_get_match_data()

2021-03-22 Thread Laurentiu Palcu
Hi Fabio, On Mon, Mar 15, 2021 at 09:38:11AM -0300, Fabio Estevam wrote: > The retrieval of driver data can be a bit simplified by using > device_get_match_data(), so switch to it. > > Signed-off-by: Fabio Estevam Reviewed-by: Laurentiu Palcu > --- > drivers/gpu/drm/imx/d

Re: [PATCH v8 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-03-02 Thread Laurentiu Palcu
Hi Liu Ying, One comment below. On Tue, Mar 02, 2021 at 02:33:15PM +0800, Liu Ying wrote: > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM support. > > DPU is comprised of two main components that include a blit engine for > 2D graphics accelerations(with composition support)

Re: [PATCH v6 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-25 Thread Laurentiu Palcu
Hi Liu Ying, Just some minor comments below. On Thu, Jan 21, 2021 at 03:14:22PM +0800, Liu Ying wrote: > This patch introduces i.MX8qm/qxp Display Processing Unit(DPU) DRM support. > > DPU is comprised of two main components that include a blit engine for > 2D graphics accelerations(with composi

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-20 Thread Laurentiu Palcu
Hi Liu Ying, On Wed, Jan 20, 2021 at 04:42:50PM +0800, Liu Ying wrote: > Hi Laurentiu, > > On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > > Hi Liu Ying, > > > > I promised I would have a second, more in-depth, look at this and I finally > > managed

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-15 Thread Laurentiu Palcu
Hi Liu Ying, I promised I would have a second, more in-depth, look at this and I finally managed to do it. I have to admit it was a challenge. Partially because I'm not very familiar with DPU but mostly because of the abundance of macros used. It's true, macros make the code more compact. However

Re: [RFC] dcss: fix attaching to sn56dsi86 bridge

2020-11-24 Thread Laurentiu Palcu
Hi Lukas, On Tue, Nov 24, 2020 at 06:19:57PM +0100, Lukas F. Hartmann wrote: > The sn56dsi86 DSI to eDP bridge driver does not support attaching > without a drm connector. I think the SN65DSI86 driver is exactly what you should focus on, so that it works when connector is optional. The ADV7511/AD

Re: [PATCH 5/8] drm/imx: Introduce i.MX8qxp DPU DRM

2020-11-23 Thread Laurentiu Palcu
Hi Liu Ying, On Mon, Nov 23, 2020 at 10:45:38AM +0800, Liu Ying wrote: > Hi Laurentiu, > > On Fri, 2020-11-20 at 16:38 +0200, Laurentiu Palcu wrote: > > Hi Liu Ying, > > > > I gave this a first look but, since this is a huge piece of code and I'm not > >

Re: [PATCH 5/8] drm/imx: Introduce i.MX8qxp DPU DRM

2020-11-20 Thread Laurentiu Palcu
Hi Liu Ying, I gave this a first look but, since this is a huge piece of code and I'm not very familiar with DPU, I'll probably give it another pass next week. Anyway, some comments/questions inline. On Thu, Nov 19, 2020 at 11:22:22AM +0200, Liu Ying wrote: > This patch introduces i.MX8qxp Displ

Re: [PATCH 0/8] drm/imx: Introduce i.MX8qxp DPU DRM

2020-11-19 Thread Laurentiu Palcu
Hi Liu Ying, On Thu, Nov 19, 2020 at 05:22:17PM +0800, Liu Ying wrote: > Hi, > > > This patch set introduces i.MX8qxp Display Processing Unit(DPU) DRM support. Glad to see this series out. However, something went wrong with it as patch 5/8 didn't make it to dri-devel mailing list... :/ https:/

[PATCH] drm/imx/dcss: allow using nearest neighbor interpolation scaling

2020-11-05 Thread Laurentiu Palcu
This patch adds support for using NN interpolation scaling by setting the SCALING_FILTER plane property to 1. Otherwise, the default method is used. Signed-off-by: Laurentiu Palcu --- I had no retro pixel art games to test this with, so I used modetest to see the results: To test, I used a

[PATCH 2/2] drm/imx/dcss: fix coccinelle warning

2020-11-05 Thread Laurentiu Palcu
X8MQ") Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/dcss/dcss-plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/dcss/dcss-plane.c b/drivers/gpu/drm/imx/dcss/dcss-plane.c index 46a188dd02ad..5db093aada2f 100644 --- a/drivers/gpu/drm/imx

[PATCH 0/2] drm/imx/dcss: a couple of fixes

2020-11-05 Thread Laurentiu Palcu
Hi, This patchset fixes 90/270 rotations for Vivante tiled and super-tiled formats and a Coccinelle warning. Thanks, laurentiu Laurentiu Palcu (2): drm/imx/dcss: fix rotations for Vivante tiled formats drm/imx/dcss: fix coccinelle warning drivers/gpu/drm/imx/dcss/dcss-plane.c | 14

[PATCH 1/2] drm/imx/dcss: fix rotations for Vivante tiled formats

2020-11-05 Thread Laurentiu Palcu
ource width and height need to be swapped since DPR is sending the buffer to scaler already rotated. Also, make sure to allow full rotations for DRM_FORMAT_MOD_VIVANTE_SUPER_TILED. Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ") Signed-off-by: Laurentiu Palcu -

Re: [PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Laurentiu Palcu
of > this change. > > Two callbacks, .gem_prime_export and .gem_prime_import, were initialized > to their default implementations, so they are just kept empty now. > > Signed-off-by: Thomas Zimmermann > Reported-by: kernel test robot > --- Reviewed-by: Laurentiu Palcu Than

[PATCH] drm/imx/dcss: fix 64-bit divisions

2020-09-11 Thread Laurentiu Palcu
Use div_s64() for the 64-bit divisions. This would allow the driver to compile on 32-bit architectures, if needed. Signed-off-by: Laurentiu Palcu --- drivers/gpu/drm/imx/dcss/dcss-scaler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/dcss/dcss

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurentiu Palcu
Hi Pekka, On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: > On Thu, 10 Sep 2020 12:30:09 +0300 > Laurentiu Palcu wrote: > > > Hi Pekka, > > > > On Thu, Sep 10, 2020 at 11:50:26AM +0300, Pekka Paalanen wrote: > > > On Thu, 10 Sep 2020 09:52

  1   2   >