On 28.08.24 15:32, Tomi Valkeinen wrote:
> On 26/08/2024 22:35, Jan Kiszka wrote:
>> On 24.06.24 12:17, Dmitry Baryshkov wrote:
>>> On Mon, 24 Jun 2024 at 13:07, Alexander Stein
>>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> Am Monta
gt;>>>
>>>>
>>>> On 22/06/24 17:49, Dmitry Baryshkov wrote:
>>>>> On Sat, Jun 22, 2024 at 05:16:58PM GMT, Aradhya Bhatia wrote:
>>>>>>
>>>>>>
>>>>>> On 17-Jun-24 13:41, Dmitry Baryshkov wrote:
>>>
On 14.06.2024 18:35, Demi Marie Obenour wrote:
> On Fri, Jun 14, 2024 at 08:38:51AM +0200, Jan Beulich wrote:
>> On 13.06.2024 20:43, Demi Marie Obenour wrote:
>>> 2. Add support for `XEN_DOMCTL_memory_mapping` to use system RAM, not
>>>just
On 16.02.24 15:57, Marek Vasut wrote:
> On 2/16/24 10:10, Tomi Valkeinen wrote:
>> On 15/02/2024 11:03, Alexander Stein wrote:
>>> Hi everyone,
>>>
>>> Am Donnerstag, 15. Februar 2024, 09:53:54 CET schrieb Jan Kiszka:
>>>> On 11.12.23 09:07, Ara
> at any time for accessing the AUX channel.
>
> + Marek
>
> Marek, Alexander,
>
> A quick grep tells me that you have added devicetree for tc358767 in DSI
> to (e)DP mode on other platforms. Could you please test these patches
> and report if you find any issue?
Is this the last blocker to move forward with these fixes? I'd really
like to see them finally merged.
Thanks,
Jan
--
Siemens AG, Technology
Linux Expert Center
8a47a2881534923f
> change-id: 20231031-tc358767-58e3ebdf95f0
>
> Best regards,
What's the plan for these fixes? I'm not yet seeing them in Linus' tree,
thus also not in stable.
Jan
--
Siemens AG, Technology
Linux Expert Center
On Wed 22-11-23 13:48:25, Christian Brauner wrote:
> No caller care about the return value.
>
> Signed-off-by: Christian Brauner
Yup. Feel free to add:
Reviewed-by: Jan Kara
Honza
> ---
> fs/eventfd.c
to add:
Reviewed-by: Jan Kara
Honza
> ---
> fs/eventfd.c| 7 ---
> include/linux/eventfd.h | 5 ++---
> io_uring/io_uring.c | 4 ++--
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
>
ng that additional argument.
>
> Signed-off-by: Christian Brauner
Looks good. Feel free to add:
Reviewed-by: Jan Kara
Honza
> ---
> arch/x86/kvm/hyperv.c | 2 +-
> arch/x86/kvm/xen.c
On Wed 22-11-23 13:48:22, Christian Brauner wrote:
> The single caller of inject_virtual_interrupt() ignores the return value
> anyway. This allows us to simplify eventfd_signal() in follow-up
> patches.
>
> Signed-off-by: Christian Brauner
Looks good. Feel free to add:
Review
8a47a2881534923f
> change-id: 20231031-tc358767-58e3ebdf95f0
>
> Best regards,
Tested-by: Jan Kiszka
Would be good to have that in stable for 6.6 as well then.
Thanks,
Jan
--
Siemens AG, Technology
Linux Expert Center
On 31.10.23 11:53, Tomi Valkeinen wrote:
> Hi Jan,
>
> On 31/10/2023 08:24, Jan Kiszka wrote:
>> On 30.10.23 20:28, Aradhya Bhatia wrote:
>>> With new connector model, tc358767 will not create the connector, when
>>> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set a
egotiation hook in the
> drm_bridge_funcs to complete DRM_BRIDGE_ATTACH_NO_CONNECTOR support.
>
> Input format is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, as is
> the case with older model.
>
> Reported-by: Jan Kiszka
> Signed-off-by: Aradhya Bhatia
> ---
&
dss->crtcs[tidss->num_crtcs++] = &tcrtc->crtc;
>
> - enc = tidss_encoder_create(tidss, pipes[i].enc_type,
> + ret = tidss_encoder_create(tidss, pipes[i].bridge,
> + pipes[i].enc_type,
> 1 << tcrtc->crtc.index);
> - if (IS_ERR(enc)) {
> + if (ret) {
> dev_err(tidss->dev, "encoder create failed\n");
> - return PTR_ERR(enc);
> - }
> -
> - ret = drm_bridge_attach(enc, pipes[i].bridge, NULL, 0);
> - if (ret)
> return ret;
> + }
> }
>
> /* create overlay planes of the leftover planes */
This breaks the IOT2050 devices over 6.6, just bisected to it:
[3.435153] [drm] Initialized tidss 1.0.0 20180215 for 4a0.dss on minor 0
[3.491246] tidss 4a0.dss: [drm] Cannot find any crtc or sizes
vs.
[3.436116] [drm] Initialized tidss 1.0.0 20180215 for 4a0.dss on minor 0
[3.910574] Console: switching to colour frame buffer device 80x30
[3.937614] tidss 4a0.dss: [drm] fb0: tidssdrmfb frame buffer device
Do we need to adjust its device tree to anything, or what may be the
reason?
Jan
--
Siemens AG, Technology
Linux Expert Center
ueshi Hu
Looks good to me. Feel free to add:
Reviewed-by: Jan Kara
Honza
> ---
> Changes in v2:
> - make noop_dirty_folio() inline as suggested by Matthew
> - v1:
> https://lore.kernel.org/li
Xueshi Hu
Yeah, looks sensible to me but for some callbacks we are oscilating between
all users having to provide some callback and providing some default
behavior for NULL callback. I don't have a strong opinion either way so
feel free to add:
Reviewed-by: Jan Kara
But I guess let's
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> - Library General Public License for more details.
> -
> - You should have received a copy of the GNU Library General Public
> - License along with the GNU C Library; see the file COPYING.LIB. If not,
> - write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> - Boston, MA 02111-1307, USA. */
> +/* SPDX-License-Identifier: GPL-2.0-only */
>
> /*
> * dgb 10/02/98: ripped this from glibc source to help convert timestamps
> diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c
> index 622569007b530b..5d6b66e15fcded 100644
> --- a/fs/udf/unicode.c
> +++ b/fs/udf/unicode.c
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> /*
> * unicode.c
> *
> @@ -11,11 +12,6 @@
> * UTF-8 is explained in the IETF RFC .
> * ftp://ftp.internic.net/rfc/rfc.txt
> *
> - * COPYRIGHT
> - * This file is distributed under the terms of the GNU General Public
> - * License (GPL). Copies of the GPL can be obtained from:
> - * ftp://prep.ai.mit.edu/pub/gnu/GPL
> - * Each contributing author retains all rights to their own work.
> */
>
> #include "udfdecl.h"
> --
> An old man doll... just what I always wanted! - Clara
>
--
Jan Kara
SUSE Labs, CR
On 16.03.2023 14:53, Alex Deucher wrote:
> On Thu, Mar 16, 2023 at 9:48 AM Juergen Gross wrote:
>>
>> On 16.03.23 14:45, Alex Deucher wrote:
>>> On Thu, Mar 16, 2023 at 3:50 AM Jan Beulich wrote:
>>>>
>>>> On 16.03.2023 00:25, Stefano Stabelli
On 16.03.2023 00:25, Stefano Stabellini wrote:
> On Wed, 15 Mar 2023, Jan Beulich wrote:
>> On 15.03.2023 01:52, Stefano Stabellini wrote:
>>> On Mon, 13 Mar 2023, Jan Beulich wrote:
>>>> On 12.03.2023 13:01, Huang Rui wrote:
>>>>> Xen PVH is th
On 15.03.2023 05:14, Huang Rui wrote:
> On Wed, Mar 15, 2023 at 08:52:30AM +0800, Stefano Stabellini wrote:
>> On Mon, 13 Mar 2023, Jan Beulich wrote:
>>> On 12.03.2023 13:01, Huang Rui wrote:
>>>> Xen PVH is the paravirtualized mode and takes advantage of hardware
&g
On 15.03.2023 01:52, Stefano Stabellini wrote:
> On Mon, 13 Mar 2023, Jan Beulich wrote:
>> On 12.03.2023 13:01, Huang Rui wrote:
>>> Xen PVH is the paravirtualized mode and takes advantage of hardware
>>> virtualization support when possible. It will using the hardwar
no way (yet) to drive the IOMMU, so how can it get
away without resorting to swiotlb in certain cases (like I/O to an
address-restricted device)?
Jan
On 18.10.2022 13:02, Christoph Hellwig wrote:
> On Tue, Oct 18, 2022 at 10:57:37AM +0200, Jan Beulich wrote:
>> Shouldn't this then be xen_pv_domain() that you use here, and - if you
>> really want IS_ENABLED() in addition - CONFIG_XEN_PV?
>
> I'll need help from pe
;
> }
Shouldn't this then be xen_pv_domain() that you use here, and - if you
really want IS_ENABLED() in addition - CONFIG_XEN_PV?
Jan
eal function.
>
> Reviewed-by: Kees Cook
> Signed-off-by: Jason A. Donenfeld
Looks good. Feel free to add:
Reviewed-by: Jan Kara
for the ext4 bits.
Honza
--
Jan Kara
SUSE Labs, CR
d-by: Kees Cook
> Reviewed-by: KP Singh
> Reviewed-by: Christoph Böhmwalder
> Signed-off-by: Jason A. Donenfeld
Feel free to add:
Reviewed-by: Jan Kara
for the ext2, ext4, and lib/sbitmap.c bits.
Honza
--
Jan Kara
SUSE Labs, CR
sumably we didn't want to use modulo here because EXT4_MMP_SEQ_MAX
is rather big and so the resulting 'new_seq' would be seriously
non-uniform.
Honza
--
Jan Kara
SUSE Labs, CR
On Thu 03-03-22 10:00:33, Byungchul Park wrote:
> On Mon, Feb 28, 2022 at 11:14:44AM +0100, Jan Kara wrote:
> > On Mon 28-02-22 18:28:26, Byungchul Park wrote:
> > > case 1. Code with an actual circular dependency, but not deadlock.
> > >
> > >A circular
On Mon 28-02-22 18:28:26, Byungchul Park wrote:
> On Thu, Feb 24, 2022 at 11:22:39AM +0100, Jan Kara wrote:
> > On Thu 24-02-22 10:11:02, Byungchul Park wrote:
> > > On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote:
> > > > > KJOURNALD2(kthread) TASK1(k
On Thu 24-02-22 10:11:02, Byungchul Park wrote:
> On Wed, Feb 23, 2022 at 03:48:59PM +0100, Jan Kara wrote:
> > > KJOURNALD2(kthread) TASK1(ksys_write) TASK2(ksys_write)
> > >
> > > wait A
> > > --- stuck
> > >
On Wed 23-02-22 09:35:34, Byungchul Park wrote:
> On Mon, Feb 21, 2022 at 08:02:04PM +0100, Jan Kara wrote:
> > On Thu 17-02-22 20:10:04, Byungchul Park wrote:
> > > [9.008161] ===
> > > [9.008163] DEPT: Circular d
ased
on what the block is used for). Similarly how we e.g. annotate i_rwsem for
different inodes.
Honza
--
Jan Kara
SUSE Labs, CR
l/dependency/dept.c:241 kernel/dependency/dept.c:999
> kernel/dependency/dept.c:1043 kernel/dependency/dept.c:1843)
> [9.008389] ? _raw_spin_unlock_irqrestore
> (./arch/x86/include/asm/irqflags.h:45 ./arch/x86/include/asm/irqflags.h:80
> ./arch/x86/include/asm/irqflags.h:138 ./include/linux/spinlock_api_smp.h:151
> kernel/locking/spinlock.c:194)
> [9.008392] ? _raw_spin_unlock_irqrestore
> (./arch/x86/include/asm/preempt.h:103 ./include/linux/spinlock_api_smp.h:152
> kernel/locking/spinlock.c:194)
> [9.008394] ? try_to_del_timer_sync (kernel/time/timer.c:1239)
> [9.008396] kjournald2 (fs/jbd2/journal.c:214 (discriminator 3))
> [9.008398] ? prepare_to_wait_exclusive (kernel/sched/wait.c:431)
> [9.008400] ? commit_timeout (fs/jbd2/journal.c:173)
> [9.008402] kthread (kernel/kthread.c:377)
> [9.008404] ? kthread_complete_and_exit (kernel/kthread.c:332)
> [9.008407] ret_from_fork (arch/x86/entry/entry_64.S:301)
> [9.008410]
--
Jan Kara
SUSE Labs, CR
sctl-subdir-register-sysctl-simplify.cocci PATH
Heh, nice example of using Coccinelle. The result looks good. Feel free to
add:
Reviewed-by: Jan Kara
Honza
>
> @c1@
> expression E1;
> identifier subdir, sysctls;
> @@
roc_handler = proc_dointvec,
> },
> #endif
> -#ifdef CONFIG_INOTIFY_USER
> - {
> - .procname = "inotify",
> - .mode = 0555,
> - .child = inotify_table,
> - },
> -#endif
> -#ifdef CONFIG_FANOTIFY
> - {
> - .procname = "fanotify",
> - .mode = 0555,
> - .child = fanotify_table,
> - },
> -#endif
> #ifdef CONFIG_EPOLL
> {
> .procname = "epoll",
> --
> 2.33.0
>
--
Jan Kara
SUSE Labs, CR
us_driver.
I'm wondering whether it wouldn't better be the other way around: The
(hopefully few) essential ones get flagged, thus also making it more
prominent during patch review that a flag gets added (and justification
provided), instead of having to spot the lack of a flag getting set.
Jan
le to find it. Is this mmap_region change
expected to be backported to any lts kernels?
Jan
On April 21, 2021 9:20:11 AM EDT, "Christian König"
wrote:
>mmap_region() now calls fput() on the vma->vm_file.
>
>So we need to drop the extra reference on the coda file instead of
On Thu, Apr 22, 2021 at 02:39:41PM +0200, Christian König wrote:
> Am 22.04.21 um 14:27 schrieb Jan Harkes:
> > Looks good to me.
> >
> > I'm also maintaining an out of tree coda module build that people sometimes
> > use, which has workarounds for differ
One more update. without changing any cmake files the following cmdline
should work:
cmake ../llvm-project/libclc/
-DLLVM_CONFIG=/usr/local/llvm-git/bin/llvm-config
-DCMAKE_LLAsm_FLAGS=-cl-no-stdinc -DCMAKE_CLC_FLAGS=-cl-no-stdinc
Jan
On Wed, Mar 10, 2021 at 1:20 AM Jan Vesely wrote:
>
hi,
sorry the option is actually -cl-no-stdinc. you can add it to
'target_compiler_options'.
I should have a patch ready soon(tm), but time is scarce.
Jan
On Sun, Mar 7, 2021 at 9:51 PM Dieter Nützel wrote:
> Hello Jan,
>
> I very much appreciate your advice.
>
declarations can be turned off using a cmdline
switch but that remains to be implemented in the libclc build system.
manually adding '-cl-no-stdinc' should work as a workaround.
Jan
On Thu, Mar 4, 2021 at 10:27 PM Dieter Nützel wrote:
> Hello Marek,
>
> can't compile anyt
ot;ing
the dummy one.
Signed-off-by: Jan Beulich
--- a/drivers/gpu/drm/xen/Kconfig
+++ b/drivers/gpu/drm/xen/Kconfig
@@ -1,15 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_XEN
- bool "DRM Support for Xen guest OS"
- depends on XEN
- help
- Cho
On 03.12.20 22:30, Alex Deucher wrote:
> On Tue, Sep 29, 2020 at 4:04 PM Alex Deucher wrote:
>>
>> On Tue, Sep 29, 2020 at 8:31 AM Jan Kiszka wrote:
>>>
>>> On 10.09.20 20:18, Deucher, Alexander wrote:
>>>> [AMD Public Use]
>>>>
>>&
27;d exit the loop (to out: label) anyway due to the loop termination
condition and why not return the frames we already have? Furthermore
find_vma_intersection() can return NULL which would oops in your check
then. What am I missing?
Honza
>
ivers are supposed to
work.
Anyway, if you can make this go away, sure go ahead :)
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 10.09.20 20:18, Deucher, Alexander wrote:
> [AMD Public Use]
>
>
>
>> -Original Message-
>> From: amd-gfx On Behalf Of
>> Daniel Vetter
>> Sent: Monday, September 7, 2020 3:15 AM
>> To: Jan Kiszka ; amd-gfx list > g...@lists.freedesktop.or
f 1f 44 00 00 48 89
f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01
f0 ff ff 73 01 c3 48 8b 0d 07 6f 0c 00 f7 d8 64 89 01 48
[ 14.033842] RSP: 002b:7ffd03534438 EFLAGS: 0246 ORIG_RAX:
0139
[ 1
On Tuesday 2020-05-19 22:36, Sasha Levin wrote:
>
>> - Why DX12 on linux? Looking at this feels like classic divide and
>
> There is a single usecase for this: WSL2 developer who wants to run
> machine learning on his GPU. The developer is working on his laptop,
> which is running Windows and tha
Add a quirk for the Oculus Rift S OVR0012 display so
it shows up as a non-desktop display.
Signed-off-by: Jan Schmidt
---
drivers/gpu/drm/drm_edid.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 116451101426
On Friday 2020-02-28 08:59, Daniel Stone wrote:
>
>I believe that in January, we had $2082 of network cost (almost
>entirely egress; ingress is basically free) and $1750 of
>cloud-storage cost (almost all of which was download). That's based
>on 16TB of cloud-storage (CI artifacts, container image
ches.
>
>If that's too much trouble, then I'd have to fall back to submitting a few
>patches at a time and working my way up to the tracking patch...
It could also be that an ordinary page reference is dropped with 'unpin'
thus underflowing the page refcount...
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
st would work... And I don't think
making all GUP users huge page aware is realistic (effort-wise) or even
wanted (maintenance overhead in all those places).
I believe there might be also a different solution for this: For
transparent huge pages, we could find a space in '
er testing exposure and is
prepared for the next merge window.
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon 16-12-19 14:18:59, John Hubbard wrote:
> On 12/16/19 4:53 AM, Jan Kara wrote:
> > With this fixed, the patch looks good to me so you can then add:
> >
> > Reviewed-by: Jan Kara
> >
> > Ho
d get_user_pages() (LPC: Dec 12, 2018):
> https://lwn.net/Articles/774411/
> [3] The trouble with get_user_pages() (Apr 30, 2018):
> https://lwn.net/Articles/753027/
>
> Suggested-by: Jan Kara
> Suggested-by: Jérôme Glisse
> Cc: Kirill A. Shutemov
> Signed-off-b
d get_user_pages() (LPC: Dec 12, 2018):
> https://lwn.net/Articles/774411/
> [3] The trouble with get_user_pages() (Apr 30, 2018):
> https://lwn.net/Articles/753027/
>
> Suggested-by: Jan Kara
> Suggested-by: Jérôme Glisse
> Cc: Kirill A. Shutemov
> Signed-off-by: J
d get_user_pages() (LPC: Dec 12, 2018):
> https://lwn.net/Articles/774411/
> [3] The trouble with get_user_pages() (Apr 30, 2018):
> https://lwn.net/Articles/753027/
The patch looks mostly good to me now. Just a few smaller comments below.
> Suggested-by: Jan Kara
> Suggested-by
On Tue 10-12-19 18:53:13, John Hubbard wrote:
> 1. Convert from get_user_pages() to pin_user_pages().
>
> 2. As required by pin_user_pages(), release these pages via
> put_user_page().
>
> Cc: Jan Kara
> Signed-off-by: John Hubbard
The patch looks good to me. You can a
d get_user_pages() (LPC: Dec 12, 2018):
> https://lwn.net/Articles/774411/
> [3] The trouble with get_user_pages() (Apr 30, 2018):
> https://lwn.net/Articles/753027/
>
> Suggested-by: Jan Kara
> Suggested-by: Jérôme Glisse
> Signed-off-by: John Hubbard
Looks nice,
into the patch the uses
> the gup flags arguments.
You should probably implement this TODO? :)
Honza
>
> Reviewed-by: Jan Kara
> Reviewed-by: Jérôme Glisse
> Reviewed-by: Ira Weiny
> Cc: Kirill A. Shu
before the video HW
stored data in the page) and the page then gets evicted from the page cache.
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
t; avoid writing to the pages. So it appears to have been an oversight.
>
> Fix by allowing FOLL_FORCE to be set for get_user_pages_fast().
>
> Fixes: 817be129e6f2 ("mm: validate get_user_pages_fast flags")
> Cc: Christoph Hellwig
> Reviewed-by: Leon Romanovsky
>
ere we have reference on the inode it
> hangs off." [1]
>
> [1] https://lore.kernel.org/r/20190723153640.gb...@lst.de
>
> Cc: Jan Kara
> Signed-off-by: John Hubbard
> ---
> arch/powerpc/mm/book3s64/iommu_api.c | 12 +---
> 1 file changed, 5 insertions(+
rty(page);
> + put_user_pages_dirty_lock(&mem->hpages[i], 1,
> + MM_IOMMU_TABLE_GROUP_PAGE_DIRTY);
And the dirtying condition is wrong here as well. Currently it is always
true.
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu 21-11-19 18:54:02, John Hubbard wrote:
> On 11/21/19 1:54 AM, Jan Kara wrote:
> > On Thu 21-11-19 00:29:59, John Hubbard wrote:
> > > >
> > > > Otherwise this looks fine and might be a worthwhile cleanup to feed
> > > > Andrew
with), it would probably make sense to push also the
put_user_pages() -> unpin_user_pages() renaming so that that inconsistency
in naming does not exist in the released upstream kernel.
Honza
--
Jan Kara
SUSE Labs, CR
__
them as we do now because
ideally in 4 weeks we should have them ready with all the reviews so that
they can be picked up and integrated into linux-next.
Honza
--
Jan Kara
SUSE Labs, CR
___
ser_pages() (LPC: Dec 12, 2018):
> https://lwn.net/Articles/774411/
> [3] The trouble with get_user_pages() (Apr 30, 2018):
> https://lwn.net/Articles/753027/
>
> Suggested-by: Jan Kara
> Suggested-by: Jérôme Glisse
> Signed-off-by: Jo
igned-off-by: John Hubbard
Looks good to me. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> Documentation/core-api/pin_user_pages.rst | 2 +-
> arch/powerpc/mm/book3s64/iommu_api.c| 6 +--
> drivers/gpu/drm/vi
'd add a helper grab_page(page,
flags) doing
if (flags & FOLL_GET)
get_page(page);
else if (flags & FOLL_PIN)
return try_pin_page(page);
return true;
Otherwise the patch looks good to me now.
surrounded
> by get_page()/put_page().
>
> Also, further simplify (slightly), by waiting until the the successful
> end of each routine, to increment *nr.
>
> Reviewed-by: Jérôme Glisse
> Cc: Jan Kara
> Cc: Ira Weiny
> Cc: Christoph Hellwig
> Cc: Aneesh Kumar K.V
ewed-by: Ira Weiny
> Signed-off-by: John Hubbard
Looks good to me. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> drivers/infiniband/core/umem.c | 17 ++---
> 1 file changed, 6 insertions(+), 11 deletion
: Jérôme Glisse
> Reviewed-by: Ira Weiny
> Signed-off-by: John Hubbard
Looks good to me. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> drivers/platform/goldfish/goldfish_pipe.c | 18 +-
> 1 file ch
surrounded
> by get_page()/put_page().
>
> Also, further simplify (slightly), by waiting until the the successful
> end of each routine, to increment *nr.
>
> Reviewed-by: Jérôme Glisse
> Cc: Jan Kara
> Cc: Ira Weiny
> Cc: Christoph Hellwig
> Cc: Aneesh
153640.gb...@lst.de
>
> Reviewed-by: Ira Weiny
> Signed-off-by: John Hubbard
Looks good to me. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> drivers/platform/goldfish/goldfish_pipe.c | 17 +++-
> 1 file changed, 15 insertions(+), 13 deletions(-)
The patch looks good to me. You can add:
Reviewed-by: Jan Kara
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing l
user_pages() to pin_user_pages().
>
> Signed-off-by: John Hubbard
Looks good to me. You can add:
Reviewed-by: Jan Kara
Honza
> ---
> fs/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
ere usages which are transient.
^^^ when you touch this, please fix also the
second sentense. It doesn't quite make sense to me... I'd probably write
there "whose usages are transient" but maybe you can come up with something
even better.
Otherwise the patch looks good
is left to later
> patchsets. There is discussion about this in [1].
^^ missing this reference
in the changelog...
> This also changes a BUG_ON(), to a WARN_ON(), in follow_page_mask().
>
> Suggested-by: Jan Kara
> Suggested-by: Jé
> + SetPageReferenced(head);
> +}
I don't find this last helper very useful. It seems to muddy water more
than necessary...
Other than that the cleanup looks nice to me.
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue 12-11-19 20:26:50, John Hubbard wrote:
> An upcoming patch uses try_get_compound_head() more widely,
> so move it to the top of gup.c.
>
> Also fix a tiny spelling error and a checkpatch.pl warning.
>
> Signed-off-by: John Hubbard
Looks good. You can add:
Rev
ewed-by: Ira Weiny
> Cc: Kirill A. Shutemov
> Signed-off-by: John Hubbard
Looks good! You can add:
Reviewed-by: Jan Kara
Honza
> ---
> mm/gup.c | 28 ++--
> 1 file changed, 18 insertions(+
periments.
> Since then, Jérôme Glisse suggested the refactoring described above.
>
> Suggested-by: Jérôme Glisse
> Signed-off-by: Ira Weiny
> Signed-off-by: John Hubbard
Looks good to me. You can add:
Reviewed-by: Jan Kara
cs, should call a
> get_user_pages()-like wrapper call that sets FOLL_PIN. These wrappers
> will:
> * Start with "pin_user_pages" instead of "get_user_pages". That
> makes it easy to find and audit the call sites.
> * Set FOLL_PIN
>
hy I started off with a proposal that avoids changing the
> names of put_user_page*() APIs). But OTOH, the amount of churn is proportional
> to the change in direction here, and it's really only 10 or 20 lines changed,
> in the end.
>
> So I'm open to changing to that naming. It would be nice to hear what others
> prefer, too...
FWIW I'd find unpin_user_page() also better than put_user_page() as a
counterpart to pin_user_pages().
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
nce the address will not be used.
>> + * The virtual address is used in the transfer and the SPI core
>> + * re-maps it on the SPI master device using the DMA streaming API
>> + * (spi_map_buf()).
>> + */
>> +if (!dev->coheren
m now
> touching mm, procfs, rdma, ext4, and xfs.
MM tree would be one candidate for routing but there are other options that
would make sense as well - Dan's tree, VFS tree, or even I can pickup the
patches to my tree if needed. But let's worry about the routing after
like to say that the "imbalance" of get_user_pages()
> and put_page() bothers me from a purist standpoint... However, since this
> discussion cropped up I went ahead and ported my work to Linus' current master
> (5.3-rc3+) and in doing so I only had to steal a bit of Johns
On Fri 02-08-19 12:14:09, John Hubbard wrote:
> On 8/2/19 7:52 AM, Jan Kara wrote:
> > On Fri 02-08-19 07:24:43, Matthew Wilcox wrote:
> > > On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote:
> > > > On Fri 02-08-19 11:12:44, Michal Hocko wrote:
> > >
On Fri 02-08-19 07:24:43, Matthew Wilcox wrote:
> On Fri, Aug 02, 2019 at 02:41:46PM +0200, Jan Kara wrote:
> > On Fri 02-08-19 11:12:44, Michal Hocko wrote:
> > > On Thu 01-08-19 19:19:31, john.hubb...@gmail.com wrote:
> > > [...]
> > > > 2) Convert all of t
efs using
put_page()) but I suppose it would be a high enough barrier for missed
conversions... Thoughts?
Honza
--
Jan Kara
SUSE Labs, CR
___
dri-devel mailing list
dri-devel@lists.freed
On 7/31/19 1:49 AM, Emil Velikov wrote:
> On 2019/07/31, Jan Sebastian Götte wrote:
>> Hi Emil,
>>
>> thank you for your comments.
>>
>> On 7/30/19 11:08 PM, Emil Velikov wrote:
>>> On 2019/07/30, Jan Sebastian Götte wrote:
>>>> Signed-off-by
e gentle but please do point out all my mistakes :) I'm aware the dt
>> binding doc is still lacking.
>
> So the great and also somewhat tricky bit is that support code for
> tiny drivers is evolving really quick, so would be good if you can
> rebase onto drm-m
Hi Emil,
thank you for your comments.
On 7/30/19 11:08 PM, Emil Velikov wrote:
> On 2019/07/30, Jan Sebastian Götte wrote:
>> Signed-off-by: Jan Sebastian Götte
>> ---
>> include/uapi/drm/gdepaper_drm.h | 62 +
>> 1 file changed, 62 in
Signed-off-by: Jan Sebastian Götte
---
include/uapi/drm/gdepaper_drm.h | 62 +
1 file changed, 62 insertions(+)
create mode 100644 include/uapi/drm/gdepaper_drm.h
diff --git a/include/uapi/drm/gdepaper_drm.h b/include/uapi/drm/gdepaper_drm.h
new file mode 100644
nd refresh on fb
updates. By default this is disabled since careful LUT tuning is
required for this to not look terrible. Also not all content is suited
to this mode of operation.
Tested-by: Jan Sebastian Götte
Signed-off-by: Jan Sebastian Götte
---
drivers/gpu/drm/tinydrm/gdepaper.c
Signed-off-by: Jan Sebastian Götte
---
.../devicetree/bindings/display/gdepaper.txt | 27 +++
1 file changed, 27 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/gdepaper.txt
diff --git a/Documentation/devicetree/bindings/display/gdepaper.txt
b
Signed-off-by: Jan Sebastian Götte
---
include/dt-bindings/display/gdepaper.h | 28 ++
1 file changed, 28 insertions(+)
create mode 100644 include/dt-bindings/display/gdepaper.h
diff --git a/include/dt-bindings/display/gdepaper.h
b/include/dt-bindings/display
Dalian Good Display Co., Ltd. among others makes three-color epaper
panels.
Signed-off-by: Jan Sebastian Götte
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation
Signed-off-by: Jan Sebastian Götte
---
drivers/gpu/drm/tinydrm/Kconfig | 10 ++
drivers/gpu/drm/tinydrm/Makefile | 1 +
2 files changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig
index 87819c82bcce..427d1e62e63d 100644
--- a
1 - 100 of 361 matches
Mail list logo
