Hi Keith,
There is a problem with stopping when changing modes.
Below test log
root:~> modetest -Mstarfive -c
Connectors:
id encoder status namesize (mm) modes
encoders
116 115 connected HDMI-A-1320x180 51 115
modes:
in
Could you please check this patch.
Best regards
Hoegeun
> -Original Message-
> From: dri-devel On Behalf Of
> Hoegeun Kwon
> Sent: Monday, January 16, 2023 6:44 PM
> To: dri-devel@lists.freedesktop.org; hoegeun.k...@samsung.com
> Subject: [PATCH libdrm] vbltest: add
Add option to use high pipe.
Signed-off-by: Hoegeun Kwon
---
tests/vbltest/vbltest.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/tests/vbltest/vbltest.c b/tests/vbltest/vbltest.c
index 1c2b519eec4a..1be77b81c560 100644
--- a/tests/vbltest/vbltest.c
rtc: Assign output to channel automatically")
> Signed-off-by: Maxime Ripard
I checked all patches well works.
All patches:
Reviewed-by: Hoegeun Kwon
Tested-by: Hoegeun Kwon
Best regards,
Hoegeun
> ---
> drivers/gpu/drm/vc4/vc4_drv.h | 1 +-
> drivers/gpu/drm/vc4/vc4
Hi Maxime,
Thanks for V2 patch.
On 10/28/20 9:41 PM, Maxime Ripard wrote:
> The current HVS muxing code will consider the CRTCs in a given state to
> setup their muxing in the HVS, and disable the other CRTCs muxes.
>
> However, it's valid to only update a single CRTC with a state, and in this
>
lt;41d69f98>] try_to_bring_up_master+0x180/0x1e8
[<d1e1caae>] component_master_add_with_match+0xbc/0x108
[<85cea46d>] vc4_platform_drm_probe+0xd8/0x108
[<eacabf20>] platform_drv_probe+0x58/0xa8
[<3822d094>] really_probe+0x10c/0x350
Best regards,
There is a problem that if vc4_drm bind fails, a memory leak occurs on
the drm_property_create side. Add error handding for drm_mode_config.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers
rks.
All patches:
Reviewed-by: Hoegeun Kwon
Tested-by: Hoegeun Kwon
Best regards,
Hoegeun
> ---
> drivers/gpu/drm/vc4/vc4_kms.c | 18 +++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc
Hi Maxime,
On 9/18/20 11:59 PM, Maxime Ripard wrote:
> The HVS has three FIFOs that can be assigned to a number of PixelValves
> through a mux.
>
> However, changing that FIFO requires that we disable and then enable the
> pixelvalve, so we want to assign FIFOs to all the enabled CRTCs, and not
>
re kept running
> unmodified, and will thus unassign its associated FIFO, and later disable
> it.
>
> In order to make the code work as expected, let's pull the CRTC state of
> all the enabled CRTC in our atomic_check so that we can operate on all the
> running CRTCs, no mat
Hi Maxime,
On 9/8/20 9:00 PM, Maxime Ripard wrote:
> Hi Hoegeun,
>
> On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote:
>> On 9/3/20 5:00 PM, Maxime Ripard wrote:
>>> Hi everyone,
>>>
>>> Here's a (pretty long) series to introduce su
ave Stevenson
> Tested-by: Chanwoo Choi
> Tested-by: Hoegeun Kwon
> Tested-by: Stefan Wahren
> Signed-off-by: Maxime Ripard
Thanks for your v5 patch
Reviewed-by: Hoegeun Kwon
Best regards,
Hoegeun
> ---
> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 48 +++-
>
Choi
> Tested-by: Hoegeun Kwon
> Tested-by: Stefan Wahren
> Signed-off-by: Maxime Ripard
Thanks for your v5 patch
Reviewed-by: Hoegeun Kwon
Best regards,
Hoegeun
> ---
> Documentation/devicetree/bindings/dis
Hi Maxime,
On 9/3/20 5:00 PM, Maxime Ripard wrote:
> Hi everyone,
>
> Here's a (pretty long) series to introduce support in the VC4 DRM driver
> for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4).
>
> The main differences are that there's two HDMI controllers and that there
Hi Chanwoo,
On 9/1/20 1:27 PM, Chanwoo Choi wrote:
> Hi Hoegeun,
>
> It looks good to me. But, just one comment.
>
> On 9/1/20 1:07 PM, Hoegeun Kwon wrote:
>> There is a problem that the output does not work at a resolution
>> exceeding FHD. To solve this, we need t
There is a problem that the output does not work at a resolution
exceeding FHD. To solve this, we need to adjust the bvb clock at a
resolution exceeding FHD.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 25 +
drivers/gpu/drm/vc4/vc4_hdmi.h | 1 +
2
When using a resolution exceeding FHD, bvb clock is required.
Add bvb clock-names property.
Signed-off-by: Hoegeun Kwon
---
.../bindings/display/brcm,bcm2711-hdmi.yaml | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings
x27;s
patchset)
Changes from v1:
- Added dt-bindings documents
- Change patch order, first fix driver and then device tree
Hoegeun Kwon (4):
clk: bcm: rpi: Add register to control pixel bvb clk
drm/vc4: hdmi: Add pixel bvb clock control
dt-bindings: display: vc4: hdmi: Add bvb clock-names pro
To use QHD or higher, we need to modify the pixel_bvb_clk value. So
add register to control this clock.
Signed-off-by: Hoegeun Kwon
---
drivers/clk/bcm/clk-raspberrypi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c
b/drivers/clk/bcm/clk-raspberrypi.c
It is necessary to control the hdmi pixel bvb clock. Add bvb clock.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
Am 28.08.20 um 08:30 schrieb Hoegeun Kwon:
>>>> On 8/27/20 6:49 PM, Stefan Wahren wrote:
>>>>> Am 27.08.20 um 06:35 schrieb Hoegeun Kwon:
>>>>>> Hi Stefan,
>>>>>>
>>>>>> Thank you for your review.
>>>>>&g
On 8/27/20 6:49 PM, Stefan Wahren wrote:
> Am 27.08.20 um 06:35 schrieb Hoegeun Kwon:
>> Hi Stefan,
>>
>> Thank you for your review.
>>
>>
>> On 8/26/20 7:04 PM, Stefan Wahren wrote:
>>> Hi Hoeguen,
>>>
>>> Am 21.08.20 um 09:10 schr
Hi Stefan,
Thank you for your review.
On 8/26/20 7:04 PM, Stefan Wahren wrote:
> Hi Hoeguen,
>
> Am 21.08.20 um 09:10 schrieb Hoegeun Kwon:
>> There is a problem that the output does not work at a resolution
>> exceeding FHD. To solve this, we need to adjust the bvb clo
H not outputting...
So this problem worked as I fixed it like patches[1].
[1] [PATCH 0/3] drm/vc4: Support HDMI QHD or higher output
"[PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline" all patches.
Tested-by: Hoegeun Kwon
Best regards,
Hoegeun
> Hi everyone,
>
> Here
It is necessary to control the hdmi pixel bvb clock. Add bvb clock.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
To use QHD or higher, we need to modify the pixel_bvb_clk value. So
add register to control this clock.
Signed-off-by: Hoegeun Kwon
---
drivers/clk/bcm/clk-raspberrypi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c
b/drivers/clk/bcm/clk-raspberrypi.c
There is a problem that the output does not work at a resolution
exceeding FHD. To solve this, we need to adjust the bvb clock at a
resolution exceeding FHD.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 25 +
drivers/gpu/drm/vc4/vc4_hdmi.h | 1 +
2
x27;s
patchset)
Hoegeun Kwon (3):
clk: bcm: rpi: Add register to control pixel bvb clk
ARM: dts: bcm2711: Add bvb clock for hdmi-pixel
drm/vc4: hdmi: Add pixel bvb clock control
arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 --
drivers/clk/bcm/clk-raspberrypi.c | 1 +
drivers/gpu/dr
On 4/10/19 1:24 AM, Eric Anholt wrote:
> Hoegeun Kwon writes:
>
>> On 4/2/19 2:48 AM, Eric Anholt wrote:
>>> Hoegeun Kwon writes:
>>>
>>>> There is a problem when often dpms goes from off to on. pm idle is not
>>>> in sync and the problem o
On 4/2/19 2:48 AM, Eric Anholt wrote:
> Hoegeun Kwon writes:
>
>> There is a problem when often dpms goes from off to on. pm idle is not
>> in sync and the problem occurs. Modify pm_runtime_put from
>> asynchronous to synchronous.
> Why would we need the power domain to
There is a problem when often dpms goes from off to on. pm idle is not
in sync and the problem occurs. Modify pm_runtime_put from
asynchronous to synchronous.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/vc4/vc4_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On 1/17/19 9:15 PM, Daniel Vetter wrote:
> On Thu, Jan 17, 2019 at 10:57 AM Hoegeun Kwon
> wrote:
>>
>> On 1/17/19 6:20 PM, Daniel Vetter wrote:
>>> On Thu, Jan 17, 2019 at 05:50:44PM +0900, Hoegeun Kwon wrote:
>>>> There is a problem in crtc_helper that
On 1/17/19 6:20 PM, Daniel Vetter wrote:
> On Thu, Jan 17, 2019 at 05:50:44PM +0900, Hoegeun Kwon wrote:
>> There is a problem in crtc_helper that property value is not updated
>> when dpms is turned on or off. So modify the property value when dpms
>> is on.
>>
>
There is a problem in crtc_helper that property value is not updated
when dpms is turned on or off. So modify the property value when dpms
is on.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/drm_crtc_helper.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm
. Stateless nature of DRM_IOCTL_EXYNOS_IPP_COMMIT ioctl simplifies
the driver API. Minimal driver needs to provide a single callback for
starting processing and an array with supported image formats.
Signed-off-by: Marek Szyprowski
Tested-by: Hoegeun Kwon
---
drivers/gpu/drm/exynos/Kconfig
Hi Marek,
On 09/29/2017 04:32 PM, Marek Szyprowski wrote:
This patch adapts Exynos DRM rotator driver to new IPP v2 core API.
The side effect of this conversion is a switch to driver component API
to register properly in the Exynos DRM core.
Signed-off-by: Marek Szyprowski
Tested-by: Hoegeun
Hi Marek,
Tested-by: Hoegeun Kwon
Best regards,
Hoegeun
On 09/12/2017 05:08 PM, Marek Szyprowski wrote:
This patch adds Exynos IPP v2 subsystem and userspace API.
New userspace API is focused ONLY on memory-to-memory image processing.
The two remainging IPP operation modes (framebuffer
Hi Marek,
Tested-by: Hoegeun Kwon
Best regards,
Hoegeun
On 09/12/2017 05:08 PM, Marek Szyprowski wrote:
Exynos IPP will be rewritten, so remove current IPP core code and mark
existing drivers as BROKEN.
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/Kconfig | 11
Hi Marek,
Tested-by: Hoegeun Kwon
Best regards,
Hoegeun
On 09/12/2017 05:08 PM, Marek Szyprowski wrote:
This patch adapts Exynos DRM rotator driver to new IPP v2 core API.
The side effect of this conversion is a switch to driver component API
to register properly in the Exynos DRM core
The display-timing and delay are included in the panel driver. So it
should be removed in dts.
Signed-off-by: Hoegeun Kwon
---
Hi Krzysztof,
This patch was rebased to the mainline (v4.14-rc1).
Best regards,
Hoegeun
arch/arm/boot/dts/exynos3250-rinato.dts | 22 --
1
On 09/13/2017 09:13 PM, Sylwester Nawrocki wrote:
On 09/13/2017 01:41 PM, Hoegeun Kwon wrote:
@@ -1004,11 +1088,33 @@ static irqreturn_t gsc_irq_handler(int irq,
void *priv)
.num_clocks = 1,
};
+static struct gsc_driverdata gsc_v_5250_drvdata = {
+.variant = {
+[0
driver.
Best regards,
Hoegeun
Hoegeun Kwon (4):
[media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific
version
ARM: dts: exynos: Add clean name of compatible.
drm/exynos/gsc: Add hardware rotation limits
[media] exynos-gsc: Add hardware rotation limits
.../devicetree/
The hardware rotation limits of gsc depends on SOC (Exynos
5250/5420/5433). Distinguish them and add them to the driver data.
Signed-off-by: Hoegeun Kwon
---
drivers/media/platform/exynos-gsc/gsc-core.c | 127 +--
1 file changed, 122 insertions(+), 5 deletions(-)
diff
related to pos size, use pos size to check
the limits.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 104 +++-
include/uapi/drm/exynos_drm.h | 2 +
2 files changed, 77 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/exynos
Exynos 5250 and 5420 have different hardware rotation limits.
Since we have to distinguish between these two, we add different
compatible(samsung,exynos5250-gsc and samsung,exynos5420-gsc).
Signed-off-by: Hoegeun Kwon
---
Documentation/devicetree/bindings/media/exynos5-gsc.txt | 9 ++---
1
Exynos 5250 and 5420 have different hardware rotation limits. However,
currently it uses only one compatible - "exynos5-gsc". Since we have
to distinguish between these two, we add different compatible.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos5250.dtsi | 8
On 09/13/2017 06:11 PM, Sylwester Nawrocki wrote:
Hi Hoegeun,
On 09/13/2017 04:33 AM, Hoegeun Kwon wrote:
@@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq,
void *priv)
static const struct of_device_id exynos_gsc_match[] = {
{
-.compatible = "sa
Hi Sylwester,
On 09/11/2017 06:35 PM, Sylwester Nawrocki wrote:
On 09/08/2017 08:02 AM, Hoegeun Kwon wrote:
The hardware rotation limits of gsc depends on SOC (Exynos
5250/5420/5433). Distinguish them and add them to the driver data.
Signed-off-by: Hoegeun Kwon
---
drivers/media/platform
system]
url:
https://github.com/0day-ci/linux/commits/Hoegeun-Kwon/drm-exynos-gsc-Support-the-hardware-rotation-limits/20170910-015155
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-at91_dt_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc
Currently, the compatible('samsung,exynos5-gsc') is not used.
Remove unnecessary compatible.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos5250.dtsi | 8
arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arc
Currently, the compatible('samsung,exynos5-gsc') is not used.
Remove unnecessary compatible.
Signed-off-by: Hoegeun Kwon
---
Documentation/devicetree/bindings/media/exynos5-gsc.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetre
Exynos 5250 and 5420 have different hardware rotation limits.
Since we have to distinguish between these two, we add different
compatible(samsung,exynos5250-gsc and samsung,exynos5420-gsc).
Signed-off-by: Hoegeun Kwon
---
Documentation/devicetree/bindings/media/exynos5-gsc.txt | 1 +
1 file
driver.
Best regards,
Hoegeun
Hoegeun Kwon (6):
[media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific
version
ARM: dts: exynos: Add clean name of compatible.
drm/exynos/gsc: Add hardware rotation limits
[media] exynos-gsc: Add hardware rotation limits
[media] exynos-gsc
Exynos 5250 and 5420 have different hardware rotation limits. However,
currently it uses only one compatible - "exynos5-gsc". Since we have
to distinguish between these two, we add different compatible.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos5250.dtsi | 8
related to pos size, use pos size to check
the limits.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 93 +++--
include/uapi/drm/exynos_drm.h | 2 +
2 files changed, 66 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/exynos
The hardware rotation limits of gsc depends on SOC (Exynos
5250/5420/5433). Distinguish them and add them to the driver data.
Signed-off-by: Hoegeun Kwon
---
drivers/media/platform/exynos-gsc/gsc-core.c | 96
1 file changed, 83 insertions(+), 13 deletions(-)
diff
On 09/07/2017 08:27 PM, Marek Szyprowski wrote:
Hi Hoegeun,
On 2017-09-07 11:39, Hoegeun Kwon wrote:
Exynos 5250 and 5420 have different hardware rotation limits. However,
currently it uses only one compatible - "exynos5-gsc". Since we have
to distinguish between these two, we add
On 09/07/2017 08:25 PM, Marek Szyprowski wrote:
Hi Hoegeun,
On 2017-09-07 07:16, Hoegeun Kwon wrote:
On 09/04/2017 03:19 PM, Hoegeun Kwon wrote:
On 09/01/2017 04:31 PM, Marek Szyprowski wrote:
Hi Hoegeun,
On 2017-09-01 03:47, Hoegeun Kwon wrote:
The gscaler has hardware rotation limits that
Exynos 5250 and 5420 have different hardware rotation limits.
Since we have to distinguish between these two, we add different
compatible(samsung,exynos5250-gsc and samsung,exynos5420-gsc).
Signed-off-by: Hoegeun Kwon
---
Documentation/devicetree/bindings/media/exynos5-gsc.txt | 1 +
1 file
regards,
Hoegeun
Hoegeun Kwon (3):
[media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific
version
ARM: dts: exynos: Add clean name of compatible.
drm/exynos/gsc: Add hardware rotation limits
.../devicetree/bindings/media/exynos5-gsc.txt | 1 +
arch/arm/boot/dts
Exynos 5250 and 5420 have different hardware rotation limits. However,
currently it uses only one compatible - "exynos5-gsc". Since we have
to distinguish between these two, we add different compatible.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos5250.dtsi | 8
related to pos size, use pos size to check
the limits.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 100 +++-
include/uapi/drm/exynos_drm.h | 2 +
2 files changed, 73 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/exynos
On 09/04/2017 03:19 PM, Hoegeun Kwon wrote:
On 09/01/2017 04:31 PM, Marek Szyprowski wrote:
Hi Hoegeun,
On 2017-09-01 03:47, Hoegeun Kwon wrote:
The gscaler has hardware rotation limits that need to be imported from
dts. Parse them and add them to the property list.
The rotation hardware
On 09/04/2017 04:36 PM, Daniel Vetter wrote:
On Fri, Sep 01, 2017 at 04:36:25PM +0300, Ville Syrjälä wrote:
On Fri, Sep 01, 2017 at 04:07:16PM +0900, Hoegeun Kwon wrote:
If scanout started, we should reduce etime by delta_ns. But delta_ns
is negative if scanout has not started. If delta_ns is
On 09/01/2017 04:31 PM, Marek Szyprowski wrote:
Hi Hoegeun,
On 2017-09-01 03:47, Hoegeun Kwon wrote:
The gscaler has hardware rotation limits that need to be imported from
dts. Parse them and add them to the property list.
The rotation hardware limits are related to the cropped source size
: Hoegeun Kwon
---
Hello all,
I think that the etime should not be increased.
In cases where delta_ns is negative, if you get time again after an
interrupt call, there is a problem that the time obtained from the
interrupt becomes the future time instead of the past time.
Please let me know if
Hello all,
The gscaler has hardware rotation limits. So this patch set support
the rotate hardware limits of gsc.
Best regards,
Hoegeun
Hoegeun Kwon (3):
ARM: dts: exynos: Add the hardware rotation limits for gsc
arm64: dts: exynos: Add the hardware rotation limits for gsc
drm/exynos/gsc
size, use pos size to
check the limits.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 63 +
include/uapi/drm/exynos_drm.h | 2 ++
2 files changed, 42 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/exynos
The gscaler has maximum size of input or output rotation. Add the
hardware limits property for the gscaler rotation in the exynos5250
and exynos5420 dts.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos5250.dtsi | 8
arch/arm/boot/dts/exynos5420.dtsi | 4
2 files changed
The gscaler has maximum size of input or output rotation. Add the
hardware limits property for the gscaler rotation in the exynos5433
dts.
Signed-off-by: Hoegeun Kwon
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts
Hi Krzysztof,
The driver has been merged into exynos-drm-misc.
Could you please check this patch(3/3).
Best regards,
Hoegeun
On 07/13/2017 11:20 AM, Hoegeun Kwon wrote:
The display-timing and delay are included in the panel driver. So it
should be removed in dts.
Signed-off-by: Hoegeun Kwon
Dear Thierry,
Could you please check these patches.
Best regards,
Hoegeun
On 07/13/2017 11:20 AM, Hoegeun Kwon wrote:
Hi Andrzej,
Thank you for your review.
The purpose of this patch is add support for s6e63j0x03 AMOLED panel
on the rinato board(Samsung Galaxy Gear 2).
Changes for V4
ff-by: Hoegeun Kwon
Reviewed-by: Andrzej Hajda
---
drivers/gpu/drm/panel/Kconfig| 7 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 532 +++
3 files changed, 540 insertions(+)
create mode 100644 dr
The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using
MIPI-DSI interfaces.
Signed-off-by: Hoegeun Kwon
Reviewed-by: Andrzej Hajda
Acked-by: Rob Herring
---
.../bindings/display/panel/samsung,s6e63j0x03.txt | 24 ++
1 file changed, 24 insertions(+)
c
Andrzej Hajda (1/3 patch).
- Added Acked-by: Rob Herring (1/3 patch).
- Fixed the tristate of config from video mode to command mode.
- Fixed the reset gpios from active high to low from rinato dts.
- Fixed a lot of things in panel driver, reflect Andrzej's review.
Best regards,
Hoegeun
Hoegeu
The display-timing and delay are included in the panel driver. So it
should be removed in dts.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos3250-rinato.dts | 22 --
1 file changed, 22 deletions(-)
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts
b/arch/arm
Hi Andrzej,
Could you please check this patch?
Best regards,
Hoegeun
On 06/27/2017 11:11 AM, Hoegeun Kwon wrote:
This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver
which uses mipi_dsi bus to communicate with panel. The panel has
320×320 resolution in 1.63" physical panel.
Hajda
Reviewed-by: Andrzej Hajda
Signed-off-by: Inki Dae
Reviewed-by: Hoegeun Kwon
Best regards,
Hoegeun
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Inki,
Could you check this patch? :D
Best regards,
Hoegeun
On 06/21/2017 07:51 PM, Hoegeun Kwon wrote:
Remove the error handling of bridge_node because the bridge_node is
optional.
For example, In case of Exynos SoC, a bridge device such as mDNIe and
MIC could be placed between Display
On 07/03/2017 04:27 PM, Inki Dae wrote:
This patch moves drm_bridge_add call into probe.
This change is required by DSI driver so that
the brige can be bound at DSI driver's probe.
Suggested-by: Andrzej Hajda
Signed-off-by: Inki Dae
Reviewed-by: Hoegeun Kwon
Best regards,
Ho
The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using
MIPI-DSI interfaces.
Signed-off-by: Hoegeun Kwon
Reviewed-by: Andrzej Hajda
Acked-by: Rob Herring
---
.../bindings/display/panel/samsung,s6e63j0x03.txt | 24 ++
1 file changed, 24 insertions(+)
c
The display-timing and delay are included in the panel driver. So it
should be removed in dts.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos3250-rinato.dts | 22 --
1 file changed, 22 deletions(-)
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts
b/arch/arm
ff-by: Hoegeun Kwon
---
drivers/gpu/drm/panel/Kconfig| 7 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 540 +++
3 files changed, 548 insertions(+)
create mode 100644 drivers/gpu/drm/panel/panel-sa
e.
- Fixed the reset gpios from active high to low from rinato dts.
- Fixed a lot of things in panel driver, reflect Andrzej's review.
Best regards,
Hoegeun
Hoegeun Kwon (3):
dt-bindings: Add support for samsung s6e63j0x03 panel binding
drm/panel: Add support for s6e63j0x03 panel driver
ARM
Remove the error handling of bridge_node because the bridge_node is
optional.
For example, In case of Exynos SoC, a bridge device such as mDNIe and
MIC could be placed between Display Controller and MIPI DSI device but
the bridge device is optional.
Signed-off-by: Hoegeun Kwon
---
Hi all
Remove the error handling of bridge_node because the bridge_node is
optionally.
For example, In case of Exynos SoC, a bridge device such as mDNIe and
MIC could be placed between Display Controller and MIPI DSI device but
the bridge device is optionally.
Signed-off-by: Hoegeun Kwon
---
Hi all
Hello Tobias,
Sorry for late reply.
On 06/14/2017 09:30 PM, Tobias Jakobi wrote:
Hello Hoegeun,
my last question (does this regress the case "node required, but
absent") still stands.
Hoegeun Kwon wrote:
Remove the error handling of bridge_node because the bridge_node i
On 06/19/2017 06:14 PM, Andrzej Hajda wrote:
On 15.06.2017 12:03, Hoegeun Kwon wrote:
This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver
which uses mipi_dsi bus to communicate with panel. The panel has
320×320 resolution in 1.63" physical panel. This panel is used in
Sa
The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using
MIPI-DSI interfaces.
Signed-off-by: Hoegeun Kwon
Reviewed-by: Andrzej Hajda
Acked-by: Rob Herring
---
.../bindings/display/panel/samsung,s6e63j0x03.txt | 24 ++
1 file changed, 24 insertions(+)
c
ff-by: Hoegeun Kwon
---
drivers/gpu/drm/panel/Kconfig| 7 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c | 476 +++
3 files changed, 484 insertions(+)
create mode 100644 drivers/gpu/drm/panel/panel-sa
The display-timing and delay are included in the panel driver. So it
should be removed in dts.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos3250-rinato.dts | 22 --
1 file changed, 22 deletions(-)
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts
b/arch/arm
tristate of config from video mode to command mode.
- Fixed the reset gpios from active high to low from rinato dts.
- Fixed a lot of things in panel driver, reflect Andrzej's review.
Best regards,
Hoegeun
Hoegeun Kwon (4):
dt-bindings: Add support for samsung s6e63j0x03 panel binding
drm/panel
This reset gpios is active low, therefore fix from active high to low.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos3250-rinato.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts
b/arch/arm/boot/dts/exynos3250-rinato.dts
Hi Andrzej,
Thanks for your review.
On 06/12/2017 10:16 PM, Andrzej Hajda wrote:
Hi Hoegeun,
Nice to see patches completing support for mainlined platforms.
On 09.06.2017 06:59, Hoegeun Kwon wrote:
This patch adds MIPI-DSI based S6E63J0X03 AMOLED LCD panel driver
which uses mipi_dsi bus to
Remove the error handling of bridge_node because the bridge_node is
required optionally.
For example, In case of Exynos SoC, a bridge device such as mDNIe and
MIC could be placed between Display Controller and MIPI DSI device but
the bridge device is required optionally.
Signed-off-by: Hoegeun
On 06/13/2017 06:25 PM, Inki Dae wrote:
2017년 06월 09일 18:23에 Hoegeun Kwon 이(가) 쓴 글:
The bridge_node is unnecessary between FIMD and DSIM. If don't remove
error handling, it will not work between FIMD and DSIM. So remove
error handling.
Please make sure to describe why bridge_no
The bridge_node is unnecessary between FIMD and DSIM. If don't remove
error handling, it will not work between FIMD and DSIM. So remove
error handling.
Signed-off-by: Hoegeun Kwon
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gp
On 06/09/2017 04:45 PM, Krzysztof Kozlowski wrote:
On Fri, Jun 09, 2017 at 01:59:14PM +0900, Hoegeun Kwon wrote:
The display-timing and delay are included in the panel driver. So it
should be removed in dts.
Signed-off-by: Hoegeun Kwon
---
arch/arm/boot/dts/exynos3250-rinato.dts | 22
On 06/09/2017 04:27 PM, Krzysztof Kozlowski wrote:
On Fri, Jun 09, 2017 at 11:59:33AM +0900, Hoegeun Kwon wrote:
It should be connected to OF graph between fimd and dsi.
Add the OF graph between fimd and dsi.
I need more explanation why this is needed. What happens without this?
What issue is
The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using
MIPI-DSI interfaces.
Signed-off-by: Hoegeun Kwon
---
.../bindings/display/panel/samsung,s6e63j0x03.txt | 24 ++
1 file changed, 24 insertions(+)
create mode 100644
Documentation/devicetree/bin
1 - 100 of 233 matches
Mail list logo
