Re: [PATCH v4 04/13] media: saa7115: Replace open-coded parity calculation with parity_odd()

2025-04-25 Thread Hans Verkuil
On 09/04/2025 17:43, Kuan-Wei Chiu wrote: > Refactor parity calculations to use the standard parity_odd() helper. > This change eliminates redundant implementations. > > Co-developed-by: Yu-Chun Lin > Signed-off-by: Yu-Chun Lin > Signed-off-by: Kuan-Wei Chiu Reviewe

Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()

2025-04-25 Thread Hans Verkuil
); >>> + err = !parity_odd(p[0]) || !parity_odd(p[1]); >> >> No need to call parity_odd() twice here. Instead you could do: >> >> err = !parity_odd(p[0] ^ p[1]); I prefer the original approach, it is easier to understand. Performance is not an i

Re: [PATCH v4 02/13] media: media/test_drivers: Replace open-coded parity calculation with parity_odd()

2025-04-25 Thread Hans Verkuil
On 09/04/2025 17:43, Kuan-Wei Chiu wrote: > Refactor parity calculations to use the standard parity_odd() helper. > This change eliminates redundant implementations. > > Co-developed-by: Yu-Chun Lin > Signed-off-by: Yu-Chun Lin > Signed-off-by: Kuan-Wei Chiu Reviewe

Re: linux-next: Tree for Mar 26 (drivers/media/cec/i2c/tda9950)

2025-03-27 Thread Hans Verkuil
On 27/03/2025 01:22, Randy Dunlap wrote: > > > On 3/25/25 10:56 PM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20250325: >> > > on x86_64, when CONFIG_I2C=m and > CONFIG_CEC_NXP_TDA9950=y: > > ld: vmlinux.o: in function `tda9950_write_range': > tda9950.c:(.text+0x1225126): undefined

Re: [PATCH v2 2/2] drm/display: hdmi: Mention Infoframes testing with edid-decode

2025-03-13 Thread Hans Verkuil
rs (and helpers) behave > properly. > > Let's document it. > > Cc: Hans Verkuil Reviewed-by: Hans Verkuil Thanks! Hans > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 271 > > 1

Re: [PATCH 2/2] drm/display: hdmi: Mention Infoframes testing with edid-decode

2025-03-07 Thread Hans Verkuil
hat the drivers (and helpers) behave > properly. > > Let's document it. > > Cc: Hans Verkuil > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/display/drm_hdmi_state_helper.c | 240 > > 1 file changed, 240 inser

Re: [PATCH v5 04/12] driver core: Constify API device_find_child() and adapt for various usages

2025-02-20 Thread Hans Verkuil
pter *get_i2c_adap(struct > platform_device *pdev) > return dev ? to_i2c_adapter(dev) : NULL; > } > > -static int match_spi_adap(struct device *dev, void *data) > +static int match_spi_adap(struct device *dev, const void *data) > { > return to_spi_device(dev) ? 1 : 0; > } Reviewed-by: Hans Verkuil Regards, Hans

Re: [PATCH] gpu: drm_dp_cec: fix broken CEC adapter properties check

2025-01-31 Thread Hans Verkuil
On 29/01/2025 13:21, Hans Verkuil wrote: > On 29/01/2025 10:51, Hans Verkuil wrote: >> If the hotplug detect of a display is low for longer than one second >> (configurable through drm_dp_cec_unregister_delay), then the CEC adapter >> is unregistered since we assume the dis

Re: [PATCH] gpu: drm_dp_cec: fix broken CEC adapter properties check

2025-01-29 Thread Hans Verkuil
On 29/01/2025 10:51, Hans Verkuil wrote: > If the hotplug detect of a display is low for longer than one second > (configurable through drm_dp_cec_unregister_delay), then the CEC adapter > is unregistered since we assume the display was disconnected. If the > HPD went low for less tha

[PATCH] gpu: drm_dp_cec: fix broken CEC adapter properties check

2025-01-29 Thread Hans Verkuil
dropped as well, so that's a nice cleanup. Signed-off-by: Hans Verkuil Reported-by: Farblos --- Jens (aka Farblos), can you test this patch? --- drivers/gpu/drm/display/drm_dp_cec.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/di

Re: [PATCH v2 0/3] drm/i2c: tda998x: move under drivers/gpu/drm/bridge

2025-01-10 Thread Hans Verkuil
On 10/01/2025 13:31, Dmitry Baryshkov wrote: > TDA998x is the HDMI bridge driver, incorporating drm_connector and > optional drm_encoder (created via the component bind API by the TICLDC > and HDLCD drivers). TDA9950 is an I2C-CEC translator, being present > on-die on the TDA9989 and TDA19989 chips

Re: [PATCH v2 3/3] drm/i2c: move TDA drivers under drivers/gpu/drm/bridge

2025-01-10 Thread Hans Verkuil
On 10/01/2025 13:31, Dmitry Baryshkov wrote: > TDA998x is the HDMI bridge driver, incorporating drm_connector and > optional drm_encoder (created via the component bind API by the TICLDC > and HDLCD drivers). Thus it should be residing together with the other > DRM bridge drivers under drivers/gpu/

Re: [PATCH v2 2/3] media: cec: move driver for TDA9950 from drm/i2c

2025-01-10 Thread Hans Verkuil
me has been changed to follow media/cec style. > > Signed-off-by: Dmitry Baryshkov Acked-by: Hans Verkuil Regards, Hans > --- > drivers/gpu/drm/i2c/Kconfig | 5 - > drivers/gpu/drm/i2c/Makefile | 1 - > drivers/

Re: [PATCH 2/2] drm/i2c: move TDA drivers under drivers/gpu/drm/bridge

2025-01-06 Thread Hans Verkuil
On 06/01/2025 00:20, Laurent Pinchart wrote: > (CC'ing Hans Verkuil) > > On Mon, Jan 06, 2025 at 12:52:55AM +0200, Dmitry Baryshkov wrote: >> On Sun, Dec 15, 2024 at 02:38:05PM +0200, Laurent Pinchart wrote: >>> Hi Dmitry, >>> >>> Thank you for t

Re: [PATCH v2] media: cec: include linux/debugfs.h and linux/seq_file.h where needed

2024-12-31 Thread Hans Verkuil
include debugfs.h and >> seq_file.h where needed. >> >> Sort all the modified include lists while at it. >> >> Cc: Hans Verkuil >> Cc: linux-me...@vger.kernel.org >> Signed-off-by: Jani Nikula > > Ping? I plan to pick it up next week, when I'm back

Re: [PATCH] media: cec: include linux/debugfs.h and linux/seq_file.h where needed

2024-12-05 Thread Hans Verkuil
On 05/12/2024 14:20, Jani Nikula wrote: > On Fri, 29 Nov 2024, Hans Verkuil wrote: >> On 29/11/2024 09:24, Jani Nikula wrote: >>> On Wed, 27 Nov 2024, Jani Nikula wrote: >>>> Cc: Hans Verkuil >> >> That email no longer exists. Just use hverk...@xs4all

Re: [PATCH] media: cec: include linux/debugfs.h and linux/seq_file.h where needed

2024-11-29 Thread Hans Verkuil
include debugfs.h and >> seq_file.h where needed. >> >> Sort all the modified include lists while at it. >> >> Cc: Hans Verkuil That email no longer exists. Just use hverk...@xs4all.nl or hansv...@cisco.com, either works, but I prefer my private email. Regards, Han

Re: [PATCH RESEND v2 05/19] media: vivid: Include in vivid-vid-cap.c

2024-09-09 Thread Hans Verkuil
On 09/09/2024 09:53, Uros Bizjak wrote: > Substitute the inclusion of header with > to allow the removal of legacy inclusion > of from . > > Signed-off-by: Uros Bizjak Acked-by: Hans Verkuil Regards, Hans > Cc: Hans Verkuil > Cc: Mauro Carvalho C

Re: [Letux-kernel] [PATCHv2 0/6] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5

2024-08-29 Thread Hans Verkuil
On 28/08/2024 21:41, H. Nikolaus Schaller wrote: > Hi all, > >> Am 28.08.2024 um 16:14 schrieb Hans Verkuil : >> >> On 28/08/2024 15:57, Tomi Valkeinen wrote: >>> Hi, >>> >>> On 25/08/2024 23:31, H. Nikolaus Schaller wrote: >>>>

Re: [PATCH 2/7] media: v4l2-core: add v4l2_debugfs_if_alloc/free()

2024-08-28 Thread Hans Verkuil
On 28/08/2024 17:08, Jani Nikula wrote: > On Wed, 28 Aug 2024, Hans Verkuil wrote: >> Add new helpers to export received or transmitted HDMI InfoFrames to >> debugfs. >> >> This complements similar code in drm where the transmitted HDMI infoframes >> are exported

Re: [PATCHv2 0/6] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5

2024-08-28 Thread Hans Verkuil
Hans > >  Tomi > >> BR and thanks, >> Nikolaus >> >> [1] >> https://lore.kernel.org/r/all/20210302162403.983585-4-hverkuil-ci...@xs4all.nl/T/ >> >>> Am 02.03.2021 um 17:23 schrieb Hans Verkuil : >>> >>

[PATCH 0/7] media: export InfoFrames to debugfs

2024-08-28 Thread Hans Verkuil
just drop that patch. This is very useful for debugging received InfoFrames. Regards, Hans Hans Verkuil (7): media: v4l2-core: add v4l2_debugfs_root() media: v4l2-core: add v4l2_debugfs_if_alloc/free() media: i2c: adv7511-v4l2: export InfoFrames to debugfs media: i2c: adv7604: e

[PATCH 7/7] media: i2c: tda1997x: export InfoFrames to debugfs

2024-08-28 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil --- drivers/media/i2c/tda1997x.c | 50 ++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c index 3b7e5ff5b010..2b33fdecb2d2

[PATCH 2/7] media: v4l2-core: add v4l2_debugfs_if_alloc/free()

2024-08-28 Thread Hans Verkuil
-decode utility. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dv-timings.c | 63 +++ include/media/v4l2-dv-timings.h | 48 + 2 files changed, 111 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2

[PATCH 6/7] media: i2c: tc358743: export InfoFrames to debugfs

2024-08-28 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil Tested-by: Dave Stevenson --- drivers/media/i2c/tc358743.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index

[PATCH 5/7] media: i2c: adv7842: export InfoFrames to debugfs

2024-08-28 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/media/i2c/adv7842.c | 120 ++-- 1 file changed, 88 insertions(+), 32 deletions(-) diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c index

[PATCH 4/7] media: i2c: adv7604: export InfoFrames to debugfs

2024-08-28 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/media/i2c/adv7604.c | 90 - 1 file changed, 70 insertions(+), 20 deletions(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index

[PATCH 3/7] media: i2c: adv7511-v4l2: export InfoFrames to debugfs

2024-08-28 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/media/i2c/adv7511-v4l2.c | 91 ++-- 1 file changed, 74 insertions(+), 17 deletions(-) diff --git a/drivers/media/i2c/adv7511-v4l2.c b/drivers/media/i2c/adv7511-v4l2.c

[PATCH 1/7] media: v4l2-core: add v4l2_debugfs_root()

2024-08-28 Thread Hans Verkuil
This new function returns the dentry of the top-level debugfs "v4l2" directory. If it does not exist yet, then it is created first. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dev.c | 14 ++ include/media/v4l2-dev.h | 15 +++ 2 fil

Re: [RFC PATCH 7/7] media: i2c: tc358743: export InfoFrames to debugfs

2024-08-21 Thread Hans Verkuil
On 21/08/2024 18:12, Dave Stevenson wrote: > Hi Hans > > This is a very useful little series - thanks. > > On Wed, 21 Aug 2024 at 15:16, Hans Verkuil wrote: >> >> Export InfoFrames to debugfs. > > I had a tc358743 to hand, so thought this warranted a quick t

[RFC PATCH 4/7] media: i2c: adv7604: export InfoFrames to debugfs

2024-08-21 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/media/i2c/adv7604.c | 90 - 1 file changed, 70 insertions(+), 20 deletions(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index

[RFC PATCH 6/7] media: i2c: tda1997x: export InfoFrames to debugfs

2024-08-21 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil --- drivers/media/i2c/tda1997x.c | 50 ++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c index 3b7e5ff5b010..2b33fdecb2d2

[RFC PATCH 5/7] media: i2c: adv7842: export InfoFrames to debugfs

2024-08-21 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/media/i2c/adv7842.c | 120 ++-- 1 file changed, 88 insertions(+), 32 deletions(-) diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c index

[RFC PATCH 1/7] media: v4l2-core: add v4l2_debugfs_root()

2024-08-21 Thread Hans Verkuil
This new function returns the dentry of the top-level debugfs "v4l2" directory. If it does not exist yet, then it is created first. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dev.c | 14 ++ include/media/v4l2-dev.h | 15 +++ 2 fil

[RFC PATCH 3/7] media: i2c: adv7511-v4l2: export InfoFrames to debugfs

2024-08-21 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/media/i2c/adv7511-v4l2.c | 91 ++-- 1 file changed, 74 insertions(+), 17 deletions(-) diff --git a/drivers/media/i2c/adv7511-v4l2.c b/drivers/media/i2c/adv7511-v4l2.c

[RFC PATCH 7/7] media: i2c: tc358743: export InfoFrames to debugfs

2024-08-21 Thread Hans Verkuil
Export InfoFrames to debugfs. Signed-off-by: Hans Verkuil --- drivers/media/i2c/tc358743.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 65d58ddf0287..c7652c0dbaeb 100644

[RFC PATCH 0/7] media: export InfoFrames to debugfs

2024-08-21 Thread Hans Verkuil
lable for testing, so I might decide to just drop this. It's RFC for now, but I think it is quite straightforward. This is very useful for debugging received InfoFrames. Regards, Hans Hans Verkuil (7): media: v4l2-core: add v4l2_debugfs_root() media: v4l2-core: add v4l2_debugf

[RFC PATCH 2/7] media: v4l2-core: add v4l2_debugfs_if_alloc/free()

2024-08-21 Thread Hans Verkuil
-decode utility. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dv-timings.c | 63 +++ include/media/v4l2-dv-timings.h | 48 + 2 files changed, 111 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c b/drivers/media/v4l2

Re: [PATCH v15 00/29] drm/connector: Create HDMI Connector infrastructure

2024-07-31 Thread Hans Verkuil
Hi Maxime, On 27/05/2024 15:57, Maxime Ripard wrote: > Hans Verkuil also expressed interest in implementing a mechanism in v4l2 > to retrieve infoframes from HDMI receiver and implementing a tool to > decode (and eventually check) infoframes. His current work on > edid-decode to

Re: [PATCH v7 02/28] v4l2: handle restricted memory flags in queue setup

2024-07-20 Thread Hans Verkuil
On 20/07/2024 09:15, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Validates the restricted memory flags when setting up a queue and > ensures the queue has the proper capability. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by: Yunfei Dong > [Yunfei: Change reviewer's comments] > ---

Re: [PATCH v7 03/28] media: videobuf2: calculate restricted memory size

2024-07-20 Thread Hans Verkuil
On 20/07/2024 09:15, Yunfei Dong wrote: > Getting the physical address with sg_dma_address for restricted memory, > only return the first physical address size since sg may not be physical > continuous, then leading to the dmabuf size is small than buf size. Need > to bypass continuous checking for

Re: [PATCH v7 02/28] v4l2: handle restricted memory flags in queue setup

2024-07-20 Thread Hans Verkuil
On 20/07/2024 09:15, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Validates the restricted memory flags when setting up a queue and > ensures the queue has the proper capability. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by: Yunfei Dong > [Yunfei: Change reviewer's comments] > ---

Re: [PATCH v7 01/28] v4l2: add restricted memory flags

2024-07-20 Thread Hans Verkuil
Hi Yunfei, First a high-level comment: Adding a new V4L2 uAPI also requires patches to v4l-utils, specifically v4l2-ctl and v4l2-compliance (i.e. new tests are needed for this flag). This will also help you test the driver. Some more comments below: On 20/07/2024 09:15, Yunfei Dong wrote: > Fr

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-19 Thread Hans Verkuil
On 19/06/2024 06:19, Tomasz Figa wrote: > On Wed, Jun 19, 2024 at 1:24 AM Nicolas Dufresne wrote: >> >> Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : >>> Hi TaoJiang, >>> >>> On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: From: Ming Qian When the memory type is

Re: [PATCH v3 07/10] media: intel: Add Displayport RX IP driver

2024-06-07 Thread Hans Verkuil
On 04/06/2024 14:32, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 10:37 AM Hans Verkuil wrote: >> >> On 07/05/2024 17:54, Paweł Anikiel wrote: >>> Add v4l2 subdev driver for the Intel Displayport receiver FPGA IP. >>> It is a part of the DisplayPort

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-04 Thread Hans Verkuil
On 04/06/2024 14:03, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 4:56 PM Hans Verkuil wrote: >> >> On 03/06/2024 16:32, Paweł Anikiel wrote: >>> On Mon, Jun 3, 2024 at 9:57 AM Hans Verkuil >>> wrote: >>>> >>>> On 07/05/2024 17:54,

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Hans Verkuil
On 03/06/2024 16:32, Paweł Anikiel wrote: > On Mon, Jun 3, 2024 at 9:57 AM Hans Verkuil wrote: >> >> On 07/05/2024 17:54, Paweł Anikiel wrote: >>> Add v4l2 driver for the video interface present on the Google >>> Chameleon v3. The Chameleon v3 uses the video

Re: [PATCH v3 00/10] Add Chameleon v3 video support

2024-06-03 Thread Hans Verkuil
Hi Paweł, On 07/05/2024 17:54, Paweł Anikiel wrote: > Google Chameleon v3 is a testing device capable of emulating multiple > DisplayPort monitors, used for testing purposes. It is based on an Arria > 10 SoCFPGA. This patchset adds V4L2 drivers for two IP blocks used in the > device's FPGA: the

Re: [PATCH v3 07/10] media: intel: Add Displayport RX IP driver

2024-06-03 Thread Hans Verkuil
On 07/05/2024 17:54, Paweł Anikiel wrote: > Add v4l2 subdev driver for the Intel Displayport receiver FPGA IP. > It is a part of the DisplayPort Intel FPGA IP Core, and supports > DisplayPort 1.4, HBR3 video capture and Multi-Stream Transport. > > Signed-off-by: Paweł Anikiel > --- > drivers/med

Re: [PATCH v3 01/10] media: Add Chameleon v3 video interface driver

2024-06-03 Thread Hans Verkuil
On 07/05/2024 17:54, Paweł Anikiel wrote: > Add v4l2 driver for the video interface present on the Google > Chameleon v3. The Chameleon v3 uses the video interface to capture > a single video source from a given HDMI or DP connector and write > the resulting frames to memory. > > Signed-off-by: Pa

Re: [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-04-08 Thread Hans Verkuil
On 05/04/2024 12:18, Wolfram Sang wrote: > Hello Easwar, > > On Fri, Mar 29, 2024 at 05:00:24PM +, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix driver

Re: [PATCH v7 21/36] drm/connector: hdmi: Add Broadcast RGB property

2024-03-01 Thread Hans Verkuil
On 29/02/2024 20:47, Sebastian Wick wrote: > On Thu, Feb 22, 2024 at 07:14:07PM +0100, Maxime Ripard wrote: >> The i915 driver has a property to force the RGB range of an HDMI output. >> The vc4 driver then implemented the same property with the same >> semantics. KWin has support for it, and a PR

Re: [PATCH v2 1/9] media: v4l2-subdev: Add a pad variant of .query_dv_timings()

2024-02-29 Thread Hans Verkuil
On 2/29/24 12:33, Paweł Anikiel wrote: > On Thu, Feb 29, 2024 at 9:02 AM Hans Verkuil wrote: >> >> On 28/02/2024 16:34, Paweł Anikiel wrote: >>> On Wed, Feb 28, 2024 at 12:25 PM Hans Verkuil >>> wrote: >>>> >>>> Hi Paweł, >>&g

Re: [PATCH v2 1/9] media: v4l2-subdev: Add a pad variant of .query_dv_timings()

2024-02-29 Thread Hans Verkuil
On 28/02/2024 16:34, Paweł Anikiel wrote: > On Wed, Feb 28, 2024 at 12:25 PM Hans Verkuil > wrote: >> >> Hi Paweł, >> >> On 21/02/2024 17:02, Paweł Anikiel wrote: >>> Currently, .query_dv_timings() is defined as a video callback without >>> a pad

Re: [PATCH v2 2/9] media: Add Chameleon v3 framebuffer driver

2024-02-28 Thread Hans Verkuil
On 28/02/2024 16:08, Paweł Anikiel wrote: > Hi Hans, thanks for the review! > > On Wed, Feb 28, 2024 at 12:24 PM Hans Verkuil > wrote: >> >> Hi Paweł, >> >> On 21/02/2024 17:02, Paweł Anikiel wrote: >>> Add v4l2 driver for the Google Chameleon v3 f

Re: [PATCH v2 6/9] media: intel: Add Displayport RX IP driver

2024-02-28 Thread Hans Verkuil
On 21/02/2024 17:02, Paweł Anikiel wrote: > Add driver for the Intel DisplayPort RX FPGA IP > > Signed-off-by: Paweł Anikiel > --- > drivers/media/platform/intel/Kconfig | 12 + > drivers/media/platform/intel/Makefile |1 + > drivers/media/platform/intel/intel-dprx.c | 2176 ++

Re: [PATCH v2 1/9] media: v4l2-subdev: Add a pad variant of .query_dv_timings()

2024-02-28 Thread Hans Verkuil
Hi Paweł, On 21/02/2024 17:02, Paweł Anikiel wrote: > Currently, .query_dv_timings() is defined as a video callback without > a pad argument. This is a problem if the subdevice can have different > dv timings for each pad (e.g. a DisplayPort receiver with multiple > virtual channels). > > To solv

Re: [PATCH v2 2/9] media: Add Chameleon v3 framebuffer driver

2024-02-28 Thread Hans Verkuil
Hi Paweł, On 21/02/2024 17:02, Paweł Anikiel wrote: > Add v4l2 driver for the Google Chameleon v3 framebuffer device. This is just a video capture device, right? A framebuffer device is something that lives in drivers/video/fbdev. It is *very* confusing to see the term 'framebuffer' used in a vi

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-12 Thread Hans Verkuil
On 12/02/2024 16:49, Ville Syrjälä wrote: > On Mon, Feb 12, 2024 at 11:01:07AM +0100, Maxime Ripard wrote: >> On Fri, Feb 09, 2024 at 09:34:35PM +0100, Sebastian Wick wrote: >>> On Mon, Feb 05, 2024 at 10:39:38AM +0100, Maxime Ripard wrote: On Fri, Feb 02, 2024 at 06:37:52PM +0200, Ville Syrjä

Re: [PATCH 2/4] media: i2c: replace of_graph_get_next_endpoint()

2024-02-07 Thread Hans Verkuil
On 07/02/2024 14:51, Laurent Pinchart wrote: > On Wed, Feb 07, 2024 at 02:14:33PM +0100, Krzysztof Hałasa wrote: >> Hans, >> >> Hans Verkuil writes: >> >>> Ideally someone would have to actually test this, perhaps with one of those >>> Renesas boards

Re: [PATCH 2/4] media: i2c: replace of_graph_get_next_endpoint()

2024-02-06 Thread Hans Verkuil
On 2/6/24 14:41, Laurent Pinchart wrote: > Hi Morimoto-san, > > (Adding Krzysztof Hałasa) > > Thank you for the patch. > > On Tue, Feb 06, 2024 at 02:55:27AM +, Kuninori Morimoto wrote: >> From DT point of view, in general, drivers should be asking for a >> specific port number because their

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-02 Thread Hans Verkuil
On 02/02/2024 12:04, Jani Nikula wrote: > On Mon, 15 Jan 2024, Sebastian Wick wrote: >> On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: >>> The i915 driver has a property to force the RGB range of an HDMI output. >>> The vc4 driver then implemented the same property with the same >>

Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag

2024-01-08 Thread Hans Verkuil
On 04/01/2024 21:05, Jeffrey Kardatzke wrote: > On Mon, Dec 11, 2023 at 3:05 AM Hans Verkuil wrote: >> >> On 06/12/2023 09:15, Yunfei Dong wrote: >>> From: Jeffrey Kardatzke >>> >>> Adds documentation for V4L2_MEMORY_FLAG_SECURE. >>> >

Re: [PATCH v3,04/21] v4l: add documentation for secure memory flag

2023-12-11 Thread Hans Verkuil
On 06/12/2023 09:15, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Adds documentation for V4L2_MEMORY_FLAG_SECURE. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by: Yunfei Dong > --- > Documentation/userspace-api/media/v4l/buffer.rst | 8 +++- > 1 file changed, 7 insertions(+), 1 d

Re: [PATCH v3,03/21] v4l2: verify secure dmabufs are used in secure queue

2023-12-11 Thread Hans Verkuil
On 06/12/2023 09:15, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Verfies in the dmabuf implementations that if the secure memory flag is Verfies -> Verifies > set for a queue that the dmabuf submitted to the queue is unmappable. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by: Yunfe

Re: [PATCH v3,02/21] v4l2: handle secure memory flags in queue setup

2023-12-11 Thread Hans Verkuil
Hi Yunfei, Jeffrey, Some comments below: On 06/12/2023 09:15, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Validates the secure memory flags when setting up a queue and ensures > the queue has the proper capability. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by: Yunfei Dong > ---

Re: [PATCH v3,16/21] media: medkatek: vcodec: support one plane capture buffer

2023-12-06 Thread Hans Verkuil
On 06/12/2023 09:15, Yunfei Dong wrote: > The capture buffer has two planes for format MM21, but user space only > allocate secure memory for plane[0], and the size is Y data + uv data. > The driver need to support one plane decoder for svp mode. For a future v4: note the typo in the Subject line:

Re: [PATCH v4 00/45] drm/connector: Create HDMI Connector infrastructure

2023-11-28 Thread Hans Verkuil
can implement > multiple output) and required more churn to cast between the > drm_connector and its subclass. The decision was thus to provide a set > of helper and to store the required variables in drm_connector and > drm_connector_state. This what has been implemented now. >

Re: [PATCH 20/32] media/ivtvfb: Initialize fb_ops to fbdev I/O-memory helpers

2023-11-20 Thread Hans Verkuil
hat do not use these functions. > > Set the callbacks via macros. No functional changes. Makes sense, shall I pick up this patch? If you prefer to take it, then you can add: Reviewed-by: Hans Verkuil Regards, Hans > > Signed-off-by: Thomas Zimmermann > Cc: Andy Walls

Re: [PATCH RFC v3 12/37] drm/connector: hdmi: Create Infoframe DebugFS entries

2023-11-06 Thread Hans Verkuil
On 06/11/2023 15:44, Maxime Ripard wrote: > Hi Hans, > > On Fri, Nov 03, 2023 at 10:05:18AM +0100, Hans Verkuil wrote: >> Hi Maxime, >> >> Thank you for posting v3, this time it runs fine on my RPi 4, thank you for >> fixing that. >> >> I'

Re: [PATCH RFC v3 12/37] drm/connector: hdmi: Create Infoframe DebugFS entries

2023-11-03 Thread Hans Verkuil
Hi Maxime, Thank you for posting v3, this time it runs fine on my RPi 4, thank you for fixing that. I'll start working on a conformity checker for this. I have a few remarks: On 31/10/2023 17:48, Maxime Ripard wrote: > There has been some discussions recently about the infoframes sent by > driv

Re: [PATCH v3 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-10-19 Thread Hans Verkuil
Hi Maxime, On 19/10/2023 10:02, Maxime Ripard wrote: > Hi, > > On Wed, Oct 11, 2023 at 03:23:18PM +0200, Daniel Vetter wrote: >> On Mon, 6 Mar 2023 at 11:49, Maxime Ripard wrote: >>> >>> From: Dave Stevenson >>> >>> Copy Intel's "Broadcast RGB" property semantics to add manual override >>> of t

Re: [PATCH RFC v2 00/37] drm/connector: Create HDMI Connector infrastructure

2023-09-21 Thread Hans Verkuil
or driver can implement > multiple output) and required more churn to cast between the > drm_connector and its subclass. The decision was thus to provide a set > of helper and to store the required variables in drm_connector and > drm_connector_state. This what has been implemented now. >

Re: [PATCH v5 00/14] add support MDP3 on MT8195 platform

2023-09-15 Thread Hans Verkuil
Hi Moudy, On 12/09/2023 09:57, Moudy Ho wrote: > Changes since v4: > - Rebase on v6.6-rc1 > - Remove any unnecessary DTS settings. > - Adjust the usage of MOD and clock in blending components. > > Changes since v3: > - Depend on : > [1] https://patchwork.kernel.org/project/linux-media/list/?ser

Re: [PATCH v5 00/14] add support MDP3 on MT8195 platform

2023-09-15 Thread Hans Verkuil
On 12/09/2023 12:28, Chen-Yu Tsai wrote: > On Tue, Sep 12, 2023 at 5:43 PM AngeloGioacchino Del Regno > wrote: >> >> Il 12/09/23 11:37, Chen-Yu Tsai ha scritto: >>> On Tue, Sep 12, 2023 at 5:00 PM AngeloGioacchino Del Regno >>> wrote: Il 12/09/23 09:57, Moudy Ho ha scritto: > Change

Re: [PATCH 0/6] drm, cec and edid updates

2023-08-31 Thread Hans Verkuil
rging via > drm-intel? That's fine, it makes sense to do that. If you need it, for this series: Acked-by: Hans Verkuil Regards, Hans > > Thanks, > Jani. > > >> >> drivers/gpu/drm/display/drm_dp_cec.c | 22 +++---

Re: [PATCH v2] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-31 Thread Hans Verkuil
On 31/08/2023 12:51, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil > Cc: linux-me...@vger.k

Re: [PATCH v2] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-30 Thread Hans Verkuil
ng is a bit specific now that > there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > v2: Fix the embarrashing build failures > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula Reviewed-by: Hans Verku

Re: [PATCH 6/6] media: cec: core: add note about *_from_edid() function usage in drm

2023-08-30 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > In the drm subsystem, the source physical address is, in most cases, > available without having to parse the EDID again. Add notes about > preferring to use the pre-parsed address instead. > > Cc: Hans Verkuil > Cc: linux-me...@vger.k

Re: [PATCH 5/6] drm/i915/cec: switch to setting physical address directly

2023-08-30 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > Avoid parsing the EDID again for source physical address. Also gets rids > of a few remaining raw EDID usages. > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula Reviewed-by: Hans Verkuil Rega

Re: [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-30 Thread Hans Verkuil
there's no need to pass the EDID at all, so aim for attach/detach going > forward. > > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/display/drm_dp_cec.c | 22 +++--- > include/drm/display

Re: [PATCH 3/6] drm/edid: parse source physical address

2023-08-30 Thread Hans Verkuil
On 24/08/2023 15:46, Jani Nikula wrote: > CEC needs the source physical address. Parsing it is trivial with the > existing EDID CEA DB infrastructure. > > Default to CEC_PHYS_ADDR_INVALID (0x) instead of 0 to cater for > easier CEC usage. > > Cc: Hans Ve

Re: [PATCH RFC 00/13] drm/connector: Create HDMI Connector infrastructure

2023-08-16 Thread Hans Verkuil
ables stored in a state (current bpc, format, RGB range selection, > etc.). > > Thus, I decided to create some generic subclass of drm_connector to > address HDMI connectors, with a bunch of helpers that will take care of > all the "HDMI Spec" related code. Scrambler setup

Re: [v3] media: mediatek: vcodec: fix AV1 decoding on MT8188

2023-08-07 Thread Hans Verkuil
FYI: the v2 patch has already been merged, so I dropped this v3. On 03/08/2023 13:10, Xiaoyong Lu wrote: > Fix AV1 decoding failure when the iova is 36bit. > > Before this fix, the decoder was accessing incorrect addresses with 36bit > iova tile buffer, leading to iommu faults. > > Fixes: 2f5d0a

Re: [PATCH v2 01/47] media/vivid: Use fbdev I/O helpers

2023-08-02 Thread Hans Verkuil
On 01/08/2023 18:54, Thomas Zimmermann wrote: > Hi > > Am 01.08.23 um 13:22 schrieb Hans Verkuil: >> On 01/08/2023 12:13, Thomas Zimmermann wrote: >>> Set struct fb_ops and with FB_DEFAULT_IO_OPS, fbdev's initializer >>> for I/O memory. Sets the call

Re: [PATCH v2 01/47] media/vivid: Use fbdev I/O helpers

2023-08-01 Thread Hans Verkuil
d token set the currently selected values, so there is > no functional change. > > v2: > * updated to use _IOMEM_ tokens > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Sam Ravnborg > Acked-by: Helge Deller > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab &g

Re: [PATCH v4 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

2023-07-18 Thread Hans Verkuil
up all occurrences of FBINFO_DEFAULT, the token will be removed. > > v2: > * fix commit message (Miguel) > > Signed-off-by: Thomas Zimmermann > Acked-by: Sam Ravnborg > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > --- > drivers/media/pc

Re: [v10] media: mediatek: vcodec: support stateless AV1 decoder

2023-05-26 Thread Hans Verkuil
On 14/04/2023 10:30, Xiaoyong Lu wrote: > Add mediatek av1 decoder linux driver which use the stateless API in > MT8195. > > Signed-off-by: Xiaoyong Lu > Tested-by: Nicolas Dufresne > Reviewed-by: Nicolas Dufresne > Tested-by: AngeloGioacchino Del Regno > > Reviewed-by: AngeloGioacchino Del Re

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-05-26 Thread Hans Verkuil
Hi Arnaud, My apologies for the long delay in replying, it's been very, very busy lately. I hope I'll be able to be more responsive going forward. On 21/04/2023 18:58, Arnaud Vrac wrote: > Le ven. 21 avr. 2023 à 15:27, Hans Verkuil a écrit > : >> >> Hi Arnaud, >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-23 Thread Hans Verkuil
| 3 +- > include/linux/i2c.h | 3 +- > 5 files changed, 69 insertions(+), 37 deletions(-) For the media and adv7511 bits: Reviewed-by: Hans Verkuil Regards, Hans > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/driver

Re: [PATCH 2/4] drm/msm: add hdmi cec support

2023-04-21 Thread Hans Verkuil
Hi Arnaud, Some review comments below... On 4/18/23 20:10, Arnaud Vrac wrote: > Some Qualcomm SoCs that support HDMI also support CEC, including MSM8996 > and MSM8998. The hardware block can handle a single CEC logical address > and broadcast messages. > > Port the CEC driver from downstream msm

Re: [PATCH 1/3] dt-bindings: display: synopsys, dw-hdmi: Add property for disabling CEC

2023-04-21 Thread Hans Verkuil
On 18/04/2023 23:41, Rob Herring wrote: > On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote: >> Even though some DW-HDMI controllers have perfectly usable HDMI-CEC >> implementation, some boards might prefer not to use it or even use >> software implementation instead. >> >> Add proper

Re: [PATCH v5 14/20] staging: media: tegra-video: move MIPI calibration calls from VI to CSI

2023-04-18 Thread Hans Verkuil
On 18/04/2023 10:07, Luca Ceresoli wrote: > Hi Hans, > > On Fri, 14 Apr 2023 17:51:34 +0200 > Hans Verkuil wrote: > >> Hi Luca, >> >> I just encountered an error in this patch, so I have rejected the PR I made. >> >> See below for the details: &

Re: [PATCH v5 14/20] staging: media: tegra-video: move MIPI calibration calls from VI to CSI

2023-04-14 Thread Hans Verkuil
Hi Luca, I just encountered an error in this patch, so I have rejected the PR I made. See below for the details: On 07/04/2023 15:38, Luca Ceresoli wrote: > The CSI module does not handle all the MIPI lane calibration procedure, > leaving a small part of it to the VI module. In doing this, > teg

Re: [PATCH v2 1/7] media: videobuf2: Don't assert held reservation lock for dma-buf mmapping

2023-04-12 Thread Hans Verkuil
d-by: Emil Velikov > Signed-off-by: Dmitry Osipenko Reviewed-by: Hans Verkuil Regards, Hans > --- > drivers/media/common/videobuf2/videobuf2-dma-contig.c | 3 --- > drivers/media/common/videobuf2/videobuf2-dma-sg.c | 3 --- > drivers/media/common/videobuf2/vide

Re: [v9] media: mediatek: vcodec: support stateless AV1 decoder

2023-04-12 Thread Hans Verkuil
On 12/04/2023 14:22, Hans Verkuil wrote: > On 12/04/2023 05:30, Xiaoyong Lu wrote: >> Add mediatek av1 decoder linux driver which use the stateless API in >> MT8195. >> >> Signed-off-by: Xiaoyong Lu >> Tested-by: Nicolas Dufresne >> Reviewed-by: Nicolas D

Re: [v9] media: mediatek: vcodec: support stateless AV1 decoder

2023-04-12 Thread Hans Verkuil
On 12/04/2023 05:30, Xiaoyong Lu wrote: > Add mediatek av1 decoder linux driver which use the stateless API in > MT8195. > > Signed-off-by: Xiaoyong Lu > Tested-by: Nicolas Dufresne > Reviewed-by: Nicolas Dufresne > Tested-by: AngeloGioacchino Del Regno > > Reviewed-by: AngeloGioacchino Del Re

Re: [PATCH v5 00/20] Add Tegra20 parallel video input capture

2023-04-12 Thread Hans Verkuil
edia: tegra-video: add a per-soc enable/disable op >>16. staging: media: tegra-video: move syncpt init/free to a per-soc op >>17. staging: media: tegra-video: add syncpts for Tegra20 to struct >> tegra_vi >>18. staging: media: tegra-video: add hooks for planar YUV and H/V flip >

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-04-05 Thread Hans Verkuil
On 05/04/2023 10:31, Luca Ceresoli wrote: > Hi Laurent, > > On Wed, 5 Apr 2023 05:30:48 +0300 > Laurent Pinchart wrote: > >> Hi Luca, >> >> On Tue, Apr 04, 2023 at 04:12:51PM +0200, Luca Ceresoli wrote: >>> On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verku

Re: [RESEND PATCH v4 03/21] staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats

2023-03-29 Thread Hans Verkuil
Hi Luca, On 29/03/2023 13:16, Hans Verkuil wrote: > Hi Luca, > > I finally found the time to test this series. It looks OK, except for this > patch. > The list of supported formats really has to be the intersection of what the > tegra > supports and what the sensor support

  1   2   3   4   5   6   7   8   9   10   >