Re: [PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check

2025-06-26 Thread Doug Anderson
Hi, On Wed, Jun 25, 2025 at 11:25 AM Doug Anderson wrote: > > Hi, > > On Fri, Jun 20, 2025 at 12:50 AM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on inpu

Re: [PATCH] drm/panel-edp: Add CMN N116BCJ-EAK

2025-06-26 Thread Doug Anderson
Hi, On Thu, Jun 26, 2025 at 5:29 AM Langyan Ye wrote: > > Add support for the CMN N116BCJ-EAK, pleace the EDID here for > subsequent reference. > > 00 ff ff ff ff ff ff 00 0d ae 63 11 00 00 00 00 > 19 22 01 04 95 1a 0e 78 02 67 75 98 59 53 90 27 > 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 >

Re: [PATCH] drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check

2025-06-25 Thread Doug Anderson
Hi, On Fri, Jun 20, 2025 at 12:50 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input > lines"), the GPIO core makes sure values cannot be set on input lines. > Remove the unnecessary check. > > Signed-off-by:

Re: [PATCH v6] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-06-25 Thread Doug Anderson
Hi, On Tue, Jun 24, 2025 at 1:59 PM Doug Anderson wrote: > > Hi, > > On Mon, Jun 23, 2025 at 9:48 PM Jayesh Choudhary wrote: > > > > By default, HPD was disabled on SN65DSI86 bridge. When the driver was > > added (commit "a095f15c00e27"), the HPD_DISABLE

Re: [PATCH v6] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-06-24 Thread Doug Anderson
Hi, On Mon, Jun 23, 2025 at 9:48 PM Jayesh Choudhary wrote: > > By default, HPD was disabled on SN65DSI86 bridge. When the driver was > added (commit "a095f15c00e27"), the HPD_DISABLE bit was set in pre-enable > call which was moved to other function calls subsequently. > Later on, commit "c312b0

Re: [PATCH v5] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-06-23 Thread Doug Anderson
Hi, On Mon, Jun 16, 2025 at 9:24 AM Doug Anderson wrote: > > Hi, > > On Mon, Jun 16, 2025 at 2:32 AM Jayesh Choudhary wrote: > > > > @@ -1220,6 +1231,27 @@ static void ti_sn65dsi86_debugfs_init(struct > > drm_bridge *bridge, struct dentry * > >

Re: [PATCH] drm/bridge: ti-sn65dsi86: use new GPIO line value setter callbacks

2025-06-16 Thread Doug Anderson
Hi, On Tue, Jun 10, 2025 at 9:27 AM Doug Anderson wrote: > > Hi, > > On Tue, Jun 10, 2025 at 5:34 AM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > struct gpio_chip now has callbacks for setting line values that return > >

Re: [PATCH v4 3/8] drm/bridge: ti-sn65dsi86: use the auxiliary device

2025-06-16 Thread Doug Anderson
Hi, On Mon, Jun 9, 2025 at 8:43 AM Doug Anderson wrote: > > Hi, > > On Mon, Jun 9, 2025 at 6:02 AM Jerome Brunet wrote: > > > > On Tue 25 Feb 2025 at 08:04, Doug Anderson wrote: > > > > > Hi, > > > > > > On Tue, Feb 18, 2025 at 11:30 AM

Re: [PATCH v5] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-06-16 Thread Doug Anderson
Hi, On Mon, Jun 16, 2025 at 2:32 AM Jayesh Choudhary wrote: > > @@ -1220,6 +1231,27 @@ static void ti_sn65dsi86_debugfs_init(struct > drm_bridge *bridge, struct dentry * > debugfs_create_file("status", 0600, debugfs, pdata, &status_fops); > } > > +static void ti_sn_bridge_hpd_enable(str

Re: [PATCH] drm/bridge: ti-sn65dsi86: fix REFCLK setting

2025-06-12 Thread Doug Anderson
Hi, On Thu, Jun 12, 2025 at 10:52 AM Doug Anderson wrote: > > Hi, > > On Thu, Jun 12, 2025 at 12:35 AM Jayesh Choudhary wrote: > > > > >> If refclk is described in devicetree node, then I see that > > >> the driver modifies it in every resume call bas

Re: [PATCH] drm/bridge: ti-sn65dsi86: fix REFCLK setting

2025-06-12 Thread Doug Anderson
Hi, On Thu, Jun 12, 2025 at 12:35 AM Jayesh Choudhary wrote: > > >> If refclk is described in devicetree node, then I see that > >> the driver modifies it in every resume call based solely on the > >> clock value in dts. > > > > Exactly. But that is racy with what the chip itself is doing. I.e. >

Re: [PATCH v4] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-06-12 Thread Doug Anderson
Hi, On Wed, Jun 11, 2025 at 9:39 PM Jayesh Choudhary wrote: > > Hello Doug, > > On 12/06/25 03:08, Doug Anderson wrote: > > Hi, > > > > On Tue, Jun 10, 2025 at 10:29 PM Jayesh Choudhary > > wrote: > >> > >> @@ -1195,9 +1203,17 @@ stat

Re: [PATCH v4] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-06-11 Thread Doug Anderson
Hi, On Tue, Jun 10, 2025 at 10:29 PM Jayesh Choudhary wrote: > > @@ -1195,9 +1203,17 @@ static enum drm_connector_status > ti_sn_bridge_detect(struct drm_bridge *bridge) > struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge); > int val = 0; > > - pm_runtime_get_sync(

Re: [PATCH] drm/bridge: ti-sn65dsi86: use new GPIO line value setter callbacks

2025-06-10 Thread Doug Anderson
Hi, On Tue, Jun 10, 2025 at 5:34 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > struct gpio_chip now has callbacks for setting line values that return > an integer, allowing to indicate failures. Convert the driver to using > them. > > Signed-off-by: Bartosz Golaszewski > --- >

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-06-10 Thread Doug Anderson
Hi, On Tue, Jun 10, 2025 at 12:43 AM Jayesh Choudhary wrote: > > Hello Doug, > > On 10/06/25 03:39, Doug Anderson wrote: > > Hi, > > > > On Mon, Jun 2, 2025 at 4:05 AM Jayesh Choudhary wrote: > >> > >> Hello Geert, Krzysztof, > >> >

Re: [PATCH 1/4] drm/panel: use fwnode based lookups for panel followers

2025-06-09 Thread Doug Anderson
t; Package (0x02) > { > "panel", \_SB.PCI0.GFX0.LCD0 > } > > Suggested-by: Heikki Krogerus > Cc: Neil Armstrong > Cc: Jessica Zhang > Cc: Maxime Ripard > Cc: Doug Anderson > Cc: Lee Shawn C > Signed-off-by: Jani Nikula > --- > dr

Re: [PATCH] drm/bridge: ti-sn65dsi86: fix REFCLK setting

2025-06-09 Thread Doug Anderson
Hi, On Wed, May 28, 2025 at 6:21 AM Michael Walle wrote: > > The bridge has three bootstrap pins which are sampled to determine the > frequency of the external reference clock. The driver will also > (over)write that setting. But it seems this is racy after the bridge is > enabled. It was observe

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-06-09 Thread Doug Anderson
Hi, On Mon, Jun 2, 2025 at 4:05 AM Jayesh Choudhary wrote: > > Hello Geert, Krzysztof, > > (continuing discussion from both patches on this thread...) > > On 30/05/25 13:25, Geert Uytterhoeven wrote: > > Hi Jayesh, > > > > CC devicetree > > > > On Fri, 30 May 2025 at 04:54, Jayesh Choudhary wrot

Re: [PATCH v4 3/8] drm/bridge: ti-sn65dsi86: use the auxiliary device

2025-06-09 Thread Doug Anderson
Hi, On Mon, Jun 9, 2025 at 6:02 AM Jerome Brunet wrote: > > On Tue 25 Feb 2025 at 08:04, Doug Anderson wrote: > > > Hi, > > > > On Tue, Feb 18, 2025 at 11:30 AM Jerome Brunet wrote: > >> > >> The auxiliary device creation of this driver is simp

Re: [PATCH v4 2/5] drm/panel-edp: add N160JCE-ELL CMN panel for Lenovo Thinkbook 16

2025-05-27 Thread Doug Anderson
Hi, On Sat, May 24, 2025 at 4:48 AM Jens Glathe via B4 Relay wrote: > > From: Jens Glathe > > Panel is widely used in 16" laptops, and also in my Thinkbook 16 G7 QOY. > > CMN N160JCE-ELL EDID > edid-decode (hex): > > 00 ff ff ff ff ff ff 00 0d ae 2b 16 00 00 00 00 > 20 20 01 04 a5 22 16 78 03 28

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-05-27 Thread Doug Anderson
Hi, On Mon, May 26, 2025 at 1:41 AM Ernest Van Hoecke wrote: > > Hi Jayesh, > > First of all, thanks for your patch. I applied it to our 6.6-based > downstream kernel supporting a board I have here, and noticed some > strange behaviour with eDP now. > > On Thu, May 08, 2025 at 05:24:33PM +0530, J

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-05-27 Thread Doug Anderson
Hi, On Thu, May 22, 2025 at 6:14 AM Dmitry Baryshkov wrote: > > > > @@ -1194,13 +1196,14 @@ static enum drm_connector_status > > > ti_sn_bridge_detect(struct drm_bridge *bridge) > > > { > > > struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge); > > > int val = 0; > > > +

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

2025-05-21 Thread Doug Anderson
Hi, On Thu, May 8, 2025 at 4:54 AM Jayesh Choudhary wrote: > > By default, HPD was disabled on SN65DSI86 bridge. When the driver was > added (commit "a095f15c00e27"), the HPD_DISABLE bit was set in pre-enable > call which was moved to other function calls subsequently. > Later on, commit "c312b0d

Re: [PATCH] drm/panel-edp: Add KDC KD116N3730A05

2025-05-21 Thread Doug Anderson
Hi, On Wed, May 21, 2025 at 2:37 AM Langyan Ye wrote: > > Add support for the KDC KD116N3730A05, pleace the EDID here for > subsequent reference. > > 00 ff ff ff ff ff ff 00 2c 83 20 12 00 00 00 00 > 30 22 01 04 95 1a 0e 78 03 3a 75 9b 5d 5b 96 28 > 19 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01

Re: [PATCH v1] drm/panel-edp: Add support for AUO G156HAN03.0 panel

2025-05-20 Thread Doug Anderson
Hi, On Tue, May 20, 2025 at 5:43 AM wrote: > > From: Ernest Van Hoecke > > AUO G156HAN03.0 EDID: > > 00 ff ff ff ff ff ff 00 06 af ed 30 00 00 00 00 > 1a 1c 01 04 a5 22 13 78 02 05 b5 94 59 59 92 28 > 1d 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 78 37 80 b4 70 38 2e 40 6c

Re: [PATCH] drm/panel-edp: Add BOE NV133WUM-N61 panel entry

2025-05-16 Thread Doug Anderson
Hi, On Thu, May 15, 2025 at 2:11 PM Rob Clark wrote: > > From: Rob Clark > > Add an eDP panel for BOE NV133WUM-N61, which appears to be a 3rd panel > option on the lenevo x13s laptop. > > edid: > 00 ff ff ff ff ff ff 00 09 e5 64 09 00 00 00 00 > 16 1e 01 04 a5 1d 12 78 03 55 8e a7 51 4c 9c 26 >

Re: [PATCH v1] drm/bridge: ti-sn65dsi86: Use HPD in a DP use case

2025-05-01 Thread Doug Anderson
Hi, On Thu, May 1, 2025 at 12:48 AM wrote: > > From: Max Krummenacher > > The bridge driver currently disables handling the hot plug input and > relies on a always connected eDP panel with fixed delays when the > panel is ready. Not entirely correct. In some cases we don't have fixed delays and

Re: PROBLEM: AST2500 BMC video output disabled by reboot (regression)

2025-04-30 Thread Doug Anderson
Hi, On Wed, Apr 30, 2025 at 10:52 AM Nick Bowler wrote: > > > > To clarify, there is no boot failure. There is just no video output > > > after rebooting. I can then boot Linux again by any method that works > > > without being able to see the screen, and then everything is fine once > > > I do

Re: PROBLEM: AST2500 BMC video output disabled by reboot (regression)

2025-04-30 Thread Doug Anderson
Hi, On Wed, Apr 30, 2025 at 6:28 AM Nick Bowler wrote: > > Hi Doug, > > On Mon, Apr 28, 2025 at 01:40:25PM -0700, Doug Anderson wrote: > > On Sun, Apr 20, 2025 at 9:26■PM Nick Bowler wrote: > > > I recently noticed that on current kernels I lose video output from &

Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

2025-04-30 Thread Doug Anderson
Hi, On Wed, Apr 30, 2025 at 3:36 AM Luca Ceresoli wrote: > > Hello Doug, > > On Mon, 28 Apr 2025 13:59:50 -0700 > Doug Anderson wrote: > > [...] > > > Reviewed-by: Douglas Anderson # parade-ps8640 > > Tested-by: Douglas Anderson # parade-ps8640 > > T

Re: [PATCH v3 3/3] drm/panel-edp: Add support for CSW MNE007QS3-8 panel

2025-04-29 Thread Doug Anderson
Hi, On Tue, Apr 29, 2025 at 2:20 AM Zhengqiao Xia wrote: > > CSW MNE007QS3-8 EDID: > edid-decode (hex): > > 00 ff ff ff ff ff ff 00 0e 77 57 14 00 00 00 00 > 34 22 01 04 a5 1e 13 78 07 ee 95 a3 54 4c 99 26 > 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 cd 7c 80 a0 70 b0 50

Re: [PATCH v3 2/3] drm/panel-edp: Add support for BOE NE140WUM-N6S panel

2025-04-29 Thread Doug Anderson
Hi, On Tue, Apr 29, 2025 at 2:20 AM Zhengqiao Xia wrote: > > BOE NE140WUM-N6S EDID: > edid-decode (hex): > > 00 ff ff ff ff ff ff 00 09 e5 73 0d 00 00 00 00 > 32 22 01 04 a5 1e 13 78 07 13 45 a6 54 4d a0 27 > 0c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 03 3e 80 a0 70 b0 48

Re: [PATCH v3 1/3] drm/panel-edp: Add support for AUO B140QAN08.H panel

2025-04-29 Thread Doug Anderson
Hi, On Tue, Apr 29, 2025 at 2:20 AM Zhengqiao Xia wrote: > > AUO B140QAN08.H EDID: > edid-decode (hex): > > 00 ff ff ff ff ff ff 00 06 af b9 fe 00 00 00 00 > 00 23 01 04 a5 1e 13 78 03 c1 45 a8 55 48 9d 24 > 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 18 86 40 a0 b0 08 52

Re: [PATCH] drm/msm/gpu: Fix crash when throttling GPU immediately during boot

2025-04-29 Thread Doug Anderson
Hi, On Tue, Apr 29, 2025 at 1:34 AM Stephan Gerhold wrote: > > There is a small chance that the GPU is already hot during boot. In that > case, the call to of_devfreq_cooling_register() will immediately try to > apply devfreq cooling, as seen in the following crash: > > Unable to handle kernel

Re: [RFC PATCH] drm/bridge: ti-sn65dsi86: Enable HPD functionality

2025-04-28 Thread Doug Anderson
Hi, On Thu, Apr 24, 2025 at 6:32 PM Kumar, Udit wrote: > > Hello Jayesh, > > On 4/24/2025 4:24 PM, Jayesh Choudhary wrote: > > For TI SoC J784S4, the display pipeline looks like: > > TIDSS -> CDNS-DSI -> SN65DSI86 -> DisplayConnector -> DisplaySink > > This requires HPD to detect connection form

Re: [PATCH v2 01/34] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API

2025-04-28 Thread Doug Anderson
Hi, On Thu, Apr 24, 2025 at 11:59 AM Luca Ceresoli wrote: > > devm_drm_bridge_alloc() is the new API to be used for allocating (and > partially initializing) a private driver struct embedding a struct > drm_bridge. > > For many drivers having a simple code flow in the probe function, this > commi

Re: [PATCH v2 13/34] drm/bridge: ti-sn65dsi86: convert to devm_drm_bridge_alloc() API

2025-04-28 Thread Doug Anderson
Hi, On Thu, Apr 24, 2025 at 12:00 PM Luca Ceresoli wrote: > > This is the new API for allocating DRM bridges. > > Reviewed-by: Herve Codina > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by:

Re: PROBLEM: AST2500 BMC video output disabled by reboot (regression)

2025-04-28 Thread Doug Anderson
Hi, On Sun, Apr 20, 2025 at 9:26 PM Nick Bowler wrote: > > Hi, > > I recently noticed that on current kernels I lose video output from > my Blackbird's AST2500 BMC after a reboot, which makes it difficult to > boot the system again (the video output will come on only after Linux > is booted again

Re: [PATCH v2 3/3] drm/panel-edp: Add support for CSW MNE007QS3-8 panel

2025-04-28 Thread Doug Anderson
Hi, On Mon, Apr 21, 2025 at 4:37 AM Zhengqiao Xia wrote: > > CSW MNE007QS3-8 EDID: > edid-decode (hex): > > 00 ff ff ff ff ff ff 00 0e 77 57 14 00 00 00 00 > 34 22 01 04 a5 1e 13 78 07 ee 95 a3 54 4c 99 26 > 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 cd 7c 80 a0 70 b0 50

Re: [PATCH v2 2/3] drm/panel-edp: Add support for BOE NE140WUM-N6S panel

2025-04-28 Thread Doug Anderson
Hi, On Mon, Apr 21, 2025 at 4:37 AM Zhengqiao Xia wrote: > > BOE NE140WUM-N6S EDID: > edid-decode (hex): > > 00 ff ff ff ff ff ff 00 09 e5 73 0d 00 00 00 00 > 32 22 01 04 a5 1e 13 78 07 13 45 a6 54 4d a0 27 > 0c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 03 3e 80 a0 70 b0 48

Re: [PATCH v2 1/3] drm/panel-edp: Add support for AUO B140QAN08.H panel

2025-04-28 Thread Doug Anderson
Hi, On Mon, Apr 21, 2025 at 4:36 AM Zhengqiao Xia wrote: > > AUO B140QAN08.H EDID: > edid-decode (hex): > > 00 ff ff ff ff ff ff 00 06 af b9 fe 00 00 00 00 > 00 23 01 04 a5 1e 13 78 03 c1 45 a8 55 48 9d 24 > 0f 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 > 01 01 01 01 01 01 18 86 40 a0 b0 08 52

Re: [PATCH] drm/bridge: ti-sn65dsi86: Add necessary DSI flags

2025-04-28 Thread Doug Anderson
Hi, On Thu, Apr 24, 2025 at 3:47 AM Jayesh Choudhary wrote: > > Hello Doug, > > On 17/04/25 02:40, Jayesh Choudhary wrote: > > Hello Doug, > > > > On 13/04/25 07:22, Doug Anderson wrote: > >> Hi, > >> > >> On Fri, Apr 11, 2025 at 2:23 A

Re: [PATCH v3] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-04-16 Thread Doug Anderson
Hi, On Sat, Apr 12, 2025 at 9:00 PM Tejas Vipin wrote: > > Changes the boe-bf060y8m-aj0 panel to use multi style functions for > improved error handling. Additionally the MIPI_DSI_MODE_LPM flag is set > after the off commands are run in boe_bf060y8m_aj0_off regardless of any > failures, and regul

Re: [PATCH v3] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-04-14 Thread Doug Anderson
Hi, On Sat, Apr 12, 2025 at 9:00 PM Tejas Vipin wrote: > > Changes the boe-bf060y8m-aj0 panel to use multi style functions for > improved error handling. Additionally the MIPI_DSI_MODE_LPM flag is set > after the off commands are run in boe_bf060y8m_aj0_off regardless of any > failures, and regul

Re: [PATCH] drm/bridge: ti-sn65dsi86: Add necessary DSI flags

2025-04-12 Thread Doug Anderson
Hi, On Fri, Apr 11, 2025 at 2:23 AM Jayesh Choudhary wrote: > > Enable NO_EOT and SYNC flags for DSI to use VIDEO_SYNC_PULSE_MODE > with EOT disabled. Any chance you could add some details to this commit message? Your subject says that these flags are "necessary", but people have been using this

Re: [PATCH v3] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-04-12 Thread Doug Anderson
Hi, On Fri, Apr 11, 2025 at 9:30 PM Tejas Vipin wrote: > > Changes the boe-bf060y8m-aj0 panel to use multi style functions for > improved error handling. Additionally the MIPI_DSI_MODE_LPM flag is set > after the off commands are run in boe_bf060y8m_aj0_off regardless of any > failures, and regul

Re: [PATCH v2] drm/panel/sharp-ls043t1le01: Use _multi variants

2025-04-05 Thread Doug Anderson
t; > @rule_3@ > identifier dsi_var; > identifier func; > type t; > position p; > expression list es; > @@ > t func(...) { > ... > struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi_var }; > ... > -return 0; > +return dsi_ctx.accum_err; > } This is

Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-04-01 Thread Doug Anderson
Hi, On Mon, Mar 31, 2025 at 6:52 PM Dmitry Baryshkov wrote: > > > > ...although I think you said that the DRM framework ignores errors > > > from prepare() and still calls unprepare(). I guess this is in > > > panel_bridge_atomic_pre_enable() where drm_panel_prepare()'s error > > > code is ignore

Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-03-31 Thread Doug Anderson
Hi, On Mon, Mar 31, 2025 at 1:28 PM Dmitry Baryshkov wrote: > > On Mon, Mar 31, 2025 at 08:06:36AM -0700, Doug Anderson wrote: > > Hi, > > > > On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin wrote: > > > > > > @@ -157,7 +137,6 @@ static int boe_bf060y8m_

Re: [PATCH v2] drm/panel: boe-bf060y8m-aj0: transition to mipi_dsi wrapped functions

2025-03-31 Thread Doug Anderson
Hi, On Sun, Mar 30, 2025 at 11:18 PM Tejas Vipin wrote: > > @@ -157,7 +137,6 @@ static int boe_bf060y8m_aj0_prepare(struct drm_panel > *panel) > > ret = boe_bf060y8m_aj0_on(boe); > if (ret < 0) { > - dev_err(dev, "Failed to initialize panel: %d\n", ret); >

Re: [PATCH] drm/bridge: anx7625: Remove redundant 'flush_workqueue()' calls

2025-03-27 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 2:02 AM Chen Ni wrote: > > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > - flu

Re: [PATCH v3] drm/panel/sharp-ls043t1le01: Use _multi variants

2025-03-27 Thread Doug Anderson
pt is > used and remove the actual script from commit log. > Use mipi_dsi_dcs_write_seq_multi() for mipi_dsi_dcs_write() (Doug) > > Cc: Maxime Ripard > Cc: Dmitry Baryshkov > Cc: Tejas Vipin > Cc: Doug Anderson > Signed-off-by: Anusha Srivatsa > --- > Changes in v3: > -

Re: [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna40yk20: document ATNA40YK20

2025-03-27 Thread Doug Anderson
Hi, On Wed, Mar 26, 2025 at 1:08 AM Krzysztof Kozlowski wrote: > > On Tue, Mar 25, 2025 at 07:21:26PM +, Christopher Obbard wrote: > > The Samsung ATNA40YK20 panel is a 14" AMOLED eDP panel. It is > > similar to the ATNA33XC20 except that it is larger and has a > > different resolution. > > >

Re: [PATCH v2] drm/panel: himax-hx8394: transition to mipi_dsi wrapped functions

2025-03-25 Thread Doug Anderson
Hi, On Tue, Mar 25, 2025 at 2:47 AM Tejas Vipin wrote: > > Changes the himax-hx8394 panel to use multi style functions for > improved error handling. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Tejas Vipin > --- > Changes in v2: > - Revert behavior change in hx8394_enable > - Mov

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 24, 2025 at 10:31 AM Laurent Pinchart wrote: > > On Mon, Mar 24, 2025 at 10:17:05AM -0700, Doug Anderson wrote: > > On Mon, Mar 24, 2025 at 9:40 AM Laurent Pinchart wrote: > > > On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrot

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 24, 2025 at 9:40 AM Laurent Pinchart wrote: > > On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrote: > > Hi Laurent, > > > > > > Read out and check the ID registers, so we can bail out if I2C > > > > communication does not work or if the device is unknown. > > > > > > Wha

Re: [PATCH] drm/panel: himax-hx8394: transition to mipi_dsi wrapped functions

2025-03-24 Thread Doug Anderson
Hi, On Sat, Mar 22, 2025 at 10:30 PM Tejas Vipin wrote: > > @@ -493,35 +481,28 @@ static int hx8394_enable(struct drm_panel *panel) > { > struct hx8394 *ctx = panel_to_hx8394(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > - int ret; > - > - re

Re: [PATCH v2] drm/panel: samsung-s6d7aa0: transition to mipi_dsi wrapped functions

2025-03-24 Thread Doug Anderson
Hi, On Wed, Mar 19, 2025 at 1:05 PM Doug Anderson wrote: > > Hi, > > On Wed, Mar 19, 2025 at 11:31 AM Tejas Vipin wrote: > > > > Changes the samsung-s6d7aa0 panel to use multi style functions for > > improved error handling. > > > > Signed-off-

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 17, 2025 at 7:33 AM Doug Anderson wrote: > > Hi, > > On Sat, Mar 15, 2025 at 1:17 PM Wolfram Sang > wrote: > > > > Do not create a custom directory in debugfs-root, but use the > > debugfs_init callback to create a custom directory at the given

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Tue, Mar 18, 2025 at 10:56 AM Doug Anderson wrote: > > Hi, > > On Tue, Mar 18, 2025 at 8:56 AM Wolfram Sang > wrote: > > > > Read out and check the ID registers, so we can bail out if I2C > > communication does not work or if the device is unknown. Teste

Re: [PATCH v4] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-24 Thread Doug Anderson
Hi, On Sat, Mar 15, 2025 at 11:25 AM Tejas Vipin wrote: > > Changes the novatek-nt36523 panel to use multi style functions for > improved error handling. > > Reviewed-by: Douglas Anderson > Signed-off-by: Tejas Vipin > --- > Changes in v4: > - Cleanup nt36523_prepare > > Link to v3: > http

Re: [PATCH v4] drm/panel/synaptics-r63353: Use _multi variants

2025-03-24 Thread Doug Anderson
Hi, On Tue, Mar 18, 2025 at 7:37 AM Anusha Srivatsa wrote: > > Move away from using deprecated API and use _multi > variants if available. Use mipi_dsi_msleep() > and mipi_dsi_usleep_range() instead of msleep() > and usleep_range() respectively. > > Used Coccinelle to find the _multi variant APIs

Re: [PATCH] drm/panel-edp: Add panel used by T14s Gen6 Snapdragon (OLED)

2025-03-20 Thread Doug Anderson
Hi, On Thu, Mar 20, 2025 at 6:47 AM Dmitry Baryshkov wrote: > > On Thu, Mar 20, 2025 at 12:47:09PM +, Christopher Obbard wrote: > > The Lenovo Thinkpad T14s Gen6 Snapdragon OLED model has a Samsung > > panel. The kernel currently prints a warning due to not having the > > correct timings. > >

Re: [PATCH v2] drm/panel: samsung-s6d7aa0: transition to mipi_dsi wrapped functions

2025-03-19 Thread Doug Anderson
Hi, On Wed, Mar 19, 2025 at 11:31 AM Tejas Vipin wrote: > > Changes the samsung-s6d7aa0 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > Changes in v2: > - Remove unnecessary early return in s6d7aa0_lock > - Remove redundant GPIO re

Re: [PATCH v3 1/2] dt-bindings: drm/bridge: Add no-hpd property

2025-03-18 Thread Doug Anderson
Hi, On Tue, Mar 18, 2025 at 8:50 AM Tomi Valkeinen wrote: > > Hi, > > On 12/03/2025 14:52, Dmitry Baryshkov wrote: > > On Wed, Mar 12, 2025 at 11:56:41AM +0530, Harikrishna Shenoy wrote: > >> > >> > >> On 05/02/25 19:03, Dmitry Baryshkov wrote: > >>> On Wed, Feb 05, 2025 at 12:52:52PM +0100, Krzy

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-18 Thread Doug Anderson
Hi, On Tue, Mar 18, 2025 at 8:56 AM Wolfram Sang wrote: > > Read out and check the ID registers, so we can bail out if I2C > communication does not work or if the device is unknown. Tested on a > Renesas GrayHawk board (R-Car V4M) by using a wrong I2C address and by > not enabling RuntimePM for t

Re: [PATCH] drm/panel: samsung-s6d7aa0: transition to mipi_dsi wrapped functions

2025-03-17 Thread Doug Anderson
Hi, On Sat, Mar 15, 2025 at 9:50 PM Tejas Vipin wrote: > > @@ -62,93 +62,66 @@ static void s6d7aa0_reset(struct s6d7aa0 *ctx) > msleep(50); > } > > -static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock) > +static void s6d7aa0_lock(struct s6d7aa0 *ctx, struct mipi_dsi_multi_context > *

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-17 Thread Doug Anderson
Hi, On Sat, Mar 15, 2025 at 2:00 AM Wolfram Sang wrote: > > Hi Doug, > > > Seems reasonable to me. I would probably put an error message in this > > case, though? I don't think regmap_read() necessarily prints an error > > so it would just be a mysterious failure for why things didn't probe, > >

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-17 Thread Doug Anderson
Hi, On Sat, Mar 15, 2025 at 1:17 PM Wolfram Sang wrote: > > Do not create a custom directory in debugfs-root, but use the > debugfs_init callback to create a custom directory at the given place > for the bridge. The new directory layout looks like this on a Renesas > GrayHawk-Single with a R-Car

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-14 Thread Doug Anderson
Hi, On Fri, Mar 14, 2025 at 3:42 PM Wolfram Sang wrote: > > From: Phong Hoang > > Add a check to the very first register access function when attaching a > bridge device, so we can bail out if I2C communication does not work. > > Signed-off-by: Phong Hoang > Signed-off-by: Jacopo Mondi > Revie

Re: [PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-14 Thread Doug Anderson
Hi, On Thu, Mar 13, 2025 at 9:47 PM Anusha Srivatsa wrote: > > @@ -181,24 +162,15 @@ static int r63353_panel_prepare(struct drm_panel *panel) > static int r63353_panel_deactivate(struct r63353_panel *rpanel) > { > struct mipi_dsi_device *dsi = rpanel->dsi; > - struct device *dev =

dri-devel@lists.freedesktop.org

2025-03-13 Thread Doug Anderson
Hi, On Mon, Mar 10, 2025 at 3:42 AM Damon Ding wrote: > > Add analogix_dpaux_wait_hpd_asserted() to help confirm the HPD state > before doing AUX transfers. > > Signed-off-by: Damon Ding > --- > .../drm/bridge/analogix/analogix_dp_core.c| 21 +++ > 1 file changed, 21 inserti

Re: [PATCH v8 06/13] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus

2025-03-13 Thread Doug Anderson
Hi, On Mon, Mar 10, 2025 at 3:42 AM Damon Ding wrote: > > The main modification is moving the DP AUX initialization from function > analogix_dp_bind() to analogix_dp_probe(). In order to get the EDID of > eDP panel during probing, it is also needed to advance PM operations to > ensure that eDP co

Re: [PATCH v8 08/13] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-03-13 Thread Doug Anderson
Hi, On Mon, Mar 10, 2025 at 3:42 AM Damon Ding wrote: > > Move drm_of_find_panel_or_bridge() a little later and combine it with > component_add() into a new function rockchip_dp_link_panel(). The function > will serve as done_probing() callback of devm_of_dp_aux_populate_bus(), > aiding to suppor

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 5:00 PM Anusha Srivatsa wrote: > > > > On Wed, Mar 12, 2025 at 11:48 AM Doug Anderson wrote: >> >> Hi, >> >> On Wed, Mar 12, 2025 at 8:06 AM Anusha Srivatsa wrote: >> > >> >> > @@ -106,53 +107,46 @@ st

Re: [PATCH] drm/bridge: anx7625: Remove redundant 'flush_workqueue()' calls

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 2:02 AM Chen Ni wrote: > > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > - flu

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 8:06 AM Anusha Srivatsa wrote: > >> > @@ -106,53 +107,46 @@ static int r63353_panel_power_off(struct >> > r63353_panel *rpanel) >> > static int r63353_panel_activate(struct r63353_panel *rpanel) >> > { >> > struct mipi_dsi_device *dsi = rpanel->dsi; >> > -

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-12 Thread Doug Anderson
Hi, On Wed, Mar 12, 2025 at 7:54 AM Anusha Srivatsa wrote: > >> > @@ -78,7 +79,7 @@ static int r63353_panel_power_on(struct r63353_panel >> > *rpanel) >> > return ret; >> > } >> > >> > - usleep_range(15000, 25000); >> > + mipi_dsi_usleep_range(&dsi_ctx, 15000,

Re: [PATCH v3] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-11 Thread Doug Anderson
Hi, On Sat, Mar 8, 2025 at 8:04 PM Tejas Vipin wrote: > > Changes the novatek-nt36523 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > Changes in v3: > - Remove mipi_dsi_dual_msleep > - Change mipi_dsi_dual_dcs_write_seq_multi to us

Re: [PATCH v2] drm/panel/synaptics-r63353: Use _multi variants

2025-03-11 Thread Doug Anderson
Hi, On Mon, Mar 10, 2025 at 1:58 PM Anusha Srivatsa wrote: > > @@ -70,6 +70,7 @@ static int r63353_panel_power_on(struct r63353_panel > *rpanel) > { > struct mipi_dsi_device *dsi = rpanel->dsi; > struct device *dev = &dsi->dev; > + struct mipi_dsi_multi_context dsi_ctx = {

Re: [PATCH] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-06 Thread Doug Anderson
Hi, On Thu, Mar 6, 2025 at 11:03 AM Dmitry Baryshkov wrote: > > On Thu, 6 Mar 2025 at 18:44, Doug Anderson wrote: > > > > Hi, > > > > On Thu, Mar 6, 2025 at 8:33 AM Dmitry Baryshkov > > wrote: > > > > > > On Thu, Mar 06, 2025 at 03:05:10PM

Re: [PATCH] drm/panel/synaptics-r63353: Use _multi variants

2025-03-06 Thread Doug Anderson
Hi, On Thu, Mar 6, 2025 at 9:20 AM Maxime Ripard wrote: > > On Thu, Mar 06, 2025 at 10:08:24AM -0500, Anusha Srivatsa wrote: > > On Thu, Mar 6, 2025 at 4:31 AM Maxime Ripard wrote: > > > > > Hi Anusha, > > > > > > On Wed, Mar 05, 2025 at 07:01:41PM -0500, Anusha Srivatsa wrote: > > > > Move away

Re: [PATCH] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-06 Thread Doug Anderson
Hi, On Thu, Mar 6, 2025 at 8:33 AM Dmitry Baryshkov wrote: > > On Thu, Mar 06, 2025 at 03:05:10PM +0100, neil.armstr...@linaro.org wrote: > > On 06/03/2025 14:43, Tejas Vipin wrote: > > > Changes the novatek-nt36523 panel to use multi style functions for > > > improved error handling. > > > > > >

Re: [PATCH] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-06 Thread Doug Anderson
Hi, On Thu, Mar 6, 2025 at 6:05 AM wrote: > > On 06/03/2025 14:43, Tejas Vipin wrote: > > Changes the novatek-nt36523 panel to use multi style functions for > > improved error handling. > > > > Signed-off-by: Tejas Vipin > > --- > > drivers/gpu/drm/panel/panel-novatek-nt36523.c | 1683

Re: [PATCH v4 15/15] drm/bridge: ti-sn65dsi86: Use bridge_state crtc pointer

2025-02-28 Thread Doug Anderson
Hi, On Tue, Feb 25, 2025 at 8:44 AM Maxime Ripard wrote: > > The TI sn65dsi86 driver follows the drm_encoder->crtc pointer that is > deprecated and shouldn't be used by atomic drivers. > > This was due to the fact that we did't have any other alternative to > retrieve the CRTC pointer. Fortunatel

Re: [PATCH v4 3/8] drm/bridge: ti-sn65dsi86: use the auxiliary device

2025-02-25 Thread Doug Anderson
Hi, On Tue, Feb 18, 2025 at 11:30 AM Jerome Brunet wrote: > > The auxiliary device creation of this driver is simple enough to > use the available auxiliary device creation helper. > > Use it and remove some boilerplate code. > > Signed-off-by: Jerome Brunet > --- > drivers/gpu/drm/bridge/ti-sn

Re: [PATCH v7 10/15] drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > @@ -392,11 +393,27 @@ static const struct component_ops > rockchip_dp_component_ops = { > .unbind = rockchip_dp_unbind, > }; > > +static int rockchip_dp_link_panel(struct drm_dp_aux *aux) > +{ > + struct analogix_dp_plat_d

Re: [PATCH v7 03/15] drm/bridge: analogix_dp: Add irq flag IRQF_NO_AUTOEN instead of calling disable_irq()

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > The IRQF_NO_AUTOEN can be used for the drivers that don't want > interrupts to be enabled automatically via devm_request_threaded_irq(). > Using this flag can provide be more robust compared to the way of > calling disable_irq() after dev

Re: [PATCH v7 05/15] drm/bridge: analogix_dp: Remove CONFIG_PM related check in analogix_dp_bind()/analogix_dp_unbind()

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > Remove the check related to CONFIG_PM in order to make the code more > concise, as the CONFIG_PM should be a required option for many drivers. > > In addition, it is preferable to use devm_pm_runtime_enable() instead of > manually invokin

Re: [PATCH v7 09/15] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > The main modification is moving the DP AUX initialization from function > analogix_dp_bind() to analogix_dp_probe(). In order to get the EDID of > eDP panel during probing, it is also needed to advance PM operations to > ensure that eDP c

Re: [PATCH v7 04/15] drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: > > With the commit f37952339cc2 ("drm/bridge: analogix_dp: handle clock via > runtime PM"), the PM operations can help enable/disable the clock. The > err_disable_clk label and clk_disable_unprepare() operations are no > longer necessary bec

Re: [PATCH] drm/bridge: ti-sn65dsi86: Check for CONFIG_PWM using IS_REACHABLE()

2025-02-24 Thread Doug Anderson
Hi, On Mon, Feb 17, 2025 at 9:49 AM Uwe Kleine-König wrote: > > Currently CONFIG_PWM is a bool but I intend to change it to tristate. If > CONFIG_PWM=m in the configuration, the cpp symbol CONFIG_PWM isn't > defined and so the PWM code paths in the ti-sn65dsi86 driver are not > used. > > The corr

Re: [PATCH v2] drm/mipi-dsi: extend "multi" functions and use them in sony-td4353-jdi

2025-02-24 Thread Doug Anderson
Hi, On Wed, Feb 19, 2025 at 8:58 PM Tejas Vipin wrote: > > Removes mipi_dsi_dcs_set_tear_off and replaces it with a > multi version as after replacing it in sony-td4353-jdi, it doesn't > appear anywhere else. sony-td4353-jdi is converted to use multi style > functions, including mipi_dsi_dcs_set_

Re: [PATCH 2/2] drm/panel: sony-td4353-jdi: transition to mipi_dsi wrapped functions

2025-02-24 Thread Doug Anderson
Hi, On Fri, Feb 14, 2025 at 8:46 PM Tejas Vipin wrote: > > > > On 2/15/25 6:12 AM, Doug Anderson wrote: > > Hi, > > > > On Fri, Feb 14, 2025 at 9:30 AM Tejas Vipin wrote: > >> > >> Change the sony-td4353-jdi panel to use multi style functions fo

Re: [PATCH 00/20] drm/panel: Move to using mipi_dsi_*_multi() variants when available

2025-02-24 Thread Doug Anderson
Hi, On Tue, Feb 18, 2025 at 1:55 AM Maxime Ripard wrote: > > > I also questioned whether this really made sense to try to do with a > > Coccinelle script and I still don't think so. It looks like Dmitry has > > already reviewed the first few of your patches and has repeated my > > advice. If you

Re: [PATCH 1/2] drm/mipi-dsi: Replace mipi_dsi_dcs_set_tear_off with its multi version

2025-02-14 Thread Doug Anderson
Hi, On Fri, Feb 14, 2025 at 9:30 AM Tejas Vipin wrote: > > mipi_dsi_dcs_set_tear_off can heavily benefit from being converted > to a multi style function as it is often called in the context of > similar functions. Given that it has one caller, the wording "heavily benefit" and "often called" is

Re: [PATCH 2/2] drm/panel: sony-td4353-jdi: transition to mipi_dsi wrapped functions

2025-02-14 Thread Doug Anderson
Hi, On Fri, Feb 14, 2025 at 9:30 AM Tejas Vipin wrote: > > Change the sony-td4353-jdi panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > drivers/gpu/drm/panel/panel-sony-td4353-jdi.c | 107 -- > 1 file changed, 23 insertions(

Re: [PATCH v3 05/37] drm/bridge: Pass full state to atomic_post_disable

2025-02-14 Thread Doug Anderson
Hi, On Thu, Feb 13, 2025 at 6:44 AM Maxime Ripard wrote: > > It's pretty inconvenient to access the full atomic state from > drm_bridges, so let's change the atomic_post_disable hook prototype to > pass it directly. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Maxime Ripard >From the poi

Re: [PATCH v3 03/37] drm/bridge: Pass full state to atomic_enable

2025-02-14 Thread Doug Anderson
Hi, On Thu, Feb 13, 2025 at 6:44 AM Maxime Ripard wrote: > > It's pretty inconvenient to access the full atomic state from > drm_bridges, so let's change the atomic_enable hook prototype to pass it > directly. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Maxime Ripard >From the point of

Re: [PATCH v3 27/37] drm/bridge: Add encoder parameter to drm_bridge_funcs.attach

2025-02-14 Thread Doug Anderson
Hi, On Thu, Feb 13, 2025 at 6:45 AM Maxime Ripard wrote: > > The drm_bridge structure contains an encoder pointer that is widely used > by bridge drivers. This pattern is largely documented as deprecated in > other KMS entities for atomic drivers. > > However, one of the main use of that pointer

  1   2   3   4   5   6   7   8   9   10   >