Hi, On Thu, Mar 20, 2025 at 6:47 AM Dmitry Baryshkov <dmitry.barysh...@oss.qualcomm.com> wrote: > > On Thu, Mar 20, 2025 at 12:47:09PM +0000, Christopher Obbard wrote: > > The Lenovo Thinkpad T14s Gen6 Snapdragon OLED model has a Samsung > > panel. The kernel currently prints a warning due to not having the > > correct timings. > > > > This panel appears to work with the default conservative timings, > > so add the OLED panel to the list of supported panels with default > > timings. > > Are you sure that this panel can be handled by panel-edp.c correctly and > it doesn't require a workaround implemented in > panel-samsung-atna33xc20.c?
Yeah, I'd agree with Dmitry here. To the last person who wanted to add a Samsung OLED panel, I replied [1] It's much more likely that this should use the `panel-samsung-atna33xc20.c` driver, which gets the timings more correct for Samsung OLED panels (there's an extra GPIO it needs to manage). To use that driver, you'll actually just need to need to add a new compatible and use the existing one as a fallback. See recent changes to: Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml [1] https://lore.kernel.org/r/CAD=FV=X+WnSKZTFhzdXEFfpKCEqfPDc77h7oG=zu6nqq6xh...@mail.gmail.com
