Hi Dmitry,
On 2025/4/1 13:11, Dmitry Baryshkov wrote:
The analogix_dp_prepare_panel() returns immediately if there is no
attached panel. Drop several calls to this function which are performed
when dp->plat_data->panel is NULL.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/bridge/analo
On 2025/4/14 9:20, Damon Ding wrote:
Hi Dmitry,
On 2025/4/1 13:11, Dmitry Baryshkov wrote:
The analogix_dp_prepare_panel() returns immediately if there is no
attached panel. Drop several calls to this function which are performed
when dp->plat_data->panel is NULL.
Signed-off-by:
DRM_ERROR("failed to turnoff the panel\n");
- }
+ drm_panel_unprepare(dp->plat_data->panel);
drm_dp_aux_unregister(&dp->aux);
The patch has been verified with the eDP panel "lg,lp079qx1-sp0v" in
RK3588S EVB1 board.
Tested-by: Damon Ding
Best regards,
Damon
}
dp->fast_train_enable = false;
dp->psr_supported = false;
The patch has been verified with the eDP panel "lg,lp079qx1-sp0v" in
RK3588S EVB1 board.
Tested-by: Damon Ding
Best regards,
Damon
utex panel_lock;
-
struct analogix_dp_plat_data *plat_data;
};
The patch has been verified with the eDP panel "lg,lp079qx1-sp0v" in
RK3588S EVB1 board.
Tested-by: Damon Ding
Best regards,
Damon
panel_is_modeset;
struct analogix_dp_plat_data *plat_data;
};
The patch has been verified with the eDP panel "lg,lp079qx1-sp0v" in
RK3588S EVB1 board.
Tested-by: Damon Ding
Best regards,
Damon
lse);
if (ret)
DRM_ERROR("failed to setup the panel ret = %d\n", ret);
The patch has been verified with the eDP panel "lg,lp079qx1-sp0v" in
RK3588S EVB1 board.
Tested-by: Damon Ding
Best regards,
Damon
flag.
Suggested-by: Douglas Anderson
Reviewed-by: Douglas Anderson
Signed-off-by: Damon Ding
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b/drivers/gpu/drm/bridge/ana
-by: Damon Ding
---
Changes in v4:
- Use done_probing() to call drm_of_find_panel_or_bridge() and
component_add() when getting panel from the DP AUX bus
Changes in v5:
- Advance PM operations to make eDP AUX work well
Changes in v6:
- Use devm_pm_runtime_enable() instead of
get the panel from the DP AUX bus, it will then try the other
way to get panel information through the platform bus.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Damon Ding
---
Changes in v4:
- Use done_probing() to call drm_of_find_panel_or_bridge() and
component_add() when getting panel from
Hi Doug,
On 2025/2/25 9:42, Doug Anderson wrote:
Hi,
On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote:
@@ -392,11 +393,27 @@ static const struct component_ops
rockchip_dp_component_ops = {
.unbind = rockchip_dp_unbind,
};
+static int rockchip_dp_link_panel(struct drm_dp_aux
enable the eDP0 display on RK3588S EVB1 board.
Damon Ding (13):
drm/bridge: analogix_dp: Add irq flag IRQF_NO_AUTOEN instead of
calling disable_irq()
drm/bridge: analogix_dp: Remove CONFIG_PM related check in
analogix_dp_bind()/analogix_dp_unbind()
drm/bridge: analogix_dp: Add
Add support for the eDP0 output on RK3588 SoC.
Signed-off-by: Damon Ding
---
Changes in v3:
- Remove currently unsupported property '#sound-dai-cells'
Changes in v4:
- Remove currently unsupported clock 'spdif'
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 28 ++
igned-off-by: Damon Ding
---
Changes in v7:
- Use the forward-declare struct drm_dp_aux instead of including the
relevant header file.
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 14 ++
include/drm/bridge/analogix_dp.h | 4
2 files changed, 1
eviewed-by: Rob Herring (Arm)
Signed-off-by: Damon Ding
---
Changes in v2:
- Add the main defferences of the RK3588 eDP and the previous versions
in commit message
Changes in v3:
- Expand the property clock-names, resets and reset-names
Changes in v4:
- Remove 'spdif' clock which a
#x27;. And the newly added 'apb' reset control is to ensure the APB bus
of eDP controller works well on the RK3588 SoC.
Acked-by: Dmitry Baryshkov
Signed-off-by: Damon Ding
---
Changes in v2:
- Add support for the other eDP output edp1
Changes in v3:
- Fix the unexpected use of alia
202.02MHz.
Additionally, the 'force-hpd' is set for edp0 because the HPD pin on the
panel side is not connected to the eDP HPD pin on the SoC side according
to the RK3588S EVB1 hardware design.
Signed-off-by: Damon Ding
---
Changes in v2:
- Remove brightness-levels and default-brightness
Expand enum analogix_dp_devtype with RK3588_EDP, and add max_link_rate
and max_lane_count configs for it.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Damon Ding
---
Changes in v5:
- Add the RK3588_EDP related modification in analogix_dp.h
- Move this commit above related commit on the
Add analogix_dpaux_wait_hpd_asserted() to help confirm the HPD state
before doing AUX transfers.
Signed-off-by: Damon Ding
---
.../drm/bridge/analogix/analogix_dp_core.c| 21 +++
1 file changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix
According to Documentation/devicetree/bindings/display/dp-aux-bus.yaml,
it is a good way to get panel through the DP AUX bus.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Damon Ding
---
Changes in v4:
- Move the dt-bindings commit before related driver commits
Changes in v5:
- Remove the
Add support to configurate link rate, lane count, voltage swing and
pre-emphasis with phy_configure(). It is helpful in application scenarios
where analogix controller is mixed with the phy of other vendors.
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Damon Ding
---
Changes in v2:
- remove
-by: Douglas Anderson
Reviewed-by: Douglas Anderson
Signed-off-by: Damon Ding
---
.../drm/bridge/analogix/analogix_dp_core.c| 30 ---
1 file changed, 6 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b/drivers/gpu/drm/bridge
Hi Doug,
On 2025/2/25 9:41, Doug Anderson wrote:
Hi,
On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote:
The main modification is moving the DP AUX initialization from function
analogix_dp_bind() to analogix_dp_probe(). In order to get the EDID of
eDP panel during probing, it is also needed
ng probing.
Fixes: f37952339cc2 ("drm/bridge: analogix_dp: handle clock via runtime PM")
Suggested-by: Douglas Anderson
Reviewed-by: Douglas Anderson
Signed-off-by: Damon Ding
---
Picked from:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=936932
Changes in v8:
- Fix
Hi Doug,
On 2025/2/25 9:40, Doug Anderson wrote:
Hi,
On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote:
With the commit f37952339cc2 ("drm/bridge: analogix_dp: handle clock via
runtime PM"), the PM operations can help enable/disable the clock. The
err_disable_clk
Add two new functions: one to find &analogix_dp_device.plat_data via
&drm_dp_aux, and the other to get &analogix_dp_device.aux. Both of them
serve for the function of getting panel from DP AUX bus, which is why
they are included in a single commit.
Signed-off-by: Damon Ding
Reviewe
There are two main modifications: one is expanding struct
rockchip_dp_chip_data to an array, and the other is adding
&rockchip_dp_chip_data.reg to separate different edp devices.
Signed-off-by: Damon Ding
---
Changes in v6:
- Add the description of &rockchip_dp_chip_data.reg
-
ng probing.
Fixes: f37952339cc2 ("drm/bridge: analogix_dp: handle clock via runtime PM")
Signed-off-by: Damon Ding
---
.../gpu/drm/bridge/analogix/analogix_dp_core.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/a
-by: Damon Ding
---
.../drm/bridge/analogix/analogix_dp_core.c| 30 ---
1 file changed, 6 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index d9dafb038e7a..174e7011bba9
, add support for &drm_dp_aux.wait_hpd_asserted() to help
confirm the HPD state before doing AUX transfers.
Signed-off-by: Damon Ding
---
Changes in v4:
- Use done_probing() to call drm_of_find_panel_or_bridge() and
component_add() when getting panel from the DP AUX bus
Changes i
.
Patch 15is to enable the eDP0 display on RK3588S EVB1 board.
Damon Ding (15):
drm/rockchip: analogix_dp: Use formalized struct definition for grf
field
drm/rockchip: analogix_dp: Expand device data to support multiple edp
display
drm/bridge: analogix_dp: Add irq flag
The formalized struct definition will makes grf field operations more
concise and easier to extend.
Signed-off-by: Damon Ding
---
Changes in v2:
- Initialize struct rockchip_dp_chip_data rk3399_edp/rk3288_dp in order
of its members
Changes in v6:
- Pass 'dp' in drm_...() rathe
igned-off-by: Damon Ding
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index bfa88409a7ff..e23af674d91c 100644
Add support to configurate link rate, lane count, voltage swing and
pre-emphasis with phy_configure(). It is helpful in application scenarios
where analogix controller is mixed with the phy of other vendors.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
Changes in v2:
- remove
get the panel from the DP AUX bus, it will then try the other
way to get panel information through the platform bus.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
Changes in v4:
- Use done_probing() to call drm_of_find_panel_or_bridge() and
component_add() when getting panel from
Hi Piotr,
On 2025/2/14 20:00, Piotr Oniszczuk wrote:
Wiadomość napisana przez Sebastian Reichel w
dniu 13 lut 2025, o godz. 18:26:
Hello Piotr,
The RK3588 has two different DP controllers. The one handled in this
series should get the eDP port running, which is routed to the
"eDP Panel"
According to Documentation/devicetree/bindings/display/dp-aux-bus.yaml,
it is a good way to get panel through the DP AUX bus.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Damon Ding
---
Changes in v4:
- Move the dt-bindings commit before related driver commits
Changes in v5:
- Remove the
202.02MHz.
Additionally, the 'force-hpd' is set for edp0 because the HPD pin on the
panel side is not connected to the eDP HPD pin on the SoC side according
to the RK3588S EVB1 hardware design.
Signed-off-by: Damon Ding
---
Changes in v2:
- Remove brightness-levels and default-brightness
Expand enum analogix_dp_devtype with RK3588_EDP, and add max_link_rate
and max_lane_count configs for it.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
Changes in v5:
- Add the RK3588_EDP related modification in analogix_dp.h
- Move this commit above related commit on the
ned-off-by: Damon Ding
---
Changes in v2:
- Add the main defferences of the RK3588 eDP and the previous versions
in commit message
Changes in v3:
- Expand the property clock-names, resets and reset-names
Changes in v4:
- Remove 'spdif' clock which added in v3
- Add the comment
Add support for the eDP0 output on RK3588 SoC.
Signed-off-by: Damon Ding
---
Changes in v3:
- Remove currently unsupported property '#sound-dai-cells'
Changes in v4:
- Remove currently unsupported clock 'spdif'
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 28 ++
#x27;. And the newly added 'apb' reset control is to ensure the APB bus
of eDP controller works well on the RK3588 SoC.
Signed-off-by: Damon Ding
Acked-by: Dmitry Baryshkov
---
Changes in v2:
- Add support for the other eDP output edp1
Changes in v3:
- Fix the unexpected use of alia
Hi Heiko,
On 2025/1/31 4:33, Heiko Stübner wrote:
Hi Damon,
Am Donnerstag, 23. Januar 2025, 11:07:41 MEZ schrieb Damon Ding:
Move drm_of_find_panel_or_bridge() a little later and combine it with
component_add() into a new function rockchip_dp_link_panel(). The function
will serve as
Hi Lucas,
On 2025/2/8 3:42, Lucas Stach wrote:
Hi Damon,
Am Donnerstag, dem 23.01.2025 um 18:07 +0800 schrieb Damon Ding:
Move drm_of_find_panel_or_bridge() a little later and combine it with
component_add() into a new function rockchip_dp_link_panel(). The function
will serve as done_probing
On 2025/2/22 19:25, Damon Ding wrote:
Hi Heiko,
On 2025/1/31 4:33, Heiko Stübner wrote:
Hi Damon,
Am Donnerstag, 23. Januar 2025, 11:07:41 MEZ schrieb Damon Ding:
Move drm_of_find_panel_or_bridge() a little later and combine it with
component_add() into a new function rockchip_dp_link_panel
Hi Doug,
On 2025/1/24 11:13, Doug Anderson wrote:
Hi,
On Thu, Jan 23, 2025 at 3:25 AM Dmitry Baryshkov
wrote:
On Thu, Jan 23, 2025 at 06:07:40PM +0800, Damon Ding wrote:
The main modification is moving the DP AUX initialization from function
analogix_dp_bind() to analogix_dp_probe(). In
.
Damon Ding (2):
dt-bindings: display: rockchip: Fix label name of hdptxphy for RK3588
HDMI TX Controller
arm64: dts: rockchip: Fix label name of hdptxphy for RK3588
.../bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml | 2 +-
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP
and eDP Link. Therefore, it is better to name it hdptxphy0 other than
hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes.
Signed-off-by: Damon Ding
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP
and eDP Link. Therefore, it is better to name it hdptxphy0 other than
hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes.
Acked-by: Rob Herring (Arm)
Signed-off-by: Damon Ding
---
.../bindings/display
00 00 00 00 00 00 00 00 00 00 fe 00 4c
50 30 37 39 51 58 31 2d 53 50 30 56 00 00 00 fc
00 43 6f 6c 6f 72 20 4c 43 44 0a 20 20 20 00 3f
Signed-off-by: Damon Ding
---
Picked from:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=927765
changes in v7:
- Add &panel_delay.disable
Hi Doug,
On 2025/1/24 8:30, Doug Anderson wrote:
Hi,
On Thu, Jan 23, 2025 at 3:31 AM Dmitry Baryshkov
wrote:
On Thu, Jan 23, 2025 at 06:07:45PM +0800, Damon Ding wrote:
The raw edid for LP079QX1-SP0V panel model is:
00 ff ff ff ff ff ff 00 16 83 00 00 00 00 00 00
04 17 01 00 a5 10 0c 78
Hi Dmitry,
On 2025/1/23 19:32, Dmitry Baryshkov wrote:
On Thu, Jan 23, 2025 at 06:07:47PM +0800, Damon Ding wrote:
Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board:
- Set pinctrl of pwm12 for backlight
- Enable edp0/hdptxphy0/vp2
- Assign the parent of DCLK_VOP2_SRC to
Hi Dmitry,
On 2025/1/23 19:31, Dmitry Baryshkov wrote:
On Thu, Jan 23, 2025 at 06:07:45PM +0800, Damon Ding wrote:
The raw edid for LP079QX1-SP0V panel model is:
00 ff ff ff ff ff ff 00 16 83 00 00 00 00 00 00
04 17 01 00 a5 10 0c 78 06 ef 05 a3 54 4c 99 26
0f 50 54 00 00 00 01 01 01 01 01 01
Hi Rob,
On 2025/1/23 19:22, Rob Herring (Arm) wrote:
On Thu, 23 Jan 2025 18:07:42 +0800, Damon Ding wrote:
Compared with RK3288/RK3399, the HBR2 link rate support is the main
improvement of RK3588 eDP TX controller, and there are also two
independent eDP display interfaces on RK3588 Soc.
The
Hi Dmitry,
On 2025/1/23 19:19, Dmitry Baryshkov wrote:
On Thu, Jan 23, 2025 at 06:07:39PM +0800, Damon Ding wrote:
Add two new functions: one to find &analogix_dp_device.plat_data via
&drm_dp_aux, and the other to get &analogix_dp_device.aux. Both of them
serve for the functio
Add support for the eDP0 output on RK3588 SoC.
Signed-off-by: Damon Ding
---
Changes in v3:
- Remove currently unsupported property '#sound-dai-cells'
Changes in v4:
- Remove currently unsupported clock 'spdif'
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 28 ++
00 00 00 00 00 00 00 00 00 00 fe 00 4c
50 30 37 39 51 58 31 2d 53 50 30 56 00 00 00 fc
00 43 6f 6c 6f 72 20 4c 43 44 0a 20 20 20 00 3f
Signed-off-by: Damon Ding
---
drivers/gpu/drm/panel/panel-edp.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-edp.c
b
ned-off-by: Damon Ding
---
Changes in v2:
- Add the main defferences of the RK3588 eDP and the previous versions
in commit message
Changes in v3:
- Expand the property clock-names, resets and reset-names
Changes in v4:
- Remove 'spdif' clock which added in v3
- Add the comment
z.
Signed-off-by: Damon Ding
---
Changes in v2:
- Remove brightness-levels and default-brightness-level properties in
backlight node.
- Add the detail DT changes to commit message.
Changes in v3:
- Use aux-bus instead of platform bus for edp-panel.
Changes in v4:
- Add comments related to
#x27;. And the newly added 'apb' reset control is to ensure the APB bus
of eDP controller works well on the RK3588 SoC.
Signed-off-by: Damon Ding
---
Changes in v2:
- Add support for the other eDP output edp1
Changes in v3:
- Fix the unexpected use of alias
- Add more details in commit
get the panel from the DP AUX bus, it will then try the other
way to get panel information through the platform bus.
Signed-off-by: Damon Ding
---
Changes in v4:
- Use done_probing() to call drm_of_find_panel_or_bridge() and
component_add() when getting panel from the DP AUX bus
Changes in v5
The formalized struct definition will makes grf field operations more
concise and easier to extend.
Signed-off-by: Damon Ding
---
Changes in v2:
- Initialize struct rockchip_dp_chip_data rk3399_edp/rk3288_dp in order
of its members
Changes in v6:
- Pass 'dp' in drm_...() rathe
for panel model
LP079QX1-SP0V.
Patch 13is the addition of RK3588 eDP0 node.
Patch 14is to enable the eDP0 display on RK3588S EVB1 board.
Damon Ding (14):
drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...()
drm/rockchip: analogix_dp: Use formalized struct
Expand enum analogix_dp_devtype with RK3588_EDP, and add max_link_rate
and max_lane_count configs for it.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
Changes in v5:
- Add the RK3588_EDP related modification in analogix_dp.h
- Move this commit above related commit on the
, add a new function analogix_dp_remove() to ensure symmetry
for PM operations.
Signed-off-by: Damon Ding
---
Changes in v4:
- Use done_probing() to call drm_of_find_panel_or_bridge() and
component_add() when getting panel from the DP AUX bus
Changes in v5:
- Advance PM operations to make eDP
According to Documentation/devicetree/bindings/display/dp-aux-bus.yaml,
it is a good way to get panel through the DP AUX bus.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Damon Ding
---
Changes in v4:
- Move the dt-bindings commit before related driver commits
Changes in v5:
- Remove the
There are two main modifications: one is expanding struct
rockchip_dp_chip_data to an array, and the other is adding
&rockchip_dp_chip_data.reg to separate different edp devices.
Signed-off-by: Damon Ding
---
Changes in v6:
- Add the description of &rockchip_dp_chip_data.reg
-
Add support to configurate link rate, lane count, voltage swing and
pre-emphasis with phy_configure(). It is helpful in application scenarios
where analogix controller is mixed with the phy of other vendors.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
Changes in v2:
- remove
Add two new functions: one to find &analogix_dp_device.plat_data via
&drm_dp_aux, and the other to get &analogix_dp_device.aux. Both of them
serve for the function of getting panel from DP AUX bus, which is why
they are included in a single commit.
Signed-off-by: Damon Ding
Reviewe
According to the comments in include/drm/drm_print.h, the DRM_...()
functions are deprecated in favor of drm_...() or dev_...() functions.
Use drm_err()/drm_dbg_core()/drm_dbg_kms() instead of
DRM_DEV_ERROR()/DRM_ERROR()/DRM_DEV_DEBUG()/DRM_DEBUG_KMS().
Signed-off-by: Damon Ding
---
Changes
Hi Dmitry,
On 2025/1/22 16:17, Damon Ding wrote:
Hi Dmitry,
On 2025/1/9 20:48, Dmitry Baryshkov wrote:
On Thu, Jan 09, 2025 at 11:27:17AM +0800, Damon Ding wrote:
Move drm_of_find_panel_or_bridge() a little later and combine it with
component_add() into a new function rockchip_dp_link_panel
Hi Andy,
On 2025/1/11 18:28, Andy Yan wrote:
Hi Damon,
At 2025-01-09 11:27:25, "Damon Ding" wrote:
Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board:
- Set pinctrl of pwm12 for backlight
- Enable edp0/hdptxphy0/vp2
- Add aux-bus/panel nodes
Signed-off-by:
Hi Andy,
On 2025/1/9 14:28, Andy Yan wrote:
Hi Damon,
At 2025-01-09 11:27:10, "Damon Ding" wrote:
According to the comments in include/drm/drm_print.h, the DRM_...()
functions are deprecated in favor of drm_...() or dev_...() functions.
Use drm_err()/drm_dbg_core()/drm_dbg_kms()
Hi Dmitry,
On 2025/1/9 20:48, Dmitry Baryshkov wrote:
On Thu, Jan 09, 2025 at 11:27:17AM +0800, Damon Ding wrote:
Move drm_of_find_panel_or_bridge() a little later and combine it with
component_add() into a new function rockchip_dp_link_panel(). The function
will serve as done_probing
Hi Dmitry,
On 2025/1/9 20:45, Dmitry Baryshkov wrote:
On Thu, Jan 09, 2025 at 11:27:16AM +0800, Damon Ding wrote:
The main modification is moving the DP AUX initialization from function
analogix_dp_bind() to analogix_dp_probe(). In order to get the EDID of
eDP panel during probing, it is also
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP
and eDP Link. Therefore, it is better to name it hdptxphy0 other than
hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes.
Signed-off-by: Damon Ding
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP
and eDP Link. Therefore, it is better to name it hdptxphy0 other than
hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes.
Acked-by: Rob Herring (Arm)
Signed-off-by: Damon Ding
---
.../bindings/display
link rate are set according to the
eDP 1.3 requirements.
Signed-off-by: Damon Ding
---
Changes in v2:
- Add the module author
Changes in v3:
- Split this patch into two, one for correction and the other for
extension
Changes in v4:
- Add link_rate and lanes parameters in struct rk_hdptx_phy
Adding the '_MASK' suffix to all registers in order to ensures consistency
in the naming convention for register macros throughout the file.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
Changes in v4:
- Split the older patch related to the renaming of registers
Complete the register names of CMN_REG(0081) and CMN_REG(0087) to their
full version, and it can help to better match the datasheet.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 6 +++---
1 file changed, 3 insertions(+), 3
According to the datasheet, setting the dig_clk_sel bit of CMN_REG(0097)
to 1'b1 selects LCPLL as the reference clock, while setting it to 1'b0
selects the ROPLL.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 4 ++
Picked from:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593
These patchs have been tested with a 1536x2048p60 eDP panel on
RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified
on RK3588 EVB1 board.
Damon Ding (6):
phy: phy-rockchip-samsung-hdptx: Swap
Hi Dmitry,
On 2025/1/13 17:10, Dmitry Baryshkov wrote:
On Sun, Jan 12, 2025 at 05:07:08PM +0800, Damon Ding wrote:
Picked from:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593
Then it should have been v6, not v1.
I will update a patch series to fix it.
These
Hi Krzysztof,
On 2025/1/9 16:54, Krzysztof Kozlowski wrote:
On Thu, Jan 09, 2025 at 11:27:18AM +0800, Damon Ding wrote:
Compared with RK3288/RK3399, the HBR2 link rate support is the main
improvement of RK3588 eDP TX controller, and there are also two
independent eDP display interfaces on
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP
and eDP Link. Therefore, it is better to name it hdptxphy0 other than
hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes.
Signed-off-by: Damon Ding
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP
and eDP Link. Therefore, it is better to name it hdptxphy0 other than
hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes.
Acked-by: Rob Herring (Arm)
Signed-off-by: Damon Ding
---
.../bindings/display
link rate are set according to the
eDP 1.3 requirements.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
.../phy/rockchip/phy-rockchip-samsung-hdptx.c | 879 +-
1 file changed, 869 insertions(+), 10 deletions(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-samsung
Complete the register names of CMN_REG(0081) and CMN_REG(0087) to their
full version, and it can help to better match the datasheet.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 6 +++---
1 file changed, 3 insertions(+), 3
Adding the '_MASK' suffix to all registers in order to ensures consistency
in the naming convention for register macros throughout the file.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
.../phy/rockchip/phy-rockchip-samsung-hdptx.c | 88 +--
1 file c
According to the datasheet, setting the dig_clk_sel bit of CMN_REG(0097)
to 1'b1 selects LCPLL as the reference clock, while setting it to 1'b0
selects the ROPLL.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 4 ++
Picked from:
https://patchwork.kernel.org/project/linux-rockchip/list/?series=923593
These patchs have been tested with a 1536x2048p60 eDP panel on
RK3588S EVB1 board, and HDMI 1080P/4K display also has been verified
on RK3588 EVB1 board.
Damon Ding (6):
phy: phy-rockchip-samsung-hdptx: Swap
According to the datasheet, setting the dig_clk_sel bit of CMN_REG(0097)
to 1'b1 selects LCPLL as the reference clock, while setting it to 1'b0
selects the ROPLL.
Signed-off-by: Damon Ding
Reviewed-by: Dmitry Baryshkov
---
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 4 ++
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP
and eDP Link. Therefore, it is better to name it hdptxphy0 other than
hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes.
Acked-by: Rob Herring (Arm)
Signed-off-by: Damon Ding
---
.../bindings/display
Add two new functions: one to find &analogix_dp_device.plat_data via
&drm_dp_aux, and the other to get &analogix_dp_device.aux. Both of them
serve for the function of getting panel from DP AUX bus, which is why
they are included in a single commit.
Signed-off-by: Damon Ding
---
dri
The hdptxphy is a combo transmit-PHY for HDMI2.1 TMDS Link, FRL Link, DP
and eDP Link. Therefore, it is better to name it hdptxphy0 other than
hdptxphy_hdmi0, which will be referenced by both hdmi0 and edp0 nodes.
Signed-off-by: Damon Ding
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board:
- Set pinctrl of pwm12 for backlight
- Enable edp0/hdptxphy0/vp2
- Add aux-bus/panel nodes
Signed-off-by: Damon Ding
---
Changes in v2:
- Remove brightness-levels and default-brightness-level properties in
backlight node
Add support for the eDP0 output on RK3588 SoC.
Signed-off-by: Damon Ding
---
Changes in v3:
- Remove currently unsupported property '#sound-dai-cells'
Changes in v4:
- Remove currently unsupported clock 'spdif'
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 28 ++
Expand enum analogix_dp_devtype with RK3588_EDP, and add max_link_rate
and max_lane_count configs for it.
Signed-off-by: Damon Ding
---
Changes in v5:
- Add the RK3588_EDP related modification in analogix_dp.h
- Move this commit above related commit on the Rockchip side
---
drivers/gpu/drm
00 00 00 00 00 00 00 00 00 00 fe 00 4c
50 30 37 39 51 58 31 2d 53 50 30 56 00 00 00 fc
00 43 6f 6c 6f 72 20 4c 43 44 0a 20 20 20 00 3f
Signed-off-by: Damon Ding
---
drivers/gpu/drm/panel/panel-edp.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-edp.c
b
#x27;. And the newly added 'apb' reset control is to ensure the APB bus
of eDP controller works well on the RK3588 SoC.
Signed-off-by: Damon Ding
---
Changes in v2:
- Add support for the other eDP output edp1
Changes in v3:
- Fix the unexpected use of alias
- Add more details in commit
1 - 100 of 197 matches
Mail list logo
