RE: [PATCH v2 2/2] drm/bridge: adv7511: Rename adv7511_dsi_config_timing_gen() into adv7533_dsi_config_timing_gen()

2025-05-28 Thread Biju Das
naming convention rename > adv7511_dsi_config_timing_gen() into adv7533_dsi_config_timing_gen() > > Signed-off-by: Tommaso Merciai Reviewed-by: Biju Das Cheers, Biju > --- > v1->v2: > - New patch > > drivers/gpu/drm/bridge/adv7511/adv7511.h | 3 +-- > drivers/gpu/drm/bridge/

RE: [PATCH v2 1/2] drm/bridge: adv7511: Move adv711_dsi_config_timing_gen() into adv7511_mode_set()

2025-05-28 Thread Biju Das
ure the > horizontal and vertical > porch registers are correctly updated. > > Fixes: ae01d3183d2763ed ("drm/bridge: adv7511: switch to the HDMI connector > helpers") > Reported-by: Biju Das > Closes: https://lore.kernel.org/all/aDB8bD6cF7qiSpKd@tom-desktop/ > Sig

RE: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers

2025-05-26 Thread Biju Das
Hi Dmitry Baryshkov, > -Original Message- > From: Dmitry Baryshkov > Sent: 23 May 2025 07:37 > Subject: Re: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers > > Hi Biju > > On Fri, 23 May 2025 at 09:17, Biju Das wrote: > > > > Hi Dmit

RE: [PATCH] drm/bridge: adv7511: Do not merge adv7511_mode_set() with atomic_enable()

2025-05-26 Thread Biju Das
ct > behavior. > > Fixes: 0a9e2f0a6466 ("drm/bridge: adv7511: switch to the HDMI connector > helpers") > Reported-by: Biju Das > Closes: https://lore.kernel.org/all/aDB8bD6cF7qiSpKd@tom-desktop/ > Signed-off-by: Tommaso Merciai Reviewed-by: Biju Das The modetest sta

RE: [PATCH v2] drm: renesas: rz-du: Add atomic_pre_enable

2025-05-24 Thread Biju Das
IPI DSI > hardware to be already configured before the panel's prepare function is > called because it might need > to send DCS commands. > > Signed-off-by: Chris Brandt Reviewed-by: Biju Das Cheers, Biju > --- > v1->v2 > - Fixed alignment reported

RE: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers

2025-05-23 Thread Biju Das
Hi Dmitry Baryshkov, > -Original Message- > From: Dmitry Baryshkov > Sent: 23 May 2025 07:37 > Subject: Re: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers > > Hi Biju > > On Fri, 23 May 2025 at 09:17, Biju Das wrote: > > > > Hi Dmit

RE: (subset) [PATCH v6 00/10] drm/display: generic HDMI CEC helpers

2025-05-22 Thread Biju Das
Hi Dmitry Baryshkov, Thanks for the series. Looks like, After this patch, when I change resolution using modetest it is not working. Monitor is showing out of range/No signal on RZ/V2L SMARC EVK connected to ADV7535. Not sure, I am the only one facing this issue? Modetest works fine with 6.15

RE: [PATCH v3 0/2] drm: rcar-du: rzg2l_mipi_dsi: add MIPI DSI command support

2025-05-22 Thread Biju Das
Hi Hugo, Thanks for the patch. > -Original Message- > From: Hugo Villeneuve > Sent: 22 May 2025 15:39 > Subject: [PATCH v3 0/2] drm: rcar-du: rzg2l_mipi_dsi: add MIPI DSI command > support > > From: Hugo Villeneuve > > Hello, > this patch series add support for sending MIPI DSI comma

RE: [PATCH v3 0/2] drm: rcar-du: rzg2l_mipi_dsi: add MIPI DSI command support

2025-05-22 Thread Biju Das
Hi Hugo, > -Original Message- > From: Hugo Villeneuve > Sent: 22 May 2025 20:14 > Subject: Re: [PATCH v3 0/2] drm: rcar-du: rzg2l_mipi_dsi: add MIPI DSI > command support > > On Thu, 22 May 2025 18:40:29 + > Biju Das wrote: > > > Hi H

RE: [PATCH] drm: renesas: rz-du: Add atomic_pre_enable

2025-05-21 Thread Biju Das
Hi Chris Brandt, Thanks for the patch. > -Original Message- > From: Chris Brandt > Sent: 21 May 2025 15:24 > Subject: [PATCH] drm: renesas: rz-du: Add atomic_pre_enable > > When drm_panel.prepare_prev_first is set to true in a panel driver, the panel > expects the MIPI DSI > hardware t

RE: [PATCH v5 05/12] drm: renesas: rz-du: mipi_dsi: Use VCLK for HSFREQ calculation

2025-05-21 Thread Biju Das
; use correct scaling factors for better clarity and correctness. > > > > > > Since `clk_get_rate()` returns the clock rate in Hz, update the > > > HSFREQ threshold comparisons to use Hz instead of kHz to ensure > correct behavior. > > > > > > Co-deve

RE: [PATCH 1/2] drm: rcar-du: rzg2l_mipi_dsi: Implement host transfers

2025-05-21 Thread Biju Das
gt; Based on Renesas Linux kernel v5.10 repos [1]. > > Link: https://github.com/renesas-rz/rz_linux-cip.git > Cc: Biju Das > Cc: Chris Brandt > Signed-off-by: Hugo Villeneuve > --- > .../gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c| 174 ++ > .../drm/renesa

RE: [PATCH v5 1/4] clk: renesas: rzv2h-cpg: Add support for DSI clocks

2025-05-20 Thread Biju Das
Hi Geert, Stephen, > -Original Message- > From: Prabhakar > Sent: 12 May 2025 19:43 > Subject: [PATCH v5 1/4] clk: renesas: rzv2h-cpg: Add support for DSI clocks > > From: Lad Prabhakar > > Add support for PLLDSI and PLLDSI divider clocks. > > Introduce the `renesas-rzv2h-dsi.h` heade

RE: [PATCH] dt-bindings: display: bridge: renesas,dsi: allow properties from dsi-controller

2025-05-13 Thread Biju Das
Hi Hugo Villeneuve, Thanks for your patch. > -Original Message- > From: Hugo Villeneuve > Sent: 13 May 2025 17:23 > Subject: [PATCH] dt-bindings: display: bridge: renesas,dsi: allow properties > from dsi-controller > > From: Hugo Villeneuve > > Allow to inherit valid properties from

RE: [PATCH v5 07/12] drm: renesas: rz-du: mipi_dsi: Make "rst" reset control optional for RZ/V2H(P)

2025-05-12 Thread Biju Das
gt; Switching to devm_reset_control_get_optional_exclusive() ensures > compatibility with both SoCs that > provide this reset line and those that do not, such as RZ/V2H(P). > > Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das Cheers, Biju > --- > v4->v5: > - New patch > --

[PATCH] drm: rz-du: Support panels connected directly to the DPAD output

2025-05-08 Thread Biju Das
eate panel bridge instances. Signed-off-by: hienhuynh Signed-off-by: Biju Das --- .../gpu/drm/renesas/rz-du/rzg2l_du_encoder.c | 44 +-- 1 file changed, 40 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_encoder.c b/drivers/gpu/drm/ren

RE: [PATCH] drm/tegra: rgb: Fix the unbound reference count

2025-05-07 Thread Biju Das
Hi Thierry, > -Original Message- > From: Thierry Reding > Sent: 07 May 2025 17:00 > To: Biju Das > Subject: Re: [PATCH] drm/tegra: rgb: Fix the unbound reference count > > On Wed, Feb 05, 2025 at 11:21:35AM +, Biju Das wrote: > > The of_get_child_by_nam

RE: [PATCH v4 12/15] drm: renesas: rz-du: mipi_dsi: Add dphy_late_init() callback for RZ/V2H(P)

2025-05-04 Thread Biju Das
te_init` if defined, > ensuring SoC-specific > initialization is performed only when necessary. > > This change prepares for RZ/V2H(P) SoC support while maintaining > compatibility with existing > platforms. > > Co-developed-by: Fabrizio Castro > Signed-off-by: Fabrizio Castr

RE: [PATCH v4 14/15] drm: renesas: rz-du: mipi_dsi: Add support for LPCLK handling

2025-05-04 Thread Biju Das
if (dsi->info->features & RZ_MIPI_DSI_FEATURE_LPCLK) { > + dsi->lpclk = devm_clk_get(dsi->dev, "lpclk"); > + if (IS_ERR(dsi->lpclk)) > + return PTR_ERR(dsi->lpclk); > + } > + Can we use devm_clk_get_optional()

RE: [PATCH v4 13/15] drm: renesas: rz-du: mipi_dsi: Add function pointers for configuring VCLK and mode validation

2025-05-04 Thread Biju Das
es proper operation across different SoC variants by > allowing fine-grained control > over clock configuration and mode validation. > > Co-developed-by: Fabrizio Castro > Signed-off-by: Fabrizio Castro > Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das Cheers, Biju > --

RE: [PATCH v4 11/15] drm: renesas: rz-du: mipi_dsi: Add feature flag for 16BPP support

2025-05-04 Thread Biju Das
BPP formats. If the > SoC does not support 16BPP, return an error to prevent incorrect format > selection. > > This change enables finer-grained format support control for different SoC > variants. > > Co-developed-by: Fabrizio Castro > Signed-off-by: Fabrizio Castr

RE: [PATCH v4 10/15] drm: renesas: rz-du: mipi_dsi: Use mHz for D-PHY frequency calculations

2025-05-04 Thread Biju Das
astro > Signed-off-by: Lad Prabhakar Reviewed-by: Biju Das Cheers, Biju > --- > v3->v4: > - Used MILLI instead of KILO > - Made use of mul_u32_u32() for multiplication > > v2->v3: > - Replaced `unsigned long long` with `u64` > - Replaced *_mhz with *_millihz` i

RE: [PATCH v4 09/15] drm: renesas: rz-du: mipi_dsi: Add OF data support

2025-05-04 Thread Biju Das
return dev_err_probe(dsi->dev, PTR_ERR(dsi->rstc), > - "failed to get rst\n"); > + if (dsi->info->features & RZ_MIPI_DSI_FEATURE_DPHY_RST) { > + dsi->rstc = devm_reset_control_get_exclusive(dsi->dev,

RE: [PATCH v4 08/15] drm: renesas: rz-du: mipi_dsi: Use VCLK for HSFREQ calculation

2025-05-04 Thread Biju Das
hsfreq = (mode->clock * bpp) / dsi->lanes; > - > - ret = pm_runtime_resume_and_get(dsi->dev); > - if (ret < 0) > - return ret; > - > - clk_set_rate(dsi->vclk, mode->clock * 1000); > + vclk_rate = clk_get_rate(dsi->vclk);

RE: [PATCH v4 05/15] drm: renesas: rz-du: Add support for RZ/V2H(P) SoC

2025-05-01 Thread Biju Das
> - No changes > > v1->v2: > - Added enum for RZ/V2H as suggested by Krzysztof as the list > will grow in the future (while adding RZ/G3E SoC). > - Added Reviewed-by tag from Krzysztof. Looks this change log is not relevant here as it is related to bindings. Other

RE: [PATCH v4 03/15] dt-bindings: display: renesas,rzg2l-du: Add support for RZ/V2H(P) SoC

2025-05-01 Thread Biju Das
the > RZ/V2H(P) SoC. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Krzysztof Kozlowski > --- Change log is missing here. Otherwise LGTM. Reviewed-by: Biju Das Cheers, Biju > .../bindings/display/renesas,rzg2l-du.yaml| 23 ++- > 1 file changed

RE: [PATCH v3 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-04-19 Thread Biju Das
Hi Prabhakar, Thanks for the patch. > -Original Message- > From: Prabhakar > Sent: 18 April 2025 19:47 > Subject: [PATCH v3 15/15] drm: renesas: rz-du: mipi_dsi: Add support for > RZ/V2H(P) SoC > > From: Lad Prabhakar > > Add DSI support for Renesas RZ/V2H(P) SoC. > > Co-developed-b

RE: [PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for RZ/V2H(P) SoC

2025-04-12 Thread Biju Das
Hi Prabhakar, Thanks for the patch. > -Original Message- > From: Prabhakar > Sent: 08 April 2025 21:09 > Subject: [PATCH v2 15/15] drm: renesas: rz-du: mipi_dsi: Add support for > RZ/V2H(P) SoC > > From: Lad Prabhakar > > Add DSI support for Renesas RZ/V2H(P) SoC. > > Co-developed-b

[PATCH v2] drm: renesas: rz-du: rzg2l_mipi_dsi: Update the comment in rzg2l_mipi_dsi_start_video()

2025-04-11 Thread Biju Das
Add missing space in the comment in rzg2l_mipi_dsi_start_video(). Reported-by: Pavel Machek Closes: https://lore.kernel.org/all/zpg7sthdn4lbl...@duo.ucw.cz/ Signed-off-by: Biju Das Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- This issue is noticed while backporting this

RE: [PATCH] drm: renesas: Add zpos, alpha and blend properties to RZ/G2L DU

2025-04-07 Thread Biju Das
Hi Laurent, > -Original Message- > From: Laurent Pinchart > Sent: 04 April 2025 21:57 > Subject: Re: [PATCH] drm: renesas: Add zpos, alpha and blend properties to > RZ/G2L DU > > Hi Biju, > > Thank you for the patch. > > On Fri, Apr 04, 2025 at

RE: [PATCH v2 2/2] drm: renesas: Extend RZ/G2L supported KMS formats

2025-04-06 Thread Biju Das
Hi All, > -Original Message- > From: Biju Das > Sent: 30 March 2025 11:24 > Subject: [PATCH v2 2/2] drm: renesas: Extend RZ/G2L supported KMS formats > > From: Kieran Bingham > > The RZ/G2L driver utilises the VSPD to read data from input sources. > > Th

[PATCH v2 0/2] drm: renesas: Extend RZ/G2L KMS formats

2025-04-05 Thread Biju Das
ags * Dropped bpp entries. Biju Das (1): drm: renesas: rz-du: Drop bpp variable from struct rzg2l_du_format_info Kieran Bingham (1): drm: renesas: Extend RZ/G2L supported KMS formats drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 120 +-- drivers/gpu/drm/renesas/rz

[PATCH] drm: renesas: Add zpos, alpha and blend properties to RZ/G2L DU

2025-04-04 Thread Biju Das
rzg2l-du -w {32,37}:zpos:{0,1} Signed-off-by: Biju Das --- drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c index 8643ff2eec46..040d4e4aff00 100644

[PATCH v2 1/2] drm: renesas: rz-du: Drop bpp variable from struct rzg2l_du_format_info

2025-03-30 Thread Biju Das
Drop the unused variable bpp from struct rzg2l_du_format_info. Signed-off-by: Biju Das --- v2: * New patch. --- drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 --- drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/renesas/rz-du

[PATCH v2 2/2] drm: renesas: Extend RZ/G2L supported KMS formats

2025-03-30 Thread Biju Das
and send the image data to BRS(Blend ROP Sub Unit) for further processing. Signed-off-by: Kieran Bingham Signed-off-by: Biju Das Tested-by: Lad Prabhakar Reviewed-by: Laurent Pinchart --- v1->v2: * Updated commit description. * Collected tags * Dropped bpp entries. --- drivers/gpu/drm/rene

RE: [PATCH] drm: renesas: rz-du: Support dmabuf import

2025-03-26 Thread Biju Das
ation. This prevents importing > dmabufs. Fix it by > implementing the missing operation using the > DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE() helper macro. > > Signed-off-by: Laurent Pinchart Reviewed-by: Biju Das Cheers, Biju > --- > Kieran, would you be able to test

RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats

2025-03-22 Thread Biju Das
Hi Laurent, > -Original Message- > From: Biju Das > Sent: 22 March 2025 09:29 > Subject: RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats > > Hi Laurent, > > > -Original Message- > > From: Laurent Pinchart > > Sent: 21 March

RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats

2025-03-22 Thread Biju Das
Hi Kieran, Thanks for the patch. > -Original Message- > From: Kieran Bingham > Sent: 21 March 2025 19:06 > Subject: RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats > > Hi Biju, > > Quoting Biju Das (2025-03-21 18:40:50) > > Hi Kieran

RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats

2025-03-22 Thread Biju Das
Hi Laurent, > -Original Message- > From: Laurent Pinchart > Sent: 21 March 2025 22:33 > Subject: Re: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats > > Hi Kieran, > > Thank you for the patch. > > On Fri, Mar 21, 2025 at 05:22:19PM +, Kieran Bingham wrote: > > From: Kiera

RE: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats

2025-03-21 Thread Biju Das
Hi Kieran, Thanks for the patch. > -Original Message- > From: Kieran Bingham > Sent: 21 March 2025 17:22 > Subject: [PATCH] drm: renesas: Extend RZ/G2L supported KMS formats > > From: Kieran Bingham > > The RZ/G2L driver utilises the VSPD to read data from input sources. > > The rzg2

RE: [PATCH] drm/tegra: rgb: Fix the unbound reference count

2025-02-21 Thread Biju Das
Hi all, > -Original Message- > From: Biju Das > Sent: 05 February 2025 11:22 > Subject: [PATCH] drm/tegra: rgb: Fix the unbound reference count > > The of_get_child_by_name() increments the refcount in tegra_dc_rgb_probe, but > the driver does not > decrement th

[PATCH] drm/tegra: rgb: Fix the unbound reference count

2025-02-05 Thread Biju Das
The of_get_child_by_name() increments the refcount in tegra_dc_rgb_probe, but the driver does not decrement the refcount during unbind. Fix the unbound reference count using devm_add_action_or_reset() helper. Fixes: d8f4a9eda006 ("drm: Add NVIDIA Tegra20 support") Signed-off-by

RE: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-05 Thread Biju Das
Hi Geert, > -Original Message- > From: Geert Uytterhoeven > Sent: 05 February 2025 10:25 > Subject: Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe() > > Hi Biju, > > On Wed, 5 Feb 2025 at 11:20, Biju Das wrote: > > > -Original Message---

RE: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-05 Thread Biju Das
Hi Thierry Reding, > -Original Message- > From: Thierry Reding > Sent: 04 February 2025 18:02 > Subject: Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe() > > On Tue, Feb 04, 2025 at 03:33:53PM +, Biju Das wrote: > > Hi Thierry Reding, > &g

RE: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-04 Thread Biju Das
Hi Thierry Reding, > -Original Message- > From: Thierry Reding > Sent: 04 February 2025 15:25 > Subject: Re: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe() > > On Tue, Feb 04, 2025 at 09:07:05AM +, Biju Das wrote: > > Hi Geert, > &g

RE: [PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-04 Thread Biju Das
> On Sat, 1 Feb 2025 at 11:57, Biju Das wrote: > > Simplify tegra_dc_rgb_probe() by using of_get_available_child_by_name(). > > That's not the only thing this patch does... > > > > > Signed-off-by: Biju Das > > > --- a/drivers/gpu/drm/tegra/rgb.c &g

RE: [PATCH v2] of: base: Add of_get_available_child_by_name()

2025-02-04 Thread Biju Das
Hi Rob, > -Original Message- > From: Rob Herring > Sent: 03 February 2025 21:06 > Subject: Re: [PATCH v2] of: base: Add of_get_available_child_by_name() > > On Mon, Feb 3, 2025 at 11:17 AM Biju Das wrote: > > > > Hi Rob, > > > > +Cc relevant s

RE: [PATCH v2] of: base: Add of_get_available_child_by_name()

2025-02-03 Thread Biju Das
Hi Rob, +Cc relevant subsystems. > -Original Message- > From: Rob Herring > Sent: 03 February 2025 16:53 > Subject: Re: [PATCH v2] of: base: Add of_get_available_child_by_name() > > On Sat, Feb 1, 2025 at 3:31 AM Biju Das wrote: > > > >

[PATCH] drm/msm: Use of_get_available_child_by_name()

2025-02-01 Thread Biju Das
Simplify zap_shader_load_mdt() by using of_get_available_child_by_name(). Signed-off-by: Biju Das --- This patch is only compile tested and depend upon[1] [1] https://lore.kernel.org/all/20250201093126.7322-1-biju.das...@bp.renesas.com/ --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 4 ++-- 1

[PATCH] drm/tegra: rgb: Simplify tegra_dc_rgb_probe()

2025-02-01 Thread Biju Das
Simplify tegra_dc_rgb_probe() by using of_get_available_child_by_name(). Signed-off-by: Biju Das --- This patch is only compile tested and depend upon[1] [1] https://lore.kernel.org/all/20250201093126.7322-1-biju.das...@bp.renesas.com/ --- drivers/gpu/drm/tegra/rgb.c | 6 +++--- 1 file changed

RE: [PATCH v6 0/3] drm: adv7511: ADV7535 fixes

2024-12-12 Thread Biju Das
Hi Laurent, Thanks for the feedback. > -Original Message- > From: Laurent Pinchart > Sent: 09 December 2024 12:13 > Subject: Re: [PATCH v6 0/3] drm: adv7511: ADV7535 fixes > > Hi Biju, > > On Mon, Dec 09, 2024 at 08:29:40AM +, Biju Das wrote: > >

RE: [PATCH v2] drm/bridge: ite-it6263: Support VESA-24 input format

2024-12-09 Thread Biju Das
valid() and refactor the > it6263_bridge_atomic_get_input_bus_fmts() function to support VESA-24 format > by selecting the LVDS > input format based on the LVDS data mapping and thereby support both JEIDA-24 > and VESA-24 input > formats. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by:

RE: [PATCH v6 0/3] drm: adv7511: ADV7535 fixes

2024-12-09 Thread Biju Das
Hi All, Gentle ping to apply the series, if you are happy. > -Original Message- > From: Biju Das > Sent: 19 November 2024 18:44 > Subject: [PATCH v6 0/3] drm: adv7511: ADV7535 fixes > > This patch series aims to fix 2 bugs in the ADV7535 driver > >

RE: [PATCH] drm/bridge: ite-it6263: Support VESA input format

2024-12-05 Thread Biju Das
Hi Dmitry Baryshkov, > -Original Message- > From: Dmitry Baryshkov > Sent: 05 December 2024 11:43 > Subject: Re: [PATCH] drm/bridge: ite-it6263: Support VESA input format > > On Thu, 5 Dec 2024 at 11:01, Liu Ying wrote: > > > > On 12/04/2024, Bij

RE: [PATCH] drm/bridge: ite-it6263: Support VESA input format

2024-12-03 Thread Biju Das
Hi Liu Ying, > -Original Message- > From: Liu Ying > Sent: 04 December 2024 03:34 > To: tomm.merc...@gmail.com > Subject: Re: [PATCH] drm/bridge: ite-it6263: Support VESA input format > > On 12/04/2024, tomm.merc...@gmail.com wrote: > > From: Tommaso Merciai > > > > Introduce it6263_is_

RE: [PATCH] drm/bridge: ite-it6263: Support VESA input format

2024-12-03 Thread Biju Das
Hi Liu Ying, > -Original Message- > From: Liu Ying > Sent: 04 December 2024 03:43 > Subject: Re: [PATCH] drm/bridge: ite-it6263: Support VESA input format > > On 12/04/2024, Dmitry Baryshkov wrote: > > On Tue, Dec 03, 2024 at 06:21:29PM +0100, tomm.merc...@gmail.com wrote: > >> From: Tom

RE: hints around rcar_lvds.c :)

2024-11-26 Thread Biju Das
+ renesas-soc > -Original Message- > From: dri-devel On Behalf Of > Tommaso Merciai > Sent: 26 November 2024 10:15 > To: laurent.pinchart > Cc: Kieram Bingham ; David Airlie > ; Simona > Vetter ; dri-devel@lists.freedesktop.org; > linux-ker...@vger.kernel.org > Subject: hints around r

RE: [PATCH] drm: renesas: rz-du: Increase supported resolutions

2024-11-21 Thread Biju Das
ardware > manuals. > > Fixes: 768e9e61b3b9 ("drm: renesas: Add RZ/G2L DU Support") > Cc: sta...@vger.kernel.org > Signed-off-by: Chris Brandt Reviewed-by: Biju Das Cheers, Biju > --- > drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 6 +++--- > 1 file changed, 3 inserti

[PATCH v5 0/3] drm: adv7511: ADV7535 fixes

2024-11-20 Thread Biju Das
hit Taneja . Biju Das (3): drm: adv7511: Fix use-after-free in adv7533_attach_dsi() dt-bindings: display: adi,adv7533: Drop single lane support drm: adv7511: Drop dsi single lane support .../devicetree/bindings/display/bridge/adi,adv7533.yaml | 2 +- drivers/gpu/drm/bridge/adv7511/adv

[PATCH v7 2/3] dt-bindings: display: adi, adv7533: Drop single lane support

2024-11-20 Thread Biju Das
("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Acked-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Signed-off-by: Biju Das --- v6->v7: * No change. v5->v6: * No change. v4->v5: * No change. v3->v4: *

[PATCH v5 2/3] dt-bindings: display: adi, adv7533: Drop single lane support

2024-11-20 Thread Biju Das
("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Acked-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Signed-off-by: Biju Das --- v4->v5: * No change. v3->v4: * Added link to ADV7533 data sheet. * Collected

[PATCH v7 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
t;drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Reviewed-by: Laurent Pinchart Signed-off-by: Biju Das --- Changes in v7: - Dropped check for host_node as of_node_put() is a no-op when called with a NULL pointer. - Added Rb tag from Laurent. Changes in v6

[PATCH v7 0/3] drm: adv7511: ADV7535 fixes

2024-11-19 Thread Biju Das
hit Taneja . Biju Das (3): drm: adv7511: Fix use-after-free in adv7533_attach_dsi() dt-bindings: display: adi,adv7533: Drop single lane support drm: adv7511: Drop dsi single lane support .../bindings/display/bridge/adi,adv7533.yaml | 2 +- drivers/gpu/drm/bridge/adv7511/adv

[PATCH v7 3/3] drm: adv7511: Drop dsi single lane support

2024-11-19 Thread Biju Das
ridge: adv7533: Create a MIPI DSI device") Reported-by: Hien Huynh Cc: sta...@vger.kernel.org Reviewed-by: Laurent Pinchart Reviewed-by: Adam Ford Signed-off-by: Biju Das --- Changes in v7: - No change. Changes in v6: - Added Rb tag from Adam. Changes in v5: - No change. Changes in v4: -

RE: [PATCH v6 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
gt; On Tue, Nov 19, 2024 at 06:44:14PM +, Biju Das wrote: > > The host_node pointer was assigned and freed in adv7533_parse_dt(), > > and later, adv7533_attach_dsi() uses the same. Fix this use-after-free > > issue by dropping of_node_put() in adv7533_parse_dt() and calling >

[PATCH v6 3/3] drm: adv7511: Drop dsi single lane support

2024-11-19 Thread Biju Das
ridge: adv7533: Create a MIPI DSI device") Reported-by: Hien Huynh Cc: sta...@vger.kernel.org Reviewed-by: Laurent Pinchart Reviewed-by: Adam Ford Signed-off-by: Biju Das --- Changes in v6: - Added Rb tag from Adam. Changes in v5: - No change. Changes in v4: - Added link to ADV7533

[PATCH v6 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
t;drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Signed-off-by: Biju Das --- Changes in v6: - Fixed memory leak by adding goto stattement in error path of adv7511_init_regulators(). Changes in v5: - Updated commit description. - restored host_node in stru

[PATCH v6 2/3] dt-bindings: display: adi, adv7533: Drop single lane support

2024-11-19 Thread Biju Das
("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Acked-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Signed-off-by: Biju Das --- v5->v6: * No change. v4->v5: * No change. v3->v4: * Added link to

[PATCH v6 0/3] drm: adv7511: ADV7535 fixes

2024-11-19 Thread Biju Das
bindings and driver. changes in v2: - Added the tag "Cc: sta...@vger.kernel.org" in the sign-off area. - Dropped invalid Mail address Archit Taneja . Biju Das (3): drm: adv7511: Fix use-after-free in adv7533_attach_dsi() dt-bindings: display: adi,adv7533: Drop single lane support dr

RE: [PATCH v5 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
Hi Laurent, > -Original Message- > From: Laurent Pinchart > Sent: 19 November 2024 16:28 > Subject: Re: [PATCH v5 1/3] drm: adv7511: Fix use-after-free in > adv7533_attach_dsi() > > Hi Biju, > > Thank you for the patch. > > On Tue, Nov 19, 2024 at

[PATCH v5 3/3] drm: adv7511: Drop dsi single lane support

2024-11-19 Thread Biju Das
ridge: adv7533: Create a MIPI DSI device") Reported-by: Hien Huynh Cc: sta...@vger.kernel.org Reviewed-by: Laurent Pinchart Signed-off-by: Biju Das --- Changes in v5: - No change. Changes in v4: - Added link to ADV7533 data sheet. - Collected tags Changes in v3: - Updated commit

[PATCH v5 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
t;drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Signed-off-by: Biju Das --- Changes in v5: - Updated commit description. - restored host_node in struct adv7511. - Dropped of_node_put() in adv7533_parse_dt() and calling of_node_put() in error path of probe() a

RE: [PATCH v4 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-19 Thread Biju Das
you for the patch. > > On Sat, Nov 16, 2024 at 12:54:10PM +, Biju Das wrote: > > The host_node pointer was assigned and freed in adv7533_parse_dt(), > > and later, adv7533_attach_dsi() used the same. Fix this use-after-free > > issue with the below changes: > >

[PATCH v4 3/3] drm: adv7511: Drop dsi single lane support

2024-11-16 Thread Biju Das
ridge: adv7533: Create a MIPI DSI device") Reported-by: Hien Huynh Cc: sta...@vger.kernel.org Reviewed-by: Laurent Pinchart Signed-off-by: Biju Das --- Changes in v4: - Added link to ADV7533 data sheet. - Collected tags Changes in v3: - Updated commit header and description - Updated

[PATCH v4 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-16 Thread Biju Das
return the host_node. 3. Pass the host_node as a parameter to adv7533_attach_dsi(). 4. Call of_node_put() after use. Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Signed-off-by: Biju Das --- Changes in v4: - Updated commit d

[PATCH v4 2/3] dt-bindings: display: adi, adv7533: Drop single lane support

2024-11-16 Thread Biju Das
("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Acked-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Signed-off-by: Biju Das --- v3->v4: * Added link to ADV7533 data sheet. * Collected tags. v3:

[PATCH v4 0/3] drm: adv7511: ADV7535 fixes

2024-11-16 Thread Biju Das
l.org" in the sign-off area. - Dropped invalid Mail address Archit Taneja . Biju Das (3): drm: adv7511: Fix use-after-free in adv7533_attach_dsi() dt-bindings: display: adi,adv7533: Drop single lane support drm: adv7511: Drop dsi single lane support .../bindings/display/bridge/adi,ad

RE: [PATCH] drm/bridge: adv7533: Reset DSI receiver logic

2024-11-16 Thread Biju Das
tely I don't know. I have only used > AD7535 and therefore never > tested anything on ADV7533. > > > > >> > >> Signed-off-by: Stefan Ekenberg With and without the patch, display works on Renesas RZ/V2L SMARC board which is connected to ADV7535 device. Test

RE: [PATCH v2] drm/bridge: adv7511_audio: Update Audio InfoFrame properly

2024-11-16 Thread Biju Das
> Fixes: 53c515befe28 ("drm/bridge: adv7511: Add Audio support") With and without the patch, Audio works on Renesas RZ/V2L SMARC board. Tested-by: Biju Das > Signed-off-by: Stefan Ekenberg > --- > Changes in v2: > - Add Fixes tag > - Link to v1: > https://lore.

RE: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe()

2024-11-12 Thread Biju Das
supposed to return an error > code, but instead the > function continues and will crash on the next line. Add the missing return > statement. > > Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter") > Signed-off-by: Dan Carpenter Reviewed-by:

RE: [PATCH v6 7/7] arm64: defconfig: Enable ITE IT6263 driver

2024-11-12 Thread Biju Das
-LVDS-HDMI and > IMX-DLVDS-HDMI adapter cards. > The adapter cards can connect to i.MX8MP EVK base board to support video > output through HDMI > connectors. > Build the ITE IT6263 driver as a module. > > Signed-off-by: Liu Ying Reviewed-by: Biju Das Cheers, Biju > --

RE: [PATCH v3 3/3] drm: adv7511: Drop dsi single lane support

2024-11-07 Thread Biju Das
Hi Laurent, Thanks for the feedback. > -Original Message- > From: Laurent Pinchart > Sent: 06 November 2024 19:25 > Subject: Re: [PATCH v3 3/3] drm: adv7511: Drop dsi single lane support > > Hi Biju, > > Thank you for the patch. > > On Wed, Nov 06, 2024

RE: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support

2024-11-07 Thread Biju Das
Hi Geert, Thanks for the feedback. > -Original Message- > From: Geert Uytterhoeven > Sent: 06 November 2024 19:07 > Subject: Re: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single > lane support > > Hi Biju, > > On Wed, Nov 6, 2024 at 7:49 PM Bij

RE: [PATCH v3 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-07 Thread Biju Das
rhoeven wrote: > > Hi Biju, > > > > On Wed, Nov 6, 2024 at 7:49 PM Biju Das wrote: > > > The host_node pointer assigned and freed in adv7533_parse_dt() and > > > later adv7533_attach_dsi() uses the same. Fix this issue by freeing > > > the host_node in adv

RE: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support

2024-11-07 Thread Biju Das
gt; On Wed, Nov 06, 2024 at 06:49:29PM +, Biju Das wrote: > > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > > unsupported 1-lane from bindings. > > > > [1] > > https://www.analog.com/media/en/technical-documentation/data-sheets/AD > > V75

[PATCH v3 3/3] drm: adv7511: Drop dsi single lane support

2024-11-06 Thread Biju Das
org Signed-off-by: Biju Das --- Changes in v3: - Updated commit header and description - Updated fixes tag - Dropped single lane support Changes in v2: - Added the tag "Cc: sta...@vger.kernel.org" in the sign-off area. - Dropped Archit Taneja invalid Mail address --- drivers/gp

[PATCH v3 2/3] dt-bindings: display: adi, adv7533: Drop single lane support

2024-11-06 Thread Biju Das
As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop unsupported 1-lane from bindings. [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Signed-of

[PATCH v3 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-06 Thread Biju Das
;) Cc: sta...@vger.kernel.org Signed-off-by: Biju Das --- Changes in v3: - Replace __free construct with readable of_node_put(). Changes in v2: - Added the tag "Cc: sta...@vger.kernel.org" in the sign-off area. - Dropped Archit Taneja invalid Mail address --- drivers/gpu/drm/bridge/adv7511/adv75

[PATCH v3 0/3] drm: adv7511: ADV7535 fixes

2024-11-06 Thread Biju Das
"Cc: sta...@vger.kernel.org" in the sign-off area. - Dropped invalid Mail address Archit Taneja . Biju Das (3): drm: adv7511: Fix use-after-free in adv7533_attach_dsi() dt-bindings: display: adi,adv7533: Drop single lane support drm: adv7511: Drop dsi single lane support .../

RE: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

2024-11-06 Thread Biju Das
uot;drm/bridge: adv7533: Use internal timing > > generator") > > Reported-by: Hien Huynh > > Signed-off-by: Biju Das > > --- > > Changes in v2: > > - Added the tag "Cc: sta...@vger.kernel.org" in the sign-off area. > > - Dropped Archit Taneja invalid Mail address > > --- > > drivers/gpu/drm/bridge/adv7511/adv7533.c | 3 +++ > > 1 file changed, 3 insertions(+) > >

RE: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

2024-11-06 Thread Biju Das
Hi Laurent Pinchart, > -Original Message- > From: dri-devel On Behalf Of > Laurent Pinchart > Sent: 06 November 2024 13:18 > Subject: Re: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in > clock_div_by_lanes > > On Wed, Nov 06, 2024 at 10:20:43AM +

RE: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

2024-11-06 Thread Biju Das
. > > On Tue, Nov 05, 2024 at 11:12:19AM +, Biju Das wrote: > > Fix out-of-bounds array in adv7511_dsi_config_timing_gen(), when dsi > > lanes = 1. > > Does the hardware support using the internal timing generator with a single > lane ? If so As per the binding

RE: [PATCH v2 1/2] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-05 Thread Biju Das
n Tue, Nov 05, 2024 at 11:12:18AM +, Biju Das wrote: > > The host_node pointer assigned and freed in adv7533_parse_dt() and > > later adv7533_attach_dsi() uses the same. Fix this issue by freeing > > the host_node in adv7533_attach_dsi() instead of adv7533_parse_dt(). > >

[PATCH v2 1/2] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-05 Thread Biju Das
;) Cc: sta...@vger.kernel.org Signed-off-by: Biju Das --- Changes in v2: - Added the tag "Cc: sta...@vger.kernel.org" in the sign-off area. - Dropped Archit Taneja invalid Mail address --- drivers/gpu/drm/bridge/adv7511/adv7533.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dr

[PATCH 1/2] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-05 Thread Biju Das
The host_node pointer assigned and freed in adv7533_parse_dt() and later adv7533_attach_dsi() uses the same. Fix this issue by freeing the host_node in adv7533_attach_dsi() instead of adv7533_parse_dt(). Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Signed-off-by

[PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

2024-11-05 Thread Biju Das
Fix out-of-bounds array in adv7511_dsi_config_timing_gen(), when dsi lanes = 1. Fixes: 78fa479d703c ("drm/bridge: adv7533: Use internal timing generator") Reported-by: Hien Huynh Signed-off-by: Biju Das --- Changes in v2: - Added the tag "Cc: sta...@vger.kernel.org"

[PATCH v2 0/2] drm: adv7511: ADV7535 fixes

2024-11-05 Thread Biju Das
valid Mail address Archit Taneja . Biju Das (2): drm: adv7511: Fix use-after-free in adv7533_attach_dsi() drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes drivers/gpu/drm/bridge/adv7511/adv7533.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.43.0

[PATCH 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

2024-11-05 Thread Biju Das
Fix out-of-bounds array in adv7511_dsi_config_timing_gen() for clock_div_by_lanes[], when dsi lanes = 1. Fixes: 78fa479d703c ("drm/bridge: adv7533: Use internal timing generator") Reported-by: Hien Huynh Signed-off-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7533.c | 3 +

[PATCH 0/2] drm: adv7511: ADV7535 fixes

2024-11-05 Thread Biju Das
This patch series aims to fix 2 bugs in ADV7535 driver 1) use-after-free bug in adv7533_attach_dsi() 2) out-of-bounds array in adv7511_dsi_config_timing_gen() for clock_div_by_lanes[]. Biju Das (2): drm: adv7511: Fix use-after-free in adv7533_attach_dsi() drm: adv7511: Fix out-of-bounds

RE: [PATCH v4 00/13] Add ITE IT6263 LVDS to HDMI converter support

2024-10-30 Thread Biju Das
Baryshkov wrote: > > > On Mon, Oct 28, 2024 at 11:12:00AM +, Biju Das wrote: > > >> Hi Dmitry, Liu, > > >> > > >>> -Original Message- > > >>> From: Dmitry Baryshkov > > >>> Sent: 28 October 2024 10:20 &g

  1   2   3   4   5   6   7   >