Hi Rob, > -----Original Message----- > From: Rob Herring <r...@kernel.org> > Sent: 03 February 2025 21:06 > Subject: Re: [PATCH v2] of: base: Add of_get_available_child_by_name() > > On Mon, Feb 3, 2025 at 11:17 AM Biju Das <biju.das...@bp.renesas.com> wrote: > > > > Hi Rob, > > > > +Cc relevant subsystems. > > > > > -----Original Message----- > > > From: Rob Herring <r...@kernel.org> > > > Sent: 03 February 2025 16:53 > > > Subject: Re: [PATCH v2] of: base: Add > > > of_get_available_child_by_name() > > > > > > On Sat, Feb 1, 2025 at 3:31 AM Biju Das <biju.das...@bp.renesas.com> > > > wrote: > > > > > > > > There are lot of drivers using of_get_child_by_name() followed by > > > > of_device_is_available() to find the available child node by name > > > > for a given parent. Provide a helper for these users to simplify the > > > > code. > > > > > > > > Suggested-by: Geert Uytterhoeven <geert+rene...@glider.be> > > > > Signed-off-by: Biju Das <biju.das...@bp.renesas.com> > > > > > > Reviewed-by: Rob Herring <r...@kernel.org> > > > > > > > --- > > > > v1->v2: > > > > * Updated commit description. > > > > * Updated kerneldoc comment block > > > > * Avoided code duplication by using of_get_child_by_name(). > > > > > > > > Note: > > > > grep showed the below files will be the users for this new API. > > > > I will be updating these drivers once this patch is in mainline. > > > > > > No need to wait. Please convert all the net ones and send this patch with > > > them. > > > > Thanks for the feedback. > > > > Subsequently, I have send the patches. However, Andrew[1]/Krystoff[2] > > mentioned me to wait till this patch appear in -rc , > > > > Can it be fast tracked to 6.14-rcX?? Otherwise, it needs to wait till > > 6.15-rc1 and other patches will then appear on 6.16-rc1. > > Most maintainer trees are based on rc1. So are you sure everyone is going to > be fine with a rc2 > dependency? Generally, new APIs don't go in without a user.
From [1], looks like 'net' rebase on rcX for fixes and 'net-next' rebase on 'net'? [1] https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt > > That being said, if this was 10s of different trees I'd reconsider, but since > most of the callers are > in net, I'm less willing to apply "not a fix" to fixes. > > > [1] > > https://lore.kernel.org/all/96fbccd3-fd79-4b2f-8f41-bd0e3fdb2c69@lunn. > > ch/ > > > > [2] > > https://lore.kernel.org/all/7fe9dad9-85e2-4cf0-98bc-cca20ff62df5@kerne > > l.org/ > > It's not like they are saying to do the opposite of what I said. If the > dependency is not part of your > series, then it needs to be in rc1. OK. As you suggested, since 'net' is the main user of this API, I will send this patch along with other net patches, to net subsystem as net-next is open now. Cheers, Biju
