Hi Georgi,
On Wed, 2020-01-22 at 19:02 +0200, Georgi Djakov wrote:
> Hi Artur,
>
> On 12/20/19 13:56, Artur Świgoń wrote:
> > This patch adds interconnect functionality to the exynos-bus devfreq
> > driver.
> >
> > The SoC topology is a graph (or, more specif
Hi,
On Wed, 2020-01-22 at 18:54 +0200, Georgi Djakov wrote:
> Hi Artur,
>
> Thank you for your continuous work on this.
>
> On 12/20/19 13:56, Artur Świgoń wrote:
> > This patch adds the following properties to the Exynos4412 DT:
> > - exynos,interconnect-parent-n
On Tue, 2019-12-31 at 11:38 +0100, Krzysztof Kozlowski wrote:
> On Tue, 31 Dec 2019 at 11:23, Artur Świgoń wrote:
> > >
> > > The order of patches should reflect first of all real dependency.
> > > Whether it compiles, works at all and does not break anything. Log
On Tue, 2019-12-31 at 11:02 +0100, Krzysztof Kozlowski wrote:
> On Tue, Dec 31, 2019 at 10:41:47AM +0100, Artur Świgoń wrote:
> > On Tue, 2019-12-31 at 10:22 +0100, Krzysztof Kozlowski wrote:
> > > On Tue, Dec 31, 2019 at 08:18:01AM +0100, Artur Świgoń wrote:
> > > &g
On Tue, 2019-12-31 at 10:22 +0100, Krzysztof Kozlowski wrote:
> On Tue, Dec 31, 2019 at 08:18:01AM +0100, Artur Świgoń wrote:
> > Hi,
> >
> > On Mon, 2019-12-30 at 16:44 +0100, Krzysztof Kozlowski wrote:
> > > On Fri, Dec 20, 2019 at 12:56:50PM +0100, Artur Świgoń
Hi,
On Mon, 2019-12-30 at 16:44 +0100, Krzysztof Kozlowski wrote:
> On Fri, Dec 20, 2019 at 12:56:50PM +0100, Artur Świgoń wrote:
> > This patch adds the following properties to the Exynos4412 DT:
> > - exynos,interconnect-parent-node: to declare connections between
> >
Hi,
On Tue, 2019-12-24 at 13:56 +0900, Inki Dae wrote:
> Hi,
>
> 19. 12. 20. 오후 8:56에 Artur Świgoń 이(가) 쓴 글:
> > From: Marek Szyprowski
> >
> > This patch adds interconnect support to exynos-mixer. The mixer works
> > the same as before when CONFIG_INTERCONNECT
_get() with a NULL name simply
returns the right path.
Signed-off-by: Artur Świgoń
---
arch/arm/boot/dts/exynos4412.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi
b/arch/arm/boot/dts/exynos4412.dtsi
index 48868947373e..13a679a9a107 100644
--- a/arch/arm/
This patch relaxes the condition in of_icc_get_from_provider() so that it
is no longer required to set #interconnect-cells = <1> in the DT. In case
of the devfreq driver for exynos-bus, #interconnect-cells is always zero.
Signed-off-by: Artur Świgoń
Acked-by: Krzysztof Kozlowski
---
d
From: Marek Szyprowski
This patch adds interconnect support to exynos-mixer. The mixer works
the same as before when CONFIG_INTERCONNECT is 'n'.
Co-developed-by: Artur Świgoń
Signed-off-by: Artur Świgoń
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_mi
pled regulators patches.
* Use dev_pm_qos_*() API instead of overriding frequency in
exynos_bus_target().
* Use IDR for node ID allocation.
* Reverse order of multiplication and division in
mixer_set_memory_bandwidth() (patch 07) to avoid integer overflow.
---
Artur Świgoń
Samsung R&D Institu
always zero and node IDs are not
hardcoded anywhere.
Signed-off-by: Artur Świgoń
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index
an 'inter_set' field in struct
icc_provider. Setting it to 'true' enables calling '->set' for
inter-provider node pairs. All existing users of the interconnect
framework allocate this structure with kzalloc, and are therefore
unaffected.
Signed-off-by: Artur Świgoń
-
t an error when CONFIG_INTERCONNECT is 'n', in which case all
interconnect API functions are no-op.
Signed-off-by: Artur Świgoń
---
drivers/devfreq/exynos-bus.c | 144 +++
1 file changed, 144 insertions(+)
diff --git a/drivers/devfreq/exynos-bus.c b/dr
This patch makes the above function public (for use in exynos-bus devfreq
driver).
Signed-off-by: Artur Świgoń
Reviewed-by: Krzysztof Kozlowski
Reviewed-by: Chanwoo Choi
---
drivers/interconnect/core.c | 3 ++-
include/linux/interconnect-provider.h | 6 ++
2 files changed, 8
On Wed, 2019-12-18 at 19:29 +0900, Chanwoo Choi wrote:
> Hi
>
> 2019년 12월 18일 (수) 오후 7:18, Artur Świgoń 님이 작성:
> >
> > Hi,
> >
> > On Mon, 2019-12-16 at 11:59 +0900, Chanwoo Choi wrote:
> > > Hi,
> > >
> > > On 12/16/19 9:51 AM, C
Hi,
On Mon, 2019-12-16 at 11:59 +0900, Chanwoo Choi wrote:
> Hi,
>
> On 12/16/19 9:51 AM, Chanwoo Choi wrote:
> > On 9/19/19 11:22 PM, Artur Świgoń wrote:
> > > From: Artur Świgoń
> > >
> > > This patch adds two fields to the Exynos4412 DTS:
> &
On Wed, 2019-12-18 at 19:39 +0900, Chanwoo Choi wrote:
> Hi,
>
> 2019년 12월 18일 (수) 오후 7:19, Artur Świgoń 님이 작성:
> >
> > Hi,
> >
> > Thank you for the review.
> >
> > On Mon, 2019-12-16 at 09:44 +0900, Chanwoo Choi wrote:
> > > Hi
Hi,
Thank you for the review.
On Mon, 2019-12-16 at 09:44 +0900, Chanwoo Choi wrote:
> Hi,
>
> On 9/19/19 11:22 PM, Artur Świgoń wrote:
> > From: Artur Świgoń
> >
> > This patch adds interconnect functionality to the exynos-bus devfreq
> > driver.
> &g
status = "okay";
> };
>
> I'm not sure about continuing to use this method for new feature.
> If possible, hope to replace the existing binding style
> with new method like of_graph. Actually, I don't know the correct method.
>
>
> On 19. 9. 19. 오후
Hi,
On Fri, 2019-09-20 at 11:22 +0900, Chanwoo Choi wrote:
> Hi Artur,
>
> On 19. 9. 19. 오후 11:22, Artur Świgoń wrote:
> > From: Artur Świgoń
> >
> > This patch adds minor improvements to the exynos-bus driver.
> >
> > Signed-off-by: Artur Świgo
new method like of_graph. Actually, I don't know the correct method.
Adding the 'parent' binding was the simplest solution to create this
RFC to show the concept of using interconnect functionality in devfreq.
I agree that a method like of_graph is probably more elegant. I am ope
On Wed, 2019-09-25 at 15:37 +0900, Chanwoo Choi wrote:
> Hi,
>
> On 19. 9. 25. 오후 2:44, Artur Świgoń wrote:
> > Hi,
> >
> > On Fri, 2019-09-20 at 11:15 +0900, Chanwoo Choi wrote:
> > > Hi,
> > >
> > > As I already replied on v1, patc
On Wed, 2019-09-25 at 15:12 +0900, Chanwoo Choi wrote:
> Hi,
>
> On 19. 9. 25. 오후 2:47, Artur Świgoń wrote:
> > Hi,
> >
> > On Fri, 2019-09-20 at 11:14 +0900, Chanwoo Choi wrote:
> > > Hi Artur,
> > >
> > > I tried to just build this pat
; > the reply of reviewer and and keep the basic rule
> > of mailing contribution for discussion.
> >
> > On 19. 9. 19. 오후 11:22, Artur Świgoń wrote:
> > > The following patchset adds interconnect[1][2] framework support to the
> > > exynos-bus devfreq driver.
t 'exynos_bus_probe' is a new function).
Please take a look at the diff at the bottom of this message to see how patches
01..03 look when combined. If such patch looks acceptable to you, I can merge.
> On 19. 9. 19. 오후 11:22, Artur Świgoń wrote:
> > From: Artur Świgoń
>
From: Artur Świgoń
This patch adds a new static function, exynos_bus_profile_init_passive(),
extracted from exynos_bus_probe().
Signed-off-by: Artur Świgoń
---
drivers/devfreq/exynos-bus.c | 70 +---
1 file changed, 42 insertions(+), 28 deletions(-)
diff --git
From: Artur Świgoń
This patch adds interconnect functionality to the exynos-bus devfreq
driver.
The SoC topology is a graph (or, more specifically, a tree) and most of
its edges are taken from the devfreq parent-child hierarchy (cf.
Documentation/devicetree/bindings/devfreq/exynos-bus.txt). Due
From: Artur Świgoń
This patch adds minor improvements to the exynos-bus driver.
Signed-off-by: Artur Świgoń
Reviewed-by: Krzysztof Kozlowski
---
drivers/devfreq/exynos-bus.c | 66 ++--
1 file changed, 25 insertions(+), 41 deletions(-)
diff --git a/drivers
From: Artur Świgoń
This patch adds an 'interconnects' property to Exynos4412 DTS in order to
declare the interconnect path used by the mixer. Please note that the
'interconnect-names' property is not needed when there is only one path in
'interconnects', in which ca
From: Artur Świgoń
This patch adds a new static function, exynos_bus_profile_init(), extracted
from exynos_bus_probe().
Signed-off-by: Artur Świgoń
---
drivers/devfreq/exynos-bus.c | 92 +---
1 file changed, 53 insertions(+), 39 deletions(-)
diff --git a
From: Artur Świgoń
This patch relaxes the condition in of_icc_get_from_provider() so that it
is no longer required to set #interconnect-cells = <1> in the DT. In case
of the devfreq driver for exynos-bus, #interconnect-cells is always zero.
Signed-off-by: Artur Świgoń
Acked-by: Krz
From: Artur Świgoń
This patch makes the above function public (for use in exynos-bus devfreq
driver).
Signed-off-by: Artur Świgoń
Reviewed-by: Krzysztof Kozlowski
---
drivers/interconnect/core.c | 3 ++-
include/linux/interconnect-provider.h | 6 ++
2 files changed, 8
From: Artur Świgoń
This patch adds two fields to the Exynos4412 DTS:
- parent: to declare connections between nodes that are not in a
parent-child relation in devfreq;
- #interconnect-cells: required by the interconnect framework.
Please note that #interconnect-cells is always zero and
02 (cf. patch 04).
* Reverse order of multiplication and division in
mixer_set_memory_bandwidth() (patch 11) to avoid integer overflow.
---
Artur Świgoń
Samsung R&D Institute Poland
Samsung Electronics
---
References:
[1] Documentation/interconnect/interconnect.rst
[2] Documentation/d
From: Marek Szyprowski
This patch adds interconnect support to exynos-mixer. Please note that the
mixer works the same as before when CONFIG_INTERCONNECT is 'n'.
Co-developed-by: Artur Świgoń
Signed-off-by: Marek Szyprowski
Signed-off-by: Artur Świgoń
---
drivers/gpu/
From: Artur Świgoń
The exynos-bus devfreq driver is extended with interconnect functionality
by a subsequent patch. This patch removes a check from the interconnect
framework that prevents interconnect from working on exynos-bus, in which
every bus is a separate interconnect provider.
Signed
From: Artur Świgoń
This patch improves code readability by changing the following construct:
>if (cond)
>goto passive;
>foo();
>goto out;
>passive:
>bar();
>out:
into this:
>if (cond)
>bar();
>else
> fo
Hi,
On Wed, 2019-08-07 at 17:21 +0300, Georgi Djakov wrote:
> Hi Artur,
>
> On 8/1/19 10:59, Artur Świgoń wrote:
> > Hi Georgi,
> >
> > On Fri, 2019-07-26 at 11:05 +0300, Georgi Djakov wrote:
> > > Hi Artur,
> > >
> > > On 7/23/19 15:20, Ar
Hi,
Thank you for your comments.
On Tue, 2019-08-06 at 13:41 +, Leonard Crestez wrote:
> On 23.07.2019 15:21, Artur Świgoń wrote:
>
> > +static int exynos_bus_icc_aggregate(struct icc_node *node, u32 avg_bw,
> > + u32 peak_bw, u32 *agg_
Hi,
Thank you for your remarks. I will take them into account while preparing RFCv2.
On Mon, 2019-07-29 at 10:52 +0900, Chanwoo Choi wrote:
> Hi,
>
> On 19. 7. 23. 오후 9:20, Artur Świgoń wrote:
> > This patch adds interconnect functionality to the exynos-bus devfreq
> > dri
Hi,
On Wed, 2019-07-24 at 21:07 +0200, Krzysztof Kozlowski wrote:
> On Tue, Jul 23, 2019 at 02:20:06PM +0200, Artur Świgoń wrote:
> > This patch adds a new static function, exynos_bus_profile_init(), extracted
> > from exynos_bus_probe().
> >
> > Signed-off-by: Artur Ś
Hi Georgi,
On Fri, 2019-07-26 at 11:05 +0300, Georgi Djakov wrote:
> Hi Artur,
>
> On 7/23/19 15:20, Artur Świgoń wrote:
> > This patch adds interconnect functionality to the exynos-bus devfreq
> > driver.
> >
> > The SoC topology is a graph (or, more spec
On Wed, 2019-07-24 at 20:36 +0200, Krzysztof Kozlowski wrote:
> On Tue, Jul 23, 2019 at 02:20:14PM +0200, Artur Świgoń wrote:
> > This patch adds interconnect functionality to the exynos-bus devfreq
> > driver.
> >
> > The SoC topology is a graph (or, more specifical
On Wed, 2019-07-24 at 21:24 +0200, Krzysztof Kozlowski wrote:
> On Tue, Jul 23, 2019 at 02:20:13PM +0200, Artur Świgoń wrote:
> > This patch adds two fields tp the Exynos4412 DTS:
>
> tp->to
Fixed. Thanks for catching the typo :)
> > - parent: to declare connections be
code works equally well when
CONFIG_INTERCONNECT is 'n' (as in exynos_defconfig) in which case all
interconnect API functions are no-ops.
---
Artur Świgoń
Samsung R&D Institute Poland
Samsung Electronics
---
References:
[1] Documentation/interconnect/interconnect.rst
[2] Documentat
From: Marek Szyprowski
This patch adds interconnect support to exynos-mixer. Please note that the
mixer works the same as before when CONFIG_INTERCONNECT is 'n'.
Co-developed-by: Artur Świgoń
Signed-off-by: Artur Świgoń
Signed-off-by: Marek Szyprowski
---
drivers/gpu/
This patch adds a new static function, exynos_bus_profile_init_passive(),
extracted from exynos_bus_probe().
Signed-off-by: Artur Świgoń
---
drivers/devfreq/exynos-bus.c | 70 +---
1 file changed, 42 insertions(+), 28 deletions(-)
diff --git a/drivers/devfreq
This patch relaxes the condition in of_icc_get_from_provider() so that it
is no longer required to set #interconnect-cells = <1> in the DT. In case
of the devfreq driver for exynos-bus, #interconnect-cells is always zero.
Signed-off-by: Artur Świgoń
---
drivers/interconnect/core.c | 2
hardcoded anywhere.
Signed-off-by: Artur Świgoń
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 +
arch/arm/boot/dts/exynos4412.dtsi | 9 +
2 files changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
b/arch/arm/boot/dts/exynos4412
This patch adds a new static function, exynos_bus_profile_init(), extracted
from exynos_bus_probe().
Signed-off-by: Artur Świgoń
---
drivers/devfreq/exynos-bus.c | 106 ---
1 file changed, 60 insertions(+), 46 deletions(-)
diff --git a/drivers/devfreq/exynos
_get() with a NULL name simply
returns the right path.
Signed-off-by: Artur Świgoń
---
arch/arm/boot/dts/exynos4412.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi
b/arch/arm/boot/dts/exynos4412.dtsi
index a70a671acacd..faaec6c40412 100644
--- a/arch/arm/
This patch adds minor improvements to the exynos-bus driver.
Signed-off-by: Artur Świgoń
---
drivers/devfreq/exynos-bus.c | 49
1 file changed, 22 insertions(+), 27 deletions(-)
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index
This patch improves code readability by changing the following construct:
>if (cond)
>goto passive;
>foo();
>goto out;
>passive:
>bar();
>out:
into this:
>if (cond)
>bar();
>else
> foo();
Signed-off-by: Artur Św
API functions are no-op.
Signed-off-by: Artur Świgoń
---
drivers/devfreq/exynos-bus.c | 145 +++
1 file changed, 145 insertions(+)
diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index 412511ca7703..12fb7c84ae50 100644
--- a/drivers/devfre
This patch makes the above function public (for use in exynos-bus devfreq
driver).
Signed-off-by: Artur Świgoń
---
drivers/interconnect/core.c | 3 ++-
include/linux/interconnect-provider.h | 6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/interconnect
The exynos-bus devfreq driver is extended with interconnect functionality
by a subsequent patch. This patch removes a check from the interconnect
framework that prevents interconnect from working on exynos-bus, in which
every bus is a separate interconnect provider.
Signed-off-by: Artur Świgoń
57 matches
Mail list logo
