Re: [PATCH v1 1/1] drm/panel: ili9341: Remove unused member from struct ili9341

2025-06-04 Thread Neil Armstrong
Hi, On Mon, 19 May 2025 16:33:45 +0300, Andy Shevchenko wrote: > struct device *dev from struct ili9341 is not used anywhere, remove it. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/panel: ili9341: Remove unused member from struct ili9341

Re: (subset) [PATCH 0/4] Add DSI Panel for Gameforce Ace

2025-06-04 Thread Neil Armstrong
Hi, On Tue, 03 Jun 2025 14:39:26 -0500, Chris Morgan wrote: > From: Chris Morgan > > Add support for the DSI panel as found on the Gameforce Ace handheld > gaming console based on the RK3588s. > > Chris Morgan (4): > dt-bindings: vendor-prefixes: Add prefix for Huiling > dt-bindings: displa

Re: [PATCH 1/2] dt-bindings: display: simple: add AUO P238HAN01 panel

2025-06-04 Thread Neil Armstrong
Hi, On Tue, 20 May 2025 09:44:38 +0200, Michael Walle wrote: > Add AUO P238HAN01 23.8" 1920x1080 LVDS panel compatible string. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/2] dt-bindings: display: simple: add AUO P238HAN01 panel https://g

[PATCH] drm/xe: don't store the xe device pointer inside xe_ttm_tt

2025-06-04 Thread Dave Airlie
From: Dave Airlie This device pointer is nearly always available without storing an extra copy for each tt in the system. Just noticed this while reading over the xe shrinker code. Signed-off-by: Dave Airlie --- drivers/gpu/drm/xe/tests/xe_bo.c | 4 +-- drivers/gpu/drm/xe/xe_bo.c | 59

drm/ttm: port ttm pools to NUMA aware lru_list

2025-06-04 Thread Dave Airlie
(RH email ate this the first time). This is a bit of a tangent before continuing the tangent that is memcg aware pools. The pools code is already NUMA aware, but it rolls it's own numa awareness, and in order to move towards memcg awareness, I think a first step is porting the pool code to lru_

[PATCH 4/5] ttm/pool: make pool shrinker NUMA aware

2025-06-04 Thread Dave Airlie
From: Dave Airlie This enable NUMA awareness for the shrinker on the ttm pools. Cc: Christian Koenig Cc: Dave Chinner Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_pool.c | 35 +- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/drivers

[PATCH 5/5] ttm/pool: track allocated_pages per numa node.

2025-06-04 Thread Dave Airlie
From: Dave Airlie This gets the memory sizes from the nodes and stores the limit as 50% of those. I think eventually we should drop the limits once we have memcg aware shrinking, but this should be more NUMA friendly, and I think seems like what people would prefer to happen on NUMA aware systems

[PATCH 3/5] ttm/pool: drop numa specific pools

2025-06-04 Thread Dave Airlie
From: Dave Airlie The list_lru will now handle numa for us, so need to keep separate pool types for it. Just consoldiate into the global ones. This adds a debugfs change to avoid dumping non-existant orders due to this change. Cc: Christian Koenig Cc: Johannes Weiner Signed-off-by: Dave Airli

[PATCH 1/5] mm/list_lru: export list_lru_add.

2025-06-04 Thread Dave Airlie
From: Dave Airlie DRM/TTM wants to use this for it's page pool LRU tracking. This effective is a revert of 78c0ed09131b772f062b986a2fcca6600daa6285 Author: Kairui Song Date: Tue Nov 5 01:52:53 2024 +0800 mm/list_lru: don't export list_lru_add Cc: Kairui Song Cc: Johannes Weiner Cc: Sh

[PATCH 2/5] ttm/pool: port to list_lru.

2025-06-04 Thread Dave Airlie
From: Dave Airlie This is an initial port of the TTM pools for write combined and uncached pages to use the list_lru. This makes the pool's more NUMA aware and avoids needing separate NUMA pools (later commit enables this). Cc: Christian Koenig Cc: Johannes Weiner Cc: Dave Chinner Signed-off

drm/ttm: port ttm pools to NUMA aware lru_list

2025-06-04 Thread Dave Airlie
This is a bit of a tangent before continuing the tangent that is memcg aware pools. The pools code is already NUMA aware, but it rolls it's own numa awareness, and in order to move towards memcg awareness, I think a first step is porting the pool code to lru_list and making the current shrinker

[bug report] dma-buf: dma-buf: stop mapping sg_tables on attach v2

2025-06-04 Thread Dan Carpenter
Hello Christian König, Commit de68b17d5d07 ("dma-buf: dma-buf: stop mapping sg_tables on attach v2") from Feb 11, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/dma-buf/dma-buf.c:1123 dma_buf_map_attachment() warn: passing positive error code '16'

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-04 Thread Uwe Kleine-König
On Wed, Jun 04, 2025 at 11:09:15AM -0400, Alex Deucher wrote: > On Wed, Jun 4, 2025 at 10:55 AM Uwe Kleine-König > wrote: > > > > Hello Alex, > > > > On Wed, Jun 04, 2025 at 03:29:58PM +0200, Greg KH wrote: > > > On Wed, Jun 04, 2025 at 09:15:14AM -0400, Alex Deucher wrote: > > > > On Wed, Jun 4,

[PATCH 0/4] Integrate refcounting across of_drm_find_panel() callers

2025-06-04 Thread Anusha Srivatsa
++ 4 files changed, 6 insertions(+) --- base-commit: 685c407f168cb49a12cc703230d1e2d62767bfd2 change-id: 20250604-of_drm_find_panel_part1-33a2deb79256 Best regards, -- Anusha Srivatsa

[PATCH 2/4] drm/panel/samsung-dsicm: Keep up with refcounting

2025-06-04 Thread Anusha Srivatsa
Put the panel reference back when driver is no longer using it. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/bridge/samsung-dsim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 0014c497e3fe7d8349a11

[PATCH 4/4] drm/panel/exynos: Keep up with refcounting

2025-06-04 Thread Anusha Srivatsa
Put the panel reference back when driver is no longer using it. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada34cd

[PATCH 3/4] drm/panel/sun4i: Keep up with refcounting

2025-06-04 Thread Anusha Srivatsa
Put the panel reference back when driver is no longer using it. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index c35b70d83e53b739

[PATCH 1/4] drm/panel: get/put panel reference in drm_panel_add/remove()

2025-06-04 Thread Anusha Srivatsa
Take the panel reference and put it back as required. drm_panel_add() and drm_panel_remove() add a panel to the global registry and removes a panel respectively. Use get() and put() helpers to keep up with refcounting. Signed-off-by: Anusha Srivatsa --- drivers/gpu/drm/drm_panel.c | 2 ++ 1 file

Re: [PATCH 07/12] mm: Remove redundant pXd_devmap calls

2025-06-04 Thread Dan Williams
Alistair Popple wrote: > DAX was the only thing that created pmd_devmap and pud_devmap entries > however it no longer does as DAX pages are now refcounted normally and > pXd_trans_huge() returns true for those. Therefore checking both pXd_devmap > and pXd_trans_huge() is redundant and the former ca

Re: [PATCH 06/12] mm/gup: Remove pXX_devmap usage from get_user_pages()

2025-06-04 Thread Dan Williams
Alistair Popple wrote: > GUP uses pXX_devmap() calls to see if it needs to a get a reference on > the associated pgmap data structure to ensure the pages won't go > away. However it's a driver responsibility to ensure that if pages are > mapped (ie. discoverable by GUP) that they are not offlined o

Re: [PATCH 05/12] mm: Remove remaining uses of PFN_DEV

2025-06-04 Thread Dan Williams
Alistair Popple wrote: > PFN_DEV was used by callers of dax_direct_access() to figure out if the > returned PFN is associated with a page using pfn_t_has_page() or > not. However all DAX PFNs now require an assoicated ZONE_DEVICE page so can > assume a page exists. > > Other users of PFN_DEV were

Re: [PATCH 04/12] mm: Convert vmf_insert_mixed() from using pte_devmap to pte_special

2025-06-04 Thread Dan Williams
Alistair Popple wrote: > DAX no longer requires device PTEs as it always has a ZONE_DEVICE page > associated with the PTE that can be reference counted normally. Other users > of pte_devmap are drivers that set PFN_DEV when calling vmf_insert_mixed() > which ensures vm_normal_page() returns NULL fo

Re: [PATCH v4] drm: add overview diagram for drm stack

2025-06-04 Thread Bagas Sanjaya
On Wed, Jun 04, 2025 at 04:37:27PM +0200, Simona Vetter wrote: > On Mon, Jun 02, 2025 at 08:28:30AM +0700, Bagas Sanjaya wrote: > > On Sun, Jun 01, 2025 at 06:18:47PM -0400, Abdulrasaq Lawani wrote: > > > Add an overview diagram of Linux DRM architecture for > > > graphics and compute to introducti

Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk

2025-06-04 Thread Dan Williams
Alistair Popple wrote: > Previously dax pages were skipped by the pagewalk code as pud_special() or > vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are > refcounted normally that is no longer the case, so add explicit checks to > skip them. > > Signed-off-by: Alistair Pop

Re: [PATCH 00/12] mm: Remove pXX_devmap page table bit and pfn_t type

2025-06-04 Thread Dan Williams
Alistair Popple wrote: [..] > Alistair Popple (12): > mm: Remove PFN_MAP, PFN_SG_CHAIN and PFN_SG_LAST > mm: Convert pXd_devmap checks to vma_is_dax > mm/pagewalk: Skip dax pages in pagewalk > mm: Convert vmf_insert_mixed() from using pte_devmap to pte_special > mm: Remove remaining uses

Re: [PATCH 02/12] mm: Convert pXd_devmap checks to vma_is_dax

2025-06-04 Thread Dan Williams
Alistair Popple wrote: > Currently dax is the only user of pmd and pud mapped ZONE_DEVICE > pages. Therefore page walkers that want to exclude DAX pages can check > pmd_devmap or pud_devmap. However soon dax will no longer set PFN_DEV, > meaning dax pages are mapped as normal pages. > > Ensure pag

Re: [PATCH V1] accel/amdxdna: Fix incorrect PSP firmware size

2025-06-04 Thread Lizhi Hou
On 6/4/25 07:51, Alex Deucher wrote: On Wed, Jun 4, 2025 at 10:42 AM Lizhi Hou wrote: The incorrect PSP firmware size is used for initializing. It may cause error for newer version firmware. Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine") Signed-off-by: Lizhi Hou -

Re: [PATCH v3 1/3] mm/hugetlb: Make hugetlb_reserve_pages() return nr of entries updated

2025-06-04 Thread Andrew Morton
On Tue, 20 May 2025 22:19:35 -0700 Vivek Kasireddy wrote: > Currently, hugetlb_reserve_pages() returns a bool to indicate whether > the reservation map update for the range [from, to] was successful or > not. This is not sufficient for the case where the caller needs to > determine how many entr

Re: [PATCH] drm/xe: don't store the xe device pointer inside xe_ttm_tt

2025-06-04 Thread Matthew Brost
On Thu, Jun 05, 2025 at 08:35:40AM +1000, Dave Airlie wrote: > Just realised I hadn't cc'ed some people. > > ping, > > Dave. > > On Thu, 22 May 2025 at 05:48, Dave Airlie wrote: > > > > From: Dave Airlie > > > > This device pointer is nearly always available without storing > > an extra copy f

Re: [PATCH] drm/nouveau/bl: Use kasprintf for interface name

2025-06-04 Thread Jacob Keller
On 6/4/2025 3:40 PM, Timur Tabi wrote: > On Wed, 2025-06-04 at 15:16 -0700, Jacob Keller wrote: >> Fair enough. Another alternative which saves the stack and macro would >> be to add a new version of backlight_register_device which can pass the >> integer number itself into dev_set_name, but tha

Re: [PATCH] drm/nouveau/bl: Use kasprintf for interface name

2025-06-04 Thread Timur Tabi
On Wed, 2025-06-04 at 15:16 -0700, Jacob Keller wrote: > Fair enough. Another alternative which saves the stack and macro would > be to add a new version of backlight_register_device which can pass the > integer number itself into dev_set_name, but thats probably not worth > the churn either. (Curr

Re: [PATCH] drm/xe: don't store the xe device pointer inside xe_ttm_tt

2025-06-04 Thread Dave Airlie
Just realised I hadn't cc'ed some people. ping, Dave. On Thu, 22 May 2025 at 05:48, Dave Airlie wrote: > > From: Dave Airlie > > This device pointer is nearly always available without storing > an extra copy for each tt in the system. > > Just noticed this while reading over the xe shrinker co

Re: [PATCH] drm/nouveau/bl: Use kasprintf for interface name

2025-06-04 Thread Jacob Keller
On 6/4/2025 3:01 PM, Timur Tabi wrote: > On Wed, 2025-06-04 at 14:03 -0700, Jacob Keller wrote: >> This could also be fixed by simply increasing BL_NAME_SIZE to 24, making it >> large enough to fit any size integer into its format string, or by checking >> the return value of snprintf. > > I th

Re: [PATCH v2 2/3] drm/pagemap: Add a populate_mm op

2025-06-04 Thread Matthew Brost
On Wed, Jun 04, 2025 at 11:35:35AM +0200, Thomas Hellström wrote: > Add an operation to populate a part of a drm_mm with device > private memory. > With the kernel doc fixed: Reviewed-by: Matthew Brost > Signed-off-by: Thomas Hellström > --- > drivers/gpu/drm/drm_gpusvm.c | 7 ++- > dri

Re: [PATCH] drm/nouveau/bl: Use kasprintf for interface name

2025-06-04 Thread Timur Tabi
On Wed, 2025-06-04 at 14:03 -0700, Jacob Keller wrote: > This could also be fixed by simply increasing BL_NAME_SIZE to 24, making it > large enough to fit any size integer into its format string, or by checking > the return value of snprintf. I think this would be a better approach. backlist_name

RE: [PATCH v3 3/4] fbdev/deferred-io: Support contiguous kernel memory framebuffers

2025-06-04 Thread Michael Kelley
From: Michael Kelley Sent: Tuesday, June 3, 2025 10:25 AM > > From: David Hildenbrand Sent: Tuesday, June 3, 2025 12:55 > AM > > > > On 03.06.25 03:49, Michael Kelley wrote: > > > From: David Hildenbrand Sent: Monday, June 2, 2025 > > > 2:48 AM > > >> [snip] > > >>> @@ -182,20 +221,34 @@ st

RE: [PATCH v3 3/4] fbdev/deferred-io: Support contiguous kernel memory framebuffers

2025-06-04 Thread Michael Kelley
From: Simona Vetter Sent: Wednesday, June 4, 2025 7:46 AM > > On Wed, Jun 04, 2025 at 10:12:45AM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 03.06.25 um 19:50 schrieb Michael Kelley: > > > From: Thomas Zimmermann Sent: Monday, June 2, 2025 > > > 11:25 PM > > > > Hi > > > > > > > > Am 03.

Re: [PATCH v2 2/3] drm/pagemap: Add a populate_mm op

2025-06-04 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on drm-xe/drm-xe-next] [also build test ERROR on next-20250604] [cannot apply to linus/master v6.15] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH 01/12] mm: Remove PFN_MAP, PFN_SG_CHAIN and PFN_SG_LAST

2025-06-04 Thread Dan Williams
Alistair Popple wrote: > The PFN_MAP flag is no longer used for anything, so remove it. The > PFN_SG_CHAIN and PFN_SG_LAST flags never appear to have been used so > also remove them. > > Signed-off-by: Alistair Popple > Reviewed-by: Christoph Hellwig Looks good and I see PFN_DEV goes later in t

[PATCH] drm/nouveau/bl: Use kasprintf for interface name

2025-06-04 Thread Jacob Keller
free(backlight_name); if (IS_ERR(bl->dev)) { if (bl->id >= 0) ida_free(&bl_ida, bl->id); --- base-commit: 90b83efa6701656e02c86e7df2cb1765ea602d07 change-id: 20250604-jk-nouveua-drm-bl-snprintf-fix-c2ca525a3d2f Best regards, -- Jacob Keller

Re: [PATCH] MAINTAINERS: .mailmap: update Rob Clark's email address

2025-06-04 Thread Bjorn Andersson
On Wed, Jun 04, 2025 at 10:55:58AM -0700, Rob Clark wrote: > From: Rob Clark > > Remap historical email addresses to @oss.qualcomm.com. > > Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson Welcome, Bjorn > --- > .mailmap| 2 ++ > MAINTAINERS | 6 +++--- > 2 files changed, 5 insert

[pull] drm/msm: drm-msm-fixes-2025-06-04 for v6.16, the mailmap addition

2025-06-04 Thread Rob Clark
Hi Dave, Simona, Some mailmap/MAINTAINER "fixes", as there have been some recent email address changes and shufflings for drm/msm :-) The following changes since commit fc5c669c902c3039aa41731b6c58c0960d0b1bbf: dt-bindings: display: msm: correct example in SM8350 MDSS schema (2025-05-13 21:53:

Re: [PATCH] drm/amdgpu: fix NULL dereference in gfx_v9_0_kcq() and kiq_init_queue()

2025-06-04 Thread SDL
04.06.2025 22:34, Alex Deucher пишет: On Wed, Jun 4, 2025 at 3:30 PM SDL wrote: On Sat, May 24, 2025 at 2:14 AM Alexey Nepomnyashih wrote: A potential NULL pointer dereference may occur when accessing tmp_mqd->cp_hqd_pq_control without verifying that tmp_mqd is non-NULL. This may happen i

Re: [PATCH] MAINTAINERS: .mailmap: update Rob Clark's email address

2025-06-04 Thread Dmitry Baryshkov
On Wed, Jun 04, 2025 at 10:55:58AM -0700, Rob Clark wrote: > From: Rob Clark > > Remap historical email addresses to @oss.qualcomm.com. > > Signed-off-by: Rob Clark > --- > .mailmap| 2 ++ > MAINTAINERS | 6 +++--- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/.mailm

Re: [PATCH] drm/amdgpu: fix NULL dereference in gfx_v9_0_kcq() and kiq_init_queue()

2025-06-04 Thread Alex Deucher
On Wed, Jun 4, 2025 at 3:30 PM SDL wrote: > > > > On Sat, May 24, 2025 at 2:14 AM Alexey Nepomnyashih wrote: > >> A potential NULL pointer dereference may occur when accessing > >> tmp_mqd->cp_hqd_pq_control without verifying that tmp_mqd is non-NULL. > >> This may happen if mqd_backup[mqd_idx] i

Re: [PATCH] drm/amdgpu: fix NULL dereference in gfx_v9_0_kcq() and kiq_init_queue()

2025-06-04 Thread SDL
On Sat, May 24, 2025 at 2:14 AM Alexey Nepomnyashih wrote: A potential NULL pointer dereference may occur when accessing tmp_mqd->cp_hqd_pq_control without verifying that tmp_mqd is non-NULL. This may happen if mqd_backup[mqd_idx] is unexpectedly NULL. Although a NULL check for mqd_backup[mq

RE: [PATCH V8 32/43] drm/colorop: Add 1D Curve Custom LUT type

2025-06-04 Thread Shankar, Uma
> -Original Message- > From: Harry Wentland > Sent: Wednesday, June 4, 2025 1:57 AM > To: Pekka Paalanen ; Shankar, Uma > > Cc: Simon Ser ; Alex Hung ; dri- > de...@lists.freedesktop.org; amd-...@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; wayland-de...@lists.freedesktop

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-04 Thread Alex Deucher
On Wed, Jun 4, 2025 at 10:55 AM Uwe Kleine-König wrote: > > Hello Alex, > > On Wed, Jun 04, 2025 at 03:29:58PM +0200, Greg KH wrote: > > On Wed, Jun 04, 2025 at 09:15:14AM -0400, Alex Deucher wrote: > > > On Wed, Jun 4, 2025 at 5:40 AM Uwe Kleine-König > > > wrote: > > > > On Fri, May 30, 2025 at

Re: [PATCH v4 16/20] nova-core: Add support for VBIOS ucode extraction for boot

2025-06-04 Thread Joel Fernandes
On 6/2/2025 9:33 AM, Danilo Krummrich wrote: >> +/// Try to find NPDE in the data, the NPDE is right after the PCIR. >> +fn find_in_data( >> +pdev: &pci::Device, >> +data: &[u8], >> +rom_header: &PciRomHeader, >> +pcir: &PcirStruct, >> +) -> Option { >

Re: [PATCH v6 05/10] accel/rocket: Add a new driver for Rockchip's NPU

2025-06-04 Thread Robin Murphy
[ Since Daniel made me look... ] On 2025-06-04 8:57 am, Tomeu Vizoso wrote: [...] diff --git a/drivers/accel/rocket/Kconfig b/drivers/accel/rocket/Kconfig new file mode 100644 index ..9a59c6c61bf4d6460d8008b16331f001c97de67d --- /dev/null +++ b/drivers/ac

[PATCH] MAINTAINERS: .mailmap: update Rob Clark's email address

2025-06-04 Thread Rob Clark
From: Rob Clark Remap historical email addresses to @oss.qualcomm.com. Signed-off-by: Rob Clark --- .mailmap| 2 ++ MAINTAINERS | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.mailmap b/.mailmap index 6a6aa09e244b..b72a164280ea 100644 --- a/.mailmap +++ b/.mailm

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-04 Thread Dan Carpenter
On Wed, Jun 04, 2025 at 11:56:57AM -0300, Jason Gunthorpe wrote: > > A WARN_ON would be reasonable Or we could add a WARN_ON(). That's also fine. regards, dan carpenter

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-04 Thread Dan Carpenter
On Wed, Jun 04, 2025 at 04:54:43PM +0200, Simona Vetter wrote: > On Tue, Jun 03, 2025 at 07:29:52PM -0300, Jason Gunthorpe wrote: > > On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote: > > > > > > > > > On 26-05-2025 20:36, Dan Carpenter wrote: > > > > Hello Himal Prasad Ghim

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Matthew Brost
On Wed, Jun 04, 2025 at 06:53:44PM +0200, Danilo Krummrich wrote: > On Wed, Jun 04, 2025 at 09:45:00AM -0700, Matthew Brost wrote: > > On Wed, Jun 04, 2025 at 05:07:15PM +0200, Simona Vetter wrote: > > > We should definitely document this trick better though, I didn't find any > > > place where tha

Re: [PATCH v3 7/8] riscv: dts: thead: th1520: Add IMG BXM-4-64 GPU node

2025-06-04 Thread Matt Coster
On 03/06/2025 13:27, Ulf Hansson wrote: > On Fri, 30 May 2025 at 00:24, Michal Wilczynski > wrote: >> >> Add a device tree node for the IMG BXM-4-64 GPU present in the T-HEAD >> TH1520 SoC used by the Lichee Pi 4A board. This node enables support for >> the GPU using the drm/imagination driver. >>

Re: [PATCH v6 06/10] accel/rocket: Add IOCTL for BO creation

2025-06-04 Thread Robin Murphy
On 2025-06-04 5:18 pm, Daniel Stone wrote: Hi Tomeu, I have some bad news ... On Wed, 4 Jun 2025 at 08:57, Tomeu Vizoso wrote: +int rocket_ioctl_create_bo(struct drm_device *dev, void *data, struct drm_file *file) +{ + [...] + + /* This will map the pages to the IOMMU linked to co

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Danilo Krummrich
On Wed, Jun 04, 2025 at 09:45:00AM -0700, Matthew Brost wrote: > On Wed, Jun 04, 2025 at 05:07:15PM +0200, Simona Vetter wrote: > > We should definitely document this trick better though, I didn't find any > > place where that was documented. > > This is a good idea. I think - and I also mentione

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Matthew Brost
On Wed, Jun 04, 2025 at 05:07:15PM +0200, Simona Vetter wrote: > On Wed, Jun 04, 2025 at 11:41:25AM +0200, Christian König wrote: > > On 6/4/25 10:16, Philipp Stanner wrote: > > > struct drm_sched_init_args provides the possibility of letting the > > > scheduler use user-controlled workqueues, inst

Re: [PATCH v2] drm/ttm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Steven Rostedt
On Wed, 4 Jun 2025 12:38:37 -0400 Steven Rostedt wrote: > On Wed, 4 Jun 2025 09:26:21 -0700 (PDT) > Hugh Dickins wrote: > > > > Reviewed-by: Thomas Hellström > > > > Acked-by: Hugh Dickins > > Thanks Thomas and Hugh, > > Now the question is, who's gonna take it? ;-) Never mind, I se

Re: [PATCH v2] drm/ttm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Steven Rostedt
On Wed, 4 Jun 2025 09:26:21 -0700 (PDT) Hugh Dickins wrote: > > Reviewed-by: Thomas Hellström > > Acked-by: Hugh Dickins Thanks Thomas and Hugh, Now the question is, who's gonna take it? ;-) -- Steve

Re: [PATCH v2] drm/ttm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Hugh Dickins
On Wed, 4 Jun 2025, Thomas Hellström wrote: > On Wed, 2025-06-04 at 08:51 -0400, Steven Rostedt wrote: > > From: Steven Rostedt > > > > When CONFIG_SHMEM is not set, the following compiler error occurs: > > > > ld: vmlinux.o: in function `ttm_backup_backup_page': > > (.text+0x10363bc): undefined

Re: [PATCH v2 3/4] drm/dp: Add an EDID quirk for the DPCD register access probe

2025-06-04 Thread Imre Deak
On Wed, Jun 04, 2025 at 01:11:08PM +0300, Jani Nikula wrote: > On Tue, 03 Jun 2025, Imre Deak wrote: > > Reading DPCD registers has side-effects and some of these can cause a > > problem for instance during link training. Based on this it's better to > > avoid the probing quirk done before each DP

Re: [PATCH v2 2/4] drm/edid: Add support for quirks visible to DRM core and drivers

2025-06-04 Thread Imre Deak
On Wed, Jun 04, 2025 at 01:02:57PM +0300, Jani Nikula wrote: > On Wed, 04 Jun 2025, Imre Deak wrote: > > Add support for EDID based quirks which can be queried outside of the > > EDID parser iteself by DRM core and drivers. There are at least two such > > quirks applicable to all drivers: the DPCD

Re: [PATCH] drm/prime: remove drm_prime_lookup_buf_by_handle

2025-06-04 Thread Simona Vetter
On Wed, Jun 04, 2025 at 05:36:22PM +0200, Simona Vetter wrote: > On Wed, Jun 04, 2025 at 01:32:34PM +0200, Christian König wrote: > > This was added by Sima +10 years ago as a solution to avoid exporting > > multiple dma-bufs for the same GEM object. I tried to remove it before, > > but wasn't 100%

Re: [PATCH v6 06/10] accel/rocket: Add IOCTL for BO creation

2025-06-04 Thread Daniel Stone
Hi Tomeu, I have some bad news ... On Wed, 4 Jun 2025 at 08:57, Tomeu Vizoso wrote: > +int rocket_ioctl_create_bo(struct drm_device *dev, void *data, struct > drm_file *file) > +{ > + [...] > + > + /* This will map the pages to the IOMMU linked to core 0 */ > + sgt = drm_gem_sh

Re: [PATCH] accel/ivpu: Reorder doorbell unregister and command queue destruction

2025-06-04 Thread Jeff Hugo
On 6/4/2025 9:44 AM, Maciej Falkowski wrote: From: Karol Wachowski Refactor ivpu_cmdq_unregister() to ensure the doorbell is unregistered before destroying the command queue. The NPU firmware requires doorbells to be unregistered prior to command queue destruction. If doorbell remains register

[PATCH 1/3] drm/tests: Do not use drm_fb_blit() in format-helper tests

2025-06-04 Thread Thomas Zimmermann
Export additional helpers from the format-helper library and open-code drm_fb_blit() in tests. Prepares for the removal of drm_fb_blit(). Only sysfb drivers use drm_fb_blit(). The function will soon be removed from format helpers and be refactored within sysfb helpers. Signed-off-by: Thomas Zimmer

[PATCH 3/3] drm/format-helper: Move drm_fb_build_fourcc_list() to sysfb helpers

2025-06-04 Thread Thomas Zimmermann
Only sysfb drivers use drm_fb_build_fourcc_list(). Move the function to sysfb helpers and rename it accordingly. Update drivers and tests. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_format_helper.c | 138 -- drivers/gpu/drm/sysfb/drm_sysfb_helper.h |

[PATCH 2/3] drm/tests: Test drm_fb_build_fourcc_list() in separate test suite

2025-06-04 Thread Thomas Zimmermann
Only sysfb drivers use drm_fb_build_fourcc_list(). The helper will be moved from format helpers to sysfb helpers. Moving the related tests to their own test suite. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tests/Makefile| 3 +- .../gpu/drm/tests/drm_format_helper_tes

[PATCH 0/3] drm/tests: Update format-helper tests for sysfb

2025-06-04 Thread Thomas Zimmermann
The helpers drm_fb_blit() and drm_fb_build_fourcc_list() will be integrated into sysfb helpers. Update the DRM format-helper tests accordingly in patches 1 and 2. The change to drm_fb_build_fourcc_list() is simple enough that we can apply it here in patch 3. Thomas Zimmermann (3): drm/tests: Do

[PATCH] accel/ivpu: Reorder doorbell unregister and command queue destruction

2025-06-04 Thread Maciej Falkowski
From: Karol Wachowski Refactor ivpu_cmdq_unregister() to ensure the doorbell is unregistered before destroying the command queue. The NPU firmware requires doorbells to be unregistered prior to command queue destruction. If doorbell remains registered when command queue destroy command is sent f

Re: [PATCH v2 1/3] drm/gpusvm, drm/pagemap: Move migration functionality to drm_pagemap

2025-06-04 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on drm-xe/drm-xe-next] [also build test ERROR on next-20250604] [cannot apply to linus/master v6.15] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH] drm/prime: remove drm_prime_lookup_buf_by_handle

2025-06-04 Thread Simona Vetter
On Wed, Jun 04, 2025 at 01:32:34PM +0200, Christian König wrote: > This was added by Sima +10 years ago as a solution to avoid exporting > multiple dma-bufs for the same GEM object. I tried to remove it before, > but wasn't 100% sure about all the side effects. > > Now Thomas recent modified drm_g

Re: [PATCH] drm/sched: Discourage usage of separate workqueues

2025-06-04 Thread Simona Vetter
On Wed, Jun 04, 2025 at 11:41:25AM +0200, Christian König wrote: > On 6/4/25 10:16, Philipp Stanner wrote: > > struct drm_sched_init_args provides the possibility of letting the > > scheduler use user-controlled workqueues, instead of the scheduler > > creating its own workqueues. It's currently no

Re: [PATCH v2 3/3] drm/xe: Implement and use the drm_pagemap populate_mm op

2025-06-04 Thread Matthew Brost
On Wed, Jun 04, 2025 at 11:35:36AM +0200, Thomas Hellström wrote: > Add runtime PM since we might call populate_mm on a foreign device. I think taking a runtime PM will fix hard to hit splat [1] too. [1] https://patchwork.freedesktop.org/patch/648954/?series=147849&rev=1 > Also create the VRAM b

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-04 Thread Jason Gunthorpe
On Wed, Jun 04, 2025 at 04:54:43PM +0200, Simona Vetter wrote: > On Tue, Jun 03, 2025 at 07:29:52PM -0300, Jason Gunthorpe wrote: > > On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote: > > > > > > > > > On 26-05-2025 20:36, Dan Carpenter wrote: > > > > Hello Himal Prasad Ghim

[PATCH v4 0/1] drm: rcar-du: rzg2l_mipi_dsi: add MIPI DSI command support

2025-06-04 Thread Hugo Villeneuve
From: Hugo Villeneuve Hello, this patch series add support for sending MIPI DSI command packets to the Renesas RZ/G2L MIPI DSI driver. Tested on a custom board with a SolidRun RZ/G2L SOM, with two different LCD panels using the jd9365da and st7703 drivers. Tested short and long writes. Tested

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-04 Thread Uwe Kleine-König
Hello Alex, On Wed, Jun 04, 2025 at 03:29:58PM +0200, Greg KH wrote: > On Wed, Jun 04, 2025 at 09:15:14AM -0400, Alex Deucher wrote: > > On Wed, Jun 4, 2025 at 5:40 AM Uwe Kleine-König > > wrote: > > > On Fri, May 30, 2025 at 04:14:09PM -0400, Alex Deucher wrote: > > > > Already included in my -f

[PATCH v4 1/1] drm: renesas: rz-du: Implement MIPI DSI host transfers

2025-06-04 Thread Hugo Villeneuve
From: Hugo Villeneuve Add support for sending MIPI DSI command packets from the host to a peripheral. This is required for panels that need configuration before they accept video data. Also for long reads to work properly, set DCS maximum return packet size to the value of the DMA buffer size.

Re: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges

2025-06-04 Thread Simona Vetter
On Tue, Jun 03, 2025 at 07:29:52PM -0300, Jason Gunthorpe wrote: > On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote: > > > > > > On 26-05-2025 20:36, Dan Carpenter wrote: > > > Hello Himal Prasad Ghimiray, > > > > > > Commit 09ba0a8f06cd ("drm/xe/svm: Implement prefetch sup

Re: [PATCH V1] accel/amdxdna: Fix incorrect PSP firmware size

2025-06-04 Thread Alex Deucher
On Wed, Jun 4, 2025 at 10:42 AM Lizhi Hou wrote: > > The incorrect PSP firmware size is used for initializing. It may > cause error for newer version firmware. > > Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine") > Signed-off-by: Lizhi Hou > --- > drivers/accel/amdxdna/a

Re: [PATCH v4] drm: add overview diagram for drm stack

2025-06-04 Thread Simona Vetter
On Mon, Jun 02, 2025 at 08:28:30AM +0700, Bagas Sanjaya wrote: > On Sun, Jun 01, 2025 at 06:18:47PM -0400, Abdulrasaq Lawani wrote: > > Add an overview diagram of Linux DRM architecture for > > graphics and compute to introduction.rst > > > > Signed-off-by: Abdulrasaq Lawani > > --- > > ... > > d

Re: [PATCH v3 3/4] fbdev/deferred-io: Support contiguous kernel memory framebuffers

2025-06-04 Thread Simona Vetter
On Wed, Jun 04, 2025 at 10:12:45AM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.06.25 um 19:50 schrieb Michael Kelley: > > From: Thomas Zimmermann Sent: Monday, June 2, 2025 > > 11:25 PM > > > Hi > > > > > > Am 03.06.25 um 03:49 schrieb Michael Kelley: > > > [...] > > > > > Will the VMA have

Re: [PATCH v6 05/18] drm/imagination: Add power domain control

2025-06-04 Thread Ulf Hansson
On Thu, 10 Apr 2025 at 12:12, Matt Coster wrote: > > The first supported GPU only used a single power domain so this was > automatically handled by the device runtime. > > In order to support multiple power domains, they must be enumerated from > devicetree and linked to both the GPU device and ea

[PATCH V1] accel/amdxdna: Fix incorrect PSP firmware size

2025-06-04 Thread Lizhi Hou
The incorrect PSP firmware size is used for initializing. It may cause error for newer version firmware. Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine") Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_psp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH v3 7/8] riscv: dts: thead: th1520: Add IMG BXM-4-64 GPU node

2025-06-04 Thread Ulf Hansson
On Wed, 4 Jun 2025 at 14:40, Michal Wilczynski wrote: > > > > On 6/3/25 14:27, Ulf Hansson wrote: > > On Fri, 30 May 2025 at 00:24, Michal Wilczynski > > wrote: > >> > >> Add a device tree node for the IMG BXM-4-64 GPU present in the T-HEAD > >> TH1520 SoC used by the Lichee Pi 4A board. This nod

Re: [RFC PATCH 17/30] iommufd/device: Add TSM Bind/Unbind for TIO support

2025-06-04 Thread Aneesh Kumar K . V
Jason Gunthorpe writes: > On Tue, Jun 03, 2025 at 02:20:51PM +0800, Xu Yilun wrote: >> > Wouldn’t it be simpler to skip the reference count increment altogether >> > and just call tsm_unbind in the virtual device’s destroy callback? >> > (iommufd_vdevice_destroy()) >> >> The vdevice refcount is

Re: [PATCH v3 2/2] drm: renesas: rz-du: Set DCS maximum return packet size

2025-06-04 Thread Hugo Villeneuve
On Wed, 4 Jun 2025 12:08:49 + Chris Brandt wrote: Hi Chris, > Hi Hugo, > > Sorry, one more thing > > > + /* > > +* The default value of 1 will result in long read commands payload > > +* not being saved to memory. Set to the DMA buffer size. > > +*/ > > The comment is a

Re: [RFC PATCH 19/30] vfio/pci: Add TSM TDI bind/unbind IOCTLs for TEE-IO support

2025-06-04 Thread Aneesh Kumar K . V
Xu Yilun writes: > On Sun, Jun 01, 2025 at 04:15:32PM +0530, Aneesh Kumar K.V wrote: >> Xu Yilun writes: >> >> > Add new IOCTLs to do TSM based TDI bind/unbind. These IOCTLs are >> > expected to be called by userspace when CoCo VM issues TDI bind/unbind >> > command to VMM. Specifically for TDX

Re: [PATCH v3 2/2] drm: renesas: rz-du: Set DCS maximum return packet size

2025-06-04 Thread Hugo Villeneuve
On Wed, 4 Jun 2025 11:54:28 + Chris Brandt wrote: Hi Chris, > Hi Hugo, > > I'm fine with the code, but maybe it should go in a different location. > > Since it's a register setup, it should probably go in > rzg2l_mipi_dsi_startup() with the others. It makes sense, I will move it there.

Re: [RFC PATCH 17/30] iommufd/device: Add TSM Bind/Unbind for TIO support

2025-06-04 Thread Jason Gunthorpe
On Wed, Jun 04, 2025 at 02:10:43PM +0530, Aneesh Kumar K.V wrote: > Jason Gunthorpe writes: > > > On Tue, Jun 03, 2025 at 02:20:51PM +0800, Xu Yilun wrote: > >> > Wouldn’t it be simpler to skip the reference count increment altogether > >> > and just call tsm_unbind in the virtual device’s destro

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-04 Thread Greg KH
On Wed, Jun 04, 2025 at 09:15:14AM -0400, Alex Deucher wrote: > On Wed, Jun 4, 2025 at 5:40 AM Uwe Kleine-König > wrote: > > > > Hello Alex, > > > > On Fri, May 30, 2025 at 04:14:09PM -0400, Alex Deucher wrote: > > > On Fri, May 30, 2025 at 4:09 PM Aurabindo Pillai > > > wrote: > > > > > > > > Th

Re: [PATCH v2] drm/ttm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Thomas Hellström
On Wed, 2025-06-04 at 08:51 -0400, Steven Rostedt wrote: > From: Steven Rostedt > > When CONFIG_SHMEM is not set, the following compiler error occurs: > > ld: vmlinux.o: in function `ttm_backup_backup_page': > (.text+0x10363bc): undefined reference to `shmem_writeout' > make[3]: *** > [/work/bui

Re: [PATCH v3 6/8] riscv: dts: thead: Add GPU power sequencer node

2025-06-04 Thread Bartosz Golaszewski
On Tue, Jun 3, 2025 at 8:45 PM Michal Wilczynski wrote: > > > > On 6/3/25 15:22, Krzysztof Kozlowski wrote: > > On Fri, May 30, 2025 at 12:23:53AM GMT, Michal Wilczynski wrote: > >> Add the device tree node for the T-HEAD TH1520 GPU power sequencer > >> (gpu_pwrseq) to the th1520.dtsi file. > >> >

Re: [PATCH] Revert "drm/amd/display: more liberal vmin/vmax update for freesync"

2025-06-04 Thread Alex Deucher
On Wed, Jun 4, 2025 at 5:40 AM Uwe Kleine-König wrote: > > Hello Alex, > > On Fri, May 30, 2025 at 04:14:09PM -0400, Alex Deucher wrote: > > On Fri, May 30, 2025 at 4:09 PM Aurabindo Pillai > > wrote: > > > > > > This reverts commit 219898d29c438d8ec34a5560fac4ea8f6b8d4f20 since it > > > causes r

Re: [PATCH v7] drm/msm/dp: reuse generic HDMI codec implementation

2025-06-04 Thread Dmitry Baryshkov
On Tue, Jun 03, 2025 at 10:16:14PM +0800, Xilin Wu wrote: > On 2025/6/3 22:06:36, Dmitry Baryshkov wrote: > > On Thu, May 29, 2025 at 10:40:12AM +0800, Xilin Wu wrote: > > > On 2025/4/24 01:52:45, Dmitry Baryshkov wrote: > > > > From: Dmitry Baryshkov > > > > > > > > The MSM DisplayPort driver im

[PATCH v2] drm/ttm: Fix compile error when CONFIG_SHMEM is not set

2025-06-04 Thread Steven Rostedt
From: Steven Rostedt When CONFIG_SHMEM is not set, the following compiler error occurs: ld: vmlinux.o: in function `ttm_backup_backup_page': (.text+0x10363bc): undefined reference to `shmem_writeout' make[3]: *** [/work/build/trace/nobackup/linux.git/scripts/Makefile.vmlinux:91: vmlinux.unstrip

[PATCH v6 07/10] accel/rocket: Add job submission IOCTL

2025-06-04 Thread Tomeu Vizoso
Using the DRM GPU scheduler infrastructure, with a scheduler for each core. Userspace can decide for a series of tasks to be executed sequentially in the same core, so SRAM locality can be taken advantage of. The job submission code was initially based on Panfrost. v2: - Remove hardcoded number

Re: [PATCH v3 7/8] riscv: dts: thead: th1520: Add IMG BXM-4-64 GPU node

2025-06-04 Thread Michal Wilczynski
On 6/3/25 14:27, Ulf Hansson wrote: > On Fri, 30 May 2025 at 00:24, Michal Wilczynski > wrote: >> >> Add a device tree node for the IMG BXM-4-64 GPU present in the T-HEAD >> TH1520 SoC used by the Lichee Pi 4A board. This node enables support for >> the GPU using the drm/imagination driver. >>

Re: [PATCH v13 0/9] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-06-04 Thread Jeff Layton
On Tue, 2025-06-03 at 19:29 -0700, Jakub Kicinski wrote: > On Tue, 03 Jun 2025 07:27:11 -0400 Jeff Layton wrote: > > For those just joining in, this series adds a new top-level > > "ref_tracker" debugfs directory, and has each ref_tracker_dir register a > > file in there as part of its initializati

  1   2   >