Re: (subset) [PATCH V9 00/24] drm: sun4i: add Display Engine 3.3 (DE33) support

2025-05-09 Thread Chen-Yu Tsai
On Wed, 07 May 2025 15:19:19 -0500, Chris Morgan wrote: > From: Chris Morgan > > I've spoken with Ryan and he agreed to let me take over this series to > get the display engine working on the Allwinner H616. I've taken his > previous patch series for Display Engine 3.3 and combined it with the >

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-09 Thread Xu Yilun
On Fri, May 09, 2025 at 03:43:18PM -0300, Jason Gunthorpe wrote: > On Sat, May 10, 2025 at 12:28:48AM +0800, Xu Yilun wrote: > > On Fri, May 09, 2025 at 07:12:46PM +0800, Xu Yilun wrote: > > > On Fri, May 09, 2025 at 01:04:58PM +1000, Alexey Kardashevskiy wrote: > > > > Ping? > > > > > > Sorry for

Re: [PATCH v3 05/22] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > --- > > Cc: Ian Ray > Cc: Martyn Welch > Cc: Peter Senna Tschudin > > Changed in v3: > - updated Ian Ray's e-mail (old one is bouncing ^^ you misse

[PATCH v9 09/10] i915: add ref_tracker_dir symlinks for each tracker

2025-05-09 Thread Jeff Layton
Now that there is the ability to create a symlink for each tracker, do so for the i915 entries. Acked-by: Jani Nikula Signed-off-by: Jeff Layton --- drivers/gpu/drm/i915/intel_runtime_pm.c | 1 + drivers/gpu/drm/i915/intel_wakeref.c| 1 + 2 files changed, 2 insertions(+) diff --git a/drive

Re: [PATCH v2] drm/amd/display/dc/irq: Remove duplications of hpd_ack function from IRQ

2025-05-09 Thread Alex Hung
Reviewed-by: Alex Hung On 5/5/25 12:20, Alex Hung wrote: Thanks. I will send this patch for testing. Note I still see a warning of mismatch of author and SOB as below, but that can be fixed to "Sebastian Aguilera Novoa " manually after testing and before merging. $ ./scripts/checkpatch.pl

Re: [PATCH] drm/amd/display: Fix null check of pipe_ctx->plane_state for update_dchubp_dpp

2025-05-09 Thread Alex Hung
Reviewed-by: Alex Hung On 4/30/25 08:11, Melissa Wen wrote: Similar to commit 6a057072ddd1 ("drm/amd/display: Fix null check for pipe_ctx->plane_state in dcn20_program_pipe") that addresses a null pointer dereference on dcn20_update_dchubp_dpp. This is the same function hooked for update_dchubp

[pull] amdgpu, amdkfd, drm, dma-buf drm-next-6.16

2025-05-09 Thread Alex Deucher
Hi Dave, Simona, More changes for 6.16. The following changes since commit da072da2c8ca3e886133c5826a3f802f3d816708: drm/amd/display: Rename program_timing function for better debugging (2025-04-30 18:18:59 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5

Re: [PATCH v9 00/10] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-05-09 Thread Jakub Kicinski
On Fri, 09 May 2025 11:53:36 -0400 Jeff Layton wrote: > This one just fixes a typo in the ref_tracker_dir_init() kerneldoc > header. I'm only resending so the CI will pick it up. We got a bunch of: [0.457561][T0] ref_tracker: ref_tracker: unable to create debugfs file for net_refcnt@

Re: [PATCH v2 4/6] drm/panel: visionox-rm69299: switch to devm_regulator_bulk_get_const()

2025-05-09 Thread Jessica Zhang
On 5/9/2025 1:59 AM, Neil Armstrong wrote: Switch to devm_regulator_bulk_get_const() to move the supply data to const. Signed-off-by: Neil Armstrong Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 21 - 1 file changed, 12 insertions

Re: [PATCH v2 6/6] drm/panel: visionox-rm69299: support the variant found in the SHIFT6mq

2025-05-09 Thread Jessica Zhang
On 5/9/2025 1:59 AM, Neil Armstrong wrote: From: Caleb Connolly Add support for another variant of the rm69299 panel. This panel is 1080x2160 and is found in the shift-axolotl (SHIFT6mq). Signed-off-by: Caleb Connolly [narmstrong: moved to panel_desc] Signed-off-by: Neil Armstrong Revie

[Bug 205089] amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2025-05-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205089 Nelson G (konoh...@yahoo.com) changed: What|Removed |Added CC||konoh...@yahoo.com --- Co

Re: [PATCH v2 5/6] drm/panel: visionox-rm69299: switch to devm_drm_panel_alloc()

2025-05-09 Thread Jessica Zhang
On 5/9/2025 1:59 AM, Neil Armstrong wrote: Switch to devm_drm_panel_alloc() to add panel refcounting. Signed-off-by: Neil Armstrong Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

Re: [PATCH v2 3/6] drm/panel: visionox-rm69299: switch to _multi variants

2025-05-09 Thread Jessica Zhang
On 5/9/2025 1:59 AM, Neil Armstrong wrote: Switch to the DSI _multi variants to simplify error handling. Signed-off-by: Neil Armstrong Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 48 +++--- 1 file changed, 13 insertions(+), 35 d

Re: [PATCH v2 2/6] drm/panel: visionox-rm69299: add plumbing to support panel variants

2025-05-09 Thread Jessica Zhang
On 5/9/2025 1:59 AM, Neil Armstrong wrote: In order to support a panel variant, add plumbing code to pass init sequence and mode as compatible data. Signed-off-by: Neil Armstrong Reviewed-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 58 ++-

Re: [PATCH bpf-next v4 5/5] selftests/bpf: Add test for open coded dmabuf_iter

2025-05-09 Thread T.J. Mercier
On Fri, May 9, 2025 at 2:58 PM Song Liu wrote: > > On Fri, May 9, 2025 at 2:43 PM T.J. Mercier wrote: > > > [...] > > > > > > Personally, I would prefer we just merge all the logic of > > > create_udmabuf() and create_sys_heap_dmabuf() > > > into create_test_buffers(). > > > > That's a lot of dif

Re: (subset) [PATCH 17/33] dt-bindings: nvmem: qfprom: Add the SM7150 compatible

2025-05-09 Thread Bjorn Andersson
On Wed, 23 Apr 2025 00:31:21 +0300, Danila Tikhonov wrote: > Document QFPROM compatible for SM7150. > > Applied, thanks! [31/33] dt-bindings: arm: qcom: Add SM7150 Google Pixel 4a commit: bd4718d97d308fdc20ddcd471444b3e398ce877d Best regards, -- Bjorn Andersson

Re: [PATCH bpf-next v4 5/5] selftests/bpf: Add test for open coded dmabuf_iter

2025-05-09 Thread Song Liu
On Fri, May 9, 2025 at 2:43 PM T.J. Mercier wrote: > [...] > > > > Personally, I would prefer we just merge all the logic of > > create_udmabuf() and create_sys_heap_dmabuf() > > into create_test_buffers(). > > That's a lot of different stuff to put in one place. How about > returning file descrip

Re: [PATCH 3/4] rust: drm: gem: s/into_gem_obj()/as_gem_obj()/

2025-05-09 Thread Daniel Almeida
Hi Lyude, > On 1 May 2025, at 15:33, Lyude Paul wrote: > > There's a few changes here: > * The rename, of course (this should also let us drop the clippy annotation > here) > * Return *mut bindings::drm_gem_object instead of > &Opaque - the latter doesn't really have any > benefit and just re

Re: [PATCH 4/4] rust: drm: gem: Implement AlwaysRefCounted for all gem objects automatically

2025-05-09 Thread Daniel Almeida
Hi Lyude, > On 1 May 2025, at 15:33, Lyude Paul wrote: > > Currently we are requiring AlwaysRefCounted in most trait bounds for gem > objects, and implementing it by hand for our only current type of gem > object. However, all gem objects use the same functions for reference > counting - and all

[PATCH] drm/sched: Fix UAF in drm_sched_fence_get_timeline_name()

2025-05-09 Thread Rob Clark
From: Rob Clark The fence can outlive the sched, so it is not safe to dereference the sched in drm_sched_fence_get_timeline_name() Signed-off-by: Rob Clark --- drivers/gpu/drm/scheduler/sched_fence.c | 3 ++- include/drm/gpu_scheduler.h | 11 +++ 2 files changed, 13 insert

Re: [PATCH v3 14/22] drm/rcar-du: dsi: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:57 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > --- > > Cc: Kieran Bingham > Cc: Laurent Pinchart > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 8 > 1 file cha

Re: [PATCH bpf-next v4 5/5] selftests/bpf: Add test for open coded dmabuf_iter

2025-05-09 Thread T.J. Mercier
On Fri, May 9, 2025 at 11:46 AM Song Liu wrote: > > On Thu, May 8, 2025 at 11:21 AM T.J. Mercier wrote: > > > > Use the same test buffers as the traditional iterator and a new BPF map > > to verify the test buffers can be found with the open coded dmabuf > > iterator. > > The way we split 4/5 and

Re: [PATCH 2/4] rust: drm: gem: Refactor IntoGEMObject::from_gem_obj() to as_ref()

2025-05-09 Thread Daniel Almeida
Hi Lyude > On 1 May 2025, at 15:33, Lyude Paul wrote: > > There's a few issues with this function, mainly: > > * This function -probably- should have been unsafe from the start. Pointers > are not always necessarily valid, but you want a function that does > field-projection for a pointer tha

Re: [PATCH v3 15/22] drm/bridge: stm_lvds: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:57 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > --- > > Cc: Alexandre Torgue > Cc: Maxime Coquelin > Cc: Philippe Cornu > Cc: Raphael Gallais-Pou > Cc: Yannick Fertre > --- > drivers/gpu/drm/stm/lvds

Re: [PATCH v3 09/22] drm/omap: dss: dsi: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > --- > > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/driver

Re: [PATCH v3 08/22] drm/omap: dss: dpi: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > --- > > Cc: "Rob Herring (Arm)" > Cc: Helge Deller > Cc: Kuninori Morimoto > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/dss/dpi.c | 7 +++ >

Re: [PATCH v3 07/22] drm/bridge: sii902x: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/bridge/sii902x.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/sii902x.c > b/dr

Re: [PATCH v3 06/22] drm/bridge: nxp-ptn3460: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/bridge/nxp-ptn3460.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/nxp-ptn346

Re: [PATCH v2 7/7] gpu: nova-core: Clarify falcon code

2025-05-09 Thread Joel Fernandes
On 5/6/2025 12:21 PM, Zhi Wang wrote: >> -/// Target/source of a DMA transfer to/from falcon memory. >> +/// FBIF (Framebuffer Interface) aperture type. Used to determine >> +/// the memory type of the external memory access for a DMA memory >> +/// transfer (by the Falcon's FramebufferDMA (FBDM

Re: [PATCH 1/4] rust: drm: gem: Use NonNull for Object::dev

2025-05-09 Thread Daniel Almeida
Hi Lyude, > On 1 May 2025, at 15:33, Lyude Paul wrote: > > There is usually not much of a reason to use a raw pointer in a data > struct, so move this to NonNull instead. > > Signed-off-by: Lyude Paul > --- > rust/kernel/drm/gem/mod.rs | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(

Re: [PATCH v2 4/7] nova-core: docs: Document fwsec operation and layout

2025-05-09 Thread Joel Fernandes
On 5/6/2025 12:26 PM, Zhi Wang wrote: > On Sat, 3 May 2025 00:07:56 -0400 > Joel Fernandes wrote: > >> Add explanation of fwsec with diagrams. This helps clarify how the >> nova-core falcon boot works. >> >> Signed-off-by: Joel Fernandes >> --- >> Documentation/gpu/nova/core/fwsec.rst | 180

[PATCH] fbdev: fbcon: Make sure modelist not set on unregistered console

2025-05-09 Thread Kees Cook
It looks like attempting to write to the "store_modes" sysfs node will run afoul of unregistered consoles: UBSAN: array-index-out-of-bounds in drivers/video/fbdev/core/fbcon.c:122:28 index -1 is out of range for type 'fb_info *[32]' ... fbcon_info_from_console+0x192/0x1a0 drivers/video/fbdev/core

Re: [git pull] drm fixes for 6.15-rc6

2025-05-09 Thread pr-tracker-bot
The pull request you sent on Sat, 10 May 2025 05:19:27 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2025-05-10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ea34704d6ad7225421cc3543906deacae35a6ea2 Thank you! -- Deet-doot-dot, I am a bot. h

Re: [PATCH V9 02/24] clk: sunxi-ng: h616: Add LVDS reset for LCD TCON

2025-05-09 Thread Chris Morgan
On Fri, May 09, 2025 at 05:31:40PM +0100, Andre Przywara wrote: > On Fri, 9 May 2025 23:29:50 +0900 > Chen-Yu Tsai wrote: > > > On Fri, May 9, 2025 at 11:14 PM Andre Przywara > > wrote: > > > > > > On Wed, 7 May 2025 15:19:21 -0500 > > > Chris Morgan wrote: > > > > > > Hi, > > > > > > despite

Re: [PATCH V9 23/24] arm64: dts: allwinner: rg35xx: Add GPIO backlight control

2025-05-09 Thread Chris Morgan
On Fri, May 09, 2025 at 03:32:04PM +0100, Andre Przywara wrote: > On Wed, 7 May 2025 15:19:42 -0500 > Chris Morgan wrote: > > Hi Chris, > > > From: Chris Morgan > > > > The LCD backlight for this device can be exposed as a simple GPIO- > > controlled device. It would be more accurately modell

Re: [PATCH v3 04/22] drm/bridge: cdns-dsi: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > --- > > Cc: Aradhya Bhatia > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 8 > 1 file changed, 4 insertions(+), 4

[PATCH v9 10/10] ref_tracker: eliminate the ref_tracker_dir name field

2025-05-09 Thread Jeff Layton
Now that we have dentries and the ability to create meaningful symlinks to them, don't keep a name string in each tracker. Switch the output format to print "class@address", and drop the name field. Also, add a kerneldoc header for ref_tracker_dir_init(). Signed-off-by: Jeff Layton --- drivers/

Re: [PATCH v3 03/22] drm/bridge: anx7625: convert to devm_drm_bridge_alloc() API

2025-05-09 Thread Anusha Srivatsa
On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli wrote: > This is the new API for allocating DRM bridges. > > Signed-off-by: Luca Ceresoli > > Looks good! Reviewed-by: Anusha Srivatsa > --- > > Cc: "Rob Herring (Arm)" > Cc: Hsin-Te Yuan > Cc: Jani Nikula > Cc: Pin-yen Lin > Cc: Sui Jingfeng

[git pull] drm fixes for 6.15-rc6

2025-05-09 Thread Dave Airlie
Hey Linus, Weekly drm fixes, bit bigger than last week, but overall amdgpu/xe with some ivpu bits and a random few fixes, and dropping the ttm_backup struct which wrapped struct file and was recently frowned at. Thanks, Dave. drm-fixes-2025-05-10: drm fixes for 6.15-rc6 drm: - Fix overflow when

[RFC v2 07/13] sync_file: Use dma-fence driver and timeline name helpers

2025-05-09 Thread Tvrtko Ursulin
Access the dma-fence internals via the previously added helpers. Signed-off-by: Tvrtko Ursulin --- drivers/dma-buf/sync_file.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c index d9b1c1b2a72b..212df4b849fe 10

Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock

2025-05-09 Thread Neil Armstrong
Hi, On Tue, 06 May 2025 02:43:38 +0800, I Hsin Cheng wrote: > Coverity scan reported the usage of "mode->clock * 1000" may lead to > integer overflow. Use "1000ULL" instead of "1000" > when utilizing it to avoid potential integer overflow issue. > > Thanks, Applied to https://gitlab.freedesktop

Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock

2025-05-09 Thread Neil Armstrong
On 09/05/2025 20:27, Martin Blumenstingl wrote: On Fri, May 9, 2025 at 5:35 PM wrote: On 05/05/2025 20:43, I Hsin Cheng wrote: Coverity scan reported the usage of "mode->clock * 1000" may lead to integer overflow. Use "1000ULL" instead of "1000" when utilizing it to avoid potential integer ov

Re: [PATCH bpf-next v4 4/5] selftests/bpf: Add test for dmabuf_iter

2025-05-09 Thread Song Liu
On Thu, May 8, 2025 at 11:20 AM T.J. Mercier wrote: [...] > + > +void test_dmabuf_iter(void) > +{ > + struct dmabuf_iter *skel = NULL; > + char buf[256]; > + int iter_fd; > + > + skel = dmabuf_iter__open_and_load(); > + if (!ASSERT_OK_PTR(skel, "dmabuf_iter__open_and

Re: [PATCH bpf-next v4 5/5] selftests/bpf: Add test for open coded dmabuf_iter

2025-05-09 Thread Song Liu
On Thu, May 8, 2025 at 11:21 AM T.J. Mercier wrote: > > Use the same test buffers as the traditional iterator and a new BPF map > to verify the test buffers can be found with the open coded dmabuf > iterator. The way we split 4/5 and 5/5 makes the code tricker to follow. I guess the motivation is

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-09 Thread Jason Gunthorpe
On Sat, May 10, 2025 at 12:28:48AM +0800, Xu Yilun wrote: > On Fri, May 09, 2025 at 07:12:46PM +0800, Xu Yilun wrote: > > On Fri, May 09, 2025 at 01:04:58PM +1000, Alexey Kardashevskiy wrote: > > > Ping? > > > > Sorry for late reply from vacation. > > > > > Also, since there is pushback on 01/12

Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock

2025-05-09 Thread Martin Blumenstingl
On Fri, May 9, 2025 at 5:35 PM wrote: > > On 05/05/2025 20:43, I Hsin Cheng wrote: > > Coverity scan reported the usage of "mode->clock * 1000" may lead to > > integer overflow. Use "1000ULL" instead of "1000" > > when utilizing it to avoid potential integer overflow issue. > > > > Link: > > http

Re: [RFC PATCH 00/12] Private MMIO support for private assigned dev

2025-05-09 Thread Xu Yilun
On Fri, May 09, 2025 at 07:12:46PM +0800, Xu Yilun wrote: > On Fri, May 09, 2025 at 01:04:58PM +1000, Alexey Kardashevskiy wrote: > > Ping? > > Sorry for late reply from vacation. > > > Also, since there is pushback on 01/12 "dma-buf: Introduce > > dma_buf_get_pfn_unlocked() kAPI", what is the p

Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

2025-05-09 Thread Krzysztof Kozlowski
On 09/05/2025 09:34, Chaoyi Chen wrote: > Hi Krzysztof, > > On 2025/5/9 15:11, Krzysztof Kozlowski wrote: >> On 09/05/2025 09:02, Chaoyi Chen wrote: >>> + >>> + clock-names: >>> +items: >>> + - const: core-clk >>> + - const: pclk >>> + - const: spdif >>> + - const: grf >>>

Re: [PATCH bpf-next v4 4/5] selftests/bpf: Add test for dmabuf_iter

2025-05-09 Thread T.J. Mercier
On Thu, May 8, 2025 at 5:36 PM Song Liu wrote: > > On Thu, May 8, 2025 at 11:20 AM T.J. Mercier wrote: > [...] > > diff --git a/tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c > > b/tools/testing/selftests/bpf/prog_tests/dmabuf_iter.c > > new file mode 100644 > > index ..35745f4

Re: [PATCH bpf-next v4 3/5] bpf: Add open coded dmabuf iterator

2025-05-09 Thread T.J. Mercier
On Thu, May 8, 2025 at 5:28 PM Song Liu wrote: > > On Thu, May 8, 2025 at 11:20 AM T.J. Mercier wrote: > > > > This open coded iterator allows for more flexibility when creating BPF > > programs. It can support output in formats other than text. With an open > > coded iterator, a single BPF progr

Re: [PATCH bpf-next v4 2/5] bpf: Add dmabuf iterator

2025-05-09 Thread T.J. Mercier
On Thu, May 8, 2025 at 5:27 PM Song Liu wrote: > > On Thu, May 8, 2025 at 11:20 AM T.J. Mercier wrote: > > > > The dmabuf iterator traverses the list of all DMA buffers. > > > > DMA buffers are refcounted through their associated struct file. A > > reference is taken on each buffer as the list is

Re: [PATCH RFT 04/14] drm/msm/a6xx: Get a handle to the common UBWC config

2025-05-09 Thread Konrad Dybcio
On 5/9/25 3:52 PM, Rob Clark wrote: > On Fri, May 9, 2025 at 5:31 AM Konrad Dybcio > wrote: >> >> On 5/8/25 8:41 PM, Rob Clark wrote: >>> On Thu, May 8, 2025 at 11:13 AM Konrad Dybcio >>> wrote: From: Konrad Dybcio Start the great despaghettification by getting a pointer to

Re: [PATCH v2] drm/dp: Fix Write_Status_Update_Request AUX request format

2025-05-09 Thread Mario Limonciello
On 5/9/2025 4:22 AM, Wayne Lin wrote: [Why] Notice AUX request format of I2C-over-AUX with Write_Status_Update_Request flag set is incorrect. It should be address only request without length and data like: "SYNC->COM3:0 (= 0110)|-> |-> 0|7-bit I2C address (the same as the last)-> STOP

Re: [PATCH v6 2/7] drm/msm/a6xx: Increase HFI response timeout

2025-05-09 Thread Konrad Dybcio
On 5/3/25 9:03 AM, Akhil P Oommen wrote: > When ACD feature is enabled, it triggers some internal calibrations > which result in a pretty long delay during the first HFI perf vote. > So, increase the HFI response timeout to match the downstream driver. > > Tested-by: Maya Matuszczyk > Tested-by:

Re: [PATCH v4 2/4] drm/panel: Add refcount support

2025-05-09 Thread Jani Nikula
On Thu, 08 May 2025, Anusha Srivatsa wrote: > On Thu, May 8, 2025 at 10:27 AM Jani Nikula > wrote: > >> On Mon, 05 May 2025, Anusha Srivatsa wrote: >> > On Mon, May 5, 2025 at 2:54 AM Maxime Ripard wrote: >> > >> >> Hi Jani, >> >> >> >> On Tue, Apr 29, 2025 at 12:22:00PM +0300, Jani Nikula wrot

Re: [PATCH V9 02/24] clk: sunxi-ng: h616: Add LVDS reset for LCD TCON

2025-05-09 Thread Andre Przywara
On Fri, 9 May 2025 23:29:50 +0900 Chen-Yu Tsai wrote: > On Fri, May 9, 2025 at 11:14 PM Andre Przywara wrote: > > > > On Wed, 7 May 2025 15:19:21 -0500 > > Chris Morgan wrote: > > > > Hi, > > > > despite the slightly ill fate of this series, I was wondering if we could > > get the non-controve

[PULL] drm-intel-fixes

2025-05-09 Thread Jani Nikula
Hi Dave & Sima - A bit late this week, couple of fixes for -rc6. drm-intel-fixes-2025-05-09: drm/i915 fixes for v6.15-rc6: - Fix oops on resume after disconnecting DP MST sinks during suspend - Fix SPLC num_waiters refcounting BR, Jani. The following changes since commit 92a09c47464d040866cf

[PATCH v9 05/10] ref_tracker: allow pr_ostream() to print directly to a seq_file

2025-05-09 Thread Jeff Layton
Allow pr_ostream to also output directly to a seq_file without an intermediate buffer. The first caller of +ref_tracker_dir_seq_print() will come in a later patch, so mark that __maybe_unused for now. That designation will be removed once it is used. Reviewed-by: Andrew Lunn Signed-off-by: Jeff L

[PATCH v9 02/10] ref_tracker: add a top level debugfs directory for ref_tracker

2025-05-09 Thread Jeff Layton
Add a new "ref_tracker" directory in debugfs. Each individual refcount tracker can register files under there to display info about currently-held references. Reviewed-by: Andrew Lunn Signed-off-by: Jeff Layton --- lib/ref_tracker.c | 16 1 file changed, 16 insertions(+) diff

Re: [PATCH v6 2/2] i2c: i2c-qcom-geni: Add Block event interrupt support

2025-05-09 Thread Dmitry Baryshkov
On 09/05/2025 09:18, Jyothi Kumar Seerapu wrote: Hi Dimitry, Thanks for providing the review comments. On 5/6/2025 5:16 PM, Dmitry Baryshkov wrote: On Tue, May 06, 2025 at 04:48:44PM +0530, Jyothi Kumar Seerapu wrote: The I2C driver gets an interrupt upon transfer completion. When handling mul

Re: [PATCH RFT 13/14] drm/msm/a6xx: Drop cfg->ubwc_swizzle override

2025-05-09 Thread Konrad Dybcio
On 5/9/25 4:48 PM, Connor Abbott wrote: > On Fri, May 9, 2025 at 9:37 AM Konrad Dybcio > wrote: >> >> On 5/9/25 3:17 PM, Konrad Dybcio wrote: >>> On 5/8/25 9:26 PM, Connor Abbott wrote: On Thu, May 8, 2025 at 2:14 PM Konrad Dybcio wrote: > > From: Konrad Dybcio > > On

[PATCH v9 07/10] ref_tracker: add a way to create a symlink to the ref_tracker_dir debugfs file

2025-05-09 Thread Jeff Layton
Add the ability for a subsystem to add a user-friendly symlink that points to a ref_tracker_dir's debugfs file. Signed-off-by: Jeff Layton --- include/linux/ref_tracker.h | 13 + lib/ref_tracker.c | 28 2 files changed, 41 insertions(+) diff --

[PATCH v9 04/10] ref_tracker: add a static classname string to each ref_tracker_dir

2025-05-09 Thread Jeff Layton
A later patch in the series will be adding debugfs files for each ref_tracker that get created in ref_tracker_dir_init(). The format will be "class@%px". The current "name" string can vary between ref_tracker_dir objects of the same type, so it's not suitable for this purpose. Add a new "class" st

[PATCH v9 00/10] ref_tracker: add ability to register a debugfs file for a ref_tracker_dir

2025-05-09 Thread Jeff Layton
This one just fixes a typo in the ref_tracker_dir_init() kerneldoc header. I'm only resending so the CI will pick it up. Signed-off-by: Jeff Layton --- Changes in v9: - fix typo in ref_tracker_dir_init() kerneldoc header - Link to v8: https://lore.kernel.org/r/20250507-reftrack-dbgfs-v8-0-607717

[PATCH v9 08/10] net: add symlinks to ref_tracker_dir for netns

2025-05-09 Thread Jeff Layton
After assigning the inode number to the namespace, use it to create a unique name for each netns refcount tracker with the ns.inum and net_cookie values in it, and register a symlink to the debugfs file for it. init_net is registered before the ref_tracker dir is created, so add a late_initcall()

[PATCH v9 06/10] ref_tracker: automatically register a file in debugfs for a ref_tracker_dir

2025-05-09 Thread Jeff Layton
Currently, there is no convenient way to see the info that the ref_tracking infrastructure collects. Attempt to create a file in debugfs when called from ref_tracker_dir_init(). The file is given the name "class@%px", as having the unmodified address is helpful for debugging. This should be safe s

[PATCH v9 03/10] ref_tracker: have callers pass output function to pr_ostream()

2025-05-09 Thread Jeff Layton
In a later patch, we'll be adding a 3rd mechanism for outputting ref_tracker info via seq_file. Instead of a conditional, have the caller set a pointer to an output function in struct ostream. As part of this, the log prefix must be explicitly passed in, as it's too late for the pr_fmt macro. Revi

[PATCH v9 01/10] ref_tracker: don't use %pK in pr_ostream() output

2025-05-09 Thread Jeff Layton
As Thomas Weißschuh points out [1], it is now preferable to use %p instead of hashed pointers with printk(), since raw pointers should no longer be leaked into the kernel log. Change the ref_tracker infrastructure to use %p instead of %pK in its formats. [1]: https://lore.kernel.org/netdev/202504

[PATCH 5/5] drm/vesadrm: Use helpers for programming gamma ramps

2025-05-09 Thread Thomas Zimmermann
Replace vesadrm's code for programming the hardware gamma LUT with DRM helpers. Either load a provided gamma ramp or program a default. Set the individual entries with a callback. Each gamma value is given as 3 individual 16-bit values for red, green and blue. The driver reduces them to 8 bit to m

[PATCH 1/5] drm: Add helpers for programming hardware gamma LUTs

2025-05-09 Thread Thomas Zimmermann
Provide helpers that program hardware gamma LUTs. Tha gamma ramp is either provided by the driver or generated by the helper. The DRM driver exports the GAMMA_LUT property with a fixed number of entries per color component, such as 256 on 8-bit-wide components. The entries describe the gamma ramp

Re: [PATCH] dt-bindings: display/msm: hdmi: Fix constraints on additional 'port' properties

2025-05-09 Thread Rob Herring
On Thu, May 08, 2025 at 07:03:17AM +0300, Dmitry Baryshkov wrote: > On Wed, May 07, 2025 at 04:59:12PM -0500, Rob Herring (Arm) wrote: > > The MSM HDMI port nodes are missing any restrictions on additional > > properties. The $ref should be to "/properties/port" rather than > > "/$defs/port-base" a

Re: [RFC v2 01/13] drm/i915: Use provided dma_fence_is_chain

2025-05-09 Thread Matthew Brost
On Fri, May 09, 2025 at 04:33:40PM +0100, Tvrtko Ursulin wrote: > Replace open-coded helper with the subsystem one. > You probably can just send this one by itself as it good cleanup and independent. Reviewed-by: Matthew Brost > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gem/

[RFC v2 03/13] dma-fence: Use a flag for 64-bit seqnos

2025-05-09 Thread Tvrtko Ursulin
With the goal of reducing the need for drivers to touch (and dereference) fence->ops, we move the 64-bit seqnos flag from struct dma_fence_ops to the fence->flags. Drivers which were setting this flag are changed to use new dma_fence_init64() instead of dma_fence_init(). Signed-off-by: Tvrtko Urs

Re: [PATCH RFT 10/14] drm/msm/a6xx: Stop tracking macrotile_mode (again)

2025-05-09 Thread Connor Abbott
On Fri, May 9, 2025 at 8:45 AM Konrad Dybcio wrote: > > On 5/8/25 8:33 PM, Connor Abbott wrote: > > On Thu, May 8, 2025 at 2:14 PM Konrad Dybcio wrote: > >> > >> From: Konrad Dybcio > >> > >> SC8180X (A680) and SA8775P (A663) require a write to that register, > >> while other SKUs are fine with

[RFC v2 02/13] dma-fence: Change signature of __dma_fence_is_later

2025-05-09 Thread Tvrtko Ursulin
With the goal of reducing the need for drivers to touch (and dereference) fence->ops, we change the prototype of __dma_fence_is_later() to take fence instead of fence->ops. Signed-off-by: Tvrtko Ursulin --- drivers/dma-buf/dma-fence-chain.c | 2 +- drivers/dma-buf/sw_sync.c | 2 +- dri

Re: [PATCH RFT 05/14] drm/msm/a6xx: Resolve the meaning of AMSBC

2025-05-09 Thread Konrad Dybcio
On 5/8/25 9:16 PM, Connor Abbott wrote: > On Thu, May 8, 2025 at 2:13 PM Konrad Dybcio wrote: >> >> From: Konrad Dybcio >> >> The bit must be set to 1 if the UBWC encoder version is >= 3.0, drop it >> as a separate field. > > For these sorts of things, it's probably best to add a helper to the >

Re: [PATCH v2] drm/meson: Use 1000ULL when operating with mode->clock

2025-05-09 Thread neil . armstrong
On 05/05/2025 20:43, I Hsin Cheng wrote: Coverity scan reported the usage of "mode->clock * 1000" may lead to integer overflow. Use "1000ULL" instead of "1000" when utilizing it to avoid potential integer overflow issue. Link: https://scan5.scan.coverity.com/#/project-view/10074/10063?selectedI

[RFC v2 09/13] drm/i915: Use dma-fence driver and timeline name helpers

2025-05-09 Thread Tvrtko Ursulin
Access the dma-fence internals via the previously added helpers. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_requests.c | 4 ++-- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/i915/i915_sw_fence.c| 4 ++-- 3 files changed, 5 insertions(+), 5 d

[RFC v2 08/13] drm/amdgpu: Use dma-fence driver and timeline name helpers

2025-05-09 Thread Tvrtko Ursulin
Access the dma-fence internals via the previously added helpers. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h

[RFC v2 13/13] drm/xe: Make dma-fences compliant with the safe access rules

2025-05-09 Thread Tvrtko Ursulin
Xe can free some of the data pointed to by the dma-fences it exports. Most notably the timeline name can get freed if userspace closes the associated submit queue. At the same time the fence could have been exported to a third party (for example a sync_fence fd) which will then cause an use- after-

[RFC v2 11/13] sync_file: Protect access to driver and timeline name

2025-05-09 Thread Tvrtko Ursulin
Protect the access to driver and timeline name which otherwise could be freed as dma-fence exported is signalling fences. Signed-off-by: Tvrtko Ursulin --- drivers/dma-buf/sync_file.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_fil

[RFC v2 10/13] dma-fence: Add safe access helpers and document the rules

2025-05-09 Thread Tvrtko Ursulin
Dma-fence objects currently suffer from a potential use after free problem where fences exported to userspace and other drivers can outlive the exporting driver, or the associated data structures. The discussion on how to address this concluded that adding reference counting to all the involved ob

[RFC v2 12/13] drm/i915: Protect access to driver and timeline name

2025-05-09 Thread Tvrtko Ursulin
Protect the access to driver and timeline name which otherwise could be freed as dma-fence exported is signalling fences. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_requests.c | 2 ++ drivers/gpu/drm/i915/i915_request.c | 5 +++-- drivers/gpu/drm/i915/i915_sw_fenc

[RFC v2 01/13] drm/i915: Use provided dma_fence_is_chain

2025-05-09 Thread Tvrtko Ursulin
Replace open-coded helper with the subsystem one. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index 7127e9

[RFC v2 05/13] dma-fence: Add helpers for accessing driver and timeline name

2025-05-09 Thread Tvrtko Ursulin
Add some helpers in order to enable preventing dma-fence users accessing the implementation details directly. Signed-off-by: Tvrtko Ursulin --- include/linux/dma-fence.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index 5b

[RFC v2 06/13] dma-fence: Use driver and timeline name helpers internally

2025-05-09 Thread Tvrtko Ursulin
Make the implementation use the previously added helper for accessing the driver and timeline name. This will enable more coverage later when asserts will be added into them. Signed-off-by: Tvrtko Ursulin --- drivers/dma-buf/dma-fence.c | 9 + include/trace/events/dma_fence.h | 4 ++

[RFC v2 04/13] dma-fence: Move array and chain checks to flags

2025-05-09 Thread Tvrtko Ursulin
With the goal of reducing the need for drivers to touch fence->ops, we add explicit flags for struct dma_fence_array and struct dma_fence_chain and make the respective helpers (dma_fence_is_array() and dma_fence_is_chain()) use them. This also allows us to remove the exported symbols for the respe

[RFC v2 00/13] Some (drm_sched_|dma_)fence lifetime issues

2025-05-09 Thread Tvrtko Ursulin
Hi all, tl;dr; Xe and probably some other drivers can tear down the internal state referenced by an exported sync_file fence which then causes a null pointer derefences on accessing said fence. IGT that exploits the problem: https://patchwork.freedesktop.org/patch/642709/?series=146211&rev=2 It

Re: [PATCH bpf-next v4 0/5] Replace CONFIG_DMABUF_SYSFS_STATS with BPF

2025-05-09 Thread T.J. Mercier
On Thu, May 8, 2025 at 11:04 PM Christian König wrote: > > Feel free to add my Acked-by to the patches which don't have my rb yet. > > And ping me when I should upstream this through drm-misc-next, but if you > want to upstream this through some other branch then that is fine with me as > well.

Re: [PATCH v4 0/7] Convert inno hdmi to drm bridge

2025-05-09 Thread Dmitry Baryshkov
On 09/05/2025 04:58, Andy Yan wrote: Hi Dmitry, Thanks for you review. 在 2025-05-05 00:16:35,"Dmitry Baryshkov" 写道: On Sat, May 03, 2025 at 04:42:04PM +0200, Heiko Stübner wrote: Am Dienstag, 22. April 2025, 09:04:39 Mitteleuropäische Sommerzeit schrieb Andy Yan: From: Andy Yan When p

Re: [PATCH v9 01/14] drm/atomic-helper: Add crtc check before checking plane

2025-05-09 Thread Dmitry Baryshkov
On 09/05/2025 06:08, Jun Nie wrote: Dmitry Baryshkov 于2025年5月8日周四 18:47写道: On Tue, May 06, 2025 at 11:47:31PM +0800, Jun Nie wrote: Some display controller support flexible CRTC and DMA, such as the display controllers in snapdragon SoCs. CRTC can be implemented with several mixers in paralle

Re: [PATCH v8 10/10] ref_tracker: eliminate the ref_tracker_dir name field

2025-05-09 Thread Jakub Kicinski
On Fri, 09 May 2025 09:36:57 -0400 Jeff Layton wrote: > On Wed, 2025-05-07 at 20:01 -0700, Jakub Kicinski wrote: > > On Wed, 07 May 2025 09:06:35 -0400 Jeff Layton wrote: > > > + * @quarantime_count: max number of entries to be tracked > > > > quarantime > > ^ > > :( > > Sorry, I th

Re: [PATCH RFT 13/14] drm/msm/a6xx: Drop cfg->ubwc_swizzle override

2025-05-09 Thread Connor Abbott
On Fri, May 9, 2025 at 9:37 AM Konrad Dybcio wrote: > > On 5/9/25 3:17 PM, Konrad Dybcio wrote: > > On 5/8/25 9:26 PM, Connor Abbott wrote: > >> On Thu, May 8, 2025 at 2:14 PM Konrad Dybcio > >> wrote: > >>> > >>> From: Konrad Dybcio > >>> > >>> On A663 (SA8775P) the value matches exactly. > >>

Re: [PATCH V9 23/24] arm64: dts: allwinner: rg35xx: Add GPIO backlight control

2025-05-09 Thread Andre Przywara
On Wed, 7 May 2025 15:19:42 -0500 Chris Morgan wrote: Hi Chris, > From: Chris Morgan > > The LCD backlight for this device can be exposed as a simple GPIO- > controlled device. It would be more accurately modelled using PWM to > enable brightness control, however the PWM driver design for the

Re: [PATCH V9 02/24] clk: sunxi-ng: h616: Add LVDS reset for LCD TCON

2025-05-09 Thread Chen-Yu Tsai
On Fri, May 9, 2025 at 11:14 PM Andre Przywara wrote: > > On Wed, 7 May 2025 15:19:21 -0500 > Chris Morgan wrote: > > Hi, > > despite the slightly ill fate of this series, I was wondering if we could > get the non-controversial clock parts for instance already merged, to > reduce the number of p

[PATCH] drm: drm_auth: Convert mutex usage to guard(mutex)

2025-05-09 Thread André Almeida
Replace open-coded mutex handling with cleanup.h guard(mutex). This simplifies the code and removes the "goto unlock" pattern. Tested with igt tests core_auth and core_setmaster. Signed-off-by: André Almeida --- For more information about guard(mutex): https://www.kernel.org/doc/html/latest/cor

Re: [PATCH RFT 04/14] drm/msm/a6xx: Get a handle to the common UBWC config

2025-05-09 Thread Konrad Dybcio
On 5/8/25 8:41 PM, Rob Clark wrote: > On Thu, May 8, 2025 at 11:13 AM Konrad Dybcio wrote: >> >> From: Konrad Dybcio >> >> Start the great despaghettification by getting a pointer to the common >> UBWC configuration, which houses e.g. UBWC versions that we need to >> make decisions. >> >> Signed-

Re: [PATCH V9 02/24] clk: sunxi-ng: h616: Add LVDS reset for LCD TCON

2025-05-09 Thread Andre Przywara
On Wed, 7 May 2025 15:19:21 -0500 Chris Morgan wrote: Hi, despite the slightly ill fate of this series, I was wondering if we could get the non-controversial clock parts for instance already merged, to reduce the number of patches and mitigate the churn with dependencies? > From: Chris Morgan

Re: [PATCH V9 01/24] dt-bindings: clock: sun50i-h616-ccu: Add LVDS reset

2025-05-09 Thread Andre Przywara
On Wed, 7 May 2025 15:19:20 -0500 Chris Morgan wrote: > From: Chris Morgan > > Add the required LVDS reset binding for the LCD TCON. > > Signed-off-by: Chris Morgan > Signed-off-by: Ryan Walklin Reviewed-by: Andre Przywara Cheers, Andre > --- > include/dt-bindings/reset/sun50i-h616-ccu

Re: Kernels >= 6.3 disable video output

2025-05-09 Thread Alex Deucher
On Fri, May 9, 2025 at 9:39 AM Steven J Abner wrote: > > On Fri, May 9 2025 at 01:11:17 PM +, Alex Deucher > wrote: > > What display(s) are you using and how are they connected? Can you > > bisect? > > Not sure the question, but it's a tv thru HDMI. > > Screen 0: minimum 320 x 200, current 1

  1   2   3   >