On Fri, May 9, 2025 at 9:56 AM Luca Ceresoli <luca.ceres...@bootlin.com>
wrote:

> This is the new API for allocating DRM bridges.
>
> Signed-off-by: Luca Ceresoli <luca.ceres...@bootlin.com>
>
> Looks good!

Reviewed-by: Anusha Srivatsa <asriv...@redhat.com>


> ---
>
> Cc: "Rob Herring (Arm)" <r...@kernel.org>
> Cc: Hsin-Te Yuan <yuanhsi...@chromium.org>
> Cc: Jani Nikula <jani.nik...@intel.com>
> Cc: Pin-yen Lin <treapk...@chromium.org>
> Cc: Sui Jingfeng <sui.jingf...@linux.dev>
> Cc: Xin Ji <x...@analogixsemi.com>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
> b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index
> 8a9079c2ed5c22565d0733ef899119e347947d21..0ac4a82c5a6e5e665d913674b664905a96c0d8e6
> 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2596,7 +2596,6 @@ static int anx7625_link_bridge(struct drm_dp_aux
> *aux)
>                 return ret;
>         }
>
> -       platform->bridge.funcs = &anx7625_bridge_funcs;
>         platform->bridge.of_node = dev->of_node;
>         if (!anx7625_of_panel_on_aux_bus(dev))
>                 platform->bridge.ops |= DRM_BRIDGE_OP_EDID;
> @@ -2630,10 +2629,10 @@ static int anx7625_i2c_probe(struct i2c_client
> *client)
>                 return -ENODEV;
>         }
>
> -       platform = devm_kzalloc(dev, sizeof(*platform), GFP_KERNEL);
> -       if (!platform) {
> +       platform = devm_drm_bridge_alloc(dev, struct anx7625_data, bridge,
> &anx7625_bridge_funcs);
> +       if (IS_ERR(platform)) {
>                 DRM_DEV_ERROR(dev, "fail to allocate driver data\n");
> -               return -ENOMEM;
> +               return PTR_ERR(platform);
>         }
>
>         pdata = &platform->pdata;
>
> --
> 2.49.0
>
>

Reply via email to