Re: [PATCH v2 1/4] drm/vc4: Use DRM Execution Contexts

2024-12-12 Thread Christian König
Am 12.12.24 um 21:20 schrieb Maíra Canal: VC4 has internal copies of `drm_gem_lock_reservations()` and `drm_gem_unlock_reservations()` inside the driver and ideally, we should move those hard-coded functions to the generic functions provided by DRM. But, instead of using the DRM GEM functions to

Re: [PATCH 6/7] drivers: Repace get_task_comm() with %pTN

2024-12-12 Thread Jiri Slaby
On 13. 12. 24, 6:46, Yafang Shao wrote: Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copy it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Ofir Bitton Cc: Oded Gabbay Cc:

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-12 Thread Sharma, Shashank
[AMD Official Use Only - AMD Internal Distribution Only] Looks good to me as well, With Christian's comment accommodated: Acked-by: Shashank Sharma Regards Shashank From: Koenig, Christian Sent: Friday, December 13, 2024 8:34 AM To: André Almeida ; Raag Jadav ;

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Christophe Leroy
Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warni

Re: [PATCH v2 2/3] drm/fbdev: Select FB_CORE dependency for fbdev on DMA and TTM

2024-12-12 Thread Christophe Leroy
Le 13/12/2024 à 08:40, Christophe Leroy a écrit : Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : Select FB_CORE if GEM's DMA and TTM implementations support fbdev emulation. Fixes linker errors about missing symbols from the fbdev subsystem. Also see [1] for a related SHMEM fix. Fixes

Re: [PATCH v2 2/3] drm/fbdev: Select FB_CORE dependency for fbdev on DMA and TTM

2024-12-12 Thread LEROY Christophe
Le 12/12/2024 à 11:04, Thomas Zimmermann a écrit : > Select FB_CORE if GEM's DMA and TTM implementations support fbdev > emulation. Fixes linker errors about missing symbols from the fbdev > subsystem. > > Also see [1] for a related SHMEM fix. > > Fixes: dadd28d4142f ("drm/client: Add client-li

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-12 Thread Christian König
Am 12.12.24 um 20:09 schrieb André Almeida: Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ 1 file changed, 3 inserti

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Thomas Zimmermann
Hi Am 12.12.24 um 22:04 schrieb Arnd Bergmann: On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make f

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Thomas Zimmermann
Hi Am 13.12.24 um 00:56 schrieb Helge Deller: On 12/13/24 00:24, Jani Nikula wrote: On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter

Re: [PATCH v6 2/3] drm/bridge: ti-sn65dsi83: Add ti,lvds-vod-swing optional properties

2024-12-12 Thread Andrej Picej
Hi Christophe, On 12. 12. 24 13:33, Christophe JAILLET wrote: Le 12/12/2024 à 13:17, Andrej Picej a écrit : Add a optional properties to change LVDS output voltage. This should not be static as this depends mainly on the connected display voltage requirement. We have three properties: - "ti,lvd

Re: [PATCH 1/2] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

2024-12-12 Thread 林睿祥

[PATCH v8 drm-dp 5/5] drm/hisilicon/hibmc: add dp module in hibmc

2024-12-12 Thread Yongbang Shi
From: baihan li To support DP interface displaying in hibmc driver. Add a encoder and connector for DP modual. The HPD function and get_edid function will be add in next series, so temporarily using 1024x768 as default in hibmc_dp_connector_get_modes() Signed-off-by: Baihan Li Signed-off-by: Yo

[PATCH 1/2] drm/dp: Add the DPCD register required for Extended wake timeout

2024-12-12 Thread Suraj Kandpal
Add DPCD registers required to configure Extended Wake Timeout for LTTPR. Signed-off-by: Suraj Kandpal --- include/drm/display/drm_dp.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h index a6f8b098c56f..480370bba1de

[PATCH v8 drm-dp 1/5] drm/hisilicon/hibmc: add dp aux in hibmc drivers

2024-12-12 Thread Yongbang Shi
From: baihan li Add dp aux read/write functions. They are basic functions and will be used later. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - adding do{} while(0) in macro defination function, suggested by Dmitry Baryshkov.

[PATCH v8 drm-dp 4/5] drm/hisilicon/hibmc: refactored struct hibmc_drm_private

2024-12-12 Thread Yongbang Shi
From: baihan li Refactored struct hibmc_drm_private to separate VGA module from generic struct. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v3 -> v4: - separating hibmc_vdac and hibmc_dp changes into separate patche, suggested by Dmitry

[PATCH v8 drm-dp 2/5] drm/hisilicon/hibmc: add dp link moduel in hibmc drivers

2024-12-12 Thread Yongbang Shi
From: baihan li Add link training process functions in this moduel. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- Changelog: v7 -> v8: - adding DP_AUX_NATIVE_WRITE case in switch statement in hibmc_dp_aux_parse_xfer(). v6 -> v7: - deleteing unset

[PATCH v8 drm-dp 3/5] drm/hisilicon/hibmc: add dp hw moduel in hibmc driver

2024-12-12 Thread Yongbang Shi
From: baihan li Build a dp level that hibmc driver can enable dp by calling their functions. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi Reviewed-by: Dmitry Baryshkov --- ChangeLog: v5 -> v6: - using drm_dbg_dp() to print debug info instead of drm_info(), suggested by Dmitry Barys

[PATCH v8 drm-dp 0/5] Add dp module in hibmc driver

2024-12-12 Thread Yongbang Shi
From: baihan li Realizing the basic display function of DP cable for DP connector displaying. Add DP module in hibmc drm driver, which is for Hisilicon Hibmc SoC which used for Out-of-band management. Blow is the general hardware connection, both the Hibmc and the host CPU are on the same mother

Re: [PATCH v6 12/19] drm/imx: Add i.MX8qxp Display Controller KMS

2024-12-12 Thread Liu Ying
On 12/12/2024, Dmitry Baryshkov wrote: > On Wed, Dec 11, 2024 at 03:43:20PM +0800, Liu Ying wrote: >> On 12/10/2024, Dmitry Baryshkov wrote: >>> On Mon, Dec 09, 2024 at 11:39:16AM +0800, Liu Ying wrote: i.MX8qxp Display Controller(DC) is comprised of three main components that include a b

[PATCH 2/2] drm/i915/lttpr: Enable Extended Wake Timeout

2024-12-12 Thread Suraj Kandpal
Usually retimers take around 30 to 40ms to exit all devices from sleep state. Extended wake timeout request helps to give additional time by reading the DPCD register through which sink requests the minimal amount of time required to wake the sink up and giving the same amount of wait requested by

[PATCH 0/2] Extended Wake Timeout

2024-12-12 Thread Suraj Kandpal
Retimers in H/w usually takes 30 to 40ms to wake up all the devices. To get this we use the Extended Wake Time feature in which the sink device tells us the minimum amount of time it requires to wake up and we need to do a write to grant this request else we need to wake up within 1ms of low power

[PATCH 7/7] fs: Use %pTN to print task name

2024-12-12 Thread Yafang Shao
Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copy it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Mark Fasheh Cc: Joel Becker Cc: Joseph Qi --- fs/ocfs2/cluster/netdebug.

[PATCH 6/7] drivers: Repace get_task_comm() with %pTN

2024-12-12 Thread Yafang Shao
Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copy it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Ofir Bitton Cc: Oded Gabbay Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Joonas

[PATCH 5/7] security: Replace get_task_comm() with %pTN

2024-12-12 Thread Yafang Shao
Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copy it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Kees Cook Cc: Paul Moore Cc: James Morris Cc: "Serge E. Hallyn" --- sec

[PATCH 4/7] net: Replace get_task_comm() with %pTN

2024-12-12 Thread Yafang Shao
Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copy it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Johannes Berg --- net/wireless/wext-core.c | 6 ++ 1 file changed, 2 i

[PATCH 0/7] vsprintf: Add %pTN to print Task Name

2024-12-12 Thread Yafang Shao
Since task->comm is guaranteed to be NUL-terminated, it can be printed directly. This patch introduces a new vsnprintf format specifier, %pTN, to print a task's name. In this specifier, p represents the task pointer, T stands for "Task," and N denotes "Name." With this abstraction, users no longer

[PATCH 3/7] arch: Replace get_task_comm() with %pTN

2024-12-12 Thread Yafang Shao
Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copy it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Vineet Gupta Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc:

[PATCH 2/7] kernel: Replace get_task_comm() with %pTN

2024-12-12 Thread Yafang Shao
Since task->comm is guaranteed to be NUL-terminated, we can print it directly without the need to copye it into a separate buffer. This simplifies the code and avoids unnecessary operations. Signed-off-by: Yafang Shao Cc: Serge Hallyn Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Peter Zijlstra Cc:

[PATCH 1/7] vsprintf: Add %pTN to print task name

2024-12-12 Thread Yafang Shao
Since the task->comm is guaranteed to be NUL-ternimated, we can print it directly. Add a new vsnprintf format specifier "%pTN" to print task comm, where 'p' represents the task Pointer, 'T' stands for Task, and 'N' denots Name. With this abstraction, the user no longer needs to care about retrievin

Re: [PATCH 1/2] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

2024-12-12 Thread Pin-yen Lin
Hi Jason, On Thu, Dec 12, 2024 at 11:33 PM Jason-JH.Lin wrote: > > From: Hsiao Chien Sung > > Modify rules for both MT8195 and MT8188. > Hardware capabilities include color formats and AFBC are > changed since MT8195, stop using the settings of MT8183. > > Acked-by: Rob Herring > Reviewed-by: A

Re: [PATCH v6 01/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller processing units

2024-12-12 Thread Liu Ying
On 12/11/2024, Rob Herring wrote: > On Wed, Dec 11, 2024 at 11:05:52AM +0800, Liu Ying wrote: >> On 12/11/2024, Rob Herring wrote: >>> On Mon, Dec 09, 2024 at 11:39:05AM +0800, Liu Ying wrote: Freescale i.MX8qxp Display Controller is implemented as construction set of building blocks with

Re: [PATCH 1/2] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188

2024-12-12 Thread 胡俊光

Re: [PATCH] drm/msm/a6xx: Skip gpu secure fw load in EL2 mode

2024-12-12 Thread Pavan Kondeti
On Thu, Dec 12, 2024 at 10:40:46AM +, Mark Rutland wrote: > On Thu, Dec 12, 2024 at 08:50:12AM +, Marc Zyngier wrote: > > On Thu, 12 Dec 2024 05:31:00 +, > > Pavan Kondeti wrote: > > > > > > On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote: > > > > On Wed, 11 Dec 2024 00:3

[Bug 205089] amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2024-12-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205089 Wenjie (ww107...@gmail.com) changed: What|Removed |Added CC||ww107...@gmail.com --- Comm

Re: [PATCH] drm/msm/dpu: Filter modes based on adjusted mode clock

2024-12-12 Thread Dmitry Baryshkov
> dpu_kms->perf.perf_cfg); > + > + /* > + * The given mode, adjusted for the perf clock factor, should not exceed > + * the max core clock rate > + */ > + if (adjusted_mode_clk > dpu_kms->perf.max_core_clk_rate / 1000) > + return MODE_CLOCK_HIGH; > + > /* >* max crtc width is equal to the max mixer width * 2 and max height is > 4K >*/ > > --- > base-commit: 423c1c96d6b2d3bb35072e33a5fdd8db6d2c0a74 > change-id: 20241212-filter-mode-clock-8cb2e769f05b > > Best regards, > -- > Jessica Zhang > -- With best wishes Dmitry

Re: [PATCH v3 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-12 Thread Dmitry Baryshkov
On Fri, 13 Dec 2024 at 01:53, Abhinav Kumar wrote: > > > > On 12/12/2024 2:28 PM, Dmitry Baryshkov wrote: > > On Thu, 12 Dec 2024 at 23:41, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > >>> Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_l

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Helge Deller
On 12/13/24 00:24, Jani Nikula wrote: On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev cor

Re: [PATCH v3 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-12 Thread Abhinav Kumar
On 12/12/2024 2:28 PM, Dmitry Baryshkov wrote: On Thu, 12 Dec 2024 at 23:41, Abhinav Kumar wrote: On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly to program audio packet data. Use 0 as Packet ID, as it was not progra

Re: [WIP RFC v2 20/35] WIP: rust: drm/kms: Add drm_atomic_state bindings

2024-12-12 Thread Lyude Paul
On Wed, 2024-11-27 at 17:54 -0300, Daniel Almeida wrote: > Hi Lyude > > > On 30 Sep 2024, at 20:10, Lyude Paul wrote: > > > > Next up is introducing bindings that we can use to represent the global DRM > > atomic state, along with all of the various object states contained within. > > We do this

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Jani Nikula
On Thu, 12 Dec 2024, "Arnd Bergmann" wrote: > On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: >> On 12/12/24 11:04, Thomas Zimmermann wrote: >>> Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter >>> only controls backlight support within fbdev core code and data >>> structures

Re: [PATCH v3 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-12 Thread Dmitry Baryshkov
On Thu, 12 Dec 2024 at 20:53, Abhinav Kumar wrote: > > > > On 12/12/2024 10:31 AM, Abhinav Kumar wrote: > > > > > > On 12/12/2024 12:58 AM, Dmitry Baryshkov wrote: > >> On Wed, Dec 11, 2024 at 05:14:18PM -0800, Abhinav Kumar wrote: > >>> > >>> > >>> On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: >

Re: [PATCH v3 04/14] drm/msm/dp: pull I/O data out of msm_dp_catalog_private()

2024-12-12 Thread Dmitry Baryshkov
On Thu, 12 Dec 2024 at 21:15, Abhinav Kumar wrote: > > > > On 12/12/2024 12:52 AM, Dmitry Baryshkov wrote: > > On Thu, 12 Dec 2024 at 04:59, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > >>> Having I/O regions inside a msm_dp_catalog_private() resu

Re: [WIP RFC v2 14/35] WIP: rust: drm/kms: Add OpaqueCrtc and OpaqueCrtcState

2024-12-12 Thread Lyude Paul
On Wed, 2024-11-27 at 13:00 -0300, Daniel Almeida wrote: > Hi Lyude, > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > This is the same thing as OpaqueConnector and OpaqueConnectorState, but for > > CRTCs now. > > > > Signed-off-by: Lyude Paul > > > > --- > > > > TODO: > > * Add upca

Re: [WIP RFC v2 10/35] rust: drm/kms: Add DriverConnector::get_mode callback

2024-12-12 Thread Lyude Paul
On Wed, 2024-11-27 at 12:03 -0300, Daniel Almeida wrote: > Hi Lyude, > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > Next up is filling out some of the basic connector hotplugging callbacks - > > which we'll need for setting up the fbdev helpers for KMS devices. Note > > that connector

Re: [PATCH v3 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-12 Thread Dmitry Baryshkov
On Thu, 12 Dec 2024 at 23:41, Abhinav Kumar wrote: > > > > On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > > Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly > > to program audio packet data. Use 0 as Packet ID, as it was not > > programmed earlier. > > > > Reviewed-by: St

Re: [WIP RFC v2 07/35] WIP: rust: drm/kms: Add drm_crtc bindings

2024-12-12 Thread Lyude Paul
On Wed, 2024-11-27 at 11:36 -0300, Daniel Almeida wrote: > Hi Lyude, > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > This introduces basic bindings for DRM CRTCs which follow the same general > > pattern as connectors and planes (e.g. AsRawCrtc, AsRawCrtcState, etc.). > > There is one

Re: [PATCH v5 2/7] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-12-12 Thread Neil Armstrong
On 12/12/2024 20:55, Konrad Dybcio wrote: On 11.12.2024 9:29 AM, Neil Armstrong wrote: The Adreno GPU Management Unit (GMU) can also scale DDR Bandwidth along the Frequency and Power Domain level, but by default we leave the OPP core scale the interconnect ddr path. While scaling via the interc

Re: [PATCH v3 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-12-12 Thread Abhinav Kumar
On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly to program audio packet data. Use 0 as Packet ID, as it was not programmed earlier. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/

Re: [PATCH] drm/log: select CONFIG_FONT_SUPPORT

2024-12-12 Thread Jocelyn Falempe
On 12/12/2024 17:37, Jocelyn Falempe wrote: On 12/12/2024 16:39, Arnd Bergmann wrote: From: Arnd Bergmann Without fonts, this fails to link: drivers/gpu/drm/clients/drm_log.o: in function `drm_log_init_client': drm_log.c:(.text+0x3d4): undefined reference to `get_default_font' Select this, l

Re: [PATCH v5 3/7] drm/msm: adreno: dynamically generate GMU bw table

2024-12-12 Thread Neil Armstrong
On 12/12/2024 21:10, Konrad Dybcio wrote: On 11.12.2024 9:29 AM, Neil Armstrong wrote: The Adreno GPU Management Unit (GMU) can also scale the ddr bandwidth along the frequency and power domain level, but for now we statically fill the bw_table with values from the downstream driver. Only the f

Re: [PATCH v5 4/7] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-12-12 Thread Neil Armstrong
On 12/12/2024 21:21, Konrad Dybcio wrote: On 11.12.2024 9:29 AM, Neil Armstrong wrote: The Adreno GPU Management Unit (GMU) can also scale the DDR Bandwidth along the Frequency and Power Domain level, until now we left the OPP core scale the OPP bandwidth via the interconnect path. In order to

Re: [PATCH v5 5/7] drm/msm: adreno: enable GMU bandwidth for A740 and A750

2024-12-12 Thread Neil Armstrong
On 12/12/2024 21:32, Konrad Dybcio wrote: On 11.12.2024 9:29 AM, Neil Armstrong wrote: Now all the DDR bandwidth voting via the GPU Management Unit (GMU) is in place, declare the Bus Control Modules (BCMs) and the corresponding parameters in the GPU info struct. Reviewed-by: Dmitry Baryshkov R

Re: [WIP RFC v2 06/35] rust: drm/kms: Add drm_plane bindings

2024-12-12 Thread Lyude Paul
Some questions/responses down below: On Wed, 2024-11-27 at 11:05 -0300, Daniel Almeida wrote: > Hi Lyude, > > > On 30 Sep 2024, at 20:09, Lyude Paul wrote: > > > > The next step is adding a set of basic bindings to create a plane, which > > has to happen before we can create a CRTC (since we ne

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Arnd Bergmann
On Thu, Dec 12, 2024, at 19:44, Helge Deller wrote: > On 12/12/24 11:04, Thomas Zimmermann wrote: >> Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter >> only controls backlight support within fbdev core code and data >> structures. >> >> Make fbdev drivers depend on BACKLIGHT_CLAS

Re: [PATCH v5 5/7] drm/msm: adreno: enable GMU bandwidth for A740 and A750

2024-12-12 Thread Konrad Dybcio
On 11.12.2024 9:29 AM, Neil Armstrong wrote: > Now all the DDR bandwidth voting via the GPU Management Unit (GMU) > is in place, declare the Bus Control Modules (BCMs) and the > corresponding parameters in the GPU info struct. > > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Akhil P Oommen > Sig

Re: [PATCH v3 00/14] drm/msm/dp: perform misc cleanups

2024-12-12 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-11 15:41:35) > - Fix register programming in the dp_audio module > - Rework most of the register programming functions to be local to the > calling module rather than accessing everything through huge > dp_catalog monster. > > Signed-off-by: Dmitry Baryshkov >

Re: [PATCH v3 06/14] drm/msm/dp: move/inline AUX register functions

2024-12-12 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-11 15:41:41) > Move all register-level functions to dp_aux.c, inlining one line > wrappers during this process. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v3 05/14] drm/msm/dp: move I/O functions to global header

2024-12-12 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-12-11 15:41:40) > Move msm_dp_read()/msm_write_foo() functions to the dp_catalog.h, > allowing other modules to access the data directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

[PATCH v2 2/4] drm/vc4: Use DMA Resv to implement VC4 wait BO IOCTL

2024-12-12 Thread Maíra Canal
As the BOs used by VC4 have DMA Reservation Objects attached to it, there is no need to use seqnos wait for the BOs availability. Instead, we can use `dma_gem_dma_resv_wait()`. Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_drv.h | 10 ++ drivers/gpu/drm/vc4/vc4_gem.c | 31 ++

[PATCH v2 4/4] drm/vc4: Remove `vc4_queue_seqno_cb()`

2024-12-12 Thread Maíra Canal
The function `vc4_queue_seqno_cb()` is no longer needed, as we are using DMA Reservation Objects to track BOs. Using DMA Resv, we can use `dma_fence_add_callback()` to perform the async page flip. Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_drv.h | 3 --- drivers/gpu/drm/vc4/vc4_gem.

[PATCH v2 1/4] drm/vc4: Use DRM Execution Contexts

2024-12-12 Thread Maíra Canal
VC4 has internal copies of `drm_gem_lock_reservations()` and `drm_gem_unlock_reservations()` inside the driver and ideally, we should move those hard-coded functions to the generic functions provided by DRM. But, instead of using the DRM GEM functions to (un)lock reservations, move the new DRM Exec

[PATCH v2 3/4] drm/vc4: Remove BOs seqnos

2024-12-12 Thread Maíra Canal
`bo->seqno`, `bo->write_seqno`, and `exec->bin_dep_seqno` are leftovers from a time when VC4 didn't support DMA Reservation Objects. When they were introduced, it made sense to think about tracking the correspondence between the BOs and the jobs through the job's seqno. This is no longer needed, a

[PATCH v2 0/4] drm/vc4: Clean-up the BO seqnos

2024-12-12 Thread Maíra Canal
This series introduces a series of clean-ups for BO reservations in the VC4 driver. Currently, VC4 uses shared fences to track BO reservations, similar to many other DRM devices. However, in addition to DMA reservation objects, VC4 has been maintaining a separate seqno tracking system for BOs to tr

Re: [PATCH v5 4/7] drm/msm: adreno: find bandwidth index of OPP and set it along freq index

2024-12-12 Thread Konrad Dybcio
On 11.12.2024 9:29 AM, Neil Armstrong wrote: > The Adreno GPU Management Unit (GMU) can also scale the DDR Bandwidth > along the Frequency and Power Domain level, until now we left the OPP > core scale the OPP bandwidth via the interconnect path. > > In order to enable bandwidth voting via the GPU

Re: [PATCH v5 3/7] drm/msm: adreno: dynamically generate GMU bw table

2024-12-12 Thread Konrad Dybcio
On 11.12.2024 9:29 AM, Neil Armstrong wrote: > The Adreno GPU Management Unit (GMU) can also scale the ddr > bandwidth along the frequency and power domain level, but for > now we statically fill the bw_table with values from the > downstream driver. > > Only the first entry is used, which is a di

Re: [PATCH v3 2/2] leds: lp8864: New driver

2024-12-12 Thread Sverdlin, Alexander
Hi Lee! On Thu, 2024-12-12 at 18:59 +, Lee Jones wrote: > On Mon, 09 Dec 2024, A. Sverdlin wrote: > > > From: Alexander Sverdlin > > > > Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers > > with I2C interface. > > > > Link: https://www.ti.com/lit/gpn/lp8864-q1 >

Re: [PATCH v5 2/7] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-12-12 Thread Konrad Dybcio
On 11.12.2024 9:29 AM, Neil Armstrong wrote: > The Adreno GPU Management Unit (GMU) can also scale DDR Bandwidth along > the Frequency and Power Domain level, but by default we leave the > OPP core scale the interconnect ddr path. > > While scaling via the interconnect path was sufficient, newer G

Re: [PATCH v2] drm/msm/dpu: check dpu_plane_atomic_print_state() for valid sspp

2024-12-12 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-12-11 11:50:26) > Similar to the r_pipe sspp protect, add a check to protect > the pipe state prints to avoid NULL ptr dereference for cases when > the state is dumped without a corresponding atomic_check() where the > pipe->sspp is assigned. > > Fixes: 31f7148fd370 ("dr

[PULL] drm-xe-fixes

2024-12-12 Thread Thomas Hellstrom
Dave, Simona This week'd drm-xe-fixes PR. Thanks, Thomas drm-xe-fixes-2024-12-12: - Fix a KUNIT test error message (Mirsad Todorovac) - Fix an invalidation fence PM ref leak (Daniele) - Fix a register pool UAF (Lucas) The following changes since commit 5dce85fecb87751ec94526e1ac516dd7871e2e0c:

[PATCH v11 2/2] drm/amdgpu: Enable async flip on overlay planes

2024-12-12 Thread André Almeida
amdgpu can handle async flips on overlay planes, so allow it for atomic async checks. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amd

[PATCH v11 0/2] drm/atomic: Ease async flip restrictions

2024-12-12 Thread André Almeida
Hi, The goal of this work is to find a nice way to allow amdgpu to perform async page flips in the overlay plane as well, not only on the primary one. Currently, when using the atomic uAPI, this is the only type of plane allowed to do async flips, and every driver accepts it. This patchset re-use

[PATCH v11 1/2] drm/atomic: Let drivers decide which planes to async flip

2024-12-12 Thread André Almeida
Currently, DRM atomic uAPI allows only primary planes to be flipped asynchronously. However, each driver might be able to perform async flips in other different plane types. To enable drivers to set their own restrictions on which type of plane they can or cannot flip, use the existing atomic_async

[PATCH 0/1] drm/amdgpu: Use device wedged event

2024-12-12 Thread André Almeida
Raag Jadav is introducing a new DRM API for generating "device wedged events", to notify userspace when the device needs userspace intervention after a GPU reset[1]. I did a simple patch to add support for it for amdgpu for the telemetry aspect of the event. Tested in Steam Deck. This patch require

Re: [PATCH v3 04/14] drm/msm/dp: pull I/O data out of msm_dp_catalog_private()

2024-12-12 Thread Abhinav Kumar
On 12/12/2024 12:52 AM, Dmitry Baryshkov wrote: On Thu, 12 Dec 2024 at 04:59, Abhinav Kumar wrote: On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: Having I/O regions inside a msm_dp_catalog_private() results in extra layers of one-line wrappers for accessing the data. Move I/O region base

[PATCH] drm/msm/dpu: Filter modes based on adjusted mode clock

2024-12-12 Thread Jessica Zhang
e-commit: 423c1c96d6b2d3bb35072e33a5fdd8db6d2c0a74 change-id: 20241212-filter-mode-clock-8cb2e769f05b Best regards, -- Jessica Zhang

Re: [PATCH v4 5/8] i2c: i2c-core-of: follow i2c-parent phandle to probe devices from added nodes

2024-12-12 Thread Sverdlin, Alexander
Hi Luca! On Tue, 2024-09-17 at 10:53 +0200, Luca Ceresoli wrote: > When device tree nodes are added, the I2C core tries to probe client > devices based on the classic DT structure: > > i2c@abcd { > some-client@42 { compatible = "xyz,blah"; ... }; > }; > > However for hotplug connec

[PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-12 Thread André Almeida
Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/

Re: [PATCH v3 2/2] leds: lp8864: New driver

2024-12-12 Thread Lee Jones
On Mon, 09 Dec 2024, A. Sverdlin wrote: > From: Alexander Sverdlin > > Add driver for TI LP8864, LP8864S, LP8866 4/6 channel LED-backlight drivers > with I2C interface. > > Link: https://www.ti.com/lit/gpn/lp8864-q1 > Link: https://www.ti.com/lit/gpn/lp8864s-q1 > Link: https://www.ti.com/lit/gp

Re: [PATCH v3 13/14] drm/msm/dp: drop struct msm_dp_panel_in

2024-12-12 Thread Abhinav Kumar
On 12/12/2024 12:53 AM, Dmitry Baryshkov wrote: On Thu, 12 Dec 2024 at 05:26, Abhinav Kumar wrote: On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: All other submodules pass arguments directly. Drop struct msm_dp_panel_in that is used to wrap dp_panel's submodule args and pass all data to

Re: [PATCH v3 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-12 Thread Abhinav Kumar
On 12/12/2024 10:31 AM, Abhinav Kumar wrote: On 12/12/2024 12:58 AM, Dmitry Baryshkov wrote: On Wed, Dec 11, 2024 at 05:14:18PM -0800, Abhinav Kumar wrote: On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: Rather than printing random garbage from stack and pretending that it is the defaul

Re: [PATCH v10 2/4] drm/doc: Document device wedged event

2024-12-12 Thread André Almeida
Em 28/11/2024 12:37, Raag Jadav escreveu: Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions, prerequisites and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) v9: Add prerequisites secti

Re: [PATCH v2 1/3] fbdev: Fix recursive dependencies wrt BACKLIGHT_CLASS_DEVICE

2024-12-12 Thread Helge Deller
On 12/12/24 11:04, Thomas Zimmermann wrote: Do not select BACKLIGHT_CLASS_DEVICE from FB_BACKLIGHT. The latter only controls backlight support within fbdev core code and data structures. Make fbdev drivers depend on BACKLIGHT_CLASS_DEVICE and let users select it explicitly. Fixes warnings about

Re: [PATCH v3 3/7] dt-bindings: gpio: brcmstb: permit gpio-line-names property

2024-12-12 Thread Florian Fainelli
On 12/12/24 10:36, Dave Stevenson wrote: gpio-line-names is a generic property that can be supported by any GPIO controller, so permit it through the binding. It is permitted to have a variable number of GPIOs per node based on brcm,gpio-bank-widths, so define an arbitrary maximum number of item

[PATCH v3 6/7] arm64: dts: broadcom: Correct hdmi device node names

2024-12-12 Thread Dave Stevenson
The names of the hdmi0 and hdmi1 nodes had addresses that didn't match the reg properties for the nodes. Fixes: f66b382affd8 ("arm64: dts: broadcom: Add display pipeline support to BCM2712") Signed-off-by: Dave Stevenson --- arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 4 ++-- 1 file changed, 2

[PATCH v3 7/7] arm64: dts: broadcom: Remove intc controller on BCM2712.

2024-12-12 Thread Dave Stevenson
The brcm,bcm2836-l1-intc controller isn't used on this platform. It is used on 32-bit kernels for the smp_boot_secondary hook, but BCM2712 can't run a 32-bit kernel. Remove the node. Fixes: e1417095a139 ("arm64: dts: broadcom: Add firmware clocks and power nodes to Pi5 DT") Signed-off-by: Dave S

[PATCH v3 5/7] arm64: dts: broadcom: Rename bcm2712 interrupt controllers

2024-12-12 Thread Dave Stevenson
CHECK_DTBS produces errors on bcm2712-rpi-5-b.dtb and bcm2712-d-rpi-5-b.dtb of: intc@7d508380: $nodename:0: 'intc@7d508380' does not match '^interrupt-controller(@[0-9a-f,]+)*$' from schema $id: http://devicetree.org/schemas/interrupt-controller/brcm,l2-intc.yaml# intc@7d508400: $nodename

[PATCH v3 2/7] dt-bindings: display: Fix BCM2835 HVS bindings for BCM2712

2024-12-12 Thread Dave Stevenson
Commit 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") added the compatible string for BCM2712, but missed out that the number of interrupts and clocks changed too. Update to validate clock and interrupts for the variants. Fixes: 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HV

[PATCH v3 4/7] dt-bindings: interrupt-controller: brcm,bcm2836-l1-intc: Drop interrupt-controller requirement

2024-12-12 Thread Dave Stevenson
Since commit 88bbe85dcd37 ("irqchip: bcm2836: Move SMP startup code to arch/arm (v2)") the bcm2836-l1-intc block on bcm2711 is only used as a base address for the smp_boot_secondary hook on 32 bit kernels. It is not used as an interrupt controller. Drop the binding requirement for interrupt-contro

[PATCH v3 1/7] dt-bindings: display: bcm2711-hdmi: Add interrupt details for BCM2712

2024-12-12 Thread Dave Stevenson
Commit 62948c62abca ("dt-bindings: display: Add BCM2712 HDMI bindings") added the compatible strings for BCM2712, but missed out that the number of interrupts changed. Update the schema to include the interrupt requirements. Fixes: 62948c62abca ("dt-bindings: display: Add BCM2712 HDMI bindings")

[PATCH v3 3/7] dt-bindings: gpio: brcmstb: permit gpio-line-names property

2024-12-12 Thread Dave Stevenson
gpio-line-names is a generic property that can be supported by any GPIO controller, so permit it through the binding. It is permitted to have a variable number of GPIOs per node based on brcm,gpio-bank-widths, so define an arbitrary maximum number of items based on current users. Signed-off-by: D

[PATCH v3 0/7] drm/vc4: Fixup DT and DT binding issues from recent patchset

2024-12-12 Thread Dave Stevenson
83c8...@raspberrypi.com/ Signed-off-by: Dave Stevenson --- Changes in v3: - Fixed up indentation on 1/7. (I fixed it once, but obviously reworked things and lost it). - Link to v2: https://lore.kernel.org/r/20241212-dt-bcm2712-fixes-v2-0-35986e04d...@raspberrypi.com Thanks to Stefan and Krzys

Re: [PATCH v3 01/14] drm/msm/dp: set safe_to_exit_level before printing it

2024-12-12 Thread Abhinav Kumar
On 12/12/2024 12:58 AM, Dmitry Baryshkov wrote: On Wed, Dec 11, 2024 at 05:14:18PM -0800, Abhinav Kumar wrote: On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: Rather than printing random garbage from stack and pretending that it is the default safe_to_exit_level, set the variable beforehand

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-12 Thread André Almeida
Hi Raag, Thank you for your patch. Em 28/11/2024 12:37, Raag Jadav escreveu: [...] +int drm_dev_wedged_event(struct drm_device *dev, unsigned long method) +{ + const char *recovery = NULL; + unsigned int len, opt; + /* Event string length up to 28+ characters with available

Re: [PATCH 2/2] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

2024-12-12 Thread 林睿祥

Re: [PATCH 2/2] dts: arm64: mediatek: mt8188: Update OVL compatible from MT8183 to MT8195

2024-12-12 Thread 林睿祥

Re: [PATCH v2 1/7] dt-bindings: display: bcm2711-hdmi: Add interrupt details for BCM2712

2024-12-12 Thread Rob Herring (Arm)
hdmi.yaml:84:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241212-dt-bcm2712-fixes-v2-1-35986e04d...@raspberrypi.com The base for

Re: [PATCH v1 2/2] drm/panel: add Raydium RM67200 panel driver

2024-12-12 Thread Jessica Zhang
On 12/10/2024 2:41 PM, Sebastian Reichel wrote: Hello Jessica, On Tue, Dec 10, 2024 at 09:45:09AM -0800, Jessica Zhang wrote: [...] +static const struct raydium_rm67200_panel_info w552793baa_info = { + .mode = { + .clock = 132000, + .hdisplay = 1080, +

Re: [PATCH v2 1/8] dt-bindings: mailbox: mediatek: Add GCE header file for MT8196

2024-12-12 Thread 林睿祥

Re: [RFC] drm/msm: Add UABI to request perfcntr usage

2024-12-12 Thread Rob Clark
On Thu, Dec 12, 2024 at 9:08 AM Rob Clark wrote: > > On Thu, Dec 12, 2024 at 7:59 AM Akhil P Oommen > wrote: > > > > On 12/5/2024 10:24 PM, Rob Clark wrote: > > > From: Rob Clark > > > > > > Performance counter usage falls into two categories: > > > > > > 1. Local usage, where the counter confi

[PATCH 06/12] drm/i915/display: fbdev: Move custom suspend code to new callback

2024-12-12 Thread Thomas Zimmermann
If the fbdev buffer is backed by stolen memory, it has to be cleared upon resume from hibernation. Move the code into the new callback fb_set_suspend, so that it can run from DRM's generic fbdev client. No functional change. Other drivers are not affected. Signed-off-by: Thomas Zimmermann --- dr

  1   2   3   >