Re: [PATCH v1 7/7] drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188

2024-11-25 Thread 胡俊光

Re: [PATCH v2 1/3] drm/modes: introduce drm_mode_validate_mode() helper function

2024-11-25 Thread Sean Nyekjaer
Hi Maxime, On Mon, Nov 25, 2024 at 05:00:56PM +0100, Maxime Ripard wrote: > Hi Sean, > > On Mon, Nov 25, 2024 at 02:49:26PM +0100, Sean Nyekjaer wrote: > > Check if the required pixel clock is in within .5% range of the > > desired pixel clock. > > This will match the requirement for HDMI where a

Re: [PATCH 1/4] dt-bindings: arm: qcom: Add HP Omnibook X 14

2024-11-25 Thread Krzysztof Kozlowski
On Sun, Nov 24, 2024 at 02:20:15PM +0100, Jens Glathe wrote: > Add compatible values for the HP Omnibook X Laptop 14-fe0750ng, > using "hp,omnibook-x14" > > The laptop is based on the Snapdragon X Elite (x1e80100) SoC. > > PDF link: https://www8.hp.com/h20195/V2/GetPDF.aspx/c08989140 > > Signed-

Re: [DO NOT MERGE PATCH v4 15/19] dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes

2024-11-25 Thread Krzysztof Kozlowski
On 26/11/2024 08:33, Liu Ying wrote: > On 11/26/2024, Krzysztof Kozlowski wrote: >> On Mon, Nov 25, 2024 at 05:33:12PM +0800, Liu Ying wrote: >>> Document SCU controlled display pixel link child nodes. >>> >>> Signed-off-by: Liu Ying >>> --- >>> v4: >>> * No change. >>> >>> v3: >>> * No change. >>

Re: [DO NOT MERGE PATCH v4 15/19] dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes

2024-11-25 Thread Liu Ying
On 11/26/2024, Krzysztof Kozlowski wrote: > On Mon, Nov 25, 2024 at 05:33:12PM +0800, Liu Ying wrote: >> Document SCU controlled display pixel link child nodes. >> >> Signed-off-by: Liu Ying >> --- >> v4: >> * No change. >> >> v3: >> * No change. >> >> v2: >> * New patch as needed by display contr

Re: [DO NOT MERGE PATCH v4 15/19] dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes

2024-11-25 Thread Krzysztof Kozlowski
On Mon, Nov 25, 2024 at 05:33:12PM +0800, Liu Ying wrote: > Document SCU controlled display pixel link child nodes. > > Signed-off-by: Liu Ying > --- > v4: > * No change. > > v3: > * No change. > > v2: > * New patch as needed by display controller subsystem device tree. DO NOT MERGE means also

Re: [PATCH 0/5] clk: Fix simple video pipelines on i.MX8

2024-11-25 Thread Liu Ying
On 11/22/2024, Miquel Raynal wrote: > Hello Liu, Hello Miquel, > > Thanks for the feedback! > > On 22/11/2024 at 14:01:49 +08, Liu Ying wrote: > >> Hi Miquel, >> >> On 11/22/2024, Miquel Raynal wrote: >>> Recent changes in the clock tree have set CLK_SET_RATE_PARENT to the two >>> LCDIF pixel

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-25 Thread Raag Jadav
On Mon, Nov 25, 2024 at 10:32:42AM +0100, Christian König wrote: > Am 22.11.24 um 17:02 schrieb Raag Jadav: > > On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: > > > Am 22.11.24 um 08:07 schrieb Raag Jadav: > > > > On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote:

Re: [PATCH v1 5/6] drm/mediatek: mtk_dpi: Add checks for reg_h_fre_con existence

2024-11-25 Thread 胡俊光

[PATCH v7 2/3] gpu: drm: panel: replace of_graph_get_next_endpoint()

2024-11-25 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r

[PATCH v7 3/3] gpu: drm: tiny: replace of_graph_get_next_endpoint()

2024-11-25 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r

[PATCH v7 1/3] gpu: drm: drm_of: replace of_graph_get_next_endpoint()

2024-11-25 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r

[PATCH v7 0/3] gpu: drm: replace of_graph_get_next_endpoint()

2024-11-25 Thread Kuninori Morimoto
Hi Maarten, Maxime, Thomas Cc Laurent The patch has been created as 1 patch for "drivers/gpu/drm", but this time I have finely disassembled the patch into 3 patches. v6 -> v7 - created as 3 patches Kuninori Morimoto (3): gpu: drm: drm_of: replace of_graph_get_next_endpoint() gpu: d

[PATCH v5 1/5] drm/virtio: Implement VIRTIO_GPU_CMD_RESOURCE_DETACH_BACKING cmd

2024-11-25 Thread Vivek Kasireddy
This cmd is useful to let the VMM (i.e, Qemu) know that the backing store associated with a resource is no longer valid, so that the VMM can perform any cleanup or unmap operations. The fence related changes and virtio_gpu_object_detach()/ virtio_gpu_detach_object_fenced() routines are extracted f

Re: [PATCH v4 1/2] init/Kconfig: add python3 availability config

2024-11-25 Thread Masahiro Yamada
On Sat, Nov 23, 2024 at 5:42 AM Petr Vorel wrote: > > > On Thu, Nov 21, 2024 at 10:49 AM Rob Clark wrote: > > > > On Wed, Nov 20, 2024 at 5:17 PM Petr Vorel wrote: > > > > > > On Thu, Nov 21, 2024 at 5:41 AM Petr Vorel wrote: > > > > > > > It will be used in the next commit for DRM_MSM. > > > >

[PATCH v5 5/5] drm/virtio: Add prepare and cleanup routines for imported dmabuf obj

2024-11-25 Thread Vivek Kasireddy
When an imported dmabuf obj is used as part of an atomic commit, we need to pin it as part of prepare and unpin it during cleanup of the associated FB, to make sure that it does not move until the commit is completed (and also while it is being used on the Host). Cc: Gerd Hoffmann Cc: Dmitry Osip

[PATCH v5 3/5] drm/virtio: Add helpers to initialize and free the imported object

2024-11-25 Thread Vivek Kasireddy
The imported object can be considered a guest blob resource; therefore, we use create_blob cmd while creating it. These helpers are used in the next patch which does the actual import. Cc: Gerd Hoffmann Cc: Dmitry Osipenko Cc: Rob Clark Cc: Gurchetan Singh Cc: Chia-I Wu Signed-off-by: Vivek K

[PATCH v5 4/5] drm/virtio: Import prime buffers from other devices as guest blobs

2024-11-25 Thread Vivek Kasireddy
By importing scanout buffers from other devices, we should be able to use the virtio-gpu driver in KMS only mode. Note that we attach dynamically and register a move_notify() callback so that we can let the VMM know of any location changes associated with the backing store of the imported object by

[PATCH v5 0/5] drm/virtio: Import scanout buffers from other devices

2024-11-25 Thread Vivek Kasireddy
Having virtio-gpu import scanout buffers (via prime) from other devices means that we'd be adding a head to headless GPUs assigned to a Guest VM or additional heads to regular GPU devices that are passthrough'd to the Guest. In these cases, the Guest compositor can render into the scanout buffer us

[PATCH v5 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-11-25 Thread Vivek Kasireddy
This helper would be used when first initializing the object as part of import and also when updating the plane where we need to ensure that the imported object's backing is valid. Cc: Gerd Hoffmann Cc: Dmitry Osipenko Cc: Rob Clark Cc: Gurchetan Singh Cc: Chia-I Wu Signed-off-by: Vivek Kasir

RE: [PATCH v4 4/5] drm/virtio: Import prime buffers from other devices as guest blobs

2024-11-25 Thread Kasireddy, Vivek
Hi Dmitry, > Subject: Re: [PATCH v4 4/5] drm/virtio: Import prime buffers from other > devices as guest blobs > > > struct drm_gem_object *virtgpu_gem_prime_import(struct drm_device > *dev, > > struct dma_buf *buf) > > { > > + struct virtio_gpu_devi

RE: [PATCH v4 2/5] drm/virtio: Add a helper to map and note the dma addrs and lengths

2024-11-25 Thread Kasireddy, Vivek
Hi Dmitry, > Subject: Re: [PATCH v4 2/5] drm/virtio: Add a helper to map and note the > dma addrs and lengths > > > +int virtgpu_dma_buf_import_sgt(struct virtio_gpu_mem_entry **ents, > > + unsigned int *nents, > > + struct virtio_gpu_object *bo,

Re: [PATCH v1 6/6] drm/mediatek: Add support for MT8195 Digital Parallel Interface

2024-11-25 Thread 胡俊光

Re: [PATCH v2 3/3] drm/msm/mdss: use boolean values for macrotile_mode

2024-11-25 Thread Abhinav Kumar
On 11/22/2024 9:44 PM, Dmitry Baryshkov wrote: The macrotile_mode is a flag, not a bit value. Use true/false values to set it rather than 1/0. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Revie

Re: [PATCH v2 2/3] drm/msm/mdss: reuse defined bitfields for UBWC 2.0

2024-11-25 Thread Abhinav Kumar
On 11/22/2024 9:44 PM, Dmitry Baryshkov wrote: Follow other msm_mdss_setup_ubwc_dec_nn functions and use individual bits instead of just specifying the value to be programmed to the UBWC_STATIC register. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 17 +-

Re: [DO NOT MERGE PATCH v4 16/19] arm64: dts: imx8qxp: Add display controller subsystem

2024-11-25 Thread Liu Ying
On 11/25/2024, Francesco Dolcini wrote: > On Mon, Nov 25, 2024 at 05:33:13PM +0800, Liu Ying wrote: >> Add display controller subsystem in i.MX8qxp SoC. >> >> Signed-off-by: Liu Ying > > ... > >> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi >> b/arch/arm64/boot/dts/freescale/imx8qxp.

Re: [PATCH v2 1/3] drm/msm/mdss: define bitfields for the UBWC_STATIC register

2024-11-25 Thread Abhinav Kumar
On 11/22/2024 9:44 PM, Dmitry Baryshkov wrote: Rather than hand-coding UBWC_STATIC value calculation, define corresponding bitfields and use them to setup the register value. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 38 +++---

Re: [PATCH v3 7/9] drm/msm/dsi: Add support for SM6150

2024-11-25 Thread fange zhang
On 2024/11/26 6:11, Dmitry Baryshkov wrote: On Mon, 25 Nov 2024 at 04:31, fange zhang wrote: On 2024/11/22 18:10, Dmitry Baryshkov wrote: On Fri, Nov 22, 2024 at 05:56:50PM +0800, Fange Zhang wrote: From: Li Liu Add support for DSI 2.3.1 (block used on SM6150). Signed-off-by: Li Liu

Re: [GIT PULL] fbdev fixes and cleanups for v6.13-rc1

2024-11-25 Thread pr-tracker-bot
The pull request you sent on Sun, 24 Nov 2024 18:38:26 +0100: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.13-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4e07155dd58cab024813e97dc384d48f34e3d16e Thank you! -- Dee

Re: [PATCH v5 drm-dp 1/5] drm/hisilicon/hibmc: add dp aux in hibmc

2024-11-25 Thread Yongbang Shi
在 2024/11/22 9:42, Dmitry Baryshkov 写道: On Mon, Nov 18, 2024 at 10:28:01PM +0800, Yongbang Shi wrote: From: baihan li Add dp aux read/write functions. They are basic functions and will be used later. Signed-off-by: Baihan Li Signed-off-by: Yongbang Shi --- ChangeLog: v4 -> v5: - fixing

Re: [PATCH v2 2/2] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-11-25 Thread Marek Vasut
On 11/25/24 2:17 PM, Maxime Ripard wrote: On Fri, Nov 22, 2024 at 03:32:57PM +0200, Dmitry Baryshkov wrote: On Tue, Nov 12, 2024 at 03:05:37AM +0100, Marek Vasut wrote: The Pixel PLL is not very capable and may come up with wildly inaccurate clock. Since DPI panels are often tolerant to slightl

Re: [PATCH v2 2/2] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-11-25 Thread Marek Vasut
On 11/22/24 2:32 PM, Dmitry Baryshkov wrote: On Tue, Nov 12, 2024 at 03:05:37AM +0100, Marek Vasut wrote: The Pixel PLL is not very capable and may come up with wildly inaccurate clock. Since DPI panels are often tolerant to slightly higher pixel clock without being operated outside of specifica

Re: [PATCH v5 3/5] drm/vkms: Switch to managed for crtc

2024-11-25 Thread Maíra Canal
Hi Louis, On 22/11/24 13:27, Louis Chauvet wrote: The current VKMS driver uses managed function to create crtc, but don't use it to properly clean the crtc workqueue. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers.

Re: [PATCH v5 2/5] drm/vkms: Switch to managed for encoder

2024-11-25 Thread Maíra Canal
Hi Louis, On 22/11/24 13:27, Louis Chauvet wrote: The current VKMS driver uses non-managed function to create encoders. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet Reviewed-by:

Re: [PATCH v5 1/5] drm/vkms: Switch to managed for connector

2024-11-25 Thread Maíra Canal
Hi Louis, On 22/11/24 13:27, Louis Chauvet wrote: The current VKMS driver uses non-managed function to create connectors. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet Reviewed-by

Re: [PATCH v4 3/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add bluetooth

2024-11-25 Thread Dmitry Baryshkov
On Mon, Nov 25, 2024 at 08:11:19PM +0100, Maud Spierings via B4 Relay wrote: > From: Maud Spierings > > Add bluetooth for the asus vivobook s15 > Describe wlan configuration > > Signed-off-by: Maud Spierings > --- > .../boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 164 > ++

Re: [PATCH v3 7/9] drm/msm/dsi: Add support for SM6150

2024-11-25 Thread Dmitry Baryshkov
On Mon, 25 Nov 2024 at 04:31, fange zhang wrote: > > > > On 2024/11/22 18:10, Dmitry Baryshkov wrote: > > On Fri, Nov 22, 2024 at 05:56:50PM +0800, Fange Zhang wrote: > >> From: Li Liu > >> > >> Add support for DSI 2.3.1 (block used on SM6150). > >> > >> Signed-off-by: Li Liu > >> Signed-off-by:

Re: [PATCH v3 9/9] arm64: dts: qcom: Add display support for QCS615 RIDE board

2024-11-25 Thread Dmitry Baryshkov
On Mon, 25 Nov 2024 at 09:39, fange zhang wrote: > > > > On 2024/11/22 18:22, Dmitry Baryshkov wrote: > > On Fri, Nov 22, 2024 at 05:56:52PM +0800, Fange Zhang wrote: > >> From: Li Liu > >> > >> Add display MDSS and DSI configuration for QCS615 RIDE board. > >> QCS615 has a DP port, and DP suppor

Re: [PATCH v2 2/2] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-11-25 Thread Dmitry Baryshkov
On Mon, 25 Nov 2024 at 15:17, Maxime Ripard wrote: > > On Fri, Nov 22, 2024 at 03:32:57PM +0200, Dmitry Baryshkov wrote: > > On Tue, Nov 12, 2024 at 03:05:37AM +0100, Marek Vasut wrote: > > > The Pixel PLL is not very capable and may come up with wildly inaccurate > > > clock. Since DPI panels are

Re: [PATCH v3 06/10] ARM: dts: ti: omap: espresso-common: Add common device tree for Samsung Galaxy Tab 2 series

2024-11-25 Thread Andreas Kemnade
Am Sat, 23 Nov 2024 18:14:05 + schrieb Mithil Bavishi : > > > + no-map; > > > + reg = <0xA000 0x20>; > > > > If used for ramoops, then there should be a compatible = "ramoops" > > see Documentation/devicetree/bindings/reserved-memory/ramoops.yaml > >

Re: [PATCH] drm/dp_mst: Fix MST sideband message body length check

2024-11-25 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2024-11-25 at 22:53 +0200, Imre Deak wrote: > Fix the MST sideband message body length check, which must be at least 1 > byte accounting for the message body CRC (aka message data CRC) at the > end of the message. > > This fixes a case where an MST branch device r

[PATCH] drm/dp_mst: Fix MST sideband message body length check

2024-11-25 Thread Imre Deak
Fix the MST sideband message body length check, which must be at least 1 byte accounting for the message body CRC (aka message data CRC) at the end of the message. This fixes a case where an MST branch device returns a header with a correct header CRC (indicating a correctly received body length),

Re: [PATCH 2/4] drm/vmwgfx: use the new drm_exec object v2

2024-11-25 Thread Ian Forbes
Breaks userspace command submission. Here's the log with lock debugging on. ``` [ 20.438106] [ 20.439696] WARNING: lock held when returning to user space! [ 20.441730] 6.12.0+ #11 Not tainted [ 20.442389]

Re: [PATCH 1/4] drm/vmwgfx: start to phase out ttm_exec v2

2024-11-25 Thread Ian Forbes
Tested working. Tested-by: Ian Forbes On Thu, Nov 21, 2024 at 4:27 AM Christian König wrote: > > Start switching over vmwgfx to drm_exec as well. Replacing some > unnecessary complex calls with just just single BO dma_resv locking. > > No intentional functional change, but only compile tested f

[PATCH] drm/xen-front: cast calculation to __u64 in xen_drm_drv_dumb_create()

2024-11-25 Thread Gax-c
From: Zichen Xie Like commit b0b0d811eac6 ("drm/mediatek: Fix coverity issue with unintentional integer overflow"), directly multiply args->pitch and args->height may lead to integer overflow. Add a cast to avoid it. Signed-off-by: Zichen Xie --- drivers/gpu/drm/xen/xen_drm_front.c | 2 +- 1 f

Re: [PATCH v4 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-11-25 Thread Detlev Casanova
Hi Andy, Yes, the issue can be reproduced with the details in patch 2/3 [1]. [1]: https://lore.kernel.org/linux-arm-kernel/20241115162120.83990-3-detlev.casan...@collabora.com/T/#m82b38f4a83c4793bb82919bf736b2f6bd804a283 Detlev. On Monday, 25 November 2024 02:55:41 EST Andy Yan wrote: > Hello

[PATCH v4 2/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add lid switch

2024-11-25 Thread Maud Spierings via B4 Relay
From: Maud Spierings Add the lid switch for the Asus vivobook s15 Reviewed-by: Konrad Dybcio Signed-off-by: Maud Spierings --- .../boot/dts/qcom/x1e80100-asus-vivobook-s15.dts| 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-

[PATCH v4 3/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add bluetooth

2024-11-25 Thread Maud Spierings via B4 Relay
From: Maud Spierings Add bluetooth for the asus vivobook s15 Describe wlan configuration Signed-off-by: Maud Spierings --- .../boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 164 + 1 file changed, 164 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivo

[PATCH v4 0/3] Asus vivobook s15 improvements

2024-11-25 Thread Maud Spierings via B4 Relay
Improves several parts of the devicetree: 1. The eDP panel bindings 2. Add a lid switch 3. Add bluetooth and describe wlan (depends on [1]) [1]: https://lore.kernel.org/all/20241007-x1e80100-pwrseq-qcp-v1-0-f7166510a...@linaro.org/ --- I seem to get a warning that the pci17cb vendor is undocumen

[PATCH v4 1/3] arm64: dts: qcom: x1e80100-vivobook-s15: Use the samsung,atna33xc20 panel driver

2024-11-25 Thread Maud Spierings via B4 Relay
From: Maud Spierings The Asus vivobook s15 uses the ATNA56AC03 panel. This panel is controlled by the atna33xc20 driver instead of the generic edp-panel driver Signed-off-by: Maud Spierings --- .../arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 18 +- 1 file changed, 17 i

Re: [PATCH 1/2] dt-bindings: display: simple: Document Multi-Inno Technology MI0700A2T-30 panel

2024-11-25 Thread Conor Dooley
On Mon, Nov 25, 2024 at 02:33:35AM +0100, Marek Vasut wrote: > Add Multi-Inno Technology MI0700A2T-30 7" 800x480 LVDS panel > compatible string. > > Signed-off-by: Marek Vasut > --- > Cc: Conor Dooley Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH 1/2] dt-bindings: gpu: add reset control property

2024-11-25 Thread Conor Dooley
On Mon, Nov 25, 2024 at 10:07:03PM +0530, Parthiban Nallathambi wrote: > GE8300 in Allwinner A133 have reset control from the ccu. > Add the resets property as optional one to control it. There's no specific compatible here for an a133, but the binding requires one. Where is your dts patch? > >

Re: [PATCH 3/4] drm/panel-edp: Add unknown BOE panel for HP Omnibook X14

2024-11-25 Thread Doug Anderson
Hi, On Sun, Nov 24, 2024 at 5:20 AM Jens Glathe via B4 Relay wrote: > > From: Jens Glathe > > Seems to be like NV140DRM-N61 but with touch. Haven't disassembled > the lid to look. > > Due to lack of information, use the delay_200_500_e200 timings like > many other BOE panels do for now. > > The

Re: [PATCH v3 2/4] arm64: dts: qcom: x1e80100-vivobook-s15: Use the samsung,atna33xc20 panel driver

2024-11-25 Thread Maud Spierings
On 11/25/24 1:21 PM, Konrad Dybcio wrote: On 24.11.2024 11:00 AM, Maud Spierings via B4 Relay wrote: From: Maud Spierings The Asus vivobook s15 uses the ATNA56AC03 panel. This panel is controlled by the atna33xc20 driver instead of the generic edp-panel driver Signed-off-by: Maud Spierings -

Re: [PATCH] drm/panel: st7701: Add prepare_prev_first flag to drm_panel

2024-11-25 Thread Jessica Zhang
On 11/24/2024 2:48 PM, Marek Vasut wrote: The DSI host must be enabled for the panel to be initialized in prepare(). Set the prepare_prev_first flag to guarantee this. This fixes the panel operation on NXP i.MX8MP SoC / Samsung DSIM DSI host. Hi Marek, LGTM. Reviewed-by: Jessica Zhang Th

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-25 Thread Matthew Brost
On Mon, Nov 25, 2024 at 05:19:54PM +0100, Christian König wrote: > Am 25.11.24 um 16:29 schrieb Matthew Brost: > > On Fri, Nov 15, 2024 at 10:27:59AM -0800, Matthew Brost wrote: > > > [SNIP] > > > We use this interface to read a BO marked with a dumpable flag during a > > > GPU hang in our error ca

[PATCH] drm: cast calculation to __u64 in qxl_mode_dumb_create()

2024-11-25 Thread Gax-c
From: Zichen Xie Like commit b0b0d811eac6 ("drm/mediatek: Fix coverity issue with unintentional integer overflow"), directly multiply pitch and args->height may lead to integer overflow. Add a cast to avoid it. Signed-off-by: Zichen Xie --- drivers/gpu/drm/qxl/qxl_dumb.c | 2 +- 1 file changed

Re: [PATCH] nouveau: fw: sync dma after setup is called.

2024-11-25 Thread Danilo Krummrich
On 11/14/24 1:46 AM, Dave Airlie wrote: From: Dave Airlie When this code moved to non-coherent allocator the sync was put too early for some firmwares which called the setup function, move the sync down after the setup function. Reported-by: Diogo Ivo Do you have a link of where this issue

Re: [PATCH v3 1/4] dt-bindings: display: panel: samsung,atna56ac03: Document ATNA56AC03

2024-11-25 Thread Doug Anderson
Hi, On Sun, Nov 24, 2024 at 2:01 AM Maud Spierings via B4 Relay wrote: > > From: Maud Spierings > > The Samsung ATNA56AC03 panel is an AMOLED eDP panel. > It is similar to the ATNA33xc20 except it is larger and has a different > resolution. > > Signed-off-by: Maud Spierings > --- > Documentati

Re: [PATCH v4 3/5] drm/virtio: Add helpers to initialize and free the imported object

2024-11-25 Thread Dmitry Osipenko
On 11/25/24 19:27, Dmitry Osipenko wrote: > On 11/25/24 10:31, Vivek Kasireddy wrote: >> +static void virtgpu_dma_buf_free_obj(struct drm_gem_object *obj) >> +{ >> +struct virtio_gpu_object *bo = gem_to_virtio_gpu_obj(obj); >> +struct virtio_gpu_device *vgdev = obj->dev->dev_private; >> +

Re: [PATCH v1 6/6] drm/mediatek: Add support for MT8195 Digital Parallel Interface

2024-11-25 Thread AngeloGioacchino Del Regno
Il 22/11/24 08:23, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Wed, 2024-11-20 at 13:44 +0100, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the content. Add support for the DPI block found in the MT8195 and

Re: [PATCH v1 3/6] drm/mediatek: mtk_dpi: Use an array for pixclk factor calculation

2024-11-25 Thread AngeloGioacchino Del Regno
Il 22/11/24 07:23, CK Hu (胡俊光) ha scritto: Hi, Angelo: On Fri, 2024-11-22 at 11:54 +0800, CK Hu wrote: Hi, Angelo: On Wed, 2024-11-20 at 13:44 +0100, AngeloGioacchino Del Regno wrote: External email : Please do not click links or open attachments until you have verified the sender or the con

Re: [PATCH v2 1/2] drm/msm/adreno: Introduce ADRENO_QUIRK_NO_SYSCACHE

2024-11-25 Thread Dmitry Baryshkov
On Mon, Nov 25, 2024 at 10:03:00PM +0530, Akhil P Oommen wrote: > There are a few chipsets which don't have system cache a.k.a LLC. > Currently, the assumption in the driver is that the system cache > availability correlates with the presence of GMU or RPMH, which > is not true. For instance, Snapd

Re: [PATCH v4 3/5] drm/virtio: Add helpers to initialize and free the imported object

2024-11-25 Thread Dmitry Osipenko
On 11/25/24 10:31, Vivek Kasireddy wrote: > +static void virtgpu_dma_buf_free_obj(struct drm_gem_object *obj) > +{ > + struct virtio_gpu_object *bo = gem_to_virtio_gpu_obj(obj); > + struct virtio_gpu_device *vgdev = obj->dev->dev_private; > + struct dma_buf_attachment *attach = obj->imp

Re: [PATCH v4 4/5] drm/virtio: Import prime buffers from other devices as guest blobs

2024-11-25 Thread Dmitry Osipenko
On 11/25/24 10:31, Vivek Kasireddy wrote: > struct drm_gem_object *virtgpu_gem_prime_import(struct drm_device *dev, > struct dma_buf *buf) > { > + struct virtio_gpu_device *vgdev = dev->dev_private; > + struct dma_buf_attachment *attach; > +

[PATCH v2 0/2] Support for Adreno 612 GPU

2024-11-25 Thread Akhil P Oommen
Mesa support is already available for A612. Verified Glmark2 with weston. Some dependencies for the devicetree change are not yet available in the mailing lists. I will send it out as a separate patch later. In v2 of this series, there is a new patch to check the LLC support by using a new QUIRK

[PATCH v2 2/2] drm/msm/a6xx: Add support for Adreno 612

2024-11-25 Thread Akhil P Oommen
From: Jie Zhang Add support for Adreno 612 GPU found in SM6150/QCS615 chipsets. A612 falls under ADRENO_6XX_GEN1 family and is a cut down version of A615 GPU. A612 has a new IP called Reduced Graphics Management Unit or RGMU which is a small state machine which helps to toggle GX GDSC (connected

[PATCH v2 1/2] drm/msm/adreno: Introduce ADRENO_QUIRK_NO_SYSCACHE

2024-11-25 Thread Akhil P Oommen
There are a few chipsets which don't have system cache a.k.a LLC. Currently, the assumption in the driver is that the system cache availability correlates with the presence of GMU or RPMH, which is not true. For instance, Snapdragon 6 Gen 1 has RPMH and a GPU with a full blown GMU, but doesnot have

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-25 Thread Christian König
Am 25.11.24 um 16:29 schrieb Matthew Brost: On Fri, Nov 15, 2024 at 10:27:59AM -0800, Matthew Brost wrote: [SNIP] We use this interface to read a BO marked with a dumpable flag during a GPU hang in our error capture code. This is an internal KMD feature, not directly exposed to user space. Would

Re: [PATCH v2 2/3] drm/sun4i: use drm_mode_validate_mode() helper function

2024-11-25 Thread Chen-Yu Tsai
On Mon, Nov 25, 2024 at 9:50 PM Sean Nyekjaer wrote: > > Use new helper function for HDMI mode validation This is a bit misleading since this is actually the DPI or parallel output encoder, not HDMI. HDMI is in drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c and drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c Chen

Re: [PATCH v2 2/3] drm/sun4i: use drm_mode_validate_mode() helper function

2024-11-25 Thread Maxime Ripard
On Mon, 25 Nov 2024 14:49:27 +0100, Sean Nyekjaer wrote: > Use new helper function for HDMI mode validation > > Signed-off-by: Sean Nyekjaer Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v2 3/3] drm/stm: dsi: use drm_mode_validate_mode() helper function

2024-11-25 Thread Maxime Ripard
On Mon, 25 Nov 2024 14:49:28 +0100, Sean Nyekjaer wrote: > When using the DSI interface via DSI2LVDS bridge, it seems a bit harsh > to reguire the requested and the actual px clock to be within > 50Hz. A typical LVDS display requires the px clock to be within +-10%. > > In case for HDMI .5% tolera

Re: [PATCH v2 1/3] drm/modes: introduce drm_mode_validate_mode() helper function

2024-11-25 Thread Maxime Ripard
Hi Sean, On Mon, Nov 25, 2024 at 02:49:26PM +0100, Sean Nyekjaer wrote: > Check if the required pixel clock is in within .5% range of the > desired pixel clock. > This will match the requirement for HDMI where a .5% tolerance is allowed. > > Signed-off-by: Sean Nyekjaer > --- > drivers/gpu/drm/

Re: [PATCH] drm/i915: Fixed an typo in i915_gem_gtt.c

2024-11-25 Thread Rodrigo Vivi
On Wed, Nov 20, 2024 at 08:32:45PM +0800, Zhang He wrote: > in function `i915_gem_gtt_reserve` @node comment, > i915_vma has no `mode` member, `i915_vma.node` is the correct name > > Signed-off-by: Zhang He Reviewed-by: Rodrigo Vivi and pushed to drm-intel-next. Thanks for the patch > --- >

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Hector Martin
On November 25, 2024 4:28:00 PM GMT+01:00, Maxime Ripard wrote: >On Mon, Nov 25, 2024 at 11:24:25PM +0900, Hector Martin wrote: >> >> >> On 2024/11/25 20:24, Sasha Finkelstein wrote: >> > On Mon, 25 Nov 2024 at 09:50, Neil Armstrong >> > wrote: >> >> >> >> So this controller only supports a s

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread neil . armstrong
Hi Hector, On 25/11/2024 15:24, Hector Martin wrote: On 2024/11/25 20:24, Sasha Finkelstein wrote: On Mon, 25 Nov 2024 at 09:50, Neil Armstrong wrote: So this controller only supports a single mode ??? Most likely. On all devices it is connected to a single built-in display. More s

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-25 Thread Matthew Brost
On Fri, Nov 15, 2024 at 10:27:59AM -0800, Matthew Brost wrote: > On Wed, Nov 13, 2024 at 12:42:35PM +0100, Christian König wrote: > > Am 13.11.24 um 11:44 schrieb Thomas Hellström: > > > On Wed, 2024-11-13 at 09:37 +0100, Christian König wrote: > > > > Am 12.11.24 um 17:33 schrieb Thomas Hellström:

Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings

2024-11-25 Thread Hector Martin
On 2024/11/25 23:53, Krzysztof Kozlowski wrote: > On 25/11/2024 15:14, Hector Martin wrote: + + "#address-cells": +const: 1 + + "#size-cells": +const: 0 + +additionalProperties: true >>> >>> This cannot be true. Must be false. >>> + +re

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Maxime Ripard
On Mon, Nov 25, 2024 at 11:24:25PM +0900, Hector Martin wrote: > > > On 2024/11/25 20:24, Sasha Finkelstein wrote: > > On Mon, 25 Nov 2024 at 09:50, Neil Armstrong > > wrote: > >> > >> So this controller only supports a single mode ??? > >> > > Most likely. On all devices it is connected to

Re: [PATCH v2] drm/panthor: register size of internal objects through fdinfo

2024-11-25 Thread Boris Brezillon
Hi Adrian, On Fri, 15 Nov 2024 19:14:18 + Adrián Larumbe wrote: > @@ -71,9 +112,9 @@ void panthor_kernel_bo_destroy(struct panthor_kernel_bo > *bo) > * Return: A valid pointer in case of success, an ERR_PTR() otherwise. > */ > struct panthor_kernel_bo * > -panthor_kernel_bo_create(stru

Re: [PATCH 3/5] gpu: drm: adp: Add a backlight driver for the Summit LCD

2024-11-25 Thread Krzysztof Kozlowski
On 25/11/2024 16:03, Nick Chan wrote: >>> +static int summit_probe(struct mipi_dsi_device *dsi) >>> +{ >>> + struct backlight_properties props = { 0 }; >>> + struct device *dev = &dsi->dev; >>> + struct summit_data *panel; >>> + >>> + panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL); >

Re: [PATCH 3/5] gpu: drm: adp: Add a backlight driver for the Summit LCD

2024-11-25 Thread Krzysztof Kozlowski
On 24/11/2024 23:29, Sasha Finkelstein via B4 Relay wrote: > From: Sasha Finkelstein > > This is the display panel used for the touchbar on laptops that have it. ... > +static int summit_probe(struct mipi_dsi_device *dsi) > +{ > + struct backlight_properties props = { 0 }; > + struct

Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings

2024-11-25 Thread Krzysztof Kozlowski
On 25/11/2024 15:14, Hector Martin wrote: >>> + >>> + "#address-cells": >>> +const: 1 >>> + >>> + "#size-cells": >>> +const: 0 >>> + >>> +additionalProperties: true >> >> This cannot be true. Must be false. >> >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - interrupts >> >>

Re: [PATCH v2] drm/lsdc: Request PCI BAR

2024-11-25 Thread Sui Jingfeng
Hi, Thanks. Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/lsdc: Request PCI BAR https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/ca053ee3c6a7a877754e6f444ce5f520e3c0a856 On 2024/11/25 22:02, Philipp Stanner wrote: lsdc currently just io

Re: [PATCH v1 1/7] dt-bindings: display: mediatek: Add binding for HDMIv2 DDC

2024-11-25 Thread AngeloGioacchino Del Regno
Il 21/11/24 22:02, Rob Herring ha scritto: On Wed, Nov 20, 2024 at 01:45:06PM +0100, AngeloGioacchino Del Regno wrote: Add a binding for the Display Data Channel (DDC) IP in MediaTek SoCs with version 2 HDMI TX IP. Signed-off-by: AngeloGioacchino Del Regno --- .../mediatek/mediatek,mt8195-h

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread Hector Martin
On 2024/11/25 20:24, Sasha Finkelstein wrote: > On Mon, 25 Nov 2024 at 09:50, Neil Armstrong > wrote: >> >> So this controller only supports a single mode ??? >> > Most likely. On all devices it is connected to a single built-in display. More specifically, the controller obviously support

Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings

2024-11-25 Thread Hector Martin
On 2024/11/25 16:45, Krzysztof Kozlowski wrote: > On Sun, Nov 24, 2024 at 11:29:24PM +0100, Sasha Finkelstein wrote: >> Add bindings for a secondary display controller present on certain >> Apple laptops. >> >> Signed-off-by: Sasha Finkelstein >> --- >> .../bindings/display/apple,display-pipe.yam

[PATCH v6] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-11-25 Thread carlos . song
From: Carlos Song Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When lpi2c send data, it is tx cmd register and tx data fifo. When lpi2c receive data, it is just a rx cmd register. LPI2C

[PATCH v2 0/3] drm/stm: dsi: relax mode_valid clock tolerance

2024-11-25 Thread Sean Nyekjaer
-commit: 28eb75e178d389d325f1666e422bc139804c change-id: 20241125-dsi-relax-1414baf6cd74 Best regards, -- Sean Nyekjaer

[PATCH v2 3/3] drm/stm: dsi: use drm_mode_validate_mode() helper function

2024-11-25 Thread Sean Nyekjaer
When using the DSI interface via DSI2LVDS bridge, it seems a bit harsh to reguire the requested and the actual px clock to be within 50Hz. A typical LVDS display requires the px clock to be within +-10%. In case for HDMI .5% tolerance is required. Signed-off-by: Sean Nyekjaer --- drivers/gpu/dr

[PATCH v2 1/3] drm/modes: introduce drm_mode_validate_mode() helper function

2024-11-25 Thread Sean Nyekjaer
Check if the required pixel clock is in within .5% range of the desired pixel clock. This will match the requirement for HDMI where a .5% tolerance is allowed. Signed-off-by: Sean Nyekjaer --- drivers/gpu/drm/drm_modes.c | 34 ++ include/drm/drm_modes.h | 2 +

[PATCH v2 2/3] drm/sun4i: use drm_mode_validate_mode() helper function

2024-11-25 Thread Sean Nyekjaer
Use new helper function for HDMI mode validation Signed-off-by: Sean Nyekjaer --- drivers/gpu/drm/sun4i/sun4i_rgb.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c index dfb6acc42f

[PATCH v2] drm/lsdc: Request PCI BAR

2024-11-25 Thread Philipp Stanner
lsdc currently just ioremaps its PCI BAR with pcim_iomap(). Performing a region regquest additionally can make the driver more robust. Replace pcim_iomap() with the managed function pcim_iomap_region() which performs the request and ioremaps the BAR. Signed-off-by: Philipp Stanner Reviewed-by: S

Re: [PATCH v2 2/2] drm/bridge: tc358767: Improve DPI output pixel clock accuracy

2024-11-25 Thread Maxime Ripard
On Fri, Nov 22, 2024 at 03:32:57PM +0200, Dmitry Baryshkov wrote: > On Tue, Nov 12, 2024 at 03:05:37AM +0100, Marek Vasut wrote: > > The Pixel PLL is not very capable and may come up with wildly inaccurate > > clock. Since DPI panels are often tolerant to slightly higher pixel clock > > without bei

Re: [PATCH 2/5] gpu: drm: adp: Add Apple Display Pipe driver

2024-11-25 Thread neil . armstrong
On 25/11/2024 14:14, Sasha Finkelstein wrote: On Mon, 25 Nov 2024 at 13:57, wrote: On 25/11/2024 12:24, Sasha Finkelstein wrote: On Mon, 25 Nov 2024 at 09:50, Neil Armstrong wrote: So this controller only supports a single mode ??? Most likely. On all devices it is connected to a sin

Re: [PATCHv2 3/3] drm/i915/display: Populate list of async supported formats/modifiers

2024-11-25 Thread kernel test robot
p),%rcx# 0xd0647 10: f7 d8 neg%eax 12: 64 89 01mov%eax,%fs:(%rcx) 15: 48 rex.W The kernel config and materials to reproduce are available at: https://download.01.org/0day-ci/archive/20241125/202411252029.30061fde-...@int

Re: [PATCH v5 2/5] drm/vkms: Switch to managed for encoder

2024-11-25 Thread Maxime Ripard
On Fri, 22 Nov 2024 17:27:57 +0100, Louis Chauvet wrote: > The current VKMS driver uses non-managed function to create encoders. It > is not an issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Signed-off-by: Louis Chauvet >

Re: [PATCH v5 3/5] drm/vkms: Switch to managed for crtc

2024-11-25 Thread Maxime Ripard
On Fri, 22 Nov 2024 17:27:58 +0100, Louis Chauvet wrote: > The current VKMS driver uses managed function to create crtc, but > don't use it to properly clean the crtc workqueue. It is not an > issue yet, but in order to support multiple devices easily, > convert this code to use drm and device mana

Re: [PATCH v5 1/5] drm/vkms: Switch to managed for connector

2024-11-25 Thread Maxime Ripard
On Fri, 22 Nov 2024 17:27:56 +0100, Louis Chauvet wrote: > The current VKMS driver uses non-managed function to create connectors. It > is not an issue yet, but in order to support multiple devices easily, > convert this code to use drm and device managed helpers. > > Signed-off-by: Louis Chauvet

Re: [PATCH v5 4/5] drm: writeback: Introduce drm managed helpers

2024-11-25 Thread Maxime Ripard
On Fri, Nov 22, 2024 at 05:27:59PM +0100, Louis Chauvet wrote: > Currently drm_writeback_connector are created by > drm_writeback_connector_init or drm_writeback_connector_init_with_encoder. > Both of the function uses drm_connector_init and drm_encoder_init, but > there is no way to properly clean

  1   2   >