Re: [PATCH v2] drm/panthor: Lock XArray when getting entries for the VM

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 18:58:06 + Liviu Dudau wrote: > Similar to cac075706f29 ("drm/panthor: Fix race when converting > group handle to group object") we need to use the XArray's internal > locking when retrieving a vm pointer from there. > > v2: Removed part of the patch that was trying to pr

Re: [PATCH v3 2/3] Subject: [PATCH] drm/mediatek/dp: Add HDCP2.x feature for DisplayPort

2024-11-06 Thread 胡俊光

Re: [PATCH] drm/v3d: Fix performance counter source settings on V3D 7.x

2024-11-06 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga El mié, 06-11-2024 a las 09:16 -0300, Maíra Canal escribió: > When the new register addresses were introduced for V3D 7.x, we added > new masks for performance counter sources on V3D 7.x.  Nevertheless, > we never apply these new masks when setting the sources. >

Re: [PATCH v2 02/10] sysfs: introduce callback attribute_group::bin_size

2024-11-06 Thread Greg Kroah-Hartman
On Thu, Nov 07, 2024 at 05:05:13AM +0900, Krzysztof Wilczyński wrote: > Hello, > > > Several drivers need to dynamically calculate the size of an binary > > attribute. Currently this is done by assigning attr->size from the > > is_bin_visible() callback. > > > > This has drawbacks: > > * It is no

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-06 Thread Yu Kuai
Hi, 在 2024/11/06 22:43, Lorenzo Stoakes 写道: NACK. Do this some other way that isn't a terrible mess. You've reverted my CRITICAL fix, then didn't cc- me so I'm grumpy. Even if you bizarrely brought it back later. Don't fail to cc- people you revert in future, please, especially in stable. It

Re: [PATCH] drm/ttm/tests: Fix memory leaks for ttm_tt_init()

2024-11-06 Thread Jinjie Ruan
Gentle ping. On 2024/10/18 18:11, Jinjie Ruan wrote: > modprobe ttm_tt_test and then rmmod it, the following > memory leaks occurs because the ttm->pages allocated > in ttm_tt_init() is not freed: > > unreferenced object 0xff80c8469ed0 (size 8): > comm "kunit_try_catch", pid 184

Re: [PATCH v4] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create()

2024-11-06 Thread Jinjie Ruan
On 2024/10/30 10:01, Jinjie Ruan wrote: > Gentle ping. > > On 2024/10/26 10:07, Jinjie Ruan wrote: >> modprobe ttm_device_test and then rmmod ttm_device_test, the following >> memory leaks occurs: >> >> The ttm->pages allocated in ttm_tt_init() is not freed after calling >> ttm_tt_simple_create

Re: [PATCH 6.6 28/28] maple_tree: correct tree corruption on spanning store

2024-11-06 Thread Yu Kuai
Hi, 在 2024/11/06 23:02, Lorenzo Stoakes 写道: On Thu, Oct 24, 2024 at 09:22:25PM +0800, Yu Kuai wrote: diff --git a/lib/maple_tree.c b/lib/maple_tree.c index 5328e08723d7..c57b6fc4db2e 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -2239,6 +2239,8 @@ static inline void mas_node_or_none(

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-06 Thread Yu Kuai
Hi, 在 2024/11/06 23:19, Chuck Lever III 写道: On Nov 6, 2024, at 1:16 AM, Greg KH wrote: On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote: From: Yu Kuai Fix patch is patch 27, relied patches are from: I assume patch 27 is: libfs: fix infinite directory reads for offset dir https

Re: [PATCH] drm/amdkfd: Fix wrong usage of INIT_WORK()

2024-11-06 Thread Felix Kuehling
On 2024-11-05 20:35, Yuan Can wrote: > In kfd_procfs_show(), the sdma_activity_work_handler is a local variable > and the sdma_activity_work_handler.sdma_activity_work should initialize > with INIT_WORK_ONSTACK() instead of INIT_WORK(). > > Fixes: 32cb59f31362 ("drm/amdkfd: Track SDMA utilization

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-06 Thread Lorenzo Stoakes
NACK. Do this some other way that isn't a terrible mess. You've reverted my CRITICAL fix, then didn't cc- me so I'm grumpy. Even if you bizarrely brought it back later. Don't fail to cc- people you revert in future, please, especially in stable. It's not only discourteous it's also an actual se

Re: [PATCH 6.6 28/28] maple_tree: correct tree corruption on spanning store

2024-11-06 Thread Lorenzo Stoakes
On Thu, Oct 24, 2024 at 09:22:25PM +0800, Yu Kuai wrote: > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 5328e08723d7..c57b6fc4db2e 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -2239,6 +2239,8 @@ static inline void mas_node_or_none(struct ma_state > *mas, > > /* > *

Re: [PATCH 04/21] dt-bindings: gpu: img: Allow dma-coherent

2024-11-06 Thread Andrew Davis
On 11/6/24 12:30 PM, Conor Dooley wrote: On Wed, Nov 06, 2024 at 10:18:06AM +, Matt Coster wrote: On 05/11/2024 18:06, Conor Dooley wrote: On Tue, Nov 05, 2024 at 03:58:10PM +, Matt Coster wrote: This attribute will be required for the BXS-4-64 MC1 and will be enabled in the DTS for th

Re: lockdep and ww mutex debug interactions in hdmi tests

2024-11-06 Thread Dave Airlie
On Fri, 1 Nov 2024 at 23:57, Maxime Ripard wrote: > > Hi, > > On Wed, Oct 30, 2024 at 05:03:50AM +1000, Dave Airlie wrote: > > Hi, > > > > I mentioned this internally, but wanted to get it on the list, > > > > I ran the hdmi kunit tests with LOCKDEP and WW_MUTEX_SLOWPATH enabled > > and hit some i

Re: [PATCH v2 02/10] sysfs: introduce callback attribute_group::bin_size

2024-11-06 Thread Krzysztof Wilczyński
Hello, > Several drivers need to dynamically calculate the size of an binary > attribute. Currently this is done by assigning attr->size from the > is_bin_visible() callback. > > This has drawbacks: > * It is not documented. > * A single attribute can be instantiated multiple times, overwriting t

Re: [PATCH] drm/fourcc: Add modifier definition for describing Verisilicon video framebuffer

2024-11-06 Thread Nicolas Dufresne
Hi, Le mercredi 06 novembre 2024 à 16:53 +0100, Benjamin Gaignard a écrit : > + nicolas Thanks for the CC, I'm obviously watching ker...@collabora.com, I don't know why it didn't make it to my mailbox. I'm adding explicitly Lucas and Philipp, as I believe they can provide relevant information he

Re: [PATCH v3 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-06 Thread Laurent Pinchart
On Wed, Nov 06, 2024 at 08:04:16PM +0100, Geert Uytterhoeven wrote: > Hi Biju, > > On Wed, Nov 6, 2024 at 7:49 PM Biju Das wrote: > > The host_node pointer assigned and freed in adv7533_parse_dt() > > and later adv7533_attach_dsi() uses the same. Fix this issue > > by freeing the host_node in adv

Re: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support

2024-11-06 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Wed, Nov 06, 2024 at 06:49:29PM +, Biju Das wrote: > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > unsupported 1-lane from bindings. > > [1] > https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf No need for a

Re: [PATCH v2 02/10] sysfs: introduce callback attribute_group::bin_size

2024-11-06 Thread Armin Wolf
Am 03.11.24 um 18:03 schrieb Thomas Weißschuh: Several drivers need to dynamically calculate the size of an binary attribute. Currently this is done by assigning attr->size from the is_bin_visible() callback. Hi, i really like your idea of introducing this new callback, it will be very useful

Re: [PATCH v3 3/3] drm: adv7511: Drop dsi single lane support

2024-11-06 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Wed, Nov 06, 2024 at 06:49:30PM +, Biju Das wrote: > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > unsupported 1-lane. > > [1] > https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf No need for a line break, t

Re: [PATCH v3 2/3] dt-bindings: display: adi,adv7533: Drop single lane support

2024-11-06 Thread Geert Uytterhoeven
Hi Biju, On Wed, Nov 6, 2024 at 7:49 PM Biju Das wrote: > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop > unsupported 1-lane from bindings. > > [1] > https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf The above is for ADV7535. Fortunately https://www.

Re: [PATCH v3 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-06 Thread Geert Uytterhoeven
Hi Biju, On Wed, Nov 6, 2024 at 7:49 PM Biju Das wrote: > The host_node pointer assigned and freed in adv7533_parse_dt() > and later adv7533_attach_dsi() uses the same. Fix this issue > by freeing the host_node in adv7533_attach_dsi() instead of > adv7533_parse_dt(). > > Fixes: 1e4d58cd7f88 ("drm

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Liviu Dudau
On Wed, Nov 06, 2024 at 02:21:33PM +0100, Boris Brezillon wrote: > On Wed, 6 Nov 2024 13:10:37 + > Liviu Dudau wrote: > > > panthor_heap_pool_release() does not take the panthor_heap_pool::lock, so > > the protection > > is not really there. I could fix panthor_heap_pool_release() and then a

[PATCH v2] drm/panthor: Lock XArray when getting entries for the VM

2024-11-06 Thread Liviu Dudau
Similar to cac075706f29 ("drm/panthor: Fix race when converting group handle to group object") we need to use the XArray's internal locking when retrieving a vm pointer from there. v2: Removed part of the patch that was trying to protect fetching the heap pointer from XArray, as that operation is

[PATCH v3 3/3] drm: adv7511: Drop dsi single lane support

2024-11-06 Thread Biju Das
As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop unsupported 1-lane. [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Reported-by: Hien Huynh Cc: sta...@vger.kernel.org Signed-of

[PATCH v3 2/3] dt-bindings: display: adi, adv7533: Drop single lane support

2024-11-06 Thread Biju Das
As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop unsupported 1-lane from bindings. [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.org Signed-off-by: Biju

[PATCH v3 1/3] drm: adv7511: Fix use-after-free in adv7533_attach_dsi()

2024-11-06 Thread Biju Das
The host_node pointer assigned and freed in adv7533_parse_dt() and later adv7533_attach_dsi() uses the same. Fix this issue by freeing the host_node in adv7533_attach_dsi() instead of adv7533_parse_dt(). Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device") Cc: sta...@vger.kernel.o

[PATCH v3 0/3] drm: adv7511: ADV7535 fixes

2024-11-06 Thread Biju Das
This patch series aims to fix 2 bugs in ADV7535 driver 1) use-after-free bug in adv7533_attach_dsi() 2) Drop unsupported single lane. Changes in v3: - Replace __free construct with readable of_node_put(). - Dropped single lane support from bindings and driver. changes in v2: - Added the tag "Cc

Re: [PATCH 08/21] dt-bindings: gpu: img: Add BXS-4-64 devicetree bindings

2024-11-06 Thread Conor Dooley
On Wed, Nov 06, 2024 at 10:18:10AM +, Matt Coster wrote: > On 05/11/2024 18:03, Conor Dooley wrote: > > On Tue, Nov 05, 2024 at 03:58:14PM +, Matt Coster wrote: > >> +/ { > >> +#address-cells = <2>; > >> +#size-cells = <2>; > >> +interrupt-controller; > >> +

Re: [PATCH 04/21] dt-bindings: gpu: img: Allow dma-coherent

2024-11-06 Thread Conor Dooley
On Wed, Nov 06, 2024 at 10:18:06AM +, Matt Coster wrote: > On 05/11/2024 18:06, Conor Dooley wrote: > > On Tue, Nov 05, 2024 at 03:58:10PM +, Matt Coster wrote: > >> This attribute will be required for the BXS-4-64 MC1 and will be enabled in > >> the DTS for the TI k3-j721s2 in a subsequent

Re: [PATCH 03/21] dt-bindings: gpu: img: Power domain details

2024-11-06 Thread Conor Dooley
On Wed, Nov 06, 2024 at 10:18:01AM +, Matt Coster wrote: > On 05/11/2024 18:13, Conor Dooley wrote: > > On Tue, Nov 05, 2024 at 06:05:54PM +, Conor Dooley wrote: > >> On Tue, Nov 05, 2024 at 03:58:09PM +, Matt Coster wrote: > >>> The single existing GPU (AXE-1-16M) only requires a singl

Re: [PATCH V6 07/10] accel/amdxdna: Add command execution

2024-11-06 Thread Lizhi Hou
On 11/3/24 22:31, Matthew Brost wrote: On Wed, Oct 30, 2024 at 08:51:44AM -0700, Lizhi Hou wrote: Add interfaces for user application to submit command and wait for its completion. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/aie2_ctx.c

Re: [PATCH 0/7] kernel/cgroups: Add "dev" memory accounting cgroup.

2024-11-06 Thread Tejun Heo
On Wed, Nov 06, 2024 at 11:31:49AM +0100, Maxime Ripard wrote: ... > > How about dmem for this one, and dpu for the other one. For device > > memory and device processing unit, respectively. > > dmem sounds great to me, does everyone agree? Sounds good to me. Thanks. -- tejun

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread kernel test robot
Hi Liviu, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.12-rc6 next-20241106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH 0/3] drm/rockchip: Add driver for the new DSI2 controller

2024-11-06 Thread Heiko Stuebner
This series adds a bridge and glue driver for the DSI2 controller found in the rk3588 soc from Rockchip, that is based on a Synopsis IP block. As the manual states: The Display Serial Interface 2 (DSI-2) is part of a group of communication protocols defined by the MIPI Alliance. The MIPI DSI-2 Hos

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread kernel test robot
Hi Liviu, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.12-rc6 next-20241106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

RE: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

2024-11-06 Thread Biju Das
Hi Laurent Pinchart, > -Original Message- > From: Laurent Pinchart > Sent: 05 November 2024 16:06 > Subject: Re: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in > clock_div_by_lanes > > Hi Biju, > > Thank you for the patch. > > On Tue, Nov 05, 2024 at 11:12:19AM +, Biju Da

Re: [PATCH 02/21] dt-bindings: gpu: img: Further constrain clocks

2024-11-06 Thread Conor Dooley
On Wed, Nov 06, 2024 at 10:17:53AM +, Matt Coster wrote: > On 05/11/2024 18:16, Conor Dooley wrote: > > On Tue, Nov 05, 2024 at 03:58:08PM +, Matt Coster wrote: > >> All Imagination GPUs use three clocks: core, mem and sys. All reasonably > >> modern Imagination GPUs also support a single-c

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-06 Thread Matthew Brost
On Wed, Nov 06, 2024 at 04:44:15PM +0100, Christian König wrote: > Am 06.11.24 um 16:25 schrieb Matthew Brost: > > [SNIP] > > > Can you fully describe your use case? In other words what exactly is your > > > debugger trying to do? > > See above; I hope I've made this clearer. > > It at least sound

Re: [PATCH 01/21] dt-bindings: gpu: img: More explicit compatible strings

2024-11-06 Thread Conor Dooley
On Wed, Nov 06, 2024 at 10:17:47AM +, Matt Coster wrote: > On 05/11/2024 18:13, Conor Dooley wrote: > > On Tue, Nov 05, 2024 at 03:58:07PM +, Matt Coster wrote: > >> The current compatible strings are not specific enough to constrain the > >> hardware in devicetree. For example, the current

Re: [PATCH] drm/panthor: Be stricter about IO mapping flags

2024-11-06 Thread Steven Price
On 04/11/2024 23:17, Jann Horn wrote: > The current panthor_device_mmap_io() implementation has two issues: > > 1. For mapping DRM_PANTHOR_USER_FLUSH_ID_MMIO_OFFSET, >panthor_device_mmap_io() bails if VM_WRITE is set, but does not clear >VM_MAYWRITE. That means userspace can use mprotect()

[pull] amdgpu, amdkfd drm-next-6.13

2024-11-06 Thread Alex Deucher
Hi Dave, Simona, Last few updates for 6.13. The following changes since commit dac64cb3e029e9ae9ca251798bcb9cdb118d68d5: drm/amdgpu: Fix amdgpu_ip_block_hw_fini() (2024-10-24 18:07:10 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-dr

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-06 Thread James Bottomley
On Wed, 2024-11-06 at 15:19 +, Chuck Lever III wrote: > This is the first I've heard of this CVE. It > would help if the patch authors got some > notification when these are filed. Greg did it; it came from the kernel CNA: https://www.cve.org/CVERecord?id=CVE-2024-46701 The way it seems to w

Re: [PATCH v3 0/3] Remove split on unmap behavior

2024-11-06 Thread Will Deacon
On Wed, Nov 06, 2024 at 12:15:20PM -0400, Jason Gunthorpe wrote: > On Wed, Nov 06, 2024 at 03:53:23PM +, Will Deacon wrote: > > On Tue, 05 Nov 2024 14:14:23 -0400, Jason Gunthorpe wrote: > > > This is the result of the discussion on removing split. We agreed that > > > split is not required, an

[PATCH 5.10 108/110] drm/shmem-helper: Fix BUG_ON() on mmap(PROT_WRITE, MAP_PRIVATE)

2024-11-06 Thread Greg Kroah-Hartman
5.10-stable review patch. If anyone has any objections, please let me know. -- From: Wachowski, Karol commit 39bc27bd688066a63e56f7f64ad34fae03fbe3b8 upstream. Lack of check for copy-on-write (COW) mapping in drm_gem_shmem_mmap allows users to call mmap with PROT_WRITE and MAP

Re: [PATCH v2 3/4] drm/mode_object: add drm_mode_object_read_refcount()

2024-11-06 Thread kernel test robot
Hi Luca, kernel test robot noticed the following build warnings: [auto build test WARNING on 42f7652d3eb527d03665b09edac47f85fb600924] url: https://github.com/intel-lab-lkp/linux/commits/Luca-Ceresoli/drm-drm_mode_object-fix-typo-in-kerneldoc/20241106-185032 base

Re: [PATCH v3 0/3] Remove split on unmap behavior

2024-11-06 Thread Jason Gunthorpe
On Wed, Nov 06, 2024 at 03:53:23PM +, Will Deacon wrote: > On Tue, 05 Nov 2024 14:14:23 -0400, Jason Gunthorpe wrote: > > This is the result of the discussion on removing split. We agreed that > > split is not required, and no application should ask for anything that > > would not unmap a full

[PATCH v5 1/4] dt-bindings: display: bridge: add sam9x75-mipi-dsi binding

2024-11-06 Thread Manikandan Muralidharan
Add the 'sam9x75-mipi-dsi' compatible binding, which describes the Microchip's specific wrapper for the Synopsys DesignWare MIPI DSI HOST Controller for the sam9x75 series System-on-Chip (SoC) devices. Signed-off-by: Manikandan Muralidharan Reviewed-by: Conor Dooley --- changes in v5: - Add revi

Re: [PATCH v4 1/2] drm/panfrost: Add missing OPP table refcnt decremental

2024-11-06 Thread Steven Price
On 05/11/2024 20:54, Adrián Larumbe wrote: > Commit f11b0417eec2 ("drm/panfrost: Add fdinfo support GPU load metrics") > retrieves the OPP for the maximum device clock frequency, but forgets to > keep the reference count balanced by putting the returned OPP object. This > eventually leads to an OPP

Re: [PATCH 3/3] drm/rockchip: Add MIPI DSI2 glue driver for RK3588

2024-11-06 Thread Diederik de Haas
On Wed Nov 6, 2024 at 1:33 PM CET, Heiko Stuebner wrote: > From: Heiko Stuebner > > This adds the glue code for the MIPI DSI2 bridge on Rockchip SoCs and > enables its use on the RK3588. > > Right now the DSI2 controller is always paired with a DC-phy based on a > Samsung IP, so the interface valu

Re: [PATCH] drm/fourcc: Add modifier definition for describing Verisilicon video framebuffer

2024-11-06 Thread Benjamin Gaignard
+ nicolas Le 06/11/2024 à 14:30, Benjamin Gaignard a écrit : Verisilicon hardware video decoders can produce tiled (8x4 or 4x4) and compressed video framebuffers. It considerably reduces memory bandwidth while writing and reading frames in memory. The underlying storage in NV12 (for 8-bit) or N

Re: [PATCH v3 0/3] Remove split on unmap behavior

2024-11-06 Thread Will Deacon
On Tue, 05 Nov 2024 14:14:23 -0400, Jason Gunthorpe wrote: > This is the result of the discussion on removing split. We agreed that > split is not required, and no application should ask for anything that > would not unmap a full large IOPTE. > > Instead of split the two ARM drivers will now WARN_

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 13:10:37 + Liviu Dudau wrote: > panthor_heap_pool_release() does not take the panthor_heap_pool::lock, so the > protection > is not really there. I could fix panthor_heap_pool_release() and then add a > lockdep_assert_held() before both calls to xa_load() if you think that

[PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Liviu Dudau
Similar to cac075706f29 ("drm/panthor: Fix race when converting group handle to group object") we need to use the XArray's internal locking when retrieving a pointer from there for heap and vm. Reported-by: Jann Horn Cc: Boris Brezillon Cc: Steven Price Signed-off-by: Liviu Dudau --- drivers/

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-06 Thread Christian König
Am 06.11.24 um 16:25 schrieb Matthew Brost: [SNIP] Can you fully describe your use case? In other words what exactly is your debugger trying to do? See above; I hope I've made this clearer. It at least sounds a little bit better. Also, I'm not really an expert on Eudebug, as I haven't been

[PATCH] accel/ivpu: Fix Qemu crash when running in passthrough

2024-11-06 Thread Jacek Lawrynowicz
Restore PCI state after putting the NPU in D0. Restoring state before powering up the device caused a Qemu crash if NPU was running in passthrough mode and recovery was performed. Fixes: 3534eacbf101 ("accel/ivpu: Fix PCI D0 state entry in resume") Cc: # v6.8+ Signed-off-by: Jacek Lawrynowicz Re

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Steven Price
On 06/11/2024 12:07, Liviu Dudau wrote: > Similar to cac075706f29 ("drm/panthor: Fix race when converting > group handle to group object") we need to use the XArray's internal > locking when retrieving a pointer from there for heap and vm. > > Reported-by: Jann Horn > Cc: Boris Brezillon > Cc: S

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Mihail Atanassov
Hi Liviu, On 06/11/2024 12:07, Liviu Dudau wrote: Similar to cac075706f29 ("drm/panthor: Fix race when converting group handle to group object") we need to use the XArray's internal locking when retrieving a pointer from there for heap and vm. Reported-by: Jann Horn Cc: Boris Brezillon Cc: St

[PATCH v2 2/4] drm/atomic-helper: improve CRTC enabled/connectors mismatch logging message

2024-11-06 Thread Luca Ceresoli
This message reports a mismatch between new_crtc_state->enable and has_connectors, which should be either both true or both false. However it does not mention which one is true and which is false, which can be useful for debugging. Add the value of both avriables to the log message. Signed-off-by:

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 13:17:29 + Steven Price wrote: > On 06/11/2024 12:07, Liviu Dudau wrote: > > Similar to cac075706f29 ("drm/panthor: Fix race when converting > > group handle to group object") we need to use the XArray's internal > > locking when retrieving a pointer from there for heap and

Re: [PATCH 2/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN11

2024-11-06 Thread Alex Deucher
On Wed, Nov 6, 2024 at 3:24 AM Zicheng Qu wrote: > > The current implementation incorrectly updates DOMAIN11_PG_CONFIG with > DOMAIN9_POWER_FORCEON, which is not the intended behavior. This patch > corrects the power gating configuration by updating DOMAIN11_PG_CONFIG > with DOMAIN11_POWER_FORCEON

Re: [PATCH 1/2] drm/amd/display: Fix incorrect power gating configuration for DOMAIN10

2024-11-06 Thread Alex Deucher
On Wed, Nov 6, 2024 at 3:18 AM Zicheng Qu wrote: > > The current implementation incorrectly updates DOMAIN10_PG_CONFIG with > DOMAIN8_POWER_FORCEON, which is not the intended behavior. This patch > corrects the power gating configuration by updating DOMAIN10_PG_CONFIG > with DOMAIN10_POWER_FORCEON

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-06 Thread Chuck Lever III
> On Nov 6, 2024, at 1:16 AM, Greg KH wrote: > > On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote: >> From: Yu Kuai >> >> Fix patch is patch 27, relied patches are from: I assume patch 27 is: libfs: fix infinite directory reads for offset dir https://lore.kernel.org/stable/202410241

Re: [PATCH v6 2/8] drm/ttm: Add ttm_bo_access

2024-11-06 Thread Matthew Brost
On Wed, Nov 06, 2024 at 10:48:45AM +0100, Christian König wrote: > Am 05.11.24 um 19:35 schrieb Matthew Brost: > > [SNIP] > > > Well we spend quite some time removing single page mappings from device > > > drivers. > > > > > > The only remaining use case of ttm_bo_kmap() with just one page is the

Re: [PATCH v2] drm/syncobj: ensure progress for syncobj queries

2024-11-06 Thread Christian König
Am 06.11.24 um 09:14 schrieb Boris Brezillon: On Tue, 5 Nov 2024 09:56:22 -0800 Chia-I Wu wrote: On Mon, Nov 4, 2024 at 11:32 PM Christian König wrote: Am 04.11.24 um 22:32 schrieb Chia-I Wu: On Tue, Oct 22, 2024 at 10:24 AM Chia-I Wu wrote: On Tue, Oct 22, 2024 at 9:53 AM Christian Köni

Re: [PATCH 04/21] dt-bindings: gpu: img: Allow dma-coherent

2024-11-06 Thread Matt Coster
On 05/11/2024 18:06, Conor Dooley wrote: > On Tue, Nov 05, 2024 at 03:58:10PM +, Matt Coster wrote: >> This attribute will be required for the BXS-4-64 MC1 and will be enabled in >> the DTS for the TI k3-j721s2 in a subsequent patch; add it now so >> dtbs_check doesn't complain later. > > Soun

Re: [PATCH 0/7] kernel/cgroups: Add "dev" memory accounting cgroup.

2024-11-06 Thread Maxime Ripard
On Tue, Oct 29, 2024 at 04:38:34PM -0400, Johannes Weiner wrote: > On Mon, Oct 28, 2024 at 11:05:48AM +0100, Maxime Ripard wrote: > > On Thu, Oct 24, 2024 at 07:06:36AM -1000, Tejun Heo wrote: > > > Hello, > > > > > > On Thu, Oct 24, 2024 at 09:20:43AM +0200, Maxime Ripard wrote: > > > ... > > > >

Re: [PATCH v2 1/3] iommu/io-pgtable-arm: Remove split on unmap behavior

2024-11-06 Thread Steven Price
On 04/11/2024 17:41, Jason Gunthorpe wrote: > A minority of page table implementations (arm_lpae, armv7) are unique in > how they handle partial unmap of large IOPTEs. > > Other implementations will unmap the large IOPTE and return it's > length. For example if a 2M IOPTE is present and the first

[PATCH v3 1/2] drm/display/dsc: Refactor DRM MST DSC Determination Policy

2024-11-06 Thread Fangzhi Zuo
[why] How we determine the dsc_aux used for dsc decompression in drm_dp_mst_dsc_aux_for_port() today has defects: 1. The method how we determine a connected peer device is virtual or not in drm_dp_mst_is_virtual_dpcd() is not always correct. There are DP1.4 products in the market which don'

[PATCH v3 0/2] Refactor MST DSC Determination Policy

2024-11-06 Thread Fangzhi Zuo
The patch series is to refactor existing dsc determination policy for dsc decompression and dsc passthrough given a mst output port. Original routine was written based on different peer device types which is not accurate and shows difficulty when expanding support of products that do not fully com

[PATCH v3 2/2] drm/display/dsc: MST DSC Interface Change

2024-11-06 Thread Fangzhi Zuo
[why] Starting from dp2 where dsc passthrough is introduced, it is required to identify the dsc passthrough aux, apart from dsc decompression aux. Existing drm_dp_mst_port function that returns dsc_aux alone is not sufficient. [how] 1. Interface change in drm_dp_mst_dsc_aux_for_port, and depende

[PATCH 5.4 244/462] drm: Consistently use struct drm_mode_rect for FB_DAMAGE_CLIPS

2024-11-06 Thread Greg Kroah-Hartman
5.4-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Zimmermann commit 8b0d2f61545545ab5eef923ed6e59fc3be2385e0 upstream. FB_DAMAGE_CLIPS is a plane property for damage handling. Its UAPI should only use UAPI types. Hence replace struct dr

Re: [PATCH v2] drm/syncobj: ensure progress for syncobj queries

2024-11-06 Thread Christian König
Am 06.11.24 um 14:12 schrieb Boris Brezillon: On Wed, 6 Nov 2024 13:44:20 +0100 Christian König wrote: Am 06.11.24 um 09:14 schrieb Boris Brezillon: [SNIP] I filed a Mesa issue, https://gitlab.freedesktop.org/mesa/mesa/-/issues/12094, and Faith suggested a kernel-side fix as well. Should we r

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Steven Price
On 06/11/2024 13:34, Boris Brezillon wrote: > On Wed, 6 Nov 2024 13:17:29 + > Steven Price wrote: > >> On 06/11/2024 12:07, Liviu Dudau wrote: >>> Similar to cac075706f29 ("drm/panthor: Fix race when converting >>> group handle to group object") we need to use the XArray's internal >>> lockin

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Mihail Atanassov
On 06/11/2024 12:14, Mihail Atanassov wrote: Hi Liviu, On 06/11/2024 12:07, Liviu Dudau wrote: Similar to cac075706f29 ("drm/panthor: Fix race when converting group handle to group object") we need to use the XArray's internal locking when retrieving a pointer from there for heap and vm. Repor

[PATCH] drm/v3d: Fix performance counter source settings on V3D 7.x

2024-11-06 Thread Maíra Canal
When the new register addresses were introduced for V3D 7.x, we added new masks for performance counter sources on V3D 7.x. Nevertheless, we never apply these new masks when setting the sources. Fix the performance counter source settings on V3D 7.x by introducing a new macro, `V3D_SET_FIELD_VER`

[PATCH] drm/fourcc: Add modifier definition for describing Verisilicon video framebuffer

2024-11-06 Thread Benjamin Gaignard
Verisilicon hardware video decoders can produce tiled (8x4 or 4x4) and compressed video framebuffers. It considerably reduces memory bandwidth while writing and reading frames in memory. The underlying storage in NV12 (for 8-bit) or NV15 (for 10-bit). Display controllers, like imx DCSS, could use

Re: [PATCH 1/4] drm/plane: Add new plane property IN_FORMATS_ASYNC

2024-11-06 Thread Ville Syrjälä
On Wed, Nov 06, 2024 at 02:32:28PM +, Murthy, Arun R wrote: > > -Original Message- > > From: Ville Syrjälä > > Sent: Wednesday, November 6, 2024 7:31 PM > > To: Murthy, Arun R > > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > > de...@lists.freedesktop.org

Re: [PATCH 6.6 00/28] fix CVE-2024-46701

2024-11-06 Thread Liam R. Howlett
* Greg KH [241106 01:16]: > On Thu, Oct 24, 2024 at 09:19:41PM +0800, Yu Kuai wrote: > > From: Yu Kuai > > > > Fix patch is patch 27, relied patches are from: > > > > - patches from set [1] to add helpers to maple_tree, the last patch to > > improve fork() performance is not backported; > > S

[PATCH v2 1/4] drm/drm_mode_object: fix typo in kerneldoc

2024-11-06 Thread Luca Ceresoli
Remove unintended extra word. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Ceresoli --- include/drm/drm_mode_object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_mode_object.h b/include/drm/drm_mode_object.h index 08d7a7f0188fea79e2d8ad5ee6cc5044300

[PATCH v2 4/4] drm/connector: warn when cleaning up a refcounted connector

2024-11-06 Thread Luca Ceresoli
Calling drm_connector_cleanup() should only be done via the free_cb => .destroy path, which cleans up the struct drm_connector only when the refcount drops to zero. A cleanup done with a refcount higher than 0 can result from buggy code, e.g. by doing cleanup directly in the drivers teardown code.

[PATCH v2 0/4] DRM: small improvements

2024-11-06 Thread Luca Ceresoli
This series brings small improvements to the DRM documentation, logging and a warning on an incorrect code path. Signed-off-by: Luca Ceresoli --- Changes in v2: - Added patches 3 and 4 - Updated reviewed-by tags - Link to v1: https://lore.kernel.org/r/20241018-drm-small-improvements-v1-0-cc316e1

RE: [PATCH 1/4] drm/plane: Add new plane property IN_FORMATS_ASYNC

2024-11-06 Thread Murthy, Arun R
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, November 6, 2024 7:31 PM > To: Murthy, Arun R > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCH 1/4] drm/plane: Add new plane property > IN_FORMATS_A

Re: [PATCH v2] drm/syncobj: ensure progress for syncobj queries

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 13:44:20 +0100 Christian König wrote: > Am 06.11.24 um 09:14 schrieb Boris Brezillon: > > On Tue, 5 Nov 2024 09:56:22 -0800 > > Chia-I Wu wrote: > > > >> On Mon, Nov 4, 2024 at 11:32 PM Christian König > >> wrote: > >>> Am 04.11.24 um 22:32 schrieb Chia-I Wu: > >>> > >>>

Re: [PATCH 1/3] drm/bridge/synopsys: Add MIPI DSI2 host controller bridge

2024-11-06 Thread Diederik de Haas
On Wed Nov 6, 2024 at 1:33 PM CET, Heiko Stuebner wrote: > From: Heiko Stuebner > > Add a Synopsys Designware MIPI DSI host DRM bridge driver for their > DSI2 host controller, based on the Rockchip version from the driver > rockchip/dw-mipi-dsi2.c in their vendor-kernel with phy & bridge APIs. > >

Re: [PATCH 1/7] dt-bindings: display: panel: Rename rg35xx-plus-panel back to WL-355608-A8

2024-11-06 Thread Neil Armstrong
On 06/11/2024 05:56, Hironori KIKUCHI wrote: Ok, Thank you guys. Could you help me how to name the new panel YLM-LBV0345001H-V2 for the recent RG35XX Plus please? - Use `anbernic,rg35xx-plus-panel-v2` - Use `anbernic,rg35xx-plus-panel-new` - Use `anbernic,ylm-lbv0345001h-v2` - Share `anbernic,r

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Liviu Dudau
On Wed, Nov 06, 2024 at 01:16:41PM +0100, Boris Brezillon wrote: > On Wed, 6 Nov 2024 12:07:48 + > Liviu Dudau wrote: > > > Similar to cac075706f29 ("drm/panthor: Fix race when converting > > group handle to group object") we need to use the XArray's internal > > locking when retrieving a po

Re: [PATCH v1 10/10] uapi: linux: add mediatek isp_7x camsys user api

2024-11-06 Thread Laurent Pinchart
On Mon, Oct 14, 2024 at 05:56:40AM +, CK Hu (胡俊光) wrote: > Hi, Shu-hsiang: > > On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote: > > Add UAPI for MediaTek ISP platform, providing user-space > > interfaces for the new camsys driver. > > > > Signed-off-by: Shu-hsiang Yang > > --- > >

Re: [PATCH 2/3] dt-bindings: display: rockchip: Add schema for RK3588 DW DSI2 controller

2024-11-06 Thread Rob Herring
On Wed, Nov 06, 2024 at 01:33:03PM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner > > The Display Serial Interface 2 (DSI-2) is part of a group of communication > protocols defined by the MIPI Alliance. The RK3588 implements this > specification in its two MIPI DSI-2 Host Controllers that ar

RE: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

2024-11-06 Thread Biju Das
ng_gen(), when > > > > dsi lanes = 1. > > > > > > Does the hardware support using the internal timing generator with a > > > single lane ? If so > > > > As per the binding documentation [1], ADV7535 supports single lane. > > https://git.kerne

Re: [PATCH v4 3/7] PCI: Add a helper to convert between standard and IOV resources

2024-11-06 Thread Ilpo Järvinen
On Fri, 25 Oct 2024, Michał Winiarski wrote: > There are multiple places where conversions between IOV resources and > standard resources are done. > > Extract the logic to pci_resource_to_iov() and pci_resource_from_iov() > helpers. > > Suggested-by: Ilpo Järvinen > Signed-off-by: Michał Winia

Re: [PATCH 2/3] dma-buf: sort fences in dma_fence_unwrap_merge

2024-11-06 Thread Christian König
Am 30.10.24 um 19:10 schrieb Friedrich Vock: On 24.10.24 14:41, Christian König wrote: The merge function initially handled only individual fences and arrays which in turn were created by the merge function. This allowed to create the new array by a simple merge sort based on the fence context n

Re: [PATCH 01/21] dt-bindings: gpu: img: More explicit compatible strings

2024-11-06 Thread Matt Coster
On 05/11/2024 18:13, Conor Dooley wrote: > On Tue, Nov 05, 2024 at 03:58:07PM +, Matt Coster wrote: >> The current compatible strings are not specific enough to constrain the >> hardware in devicetree. For example, the current "img,img-axe" string >> refers to the entire family of Series AXE GP

[PATCH 3/3] drm/rockchip: Add MIPI DSI2 glue driver for RK3588

2024-11-06 Thread Heiko Stuebner
From: Heiko Stuebner This adds the glue code for the MIPI DSI2 bridge on Rockchip SoCs and enables its use on the RK3588. Right now the DSI2 controller is always paired with a DC-phy based on a Samsung IP, so the interface values are set statically for now. This stays true for the upcoming RK357

Re: [PATCH v2 3/4] drm/mode_object: add drm_mode_object_read_refcount()

2024-11-06 Thread Jani Nikula
On Wed, 06 Nov 2024, Luca Ceresoli wrote: > Add a wrapper to kref_read() just like the ones already in place for > kref_get() and kref_put(). This will be used for sanity checks on object > lifetime. > > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/drm_mode_object.c | 20

[PATCH 2/3] dt-bindings: display: rockchip: Add schema for RK3588 DW DSI2 controller

2024-11-06 Thread Heiko Stuebner
From: Heiko Stuebner The Display Serial Interface 2 (DSI-2) is part of a group of communication protocols defined by the MIPI Alliance. The RK3588 implements this specification in its two MIPI DSI-2 Host Controllers that are based on a new Synopsis IP. Signed-off-by: Heiko Stuebner --- .../roc

[PATCH v2] drm/virtio: Add drm_panic support

2024-11-06 Thread Ryosuke Yasuoka
From: Jocelyn Falempe Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka Signed-off-by: Jocelyn Falempe --- v2: - Remove unnecessary virtio_gpu_vbuffer_inline - Remove reclaim_list and just call drm_gem_ob

Re: [PATCH] drm/panthor: Lock XArray when getting entries for heap and VM

2024-11-06 Thread Boris Brezillon
On Wed, 6 Nov 2024 12:07:48 + Liviu Dudau wrote: > Similar to cac075706f29 ("drm/panthor: Fix race when converting > group handle to group object") we need to use the XArray's internal > locking when retrieving a pointer from there for heap and vm. > > Reported-by: Jann Horn > Cc: Boris Br

RE: [PATCH v2 2/2] drm: adv7511: Fix out-of-bounds array in clock_div_by_lanes

2024-11-06 Thread Biju Das
documentation [1], ADV7535 supports single lane. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml?h=next-20241106 > adv7511_dsi_config_timing_gen() should be fixed, otherwise that should be > explained in

Re: [PATCH 02/21] dt-bindings: gpu: img: Further constrain clocks

2024-11-06 Thread Matt Coster
On 05/11/2024 18:16, Conor Dooley wrote: > On Tue, Nov 05, 2024 at 03:58:08PM +, Matt Coster wrote: >> All Imagination GPUs use three clocks: core, mem and sys. All reasonably >> modern Imagination GPUs also support a single-clock mode where the SoC >> only hooks up core and the other two are d

  1   2   >