Hi Biju,

Thank you for the patch.

On Wed, Nov 06, 2024 at 06:49:30PM +0000, Biju Das wrote:
> As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop
> unsupported 1-lane.
> 
> [1]
> https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf

No need for a line break, this should be

[1] 
https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf

> 
> Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device")
> Reported-by: Hien Huynh <hien.huynh...@renesas.com>

Reported-by is supposed to be immediately followed by a Closes: tag.

With those fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>

> Cc: sta...@vger.kernel.org
> Signed-off-by: Biju Das <biju.das...@bp.renesas.com>
> ---
> Changes in v3:
>  - Updated commit header and description
>  - Updated fixes tag
>  - Dropped single lane support
> Changes in v2:
>  - Added the tag "Cc: sta...@vger.kernel.org" in the sign-off area.
>  - Dropped Archit Taneja invalid Mail address
> ---
>  drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c 
> b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> index de55d687245a..ec360f8b7509 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> @@ -173,7 +173,7 @@ int adv7533_parse_dt(struct device_node *np, struct 
> adv7511 *adv)
>  
>       of_property_read_u32(np, "adi,dsi-lanes", &num_lanes);
>  
> -     if (num_lanes < 1 || num_lanes > 4)
> +     if (num_lanes < 2 || num_lanes > 4)
>               return -EINVAL;
>  
>       adv->num_dsi_lanes = num_lanes;

-- 
Regards,

Laurent Pinchart

Reply via email to