Re: [PATCH 0/3] drm/panic: Fixes and graphical logo

2024-06-13 Thread Geert Uytterhoeven
Hi Stephen and Maxime, On Fri, Jun 14, 2024 at 12:00 AM Stephen Rothwell wrote: > On Thu, 13 Jun 2024 11:48:15 +0200 Geert Uytterhoeven > wrote: > > > > Has the drm-misc git repo moved? > > > > > > It moved to gitlab recently, the new url is > > > g...@gitlab.freedesktop.org:drm/misc/kernel.git

Re:Re: [PATCH 13/14] drm/bridge: synopsys: Add DW HDMI QP TX controller driver

2024-06-13 Thread Andy Yan
Hi Neil, At 2024-06-05 19:48:09, "Neil Armstrong" wrote: >On 05/06/2024 12:11, Cristian Ciocaltea wrote: >> On 6/5/24 12:34 AM, Cristian Ciocaltea wrote: >>> On 6/4/24 11:41 PM, Sam Ravnborg wrote: Hi Cristian. On Tue, Jun 04, 2024 at 10:32:04PM +0300, Cristian Ciocaltea wro

[PATCH] video: fbdev: sis: clean up some inconsistent indenting

2024-06-13 Thread Jiapeng Chong
No functional modification involved. drivers/video/fbdev/sis/sis_main.c:2511 SiS_Sense30x() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9330 Signed-off-by: Jiapeng Chong --- drivers/video/fbdev/sis/sis_main.c | 502

Re: [PATCH v4 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-06-13 Thread Maxime Ripard
On Fri, 14 Jun 2024 03:02:19 +0300, Dmitry Baryshkov wrote: > There are two ways to describe an eDP panel in device tree. The > recommended way is to add a device on the AUX bus, ideally using the > edp-panel compatible. The legacy way is to define a top-level platform > device for the panel. > >

Re: [PATCH v9 09/21] drm/mediatek: Fix XRGB setting error in OVL

2024-06-13 Thread 胡俊光

Re: [PATCH v9 17/21] drm/mediatek: Support "Pre-multiplied" blending in Mixer

2024-06-13 Thread 胡俊光

Re: [PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-13 Thread 胡俊光

Re: [PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-13 Thread 胡俊光

Re: [PATCH v9 15/21] drm/mediatek: Support "None" blending in Mixer

2024-06-13 Thread 胡俊光

Re: [PATCH v9 14/21] drm/mediatek: Support "None" blending in OVL

2024-06-13 Thread 胡俊光

Re: [PATCH v9 13/21] drm/mediatek: Support DRM plane alpha in Mixer

2024-06-13 Thread 胡俊光

Re: [PATCH v9 12/21] drm/mediatek: Support DRM plane alpha in OVL

2024-06-13 Thread 胡俊光

[Patch V3] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-06-13 Thread carlos . song
From: Carlos Song Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When lpi2c send data, it is tx cmd register and tx data fifo. When lpi2c receive data, it is just a rx cmd register. LPI2C

Re: [PATCH net-next v12 00/13] Device Memory TCP

2024-06-13 Thread Mina Almasry
On Thu, Jun 13, 2024 at 6:35 PM Jakub Kicinski wrote: > > On Thu, 13 Jun 2024 01:35:37 + Mina Almasry wrote: > > v12: > > https://patchwork.kernel.org/project/netdevbpf/list/?series=859747&state=* > > patches 5 and 6 transiently break the build > > ../include/trace/events/page_pool.h:65:23: e

[PATCH v2 0/2] CMRR patch fixes

2024-06-13 Thread Mitul Golani
Address following issues regarding CMRR 1. Describe target_rr_divider in struct drm_dp_as_sdp. 2. Use required macro to avoid overflow. -v2: - Remove extra line from commit message. Mitul Golani (2): drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp drm/i915/display: Update calculat

[PATCH v2 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-13 Thread Mitul Golani
Describe newly added parameter target_rr_divider in struct drm_dp_as_sdp. -v2: Remove extra line from commit message.(Lucas) Fixes: a20c6d954d75 ("drm/dp: Add refresh rate divider to struct representing AS SDP") Cc: Mitul Golani Cc: Arun R Murthy Cc: Suraj Kandpal Cc: Ankit Nautiyal Cc: Jani

[PATCH v2 2/2] drm/i915/display: Update calculation to avoid overflow

2024-06-13 Thread Mitul Golani
Update calculation to avoid overflow. -v2: Remove extra line from commit message.(Lucas) Fixes: 1676ecd303ac ("drm/i915: Compute CMRR and calculate vtotal") Cc: Mitul Golani Cc: Ankit Nautiyal Cc: Suraj Kandpal Cc: Jani Nikula Cc: Stephen Rothwell Signed-off-by: Mitul Golani Reviewed-by: An

Re: [PATCH v9 11/21] drm/mediatek: Add new color format MACROs in OVL

2024-06-13 Thread 胡俊光

Re: [PATCH v9 10/21] drm/mediatek: Fix XRGB setting error in Mixer

2024-06-13 Thread 胡俊光

[PATCH] drm/mediatek: Remove less-than-zero comparison of an unsigned value

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Fix a Coverity error that less-than-zero comparison of an unsigned value is never true. Fixes: 0d9eee9118b7 ("drm/mediatek: Add drm ovl_adaptor sub driver for MT8195") Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 +- 1 file changed, 1 i

[PATCH v9 08/21] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support RGBA and RGBX formats in OVL on MT8195. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediate

[PATCH v9 19/21] drm/mediatek: Support CRC in display driver

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Register CRC related function pointers to support CRC retrieval. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 279 drivers/gpu/drm/mediatek/mtk_crtc.h | 38 drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 5

[PATCH v9 07/21] drm/mediatek: Support more 10bit formats in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support more 10bit formats in OVL. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 32 ++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH v9 06/21] drm/mediatek: Turn off the layers with zero width or height

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such a situation. Fixes: 777b7bc86a0a ("UPSTREAM: drm/mediatek: Add ovl_adaptor support for MT8195") Fixes: fa97fe71f6

[PATCH v9 18/21] drm/mediatek: Support alpha blending in display driver

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" and "None" blend mode on MediaTek's chips by adding correct blend mode property when the planes init. Before this patch, only the "Coverage" mode (default) is supported. For more information, there are three pixel blend modes in DRM driver: "None",

[PATCH v9 20/21] drm/mediatek: Support CRC in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung We choose OVL as the CRC generator from other hardware components that are also capable of calculating CRCs, since its frame done event triggers vblanks, it can be used as a signal to know when is safe to retrieve CRC of the frame. Please note that position of the hardware

[PATCH v9 14/21] drm/mediatek: Support "None" blending in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/

[PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode on in OVL. Before this patch, only the "coverage" mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 42 - 1 file changed, 34 insertions(+), 8 deletions(-)

[PATCH v9 15/21] drm/mediatek: Support "None" blending in Mixer

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" alpha blending mode on MediaTek's chips. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_et

[PATCH v9 12/21] drm/mediatek: Support DRM plane alpha in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Set the plane alpha according to DRM plane property. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/

[PATCH v9 13/21] drm/mediatek: Support DRM plane alpha in Mixer

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Set the plane alpha according to DRM plane property. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_ethdr.c b/drivers/gpu/drm/mediatek/mtk_et

[PATCH v9 05/21] drm/mediatek: Set DRM mode configs accordingly

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Set DRM mode configs limitation according to the hardware capabilities and pass the IGT checks as below: - The test "graphics.IgtKms.kms_plane" requires a frame buffer with width of 4512 pixels (> 4096). - The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor si

[PATCH v9 21/21] drm/mediatek: Support CRC in OVL adaptor

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung We choose Mixer as CRC generator in OVL adaptor since its frame done event will trigger vblanks, we can know when is safe to retrieve CRC of the frame. In OVL adaptor, there's no image procession after Mixer, unlike the OVL in VDOSYS0, Mixer's CRC will include all the effe

[PATCH v9 17/21] drm/mediatek: Support "Pre-multiplied" blending in Mixer

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" alpha blending mode in Mixer. Before this patch, only the coverage mode is supported. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v9 00/21] Support IGT in display driver

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung This series adds support for running IGT (Intel GPU Tool) tests with MediaTek display driver. The following changes will be applied: 1. Add a new API for creating GCE thread loop to retrieve CRCs from the hardware component 2. Support hardware CRC calculation in both VD

[PATCH v9 10/21] drm/mediatek: Fix XRGB setting error in Mixer

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Although the alpha channel in XRGB formats can be ignored, ALPHA_CON must be configured accordingly when using XRGB formats or it will still affects CRC generation. Fixes: d886c0009bd0 ("drm/mediatek: Add ETHDR support for MT8195") Signed-off-by: Hsiao Chien Sung --- dri

[PATCH v9 09/21] drm/mediatek: Fix XRGB setting error in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung CONST_BLD must be enabled for XRGB formats although the alpha channel can be ignored, or OVL will still read the value from memory. This error only affects CRC generation. Fixes: c410fa9b07c3 ("drm/mediatek: Add AFBC support to Mediatek DRM driver") Signed-off-by: Hsiao Ch

[PATCH v9 11/21] drm/mediatek: Add new color format MACROs in OVL

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Define new color formats to hide the bit operation in the MACROs to make the switch statement more concise. Change the MACROs to align the naming rule in DRM. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 14 -- 1 file changed,

[PATCH v9 04/21] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Always add DRM_MODE_ROTATE_0 to rotation property to meet IGT's (Intel GPU Tools) requirement. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 6 +- drivers/gpu/drm/mediatek/

[PATCH v9 03/21] drm/mediatek: Add missing plane settings when async update

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Fix an issue that plane coordinate was not saved when calling async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/d

[PATCH v9 01/21] soc: mediatek: Disable 9-bit alpha in ETHDR

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung When 9-bit alpha is enabled, its value will be converted from 0-255 to 0-256 (255 = not defined). This is designed for special HDR related calculation, which should be disabled by default, otherwise, alpha blending will not work correctly. Reviewed-by: AngeloGioacchino Del

[PATCH v9 02/21] drm/mediatek: Add OVL compatible name for MT8195

2024-06-13 Thread Shawn Sung
From: Hsiao Chien Sung Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 ins

[PATCH V2] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-06-13 Thread carlos . song
From: Carlos Song Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When lpi2c send data, it is tx cmd register and tx data fifo. When lpi2c receive data, it is just a rx cmd register. LPI2C

Re: [PATCH v5] drm/ci: add tests on vkms

2024-06-13 Thread Vignesh Raman
Hi Maxime, On 13/06/24 22:58, Maxime Ripard wrote: Hi, On Thu, Jun 13, 2024 at 01:56:10PM GMT, Vignesh Raman wrote: On 13/06/24 13:07, Maxime Ripard wrote: Hi, On Tue, Jun 11, 2024 at 02:40:37PM GMT, Vignesh Raman wrote: diff --git a/drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt b/drivers

Re: [PATCH net-next v12 00/13] Device Memory TCP

2024-06-13 Thread Jakub Kicinski
On Thu, 13 Jun 2024 01:35:37 + Mina Almasry wrote: > v12: > https://patchwork.kernel.org/project/netdevbpf/list/?series=859747&state=* patches 5 and 6 transiently break the build ../include/trace/events/page_pool.h:65:23: error: use of undeclared identifier 'NET_IOV' 65 |

[PATCH v4 3/3] drm/panel-edp: drop several legacy panels

2024-06-13 Thread Dmitry Baryshkov
The panel-edp driver supports legacy compatible strings for several eDP panels which were never used in DT files present in Linux tree and most likely have never been used with the upstream kernel. Drop compatibles for these panels in favour of using a generic "edp-panel" device on the AUX bus. Re

[PATCH v4 1/3] drm/panel-edp: add fat warning against adding new panel compatibles

2024-06-13 Thread Dmitry Baryshkov
Add a fat warning against adding new panel compatibles to the panel-edp driver. All new users of the eDP panels are supposed to use the generic "edp-panel" compatible device on the AUX bus. The remaining compatibles are either used by the existing DT or were used previously and are retained for bac

[PATCH v4 2/3] dt-bindings: display: panel-edp-legacy: drop several eDP panels

2024-06-13 Thread Dmitry Baryshkov
The panel-edp-legacy.yaml includes legacy bindings for several eDP panels which were never used in DT files present in Linux tree and most likely have never been used with the upstream kernel. Drop compatibles for these panels in favour of using a generic "edp-panel" device on the AUX bus. Reviewe

[PATCH v4 0/3] drm/panel-edp: remove several legacy compatibles used by the driver

2024-06-13 Thread Dmitry Baryshkov
There are two ways to describe an eDP panel in device tree. The recommended way is to add a device on the AUX bus, ideally using the edp-panel compatible. The legacy way is to define a top-level platform device for the panel. Document that adding support for eDP panels in a legacy way is strongly

Re: [PATCH v4 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-06-13 Thread Konrad Dybcio
On 6/13/24 17:15, Marc Gonzalez wrote: From: Arnaud Vrac Port device nodes from vendor code. Signed-off-by: Arnaud Vrac Reviewed-by: Dmitry Baryshkov Signed-off-by: Marc Gonzalez --- [...] + + hdmi: hdmi-tx@c9a { + compatible =

Re: [PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-13 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The dpu_crtc_atomic_check() already calls the function _dpu_crtc_check_and_setup_lm_bounds(). There is no need to call it again from dpu_crtc_atomic_begin(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 --

Re: [PATCH v3 5/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-13 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++

Re: [PATCH v3 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-13 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Signed-off-by: Dmitry Baryshkov --- drivers/gp

Re: [PATCH v3 2/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-13 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 - drivers/gpu/drm/msm/disp/dpu

Re: [PATCH v3 1/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-13 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Make _dpu_crtc_setup_lm_bounds() check that CRTC width is not overflowing LM requirements. Rename the function accordingly. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu

Re: Patch "Revert "drm/amdgpu: init iommu after amdkfd device init"" has been added to the 5.15-stable tree

2024-06-13 Thread Armin Wolf
Am 12.06.24 um 14:45 schrieb gre...@linuxfoundation.org: This is a note to let you know that I've just added the patch titled Revert "drm/amdgpu: init iommu after amdkfd device init" to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/

[PATCH v3 6/9] drm/msm/dpu: check for the plane pitch overflow

2024-06-13 Thread Dmitry Baryshkov
Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 6 +- 2 files changed, 7 insertions(+)

[PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-13 Thread Dmitry Baryshkov
The dpu_crtc_atomic_check() already calls the function _dpu_crtc_check_and_setup_lm_bounds(). There is no need to call it again from dpu_crtc_atomic_begin(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH v3 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-13 Thread Dmitry Baryshkov
Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 15 +++

[PATCH v3 3/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-13 Thread Dmitry Baryshkov
The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layout in the plane state and drop this call from dpu_plane_sspp_update(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ---

[PATCH v3 5/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-13 Thread Dmitry Baryshkov
Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v3 8/9] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-06-13 Thread Dmitry Baryshkov
dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 3 --- drivers/gpu/drm

[PATCH v3 4/9] drm/msm/dpu: split dpu_format_populate_layout

2024-06-13 Thread Dmitry Baryshkov
Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 45 -- dri

[PATCH v3 0/9] drm/msm/dpu: be more friendly to X.org

2024-06-13 Thread Dmitry Baryshkov
Unlike other compositors X.org allocates a single framebuffer covering the whole screen space. This is not an issue with the single screens, but with the multi-monitor setup 5120x4096 becomes a limiting factor. Check the hardware-bound limitations and lift the FB max size to 16383x16383. Signed-of

[PATCH v3 2/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-13 Thread Dmitry Baryshkov
The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 - drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 16 --- drivers/gpu/drm/msm

[PATCH v3 1/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-13 Thread Dmitry Baryshkov
Make _dpu_crtc_setup_lm_bounds() check that CRTC width is not overflowing LM requirements. Rename the function accordingly. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 17 + 1 file changed,

[PATCH] drm/i915/gt/uc: Fix typo in comment

2024-06-13 Thread Andi Shyti
Replace "dynmically" with "dynamically". Signed-off-by: Andi Shyti Cc: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h b/drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h ind

[PATCH] drm/i915/gt/uc: Evaluate GuC priority within locks

2024-06-13 Thread Andi Shyti
The ce->guc_state.lock was made to protect guc_prio, which indicates the GuC priority level. But at the begnning of the function we perform some sanity check of guc_prio outside its protected section. Move them within the locked region. Use this occasion to expand the if statement to make it clea

[PATCH] drm/i915/gt/uc: Evaluate GuC priority within locks

2024-06-13 Thread Andi Shyti
The ce->guc_state.lock was made to protect guc_prio, which indicates the GuC priority level. But at the begnning of the function we perform some sanity check of guc_prio outside its protected section. Move them within the locked region. Use this occasion to expand the if statement to make it clea

Re: [PATCH] fbdev: vesafb: Detect VGA compatibility from screen info's VESA attributes

2024-06-13 Thread Helge Deller
On 6/13/24 23:50, Javier Martinez Canillas wrote: Helge Deller writes: On 6/13/24 11:02, Thomas Zimmermann wrote: Test the vesa_attributes field in struct screen_info for compatibility with VGA hardware. Vesafb currently tests bit 1 in screen_info's capabilities field, It sets the framebuffer

Re: [PATCH] drm/amd/display: Increase frame-larger-than warning limit

2024-06-13 Thread Nathan Chancellor
Hi Palmer (and AMD folks), On Tue, Jun 04, 2024 at 09:04:23AM -0700, Palmer Dabbelt wrote: > On Mon, 03 Jun 2024 15:29:48 PDT (-0700), nat...@kernel.org wrote: > > On Thu, May 30, 2024 at 07:57:42AM -0700, Palmer Dabbelt wrote: > > > From: Palmer Dabbelt > > > > > > I get a handful of build erro

Re: [PATCH v2 05/10] mm/util: Fix possible race condition in kstrdup()

2024-06-13 Thread Linus Torvalds
On Thu, 13 Jun 2024 at 14:14, Andrew Morton wrote: > > The concept sounds a little strange. If some code takes a copy of a > string while some other code is altering it, yes, the result will be a > mess. This is why get_task_comm() exists, and why it uses locking. The thing is, get_task_comm()

Re: [PATCH 4/9] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s

2024-06-13 Thread Sebastian Reichel
Hi, On Wed, Jun 12, 2024 at 03:52:57PM GMT, Tomeu Vizoso wrote: > See Chapter 36 "RKNN" from the RK3588 TRM (Part 1). > > This is a derivative of NVIDIA's NVDLA, but with its own front-end > processor. > > Mostly taken from downstream. > > Signed-off-by: Tomeu Vizoso > --- Looking at the TRM

[PATCH v15 8/9] udmabuf: Pin the pages using memfd_pin_folios() API

2024-06-13 Thread Vivek Kasireddy
Using memfd_pin_folios() will ensure that the pages are pinned correctly using FOLL_PIN. And, this also ensures that we don't accidentally break features such as memory hotunplug as it would not allow pinning pages in the movable zone. Using this new API also simplifies the code as we no longer ha

[PATCH v15 5/9] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap

2024-06-13 Thread Vivek Kasireddy
Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel V

[PATCH v15 9/9] selftests/udmabuf: Add tests to verify data after page migration

2024-06-13 Thread Vivek Kasireddy
Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful completion

[PATCH v15 4/9] udmabuf: add CONFIG_MMU dependency

2024-06-13 Thread Vivek Kasireddy
From: Arnd Bergmann There is no !CONFIG_MMU version of vmf_insert_pfn(): arm-linux-gnueabi-ld: drivers/dma-buf/udmabuf.o: in function `udmabuf_vm_fault': udmabuf.c:(.text+0xaa): undefined reference to `vmf_insert_pfn' Fixes: d1d00dd1fd2f ("udmabuf: use vmf_insert_pfn and VM_PFNMAP for handling

[PATCH v15 1/9] mm/gup: Introduce unpin_folio/unpin_folios helpers

2024-06-13 Thread Vivek Kasireddy
These helpers are the folio versions of unpin_user_page/unpin_user_pages. They are currently only useful for unpinning folios pinned by memfd_pin_folios() or other associated routines. However, they could find new uses in the future, when more and more folio-only helpers are added to GUP. We shoul

[PATCH v15 6/9] udmabuf: Add back support for mapping hugetlb pages

2024-06-13 Thread Vivek Kasireddy
A user or admin can configure a VMM (Qemu) Guest's memory to be backed by hugetlb pages for various reasons. However, a Guest OS would still allocate (and pin) buffers that are backed by regular 4k sized pages. In order to map these buffers and create dma-bufs for them on the Host, we first need to

[PATCH v15 7/9] udmabuf: Convert udmabuf driver to use folios

2024-06-13 Thread Vivek Kasireddy
This is mainly a preparatory patch to use memfd_pin_folios() API for pinning folios. Using folios instead of pages makes sense as the udmabuf driver needs to handle both shmem and hugetlb cases. And, using the memfd_pin_folios() API makes this easier as we no longer need to separately handle shmem

[PATCH v15 2/9] mm/gup: Introduce check_and_migrate_movable_folios()

2024-06-13 Thread Vivek Kasireddy
This helper is the folio equivalent of check_and_migrate_movable_pages(). Therefore, all the rules that apply to check_and_migrate_movable_pages() also apply to this one as well. Currently, this helper is only used by memfd_pin_folios(). This patch also includes changes to rename and convert the i

[PATCH v15 3/9] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios

2024-06-13 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the folios associated with a memfd, the memfd_pin_folios() API provides an option to not only pin the folios via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with memfds but it should wo

[PATCH v15 0/9] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios

2024-06-13 Thread Vivek Kasireddy
Currently, some drivers (e.g, Udmabuf) that want to longterm-pin the pages/folios associated with a memfd, do so by simply taking a reference on them. This is not desirable because the pages/folios may reside in Movable zone or CMA block. Therefore, having drivers use memfd_pin_folios() API ensure

Re: [PATCH 0/3] drm/panic: Fixes and graphical logo

2024-06-13 Thread Stephen Rothwell
Hi Geert, On Thu, 13 Jun 2024 11:48:15 +0200 Geert Uytterhoeven wrote: > > > > Has the drm-misc git repo moved? > > > > It moved to gitlab recently, the new url is > > g...@gitlab.freedesktop.org:drm/misc/kernel.git > > Time to tell Stephen... linux-next has been using that URL for some ti

Re: [PATCH v9 00/13] Make PCI's devres API more consistent

2024-06-13 Thread Bjorn Helgaas
On Thu, Jun 13, 2024 at 01:50:13PM +0200, Philipp Stanner wrote: > Changes in v9: > - Remove forgotten dead code ('enabled' bit in struct pci_dev) in > patch No.8 ("Move pinned status bit...") > - Rework patch No.3: > - Change title from "Reimplement plural devres functions" >

Re: [PATCH] fbdev: vesafb: Detect VGA compatibility from screen info's VESA attributes

2024-06-13 Thread Javier Martinez Canillas
Helge Deller writes: > On 6/13/24 11:02, Thomas Zimmermann wrote: >> Test the vesa_attributes field in struct screen_info for compatibility >> with VGA hardware. Vesafb currently tests bit 1 in screen_info's >> capabilities field, It sets the framebuffer address size and is >> unrelated to VGA. >

Re: [PATCH v5] drm/ci: add tests on vkms

2024-06-13 Thread Maxime Ripard
Hi, On Thu, Jun 13, 2024 at 01:56:10PM GMT, Vignesh Raman wrote: > On 13/06/24 13:07, Maxime Ripard wrote: > > Hi, > > > > On Tue, Jun 11, 2024 at 02:40:37PM GMT, Vignesh Raman wrote: > > > diff --git a/drivers/gpu/drm/ci/xfails/vkms-none-flakes.txt > > > b/drivers/gpu/drm/ci/xfails/vkms-none-fl

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-13 Thread Andrew Lunn
> +static int hbl_en_napi_poll(struct napi_struct *napi, int budget); > +static int hbl_en_port_open(struct hbl_en_port *port); When you do the Intel internal review, i expect this is crop up. No forward declarations please. Put the code in the right order so they are not needed. > +static int hb

Re: [PATCH v2 4/8] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source()

2024-06-13 Thread Marijn Suijten
On 2024-06-13 20:05:07, Dmitry Baryshkov wrote: > Setting vsync source makes sense only for DSI CMD panels. Pull the > is_cmd_mode condition out of the function into the calling code, so that > it becomes more explicit. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov Reviewed-b

Re: [PATCH 5/9] arm64: dts: rockchip: Enable the NPU on quartzpro64

2024-06-13 Thread Sebastian Reichel
Hi, On Wed, Jun 12, 2024 at 03:52:58PM GMT, Tomeu Vizoso wrote: > Enable the nodes added in a previous commit to the rk3588s device tree. > > Signed-off-by: Tomeu Vizoso > --- There is a separate regulator for the NPU. For QuartzPro64, which is basically the same as EVB1, it should look like th

Re: [PATCH 2/9] iommu/rockchip: Attach multiple power domains

2024-06-13 Thread Sebastian Reichel
Hi, On Thu, Jun 13, 2024 at 11:34:02AM GMT, Tomeu Vizoso wrote: > On Thu, Jun 13, 2024 at 11:24 AM Tomeu Vizoso wrote: > > On Thu, Jun 13, 2024 at 2:05 AM Sebastian Reichel > > wrote: > > > On Wed, Jun 12, 2024 at 03:52:55PM GMT, Tomeu Vizoso wrote: > > > > IOMMUs with multiple base addresses ca

Re: [PATCH v2 3/8] drm/msm/dsi: drop unused GPIOs handling

2024-06-13 Thread Marijn Suijten
On 2024-06-13 20:05:06, Dmitry Baryshkov wrote: > Neither disp-enable-gpios nor disp-te-gpios are defined in the schema. > None of the board DT files use those GPIO pins. Drop them from the > driver. What's worse, when people set disp-te-gpios the devm_gpiod_get_optional("disp-te", GPIOD_IN) below

Re: [PATCH] fbdev: vesafb: Detect VGA compatibility from screen info's VESA attributes

2024-06-13 Thread Helge Deller
On 6/13/24 11:02, Thomas Zimmermann wrote: Test the vesa_attributes field in struct screen_info for compatibility with VGA hardware. Vesafb currently tests bit 1 in screen_info's capabilities field, It sets the framebuffer address size and is unrelated to VGA. Section 4.4 of the Vesa VBE 2.0 spe

Re: [PATCH v9 03/13] PCI: Add partial-BAR devres support

2024-06-13 Thread Bjorn Helgaas
On Thu, Jun 13, 2024 at 01:50:16PM +0200, Philipp Stanner wrote: > With the current PCI devres API implementing a managed version of > pci_iomap_range() is impossible. > > Furthermore, the PCI devres API currently is inconsistent and > complicated. This is in large part due to the fact that there

[PATCH v2 7/7] drm/panic: Add support for drawing a monochrome graphical logo

2024-06-13 Thread Geert Uytterhoeven
Re-use the existing support for boot-up logos to draw a monochrome graphical logo in the DRM panic handler. When no suitable graphical logo is available, the code falls back to the ASCII art penguin logo. Note that all graphical boot-up logos are freed during late kernel initialization, hence a c

[PATCH 08/21] drm/nouveau/nvkm: move vgaarb code from drm

2024-06-13 Thread Ben Skeggs
Signed-off-by: Ben Skeggs --- drivers/gpu/drm/nouveau/nouveau_vga.c | 27 .../gpu/drm/nouveau/nvkm/subdev/pci/base.c| 32 +++ 2 files changed, 32 insertions(+), 27 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouv

Re: [PATCH v2 5/8] drm/msm/dpu: rework vsync_source handling

2024-06-13 Thread Marijn Suijten
Maybe retitle this to something that more closely resembles "remove unset is_te_using_watchdog_timer field"? On 2024-06-13 20:05:08, Dmitry Baryshkov wrote: > The struct msm_display_info has is_te_using_watchdog_timer field which > is neither used anywhere nor is flexible enough to specify differe

Re: [PATCH v7 03/13] PCI: Reimplement plural devres functions

2024-06-13 Thread Bjorn Helgaas
On Thu, Jun 13, 2024 at 07:54:38PM +0300, Ilpo Järvinen wrote: > On Wed, 5 Jun 2024, Philipp Stanner wrote: > > > When the original PCI devres API was implemented, priority was given to > > the creation of a set of "plural functions" such as > > pcim_request_regions(). These functions have bit mas

[RFC] GPU driver with separate "core" and "DRM" modules

2024-06-13 Thread Ben Skeggs
NVIDIA has been exploring ways to better support the effort for an upstream kernel mode driver for GPUs that are capable of running GSP-RM firmware, since the introduction[1] to Nova. Use cases have been identified for which separating the core GPU programming out of the full DRM driver stack is a

Re: [PATCH v2 05/10] mm/util: Fix possible race condition in kstrdup()

2024-06-13 Thread Andrew Morton
On Thu, 13 Jun 2024 10:30:39 +0800 Yafang Shao wrote: > In kstrdup(), it is critical to ensure that the dest string is always > NUL-terminated. However, potential race condidtion can occur between a > writer and a reader. > > Consider the following scenario involving task->comm: > > reader

  1   2   3   >