Re: [PATCH v14 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-22 Thread Krzysztof Kozlowski
On 22/12/2022 17:22, Kuogee Hsieh wrote: > > On 12/22/2022 2:47 AM, Krzysztof Kozlowski wrote: >> On 16/12/2022 20:11, Kuogee Hsieh wrote: >>> Move data-lanes property from mdss_dp node to dp_out endpoint. Also >>> add link-frequencies property into dp_out endpoint as well. The last >>> frequency

Re: [Intel-gfx] [PATCH] drm/i915/gt: Reset twice

2022-12-22 Thread Gwan-gyeong Mun
On 12/22/22 3:47 PM, Andi Shyti wrote: Hi GG,  drivers/gpu/drm/i915/gt/intel_reset.c | 34 ++-  1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index ffde89c5835a4..88dfc0c

[git pull] drm fixes for 6.2-rc1

2022-12-22 Thread Dave Airlie
Hi Linus, Holiday fixes!. Two batches from amd, and one group of i915 changes. I don't think there should be anything new, and it should all be fixes. Dave. drm-next-2022-12-23: drm fixes for 6.2-rc1 amdgpu: - Spelling fix - BO pin fix - Properly handle polaris 10/11 overlap asics - GMC9 fix -

Re: [RFC PATCH v2 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2022-12-22 Thread Dmitry Baryshkov
On 23/12/2022 00:14, Jessica Zhang wrote: Initialize and use the color_fill properties for planes in DPU driver. In addition, relax framebuffer requirements within atomic commit path and add checks for NULL framebuffers. Finally, drop DPU_PLANE_COLOR_FILL_FLAG as it's unused. Changes since V2: -

Re: [RFC PATCH v2 2/3] drm: Adjust atomic checks for solid fill color

2022-12-22 Thread Dmitry Baryshkov
On 23/12/2022 00:14, Jessica Zhang wrote: Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled (and FB_ID is NULL), the commit can still go through. In addition, add framebuffer NULL checks in other areas to account for FB being NULL when soli

[PATCH v6 17/18] arm64: dts: qcom: sdm845: Add compat qcom, sdm845-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,sdm845-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for sdm845 against the yaml documentation. Reviewed-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/

[PATCH v6 13/18] arm64: dts: qcom: sc7180: Add compat qcom, sc7180-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,sc7180-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for sc7180 against the yaml documentation. Reviewed-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/

[PATCH v6 16/18] arm64: dts: qcom: sdm660: Add compat qcom, sdm660-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,sdm660-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for sdm660 against the yaml documentation. Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/qcom/sdm660.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 d

[PATCH v6 15/18] arm64: dts: qcom: sdm630: Add compat qcom, sdm660-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
The sdm630 can use the sdm660 mdss-dsi-ctrl compat. Currently it has the same set of binding dependencies as sdm660. Suggested-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch

[PATCH v6 18/18] arm64: dts: qcom: sm8250: Add compat qcom, sm8250-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,sm8250-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for sm8250 against the yaml documentation. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 -- 1

[PATCH v6 05/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

2022-12-22 Thread Bryan O'Donoghue
Each compatible has a different set of clocks which are associated with it. Add in the list of clocks for each compatible. Acked-by: Rob Herring Acked-by: Krzysztof Kozlowski Signed-off-by: Bryan O'Donoghue --- .../display/msm/dsi-controller-main.yaml | 209 -- 1 file chan

[PATCH v6 12/18] arm64: dts: qcom: msm8996: Add compat qcom, msm8996-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,msm8996-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for msm8996 against the yaml documentation. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 --

[PATCH v6 14/18] arm64: dts: qcom: sc7280: Add compat qcom, sc7280-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,sc7280-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for sc7280 against the yaml documentation. Reviewed-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/

[PATCH v6 11/18] arm64: dts: qcom: msm8953: Add compat qcom, msm8953-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,msm8953-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for msm8953 against the yaml documentation. Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/qcom/msm8953.dtsi | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v6 10/18] arm64: dts: qcom: msm8916: Add compat qcom, msm8916-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,msm8916-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for msm8916 against the yaml documentation. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 3 ++- 1

[PATCH v6 07/18] dt-bindings: display/msm: Add list of mdss-dsi-ctrl compats

2022-12-22 Thread Bryan O'Donoghue
Add the list of current compats absent the deprecated qcm2290 to the list of dsi compats listed here. Several MDSS yaml files exist which document the dsi sub-node. For each existing SoC MDSS yaml, provide the right dsi compat string. Signed-off-by: Bryan O'Donoghue --- .../bindings/display/msm

[PATCH v6 08/18] ARM: dts: qcom: apq8064: add compat qcom, apq8064-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Append silicon specific compatible qcom,apq8064-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for apq8064 against the yaml documentation. Reviewed-by: David Heidelberg Reviewed-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm/boot/d

[PATCH v6 06/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

2022-12-22 Thread Bryan O'Donoghue
When converting from .txt to .yaml we didn't include descriptions for the existing regulator supplies. - vdd - vdda - vddio Add those descriptions into the yaml now as they were prior to the conversion. In the .txt description we marked these regulators as required, however, that requirement appe

[PATCH v6 02/18] dt-bindings: msm: dsi-controller-main: Fix power-domain constraint

2022-12-22 Thread Bryan O'Donoghue
power-domain is required for the sc7180 dispcc GDSC but not every qcom SoC has a similar dependency for example the apq8064. Most Qcom SoC's using mdss-dsi-ctrl seem to have the ability to power-collapse the MDP without collapsing DSI. For example the qcom vendor kernel commit for apq8084, msm822

[PATCH v6 04/18] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC

2022-12-22 Thread Bryan O'Donoghue
Currently we do not differentiate between the various users of the qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one compatible string but, the hardware does have some significant differences in the number of clocks. To facilitate documenting the clocks add the following compat

[PATCH v6 09/18] ARM: dts: qcom: msm8974: Add compat qcom, msm8974-dsi-ctrl

2022-12-22 Thread Bryan O'Donoghue
Add silicon specific compatible qcom,msm8974-dsi-ctrl to the mdss-dsi-ctrl block. This allows us to differentiate the specific bindings for msm8974 against the yaml documentation. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bryan O'Donoghue --- arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++- 1 fi

[PATCH v6 03/18] dt-bindings: msm: dsi-controller-main: Fix description of core clock

2022-12-22 Thread Bryan O'Donoghue
There's a typo in describing the core clock as an 'escape' clock. The accurate description is 'core'. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Reviewed-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski Signed-off-by: Bryan O'Donoghue --- .../devicetree/

[PATCH v6 01/18] dt-bindings: msm: dsi-controller-main: Fix operating-points-v2 constraint

2022-12-22 Thread Bryan O'Donoghue
The existing msm8916.dtsi does not depend on nor require operating points. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Reviewed-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski Signed-off-by: Bryan O'Donoghue --- .../devicetree/bindings/display/msm/dsi-co

[PATCH v6 00/18] mdss-dsi-ctrl binding and dts fixes

2022-12-22 Thread Bryan O'Donoghue
V6: - Squashes a number of patches per Krzysztof's comments on bisectability - Adds in Acked-by Rob and Krzysztof V5: - Adds compat strings to bindings/display/msm/qcom,SoC-mdss.yaml - Dmitry - Re-orders simple fixes to the start of the series to allow backports - Dmitry - VDDA and drop of node-

[PATCH v2 3/3] drm: Convert users of drm_of_component_match_add to component_match_add_of

2022-12-22 Thread Sean Anderson
Every user of this function either uses component_compare_of or something equivalent. Most of them immediately put the device node as well. Convert these users to component_match_add_of and remove drm_of_component_match_add. Signed-off-by: Sean Anderson Acked-by: Jyri Sarha Tested-by: Jyri Sarha

[PATCH v2 2/3] iommu/sound: Use component_match_add_of helper

2022-12-22 Thread Sean Anderson
Convert users of component_match_add_release with component_release_of and component_compare_of to component_match_add_of. Signed-off-by: Sean Anderson Acked-by: Mark Brown --- Changes in v2: - Split off from helper addition drivers/iommu/mtk_iommu.c| 3 +-- drivers/iommu/mtk_iommu_v1.c |

[PATCH v2 1/3] component: Add helper for device nodes

2022-12-22 Thread Sean Anderson
There is a common case where component_patch_add_release is called with component_release_of/component_compare_of and a device node. Add a helper. Signed-off-by: Sean Anderson --- Changes in v2: - Split off conversion from helper addition include/linux/component.h | 9 + 1 file changed

[PATCH v2 0/3] drm: Add component_match_add_of and convert users of drm_of_component_match_add

2022-12-22 Thread Sean Anderson
This series adds a new function component_match_add_of to simplify the common case of calling component_match_add_release with component_release_of and component_compare_of. There is already drm_of_component_match_add, which allows for a custom compare function. However, all existing users just use

Re: [PATCH 041/606] drm/i2c/tda998x: Convert to i2c's .probe_new()

2022-12-22 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez

Re: [PATCH 040/606] drm/i2c/tda9950: Convert to i2c's .probe_new()

2022-12-22 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez

Re: [PATCH 039/606] drm/i2c/sil164: Convert to i2c's .probe_new()

2022-12-22 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez

Re: [PATCH 042/606] drm/panel: olimex-lcd-olinuxino: Convert to i2c's .probe_new()

2022-12-22 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez

Re: [PATCH 043/606] drm/panel: raspberrypi-touchscreen: Convert to i2c's .probe_new()

2022-12-22 Thread Javier Martinez Canillas
On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez

[PATCH 2/4] dt-bindings: display: Add Himax HX8394 panel controller bindings

2022-12-22 Thread Javier Martinez Canillas
Add device tree bindings for panels based on the Himax HX8394 controller, such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected through a MIPI-DSI video interface. Signed-off-by: Javier Martinez Canillas --- .../bindings/display/panel/himax,hx8394.yaml | 68 +

[PATCH 1/4] drm: panel: Add Himax HX8394 panel controller driver

2022-12-22 Thread Javier Martinez Canillas
From: Kamil Trzciński The driver is for panels based on the Himax HX8394 controller, such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface. Signed-off-by: Kamil Trzciński Co-developed-by: Ondrej Jirman Signed-off-by: Ondrej Jirman Co-developed-by: Javier Martin

[PATCH 0/4] Add PinePhone Pro display support

2022-12-22 Thread Javier Martinez Canillas
This series add support for the display present in the PinePhone Pro. Patch #1 adds a driver for panels using the Himax HX8394 panel controller, such as the HSD060BHW4 720x1440 TFT LCD panel present in the PinePhone Pro. Patch #2 adds a devicetree binding schema for this driver and patch #3 adds

[RFC PATCH 15/20] drm/i915: Rename find_section to find_bdb_section

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst This prevents a namespace collision on other archs. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_bios.c | 46 +++ 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/

[RFC PATCH 20/20] mei/hdcp: Also enable for XE

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Xe, is a new driver for Intel GPUs that supports both integrated and discrete platforms starting with Tiger Lake. Let's ensure mei/hdcp can accept xe instead of i915 whenever that is in use. Cc: Tomas Winkler Signed-off-by: Maarten Lankhorst --- drivers/misc/mei/hdcp/K

[RFC PATCH 13/20] drm/i915/display: Add more macros to remove all direct calls to uncore

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_de.h | 38 + 1 file changed, 38 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_de.h b/drivers/gpu/drm/i915/display/intel_de.h index 3dbd76fdabd6..3394044d281c

[RFC PATCH 17/20] drm/i915/display: Fix a use-after-free when intel_edp_init_connector fails

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst We enable the DP aux channel during probe, but may free the connector soon afterwards. Ensure the DP aux display power put is completed before everything is freed, to prevent a use-after-free in icl_aux_pw_to_phy(), called from icl_combo_phy_aux_power_well_disable. Signed

[RFC PATCH 18/20] drm/i915/display: Remaining changes to make xe compile

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Xe, the new Intel GPU driver, will re-use the i915 display. At least for now, the plan is to use symbolic links and adjust the build so we are building the display either for i915 or for xe. The display can be split out if needed. Also the compilation is optional at this

[RFC PATCH 19/20] sound/hda: Allow XE as i915 replacement for sound

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Xe, is a new driver for Intel GPUs that supports both integrated and discrete platforms starting with Tiger Lake. Let's ensure sound can accept xe instead of i915 whenever that is in use. Cc: Kai Vehmanen Signed-off-by: Maarten Lankhorst --- sound/hda/hdac_i915.c

[RFC PATCH 16/20] drm/i915/regs: Set DISPLAY_MMIO_BASE to 0 for xe

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Only required for some old pre-gen9 platforms, not for Xe. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/Makefile | 2 +- drivers/gpu/drm/i915/display/intel_display_reg_defs.h | 4 2 files changed, 5 insertions(+), 1 deletion(-)

[RFC PATCH 12/20] drm/i915/display: Neuter frontbuffer tracking harder

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Remove intel_frontbuffer type, and use fb->bits. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_cursor.c | 6 +- drivers/gpu/drm/i915/display/intel_display.c | 4 +- .../drm/i915/display/intel_display_types.h| 8 +- drivers/gpu/drm/

[RFC PATCH 10/20] drm/ttm: Don't print error message if eviction was interrupted

2022-12-22 Thread Matthew Brost
From: Thomas Hellström Avoid printing an error message if eviction was interrupted by, for example, the user pressing CTRL-C. That may happen if eviction is waiting for something, like for example a free batch-buffer. Signed-off-by: Thomas Hellström --- drivers/gpu/drm/ttm/ttm_bo.c | 3 ++- 1

[RFC PATCH 09/20] drm: Add a gpu page-table walker helper

2022-12-22 Thread Matthew Brost
From: Thomas Hellström Add a gpu page table walker similar in functionality to the cpu page-table walker in mm/pagewalk.c. This is made a drm helper in the hope that it might prove useful to other drivers, but we could of course make it single-driver only and rename the functions initially. Also

[RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2022-12-22 Thread Matthew Brost
In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 mapping between a drm_gpu_scheduler and drm_sched_entity. At first this seems a bit odd but let us explain the reasoning below. 1. In XE the submission order from multiple drm_sched_entity is not guaranteed to be the same completi

[RFC PATCH 05/20] drm/sched: Add generic scheduler message interface

2022-12-22 Thread Matthew Brost
Add generic schedule message interface which sends messages to backend from the drm_gpu_scheduler main submission thread. The idea is some of these messages modify some state in drm_sched_entity which is also modified during submission. By scheduling these messages and submission in the same thread

[RFC PATCH 11/20] drm/i915: Remove gem and overlay frontbuffer tracking

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Frontbuffer update handling should be done explicitly by using dirtyfb calls only. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/i9xx_plane.c | 1 + drivers/gpu/drm/i915/display/intel_drrs.c | 1 + drivers/gpu/drm/i915/display/intel_fb.c

[RFC PATCH 03/20] drm/radeon: Use the drm suballocation manager implementation.

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Use the generic suballocation helper. Note that the generic suballocator only allows a single alignment, so we may waste a few more bytes for radeon_semaphore, shouldn't be a big deal, could be re-added if needed. Also, similar to amdgpu, debug output changes slightly and

[RFC PATCH 07/20] drm/sched: Submit job before starting TDR

2022-12-22 Thread Matthew Brost
If the TDR is set to a value, it can fire before a job is submitted in drm_sched_main. The job should be always be submitted before the TDR fires, fix this ordering. Signed-off-by: Matthew Brost --- drivers/gpu/drm/scheduler/sched_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[RFC PATCH 08/20] drm/sched: Add helper to set TDR timeout

2022-12-22 Thread Matthew Brost
Add helper to set TDR timeout and restart the TDR with new timeout value. This will be used in XE, new Intel GPU driver, to trigger the TDR to cleanup drm_sched_entity that encounter errors. Signed-off-by: Matthew Brost --- drivers/gpu/drm/scheduler/sched_main.c | 18 ++ include/

[RFC PATCH 06/20] drm/sched: Start run wq before TDR in drm_sched_start

2022-12-22 Thread Matthew Brost
If the TDR is set to a very small value it can fire before the run wq is started in the function drm_sched_start. The run wq is expected to running when the TDR fires, fix this ordering so this expectation is always met. Signed-off-by: Matthew Brost --- drivers/gpu/drm/scheduler/sched_main.c | 4

[RFC PATCH 01/20] drm/suballoc: Introduce a generic suballocation manager

2022-12-22 Thread Matthew Brost
From: Thomas Hellström Initially we tried to leverage the amdgpu suballocation manager. It turnes out, however, that it tries extremely hard not to enable signalling on the fences that hold the memory up for freeing, which makes it hard to understand and to fix potential issues with it. So in a

[RFC PATCH 02/20] drm/amd: Convert amdgpu to use suballocation helper.

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Now that we have a generic suballocation helper, Use it in amdgpu. The debug output is slightly different and suballocation may be slightly more cpu-hungry. Signed-off-by: Maarten Lankhorst Co-developed-by: Thomas Hellström Signed-off-by: Thomas Hellström --- drivers/

[RFC PATCH 14/20] drm/i915/display: Remove all uncore mmio accesses in favor of intel_de

2022-12-22 Thread Matthew Brost
From: Maarten Lankhorst Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/hsw_ips.c| 7 ++- drivers/gpu/drm/i915/display/intel_bios.c | 25 ++- drivers/gpu/drm/i915/display/intel_bw.c | 34 +++--- drivers/gpu/drm/i915/display/intel_cdclk.c|

[RFC PATCH 00/20] Initial Xe driver submission

2022-12-22 Thread Matthew Brost
Hello, This is a submission for Xe, a new driver for Intel GPUs that supports both integrated and discrete platforms starting with Tiger Lake (first platform with Intel Xe Architecture). The intention of this new driver is to have a fresh base to work from that is unencumbered by older platforms,

Re: [PATCH 038/606] drm/i2c/ch7006: Convert to i2c's .probe_new()

2022-12-22 Thread Javier Martinez Canillas
Hello Uwe, On 11/18/22 23:36, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/drm/i2c/ch7006_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(

[RFC PATCH v2 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2022-12-22 Thread Jessica Zhang
Initialize and use the color_fill properties for planes in DPU driver. In addition, relax framebuffer requirements within atomic commit path and add checks for NULL framebuffers. Finally, drop DPU_PLANE_COLOR_FILL_FLAG as it's unused. Changes since V2: - Fixed dropped 'const' warning - Dropped use

[RFC PATCH v2 0/3] Support for Solid Fill Planes

2022-12-22 Thread Jessica Zhang
Introduce and add support for a solid_fill property. When the solid_fill property is set, and the framebuffer is set to NULL, memory fetch will be disabled. In addition, loosen the NULL FB checks within the atomic commit callstack to allow a NULL FB when the solid_fill property is set and add FB c

[RFC PATCH v2 2/3] drm: Adjust atomic checks for solid fill color

2022-12-22 Thread Jessica Zhang
Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled (and FB_ID is NULL), the commit can still go through. In addition, add framebuffer NULL checks in other areas to account for FB being NULL when solid fill is enabled. Changes in V2: - Changed

[RFC PATCH v2 1/3] drm: Introduce solid fill property for drm plane

2022-12-22 Thread Jessica Zhang
Add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. solid_fill holds data for supporting solid fill planes. The property accepts an RGB323232 value and the driver data is formatted as such: struct drm_solid_fill { u

Re: [PATCH 038/606] drm/i2c/ch7006: Convert to i2c's .probe_new()

2022-12-22 Thread Uwe Kleine-König
Hello Dave, hello Daniel, On Fri, Nov 18, 2022 at 11:36:12PM +0100, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/drm/i2c/ch7006_drv.c | 4 ++-- > 1 file

[PATCH] drm: kirin: Enable COMPILE_TEST

2022-12-22 Thread Sean Anderson
Use macros for 64-bit operations. This allows compile-testing this driver on 32-bit arches, so enable it. Signed-off-by: Sean Anderson --- drivers/gpu/drm/hisilicon/kirin/Kconfig | 2 +- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 10 +- 2 files changed, 6 insertions(+), 6 dele

Re: [PATCH 0/2] drm: Add component_match_add_of and convert users of drm_of_component_match_add

2022-12-22 Thread Sean Anderson
Hi Robin, On 12/16/22 12:41, Robin Murphy wrote: > On 2022-12-16 17:08, Sean Anderson wrote: >> On 11/3/22 14:22, Sean Anderson wrote: >>> This series adds a new function component_match_add_of to simplify the >>> common case of calling component_match_add_release with >>> component_release_of and

[PATCH] drm/amdkfd: Use resource_size() helper function

2022-12-22 Thread Deepak R Varma
Use the resource_size() function instead of a open coded computation resource size. It makes the code more readable. Issue identified using resource_size.cocci coccinelle semantic patch. Signed-off-by: Deepak R Varma --- Note: Proposed change compile tested only. drivers/gpu/drm/amd/amdkfd/kfd

Re: [PATCH v6 08/17] dt-bindings: usb: convert fcs,fusb302.txt to yaml

2022-12-22 Thread Rob Herring
On Thu, 22 Dec 2022 15:28:53 +0100, Johan Jonker wrote: > Convert fcs,fusb302.txt to yaml. > > Changed: > Add vbus-supply property > > Signed-off-by: Johan Jonker > --- > > Changed V6: > Add unevaluatedProperties > Drop unused labels > --- > .../devicetree/bindings/usb/fcs,fusb302.txt

Re: [PATCH v6 07/17] dt-bindings: display: rockchip: convert analogix_dp-rockchip.txt to yaml

2022-12-22 Thread Rob Herring
On Thu, 22 Dec 2022 15:27:35 +0100, Johan Jonker wrote: > Convert analogix_dp-rockchip.txt to yaml. > > Changed: > Add power-domains property > File name > > Signed-off-by: Johan Jonker > --- > .../display/rockchip/analogix_dp-rockchip.txt | 98 - > .../rockchip/rockchip,

Re: [PATCH v6 06/17] dt-bindings: display: bridge: convert analogix_dp.txt to yaml

2022-12-22 Thread Rob Herring
On Thu, 22 Dec 2022 15:26:57 +0100, Johan Jonker wrote: > Convert analogix_dp.txt to yaml for use as common document. > > Changed: > Relexed requirements > > Signed-off-by: Johan Jonker > --- > .../bindings/display/bridge/analogix,dp.yaml | 63 +++ > .../bindings/display/br

Re: [PATCH 0/2] Recover from failure to probe GPU

2022-12-22 Thread Javier Martinez Canillas
[adding Thomas Zimmermann to CC list] Hello Mario, Interesting case. On 12/22/22 19:30, Mario Limonciello wrote: > One of the first thing that KMS drivers do during initialization is > destroy the system firmware framebuffer by means of > `drm_aperture_remove_conflicting_pci_framebuffers` > The

Re: [PATCH v6 05/17] dt-bindings: display: rockchip: convert dw_mipi_dsi_rockchip.txt to yaml

2022-12-22 Thread Rob Herring
On Thu, 22 Dec 2022 15:26:28 +0100, Johan Jonker wrote: > Convert dw_mipi_dsi_rockchip.txt to yaml. > > Changed: > file name > requirements > > Signed-off-by: Johan Jonker > --- > > Changed V6: > Remove clock-master property > Fix $ref > --- > .../display/rockchip/dw_mipi_dsi_rockchi

Re: [PATCH v6 03/17] dt-bindings: display: dsi-controller: move clock-master property

2022-12-22 Thread Rob Herring
On Thu, 22 Dec 2022 15:24:51 +0100, Johan Jonker wrote: > The clock-master property is used for the controller and not in the panel, > so move it there. > > Signed-off-by: Johan Jonker > --- > .../bindings/display/dsi-controller.yaml | 18 +- > 1 file changed, 9 insertion

Re: [PATCH] drm/bridge: panel: Set pre_enable_prev_first from drmm_panel_bridge_add

2022-12-22 Thread Jagan Teki
On Fri, Dec 23, 2022 at 12:22 AM Dave Stevenson wrote: > > Commit 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to drm_panel") > added code to copy prepare_prev_first from drm_panel to pre_enable_prev_first > in drm_bridge when called through devm_panel_bridge_add, but > missed drmm_panel_

Re: [PATCH v6] drm: Optimise for continuous memory allocation

2022-12-22 Thread Dan Carpenter
Hi xinhui, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/xinhui-pan/drm-Optimise-for-continuous-memory-allocation/20221218-145922 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lo

[PATCH] drm/bridge: panel: Set pre_enable_prev_first from drmm_panel_bridge_add

2022-12-22 Thread Dave Stevenson
Commit 5ea6b1702781 ("drm/panel: Add prepare_prev_first flag to drm_panel") added code to copy prepare_prev_first from drm_panel to pre_enable_prev_first in drm_bridge when called through devm_panel_bridge_add, but missed drmm_panel_bridge_add. Add the same code to drmm_panel_bridge_add. Fixes: 5

[PATCH 2/2] drm/amd: Re-create firmware framebuffer on failure to probe

2022-12-22 Thread Mario Limonciello
If the probe sequence fails then the user is stuck with a frozen screen and can only really recover via SSH or by rebooting and applying nomodeset to the kernel command line. This is particularly problematic as newer GPUs are introduced because distributions may take some time to land newer GPU fi

[PATCH 1/2] firmware: sysfb: Allow re-creating system framebuffer after init

2022-12-22 Thread Mario Limonciello
When GPU kernel drivers have failed to load for any reason the current experience is that the screen is frozen. This is because one of the first things that these drivers do is to call `sysfb_disable`. For end users this is quite jarring and hard to recover from. Allow drivers to request the fra

[PATCH 0/2] Recover from failure to probe GPU

2022-12-22 Thread Mario Limonciello
One of the first thing that KMS drivers do during initialization is destroy the system firmware framebuffer by means of `drm_aperture_remove_conflicting_pci_framebuffers` This means that if for any reason the GPU failed to probe the user will be stuck with at best a screen frozen at the last thing

[PULL] drm-misc-fixes

2022-12-22 Thread Maxime Ripard
Hi, here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2022-12-22: One fix for a use-after-free in panfrost, one to fix the error handling in dma_buf_export and one to fix a compile error with drm_plane_helper_atomic_check missing a definition for drm_atomic_state The following changes sin

Re: [PATCH] drm: override detected status for connectors which are forced on

2022-12-22 Thread Maxime Ripard
Hi, On Thu, Dec 15, 2022 at 06:03:59PM +0100, Michael Rodin wrote: > The detected status of a connector should be ignored when a connector is > forced as hinted in the commit d50ba256b5f1 ("drm/kms: start > adding command line interface using fb."). One negative side effect of > not ignoring this

Re: [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-22 Thread Andrew Morton
On Thu, 22 Dec 2022 12:46:16 +0100 Andrzej Hajda wrote: > Hi all, > > I hope there will be place for such tiny helper in kernel. > Quick cocci analyze shows there is probably few thousands places > where it could be useful. So to clarify, the intent here is a simple readability cleanup for exi

Re: [PATCH v4 0/7] Introduce debugfs device-centered functions

2022-12-22 Thread Daniel Vetter
On Mon, Dec 19, 2022 at 11:49:47AM -0100, Melissa Wen wrote: > On 12/19, Maíra Canal wrote: > > This series introduces the initial structure to make DRM debugfs more > > device-centered and it is the first step to drop the > > drm_driver->debugfs_init hooks in the future [1]. > > > > Currently, DR

Re: [PATCH v3 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-22 Thread Daniel Thompson
On Thu, Dec 22, 2022 at 08:54:40PM +0800, Jianhua Lu wrote: > Add support for Kinetic KTZ8866 backlight, which is used in > Xiaomi tablet, Mi Pad 5 series. This driver lightly based on > downstream implementation [1]. > [1] > https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/driv

Re: [PATCH v14 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-22 Thread Kuogee Hsieh
On 12/22/2022 2:47 AM, Krzysztof Kozlowski wrote: On 16/12/2022 20:11, Kuogee Hsieh wrote: Move data-lanes property from mdss_dp node to dp_out endpoint. Also add link-frequencies property into dp_out endpoint as well. The last frequency specified at link-frequencies will be the max link rate

Re: [PATCH v4 3/5] drm/msm/a6xx: Vote for cx gdsc from gpu driver

2022-12-22 Thread Ulf Hansson
On Wed, 21 Dec 2022 at 18:14, Akhil P Oommen wrote: > > When a device has multiple power domains, dev->power_domain is left > empty during probe. That didn't cause any issue so far because we are > freeloading on smmu driver's vote on cx gdsc. Instead of that, create > a device_link between cx gen

Re: [PATCH v4 5/5] drm/msm/a6xx: Use genpd notifier to ensure cx-gdsc collapse

2022-12-22 Thread Ulf Hansson
On Wed, 21 Dec 2022 at 18:14, Akhil P Oommen wrote: > > As per the recommended recovery sequence of adreno gpu, cx gdsc should > collapse at hardware before it is turned back ON. This helps to clear > out the stale states in hardware before it is reinitialized. Use the > genpd notifier along with

Re: [PATCH v4 4/5] drm/msm/a6xx: Remove cx gdsc polling using 'reset'

2022-12-22 Thread Ulf Hansson
On Wed, 21 Dec 2022 at 18:14, Akhil P Oommen wrote: > > Remove the unused 'reset' interface which was supposed to help to ensure > that cx gdsc has collapsed during gpu recovery. This is was not enabled > so far due to missing gpucc driver support. Similar functionality using > genpd framework wil

Re: [PATCH v4 2/5] clk: qcom: gdsc: Support 'synced_poweroff' genpd flag

2022-12-22 Thread Ulf Hansson
On Wed, 21 Dec 2022 at 18:14, Akhil P Oommen wrote: > > Add support for the newly added 'synced_poweroff' genpd flag. This allows > some clients (like adreno gpu driver) to request gdsc driver to ensure > a votable gdsc (like gpucc cx gdsc) has collapsed at hardware. > > Signed-off-by: Akhil P Oom

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-22 Thread Lucas De Marchi
On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended to new platforms or steppings. Remove them alt

Re: [PATCH v2 7/9] drm: Remove usage of deprecated DRM_DEBUG_PRIME

2022-12-22 Thread Simon Ser
This patch is: Reviewed-by: Simon Ser

[PATCH v10 14/15] drm/msm/disp/dpu: reset the datapath after timing engine disable

2022-12-22 Thread Vinod Polimera
Reset the datapath after disabling the timing gen, such that it can start on a clean slate when the intf is enabled back. This was a recommended sequence from the DPU HW programming guide. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1 + 1 file change

[PATCH v10 15/15] drm/msm/disp/dpu: clear active interface in the datapath cleanup

2022-12-22 Thread Vinod Polimera
Clear interface active register from the datapath for a clean shutdown of the datapath. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu

[PATCH v10 12/15] drm/msm/disp/dpu: get timing engine status from intf status register

2022-12-22 Thread Vinod Polimera
Recommended way of reading the interface timing gen status is via status register. Timing gen status register will give a reliable status of the interface especially during ON/OFF transitions. This support was added from DPU version 5.0.0. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/di

[PATCH v10 13/15] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled

2022-12-22 Thread Vinod Polimera
There can be a race between timing gen disable and vblank irq. The wait post timing gen disable may return early but intf disable sequence might not be completed. Ensure that, intf status is disabled before we retire the function. Signed-off-by: Vinod Polimera --- .../gpu/drm/msm/disp/dpu1/dpu_e

[PATCH v10 11/15] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver

2022-12-22 Thread Vinod Polimera
Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dis

[PATCH v10 07/15] drm/bridge: use atomic enable/disable callbacks for panel bridge

2022-12-22 Thread Vinod Polimera
Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/panel.c | 20 +++

[PATCH v10 10/15] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources

2022-12-22 Thread Vinod Polimera
According to KMS documentation, The driver must not release any shared resources if active is set to false but enable still true. Fixes: ccc862b957c6 ("drm/msm/dpu: Fix reservation failures in modeset") Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu

[PATCH v10 06/15] drm/msm/dp: disable self_refresh_aware after entering psr

2022-12-22 Thread Vinod Polimera
From: Sankeerth Billakanti Updated frames get queued if self_refresh_aware is set when the sink is in psr. To support bridge enable and avoid queuing of update frames, reset the self_refresh_aware state after entering psr. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera ---

[PATCH v10 08/15] drm/bridge: add psr support for panel bridge callbacks

2022-12-22 Thread Vinod Polimera
This change will handle the psr entry exit cases in the panel bridge atomic callback functions. For example, the panel power should not turn off if the panel is entering psr. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 48 ++

[PATCH v10 09/15] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions

2022-12-22 Thread Vinod Polimera
Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++-

  1   2   >