Re: [PATCH] drm/msm/gpu: Drop qos request if devm_devfreq_add_device() fails

2022-08-01 Thread Dmitry Baryshkov
On 08/07/2022 19:26, Bjorn Andersson wrote: In the event that devm_devfreq_add_device() fails the device's qos freq list is left referencing df->idle_freq and df->boost_freq. Attempting to initialize devfreq again after a probe deferral will then cause invalid memory accesses in dev_pm_qos_add_re

Re: [PATCH v2] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-01 Thread Dmitry Baryshkov
On 01/08/2022 23:13, Kuogee Hsieh wrote: Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement with minimal equipment for embedded application

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-01 Thread Kevin Brace
Hi Thomas, I hope I am comprehending this right. Yes, I am adding 3 new uAPI calls, not 6 of them. Correspondingly, there are 3 new structs added. While I may drop one (unmap uAPI), I personally do not wish to drop the other two at this point. Instead, I may need to add setparam and / or getparam

[PATCH] Prevent CPU deadlock with fbdev based consoles while printing scheduler warnings

2022-08-01 Thread mpenttil
From: Mika Penttilä With some fbdev based consoles, using the deferred_io mechanism and drm_fb_helper, there can be a call chain like: Backtrack: try_to_wake_up <-- rq_lock taken __queue_work queue_work_on soft_cursor hide_cursor vt_console_print console_unlock vprintk_emit printk __warn_prin

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 8:53 PM Fabio Estevam wrote: > > On Mon, Aug 1, 2022 at 10:39 PM Adam Ford wrote: > > > I managed to get my HDMI output working. I had the lanes set to 2 > > instead of 4. Once I switched to 4-lanes, the monitor came up in > > 1080p. I haven't yet been able to get other m

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Fabio Estevam
On Mon, Aug 1, 2022 at 10:39 PM Adam Ford wrote: > I managed to get my HDMI output working. I had the lanes set to 2 > instead of 4. Once I switched to 4-lanes, the monitor came up in > 1080p. I haven't yet been able to get other modes to work. Ok, good. On another thread, you mentioned that y

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 6:12 PM Fabio Estevam wrote: > > Hi Marco, > > On Mon, Aug 1, 2022 at 7:55 PM Marco Felsch wrote: > > > Question is, does your setup work for all modes after applying your > > patches and without using the NXP-downstream porches settings? We also > > Without Frieder's patch

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-01 Thread Kevin Brace
Hi Sam, OpenChrome DDX carries lots of legacy code. https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/tree/src/via_drm.h?h=main&id=dc661c59257e855cd9b29c14b91a8ee2d9b86ccb There is a requirement to use the same via_drm.h with both DDX and DRM. Hence, I need to keep a lot of the legac

[PATCH drm-misc-next v7 5/5] drm/todo: remove task to rename CMA helpers

2022-08-01 Thread Danilo Krummrich
Both, GEM and FB, CMA helpers were renamed to "GEM DMA" and "FB DMA", hence the task can be removed. Acked-by: Sam Ravnborg Acked-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Signed-off-by: Danilo Krummrich --- Documentation/gpu/todo.rst | 13 - 1 file changed, 13 deletions

[PATCH drm-misc-next v7 2/5] drm/fb: rename FB CMA helpers to FB DMA helpers

2022-08-01 Thread Danilo Krummrich
Rename "FB CMA" helpers to "FB DMA" helpers - considering the hierarchy of APIs (mm/cma -> dma -> fb dma) calling them "FB DMA" seems to be more applicable. Besides that, commit e57924d4ae80 ("drm/doc: Task to rename CMA helpers") requests to rename the CMA helpers and implies that people seem to

[PATCH drm-misc-next v7 4/5] drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr}

2022-08-01 Thread Danilo Krummrich
The field paddr of struct drm_gem_dma_object holds a DMA address, which might actually be a physical address. However, depending on the platform, it can also be a bus address or a virtual address managed by an IOMMU. Hence, rename the field to dma_addr, which is more applicable. In order to do th

[PATCH drm-misc-next v7 1/5] drm/fb: remove unused includes of drm_fb_cma_helper.h

2022-08-01 Thread Danilo Krummrich
Quite a lot of drivers include the drm_fb_cma_helper.h header file without actually making use of it's provided API, hence remove those includes. Suggested-by: Sam Ravnborg Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/hdlcd_drv.c | 1 - drivers/gpu/drm/arm/malidp_drv.

[PATCH drm-misc-next v7 0/5] drm: rename CMA helpers to DMA helpers

2022-08-01 Thread Danilo Krummrich
This patch series renames all CMA helpers to DMA helpers - considering the hierarchy of APIs (mm/cma -> dma -> gem/fb dma helpers) calling them DMA helpers seems to be more applicable. Additionally, commit e57924d4ae80 ("drm/doc: Task to rename CMA helpers") requests to rename the CMA helpers and

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Fabio Estevam
Hi Marco, On Mon, Aug 1, 2022 at 7:55 PM Marco Felsch wrote: > Question is, does your setup work for all modes after applying your > patches and without using the NXP-downstream porches settings? We also Without Frieder's patch: "drm/exynos: Fix horizontal timing settings in MHPORCH/MSYNC regis

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 3:07 PM Adam Ford wrote: > > On Mon, Aug 1, 2022 at 2:33 PM Fabio Estevam wrote: > > > > Hi Adam, > > > > On Sat, Jul 30, 2022 at 12:16 PM Adam Ford wrote: > > > > > > Hey all, > > > > > > I am trying to test Jagan's patch series [1] to add support for the > > > samsung ds

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Marco Felsch
Hi Fabio, Adam, +Cc Marek, Robert, Laurentiu On 22-08-01, Fabio Estevam wrote: > Hi Adam, > > On Sat, Jul 30, 2022 at 12:16 PM Adam Ford wrote: > > > > Hey all, > > > > I am trying to test Jagan's patch series [1] to add support for the > > samsung dsim bridge which is used on the imx8mm to out

Re: [PATCH v2] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-01 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-01 13:13:50) > Data Symbols scrambled is required for tps4 at link training 2. > Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to > work. > RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter > measurement with minimal equipment for embedded a

Re: [PATCH v3 09/15] drm/gem: Add LRU/shrinker helper

2022-08-01 Thread Dmitry Osipenko
On 8/1/22 23:42, Rob Clark wrote: > On Mon, Aug 1, 2022 at 1:26 PM Dmitry Osipenko > wrote: >> >> On 8/1/22 23:13, Dmitry Osipenko wrote: >>> On 8/1/22 23:11, Dmitry Osipenko wrote: On 8/1/22 23:00, Rob Clark wrote: > On Mon, Aug 1, 2022 at 12:41 PM Dmitry Osipenko > wrote: >> >>

Re: [PATCH 1/1] drm/i915/dg2: Update DG2 to GuC v70.4.1

2022-08-01 Thread Ceraolo Spurio, Daniele
On 7/28/2022 4:07 PM, john.c.harri...@intel.com wrote: From: John Harrison New release of GuC with a bunch of fixes specific to DG2. Some of these require follow up i915 changes to enable. This needs a note to explain that we don't need to maintain 70.1 compatibility because DG2 is still

Re: [PATCH v3 09/15] drm/gem: Add LRU/shrinker helper

2022-08-01 Thread Rob Clark
On Mon, Aug 1, 2022 at 1:26 PM Dmitry Osipenko wrote: > > On 8/1/22 23:13, Dmitry Osipenko wrote: > > On 8/1/22 23:11, Dmitry Osipenko wrote: > >> On 8/1/22 23:00, Rob Clark wrote: > >>> On Mon, Aug 1, 2022 at 12:41 PM Dmitry Osipenko > >>> wrote: > > On 7/26/22 20:50, Rob Clark wrote:

Re: [RFC PATCH] drm: hide unregistered connectors from GETCONNECTOR IOCTL

2022-08-01 Thread Lyude Paul
Yikes! Surprised this wasn't noticed until now. This lgtm: Reviewed-by: Lyude Paul On Mon, 2022-08-01 at 13:38 +, Simon Ser wrote: > When registering a connector, the kernel sends a hotplug uevent in > drm_connector_register(). When unregistering a connector, drivers > are expected to send a

Re: [PATCH v3 09/15] drm/gem: Add LRU/shrinker helper

2022-08-01 Thread Dmitry Osipenko
On 8/1/22 23:13, Dmitry Osipenko wrote: > On 8/1/22 23:11, Dmitry Osipenko wrote: >> On 8/1/22 23:00, Rob Clark wrote: >>> On Mon, Aug 1, 2022 at 12:41 PM Dmitry Osipenko >>> wrote: On 7/26/22 20:50, Rob Clark wrote: > +/** > + * drm_gem_lru_remove - remove object from whatever L

Re: [Freedreno] [PATCH v2] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-01 Thread Abhinav Kumar
On 8/1/2022 1:13 PM, Kuogee Hsieh wrote: Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement with minimal equipment for embedded applicat

[PATCH v2] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-01 Thread Kuogee Hsieh
Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement with minimal equipment for embedded applications purpose and is not required to be set dur

Re: [PATCH v3 09/15] drm/gem: Add LRU/shrinker helper

2022-08-01 Thread Dmitry Osipenko
On 8/1/22 23:11, Dmitry Osipenko wrote: > On 8/1/22 23:00, Rob Clark wrote: >> On Mon, Aug 1, 2022 at 12:41 PM Dmitry Osipenko >> wrote: >>> >>> On 7/26/22 20:50, Rob Clark wrote: +/** + * drm_gem_lru_remove - remove object from whatever LRU it is in + * + * If the object is cu

Re: [PATCH v3 09/15] drm/gem: Add LRU/shrinker helper

2022-08-01 Thread Dmitry Osipenko
On 8/1/22 23:00, Rob Clark wrote: > On Mon, Aug 1, 2022 at 12:41 PM Dmitry Osipenko > wrote: >> >> On 7/26/22 20:50, Rob Clark wrote: >>> +/** >>> + * drm_gem_lru_remove - remove object from whatever LRU it is in >>> + * >>> + * If the object is currently in any LRU, remove it. >>> + * >>> + * @ob

Re: [PATCH] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-01 Thread Kuogee Hsieh
On 8/1/2022 12:51 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-01 12:42:50) Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 2:33 PM Fabio Estevam wrote: > > Hi Adam, > > On Sat, Jul 30, 2022 at 12:16 PM Adam Ford wrote: > > > > Hey all, > > > > I am trying to test Jagan's patch series [1] to add support for the > > samsung dsim bridge which is used on the imx8mm to output DSI video. > > The DSIM

Re: [PATCH v3 09/15] drm/gem: Add LRU/shrinker helper

2022-08-01 Thread Rob Clark
On Mon, Aug 1, 2022 at 12:41 PM Dmitry Osipenko wrote: > > On 7/26/22 20:50, Rob Clark wrote: > > +/** > > + * drm_gem_lru_remove - remove object from whatever LRU it is in > > + * > > + * If the object is currently in any LRU, remove it. > > + * > > + * @obj: The GEM object to remove from current

Re: [PATCH] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-01 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-01 12:42:50) > Data Symbols scrambled is required for tps4 at link training 2. > Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to > work. > RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter > measurement with minimal equipment for embedded a

[PATCH] drm/msm/dp: delete DP_RECOVERED_CLOCK_OUT_EN to fix tps4

2022-08-01 Thread Kuogee Hsieh
Data Symbols scrambled is required for tps4 at link training 2. Therefore SCRAMBLING_DISABLE bit should not be set for tps4 to work. RECOVERED_CLOCK_OUT_EN is for enable simple EYE test for jitter measurement with minimal equipment for embedded applications purpose and is not required to be set dur

Re: [PATCH v3 09/15] drm/gem: Add LRU/shrinker helper

2022-08-01 Thread Dmitry Osipenko
On 7/26/22 20:50, Rob Clark wrote: > +/** > + * drm_gem_lru_remove - remove object from whatever LRU it is in > + * > + * If the object is currently in any LRU, remove it. > + * > + * @obj: The GEM object to remove from current LRU > + */ > +void > +drm_gem_lru_remove(struct drm_gem_object *obj) >

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Fabio Estevam
Hi Adam, On Sat, Jul 30, 2022 at 12:16 PM Adam Ford wrote: > > Hey all, > > I am trying to test Jagan's patch series [1] to add support for the > samsung dsim bridge which is used on the imx8mm to output DSI video. > The DSIM gets the video from the mxsfb, and in my case, the DSI is > sent to the

[PATCH AUTOSEL 5.15 1/8] drm/amdgpu: Remove one duplicated ef removal

2022-08-01 Thread Sasha Levin
From: xinhui pan [ Upstream commit e1aadbab445b06e072013a1365fd0cf2aa25e843 ] That has been done in BO release notify. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2074 Signed-off-by: xinhui pan Acked-by: Christian König Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed

[PATCH AUTOSEL 5.18 02/10] drm/amdgpu: Remove one duplicated ef removal

2022-08-01 Thread Sasha Levin
From: xinhui pan [ Upstream commit e1aadbab445b06e072013a1365fd0cf2aa25e843 ] That has been done in BO release notify. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2074 Signed-off-by: xinhui pan Acked-by: Christian König Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher Signed

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-01 Thread Thomas Zimmermann
Hi Kevin Am 31.07.22 um 00:48 schrieb Kevin Brace: Hi Thomas, I cannot drop the older DRI1 based uAPI calls. This is because include/uapi/drm/via_drm.h needs to retain backward compatibility with the existing OpenChrome DDX's XvMC library (it gets compiled when OpenChrome DDX is built) and li

Re: [PATCH 0/1] Move DG2 to GuC v70.4.1

2022-08-01 Thread John Harrison
On 8/1/2022 10:28, Niranjana Vishwanathapura wrote: On Thu, Jul 28, 2022 at 04:07:21PM -0700, john.c.harri...@intel.com wrote: From: John Harrison The latest GuC release contains a bunch of fixes for DG2. Start using it. Note that some of these fixes require i915 side support which will follo

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add and use hs_rate and lp_rate

2022-08-01 Thread Marek Vasut
On 8/1/22 18:38, Adam Ford wrote: On Mon, Aug 1, 2022 at 11:05 AM Marek Vasut wrote: On 8/1/22 16:55, Dave Stevenson wrote: Hi Marek Hi, On Mon, 1 Aug 2022 at 14:12, Marek Vasut wrote: Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and adjust DSI input frequency

Re: [PATCH] drm/msm/gpu: Drop qos request if devm_devfreq_add_device() fails

2022-08-01 Thread Rob Clark
On Fri, Jul 8, 2022 at 9:24 AM Bjorn Andersson wrote: > > In the event that devm_devfreq_add_device() fails the device's qos freq > list is left referencing df->idle_freq and df->boost_freq. Attempting to > initialize devfreq again after a probe deferral will then cause invalid > memory accesses i

Re: [PATCH 0/1] Move DG2 to GuC v70.4.1

2022-08-01 Thread Niranjana Vishwanathapura
On Thu, Jul 28, 2022 at 04:07:21PM -0700, john.c.harri...@intel.com wrote: From: John Harrison The latest GuC release contains a bunch of fixes for DG2. Start using it. Note that some of these fixes require i915 side support which will follow in separate patches. So, this patch series has a

Re: [PATCH] drm/i915/userptr: remove redundation assignment to variable ret

2022-08-01 Thread Niranjana Vishwanathapura
On Sat, Jul 30, 2022 at 01:23:42PM +0100, Colin Ian King wrote: Variable ret is assigned a value that is never read; it is either being re-assigned during the following while-loop or after the loop. The assignmnt is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/dr

Re: [PATCH] [Draft]: media: videobuf2-dma-heap: add a vendor defined memory runtine

2022-08-01 Thread ayaka
Sent from my iPad > On Aug 1, 2022, at 5:46 PM, Tomasz Figa wrote: > > CAUTION: Email originated externally, do not click links or open attachments > unless you recognize the sender and know the content is safe. > > >> On Mon, Aug 1, 2022 at 3:44 PM Hsia-Jun Li wrote: >> >> >> >>> On

Re: [PATCH] [Draft]: media: videobuf2-dma-heap: add a vendor defined memory runtine

2022-08-01 Thread ayaka
 Sent from my iPad > On Aug 1, 2022, at 5:46 PM, Tomasz Figa wrote: > > CAUTION: Email originated externally, do not click links or open attachments > unless you recognize the sender and know the content is safe. > > >> On Mon, Aug 1, 2022 at 3:44 PM Hsia-Jun Li wrote: >>> On 8/1/22 14:19

Re: [PATCHv2 -next] drm/amdgpu: double free error and freeing uninitialized null pointer

2022-08-01 Thread André Almeida
Às 00:46 de 30/07/22, Sebin Sebastian escreveu: > Fix a double free and an uninitialized pointer read error. Both tmp and > new are pointing at same address and both are freed which leads to > double free. Adding a check to verify if new and tmp are free in the > error_free label fixes the double f

[PATCH v2 3/3] drm/msm/prime: Add mmap_info support

2022-08-01 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 1 + drivers/gpu/drm/msm/msm_drv.h | 1 + drivers/gpu/drm/msm/msm_gem_prime.c | 11 +++ 3 files changed, 13 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.

[PATCH v2 2/3] drm/prime: Wire up mmap_info support

2022-08-01 Thread Rob Clark
From: Rob Clark Just plumbing the thing thru an extra layer. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_prime.c | 12 include/drm/drm_drv.h | 7 +++ 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index e3f

[PATCH v2 1/3] dma-buf: Add ioctl to query mmap info

2022-08-01 Thread Rob Clark
From: Rob Clark This is a fairly narrowly focused interface, providing a way for a VMM in userspace to tell the guest kernel what pgprot settings to use when mapping a buffer to guest userspace. For buffers that get mapped into guest userspace, virglrenderer returns a dma-buf fd to the VMM (cros

[PATCH v2 0/3] dma-buf: map-info support

2022-08-01 Thread Rob Clark
From: Rob Clark See 1/3 for motivation. Rob Clark (3): dma-buf: Add ioctl to query mmap info drm/prime: Wire up mmap_info support drm/msm/prime: Add mmap_info support drivers/dma-buf/dma-buf.c | 26 ++ drivers/gpu/drm/drm_prime.c | 12 +++

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add and use hs_rate and lp_rate

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 11:05 AM Marek Vasut wrote: > > On 8/1/22 16:55, Dave Stevenson wrote: > > Hi Marek > > Hi, > > > On Mon, 1 Aug 2022 at 14:12, Marek Vasut wrote: > >> > >> Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and > >> adjust DSI input frequency calculations

Re: [PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap

2022-08-01 Thread Rob Herring
On Mon, Aug 01, 2022 at 03:19:00PM +0200, Marek Vasut wrote: > The ICN6211 is capable of swapping the output DPI RGB/BGR color channels, > document a DT property to select this swap in DT. This can be useful on > hardware where such swap happens. We should ensure this series[1] works for you inste

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add and use hs_rate and lp_rate

2022-08-01 Thread Marek Vasut
On 8/1/22 16:55, Dave Stevenson wrote: Hi Marek Hi, On Mon, 1 Aug 2022 at 14:12, Marek Vasut wrote: Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and adjust DSI input frequency calculations such that they expect the DSI host to configure HS clock according to hs_rat

Re: [RFC PATCH v3 04/19] KVM: x86: mmu: allow to enable write tracking externally

2022-08-01 Thread Maxim Levitsky
On Thu, 2022-07-28 at 10:46 +0300, Maxim Levitsky wrote: > On Mon, 2022-07-25 at 16:08 +, Sean Christopherson wrote: > > On Wed, Jul 20, 2022, Maxim Levitsky wrote: > > > On Sun, 2022-05-22 at 13:22 +0300, Maxim Levitsky wrote: > > > > On Thu, 2022-05-19 at 16:37 +, Sean Christopherson wrot

Re: [Freedreno] [PATCH 2/5] clk: qcom: Allow custom reset ops

2022-08-01 Thread Akhil P Oommen
On 7/30/2022 6:40 PM, kernel test robot wrote: Hi Akhil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on robh/for-next drm-misc/drm-misc-next drm-tip/drm-tip linus/master v5.19-rc8 next-20220728] [If your patch is app

Re: [PATCH v3 4/8] drm/msm: Fix cx collapse issue during recovery

2022-08-01 Thread Akhil P Oommen
On 7/31/2022 9:52 PM, Rob Clark wrote: On Sat, Jul 30, 2022 at 2:41 AM Akhil P Oommen wrote: There are some hardware logic under CX domain. For a successful recovery, we should ensure cx headswitch collapses to ensure all the stale states are cleard out. This is especially true to for a6xx fami

Re: [PATCH] drm/bridge: ti-sn65dsi83: Add and use hs_rate and lp_rate

2022-08-01 Thread Dave Stevenson
Hi Marek On Mon, 1 Aug 2022 at 14:12, Marek Vasut wrote: > > Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and > adjust DSI input frequency calculations such that they expect the DSI host > to configure HS clock according to hs_rate. I think this falls into another of the

Re: [PATCH v3 26/32] drm/via: Add via_drm.h

2022-08-01 Thread Sam Ravnborg
Hi Kevin, > I cannot drop the older DRI1 based uAPI calls. > This is because include/uapi/drm/via_drm.h needs to retain backward > compatibility with the existing OpenChrome DDX's XvMC library > (it gets compiled when OpenChrome DDX is built) and likely with the > existing DDX Xv code as well. > I

Re: [PATCH v3 2/8] drm/msm: Take single rpm refcount on behalf of all submits

2022-08-01 Thread Akhil P Oommen
On 8/1/2022 3:45 AM, Rob Clark wrote: On Sun, Jul 31, 2022 at 9:33 AM Akhil P Oommen wrote: On 7/31/2022 9:26 PM, Rob Clark wrote: On Sat, Jul 30, 2022 at 2:41 AM Akhil P Oommen wrote: Instead of separate refcount for each submit, take single rpm refcount on behalf of all the submits. This m

Re: [PATCH v3 1/8] drm/msm: Remove unnecessary pm_runtime_get/put

2022-08-01 Thread Akhil P Oommen
On 7/31/2022 9:25 PM, Rob Clark wrote: On Sat, Jul 30, 2022 at 2:41 AM Akhil P Oommen wrote: We already enable gpu power from msm_gpu_submit(), so avoid a duplicate pm_runtime_get/put from msm_job_run(). Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/msm_ringb

Re: [PATCH 1/3] drm/amd/display: Fix merge conflict resolution in amdgpu_dm_plane.c

2022-08-01 Thread Simon Ser
Acked-by: Simon Ser CC amd-gfx On Monday, August 1st, 2022 at 15:52, Imre Deak wrote: > The API change introduced in > > commit 30c637151cfa ("drm/plane-helper: Export individual helpers") > > was missed in the conflict resolution of > > commit d93a13bd75b9 ("Merge remote-tracking branch 'drm-

[PATCH v3 4/5] drm/simpledrm: Compute framebuffer stride if not set

2022-08-01 Thread Thomas Zimmermann
Compute the framebuffer's scanline stride length if not given by the simplefb data. v3: * get pixel size from drm_format_info_bpp() (Geert, Javier) Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/simpledrm.c | 3 +++ 1 file changed, 3 insert

[PATCH v3 3/5] drm/simpledrm: Remove pdev field from device structure

2022-08-01 Thread Thomas Zimmermann
Replace the remaining uses of the field pdev by upcasts from the Linux device and remove the field. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/simpledrm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 3/3] drm/amd/display: Fix static declaration follows non-static declaration compiler warn

2022-08-01 Thread Imre Deak
Fix the drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:951:13: error: static declaration of ‘get_min_max_dc_plane_scaling’ follows non-static declaration 951 | static void get_min_max_dc_plane_scaling(struct drm_device *dev, | ^~~~ I

[PATCH 1/3] drm/amd/display: Fix merge conflict resolution in amdgpu_dm_plane.c

2022-08-01 Thread Imre Deak
The API change introduced in commit 30c637151cfa ("drm/plane-helper: Export individual helpers") was missed in the conflict resolution of commit d93a13bd75b9 ("Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip") fix this up. Fixes: d93a13bd75b9 ("Merge remote-tracking branch

[PATCH v3 0/5] drm/simpledrm: Various improvements

2022-08-01 Thread Thomas Zimmermann
Patchset contains various improvements for simpledrm that were implemented in preparation of adding another firmware graphics driver. [1] Javier and Geert already reviewed the changes and it was agreed that they could be merged independently. We start with v3, as that's were we branch of the origi

[PATCH 2/3] drm/amd/display: Fix 'no previous prototype' compiler warns in amdgpu_dm_plane.c

2022-08-01 Thread Imre Deak
Fix compiler warnings like the following triggered by '-Wmissing-prototypes': CC [M] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.o drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:83:31: warning: no previous prototype for ‘amd_get_format_info’ [-Wmissi

[PATCH v3 1/5] drm/simpledrm: Remove mem field from device structure

2022-08-01 Thread Thomas Zimmermann
Remove the unused mem field from struct simpledrm_device. Signed-off-by: Thomas Zimmermann Acked-by: Javier Martinez Canillas --- drivers/gpu/drm/tiny/simpledrm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c index 54223

[PATCH v3 2/5] drm/simpledrm: Inline device-init helpers

2022-08-01 Thread Thomas Zimmermann
Inline the helpers for initializing the hardware FB, the memory management and the modesetting into the device-creation function. No functional changes. In the original code, init helpers depended on values from other init helpers. Inlining the functions ensures that steps are taken in the correct

[PATCH v3 5/5] drm/simpledrm: Convert to atomic helpers

2022-08-01 Thread Thomas Zimmermann
Replace the simple-KMS helpers with the regular atomic helpers. The regular helpers are better architectured and therefore allow for easier code sharing among drivers. No functional changes. v3: * remove empty CRTC helpers atomic_{enable, disable} (Javier) * unconditionally run drm

[RFC PATCH] drm: hide unregistered connectors from GETCONNECTOR IOCTL

2022-08-01 Thread Simon Ser
When registering a connector, the kernel sends a hotplug uevent in drm_connector_register(). When unregistering a connector, drivers are expected to send a uevent as well. However, user-space has no way to figure out that the connector isn't registered anymore: it'll still be reported in GETCONNECT

[PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for RGB/BGR swap

2022-08-01 Thread Marek Vasut
The ICN6211 is capable of swapping the output DPI RGB/BGR color channels, document a DT property to select this swap in DT. This can be useful on hardware where such swap happens. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Laurent Pinchart Cc: Linus Walleij Cc: Rob Herring Cc: Robert Foss

[PATCH 2/2] drm: bridge: icn6211: Add support for RGB/BGR swap

2022-08-01 Thread Marek Vasut
The ICN6211 is capable of swapping the output DPI RGB/BGR color channels, implement support for this and add DT property "blue-and-red-swap" to select the RGB/BGR channel order. Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Laurent Pinchart Cc: Linus Walleij Cc: Robert Foss Cc: Sam Ravnborg

[PATCH 1/2] dt-bindings: display: bridge: icn6211: Add support for external REFCLK

2022-08-01 Thread Marek Vasut
The ICN6211 is capable of deriving its internal PLL clock from either MIPI DSI HS clock, external REFCLK clock, or even internal oscillator. Currently supported is only the first option. Document support for external REFCLK clock input in addition to that. Signed-off-by: Marek Vasut Cc: Jagan Tek

[PATCH 2/2] drm: bridge: icn6211: Add support for external REFCLK

2022-08-01 Thread Marek Vasut
The ICN6211 is capable of deriving its internal PLL clock from either MIPI DSI HS clock, external REFCLK clock, or even internal oscillator. Currently supported is only the first option. Add support for external REFCLK clock input in addition to that. There is little difference between these optio

[PATCH] drm: bridge: icn6211: Add and use hs_rate and lp_rate

2022-08-01 Thread Marek Vasut
Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and adjust DSI input frequency calculations such that they expect the DSI host to configure HS clock according to hs_rate. This is an optimization for the DSI burst mode case. In case the DSI device supports DSI burst mode, it i

[PATCH] drm/bridge: ti-sn65dsi83: Add and use hs_rate and lp_rate

2022-08-01 Thread Marek Vasut
Fill in hs_rate and lp_rate to struct mipi_dsi_device for this bridge and adjust DSI input frequency calculations such that they expect the DSI host to configure HS clock according to hs_rate. This is an optimization for the DSI burst mode case. In case the DSI device supports DSI burst mode, it i

[PATCH] drm/bridge: lvds-codec: Fix error checking of drm_of_lvds_get_data_mapping()

2022-08-01 Thread Marek Vasut
The drm_of_lvds_get_data_mapping() returns either negative value on error or MEDIA_BUS_FMT_* otherwise. The check for 'ret' would also catch the positive case of MEDIA_BUS_FMT_* and lead to probe failure every time 'data-mapping' DT property is specified. Fixes: 7c4dd0a266527 ("drm: of: Add drm_of

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 5:54 AM Adam Ford wrote: > > On Mon, Aug 1, 2022 at 1:20 AM Marco Felsch wrote: > > > > Hi Adam, > > > > On 22-07-30, Adam Ford wrote: > > > Hey all, > > > > > > I am trying to test Jagan's patch series [1] to add support for the > > > samsung dsim bridge which is used on t

Re: imx8mm lcdif->dsi->adv7535 no video, no errors

2022-08-01 Thread Adam Ford
On Mon, Aug 1, 2022 at 1:20 AM Marco Felsch wrote: > > Hi Adam, > > On 22-07-30, Adam Ford wrote: > > Hey all, > > > > I am trying to test Jagan's patch series [1] to add support for the > > samsung dsim bridge which is used on the imx8mm to output DSI video. > > The DSIM gets the video from the m

Re: [PATCH v3 30/32] drm/via: Add Kconfig

2022-08-01 Thread Thomas Zimmermann
Hi Am 31.07.22 um 03:49 schrieb Kevin Brace: Hi Thomas, In general, I am okay with the idea of keeping DRI1 based VIA DRM for now. Personally, I am not that interested in keeping it, but I am not against keeping it, either. Yeah, I see your point. No one really wants to keep the DRI1 code,

Re: [PATCH] drm/kmb: fix dereference before NULL check in kmb_plane_atomic_update()

2022-08-01 Thread Thomas Zimmermann
Hi Am 29.07.22 um 18:40 schrieb Chrisanthus, Anitha: Agree with Thomas, drm_atomic_commit() will not call kmb_atomic_update() with a NULL plane. This is not an actual bug. Indeed, it's the atomic_update function. I didn't notice at first. Thanks, Anitha -Original Message- From: T

Re: [PATCH] drm/komeda: Fix handling of atomic commits in the atomic_commit_tail hook

2022-08-01 Thread Carsten Haitzler
Looks good to me - as per log. On 7/22/22 13:21, Liviu Dudau wrote: Komeda driver relies on the generic DRM atomic helper functions to handle commits. It only implements an atomic_commit_tail hook for the mode_config_helper_funcs and even that one is pretty close to the generic implementation wi