Re: [PATCH] drm/v3d: fix sched job resources cleanup when a job is aborted

2021-09-16 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga With that said, I don't like how we are doing error handling here, I think we want to simplify this and try to make it so we centralize error handling in one place instead of having multiple error exits paths, each one trying to do the right thing at that point. Th

Re: [PATCH 01/14] dma-buf: add dma_resv_for_each_fence_unlocked

2021-09-16 Thread Christian König
Am 16.09.21 um 16:09 schrieb Daniel Vetter: On Thu, Sep 16, 2021 at 02:49:26PM +0200, Christian König wrote: Am 16.09.21 um 14:14 schrieb Daniel Vetter: On Thu, Sep 16, 2021 at 10:50 AM Christian König wrote: Am 14.09.21 um 19:04 schrieb Daniel Vetter: On Fri, Sep 10, 2021 at 10:26:42AM +02

Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-16 Thread Stephen Boyd
Quoting Doug Anderson (2021-09-16 16:21:12) > Hi, > > On Thu, Sep 16, 2021 at 3:17 PM Stephen Boyd wrote: > > > > TL;DR: Please try to reduce these error messages in drivers and > > consolidate them into subsystems so that drivers stay simple. > > > > Quoting Doug Anderson (2021-09-15 09:41:39) >

Re: [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-09-16 Thread Stephen Boyd
Quoting Sean Paul (2021-09-15 13:38:32) > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index c8921e2d6480..3ae6fc7a2c01 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3088,7 +3088,9 @@ mdss_dp:

Re: [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-09-16 Thread kernel test robot
Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip next-20210916] [cannot apply to robh/for-next linus/master v5.15-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And

[PATCH 4/4] fbdev: omapfb: panel-tpo-td043mtea1: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- .../video/fbdev/omap

[PATCH 3/4] fbdev: omapfb: panel-sharp-ls037v7dw01: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- .../fbdev/omap2/omap

[PATCH 1/4] fbdev: omapfb: panel-lgphilips-lb035q02: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- .../fbdev/omap2/omap

[PATCH 2/4] fbdev: omapfb: lcd_ams_delta: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/fbdev/

[PATCH 6/6] fbdev: mmp: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/fbdev/

[PATCH 5/6] fbdev: s3c-fb: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/fbdev/

[PATCH 4/6] fbdev: ssd1307fb: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/fbdev/

[PATCH 3/6] fbdev: pxa3xx-gcu: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/fbdev/

[PATCH 2/6] fbdev: pxa168fb: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/fbdev/

[PATCH 1/6] fbdev: da8xx-fb: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/fbdev/

Re: [PATCH v2 08/13] drm/msm/dpu_kms: Re-order dpu includes

2021-09-16 Thread Stephen Boyd
Quoting Sean Paul (2021-09-15 13:38:27) > From: Sean Paul > > Make includes alphabetical in dpu_kms.c > > Signed-off-by: Sean Paul > Link: > https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-9-s...@poorly.run > #v1 > > Changes in v2: > -None > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 09/13] drm/msm/dpu: Remove useless checks in dpu_encoder

2021-09-16 Thread Stephen Boyd
Quoting Sean Paul (2021-09-15 13:38:28) > From: Sean Paul > > A couple more useless checks to remove in dpu_encoder. > > Signed-off-by: Sean Paul > Link: > https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-10-s...@poorly.run > #v1 > > Changes in v2: > -None > --- Reviewed-by:

Re: [PATCH v2 10/13] drm/msm/dpu: Remove encoder->enable() hack

2021-09-16 Thread Stephen Boyd
Quoting Sean Paul (2021-09-15 13:38:29) > From: Sean Paul > > encoder->commit() was being misused because there were some global > resources which needed to be tweaked in encoder->enable() which were not > accessible in dpu_encoder.c. That is no longer true and the redirect > serves no purpose any

Re: [PATCH v2 11/13] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules

2021-09-16 Thread Stephen Boyd
Quoting Sean Paul (2021-09-15 13:38:30) > From: Sean Paul > > Audio is initialized last, it should be de-initialized first to match > the order in dp_init_sub_modules(). I don't really understand why the driver is written with all this "get" stuff but sure. > > Signed-off-by: Sean Paul > Link:

Re: [PATCH] vgaarb: Use ACPI HID name to find integrated GPU

2021-09-16 Thread Kai-Heng Feng
On Fri, Sep 17, 2021 at 12:38 AM Bjorn Helgaas wrote: > > [+cc Huacai, linux-pci] > > On Wed, May 19, 2021 at 09:57:23PM +0800, Kai-Heng Feng wrote: > > Commit 3d42f1ddc47a ("vgaarb: Keep adding VGA device in queue") assumes > > the first device is an integrated GPU. However, on AMD platforms an >

[PATCH 2/2] backlight: l4f00242t03: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/backli

[PATCH 1/2] backlight: bd6107: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/video/backli

[PATCH AUTOSEL 5.14 06/21] drm/amdgpu: fix fdinfo race with process exit

2021-09-16 Thread Sasha Levin
From: Philip Yang [ Upstream commit d7eff46c214c036606dd3cd305bd5a128aecfe8c ] Get process vm root BO ref in case process is exiting and root BO is freed, to avoid NULL pointer dereference backtrace: BUG: unable to handle kernel NULL pointer dereference at Call Trace: amdgpu_sh

[PATCH AUTOSEL 5.14 05/21] drm/amd/display: Fix memory leak reported by coverity

2021-09-16 Thread Sasha Levin
From: Anson Jacob [ Upstream commit 03388a347fe7cf7c3bdf68b0823ba316d177d470 ] Free memory allocated if any of the previous allocations failed. >>> CID 1487129: Resource leaks (RESOURCE_LEAK) >>> Variable "vpg" going out of scope leaks the storage it points to. Addresses-Coverity-ID:

[PATCH AUTOSEL 5.14 04/21] drm/amdgpu: Fixes to returning VBIOS RAS EEPROM address

2021-09-16 Thread Sasha Levin
From: Luben Tuikov [ Upstream commit a6a355a22f7a0efa6a11bc90b5161f394d51fe95 ] 1) Generalize the function--if the user didn't set i2c_address, still return true/false to indicate whether VBIOS contains the RAS EEPROM address. This function shouldn't evaluate whether the user set th

[PATCH v2] drm/tegra: sor: Make use of the helper function dev_err_probe()

2021-09-16 Thread Cai Huoqing
When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. And using dev_err_probe() can reduce code size, the error value gets printed. Reported-by: kernel test robot Signed-off-by: Cai Hu

Re: [PATCH v2 03/23] dt-bindings: arm: mediatek: mmsys: update mediatek,mmsys.yaml reference

2021-09-16 Thread Rob Herring
On Thu, 16 Sep 2021 11:55:02 +0200, Mauro Carvalho Chehab wrote: > Changeset cba3c40d1f97 ("dt-bindings: arm: mediatek: mmsys: convert to YAML > format") > renamed: Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > to: Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys

[PATCH v2 12/12] drm/virtio: implement context init: advertise feature to userspace

2021-09-16 Thread Gurchetan Singh
This advertises the context init feature to userspace, along with a mask of supported capabilities. Signed-off-by: Gurchetan Singh Acked-by: Lingfeng Yang --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c

[PATCH v2 11/12] drm/virtio: implement context init: add virtio_gpu_fence_event

2021-09-16 Thread Gurchetan Singh
Similar to DRM_VMW_EVENT_FENCE_SIGNALED. Sends a pollable event to the DRM file descriptor when a fence on a specific ring is signaled. One difference is the event is not exposed via the UAPI -- this is because host responses are on a shared memory buffer of type BLOB_MEM_GUEST [this is the commo

[PATCH v2 09/12] drm/virtio: implement context init: allocate an array of fence contexts

2021-09-16 Thread Gurchetan Singh
We don't want fences from different 3D contexts (virgl, gfxstream, venus) to be on the same timeline. With explicit context creation, we can specify the number of ring each context wants. Execbuffer can specify which ring to use. Note: virgl + Xserver + virtgpu KMS may need implicit sync support

[PATCH v2 08/12] drm/virtio: implement context init: stop using drv->context when creating fence

2021-09-16 Thread Gurchetan Singh
The plumbing is all here to do this. Since we always use the default fence context when allocating a fence, this makes no functional difference. We can't process just the largest fence id anymore, since it's it's associated with different timelines. It's fine for fence_id 260 to signal before 25

[PATCH v2 10/12] drm/virtio: implement context init: handle VIRTGPU_CONTEXT_PARAM_POLL_RINGS_MASK

2021-09-16 Thread Gurchetan Singh
For the Sommelier guest Wayland proxy, it's desirable for the DRM fd to be pollable in response to an host compositor event. This can also be used by the 3D driver to poll events on a CPU timeline. This enables the DRM fd associated with a particular 3D context to be polled independent of KMS even

[PATCH v2 05/12] drm/virtio: implement context init: support init ioctl

2021-09-16 Thread Gurchetan Singh
From: Anthoine Bourgeois This implements the context initialization ioctl. A list of params is passed in by userspace, and kernel driver validates them. The only currently supported param is VIRTGPU_CONTEXT_PARAM_CAPSET_ID. If the context has already been initialized, -EEXIST is returned. This

[PATCH v2 06/12] drm/virtio: implement context init: track {ring_idx, emit_fence_info} in virtio_gpu_fence

2021-09-16 Thread Gurchetan Singh
Each fence should be associated with a [fence ID, fence_context, seqno]. The seqno number is just the fence id. To get the fence context, we add the ring_idx to the 3D context's base_fence_ctx. The ring_idx is between 0 and 31, inclusive. Each 3D context will have it's own base_fence_ctx. The r

[PATCH v2 07/12] drm/virtio: implement context init: plumb {base_fence_ctx, ring_idx} to virtio_gpu_fence_alloc

2021-09-16 Thread Gurchetan Singh
These were defined in the previous commit. We'll need these parameters when allocating a dma_fence. The use case for this is multiple synchronizations timelines. The maximum number of timelines per 3D instance will be 32. Usually, only 2 are needed -- one for CPU commands, and another for GPU com

[PATCH v2 04/12] drm/virtio: implement context init: probe for feature

2021-09-16 Thread Gurchetan Singh
From: Anthoine Bourgeois Let's probe for VIRTIO_GPU_F_CONTEXT_INIT. Create a new DRM_INFO(..) line since the current one is getting too long. Signed-off-by: Anthoine Bourgeois Acked-by: Lingfeng Yang --- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.c

[PATCH v2 01/12] virtio-gpu api: multiple context types with explicit initialization

2021-09-16 Thread Gurchetan Singh
This feature allows for each virtio-gpu 3D context to be created with a "context_init" variable. This variable can specify: - the type of protocol used by the context via the capset id. This is useful for differentiating virgl, gfxstream, and venus protocols by host userspace. - other th

[PATCH v2 03/12] drm/virtio: implement context init: track valid capabilities in a mask

2021-09-16 Thread Gurchetan Singh
The valid capability IDs are between 1 to 63, and defined in the virtio gpu spec. This is used for error checking the subsequent patches. We're currently only using 2 capability IDs, so this should be plenty for the immediate future. Signed-off-by: Gurchetan Singh Acked-by: Lingfeng Yang ---

[PATCH v2 02/12] drm/virtgpu api: create context init feature

2021-09-16 Thread Gurchetan Singh
This change allows creating contexts of depending on set of context parameters. The meaning of each of the parameters is listed below: 1) VIRTGPU_CONTEXT_PARAM_CAPSET_ID This determines the type of a context based on the capability set ID. For example, the current capsets: VIRTIO_GPU_CAPSET_VI

[PATCH v2 00/12] Context types

2021-09-16 Thread Gurchetan Singh
Version 2 of context types: https://lists.oasis-open.org/archives/virtio-dev/202108/msg00141.html Changes since RFC: * le32 info --> {u8 ring_idx + u8 padding[3]). * Max rings is now 64. Changes since v1: * Document plan regarding context types + display combinations that need impl

Re: [virtio-dev] [PATCH v1 09/12] drm/virtio: implement context init: allocate an array of fence contexts

2021-09-16 Thread Gurchetan Singh
On Wed, Sep 15, 2021 at 5:11 PM Chia-I Wu wrote: > i > > On Tue, Sep 14, 2021 at 6:26 PM Gurchetan Singh > wrote: > > > > > > > > On Tue, Sep 14, 2021 at 10:53 AM Chia-I Wu wrote: > >> > >> ,On Mon, Sep 13, 2021 at 6:57 PM Gurchetan Singh > >> wrote: > >> > > >> > > >> > > >> > > >> > On Mon,

[PATCH] drm/msm: Avoid potential overflow in timeout_to_jiffies()

2021-09-16 Thread Marek Vasut
The return type of ktime_divns() is s64. The timeout_to_jiffies() currently assigns the result of this ktime_divns() to unsigned long, which on 32 bit systems may overflow. Furthermore, the result of this function is sometimes also passed to functions which expect signed long, dma_fence_wait_timeou

linux-next: build failure after merge of the amdgpu tree

2021-09-16 Thread Stephen Rothwell
Hi all, After merging the amdgpu tree, today's linux-next build (arm multi_v7_defconfig) failed like this: In file included from include/drm/ttm/ttm_bo_driver.h:40, from include/drm/drm_gem_ttm_helper.h:11, from drivers/gpu/drm/drm_gem_ttm_helper.c:5: include/drm

Re: [PATCH v6 1/3] dt-bindings: Add YAML bindings for NVDEC

2021-09-16 Thread Rob Herring
On Thu, 16 Sep 2021 17:55:15 +0300, Mikko Perttunen wrote: > Add YAML device tree bindings for NVDEC, now in a more appropriate > place compared to the old textual Host1x bindings. > > Signed-off-by: Mikko Perttunen > --- > v6: > * Elaborated description for nvidia,host1x-class. > * Added default

Re: [Intel-gfx] [PATCH v2 07/13] drm/i915/hdcp: Use HDCP helpers for i915

2021-09-16 Thread kernel test robot
Hi Sean, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip next-20210916] [cannot apply to robh/for-next linus/master v5.15-rc1] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-16 Thread Doug Anderson
Hi, On Thu, Sep 16, 2021 at 3:17 PM Stephen Boyd wrote: > > TL;DR: Please try to reduce these error messages in drivers and > consolidate them into subsystems so that drivers stay simple. > > Quoting Doug Anderson (2021-09-15 09:41:39) > > Hi, > > > > On Tue, Sep 14, 2021 at 7:50 PM Stephen Boyd

Re: [Intel-gfx] [PATCH v2 03/13] drm/hdcp: Update property value on content type and user changes

2021-09-16 Thread kernel test robot
Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip robh/for-next linus/master v5.15-rc1 next-20210916] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-16 Thread Chris Morgan
On Thu, Sep 16, 2021 at 01:49:07PM -0700, Brian Norris wrote: > On Thu, Sep 16, 2021 at 03:29:07PM -0500, Chris Morgan wrote: > > After commit 928f9e268611 ("clk: fractional-divider: Hide > > clk_fractional_divider_ops from wide audience") was merged it appears > > What does that commit have to do

Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-16 Thread Stephen Boyd
TL;DR: Please try to reduce these error messages in drivers and consolidate them into subsystems so that drivers stay simple. Quoting Doug Anderson (2021-09-15 09:41:39) > Hi, > > On Tue, Sep 14, 2021 at 7:50 PM Stephen Boyd wrote: > > > > > > I'd rather see any sort of error message in getter AP

[PATCH v2] drm/nouveau/ga102-: support ttm buffer moves via copy engine

2021-09-16 Thread Ben Skeggs
From: Ben Skeggs We don't currently have any kind of real acceleration on Ampere GPUs, but the TTM memcpy() fallback paths aren't really designed to handle copies between different devices, such as on Optimus systems, and result in a kernel OOPS. A few options were investigated to try and fix th

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-09-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 --- Comment #5 from Parker Reed (parker.l.r...@gmail.com) --- Created attachment 298847 --> https://bugzilla.kernel.org/attachment.cgi?id=298847&action=edit dmesg from 5.14.3 -- You may reply to this email to add a comment. You are receiving

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2021-09-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 Parker Reed (parker.l.r...@gmail.com) changed: What|Removed |Added CC||parker.l.r...@gmai

[PATCH] drm/v3d: fix sched job resources cleanup when a job is aborted

2021-09-16 Thread Melissa Wen
In a cl submission, when bin job initialization fails, sched job resources were already allocated for the render job. At this point, drm_sched_job_init(render) was done in v3d_job_init but the render job is aborted before drm_sched_job_arm (in v3d_job_push) happens; therefore, not only v3d_job_put

[PATCH 11/15] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 06/15] drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/tegra/dsi.c | 6 -- drivers/gpu/drm/tegra/hdmi.c | 5 +++-- drivers/gpu/drm/tegra/s

[PATCH 10/15] drm/nouveau: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

[PATCH 13/15] drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/gma500/psb_device.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-)

[PATCH 03/15] dmr/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 10 -- 1 file changed, 4

[PATCH 08/15] drm/radeon: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/radeon/radeon_device.c | 13 + drivers/gpu/drm/radeon/radeon_dp_mst.c | 7 +++

[PATCH 15/15] doc: drm: remove TODO entry regarding DRM_MODSET_LOCK_ALL cleanup

2021-09-16 Thread Fernando Ramos
The previous commits do exactly what this entry in the TODO file asks for, thus we can remove it now as it is no longer applicable. Signed-off-by: Fernando Ramos --- Documentation/gpu/todo.rst| 17 - Documentation/locking/ww-mutex-design.rst | 2 +- 2 files chang

[PATCH 09/15] drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/omapdrm/omap_fb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 05/15] drm/vmwgfx: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 11 +++ drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 12 +++

[PATCH 14/15] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 13 +++-- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |

[PATCH 02/15] dmr/i915: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/i915/display/intel_display.c | 17 - 1 file changed,

[PATCH 04/15] drm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/drm_client_modeset.c | 5 +++-- drivers/gpu/drm/drm_crtc_helper.c| 18 ---

[PATCH 07/15] drm/shmobile: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 00/15] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

2021-09-16 Thread Fernando Ramos
Hi all, One of the things in the DRM TODO list ("Documentation/gpu/todo.rst") was to "use DRM_MODESET_LOCAL_ALL_* helpers instead of boilerplate". That's what this patch series is about. You will find two types of changes here: - Replacing "drm_modeset_lock_all_ctx()" (and surrounding boilerpl

[PATCH 12/15] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/i915/display/intel_audio.c| 12 +++-- drivers/gpu/drm/i915/display/intel_display.c |

[PATCH 01/15] dmr: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-09-16 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/drm_client_modeset.c | 9 +++-- 1 file changed, 3 insertions(+),

Re: [PATCH v3] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-16 Thread Brian Norris
On Thu, Sep 16, 2021 at 03:29:07PM -0500, Chris Morgan wrote: > After commit 928f9e268611 ("clk: fractional-divider: Hide > clk_fractional_divider_ops from wide audience") was merged it appears What does that commit have to do with anything? Are you perhaps interested in its parent, where the rock

Re: [git pull] drm fixes for 5.15-rc2

2021-09-16 Thread pr-tracker-bot
The pull request you sent on Fri, 17 Sep 2021 06:15:42 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2021-09-17 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/bdb575f872175ed0ecf2638369da1cb7a6e86a14 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH 2/3] drm/v3d: add generic ioctl extension

2021-09-16 Thread Melissa Wen
On 09/16, Daniel Vetter wrote: > On Wed, Aug 18, 2021 at 06:56:41PM +0100, Melissa Wen wrote: > > Add support to attach generic extensions on job submission. > > This patch is a second prep work to enable multiple syncobjs on job > > submission. With this work, when the job submission interface nee

Re: [PATCH v3] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-16 Thread Doug Anderson
Hi, On Thu, Sep 16, 2021 at 1:29 PM Chris Morgan wrote: > > From: Chris Morgan > > After commit 928f9e268611 ("clk: fractional-divider: Hide > clk_fractional_divider_ops from wide audience") was merged it appears > that the DSI panel on my Odroid Go Advance stopped working. Upon closer > examina

Re: [PATCH v3 3/3] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-16 Thread Doug Anderson
Hi, On Thu, Sep 16, 2021 at 1:15 PM Stephen Boyd wrote: > > > > > + return ret; > > > > + } > > > > + > > > > + /* Assume it's good */ > > > > + msg->reply = 0; > > > > + > > > > + addr_len[0] = msg->address & 0xff; > > > > + addr_len[1] = (msg->address

[PATCH v3] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-16 Thread Chris Morgan
From: Chris Morgan After commit 928f9e268611 ("clk: fractional-divider: Hide clk_fractional_divider_ops from wide audience") was merged it appears that the DSI panel on my Odroid Go Advance stopped working. Upon closer examination of the problem, it looks like it was the fixup in the rockchip_drm

[git pull] drm fixes for 5.15-rc2

2021-09-16 Thread Dave Airlie
Hi Linus, Slightly busier than usual rc2, but mostly scattered amdgpu fixes, some i915 and etnaviv resolves an MMU/runtime PM blowup, otherwise I'm offline for next few days, but back early next week. drm-fixes-2021-09-17: drm fixes for 5.15-rc2 amdgpu: - UBSAN fix - Powerplay table update fix -

Re: [PATCH v3 3/3] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-16 Thread Stephen Boyd
Quoting Doug Anderson (2021-09-15 14:27:40) > Hi, > > On Tue, Sep 14, 2021 at 5:57 PM Stephen Boyd wrote: > > > > Quoting Philip Chen (2021-09-14 16:28:45) > > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > > > b/drivers/gpu/drm/bridge/parade-ps8640.c > > > index 8d3e7a147170..dc349d729f

Re: [PATCH v2] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-16 Thread Doug Anderson
Hi, On Thu, Sep 16, 2021 at 12:33 PM Chris Morgan wrote: > > From: Chris Morgan > > Fixes commit 287422a95fe2 ("drm/rockchip: Round up _before_ giving to > the clock framework") This belongs at the bottom of the commit and needs a colon. It also shouldn't be word-wrapped. > After commit 928f9

Re: [PATCH v9 2/4] dt-bindings: mfd: logicvc: Add patternProperties for the display

2021-09-16 Thread Rob Herring
On Tue, 14 Sep 2021 22:05:37 +0200, Paul Kocialkowski wrote: > The LogiCVC multi-function device has a display part which is now > described in its binding. Add a patternProperties match for it. > > Signed-off-by: Paul Kocialkowski > --- > Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml

Re: [PATCH v9 1/4] dt-bindings: display: Document the Xylon LogiCVC display controller

2021-09-16 Thread Rob Herring
On Wed, Sep 15, 2021 at 07:56:34AM -0500, Rob Herring wrote: > On Tue, 14 Sep 2021 22:05:36 +0200, Paul Kocialkowski wrote: > > The Xylon LogiCVC is a display controller implemented as programmable > > logic in Xilinx FPGAs. > > > > Signed-off-by: Paul Kocialkowski > > Acked-by: Rob Herring > >

Re: [PATCH v11 08/34] dt-bindings: host1x: Document Memory Client resets of Host1x, GR2D and GR3D

2021-09-16 Thread Rob Herring
On Sun, 12 Sep 2021 23:08:06 +0300, Dmitry Osipenko wrote: > Memory Client should be blocked before hardware reset is asserted in order > to prevent memory corruption and hanging of memory controller. > > Document Memory Client resets of Host1x, GR2D and GR3D hardware units. > > Signed-off-by: Dm

[PATCH v2] drm/hyperv: Fix double mouse pointers

2021-09-16 Thread Dexuan Cui
Hyper-V supports a hardware cursor feature. It is not used by Linux VM, but the Hyper-V host still draws a point as an extra mouse pointer, which is unwanted, especially when Xorg is running. The hyperv_fb driver uses synthvid_send_ptr() to hide the unwanted pointer. When the hyperv_drm driver was

[PATCH v2] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-16 Thread Chris Morgan
From: Chris Morgan Fixes commit 287422a95fe2 ("drm/rockchip: Round up _before_ giving to the clock framework") After commit 928f9e268611 ("clk: fractional-divider: Hide clk_fractional_divider_ops from wide audience") was merged it appears that the DSI panel on my Odroid Go Advance stopped workin

Re: [PATCH 5/5] drm/vboxvideo: Use managed interfaces for framebuffer write combining

2021-09-16 Thread Hans de Goede
Hi, On 9/16/21 8:16 PM, Thomas Zimmermann wrote: > Replace arch_phys_wc_add() with the rsp managed function. Allows for > removing the cleanup code for memory management > > Signed-off-by: Thomas Zimmermann Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- >

[PATCH] drm/tegra: Bump VIC/NVDEC clock rates to Fmax

2021-09-16 Thread Mikko Perttunen
To get full performance out of these engines, bump their clock rates to maximum. In the future we may want something smarter but this should be fine for now. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/nvdec.c | 6 ++ drivers/gpu/drm/tegra/vic.c | 6 ++ 2 files changed, 12

[PATCH v6 2/3] arm64: tegra: Add NVDEC to Tegra186/194 device trees

2021-09-16 Thread Mikko Perttunen
Add a device tree node for NVDEC on Tegra186, and device tree nodes for NVDEC and NVDEC1 on Tegra194. Signed-off-by: Mikko Perttunen --- v5: * Change from nvidia,instance to nvidia,host1x-class v4: * Add dma-coherent markers v3: * Change read2 to read-1 v2: * Add NVDECSRD1 memory client * Add als

[PATCH v6 1/3] dt-bindings: Add YAML bindings for NVDEC

2021-09-16 Thread Mikko Perttunen
Add YAML device tree bindings for NVDEC, now in a more appropriate place compared to the old textual Host1x bindings. Signed-off-by: Mikko Perttunen --- v6: * Elaborated description for nvidia,host1x-class. * Added default value for nvidia,host1x-class. v5: * Changed from nvidia,instance to nvidi

[PATCH v6 0/3] NVIDIA Tegra NVDEC support

2021-09-16 Thread Mikko Perttunen
Here's the v6 of the NVDEC support series, containing the following changes: * Minor changes to device tree bindings. See patch for details. NVDEC hardware documentation can be found at https://github.com/NVIDIA/open-gpu-doc/tree/master/classes/video and example userspace can be found at https:/

[PATCH v6 3/3] drm/tegra: Add NVDEC driver

2021-09-16 Thread Mikko Perttunen
Add support for booting and using NVDEC on Tegra210, Tegra186 and Tegra194 to the Host1x and TegraDRM drivers. Booting in secure mode is not currently supported. Signed-off-by: Mikko Perttunen --- v5: * Remove num_instances * Change from nvidia,instance to nvidia,host1x-class v3: * Change num_ins

Re: [PATCH] drm/rockchip: Update crtc fixup to account for fractional clk change

2021-09-16 Thread Chris Morgan
On Thu, Sep 16, 2021 at 10:08:05AM -0700, Doug Anderson wrote: > Hi, > > On Tue, Sep 14, 2021 at 4:14 AM Heiko Stübner wrote: > > > > Hi, > > > > Am Mittwoch, 8. September 2021, 15:53:56 CEST schrieb Chris Morgan: > > > From: Chris Morgan > > > > > > After commit 928f9e268611 ("clk: fractional-d

[PATCH v2 2/2] drm/i915/uapi: Add query for hwconfig table

2021-09-16 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interes

[PATCH v2 0/2] Add support for querying hw info that UMDs need

2021-09-16 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. v2: Add a kerneldoc comment. Test-with: 20210915215558.2473428-2-john.c.harri...@intel.com UMD:

[PATCH v2 1/2] drm/i915/guc: Add fetch of hwconfig table

2021-09-16 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc: Mich

Re: [PATCH v3 0/8] Implement generic cc_platform_has() helper function

2021-09-16 Thread Kuppuswamy, Sathyanarayanan
On 9/16/21 8:02 AM, Borislav Petkov wrote: On Wed, Sep 15, 2021 at 10:26:06AM -0700, Kuppuswamy, Sathyanarayanan wrote: I have a Intel variant patch (please check following patch). But it includes TDX changes as well. Shall I move TDX changes to different patch and just create a separate patc

[PATCH v2 7/8] drm/tegra: vic: Implement get_streamid_offset

2021-09-16 Thread Mikko Perttunen
Implement the get_streamid_offset required for supporting context isolation. Since old firmware cannot support context isolation without hacks that we don't want to implement, check the firmware binary to see if context isolation should be enabled. Signed-off-by: Mikko Perttunen --- drivers/gpu/

[PATCH v2 2/8] gpu: host1x: Add context device management code

2021-09-16 Thread Mikko Perttunen
Add code to register context devices from device tree, allocate them out and manage their refcounts. Signed-off-by: Mikko Perttunen --- v2: * Directly set DMA mask instead of inheriting from Host1x. * Use iommu-map instead of custom DT property. --- drivers/gpu/host1x/Makefile | 1 + drivers/

[PATCH v2 8/8] drm/tegra: Support context isolation

2021-09-16 Thread Mikko Perttunen
For engines that support context isolation, allocate a context when opening a channel, and set up stream ID offset and context fields when submitting a job. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.h| 2 ++ drivers/gpu/drm/tegra/submit.c | 13 + drivers/gpu/d

[PATCH v2 3/8] gpu: host1x: Program context stream ID on submission

2021-09-16 Thread Mikko Perttunen
Add code to do stream ID switching at the beginning of a job. The stream ID is switched to the stream ID specified by the context passed in the job structure. Before switching the stream ID, an OP_DONE wait is done on the channel's engine to ensure that there is no residual ongoing work that might

[PATCH v2 6/8] drm/tegra: falcon: Set DMACTX field on DMA transactions

2021-09-16 Thread Mikko Perttunen
The DMACTX field determines which context, as specified in the TRANSCFG register, is used. While during boot it doesn't matter which is used, later on it matters and this value is reused by the firmware. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/falcon.c | 8 drivers/gpu/

[PATCH v2 0/8] Host1x context isolation support

2021-09-16 Thread Mikko Perttunen
Hi all, *** New in v2: Added support for Tegra194 Use standard iommu-map property instead of custom mechanism *** this series adds support for Host1x 'context isolation'. Since when programming engines through Host1x, userspace can program in any addresses it wants, we need some way to isolate t

  1   2   3   >