When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoq...@baidu.com>
---
 .../fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c 
b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
index 1bec7a4422e8..6befd22dbd5c 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
@@ -244,10 +244,9 @@ static int lb035q02_probe_of(struct spi_device *spi)
        struct gpio_desc *gpio;
 
        gpio = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW);
-       if (IS_ERR(gpio)) {
-               dev_err(&spi->dev, "failed to parse enable gpio\n");
-               return PTR_ERR(gpio);
-       }
+       if (IS_ERR(gpio))
+               return dev_err_probe(&spi->dev, PTR_ERR(gpio),
+                                    "failed to parse enable gpio\n");
 
        ddata->enable_gpio = gpio;
 
-- 
2.25.1

Reply via email to