When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoq...@baidu.com>
---
 drivers/video/backlight/l4f00242t03.c | 34 ++++++++++-----------------
 1 file changed, 13 insertions(+), 21 deletions(-)

diff --git a/drivers/video/backlight/l4f00242t03.c 
b/drivers/video/backlight/l4f00242t03.c
index 46f97d1c3d21..8d81d4dec3c6 100644
--- a/drivers/video/backlight/l4f00242t03.c
+++ b/drivers/video/backlight/l4f00242t03.c
@@ -179,37 +179,29 @@ static int l4f00242t03_probe(struct spi_device *spi)
        priv->spi = spi;
 
        priv->reset = devm_gpiod_get(&spi->dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(priv->reset)) {
-               dev_err(&spi->dev,
-                       "Unable to get the lcd l4f00242t03 reset gpio.\n");
-               return PTR_ERR(priv->reset);
-       }
+       if (IS_ERR(priv->reset))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->reset),
+                                    "Unable to get the lcd l4f00242t03 reset 
gpio.\n");
        gpiod_set_consumer_name(priv->reset, "lcd l4f00242t03 reset");
 
        priv->enable = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW);
-       if (IS_ERR(priv->enable)) {
-               dev_err(&spi->dev,
-                       "Unable to get the lcd l4f00242t03 data en gpio.\n");
-               return PTR_ERR(priv->enable);
-       }
+       if (IS_ERR(priv->enable))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->enable),
+                                    "Unable to get the lcd l4f00242t03 data en 
gpio.\n");
        gpiod_set_consumer_name(priv->enable, "lcd l4f00242t03 data enable");
 
        priv->io_reg = devm_regulator_get(&spi->dev, "vdd");
-       if (IS_ERR(priv->io_reg)) {
-               dev_err(&spi->dev, "%s: Unable to get the IO regulator\n",
-                      __func__);
-               return PTR_ERR(priv->io_reg);
-       }
+       if (IS_ERR(priv->io_reg))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->io_reg),
+                                    "%s: Unable to get the IO regulator\n", 
__func__);
 
        priv->core_reg = devm_regulator_get(&spi->dev, "vcore");
-       if (IS_ERR(priv->core_reg)) {
-               dev_err(&spi->dev, "%s: Unable to get the core regulator\n",
-                      __func__);
-               return PTR_ERR(priv->core_reg);
-       }
+       if (IS_ERR(priv->core_reg))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->core_reg),
+                                    "%s: Unable to get the core regulator\n", 
__func__);
 
        priv->ld = devm_lcd_device_register(&spi->dev, "l4f00242t03", &spi->dev,
-                                       priv, &l4f_ops);
+                                           priv, &l4f_ops);
        if (IS_ERR(priv->ld))
                return PTR_ERR(priv->ld);
 
-- 
2.25.1

Reply via email to