Re: [PATCH] dma-buf: Fix static checker warning

2020-11-02 Thread Christian König
Am 03.11.20 um 04:51 schrieb Jianxin Xiong: Here is the warning message: drivers/dma-buf/dma-buf.c:917 dma_buf_map_attachment() error: 'sg_table' dereferencing possible ERR_PTR() Fix by adding error checking before dereferencing the pointer. Fixes: ac80cd17a615 ("dma-buf: Clari

Re: [PATCH v2] drm: Add the new api to install irq

2020-11-02 Thread Thomas Zimmermann
Hi Thanks, the code looks good already. There just are a few nits below. Am 03.11.20 um 03:10 schrieb Tian Tao: > Add new api devm_drm_irq_install() to register interrupts, > no need to call drm_irq_uninstall() when the drm module is removed. > > v2: > fixed the wrong parameter. > > Signed-off-

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Greg KH
On Mon, Nov 02, 2020 at 09:48:25PM +0100, Christian König wrote: > Am 03.11.20 um 07:53 schrieb Greg KH: > > On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian König wrote: > > > Am 02.11.20 um 20:43 schrieb Alex Deucher: > > > > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma > > > > wrote: > > >

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Christian König
Am 03.11.20 um 07:53 schrieb Greg KH: On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian König wrote: Am 02.11.20 um 20:43 schrieb Alex Deucher: On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: Initializing global variable to 0 or NULL is not necessary and should be avoided. Issue report

Re: [PATCH v7 0/6] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-02 Thread Chanwoo Choi
Hi Sylwester, When I tested this patchset on Odroid-U3, After setting 0 bps by interconnect[1][2], the frequency of devfreq devs sustain the high frequency according to the pm qos request. So, I try to find the cause of this situation. In result, it seems that interconnect exynos driver updates t

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Greg KH
On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian König wrote: > Am 02.11.20 um 20:43 schrieb Alex Deucher: > > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: > > > Initializing global variable to 0 or NULL is not necessary and should > > > be avoided. Issue reported by checkpatch script a

Re: [bug report] dma-buf: Clarify that dma-buf sg lists are page aligned

2020-11-02 Thread Dan Carpenter
On Mon, Nov 02, 2020 at 09:33:08PM +, Xiong, Jianxin wrote: > Hi Dan, > > Thanks for reporting the bug. I see what was missing. Am I supposed to submit > a patch to > replace the original patch or just to fix this bug? > Once the patch has been applied, then it's too late to replace it. Ju

Re: [resource] 22b17dc667: Kernel panic - not syncing: Fatal exception

2020-11-02 Thread John Hubbard
On 11/2/20 10:06 PM, lkp wrote: Greeting, FYI, we noticed the following commit (built with gcc-9): commit: 22b17dc667d36418ccabb9c668c4b489185fb40a ("[PATCH v5 13/15] resource: Move devmem revoke code to resource framework") url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/follow_p

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-02 Thread Vinod Koul
Hi, Thanks Doug for adding me On 02-11-20, 08:37, Doug Anderson wrote: > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > Any chance we can convince you to prepare this bridge driver for use in > > a chained bridge setup where the connector is created by the display > > driver

Re: [PATCH v2 0/8] slab: provide and use krealloc_array()

2020-11-02 Thread Joe Perches
On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Andy brought to my attention the fact that users allocating an array of > equally sized elements should check if the size multiplication doesn't > overflow. This is why we have helpers like kmalloc_array

[PATCH] dma-buf: Fix static checker warning

2020-11-02 Thread Jianxin Xiong
Here is the warning message: drivers/dma-buf/dma-buf.c:917 dma_buf_map_attachment() error: 'sg_table' dereferencing possible ERR_PTR() Fix by adding error checking before dereferencing the pointer. Fixes: ac80cd17a615 ("dma-buf: Clarify that dma-buf sg lists are page aligned") Re

linux-next: manual merge of the drm-misc tree with the amdgpu tree

2020-11-02 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c between commit: e8a982355f96 ("drm/amd/display: Add tracepoint for amdgpu_dm") from the amdgpu tree and commit: 29b77ad7b9ca ("drm/atomic: Pass the full state to CR

Re: [PATCH v6 49/52] PM / devfreq: tegra20: Convert to EMC_STAT driver, support interconnect and device-tree

2020-11-02 Thread Chanwoo Choi
On 11/3/20 5:08 AM, Dmitry Osipenko wrote: > 01.11.2020 17:12, Dmitry Osipenko пишет: > ... >> We will probably move the Tegra20 EMC_STAT devfreq driver into the >> memory driver and remove the older IMC_STAT driver in v7, like it was >> suggested by Thierry Reding. This will be a much less invasiv

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Rob Herring
On Mon, Nov 2, 2020 at 12:04 PM Sam Ravnborg wrote: > > Hi Neil. > > > > --- > > > .../bindings/display/intel,keembay-display.yaml| 75 > > > ++ > > > 1 file changed, 75 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindin

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Rob Herring
On Mon, Nov 2, 2020 at 10:38 AM Neil Armstrong wrote: > > On 02/11/2020 16:16, Rob Herring wrote: > > On Fri, Oct 30, 2020 at 4:15 PM Sam Ravnborg wrote: > >> > >> Hi Neil. > >> > >> On Fri, Oct 30, 2020 at 09:31:36AM +0100, Neil Armstrong wrote: > >>> Hi, > >>> > >>> On 29/10/2020 23:20, Sam Rav

[PATCH AUTOSEL 4.14 09/10] drm/vc4: drv: Add error handding for bind

2020-11-02 Thread Sasha Levin
From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 4.19 10/11] drm/vc4: drv: Add error handding for bind

2020-11-02 Thread Sasha Levin
From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 5.8 14/29] drm/v3d: Fix double free in v3d_submit_cl_ioctl()

2020-11-02 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit 897dbea6b716c0f2c5bcd4ba1eb4d809caba290c ] Originally this error path used to leak "bin" but then we accidentally applied two separate commits to fix it and ended up with a double free. Signed-off-by: Dan Carpenter Signed-off-by: Maxime Ripard Link: http

[PATCH AUTOSEL 5.8 27/29] drm/nouveau/nouveau: fix the start/end range for migration

2020-11-02 Thread Sasha Levin
From: Ralph Campbell [ Upstream commit cfa736f5a6f31ca8a05459b5720aac030247ad1b ] The user level OpenCL code shouldn't have to align start and end addresses to a page boundary. That is better handled in the nouveau driver. The npages field is also redundant since it can be computed from the star

[PATCH AUTOSEL 5.4 08/24] drm/sun4i: frontend: Rework a bit the phase data

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 84c971b356379c621df595bd00c3114579dfa59f ] The scaler filter phase setup in the allwinner kernel has two different cases for setting up the scaler filter, the first one using different phase parameters for the two channels, and the second one reusing the fir

[PATCH AUTOSEL 5.8 12/29] drm/sun4i: frontend: Reuse the ch0 phase for RGB formats

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 2db9ef9d9e6ea89a9feb5338f58d1f8f83875577 ] When using the scaler on the A10-like frontend with single-planar formats, the current code will setup the channel 0 filter (used for the R or Y component) with a different phase parameter than the channel 1 filter

[PATCH AUTOSEL 5.8 19/29] drm/amdgpu: add DID for navi10 blockchain SKU

2020-11-02 Thread Sasha Levin
From: "Tianci.Yin" [ Upstream commit 8942881144a7365143f196f5eafed24783a424a3 ] Reviewed-by: Alex Deucher Reviewed-by: Guchun Chen Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion

[PATCH AUTOSEL 5.4 19/24] drm/vc4: drv: Add error handding for bind

2020-11-02 Thread Sasha Levin
From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 5.4 09/24] drm/sun4i: frontend: Reuse the ch0 phase for RGB formats

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 2db9ef9d9e6ea89a9feb5338f58d1f8f83875577 ] When using the scaler on the A10-like frontend with single-planar formats, the current code will setup the channel 0 filter (used for the R or Y component) with a different phase parameter than the channel 1 filter

[PATCH AUTOSEL 5.4 23/24] drm/nouveau/gem: fix "refcount_t: underflow; use-after-free"

2020-11-02 Thread Sasha Levin
From: Karol Herbst [ Upstream commit 925681454d7b557d404b5d28ef4469fac1b2e105 ] we can't use nouveau_bo_ref here as no ttm object was allocated and nouveau_bo_ref mainly deals with that. Simply deallocate the object. Signed-off-by: Karol Herbst Signed-off-by: Ben Skeggs Signed-off-by: Sasha L

[PATCH AUTOSEL 5.8 24/29] drm/vc4: drv: Add error handding for bind

2020-11-02 Thread Sasha Levin
From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 5.4 22/24] drm/nouveau/nouveau: fix the start/end range for migration

2020-11-02 Thread Sasha Levin
From: Ralph Campbell [ Upstream commit cfa736f5a6f31ca8a05459b5720aac030247ad1b ] The user level OpenCL code shouldn't have to align start and end addresses to a page boundary. That is better handled in the nouveau driver. The npages field is also redundant since it can be computed from the star

[PATCH AUTOSEL 5.4 10/24] drm/sun4i: frontend: Fix the scaler phase on A33

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit e3190b5e9462067714d267c40d8c8c1d0463dda3 ] The A33 has a different phase parameter in the Allwinner BSP on the channel1 than the one currently applied. Fix this. Signed-off-by: Maxime Ripard Acked-by: Jernej Skrabec Link: https://patchwork.freedesktop.or

[PATCH AUTOSEL 5.8 28/29] drm/nouveau/gem: fix "refcount_t: underflow; use-after-free"

2020-11-02 Thread Sasha Levin
From: Karol Herbst [ Upstream commit 925681454d7b557d404b5d28ef4469fac1b2e105 ] we can't use nouveau_bo_ref here as no ttm object was allocated and nouveau_bo_ref mainly deals with that. Simply deallocate the object. Signed-off-by: Karol Herbst Signed-off-by: Ben Skeggs Signed-off-by: Sasha L

[PATCH AUTOSEL 5.4 14/24] drm/amdgpu: add DID for navi10 blockchain SKU

2020-11-02 Thread Sasha Levin
From: "Tianci.Yin" [ Upstream commit 8942881144a7365143f196f5eafed24783a424a3 ] Reviewed-by: Alex Deucher Reviewed-by: Guchun Chen Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion

[PATCH AUTOSEL 5.8 13/29] drm/sun4i: frontend: Fix the scaler phase on A33

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit e3190b5e9462067714d267c40d8c8c1d0463dda3 ] The A33 has a different phase parameter in the Allwinner BSP on the channel1 than the one currently applied. Fix this. Signed-off-by: Maxime Ripard Acked-by: Jernej Skrabec Link: https://patchwork.freedesktop.or

[PATCH AUTOSEL 5.9 21/35] drm/amdgpu: disable DCN and VCN for navi10 blockchain SKU(v3)

2020-11-02 Thread Sasha Levin
From: "Tianci.Yin" [ Upstream commit a305e7dc5fa86ff9cf6cd2da30215a92d43c9285 ] The blockchain SKU has no display and video support, remove them. Reviewed-by: Alex Deucher Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/nv.c |

[PATCH AUTOSEL 5.8 11/29] drm/sun4i: frontend: Rework a bit the phase data

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 84c971b356379c621df595bd00c3114579dfa59f ] The scaler filter phase setup in the allwinner kernel has two different cases for setting up the scaler filter, the first one using different phase parameters for the two channels, and the second one reusing the fir

[PATCH AUTOSEL 5.9 34/35] drm/nouveau/gem: fix "refcount_t: underflow; use-after-free"

2020-11-02 Thread Sasha Levin
From: Karol Herbst [ Upstream commit 925681454d7b557d404b5d28ef4469fac1b2e105 ] we can't use nouveau_bo_ref here as no ttm object was allocated and nouveau_bo_ref mainly deals with that. Simply deallocate the object. Signed-off-by: Karol Herbst Signed-off-by: Ben Skeggs Signed-off-by: Sasha L

[PATCH AUTOSEL 5.9 25/35] drm/amd/display: adding ddc_gpio_vga_reg_list to ddc reg def'ns

2020-11-02 Thread Sasha Levin
From: Martin Leung [ Upstream commit a1d2afc5dde29a943d32bf92eb0408c9f19541fc ] why: oem-related ddc read/write fails without these regs how: copy from hw_factory_dcn20.c Signed-off-by: Martin Leung Acked-by: Aurabindo Pillai Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- .../

[PATCH AUTOSEL 5.9 15/35] drm/v3d: Fix double free in v3d_submit_cl_ioctl()

2020-11-02 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit 897dbea6b716c0f2c5bcd4ba1eb4d809caba290c ] Originally this error path used to leak "bin" but then we accidentally applied two separate commits to fix it and ended up with a double free. Signed-off-by: Dan Carpenter Signed-off-by: Maxime Ripard Link: http

[PATCH AUTOSEL 5.9 22/35] drm/amdgpu: add DID for navi10 blockchain SKU

2020-11-02 Thread Sasha Levin
From: "Tianci.Yin" [ Upstream commit 8942881144a7365143f196f5eafed24783a424a3 ] Reviewed-by: Alex Deucher Reviewed-by: Guchun Chen Signed-off-by: Tianci.Yin Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion

[PATCH AUTOSEL 5.9 14/35] drm/sun4i: frontend: Fix the scaler phase on A33

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit e3190b5e9462067714d267c40d8c8c1d0463dda3 ] The A33 has a different phase parameter in the Allwinner BSP on the channel1 than the one currently applied. Fix this. Signed-off-by: Maxime Ripard Acked-by: Jernej Skrabec Link: https://patchwork.freedesktop.or

[PATCH AUTOSEL 5.9 07/35] hyperv_fb: Update screen_info after removing old framebuffer

2020-11-02 Thread Sasha Levin
From: Kairui Song [ Upstream commit 3cb73bc3fa2a3cb80b88aa63b48409939e0d996b ] On gen2 HyperV VM, hyperv_fb will remove the old framebuffer, and the new allocated framebuffer address could be at a differnt location, and it might be no longer a VGA framebuffer. Update screen_info so that after k

[PATCH AUTOSEL 5.9 23/35] drm/amd/display: Fixed panic during seamless boot.

2020-11-02 Thread Sasha Levin
From: David Galiffi [ Upstream commit 866e09f0110c6e86071954033e3067975946592a ] [why] get_pixel_clk_frequency_100hz is undefined in clock_source_funcs. [how] set function pointer: ".get_pixel_clk_frequency_100hz = get_pixel_clk_frequency_100hz" Signed-off-by: David Galiffi Reviewed-by: Bhaw

[PATCH AUTOSEL 5.9 33/35] drm/nouveau/nouveau: fix the start/end range for migration

2020-11-02 Thread Sasha Levin
From: Ralph Campbell [ Upstream commit cfa736f5a6f31ca8a05459b5720aac030247ad1b ] The user level OpenCL code shouldn't have to align start and end addresses to a page boundary. That is better handled in the nouveau driver. The npages field is also redundant since it can be computed from the star

[PATCH AUTOSEL 5.9 30/35] drm/vc4: drv: Add error handding for bind

2020-11-02 Thread Sasha Levin
From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://

[PATCH AUTOSEL 5.9 13/35] drm/sun4i: frontend: Reuse the ch0 phase for RGB formats

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 2db9ef9d9e6ea89a9feb5338f58d1f8f83875577 ] When using the scaler on the A10-like frontend with single-planar formats, the current code will setup the channel 0 filter (used for the R or Y component) with a different phase parameter than the channel 1 filter

[PATCH AUTOSEL 5.9 12/35] drm/sun4i: frontend: Rework a bit the phase data

2020-11-02 Thread Sasha Levin
From: Maxime Ripard [ Upstream commit 84c971b356379c621df595bd00c3114579dfa59f ] The scaler filter phase setup in the allwinner kernel has two different cases for setting up the scaler filter, the first one using different phase parameters for the two channels, and the second one reusing the fir

[PATCH AUTOSEL 5.8 07/29] hyperv_fb: Update screen_info after removing old framebuffer

2020-11-02 Thread Sasha Levin
From: Kairui Song [ Upstream commit 3cb73bc3fa2a3cb80b88aa63b48409939e0d996b ] On gen2 HyperV VM, hyperv_fb will remove the old framebuffer, and the new allocated framebuffer address could be at a differnt location, and it might be no longer a VGA framebuffer. Update screen_info so that after k

[PATCH 03/11] drm/mediatek: Move clk info from struct mtk_ddp_comp to sub driver private data

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so data belonged to sub driver should be moved into sub driver private data so it could be used for multiple path. clk info is one of sub driver data, so move it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- dr

[PATCH 04/11] drm/mediatek: Move regs info from struct mtk_ddp_comp to sub driver private data

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so data belonged to sub driver should be moved into sub driver private data so it could be used for multiple path. regs info is one of sub driver data, so move it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- d

[PATCH 07/11] drm/mediatek: Move cmdq_reg info from struct mtk_ddp_comp to sub driver private data

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so data belonged to sub driver should be moved into sub driver private data so it could be used for multiple path. cmdq_reg info is one of sub driver data, so move it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --

[PATCH 11/11] drm/mediatek: Move mtk_ddp_comp_init() from sub driver to DRM driver

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver should not directly call DRM driver's function. Moving mtk_ddp_comp_init() from sub driver to DRM driver to achieve this. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_

[PATCH 05/11] drm/mediatek: Remove irq in struct mtk_ddp_comp

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu irq in struct mtk_ddp_comp is useless, so remove it. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_

[PATCH 06/11] drm/mediatek: Use struct cmdq_client_reg to gather cmdq variable

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu struct cmdq_client_reg include subsys and offset, so use it to replace these two variable. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 24 ++--- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 4 ++-- 2 files c

[PATCH 08/11] drm/mediatek: Change sub driver interface from mtk_ddp_comp to device

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver interface should get rid of display info. Using device instead of mtk_ddp_comp make interface general. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 1

[PATCH 02/11] drm/mediatek: Use correct device pointer to get CMDQ client register

2020-11-02 Thread Chun-Kuang Hu
Some ddp component use mmsys device pointer to get CMDQ client register, this would get mmsys' CMDQ client register, so use each ddp component's device pointer to get. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 2 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c

[PATCH 01/11] drm/mediatek: Get CMDQ client register for all ddp component

2020-11-02 Thread Chun-Kuang Hu
Only OVL, RDMA,and WDMA get CMDQ client register information, but all ddp component should work with CMDQ, so get this information for all ddp component. Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 28 ++--- 1 file changed, 14 insertions(+), 14

[PATCH 10/11] drm/mediatek: DRM driver directly refer to sub driver's function

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver should not directly call DRM driver's function. Let DRM driver directly refer to sub driver's function so that sub driver need not register these function to DRM driver. Signed-off-by: CK Hu Signed-off-by: C

[PATCH 09/11] drm/mediatek: Register vblank callback function

2020-11-02 Thread Chun-Kuang Hu
From: CK Hu Some ddp component exist in both display path and other path, so sub driver should not directly call crtc function. crtc register callback function to sub driver to prevent sub driver directly call crtc function. Signed-off-by: CK Hu Signed-off-by: Chun-Kuang Hu --- drivers/gpu/dr

[PATCH 00/11] Decouple Mediatek DRM sub driver

2020-11-02 Thread Chun-Kuang Hu
mtk ccorr is controlled by DRM and MDP [1]. In order to share mtk_ccorr driver for DRM and MDP, decouple Mediatek DRM sub driver which include mtk_ccorr, so MDP could use this decoupled mtk_ccorr. [1] https://patchwork.kernel.org/patch/11140751/ CK Hu (9): drm/mediatek: Move clk info from struc

linux-next: build warning after merge of the drm-misc-fixes tree

2020-11-02 Thread Stephen Rothwell
Hi all, After merging the drm-misc-fixes tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/gpu/drm/vc4/vc4_drv.c: In function 'vc4_drm_unbind': drivers/gpu/drm/vc4/vc4_drv.c:322:18: warning: unused variable 'vc4' [-Wunused-variable] 322 | struct vc4_dev *v

Why is atomic_disable callback's plane->state->crtc sometimes null?

2020-11-02 Thread Kevin Brace
Hi, First, I will like to thank those who gave me hints on how to proceed with getting rid of an unwanted double allocation of visible portion of the frame buffer. https://lists.freedesktop.org/archives/dri-devel/2020-October/283452.html I may repost the question later to the mailing list base

Re: [PATCH] drm/msm/dp: promote irq_hpd handle to handle link trainign correctly

2020-11-02 Thread Rob Clark
On Mon, Nov 2, 2020 at 11:29 AM Stephen Boyd wrote: > > Subject has a typo in "training". > > Quoting Kuogee Hsieh (2020-10-30 16:23:24) > > Some dongles, such as Apple, required link training done at irq_hpd > > s/required/require/ > > > request instead of plugin request. This patch promote irq_h

Re: [Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-02 Thread abhinavk
Hi Stephen On 2020-11-02 15:06, Stephen Boyd wrote: Quoting abhin...@codeaurora.org (2020-11-02 14:43:33) Hi Stephen Thanks for the review. On 2020-11-02 13:19, Stephen Boyd wrote: > Quoting Abhinav Kumar (2020-10-29 13:55:09) >> For sinks that do not support audio, there is no need to notify

Re: [Freedreno] [PATCH] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-02 Thread abhinavk
Hi Stephen Thanks for the review. On 2020-11-02 13:19, Stephen Boyd wrote: Quoting Abhinav Kumar (2020-10-29 13:55:09) For sinks that do not support audio, there is no need to notify audio subsystem of the connection event. This will make sure that audio routes only to the primary display whe

Re: [PATCH v2] drm/bridge: tpd12s015: Fix irq registering in tpd12s015_probe

2020-11-02 Thread Laurent Pinchart
Hi Yue, Thank you for the patch. On Mon, Nov 02, 2020 at 10:30:24PM +0800, YueHaibing wrote: > gpiod_to_irq() return negative value in case of error, > the existing code doesn't handle negative error codes. > If the HPD gpio supports IRQs (gpiod_to_irq returns a > valid number), we use the IRQ. I

Re: [bug report] dma-buf: Clarify that dma-buf sg lists are page aligned

2020-11-02 Thread Daniel Vetter
On Mon, Nov 2, 2020 at 10:33 PM Xiong, Jianxin wrote: > > Hi Dan, > > Thanks for reporting the bug. I see what was missing. Am I supposed to submit > a patch to > replace the original patch or just to fix this bug? drm-misc-next doesn't rebase (except in emergencies), so please follow up with a

Re: [PATCH v2 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2020-11-02 Thread Laurent Pinchart
Hi Stephen, On Mon, Nov 02, 2020 at 09:38:12AM -0800, Stephen Boyd wrote: > Quoting Doug Anderson (2020-11-02 08:06:14) > > On Sun, Nov 1, 2020 at 11:21 AM Laurent Pinchart wrote: > > > On Thu, Oct 29, 2020 at 06:17:37PM -0700, Stephen Boyd wrote: > > > > @@ -265,6 +267,23 @@ connector_to_ti_sn_br

RE: [bug report] dma-buf: Clarify that dma-buf sg lists are page aligned

2020-11-02 Thread Xiong, Jianxin
Hi Dan, Thanks for reporting the bug. I see what was missing. Am I supposed to submit a patch to replace the original patch or just to fix this bug? Jianxin > -Original Message- > From: Dan Carpenter > Sent: Monday, November 02, 2020 12:15 AM > To: Xiong, Jianxin > Cc: dri-devel@list

Re: [PATCH] drm/vc4: drv: Remove unused variable

2020-11-02 Thread Daniel Vetter
On Mon, Nov 02, 2020 at 05:29:08PM +0100, Maxime Ripard wrote: > The commit dcda7c28bff2 ("drm/vc4: kms: Add functions to create the state > objects") removed the last users of the vc4 variable, but didn't remove > that variable resulting in a warning. > > Fixes: dcda7c28bff2 ("drm/vc4: kms: Add f

[PATCH v3 1/3] dt-bindings: Convert graph bindings to json-schema

2020-11-02 Thread Rob Herring
From: Sameer Pujar Convert device tree bindings of graph to YAML format. Currently graph.txt doc is referenced in multiple files and all of these need to use schema references. For now graph.txt is updated to refer to graph.yaml. For users of the graph binding, they should reference to the graph

[PATCH v3 3/3] dt-bindings: panel: common: Add reference to graph schema

2020-11-02 Thread Rob Herring
Now that we have a graph schema, reference it from the common panel schema. Cc: Thierry Reding Cc: Sam Ravnborg Cc: Laurent Pinchart Signed-off-by: Rob Herring --- v3: new patch .../devicetree/bindings/display/panel/panel-common.yaml| 7 +++ 1 file changed, 3 insertions(+), 4 deletio

[PATCH v3 0/3] dt-bindings: Convert graph bindings to json-schema

2020-11-02 Thread Rob Herring
Sameer, I wanted to experiment with what the interface for graph users looks like, so I've tweaked your patch a bit and converted 2 users. This series converts the DT graph binding to a schema. Users of the graph binding should reference the schema from 'ports' or 'port' node. Users will still nee

[PATCH v3 2/3] dt-bindings: usb-connector: Add reference to graph schema

2020-11-02 Thread Rob Herring
Now that we have a graph schema, reference it from the usb-connector schema. Signed-off-by: Rob Herring --- v3: new patch .../devicetree/bindings/connector/usb-connector.yaml | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/conne

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Greg KH
On Mon, Nov 02, 2020 at 02:43:45PM -0500, Alex Deucher wrote: > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: > > > > Initializing global variable to 0 or NULL is not necessary and should > > be avoided. Issue reported by checkpatch script as: > > ERROR: do not initialise globals to 0 (or N

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Christian König
Am 02.11.20 um 20:43 schrieb Alex Deucher: On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: Initializing global variable to 0 or NULL is not necessary and should be avoided. Issue reported by checkpatch script as: ERROR: do not initialise globals to 0 (or NULL). I agree that this is techni

Re: [PATCH] drm/amd: fix typoes

2020-11-02 Thread Christian König
Am 02.11.20 um 13:57 schrieb Bernard Zhao: Fix typoes. Signed-off-by: Bernard Zhao Acked-by: Christian König --- drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drive

Re: [PATCH] drm/nouveu: fix swiotlb include

2020-11-02 Thread Christian König
Am 02.11.20 um 11:32 schrieb Daniel Vetter: On Fri, Oct 30, 2020 at 12:13 PM Christian König wrote: The check for swiotlb has moved to nouveu_ttm.c, but we forgot to move the include as well. Signed-off-by: Christian König So this now broke drm-misc-next compilation on arm, which isn't great

Re: [PATCH 6/6] drm/amdgpu: use "*" adjacent to data name

2020-11-02 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Nov 2, 2020 at 2:41 PM Deepak R Varma wrote: > > When declaring pointer data, the "*" symbol should be used adjacent to > the data name as per the coding standards. This resolves following > issues reported by checkpatch script: > ERROR: "foo *

Re: [PATCH 2/2] drm/ttm: replace context flags with bools

2020-11-02 Thread kernel test robot
Hi "Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20201102] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.10-rc2] [If your

Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL

2020-11-02 Thread Alex Deucher
On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma wrote: > > Initializing global variable to 0 or NULL is not necessary and should > be avoided. Issue reported by checkpatch script as: > ERROR: do not initialise globals to 0 (or NULL). I agree that this is technically correct, but a lot of people don

Re: [PATCH 6/6] drm/amdgpu: improve code indentation and alignment

2020-11-02 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Nov 2, 2020 at 12:44 PM Deepak R Varma wrote: > > General code indentation and alignment changes such as replace spaces > by tabs or align function arguments as per the coding style > guidelines. The patch covers various .c files for this driver. > Issue

[Bug 210005] Kernel stacktrace, Xorg freezes

2020-11-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210005 --- Comment #1 from amara...@dshort.biz --- Found the same bug report on launchpad: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1901563 It seems there is a issue with Xorg and the i915 driver. -- You are receiving this mail because: Yo

Re: [PATCH -next] drm/amd/pm: remove unused variable

2020-11-02 Thread Alex Deucher
On Mon, Nov 2, 2020 at 8:44 AM Zou Wei wrote: > > Fix variable set but not used compilation warning: > > ./vangogh_ppt.c:397:6: warning: variable ‘ret’ set but not used > [-Wunused-but-set-variable] > int ret = 0; > ^~~ > Maybe you have an older version of the code? It's currently used.

RE: [PATCH][next] drm/amdgpu: fix spelling mistake: "Successed" -> "Succeeded"

2020-11-02 Thread Chauhan, Madhav
[AMD Public Use] -Original Message- From: amd-gfx On Behalf Of Colin King Sent: Monday, November 2, 2020 7:47 PM To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Daniel Vetter ; Dave Airlie ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: kernel-janit...@

Re: [PATCH][next] drm/amdgpu: fix spelling mistake: "Successed" -> "Succeeded"

2020-11-02 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 2, 2020 at 9:17 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a deb_dbg message. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH] drm/amd: fix typoes

2020-11-02 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Nov 2, 2020 at 8:43 AM Bernard Zhao wrote: > > Fix typoes. > > Signed-off-by: Bernard Zhao > --- > drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_c

[kbuild] Re: [PATCH] drm/irq: Add irq as false detection

2020-11-02 Thread Dan Carpenter
Hi Tian, url: https://github.com/0day-ci/linux/commits/Tian-Tao/drm-irq-Add-irq-as-false-detection/20201102-192137 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3cea11cd5e3b00d91caf0b4730194039b45c5891 config: x86_64-randconfig-m001-20201102 (attached as

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-11-02 Thread Tomasz Figa
On Fri, Oct 30, 2020 at 3:38 PM Daniel Vetter wrote: > > On Fri, Oct 30, 2020 at 3:11 PM Tomasz Figa wrote: > > > > On Fri, Oct 30, 2020 at 11:08 AM Daniel Vetter > > wrote: > > > > > > This is used by media/videbuf2 for persistent dma mappings, not just > > > for a single dma operation and the

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Sam Ravnborg
Hi Neil. > > --- > > .../bindings/display/intel,keembay-display.yaml| 75 > > ++ > > 1 file changed, 75 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/intel,keembay-display.yaml > > > > diff --git > >>

Re: [PATCH -next] drm/amd/pm: remove unused variable

2020-11-02 Thread kernel test robot
Hi Zou, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20201102] url: https://github.com/0day-ci/linux/commits/Zou-Wei/drm-amd-pm-remove-unused-variable/20201102-195853 base:b49976d8ef6448e86a7fda6a86f64867942b442d config: x86_64-randconfig-a004

Re: [PATCH v5 08/15] mm: Add unsafe_follow_pfn

2020-11-02 Thread Daniel Vetter
On Mon, Nov 2, 2020 at 4:52 PM Jason Gunthorpe wrote: > > On Mon, Nov 02, 2020 at 02:23:58PM +0100, Daniel Vetter wrote: > > On Mon, Nov 2, 2020 at 2:01 PM Jason Gunthorpe wrote: > > > > > > On Mon, Nov 02, 2020 at 01:56:10PM +0100, Daniel Vetter wrote: > > > > On Mon, Nov 2, 2020 at 8:29 AM Chri

Re: [PATCH v10 1/6] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-02 Thread Neil Armstrong
On 02/11/2020 16:16, Rob Herring wrote: > On Fri, Oct 30, 2020 at 4:15 PM Sam Ravnborg wrote: >> >> Hi Neil. >> >> On Fri, Oct 30, 2020 at 09:31:36AM +0100, Neil Armstrong wrote: >>> Hi, >>> >>> On 29/10/2020 23:20, Sam Ravnborg wrote: Hi Anitha. On Thu, Oct 29, 2020 at 02:27:52PM -

Re: [PATCH v2 0/4] drm/bridge: ti-sn65dsi86: Support EDID reading

2020-11-02 Thread Doug Anderson
Hi, On Sun, Nov 1, 2020 at 9:37 AM Sam Ravnborg wrote: > > Hi Stephen. > > On Thu, Oct 29, 2020 at 06:17:34PM -0700, Stephen Boyd wrote: > > This patch series cleans up the DDC code a little bit so that > > it is more efficient time wise and supports grabbing the EDID > > of the eDP panel over th

Re: [PATCH v2 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures

2020-11-02 Thread Doug Anderson
Hi, On Thu, Oct 29, 2020 at 6:17 PM Stephen Boyd wrote: > > We should be setting the drm_dp_aux_msg::reply field if a NACK or a > SHORT reply happens. Update the error bit handling logic in > ti_sn_aux_transfer() to handle these cases and notify upper layers that > such errors have happened. This

[Bug 210005] New: Kernel stacktrace, Xorg freezes

2020-11-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210005 Bug ID: 210005 Summary: Kernel stacktrace, Xorg freezes Product: Drivers Version: 2.5 Kernel Version: 5.8.0-26-generic Hardware: Intel OS: Linux Tree: Mainlin

Re: [PATCH v2 1/4] drm/bridge: ti-sn65dsi86: Combine register accesses in ti_sn_aux_transfer()

2020-11-02 Thread Doug Anderson
Hi, On Thu, Oct 29, 2020 at 6:17 PM Stephen Boyd wrote: > > These register reads and writes are sometimes directly next to each > other in the register address space. Let's use regmap bulk read/write > APIs to get the data with one transfer instead of multiple i2c > transfers. This helps cut down

Re: [PATCH 1/3] drm/nouveau/kms/nv50-: Use state helper instead of crtc pointer

2020-11-02 Thread Ville Syrjälä
On Mon, Nov 02, 2020 at 02:38:32PM +0100, Maxime Ripard wrote: > dispnv50 references the crtc->state pointer in order to get the current > CRTC state in its atomic_check hook, which would be the old CRTC state in > the global atomic state. > > Use the drm_atomic_get_old_crtc_state helper to get th

Re: [PATCH 3/3] drm: Use the state pointer directly in atomic_check

2020-11-02 Thread Ville Syrjälä
On Mon, Nov 02, 2020 at 02:38:34PM +0100, Maxime Ripard wrote: > Now that atomic_check takes the global atomic state as a parameter, we > don't need to go through the pointer in the CRTC state. > > This was done using the following coccinelle script: > > @ crtc_atomic_func @ > identifier helpers;

Re: [PATCH v2 3/4] drm/bridge: ti-sn65dsi86: Read EDID blob over DDC

2020-11-02 Thread Doug Anderson
Hi, On Sun, Nov 1, 2020 at 11:21 AM Laurent Pinchart wrote: > > Hi Stephen, > > Thank you for the patch. > > On Thu, Oct 29, 2020 at 06:17:37PM -0700, Stephen Boyd wrote: > > Use the DDC connection to read the EDID from the eDP panel instead of > > relying on the panel to tell us the modes. > > >

Re: [PATCH 2/3] drm: Use state helper instead of CRTC state pointer

2020-11-02 Thread Ville Syrjälä
On Mon, Nov 02, 2020 at 02:38:33PM +0100, Maxime Ripard wrote: > Many drivers reference the crtc->pointer in order to get the current CRTC > state in their atomic_begin or atomic_flush hooks, which would be the new > CRTC state in the global atomic state since _swap_state happened when those > hook

[PATCH v7 1/3] dt-bindings: display: Document the Xylon LogiCVC display controller

2020-11-02 Thread Paul Kocialkowski
The Xylon LogiCVC is a display controller implemented as programmable logic in Xilinx FPGAs. Signed-off-by: Paul Kocialkowski Acked-by: Rob Herring --- .../display/xylon,logicvc-display.yaml| 313 ++ 1 file changed, 313 insertions(+) create mode 100644 Documentation/de

[PATCH v7 3/3] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2020-11-02 Thread Paul Kocialkowski
--- drivers/gpu/drm/logicvc/logicvc_drm.h | 3 + drivers/gpu/drm/logicvc/logicvc_layer.c | 143 +++- drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++ 3 files changed, 149 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.h b/drivers/gpu/drm/l

  1   2   3   >