Only OVL, RDMA,and WDMA get CMDQ client register information,
but all ddp component should work with CMDQ, so get this
information for all ddp component.

Signed-off-by: Chun-Kuang Hu <chunkuang...@kernel.org>
---
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 28 ++++++++++-----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c 
b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
index 8eba44be3a8a..c17c0e4c030f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
@@ -506,6 +506,20 @@ int mtk_ddp_comp_init(struct device *dev, struct 
device_node *node,
        if (IS_ERR(comp->clk))
                return PTR_ERR(comp->clk);
 
+#if IS_REACHABLE(CONFIG_MTK_CMDQ)
+       if (of_address_to_resource(node, 0, &res) != 0) {
+               dev_err(dev, "Missing reg in %s node\n", node->full_name);
+               return -EINVAL;
+       }
+       comp->regs_pa = res.start;
+
+       ret = cmdq_dev_get_client_reg(dev, &cmdq_reg, 0);
+       if (ret)
+               dev_dbg(dev, "get mediatek,gce-client-reg fail!\n");
+       else
+               comp->subsys = cmdq_reg.subsys;
+#endif
+
        /* Only DMA capable components need the LARB property */
        comp->larb_dev = NULL;
        if (type != MTK_DISP_OVL &&
@@ -531,20 +545,6 @@ int mtk_ddp_comp_init(struct device *dev, struct 
device_node *node,
 
        comp->larb_dev = &larb_pdev->dev;
 
-#if IS_REACHABLE(CONFIG_MTK_CMDQ)
-       if (of_address_to_resource(node, 0, &res) != 0) {
-               dev_err(dev, "Missing reg in %s node\n", node->full_name);
-               put_device(&larb_pdev->dev);
-               return -EINVAL;
-       }
-       comp->regs_pa = res.start;
-
-       ret = cmdq_dev_get_client_reg(dev, &cmdq_reg, 0);
-       if (ret)
-               dev_dbg(dev, "get mediatek,gce-client-reg fail!\n");
-       else
-               comp->subsys = cmdq_reg.subsys;
-#endif
        return 0;
 }
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to