Oh cool, I didn't know that. Thanks a bunch!
Andras
On 9/5/24 17:48, Jon Evans wrote:
It looks like you have already done so successfully at
https://gitlab.com/kicad/code/kicad/-/merge_requests/1992
Pipeline status has nothing to do with whether or not a merge request
can be reviewed or disc
FWIW, the failing SPICE tests *should* (TM) be fixed now.
> On 6 Sep 2024, at 01:48, Jon Evans wrote:
>
> It looks like you have already done so successfully at
> https://gitlab.com/kicad/code/kicad/-/merge_requests/1992
>
> Pipeline status has nothing to do with whether or not a merge reques
It looks like you have already done so successfully at
https://gitlab.com/kicad/code/kicad/-/merge_requests/1992
Pipeline status has nothing to do with whether or not a merge request can
be reviewed or discussed.
On Thu, Sep 5, 2024, 20:10 Andras Tantos wrote:
> I'm sorry for being so obtuse, b
I'm sorry for being so obtuse, but in that case how do I submit the
merge request to kick off the discussion?
Thanks,
Andras
On 9/5/24 16:34, 'Seth Hillbrand' via KiCad Developers wrote:
I wouldn't worry about the pipeline failing. Once we discuss the
change and decide to merge it, it is not
I wouldn't worry about the pipeline failing. Once we discuss the change
and decide to merge it, it is not an issue.
[image: KiCad Services Corporation Logo]
Seth Hillbrand
*Lead Developer*
+1-530-302-5483
Long Beach, CA
www.kipro-pcb.comi...@kipro-pcb.com
On Thu, Sep 5, 2024 at 10:53 AM And
Thanks! However it seems that the merge is blocked with the failing tests. How
can I get the request through even with the failures in place? (Apologies, I'm
new to this process, need some education.)
Thanks,
Andras
September 5, 2024 2:10 AM, "Jeff Young" wrote:
> It’s known to be acting up,
It’s known to be acting up, but we don’t know why yet (it seems to only occur
on some machines).
Note that devs can push your MR even if it’s failing tests, so it’s not a huge
issue.
Cheers,
Jeff.
> On 4 Sep 2024, at 22:56, Andras Tantos wrote:
>
> Hello!
>
> I'm trying to submit a pull re
Hello!
I'm trying to submit a pull request, but there are some failing merge
tests so the request is blocked. The test in question all boil down to
the following error:
/builds/andras_tantos/kicad/qa/tests/spice/test_library_spice.cpp(148):
error: in "SimLibrarySpice/Bjts": check param->valu
