FWIW, the failing SPICE tests *should* (TM) be fixed now.
> On 6 Sep 2024, at 01:48, Jon Evans <j...@craftyjon.com> wrote: > > It looks like you have already done so successfully at > https://gitlab.com/kicad/code/kicad/-/merge_requests/1992 > > Pipeline status has nothing to do with whether or not a merge request can be > reviewed or discussed. > > On Thu, Sep 5, 2024, 20:10 Andras Tantos <and...@tantosonline.com > <mailto:and...@tantosonline.com>> wrote: >> I'm sorry for being so obtuse, but in that case how do I submit the merge >> request to kick off the discussion? >> >> Thanks, >> Andras >> >> On 9/5/24 16:34, 'Seth Hillbrand' via KiCad Developers wrote: >>> I wouldn't worry about the pipeline failing. Once we discuss the change >>> and decide to merge it, it is not an issue. >>> >>> Seth Hillbrand >>> Lead Developer >>> +1-530-302-5483 >>> Long Beach, CA >>> www.kipro-pcb.com <https://www.kipro-pcb.com/> i...@kipro-pcb.com >>> <mailto:i...@kipro-pcb.com> >>> >>> On Thu, Sep 5, 2024 at 10:53 AM Andras Tantos <and...@tantosonline.com >>> <mailto:and...@tantosonline.com>> wrote: >>>> Thanks! However it seems that the merge is blocked with the failing tests. >>>> How can I get the request through even with the failures in place? >>>> (Apologies, I'm new to this process, need some education.) >>>> >>>> Thanks, >>>> Andras >>>> >>>> September 5, 2024 2:10 AM, "Jeff Young" <j...@rokeby.ie >>>> <mailto:j...@rokeby.ie>> wrote: >>>> >>>> > It’s known to be acting up, but we don’t know why yet (it seems to only >>>> > occur on some machines). >>>> > >>>> > Note that devs can push your MR even if it’s failing tests, so it’s not >>>> > a huge issue. >>>> > >>>> > Cheers, >>>> > Jeff. >>>> > >>>> >> On 4 Sep 2024, at 22:56, Andras Tantos <and...@tantosonline.com >>>> >> <mailto:and...@tantosonline.com>> wrote: >>>> >> >>>> >> Hello! >>>> >> >>>> >> I'm trying to submit a pull request, but there are some failing merge >>>> >> tests so the request is >>>> >> blocked. The test in question all boil down to the following error: >>>> >> >>>> >>> /builds/andras_tantos/kicad/qa/tests/spice/test_library_spice.cpp(148): >>>> >>> error: in >>>> >>> "SimLibrarySpice/Bjts": check param->value == fmt::format( >>>> >>> "{}000.0{}M", i % 10, i % 10 >>>> >>> <https://www.google.com/maps/search/i+%25+10,+i+%25+10?entry=gmail&source=g> >>>> >>> ) has >>>> >>> failed [100.001E+07 != 1000.01M] >>>> >>> Failure occurred in a following context: >>>> >>> Model index: 1, Model name: _1_PNP_VBIC, Model device type: PNP, Model >>>> >>> type: VBIC >>>> >>> Param name: ver >>>> >> >>>> >> I don't believe this failure has anything to do with my change plus the >>>> >> values are actually >>>> >> numerically the same, only the representation is different. Is it a >>>> >> known issue? If so, how can I >>>> >> unblock myself? If not, is the expected behavior the correct one? >>>> >> >>>> >> Thanks, >>>> >> Andras >>>> >> >>>> >> -- >>>> >> You received this message because you are subscribed to the Google >>>> >> Groups "KiCad Developers" group. >>>> >> To unsubscribe from this group and stop receiving emails from it, send >>>> >> an email to >>>> >> devlist+unsubscr...@kicad.org <mailto:devlist%2bunsubscr...@kicad.org>. >>>> >> To view this discussion on the web visit >>>> >> https://groups.google.com/a/kicad.org/d/msgid/devlist/21622c86-44d4-48c7-ae2a-29fd4c5babaa@tantosonl >>>> >> ne.com <http://ne.com/>. >>>> > >>>> > -- >>>> > You received this message because you are subscribed to the Google >>>> > Groups "KiCad Developers" group. >>>> > To unsubscribe from this group and stop receiving emails from it, send >>>> > an email to >>>> > devlist+unsubscr...@kicad.org <mailto:devlist%2bunsubscr...@kicad.org>. >>>> > To view this discussion on the web visit >>>> > https://groups.google.com/a/kicad.org/d/msgid/devlist/f2f231ff-893b-40d3-b480-49eaa932d...@rokeby.ie >>>> >>>> -- >>>> You received this message because you are subscribed to the Google Groups >>>> "KiCad Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send an >>>> email to devlist+unsubscr...@kicad.org >>>> <mailto:devlist%2bunsubscr...@kicad.org>. >>>> To view this discussion on the web visit >>>> https://groups.google.com/a/kicad.org/d/msgid/devlist/d4bdc22ac2c21f8a716fbe1428c5a8b8%40tantosonline.com. >>> -- >>> You received this message because you are subscribed to the Google Groups >>> "KiCad Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to devlist+unsubscr...@kicad.org >>> <mailto:devlist+unsubscr...@kicad.org>. >>> To view this discussion on the web visit >>> https://groups.google.com/a/kicad.org/d/msgid/devlist/CAFdeG-q87GLO-Ug2-mj3dcmGKojZzNXpDv_mn1fEUHiBSQH%3DXQ%40mail.gmail.com >>> >>> <https://groups.google.com/a/kicad.org/d/msgid/devlist/CAFdeG-q87GLO-Ug2-mj3dcmGKojZzNXpDv_mn1fEUHiBSQH%3DXQ%40mail.gmail.com?utm_medium=email&utm_source=footer>. >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "KiCad Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to devlist+unsubscr...@kicad.org >> <mailto:devlist+unsubscr...@kicad.org>. >> To view this discussion on the web visit >> https://groups.google.com/a/kicad.org/d/msgid/devlist/0990aed1-2ca0-4f9d-82e5-7fe3cc844ee0%40tantosonline.com >> >> <https://groups.google.com/a/kicad.org/d/msgid/devlist/0990aed1-2ca0-4f9d-82e5-7fe3cc844ee0%40tantosonline.com?utm_medium=email&utm_source=footer>. > > > -- > You received this message because you are subscribed to the Google Groups > "KiCad Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to devlist+unsubscr...@kicad.org <mailto:devlist+unsubscr...@kicad.org>. > To view this discussion on the web visit > https://groups.google.com/a/kicad.org/d/msgid/devlist/CA%2BqGbCDQw0Y_kQRtvis72T28i6_9DNEk4K4%2ByzEmRHjaQDwBFQ%40mail.gmail.com > > <https://groups.google.com/a/kicad.org/d/msgid/devlist/CA%2BqGbCDQw0Y_kQRtvis72T28i6_9DNEk4K4%2ByzEmRHjaQDwBFQ%40mail.gmail.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "KiCad Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to devlist+unsubscr...@kicad.org. To view this discussion on the web visit https://groups.google.com/a/kicad.org/d/msgid/devlist/83649300-B81B-4CF8-98C2-E2CE58409013%40rokeby.ie.
