Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 03:32:40PM +0200, Udo van den Heuvel via devel wrote: > On 01-08-19 15:24, Udo van den Heuvel via devel wrote: > > The script will exit with nonzero exit code, rendering the build failed. > > When trying to work around this in my spec file, I use: > pathfix.py -pni "%{__pyt

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 04:18:30PM +0200, Udo van den Heuvel wrote: > The build shows otherwise, else there would not be an error. > Or did I miss a step in the build process? See https://gitlab.com/NTPsec/ntpsec/commit/3ee8e4c3c3cf4b2d6f010874e7f447a23a1710cf for the change that we made to our

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 04:31:52PM +0200, Udo van den Heuvel wrote: > On 01-08-19 16:27, Matthew Selsky wrote: > > On Thu, Aug 01, 2019 at 04:18:30PM +0200, Udo van den Heuvel wrote: > > > > See > > https://gitlab.com/NTPsec/ntpsec/commit/3ee8e4c3c3cf4b2d6f010874e7f447a23a1710cf > > for the chan

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 05:02:58PM +0200, Udo van den Heuvel wrote: > On 01-08-19 16:39, Udo van den Heuvel via devel wrote: > > The 1.1.6 code does not. > > The workaround now works when I use the pathfix.py line with this > addition: %{buildroot}%{_sbindir}/* > > The whole SPEC then looks like

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Thu, Aug 01, 2019 at 07:19:02PM +0200, Udo van den Heuvel wrote: > On 01-08-19 19:00, Matthew Selsky wrote: > > You may need to specifically use %{__python3} when you call "waf" in the 2 > > places in the %build section. > > So maybe not use --python=%{__python3} for waf? "--python" should no

Re: 1.1.6 build fails on FC30

2019-08-01 Thread Matthew Selsky via devel
On Fri, Aug 02, 2019 at 06:31:34AM +0200, Udo van den Heuvel wrote: > Builds successfully after adapting the directories in the %files section. Excellent! > URL: http://www.ntpsec.org > Requires(post): systemd-units > Requires(preun): systemd-units > Requires(postun): systemd-units > BuildRequir

Re: ✘NTS and ALPN

2019-08-19 Thread Matthew Selsky via devel
On Mon, Aug 19, 2019 at 06:33:52PM -0700, Gary E. Miller via devel wrote: > For some reason GitLab has not allowed me to merge from their web pages > for a few weeks. I have to merge manually... Hi Gary, Sounds like you ran into https://gitlab.com/gitlab-org/gitlab-ee/issues/12686 I'm not sure

Re: Point release of NTPSec

2019-08-23 Thread Matthew Selsky via devel
On Fri, Aug 23, 2019 at 02:12:21PM -0400, Eric S. Raymond via devel wrote: > Sanjeev Gupta : > > We need a point release. Significant things that have happened recently: > > > > > >- The g and G suffixes > >- Removal of neoclock4x > >- Some doc changes > >- The ALPN change > > >

Re: gitlab testing broken for Fedora

2019-08-24 Thread Matthew Selsky via devel
On Sat, Aug 24, 2019 at 02:42:08AM -0700, Hal Murray via devel wrote: > Stage: build > Name: fedora-rawhide-refclocks-gpsd > Trace: GPG Keys are configured as: > file:///etc/pki/rpm-gpg/RPM-GPG-KEY-fedora- > 31-x86_64 > Public key for glibc-common-2.30.9000-1.fc32.x86_64.rpm is not installed. >

Re: %m, #614

2019-08-26 Thread Matthew Selsky via devel
On Mon, Aug 26, 2019 at 04:55:48PM -0700, Gary E. Miller via devel wrote: > _GNU_SOURCE should not always be defined, but it does need to be defined > in certain cases. For example, on glibc < 2.10, you need to define > it to get strnlen() and struct ifreq. > > From glibc 2.10, you instead need _

Re: waf checking - fail on warnings?

2019-08-27 Thread Matthew Selsky via devel
On Mon, Aug 26, 2019 at 10:51:58PM -0700, Hal Murray via devel wrote: > > A relatively quick search suggests mandatory=True as an argument. > > That makes waf fail if the code chunk doesn't work. You want "mandatory=False" since this is a probe, not a requirement. And you want to pass "-Werror"

Re: ✘Warnings on OSX

2019-08-31 Thread Matthew Selsky via devel
On Fri, Aug 30, 2019 at 08:01:59PM -0700, Fred Wright via devel wrote: > > On Thu, 29 Aug 2019, Gary E. Miller via devel wrote: > > > Warnings on OSX: > > > > [ 73/131] Compiling libntp/ntp_calendar.c > > ../../ntpd/ntp_control.c:2612:27: warning: format specifies type 'unsigned > > short' but

Re: 'ntpq -c ":config"' does not work (it probably never did)

2019-09-10 Thread Matthew Selsky via devel
On Mon, Sep 09, 2019 at 08:46:26AM -0700, James Browning via devel wrote: >While working on a script, I stumbled across this issue. the cmd.Cmd >class does not call its precmd function from its onecmd function in >either Python 2.7 or 3.6. I see several possible paths forward. > >1

Re: Cruft

2019-09-17 Thread Matthew Selsky via devel
On Sun, Sep 15, 2019 at 06:18:47PM -0700, Hal Murray via devel wrote: > > There are various #ifdefs testing RLIMIT_MEMLOCK and friends > > The Linux man page for setrlimit says: >getrlimit(), setrlimit(): POSIX.1-2001, POSIX.1-2008, SVr4, 4.3BSD. > So I think we can assume it exists and r

Re: Cruft

2019-09-17 Thread Matthew Selsky via devel
On Tue, Sep 17, 2019 at 08:42:18PM -0700, Hal Murray wrote: > > Can you partially revert ... > > I thought I had fixed it. Have you done a recent pull? Is the current code > still broken? Only thing left to revert is missing guards near "switch (rl_what) {" near line 3630 in ntpd/ntp_config.h

Re: Cruft

2019-09-17 Thread Matthew Selsky via devel
On Tue, Sep 17, 2019 at 09:39:15PM -0700, Hal Murray wrote: > > Only thing left to revert is missing guards near "switch (rl_what) {" > > near line 3630 in ntpd/ntp_config.h > > The whole point of this change was to get rid of ifdefs that weren't needed > because the symbols they were checking ar

Re: ntploggps not installed by waf

2019-09-21 Thread Matthew Selsky via devel
On Sat, Sep 21, 2019 at 01:09:30PM -0700, Paul Theodoropoulos via devel wrote: >On 9/21/2019 13:00 PM, James Browning wrote: > > On Sat, Sep 21, 2019, 12:55 PM Paul Theodoropoulos via devel > <[1]devel@ntpsec.org> wrote: > >Just a quick note, as I'm vetting all my installati

Re: 1.1.8 build error

2019-12-01 Thread Matthew Selsky via devel
On Sun, Dec 01, 2019 at 10:45:28AM +0100, Udo van den Heuvel via devel wrote: > On 01-12-2019 10:14, Udo van den Heuvel via devel wrote: > > The macro _wrong_version_format_terminate_build can be used to work > > around this issue: > > Perhaps also in this way: > > rpmbuild -bb --define '_wrong_v

Re: What's name for the gitlab thing that checks post-push and sends yes/no mail?

2019-12-16 Thread Matthew Selsky via devel
On Mon, Dec 09, 2019 at 11:35:05AM -0800, Hal Murray via devel wrote: > > I haven't seen that mail recently. Authors are emailed for failed pipelines See https://docs.gitlab.com/ee/ci/pipelines.html We also email specific users for failed pipelines. See https://gitlab.com/NTPsec/ntpsec/-/servi

Re: Python, testing

2020-01-13 Thread Matthew Selsky via devel
On Mon, Jan 13, 2020 at 05:06:01PM -0800, Hal Murray via devel wrote: > How does waf tell the c compiler which Python.h to use? > My system has: > /usr/include/python2.7/Python.h > /usr/include/python3.7m/Python.h ./waf --python=/path/to/python OR /path/to/python waf > What can we do about

Re: Python, testing

2020-01-13 Thread Matthew Selsky via devel
On Mon, Jan 13, 2020 at 05:06:01PM -0800, Hal Murray via devel wrote: > A year or 2 ago, I put together a script to test as many build time options > as > I thought reasonable. It's in ./tests/option-tester.sh > > Does anybody other than me use it? > > It's a bit of a CPU hog -- too much to r

Re: Does cross compiling work?

2020-01-26 Thread Matthew Selsky via devel
On Mon, Jan 20, 2020 at 11:53:44AM -0800, Hal Murray via devel wrote: > If so, can somebody send me an example script. See https://gitlab.com/NTPsec/ntpsec/blob/master/.gitlab-ci.yml#L450 and https://gitlab.com/NTPsec/ntpsec/blob/master/INSTALL.adoc#user-content-cross-compiling Cheers, -Matt __

Re: waf help: OPENSSL_VERSION_NUMBER from openssl/opensslv.h

2020-03-24 Thread Matthew Selsky via devel
On Tue, Mar 24, 2020 at 12:40:42PM -0700, Hal Murray via devel wrote: > I'd like to check the OpenSSL version number and give a sensible error > message > rather than some mumbo jumble from the compiler. I would model the check that we removed in https://gitlab.com/NTPsec/ntpsec/-/commit/6d179

Re: Bye bye TLS 1.2

2020-03-26 Thread Matthew Selsky via devel
On Thu, Mar 26, 2020 at 12:57:33PM -0700, Hal Murray via devel wrote: > I just pushed the change. Can we bring back support of older OpenSSL releases for builds that don't need NTS support? OpenSSL 1.0.2 is supported via paid extended support per https://www.openssl.org/policies/releasestrat.ht

Re: CI stuff is broken: gentoo-hardened-basic

2020-04-21 Thread Matthew Selsky via devel
On Tue, Apr 21, 2020 at 04:57:04PM +, Robin H. Johnson via devel wrote: > Can you please log the IP of the host you used that did not have the > file? > > distfiles.gentoo.org is a bouncer with many mirrors Hi Robin, We call "emerge-webrsync" in our CI. Are you asking us to log the output o

BSD-4-Clause-UC license usage

2020-04-29 Thread Matthew Selsky via devel
Hi Hal and team, Much our of NTS code uses BSD-4-Clause-UC instead of BSD-2-Clause (our preferred license for new code). What this license selection intentional? Is BSD-4-Clause-UC intended for code owned by the University of California, or does it make sense for others to use this license as

Re: BSD-4-Clause-UC license usage

2020-04-30 Thread Matthew Selsky via devel
On Thu, Apr 30, 2020 at 08:03:26PM +0800, Sanjeev Gupta wrote: >Hal, >I have sent in a MR, >https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1121 >for your review. Hi Sanjeev! I submitted https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1122 before I saw this. My MR also updat

Re: Pre-release cleanup

2020-09-02 Thread Matthew Selsky via devel
On Wed, Sep 02, 2020 at 08:53:41AM -0400, Eric S. Raymond via devel wrote: > Sanjeev Gupta : > > They support *any* git repository. > > Huh. Their docs are out of date, then. I tried adding our GitLab repo today and I get an error message that new GitLab repos have been disabled by the site adm

Re: Pre-release cleanup

2020-09-02 Thread Matthew Selsky via devel
I also previously setup Codacy in order to see what other SAST systems could do. See https://app.codacy.com/gl/NTPsec/ntpsec/dashboard Let me know what you think. If either are useful, I'll integrate them more tightly in our workflows. Thanks, -Matt

Re: Runtime testing, What's the CI environment like?

2020-10-02 Thread Matthew Selsky via devel
On Sun, Sep 06, 2020 at 06:18:40PM -0500, Richard Laager via devel wrote: > On 9/6/20 5:43 PM, Hal Murray via devel wrote: > > Anybody using the modem driver? > > I tested in November, for fun, not any practical reason. NIST's service > is still up. The USNO service was dead. I emailed them and re

Re: Missing build bots for tags, websites down.

2020-12-21 Thread Matthew Selsky via devel
Hi James, >We currently do not have builders for the tags freebsd-11, freebsd-12, and >ubuntu-1604-lts. It would appear that in the late unpleasantness that the >builders detached. This should be fixable by having the >builders admin(s) reattach them in the settings. It should be p

Re: Missing build bots for tags, websites down.

2020-12-22 Thread Matthew Selsky via devel
On Mon, Dec 21, 2020 at 06:48:39PM +, Matthew Selsky via devel wrote: > www.ntpsec.org was moved back to GitLab pages and it should be working now. > docs.ntpsec.org is still pending some work by GitLab support. GL support fixed docs.ntpsec.org per https://gitlab.com/gitlab-com/gl

Re: Fw: New Defects reported by Coverity Scan for ntpsec

2021-01-27 Thread Matthew Selsky via devel
On Mon, Jan 25, 2021 at 03:21:10PM -0800, James Browning via devel wrote: >Someone twisted a knob somewhere A new client for Coverity was released and it's more picky than the old client apparently. See https://scan.coverity.com/ "Coverity Upgrade to 2020.09" Thanks, -Matt ___

Re: New email address

2021-06-15 Thread Matthew Selsky via devel
On Mon, Jun 14, 2021 at 11:27:06PM -0700, Hal Murray via devel wrote: > > I think I've updated the mailing lists, but hmur...@ntpsec.org forwards to my > old email and I can't figure out how to change that. > > My notes include: > https://devel.ntpsec.org/settings/panel/email/ > but that host

Re: Using Go for NTPsec

2021-06-29 Thread Matthew Selsky via devel
On Tue, Jun 29, 2021 at 04:41:30PM -0400, Eric S. Raymond via devel wrote: > Well, first, the historical target for accuracy of WAN time service is > more than an order of magnitude higher than 1ms. The worst-case jitter > that could add would be barely above the measurement-noise floor at worst,

Re: waf: --disable-attic

2022-02-15 Thread Matthew Selsky via devel
On Tue, Feb 15, 2022 at 01:16:26PM -0800, Hal Murray via devel wrote: > > I have a simple patch that will turn off building things in attic/ > > Should we make off be the default and change that to --enable-attic? Hi Hal, Are we worried about the speed of the build, lack of build support on pa

Re: Wildcards on NTS certificates -- security

2022-03-01 Thread Matthew Selsky via devel
On Fri, Feb 25, 2022 at 12:02:34PM -0800, Gary E. Miller via devel wrote: > Yo Hal! > > On Tue, 22 Feb 2022 14:39:21 -0800 > Hal Murray via devel wrote: > > > They don't work. See https://gitlab.com/NTPsec/ntpsec/-/issues/729 > > > > There is a single line of code that disables them. > > > >

Re: Release, wildcards, etc

2022-04-28 Thread Matthew Selsky via devel
On Fri, Apr 22, 2022 at 12:13:25AM -0700, Hal Murray via devel wrote: > nts nowildcards at the top level to set the default > nowildcards at the server level > wildcardsOK at the server level to override the default Hi Hal, Sorry, I'm not following what you mean here. Do you have a patch or merg

Re: devel/make-tarball broken

2022-12-15 Thread Matthew Selsky via devel
On Wed, Dec 14, 2022 at 03:39:29PM -0800, James Browning via devel wrote: > 'Do not apply transform to symbolic link targets' [1] Which I > got from googling 'gnu tar transform' IIRC. It is also a > gnuism, but I do not see a portable transform type option as > tar on macOS uses -s and some BSDs s

Release coming, take 2

2022-12-15 Thread Matthew Selsky via devel
Hi all, I plan to cut a release on Thu 12/22/2022. I'm sorry about the delays in getting this release out the door. If there's anything that absolutely must be in this release and can't wait until the next release, please let me know. Otherwise, I plan to tidy up the NEWS file as needed and

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Matthew Selsky via devel
On Mon, Feb 06, 2023 at 10:51:02PM -0800, Hal Murray via devel wrote: > > > Do you have a coverity account? > > https://scan.coverity.com > > Then go to "My Dashboard" and "Add project". > > Should we document that? Where? The account creation seems self-explanatory. Or did you want to document

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-08 Thread Matthew Selsky via devel
On Wed, Feb 08, 2023 at 11:16:53AM -0800, Gary E. Miller via devel wrote: > The coverity scans are not part of the GitLab CI. They run off the > GitHub mirror. The GitLab CI triggers the scan. See https://gitlab.com/NTPsec/ntpsec/-/pipeline_schedules Coverity then points at GitHub for some rea

Re: Does anybody use (aka test) MDNS?

2023-03-31 Thread Matthew Selsky via devel
Hi Hal, I do not use it. My servers are all configured directly in ntp.conf Thanks, -Matt ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: [Git][NTPsec/ntpsec][master] 3 commits: Minor cleanups to restrict

2023-07-05 Thread Matthew Selsky via devel
Hi Hal, >• [10]libntp/pymodule-mac.c > >══ > > ... ... @@ -143,6 +143,10 @@ void do_mac(char *name, > 143 143 *maclen = 0; > 144 144 return; > 145 145 } >

Re: NTPsec 1.2.2a released

2023-08-04 Thread Matthew Selsky via devel
On Thu, Aug 03, 2023 at 11:38:25PM -0700, Hal Murray wrote: > Should that also go to users@ and devel@? I'll do this shortly. Thanks, -Matt ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: NTPsec 1.2.2a released

2023-08-04 Thread Matthew Selsky via devel
On Fri, Aug 04, 2023 at 01:47:29PM -0700, Fred Wright via devel wrote: > And for that matter, what exactly is 1.2.2a, given that there's no git tag > for that version? Hi Fred, 1.2.2a is 1.2.2 + the 2 line patch to avoid the crash. We'll release 1.2.3 in late August with all of the changes in

NTPsec 1.2.2a released

2023-08-04 Thread Matthew Selsky via devel
The NTPsec Project is pleased to announce the tagging of version 1.2.2a * Fix a crash in ntpd if NTS is disabled and an NTS-enabled client request (mode 3) is received. (CVE-2023-4012) #794 For other changes since the previous release, please consult the project NEWS.adoc file at https://gitlab

Re: NTPsec 1.2.2a released

2023-08-07 Thread Matthew Selsky via devel
On Mon, Aug 07, 2023 at 02:14:40PM -0500, Richard Laager via devel wrote: > That said, I did advocate for merging it back in to master (as a no-op). But > I don't feel particularly strongly about that. The code fix itself is already in master. I'll merge the 1.2.2a NEWS into master later this e

Re: Is python2 dead?

2023-09-04 Thread Matthew Selsky via devel
On Mon, Sep 04, 2023 at 02:25:46PM -0700, Gary E. Miller via devel wrote: > From RHEL: > > "The RHEL 8 AppStream Lifecycle Page puts the end date of RHEL 8's > Python 2.7 package at June 2024." > > https://access.redhat.com/solutions/4455511 Hi Gary, Is the implication that we can safely drop

Re: I just pushed ntsstats and ntskestats

2023-09-26 Thread Matthew Selsky via devel
On Mon, Sep 25, 2023 at 04:29:37PM -0700, Hal Murray via devel wrote: > I have a slight preference for double, but it doesn't really matter. > > I've seen some example with double on the left bar and single on the > top/bottom. > That was probably the web version. Hi Hal, Do you have an exampl

Re: What's magic about /tmp/? ntpd can't find UNIX socket

2023-10-18 Thread Matthew Selsky via devel
On Wed, Oct 18, 2023 at 09:37:06PM -0700, Hal Murray via devel wrote: > I put the samba socket in /tmp/ > ntpd couldn't see it. My test programs work fine. > > 18 Oct 20:52:00 ntpd[5671]: SIGND: can not connect socket > '/tmp/fake-samba-socket/socket': No such file or directory > > What's magi

Re: What's magic about /tmp/? ntpd can't find UNIX socket

2023-10-19 Thread Matthew Selsky via devel
On Thu, Oct 19, 2023 at 02:27:56PM -0700, Hal Murray via devel wrote: > It works fine from my test program. What's different about ntpd? Hi Hal, Are you running ntpd with --jaildir (or -i) or some chroot-like functionality? Cheers, -Matt ___ devel ma

Re: Time for a release?

2023-10-30 Thread Matthew Selsky via devel
On Sun, Oct 29, 2023 at 10:50:56PM -0700, Hal Murray via devel wrote: > > The last time this was suggested, I encouraged waiting until we fixed mssntp. > Well, I think we have it fixed but we haven't found anybody to test it. Sounds good. Can you please update NEWS.adoc with mssntp and other ne

Re: [Git][NTPsec/ntpsec][master] Fix mode 6 client to round up to 4 bytes (was 8)

2023-11-27 Thread Matthew Selsky via devel
On Sun, Nov 26, 2023 at 11:43:14PM +, Hal Murray (--- via vc wrote: > Hal Murray pushed to branch master at [1]NTPsec / ntpsec > > Commits: > > • [2]d98ce8d7 >by Hal Murray at 2023-11-26T15:42:51-08:00 > > Fix mode 6 client to round up to 4 bytes (was 8) > > 1 change

Re: Release

2023-12-05 Thread Matthew Selsky via devel
On Sat, Dec 02, 2023 at 08:09:00PM -0800, Hal Murray wrote: > > I think you should release what we have as soon as it is convenient. > > There are many more things I would like to include but we aren't making much > progress so it's time to do it. Hi Hal, Sounds good. I'll aim to release ~15-D

Re: Release

2023-12-18 Thread Matthew Selsky via devel
On Sun, Dec 17, 2023 at 08:17:23PM -0800, Fred Wright via devel wrote: Hi Fred, > The main issue I've found is that the "struct var" in ntp_control.c, is > relying on anonymous unions, which are a relatively new language feature. > They were originally a GNU extension, eventually becoming officia

Re: Release

2023-12-28 Thread Matthew Selsky via devel
On Wed, Dec 06, 2023 at 01:56:51AM +, Matthew Selsky via devel wrote: > Sounds good. I'll aim to release ~15-Dec-2023. Hi all, Sorry for the delays. I have a release candidate tarball available: https://ftp.ntpsec.org/pub/releases/ntpsec-1.2.3rc1.tar.gz https://ftp.ntpsec.org/pub/

Re: NTPsec 1.2.3 released

2024-01-02 Thread Matthew Selsky via devel
On Tue, Jan 02, 2024 at 07:21:39PM -0800, Fred Wright via devel wrote: Hi Fred, > There are a couple of minor issues that I should have noticed in the RC but > didn't: > > 1) The 1.2.2a entry is missing from NEWS. This is presumably because of the > way the patch release was forked off of the m

Re: NTPsec 1.2.3 released

2024-01-03 Thread Matthew Selsky via devel
On Tue, Jan 02, 2024 at 08:55:38PM -0800, Fred Wright via devel wrote: > That explains it. I don't subscribe to the announce list, based on the > expectation that announcements would be cross-posted here. Cross-posting > only needs to be done by the sender, while cross-subscribing would need to

Re: NTPsec 1.2.3 released

2024-01-03 Thread Matthew Selsky via devel
On Tue, Jan 02, 2024 at 08:52:53PM -0800, Fred Wright via devel wrote: > It should, though if the timestamps get updated in the process it would > trade bad name ordering for bad timestamp ordering. The ideal thing would > be to fix the names but keep the original timestamps. Three of the four >

Re: More SNMP dependency questions, also assertions.

2017-05-01 Thread Matthew Selsky via devel
On Sun, Apr 30, 2017 at 12:34:35PM -0500, Ian Bruene via devel wrote: > Ah, ok. The info I saw made it sound as if daemonization was > something even masters > found tricky. Conveniently there is a library and PEP on how to do > it right. :-) Hey Ian, Do you intend to make this an snmp agent

Re: More SNMP dependency questions, also assertions.

2017-05-01 Thread Matthew Selsky via devel
On Mon, May 01, 2017 at 09:50:48PM -0400, Matthew Selsky via devel wrote: > Do you intend to make this an snmp agent that would run under an existing > net-snmp daemon and communicate via the AgentX (RFC2741) protocol? Or are > you thinking of a stand-alone snmp daemon? https://g

Re: Building with seccomp

2017-05-15 Thread Matthew Selsky via devel
On Sat, May 13, 2017 at 10:10:23PM -0700, Hal Murray via devel wrote: > > If you are missing a library or header, --enable-seccomp gives a warning but > doesn't bail. Should that be changed? > > There are 3 seccomp symbols setup in config.h > #define ENABLE_SECCOMP 1 /* Enable seccomp */ >

Re: Building with seccomp

2017-05-16 Thread Matthew Selsky via devel
On Mon, May 15, 2017 at 12:02:15PM -0700, Hal Murray wrote: > > devel@ntpsec.org said: > > HAVE_SECCOMP can likely be replaced with HAVE_SECCOMP_H in the code. > > That seems backwards. HAVE_SECCOMP_H says (to me) that you have the header. > You may not have the library and/or maybe seccomp wa

dns debugging messages?

2017-05-18 Thread Matthew Selsky via devel
Hey Hal, Is this DNS debugging intended for syslog when I build without "--enable-debug"? $ ./waf configure $ sudo ./build/main/ntpd/ntpd -g -p /run/ntpd.pid $ syslog shows: 2017-05-19T05:28:57.546+00:00 host.example.com ntpd[19012]: ntpd ntpsec-0.9.7+616 2017-05-15T08:59:02-0400: Starting 2017

Re: NTPsec on MIPSbe

2017-05-23 Thread Matthew Selsky via devel
On Tue, May 23, 2017 at 11:59:24AM -0700, Hal Murray via devel wrote: > If you are keeping track... > > It builds and runs on a 32 bit PowerPC MAC-Mini, both Debian and FreeBSD. > > #define WORDS_BIGENDIAN 1 > > There are problems with the firmware setting up the time keeping parameters > incor

Re: USE_PACKET_TIMESTAMP

2017-06-08 Thread Matthew Selsky via devel
On Thu, Jun 08, 2017 at 12:26:21AM -0700, Hal Murray via devel wrote: > Can anybody confirm that Solaris really doesn't have time stamps? I thought > we decided that all modern OSes did. That's why we could rip out the SIGIO > stuff. > > I took a quick google and couldn't find any mention of a

Re: Fw: [Git][NTPsec/ntpsec][master] Replace "uint" with "unsigned int"

2017-06-09 Thread Matthew Selsky via devel
On Fri, Jun 09, 2017 at 11:43:20AM -0700, Gary E. Miller via devel wrote: > Yo Matt! > > > Commits: > > 0430e6a7 by Matt Selsky at 2017-06-08T23:42:39-04:00 > > Replace 'uint' with 'unsigned int' > > I always thought 'unsigned int' was overly verbose. How about > simply 'unsigned'? Hey Gary, I

Re: ✘Build failure

2017-09-02 Thread Matthew Selsky via devel
Hey Eric/Gary: Are there extra options we should pass to ./waf configure to catch these types of errors in our gitlab bots? I'm happy to update our .gitlab-ci.yml to do extra checking so we detect these before users do. Thanks, -Matt ___ devel mailin

Re: ✘Prevent potential buffer overruns in the mode 6 code.

2017-09-04 Thread Matthew Selsky via devel
On Mon, Mar 13, 2017 at 12:11:47PM -0700, Gary E. Miller wrote: > Yo Ertic! > > > cp = buffer; > cq = tag; > - while (*cq != '\0') > + while (*cq != '\0' && cp < buffer + sizeof(buffer) - 1) > *cp++ = *cq++; > > > Why not just use strlcpy? NTPsec has its own c

Re: NetBSD 6.1.5 doesn't have ldexpl in math.h

2017-09-08 Thread Matthew Selsky via devel
On Thu, Sep 07, 2017 at 12:47:42PM -0700, Gary E. Miller via devel wrote: > Yo Hal! > > On Thu, 07 Sep 2017 01:37:30 -0700 > Hal Murray wrote: > > > > Got a workaround? > > > > This seems to build and check: > > #include/* ldexpl() */ > > #ifndef ldexpl > > /* Missing in NetBSD 6.1

Re: Python Library Cleanups

2017-09-26 Thread Matthew Selsky via devel
On Tue, Sep 26, 2017 at 07:30:02PM -0400, Eric S. Raymond via devel wrote: > Gary E. Miller via devel : > > > 2. Gary files a bug upstream to the Python devs detailing how > > > get_python_lib() is implicated in FHS nonconformance. Gary, you > > > willing? > > > > I'm feeling like a broken record.

Re: ifdefs: O_NONBLOCK O_NOCTTY TIOCMGET

2017-11-06 Thread Matthew Selsky via devel
On Sat, Nov 04, 2017 at 10:22:25PM -0700, Hal Murray via devel wrote: > > While looking at some code, I noticed several symbols that are sometimes > protected with an ifdef and sometimes assumed to exist. > > I think they are all required by POSIX, and thus the ifdefs are not needed. > > Is the

Re: Help debugging gitlab and/or shell script

2017-11-25 Thread Matthew Selsky via devel
On Fri, Nov 24, 2017 at 06:44:29AM -0500, Eric S. Raymond via devel wrote: > Hal Murray via devel : > > I can't figure out what it is trying to tell me. There is no "local" in my > > script. It works on my CentOS 6 system. Note that it is git complaining. > > My script does waf builds, no git

Re: utmpx, git/issue 411

2017-12-03 Thread Matthew Selsky via devel
On Wed, Nov 22, 2017 at 06:12:16PM -0800, Hal Murray via devel wrote: > Why did you decide to remove the utmpx stuff? @Eric: I didn't see an answer to this... Thanks, -Matt ___ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo

Re: What am I supposed to do about an Internal server error from GitLab?

2017-12-05 Thread Matthew Selsky via devel
On Mon, Dec 04, 2017 at 10:38:13PM -0800, Hal Murray via devel wrote: > > Subject: ntpsec | Pipeline #14729097 has failed for master | 3c1cc3c8 > From: GitLab > > Commit: 3c1cc3c8 ( https://gitlab.com/NTPsec/ntpsec/commit/3c1cc3c8317faa48ce8 > e5b8ef7909c16cb04deab ) > Commit Message: Fix ntpq -

Re: Preparing for a point release

2017-12-06 Thread Matthew Selsky via devel
On Tue, Dec 05, 2017 at 12:35:34PM -0800, Hal Murray via devel wrote: > > If you want to do a quick release, then we should backport critical fixes. I > assume that turns into a branch in git. Amen. We should release 1.0.1 that just includes the ntpq fix and the AWS fix (and any other critica

Re: Preparing for a point release

2017-12-06 Thread Matthew Selsky via devel
On Wed, Dec 06, 2017 at 12:14:18PM -0500, Eric S. Raymond wrote: > Matthew Selsky via devel : > > On Tue, Dec 05, 2017 at 12:35:34PM -0800, Hal Murray via devel wrote: > > > > > > If you want to do a quick release, then we should backport critical > > > fixes

Re: Testing

2017-12-06 Thread Matthew Selsky via devel
On Wed, Dec 06, 2017 at 12:25:14PM -0500, Eric S. Raymond via devel wrote: > I have a different plan. I always write doc patches as part of my > change commits; my discipline is to prevent code and docs from getting out > of sync in the first place. Does everyone on the project do that? This "p

Re: Testing

2017-12-19 Thread Matthew Selsky via devel
On Wed, Dec 06, 2017 at 02:49:07PM -0500, Eric S. Raymond wrote: > Matthew Selsky via devel : > > On Wed, Dec 06, 2017 at 12:25:14PM -0500, Eric S. Raymond via devel wrote: > > > > > I have a different plan. I always write doc patches as part of my > > > ch

Re: Python libs on Debian/Raspbian

2017-12-19 Thread Matthew Selsky via devel
On Tue, Dec 19, 2017 at 09:00:48PM -0600, Richard Laager via devel wrote: > On 12/19/2017 07:50 PM, Gary E. Miller via devel wrote: > > I think we're on the same page. > > > I) waf could install a file in /usr/local/etc to tell ntpsec Python > > programs where to look. > > How does the utility k

Re: Python libs on Debian/Raspbian

2017-12-19 Thread Matthew Selsky via devel
On Tue, Dec 19, 2017 at 08:23:08PM -0800, Gary E. Miller via devel wrote: > Also, remember that we have the contraint where the user may have all four > of these installed: > > /usr, /usr/lib, ~user, gitclone. If you have a .pth, then you can no > longer use waf to run regression tests on the gi

Re: What is GitLab trying to tell me?

2017-12-19 Thread Matthew Selsky via devel
On Tue, Dec 19, 2017 at 04:17:07AM -0800, Hal Murray via devel wrote: > I can't find an useful error message. Where am I supposed to look? > > > Your pipeline has failed. > ... > Commit: e869f3ce ( https://gitlab.com/NTPsec/ntpsec/commit/e869f3ce9c2c6221cee > ca1b0d8f7b5559f4dd9dc ) > ... > Pipe

Re: DESTDIRMime-Version: 1.0

2017-12-21 Thread Matthew Selsky via devel
On Wed, Dec 20, 2017 at 04:26:13PM -0800, Gary E. Miller via devel wrote: > Clearly no one here knows how this works at the moment We load the "gnu_dirs" feature from waf. See https://github.com/waf-project/waf/blob/master/waflib/Tools/gnu_dirs.py#L14 for the list of variables set. Cheers,

Re: Testing

2017-12-21 Thread Matthew Selsky via devel
On Wed, Dec 20, 2017 at 02:50:55PM -0800, Gary E. Miller via devel wrote: > Yo Matthew! > > On Tue, 19 Dec 2017 23:05:37 -0500 > Matthew Selsky via devel wrote: > > > > If dev with merge-approver power pushes to a branch and then merges > > > it, how is the e

Re: Does ntpq have a command line history mechanism?

2017-12-22 Thread Matthew Selsky via devel
On Fri, Dec 22, 2017 at 06:42:00AM -0500, Eric S. Raymond via devel wrote: > Hal Murray via devel : > > > > I was expecting one, but I get things like this: > > ntpq> ^[[A^[[A^[[B > > ***Command `' ambiguous > > ntpq> > > > > That was up-arrow, up-arrow, down-arrow > > > > Is there some package

Re: What is .gitlab-ci.yml?

2017-12-25 Thread Matthew Selsky via devel
On Sun, Dec 24, 2017 at 11:14:32PM -0800, Hal Murray via devel wrote: > and/or where is it documented and/or why is it part of the git source tree? See https://docs.gitlab.com/ce/ci/yaml/README.html > It contains many lines like this one: > - python -m unittest discover -s build/main/tests/py

Re: Do we want ./waf dist?

2017-12-25 Thread Matthew Selsky via devel
On Sat, Dec 23, 2017 at 08:11:31PM -0800, Hal Murray via devel wrote: > > devel/make-tarball looks better to me? waf dist is a built-in function of waf. devel/make-tarball is something we wrote. We can merge our script into waf dist... or not. ___ de

Re: Python test coverage readout

2018-01-05 Thread Matthew Selsky via devel
On Fri, Jan 05, 2018 at 08:17:18AM -0600, Ian Bruene via devel wrote: > > How can I get a detailed report on the new python test coverage check? And how > robust is it: does it only count the percentage of functions tested, or can it > tell what parts of a function are being exercised? > > 91% is

Re: Crypto, passwords

2018-01-05 Thread Matthew Selsky via devel
On Fri, Jan 05, 2018 at 01:32:24AM -0800, Hal Murray via devel wrote: > > Does anybody use shared keys between NTP servers? I do. I use md5 keys on a private network, but I don't require clients to use them. > What other types should we test and/or suggest people use? The docs claim to suppor

Re: Version strings

2018-01-08 Thread Matthew Selsky via devel
On Mon, Jan 08, 2018 at 01:41:49PM -0800, Hal Murray via devel wrote: > >> Maybe it's time to move ntpviz and the logging > >> stuff to a separate package. > > > How does that help? > > Then they could have their own version string policy rather than getting > tangled up with ntpsec's policy and

Re: Python test coverage readout

2018-01-08 Thread Matthew Selsky via devel
On Fri, Jan 05, 2018 at 11:37:15AM -0500, Matthew Selsky wrote: > On Fri, Jan 05, 2018 at 08:17:18AM -0600, Ian Bruene via devel wrote: > > > > How can I get a detailed report on the new python test coverage check? And > > how > > robust is it: does it only count the percentage of functions teste

Re: Version strings

2018-01-08 Thread Matthew Selsky via devel
On Mon, Jan 08, 2018 at 02:06:18PM -0800, Hal Murray wrote: > > > Long-term, I'd like to simplify and just do the same git checks within waf > > itself. > > It's got to work without git, and it has to get the same checksum when built > from git or tarball. I think that means you have to stash

Re: Version strings

2018-01-08 Thread Matthew Selsky via devel
On Mon, Jan 08, 2018 at 08:07:53PM -0600, Richard Laager via devel wrote: > On 01/08/2018 07:58 PM, Richard Laager wrote: > >> There was similar discussion of waf editing man pages to get the date on > >> the > >> bottom left corner. > > Since I already learned a bunch about waf substitutions for

Re: Crypto, passwords

2018-01-10 Thread Matthew Selsky via devel
On Fri, Jan 05, 2018 at 09:04:38AM -0800, Hal Murray wrote: > > Are you modifying things, or just looking? > For example, ntpq -p doesn't require a password. Sorry for the delayed reply. I only run ntpq -p and other read-only operations. Thanks, -Matt __

Re: crypto stuff is broken with old versions of OpenSSL

2018-02-17 Thread Matthew Selsky via devel
On Thu, Feb 15, 2018 at 04:46:59AM -0800, Hal Murray via devel wrote: > > Should be fixed now. Hey Hal, What version of openssl was failing to build? Is it a version that's still supported upstream by the OpenSSL project? waf checks for OpenSSL > 0.9.7d...because that's what Classic did. Any

Re: Should we just remove the broadcast option?

2018-02-20 Thread Matthew Selsky via devel
On Wed, Feb 21, 2018 at 03:25:52AM +, Mark Atwood via devel wrote: > I think all modern Windows machines get their address from their domain > controller, or from ntp?.microsoft.com Per https://docs.microsoft.com/en-us/windows-server/identity/ad-ds/get-started/windows-time-service/accurate-ti

Re: More gitlab quirks: What is this trying to tell me?

2018-02-27 Thread Matthew Selsky via devel
On Tue, Feb 27, 2018 at 01:18:10PM -0800, Hal Murray via devel wrote: > > Yeah, it pushes the web pages. > > Should I just ignore it? > > Or tell somebody? If so, who? What would they do? > > Any idea why I'm getting pairs of messages? gitlab infrax flakiness... This CI job is at https://gi

Re: More gitlab quirks: What is this trying to tell me?

2018-02-27 Thread Matthew Selsky via devel
On Tue, Feb 27, 2018 at 06:39:32PM -0500, Matthew Selsky via devel wrote: > On Tue, Feb 27, 2018 at 01:18:10PM -0800, Hal Murray via devel wrote: > > > Yeah, it pushes the web pages. > > > > Should I just ignore it? > > > > Or tell somebody? If so, who? W

Re: prep for 1.0.1

2018-02-27 Thread Matthew Selsky via devel
On Wed, Feb 21, 2018 at 02:10:25AM -0600, Richard Laager via devel wrote: > On 02/20/2018 09:19 PM, Eric S. Raymond via devel wrote: > > I'll get on the tracker and swat a bunch of small issues I see. > > I'd like to suggest the following: > > 1) Move #55 out of 1.0.0 milestone. > 2) Close the 0.

  1   2   >