Hi Hal, > • [10]libntp/pymodule-mac.c > > ══════════════════════════════════════════════════════════════════════════ > > ... ... @@ -143,6 +143,10 @@ void do_mac(char *name, > 143 143 *maclen = 0; > 144 144 return; > 145 145 } > 146 + /* Coverity CID 462307, 2023 June 11 > 147 + * CMAC API is undocumented and deprecated in OpenSSL 3. > 148 + * See libntp/macencrypt.c */ > 149 + /* coverity[checked_return] */ > 146 150 CMAC_Update(cmac_ctx, data, (unsigned int)datalen); > 147 151 CMAC_Final(cmac_ctx, mac, maclen); > 148 152 if (MAX_MAC_LENGTH < *maclen)
I think this needs to be "coverity[CHECKED_RETURN]". The man pages for CMAC_Update document that the return is either 0 or 1. Do we want to check this return code? > • [12]tests/unity/unity.c > > ══════════════════════════════════════════════════════════════════════════ > > ... ... @@ -1002,6 +1002,7 @@ void UnityAssertFloatSpecial(const > UNITY_FLOAT actual, > 1002 1002 is_trait = !isinf(actual) && !isnan(actual); > 1003 1003 break; > 1004 1004 > 1005 + case UNITY_FLOAT_INVALID_TRAIT: /* Supress warning */ > 1005 1006 default: /* including UNITY_FLOAT_INVALID_TRAIT */ > 1006 1007 trait_index = 0; > 1007 1008 trait_names[0] = UnityStrInvalidFloatTrait; > ... ... @@ -1142,6 +1143,7 @@ void UnityAssertDoubleSpecial(const > UNITY_DOUBLE actual, > 1142 1143 is_trait = !isinf(actual) && !isnan(actual); > 1143 1144 break; > 1144 1145 > 1146 + case UNITY_FLOAT_INVALID_TRAIT: /* Supress warning */ > 1145 1147 default: /* including UNITY_FLOAT_INVALID_TRAIT */ > 1146 1148 trait_index = 0; > 1147 1149 trait_names[0] = UnityStrInvalidFloatTrait; Has this fix been submitted upstream to https://github.com/ThrowTheSwitch/Unity? Thanks, -Matt _______________________________________________ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel
