Re: ✘NTS and ALPN

2019-08-20 Thread Hal Murray via devel
>>> But, it will break existing NTPsec NTS. So upgrade to git head now >>> if you use NTS. >> What's the nature of the breakage? > The ALPN changed to what the other NTS implementations are using. I think I see what's going on. Our NTS client doesn't check the ALPN string from the server. So a

Re:˜NTS and ALPN

2019-08-20 Thread Hal Murray via devel
> Is there some plan to have more than one NTS protocol?? ALPN also lets you negotiate different versions of the same protocol. I doubt there are any near-term plans for a new version but we will want the extra loop (or equivalent) if/when we ever implement a new version of NTS. I'm happy to wa

Re: ✘NTS and ALPN

2019-08-20 Thread Gary E. Miller via devel
Yo Achim! On Tue, 20 Aug 2019 21:22:13 +0200 Achim Gratz via devel wrote: > Gary E. Miller via devel writes: > >> Dan's patch removed > >> collapsed the internal list to a single element that is already > >> stripped of its length byte, > > > > Yes. That was intentional. > > As a hotpatch

Re: ✘NTS and ALPN

2019-08-20 Thread Achim Gratz via devel
Gary E. Miller via devel writes: >> Dan's patch removed >> collapsed the internal list to a single element that is already >> stripped of its length byte, > > Yes. That was intentional. As a hotpatch (and demonstration oof the issue) it's OK, as a longterm fix not. All IMHO of course. Btw, I'd

Re: ✘NTS and ALPN

2019-08-20 Thread Gary E. Miller via devel
Yo Achim! On Tue, 20 Aug 2019 21:01:42 +0200 Achim Gratz via devel wrote: > Gary E. Miller via devel writes: > >> That is making things work for now where there's only one single > >> thing to negotiate, but it will break later on. I've posted what > >> I believe is the correct patch quite some

Re: ✘NTS and ALPN

2019-08-20 Thread Achim Gratz via devel
Gary E. Miller via devel writes: >> That is making things work for now where there's only one single thing >> to negotiate, but it will break later on. I've posted what I believe >> is the correct patch quite some time ago. > > What would break? How? The callback is supposed to traverse two list

Re: ✘NTS and ALPN

2019-08-20 Thread Achim Gratz via devel
James Browning via devel writes: >> I have attached a reformatted variant which should apply to the >> current git head. Achim, would you could look at it and see if I >> messed it up somehow. > > I hate gmail sometimes... Not seeing any attachment… anyway, if you want to switch gears from one pa

Re: ✘NTS and ALPN

2019-08-20 Thread Gary E. Miller via devel
Yo James! On Tue, 20 Aug 2019 11:43:04 -0700 James Browning wrote: > > What would break? How? Can you resend the patch? > > > > Achims patch -> > https://lists.ntpsec.org/pipermail/devel/2019-July/008508.html That answers the last question. What about the other two? I see this commen in

Re: ✘NTS and ALPN

2019-08-20 Thread James Browning via devel
On Tue, Aug 20, 2019 at 11:43 AM James Browning wrote: > On Tue, Aug 20, 2019 at 10:55 AM Gary E. Miller via devel < > devel@ntpsec.org> wrote: > >> Yo Achim! >> >> On Tue, 20 Aug 2019 19:52:07 +0200 >> Achim Gratz via devel wrote: >> >> > Gary E. Miller via devel writes: >> > > I just pushed Da

Re: ✘NTS and ALPN

2019-08-20 Thread Gary E. Miller via devel
Yo Achim! On Tue, 20 Aug 2019 19:52:07 +0200 Achim Gratz via devel wrote: > Gary E. Miller via devel writes: > > I just pushed Dan Drown's patch for the ALPN. That allows NTPsec to > > interoperate with other NTS implementations. > > That is making things work for now where there's only one

Re: ✘NTS and ALPN

2019-08-20 Thread Achim Gratz via devel
Gary E. Miller via devel writes: > I just pushed Dan Drown's patch for the ALPN. That allows NTPsec to > interoperate with other NTS implementations. That is making things work for now where there's only one single thing to negotiate, but it will break later on. I've posted what I believe is the

Re: ✘NTS and ALPN

2019-08-20 Thread Gary E. Miller via devel
Yo Hal! On Mon, 19 Aug 2019 21:28:13 -0700 Hal Murray wrote: > > But, it will break existing NTPsec NTS. So upgrade to git head now > > if you use NTS. > > What's the nature of the breakage? The ALPN changed to what the other NTS implementations are using. RGDS GARY --

Re: ✘NTS and ALPN

2019-08-20 Thread Gary E. Miller via devel
Yo Sanjeev! On Tue, 20 Aug 2019 14:34:02 +0800 Sanjeev Gupta via devel wrote: > I upgraded to git head. What should I see differrent? Some clients not from NTPsec should now be able to connect when before they could not. So hard for us to see when we only run NTPsec. RGDS GARY --

Re: ✘NTS and ALPN

2019-08-19 Thread Hal Murray via devel
> But, it will break existing NTPsec NTS. So upgrade to git head now if you > use NTS. What's the nature of the breakage? -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo/d

Re: ✘NTS and ALPN

2019-08-19 Thread Gary E. Miller via devel
Yo Paul! On Mon, 19 Aug 2019 20:03:06 -0700 Paul Theodoropoulos via devel wrote: > Forgive my ignorance here, but - what does the stylized 'X' in the > subject line signify? It only means that I set the original subject. I started doing it to make it easier for me to see threads that I started

Re: ✘NTS and ALPN

2019-08-19 Thread Paul Theodoropoulos via devel
Forgive my ignorance here, but - what does the stylized 'X' in the subject line signify? I've only run across it here on the ntpsec list and the gpsd list... On 8/19/2019 18:49 PM, Gary E. Miller via devel wrote: Yo Matthew! On Tue, 20 Aug 2019 01:42:50 + Matthew Selsky wrote: On Mon,

Re: ✘NTS and ALPN

2019-08-19 Thread James Browning via devel
On Mon, Aug 19, 2019 at 6:49 PM Gary E. Miller via devel wrote: > Yo Matthew! > > On Tue, 20 Aug 2019 01:42:50 + > Matthew Selsky wrote: > > > I'm not sure why Dan's fork of the repo doesn't have jobs enabled... > > Every MR I have looked at on gpsd and ntpsec. > I am not a member of gpsd/g

Re: ✘NTS and ALPN

2019-08-19 Thread Gary E. Miller via devel
Yo Matthew! On Tue, 20 Aug 2019 01:42:50 + Matthew Selsky wrote: > On Mon, Aug 19, 2019 at 06:33:52PM -0700, Gary E. Miller via devel > wrote: > > > For some reason GitLab has not allowed me to merge from their web > > pages for a few weeks. I have to merge manually... > > Sounds like y

Re: ✘NTS and ALPN

2019-08-19 Thread Matthew Selsky via devel
On Mon, Aug 19, 2019 at 06:33:52PM -0700, Gary E. Miller via devel wrote: > For some reason GitLab has not allowed me to merge from their web pages > for a few weeks. I have to merge manually... Hi Gary, Sounds like you ran into https://gitlab.com/gitlab-org/gitlab-ee/issues/12686 I'm not sure

Re: ✘NTS and ALPN

2019-08-19 Thread Richard Laager via devel
On 8/19/19 8:33 PM, Gary E. Miller via devel wrote: > I just pushed Dan Drown's patch for the ALPN. That allows NTPsec to > interoperate with other NTS implementations. > > But, it will break existing NTPsec NTS. So upgrade to git head now if > you use NTS. Can we get a point release soon, plea

✘NTS and ALPN

2019-08-19 Thread Gary E. Miller via devel
Yo All! I just pushed Dan Drown's patch for the ALPN. That allows NTPsec to interoperate with other NTS implementations. But, it will break existing NTPsec NTS. So upgrade to git head now if you use NTS. For some reason GitLab has not allowed me to merge from their web pages for a few weeks.