Gary E. Miller via devel writes: >> That is making things work for now where there's only one single thing >> to negotiate, but it will break later on. I've posted what I believe >> is the correct patch quite some time ago. > > What would break? How?
The callback is supposed to traverse two lists (one from the foreign party and an internal one) of possible protocols. Dan's patch removed collapsed the internal list to a single element that is already stripped of its length byte, so it doesn't conform to the ALPN data structure description anymore. Consequently it also omits any code to traverse the internal list, both of which will come back to bite you when you do need to support the second protocol. The previous changes introduced by Hal also check for things that the API clearly state need not be checked (there is explicit guidance that the callback we implement can assume the syntactic structure of the input data is correct). > Can you resend the patch? https://lists.ntpsec.org/pipermail/devel/2019-July/008508.html Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf microQ V2.22R2: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada _______________________________________________ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo/devel
