Re: Review request: python-flask-sqlalchemy-light

2024-11-17 Thread Peter Lemenkov
Hey! I've just reviewed this. Could you please review any of these? * https://bugzilla.redhat.com/2324138 python-eth-rlp - RLP definitions for common Ethereum objects in Python * https://bugzilla.redhat.com/2324137 python-eth-keyfile - Tools for handling the encrypted keyfile format used to store

Re: Review request for python-durationpy

2024-11-06 Thread Jason Montleon
Thank you for the PR, I have merged it. -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/

Re: Review request for python-durationpy

2024-11-06 Thread Miro Hrončok
On 04. 11. 24 20:48, Jason Montleon wrote: Hi, python-durationpy is a new dependency of python-kubernetes, so I need to package it in order to continue updating python-kubernetes. I am happy to review a package in return if it also helps someone else get unblocked. Bugzilla URL: https://bugzi

Re: Review request for python-durationpy

2024-11-06 Thread Peter Lemenkov
Thank you! On Tue, Nov 5, 2024 at 6:00 PM Jason Montleon wrote: > > Thank you for the review! I will start reviewing these for you this evening! > -- > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le.

Re: Review request for python-durationpy

2024-11-05 Thread Jason Montleon
Thank you for the review! I will start reviewing these for you this evening! -- ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraprojec

Re: Review request for python-durationpy

2024-11-04 Thread Peter Lemenkov
Hey! I've just reviewed this tiny one. Could you please grab one of these: * https://bugzilla.redhat.com/2321898 - python-rlp - A Python implementation of Recursive Length Prefix encoding * https://bugzilla.redhat.com/2321899 - python-eth-keys - A common API for Ethereum key operations * https://b

Re: Review Request: python-reflink: python reflink wraps around platform specific reflink implementations

2024-08-24 Thread Peter Lemenkov
Hello! Almost done - check my review. In the mean time can I ask you for a favour? If you have a free time could you please consider reviewing this my small Python package: * https://bugzilla.redhat.com/2305963 - python-multiaddr - Multiaddr implementation in Python On Fri, Aug 23, 2024 at 10:22 

Re: Review request: mingw-vulkan-volk

2024-08-04 Thread Sandro Mani
Hi Probably yes, but that would need to be done also for spirv-{headers,tools}, glslang, and vulkan-{headers,validation-layers,tools,utility-libraries} to ensure that the entire vulkan-sdk is updated consistently. For now, with my current available cycles, I'd prefer to just import mingw-vulk

Re: Review request: mingw-vulkan-volk

2024-08-04 Thread Peter Lemenkov
Hello! Would it be better to add MIngw-related bits to vulkan-volk package? On Sat, Aug 3, 2024 at 10:38 PM Sandro Mani wrote: > > Hi > > mingw-vulkan-tools grew a dependency on vulkan-volk, which I've prepared > for review here: > > https://bugzilla.redhat.com/show_bug.cgi?id=2302650 > > It is a

Re: Review request for gmobile

2024-06-09 Thread Robert-André Mauchin
On 08/06/2024 07:09, Tomi Lähteenmäki wrote: Hi, I sent a review request for gmobile [1] a bit over two weeks ago. The gmobile is written in C and it is dependency of phosh and phoc and upcoming phrog package. If someone would have time to review the request it would be great. -Tomi [1]

Re: Review request: python-libgravatar

2024-05-07 Thread Kai A. Hiller
Hi Sandro, I’ll take the review. Would be glad if you looked at rust-ulid (https://bugzilla.redhat.com/show_bug.cgi?id=2278199). Best wishes Kai On 07/05/2024 09.04, Sandro Mani wrote: Hi pgadmin4 grew a dependency on python-libgravatar, which I've posted for review here: https://bugzilla.

Re: Review request: mruby

2024-04-17 Thread Jarek Prokop
On 4/17/24 11:38 AM, Marián Konček wrote: Nice catch, using it and removing the line "conf.enable_debug" makes the build use the proper flags. However, I still don't know how to tell Rake to add a `-Wl,-soname,...` option to each .so separately. Check out `build_config/default.rb`. It has a l

Re: Review request: mruby

2024-04-17 Thread Marián Konček
Nice catch, using it and removing the line "conf.enable_debug" makes the build use the proper flags. However, I still don't know how to tell Rake to add a `-Wl,-soname,...` option to each .so separately. On 16. 4. 2024 18:11, Jarek Prokop wrote: On 4/16/24 4:16 PM, Marián Konček wrote: https

Re: Review request: mruby

2024-04-16 Thread Jarek Prokop
On 4/16/24 4:16 PM, Marián Konček wrote: https://bugzilla.redhat.com/show_bug.cgi?id=2275294 I applied downstream changes which build a shared object (upstream provides no way of doing so, only a static library). Upstream provides many ways to compile to many targets including using solibs,

Re: [Review-request] rsms-inter-fonts

2023-12-08 Thread Neal Gompa
On Fri, Dec 8, 2023 at 4:05 AM Luya Tshimbalanga wrote: > > Hello team, > > I am looking for a packager to review the package rsms-inter-fonts used as > default by Blender 3D software. > > https://bugzilla.redhat.com/show_bug.cgi?id=2253619 > > The spec is straightforward as it uses the fonts tem

Re: Review Request: aespipe - AES encrypting or decrypting pipe

2023-10-26 Thread Neal Gompa
On Thu, Oct 26, 2023 at 10:59 AM Jiri Hladky wrote: > > Hi, > > Review Request: aespipe - AES encrypting or decrypting pipe > https://bugzilla.redhat.com/show_bug.cgi?id=2244729 > > Spec URL: https://jhladky.fedorapeople.org/aespipe.spec > SRPM URL: https://jhladky.fedorapeople.org/aespipe-2.4g-1.

Re: Review request: jedit

2023-08-03 Thread Vascom
I will take it. чт, 3 авг. 2023 г., 19:24 Zdeněk Žamberský : > Hello, > > review request (jedit): > https://bugzilla.redhat.com/show_bug.cgi?id=2228918 > > reviewers welcome :) > thanks > > -- > Zdeněk Žamberský > OpenJDK QE > Red Hat > ___ > devel mail

Re: Review request for oclock package (orphaned since F35)

2023-05-14 Thread Globe Trotter via devel
Kevin, oclock was not updated, and Beson's email made me realize that I could go an do it myself. I did that by the time you check. slim's was updated and both packages are now in testing. Best, Ranjan On Sunday, May 14, 2023 at 10:49:44 AM CDT, Kevin Fenzi wrote: On Sun, May 14, 2

Re: Review request for oclock package (orphaned since F35)

2023-05-14 Thread Kevin Fenzi
On Sun, May 14, 2023 at 02:04:57PM +0300, Benson Muite wrote: > Ranjan, > > On 5/14/23 13:46, Globe Trotter via devel wrote: > > Thanks! The package was cleared  on BZ some time ago. Is there some > > additional review that is needed? > > > Sorry, that is correct. Usually state is set to post. I

Re: Review request for oclock package (orphaned since F35)

2023-05-14 Thread Benson Muite
Ranjan, On 5/14/23 13:46, Globe Trotter via devel wrote: > Thanks! The package was cleared  on BZ some time ago. Is there some > additional review that is needed? > Sorry, that is correct. Usually state is set to post. It seems to have been unretired: https://pagure.io/releng/issue/11417 Though

Re: Review request for oclock package (orphaned since F35)

2023-05-14 Thread Sandro
On 14-05-2023 12:40, Benson Muite wrote: It seems it is just the review that is needed: The re-review is done: https://bugzilla.redhat.com/show_bug.cgi?id=2025138 Releng unretiring the package is the next step, really. -- Sandro ___ devel mailing l

Re: Review request for oclock package (orphaned since F35)

2023-05-14 Thread Globe Trotter via devel
Benson, Thanks! The package was cleared  on BZ some time ago. Is there some additional review that is needed? Best wishes, Ranjan On Sunday, May 14, 2023 at 05:41:35 AM CDT, Benson Muite wrote: Hi Ranjan, Thanks for contributing to Fedora and maintaining packages. On 5/14/23 03:27,

Re: Review request for oclock package (orphaned since F35)

2023-05-14 Thread Sandro
On 14-05-2023 00:45, Globe Trotter via devel wrote: Thanks, Sandro! How does one ping in the ticket on paguire? The easiest way is to just leave a comment in the ticket. If you need info from a specific person you would tag that person (@fas_user). That ensures people watching the ticket queu

Re: Review request for oclock package (orphaned since F35)

2023-05-14 Thread Benson Muite
Hi Ranjan, Thanks for contributing to Fedora and maintaining packages. On 5/14/23 03:27, Globe Trotter via devel wrote: > Thanks, Kevin! No  problem, no rush, I did not quite know what to expect, > hence the questions. Thanks again! > > It seems it is just the review that is needed: https://do

Re: Review request for oclock package (orphaned since F35)

2023-05-13 Thread Globe Trotter via devel
Thanks, Kevin! No  problem, no rush, I did not quite know what to expect, hence the questions. Thanks again! On Saturday, May 13, 2023 at 06:12:33 PM CDT, Kevin Fenzi wrote: On Sat, May 13, 2023 at 02:41:10AM +0200, Sandro wrote: > On 11-05-2023 17:57, Globe Trotter via devel wrote:

Re: Review request for oclock package (orphaned since F35)

2023-05-13 Thread Kevin Fenzi
On Sat, May 13, 2023 at 02:41:10AM +0200, Sandro wrote: > On 11-05-2023 17:57, Globe Trotter via devel wrote: > > Still no movement on my unretire requests for both slim and oclock, not > > even a request for additional information. > > Tags have been added to the ticket. So, it has come up in on

Re: Review request for oclock package (orphaned since F35)

2023-05-13 Thread Globe Trotter via devel
Thanks, Sandro! How does one ping in the ticket on paguire? On Friday, May 12, 2023 at 07:41:47 PM CDT, Sandro wrote: On 11-05-2023 17:57, Globe Trotter via devel wrote: > Still no movement on my unretire requests for both slim and oclock, not even > a request for additional information.

Re: Review request for oclock package (orphaned since F35)

2023-05-12 Thread Sandro
On 11-05-2023 17:57, Globe Trotter via devel wrote: Still no movement on my unretire requests for both slim and oclock, not even a request for additional information. Tags have been added to the ticket. So, it has come up in one of the meetings. Supposedly, no-one has found the time yet to wo

Re: Review request for oclock package (orphaned since F35)

2023-05-11 Thread Globe Trotter via devel
Still no movement on my unretire requests for both slim and oclock, not even a request for additional information. On Sunday, May 7, 2023 at 10:50:42 AM CDT, Sandro wrote: On 07-05-2023 17:34, Globe Trotter via devel wrote: > How long does it take to unretire a package? I was thinking th

Re: Review request for oclock package (orphaned since F35)

2023-05-07 Thread Globe Trotter via devel
I see, thanks! I had indeed forgotten that the previous request had been closed. On Sunday, May 7, 2023 at 10:50:42 AM CDT, Sandro wrote: On 07-05-2023 17:34, Globe Trotter via devel wrote: > How long does it take to unretire a package? I was thinking that it > was automatic, but I have n

Re: Review request for oclock package (orphaned since F35)

2023-05-07 Thread Sandro
On 07-05-2023 17:34, Globe Trotter via devel wrote: How long does it take to unretire a package? I was thinking that it was automatic, but I have not received any notification yet. Did this request last evening. I don't think it's fully automated. It's a member of the releng team that has to p

Re: Review request for oclock package (orphaned since F35)

2023-05-07 Thread Globe Trotter via devel
How long does it take to unretire a package? I was thinking that it was automatic, but I have not received any notification yet. Did this request last evening. On Saturday, May 6, 2023 at 07:25:30 PM CDT, Globe Trotter via devel wrote: Thank you for this. I got: fedpkg import ~/rpmb

Re: Review request for oclock package (orphaned since F35)

2023-05-06 Thread Globe Trotter via devel
Thank you for this. I got: fedpkg import ~/rpmbuild/SRPMS/oclock-1.0.4-4.fc37.src.rpm Removing no longer used file: dead.package Could not execute import_srpm: This package or module is retired. The action has stopped. so I guess I have request unretirement. I thought I did it sometime ago, but

Re: Review request for oclock package (orphaned since F35)

2023-05-06 Thread Sandro
On 06-05-2023 23:43, Sandro wrote: On 06-05-2023 19:36, Globe Trotter via devel wrote: Can someone please review the oclock package? This was orphaned after F35, and I packaged it for myself, and then would like to put it up. It was tentatively approved, but never finally done so. Thanks! Look

Re: Review request for oclock package (orphaned since F35)

2023-05-06 Thread Sandro
On 06-05-2023 19:36, Globe Trotter via devel wrote: Can someone please review the oclock package? This was orphaned after F35, and I packaged it for myself, and then would like to put it up. It was tentatively approved, but never finally done so. Thanks! Looks like the package is approved. The

Re: Review request for oclock package (orphaned since F35)

2023-05-06 Thread Globe Trotter via devel
Sorry, forgot the BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2025138 On Saturday, May 6, 2023 at 12:36:20 PM CDT, Globe Trotter wrote: Can someone please review the oclock package? This was orphaned after F35, and I packaged it for myself, and then would like to put it up. It was

Re: Review request for oclock package (orphaned since F35)

2023-05-06 Thread Globe Trotter via devel
Can someone please review the oclock package? This was orphaned after F35, and I packaged it for myself, and then would like to put it up. It was tentatively approved, but never finally done so. Thanks! On Tuesday, November 23, 2021 at 02:43:00 PM CST, Björn Persson wrote: Ben Beasley

Re: [Review request] gnome-shell-extension-screen-autorotate

2023-04-07 Thread Luya Tshimbalanga
Here is the fixed link for review: https://bugzilla.redhat.com/show_bug.cgi?id=2183901 Thanks On 2023-04-02 20:02, Luya Tshimbalanga wrote: Hello team, I packaged gnome-shell-extension-screen-autorotate needed for 2-in-1 device running on GNOME Shell. The spec file should adhere to the new

Re: Review Request: ImageMagick7

2022-12-07 Thread Neal Gompa
On Wed, Dec 7, 2022 at 4:26 AM Tomáš Popela wrote: > > Hi Neal, > > On Tue, Dec 6, 2022 at 5:15 PM Neal Gompa wrote: >> >> Yes, the EOL period is further out, but I'd rather make it so that the >> next RHEL will have ImageMagick 7 right from the beginning. > > > Just to be transparent: ImageMagic

Re: Review Request: ImageMagick7

2022-12-07 Thread Tomáš Popela
Hi Neal, On Tue, Dec 6, 2022 at 5:15 PM Neal Gompa wrote: > Yes, the EOL period is further out, but I'd rather make it so that the > next RHEL will have ImageMagick 7 right from the beginning. > Just to be transparent: ImageMagick (or GraphicsMagick) won't be in RHEL 10 (or in any future versio

Re: Review Request: ImageMagick7

2022-12-06 Thread Sérgio Basto
On Tue, 2022-12-06 at 11:22 -0500, PGNet Dev wrote: > > > As I said earlier in the thread: of the 25 reverse dependencies of > > the > > ImageMagick libraries, only five don't build[1]. > > > > Further analysis indicates that dvdauthor has a patch in > > openSUSE[2], > > but the fix breaks suppor

Re: Review Request: ImageMagick7

2022-12-06 Thread Neal Gompa
On Tue, Dec 6, 2022 at 11:30 AM Kevin Kofler via devel wrote: > > Neal Gompa wrote: > > While that is true, *I* don't like doing that if I don't have to. I'd > > rather try to get things fixed upstream in tandem. Upstreams tend to > > appreciate that in my experience. :) > > Sure, but it tends to

Re: Review Request: ImageMagick7

2022-12-06 Thread Kevin Kofler via devel
Neal Gompa wrote: > While that is true, *I* don't like doing that if I don't have to. I'd > rather try to get things fixed upstream in tandem. Upstreams tend to > appreciate that in my experience. :) Sure, but it tends to be significantly more work. Upstreams need to support several platforms at

Re: Review Request: ImageMagick7

2022-12-06 Thread PGNet Dev
As I said earlier in the thread: of the 25 reverse dependencies of the ImageMagick libraries, only five don't build[1]. Further analysis indicates that dvdauthor has a patch in openSUSE[2], but the fix breaks support for GraphicsMagick as an alternative. I want to rework that patch so it doesn'

Re: Review Request: ImageMagick7

2022-12-06 Thread Neal Gompa
On Tue, Dec 6, 2022 at 10:49 AM Kevin Kofler via devel wrote: > > Neal Gompa wrote: > > There are actually > > other packages I could fix in Fedora with patches from openSUSE or > > PLD, but they need more work to not break compatibility with building > > with GraphicsMagick (which these packages

Re: Review Request: ImageMagick7

2022-12-06 Thread Neal Gompa
On Tue, Dec 6, 2022 at 10:17 AM Michael Cronenworth wrote: > > On 12/6/22 8:31 AM, Neal Gompa wrote: > > There's a very important difference between September 2017 and now: we > > know someone else already did it! > > Great. Good luck. > > > As an aside: I don't appreciate the "high horse" comment

Re: Review Request: ImageMagick7

2022-12-06 Thread Kevin Kofler via devel
Neal Gompa wrote: > There are actually > other packages I could fix in Fedora with patches from openSUSE or > PLD, but they need more work to not break compatibility with building > with GraphicsMagick (which these packages in question support), so > using IM6 there for now is fine while that gets

Re: Review Request: ImageMagick7

2022-12-06 Thread Michael Cronenworth
On 12/6/22 8:31 AM, Neal Gompa wrote: There's a very important difference between September 2017 and now: we know someone else already did it! Great. Good luck. As an aside: I don't appreciate the "high horse" comment, considering during most of this discussion, I was doing the work and evalu

Re: Review Request: ImageMagick7

2022-12-06 Thread Neal Gompa
On Tue, Dec 6, 2022 at 8:26 AM Michael Cronenworth wrote: > > On 12/5/22 5:41 PM, Neal Gompa wrote: > > But in general, it looks like an upgrade to ImageMagick 7 will be > > rather easy to do. > > Hi Neal, > > I appreciate your eagerness here, but it is a little misled. > > Version 7 is radically

Re: Review Request: ImageMagick7

2022-12-06 Thread Michael Cronenworth
On 12/5/22 5:41 PM, Neal Gompa wrote: But in general, it looks like an upgrade to ImageMagick 7 will be rather easy to do. Hi Neal, I appreciate your eagerness here, but it is a little misled. Version 7 is radically different than version 6. Most (I don't have an exact figure) packages in Fe

Re: Review Request: ImageMagick7

2022-12-06 Thread Nico Kadel-Garcia
On Sat, Dec 3, 2022 at 5:57 AM Vitaly Zaitsev via devel wrote: > > On 03/12/2022 00:30, Sérgio Basto wrote: > > The proposal now is to keep ImageMagick 6 and make a new package with > > ImageMagick 7 , when we have all applications use only ImageMagick 7, > > we move the sources from ImageMagick7

Re: Review Request: ImageMagick7

2022-12-06 Thread Sérgio Basto
On Sun, 2022-12-04 at 21:06 -0600, Richard Shaw wrote: > On Sun, Dec 4, 2022 at 6:32 PM Sérgio Basto > wrote: > > Final statement, instead of wasting my time and energy on > > arguments, > > Imagemagick7 could already be built on rawhide if someone had done > > the > > package review for me > > >

Re: Review Request: ImageMagick7

2022-12-05 Thread Neal Gompa
On Mon, Dec 5, 2022 at 6:38 PM Emmanuel Seyman wrote: > > * Neal Gompa [04/12/2022 22:26] : > > > > Smooge challenged me earlier in this conversation to provide patches > > and effort, and I'm doing just that. > > Thank you for doing this, btw. > > Over the weekend, this became a discussion where

Re: Review Request: ImageMagick7

2022-12-05 Thread Emmanuel Seyman
* Neal Gompa [04/12/2022 22:26] : > > Smooge challenged me earlier in this conversation to provide patches > and effort, and I'm doing just that. Thank you for doing this, btw. Over the weekend, this became a discussion where none of the participants seemed to be listening to the others and it be

Re: Review Request: ImageMagick7

2022-12-05 Thread Vít Ondruch
Dne 03. 12. 22 v 17:25 Sérgio Basto napsal(a): On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: On 03/12/2022 00:30, Sérgio Basto wrote: The proposal now is to keep ImageMagick 6 and make a new package with ImageMagick 7 , when we have all applications use only ImageMagick 7,

Re: Review Request: ImageMagick7

2022-12-05 Thread Vitaly Zaitsev via devel
On 04/12/2022 20:25, Sérgio Basto wrote: I don't indent change /usr/bin/convert from ImageMagick6 so probably it will /usr/bin/convert-7 Such name change is not a good idea, because /usr/bin/convert and all other ImageMagick binaries are used in many scripts and SPECs. You must provide symbol

Re: Review Request: ImageMagick7

2022-12-04 Thread Neal Gompa
On Sun, Dec 4, 2022 at 10:06 PM Richard Shaw wrote: > > On Sun, Dec 4, 2022 at 6:32 PM Sérgio Basto wrote: >> >> Final statement, instead of wasting my time and energy on arguments, >> Imagemagick7 could already be built on rawhide if someone had done the >> package review for me > > > I understa

Re: Review Request: ImageMagick7

2022-12-04 Thread Neal Gompa
On Sun, Dec 4, 2022 at 7:32 PM Sérgio Basto wrote: > > On Sun, 2022-12-04 at 17:14 -0500, Neal Gompa wrote: > > On Sun, Dec 4, 2022 at 5:07 PM Sérgio Basto > > wrote: > > > > > > On Sun, 2022-12-04 at 14:33 -0500, Neal Gompa wrote: > > > > On Sun, Dec 4, 2022 at 9:39 AM Stephen Smoogen > > > > >

Re: Review Request: ImageMagick7

2022-12-04 Thread Richard Shaw
On Sun, Dec 4, 2022 at 6:32 PM Sérgio Basto wrote: > Final statement, instead of wasting my time and energy on arguments, > Imagemagick7 could already be built on rawhide if someone had done the > package review for me > I understand the sentiment as another person who has donated 1000s of hours

Re: Review Request: ImageMagick7

2022-12-04 Thread Sérgio Basto
On Sun, 2022-12-04 at 17:14 -0500, Neal Gompa wrote: > On Sun, Dec 4, 2022 at 5:07 PM Sérgio Basto > wrote: > > > > On Sun, 2022-12-04 at 14:33 -0500, Neal Gompa wrote: > > > On Sun, Dec 4, 2022 at 9:39 AM Stephen Smoogen > > > > > > wrote: > > > > > > > > > > > > > > > > On Sat, 3 Dec 2022 a

Re: Review Request: ImageMagick7

2022-12-04 Thread Neal Gompa
On Sun, Dec 4, 2022 at 4:35 PM Kevin Kofler via devel wrote: > > Neal Gompa wrote: > > You can filter out things that use ImageMagick as a build dependency > > because that's just the command line utilities. That's why I checked > > only the ones that use the libraries, where the API changes and t

Re: Review Request: ImageMagick7

2022-12-04 Thread Neal Gompa
On Sun, Dec 4, 2022 at 5:07 PM Sérgio Basto wrote: > > On Sun, 2022-12-04 at 14:33 -0500, Neal Gompa wrote: > > On Sun, Dec 4, 2022 at 9:39 AM Stephen Smoogen > > wrote: > > > > > > > > > > > > On Sat, 3 Dec 2022 at 11:55, Neal Gompa wrote: > > > > > > > > On Sat, Dec 3, 2022 at 11:25 AM Sérgio

Re: Review Request: ImageMagick7

2022-12-04 Thread Sérgio Basto
On Sun, 2022-12-04 at 14:33 -0500, Neal Gompa wrote: > On Sun, Dec 4, 2022 at 9:39 AM Stephen Smoogen > wrote: > > > > > > > > On Sat, 3 Dec 2022 at 11:55, Neal Gompa wrote: > > > > > > On Sat, Dec 3, 2022 at 11:25 AM Sérgio Basto > > > wrote: > > > > > > > > On Sat, 2022-12-03 at 11:57 +01

Re: Review Request: ImageMagick7

2022-12-04 Thread Kevin Kofler via devel
Neal Gompa wrote: > You can filter out things that use ImageMagick as a build dependency > because that's just the command line utilities. That's why I checked > only the ones that use the libraries, where the API changes and the > required rebuilds are needed. How backwards-compatible is the CLI?

Re: Review Request: ImageMagick7

2022-12-04 Thread Neal Gompa
On Sun, Dec 4, 2022 at 9:39 AM Stephen Smoogen wrote: > > > > On Sat, 3 Dec 2022 at 11:55, Neal Gompa wrote: >> >> On Sat, Dec 3, 2022 at 11:25 AM Sérgio Basto wrote: >> > >> > On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: >> > > On 03/12/2022 00:30, Sérgio Basto wrote: >> >

Re: Review Request: ImageMagick7

2022-12-04 Thread Neal Gompa
On Sun, Dec 4, 2022 at 2:21 PM Sérgio Basto wrote: > > On Sat, 2022-12-03 at 11:35 -0500, Neal Gompa wrote: > > On Sat, Dec 3, 2022 at 11:25 AM Sérgio Basto > > wrote: > > > > > > On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: > > > > On 03/12/2022 00:30, Sérgio Basto wrote: >

Re: Review Request: ImageMagick7

2022-12-04 Thread Sérgio Basto
On Sat, 2022-12-03 at 17:41 +0100, Kalev Lember wrote: > On Sat, Dec 3, 2022 at 5:38 PM Neal Gompa wrote: > > On Sat, Dec 3, 2022 at 11:34 AM Kalev Lember > > wrote: > > > > > > On Sat, Dec 3, 2022 at 5:26 PM Sérgio Basto > > wrote: > > >> > > >> On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev

Re: Review Request: ImageMagick7

2022-12-04 Thread Sérgio Basto
On Sat, 2022-12-03 at 11:35 -0500, Neal Gompa wrote: > On Sat, Dec 3, 2022 at 11:25 AM Sérgio Basto > wrote: > > > > On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: > > > On 03/12/2022 00:30, Sérgio Basto wrote: > > > > The proposal now is to keep ImageMagick 6 and make a new >

Re: Review Request: ImageMagick7

2022-12-04 Thread Stephen Smoogen
On Sat, 3 Dec 2022 at 11:55, Neal Gompa wrote: > On Sat, Dec 3, 2022 at 11:25 AM Sérgio Basto wrote: > > > > On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: > > > On 03/12/2022 00:30, Sérgio Basto wrote: > > > > The proposal now is to keep ImageMagick 6 and make a new package

Re: Review Request: ImageMagick7

2022-12-03 Thread Kalev Lember
On Sat, Dec 3, 2022 at 5:38 PM Neal Gompa wrote: > On Sat, Dec 3, 2022 at 11:34 AM Kalev Lember > wrote: > > > > On Sat, Dec 3, 2022 at 5:26 PM Sérgio Basto wrote: > >> > >> On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: > >> > On 03/12/2022 00:30, Sérgio Basto wrote: > >> >

Re: Review Request: ImageMagick7

2022-12-03 Thread Neal Gompa
On Sat, Dec 3, 2022 at 11:34 AM Kalev Lember wrote: > > On Sat, Dec 3, 2022 at 5:26 PM Sérgio Basto wrote: >> >> On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: >> > On 03/12/2022 00:30, Sérgio Basto wrote: >> > > The proposal now is to keep ImageMagick 6 and make a new package

Re: Review Request: ImageMagick7

2022-12-03 Thread Neal Gompa
On Sat, Dec 3, 2022 at 11:25 AM Sérgio Basto wrote: > > On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: > > On 03/12/2022 00:30, Sérgio Basto wrote: > > > The proposal now is to keep ImageMagick 6 and make a new package > > > with > > > ImageMagick 7 , when we have all applicati

Re: Review Request: ImageMagick7

2022-12-03 Thread Fabio Valentini
On Sat, Dec 3, 2022, 17:26 Sérgio Basto wrote: > On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: > > On 03/12/2022 00:30, Sérgio Basto wrote: > > > The proposal now is to keep ImageMagick 6 and make a new package > > > with > > > ImageMagick 7 , when we have all applications us

Re: Review Request: ImageMagick7

2022-12-03 Thread Kalev Lember
On Sat, Dec 3, 2022 at 5:26 PM Sérgio Basto wrote: > On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: > > On 03/12/2022 00:30, Sérgio Basto wrote: > > > The proposal now is to keep ImageMagick 6 and make a new package > > > with > > > ImageMagick 7 , when we have all application

Re: Review Request: ImageMagick7

2022-12-03 Thread Sérgio Basto
On Sat, 2022-12-03 at 11:57 +0100, Vitaly Zaitsev via devel wrote: > On 03/12/2022 00:30, Sérgio Basto wrote: > > The proposal now is to keep ImageMagick 6 and make a new package > > with > > ImageMagick 7 , when we have all applications use only ImageMagick > > 7, > > we move the sources from Imag

Re: Review Request: ImageMagick7

2022-12-03 Thread Vitaly Zaitsev via devel
On 03/12/2022 00:30, Sérgio Basto wrote: The proposal now is to keep ImageMagick 6 and make a new package with ImageMagick 7 , when we have all applications use only ImageMagick 7, we move the sources from ImageMagick7 to ImageMagick I think it would be better to update the ImageMagick package

Re: Review Request: ImageMagick7

2022-12-02 Thread Sérgio Basto
On Sat, 2022-12-03 at 00:12 -0500, Neal Gompa wrote: > On Fri, Dec 2, 2022 at 11:55 PM Sérgio Basto > wrote: > > > > On Fri, 2022-12-02 at 22:41 -0500, Neal Gompa wrote: > > > On Fri, Dec 2, 2022 at 10:29 PM Sérgio Basto > > > wrote: > > > > > > > > On Fri, 2022-12-02 at 17:34 -0600, Richard Sh

Re: Review Request: ImageMagick7

2022-12-02 Thread Neal Gompa
On Fri, Dec 2, 2022 at 11:55 PM Sérgio Basto wrote: > > On Fri, 2022-12-02 at 22:41 -0500, Neal Gompa wrote: > > On Fri, Dec 2, 2022 at 10:29 PM Sérgio Basto > > wrote: > > > > > > On Fri, 2022-12-02 at 17:34 -0600, Richard Shaw wrote: > > > > > > On Fri, Dec 2, 2022 at 5:31 PM Sérgio Basto > >

Re: Review Request: ImageMagick7

2022-12-02 Thread Sérgio Basto
On Fri, 2022-12-02 at 22:41 -0500, Neal Gompa wrote: > On Fri, Dec 2, 2022 at 10:29 PM Sérgio Basto > wrote: > > > > On Fri, 2022-12-02 at 17:34 -0600, Richard Shaw wrote: > > > > On Fri, Dec 2, 2022 at 5:31 PM Sérgio Basto > > wrote: > > > > Hi, > > > > I think it's important to bring ImageM

Re: Review Request: ImageMagick7

2022-12-02 Thread Neal Gompa
On Fri, Dec 2, 2022 at 10:29 PM Sérgio Basto wrote: > > On Fri, 2022-12-02 at 17:34 -0600, Richard Shaw wrote: > > On Fri, Dec 2, 2022 at 5:31 PM Sérgio Basto wrote: > > Hi, > > I think it's important to bring ImageMagick 7 to Fedora, and it should > have been done a long time ago . > The proposa

Re: Review Request: ImageMagick7

2022-12-02 Thread Sérgio Basto
On Fri, 2022-12-02 at 17:34 -0600, Richard Shaw wrote: > On Fri, Dec 2, 2022 at 5:31 PM Sérgio Basto > wrote: > > Hi, > > > > I think it's important to bring ImageMagick 7 to Fedora, and it > > should > > have been done a long time ago . > > The proposal now is to keep ImageMagick 6 and make a ne

Re: Review Request: ImageMagick7

2022-12-02 Thread Neal Gompa
On Fri, Dec 2, 2022 at 6:35 PM Richard Shaw wrote: > > On Fri, Dec 2, 2022 at 5:31 PM Sérgio Basto wrote: >> >> Hi, >> >> I think it's important to bring ImageMagick 7 to Fedora, and it should >> have been done a long time ago . >> The proposal now is to keep ImageMagick 6 and make a new package

Re: Review Request: ImageMagick7

2022-12-02 Thread Richard Shaw
On Fri, Dec 2, 2022 at 5:31 PM Sérgio Basto wrote: > Hi, > > I think it's important to bring ImageMagick 7 to Fedora, and it should > have been done a long time ago . > The proposal now is to keep ImageMagick 6 and make a new package with > ImageMagick 7 , when we have all applications use only I

Re: Review request: sfsexp - Small Fast S-Expression Library

2022-06-24 Thread Kevin Kofler via devel
Michael J Gruber wrote: > It turns out that bodhi applies the same boundary conditions to > "newpackage" updates (no karma for your own update, 7 days minimum to > stable by time). I don't think a new leave package can disturb current > systems much ... A library, in particular, will not receive an

Re: Review request: sfsexp - Small Fast S-Expression Library

2022-06-24 Thread Michael J Gruber
So, thanks to the good and fast review sfsexp is in rawhide now. Hooray! It turns out that bodhi applies the same boundary conditions to "newpackage" updates (no karma for your own update, 7 days minimum to stable by time). I don't think a new leave package can disturb current systems much ... A

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-14 Thread Dominik 'Rathann' Mierzejewski
On Tuesday, 14 June 2022 at 15:45, Vitaly Zaitsev via devel wrote: > On 14/06/2022 10:48, Dominik 'Rathann' Mierzejewski wrote: [...] > > We could rename ffmpeg-free-devel to ffmpeg-devel or add Provides: to > > make the transition seamless. > > If an app checks for h264/h265 codecs at build time,

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-14 Thread Vitaly Zaitsev via devel
On 14/06/2022 10:48, Dominik 'Rathann' Mierzejewski wrote: If everything were built against ffmpeg-free-devel, then it might work better as the build process of other dependent packages wouldn't pull ffmpeg-libs from RPM Fusion at all and wouldn't suffer from desync. The Freedesktop Flatpak run

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-14 Thread Dominik 'Rathann' Mierzejewski
On Monday, 13 June 2022 at 16:43, Vitaly Zaitsev via devel wrote: > On 13/06/2022 16:35, Sandro Mani wrote: > > In any case I'll close the request then, and leave it to the rpmfusion > > maintainer (CCed) to decide whether to move it to Fedora proper. > > All conflicts between ffmpeg-free and ffmp

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-14 Thread Dominik 'Rathann' Mierzejewski
On Tuesday, 14 June 2022 at 09:59, Vitaly Zaitsev via devel wrote: > On 14/06/2022 08:43, Dominik 'Rathann' Mierzejewski wrote: > > It's not trivial to resolve the conflict between ffmpeg and ffmpeg-free, > > because: > > I see only one fix of this problem - delete everything, except libs from RPM

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-14 Thread Vitaly Zaitsev via devel
On 14/06/2022 08:43, Dominik 'Rathann' Mierzejewski wrote: It's not trivial to resolve the conflict between ffmpeg and ffmpeg-free, because: I see only one fix of this problem - delete everything, except libs from RPM Fusion's ffmpeg. But it will introduce major issues with synchronization b

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-13 Thread Dominik 'Rathann' Mierzejewski
On Monday, 13 June 2022 at 16:43, Vitaly Zaitsev via devel wrote: > On 13/06/2022 16:35, Sandro Mani wrote: > > In any case I'll close the request then, and leave it to the rpmfusion > > maintainer (CCed) to decide whether to move it to Fedora proper. > > All conflicts between ffmpeg-free and ffmp

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-13 Thread Vitaly Zaitsev via devel
On 13/06/2022 16:35, Sandro Mani wrote: In any case I'll close the request then, and leave it to the rpmfusion maintainer (CCed) to decide whether to move it to Fedora proper. All conflicts between ffmpeg-free and ffmpeg-libs must be resolved first. Only then can we start moving packages betwe

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-13 Thread Sandro Mani
On 13.06.22 16:22, Artur Frenszek-Iwicki wrote: SSR is available in RPM Fusion under the name "simplescreenrecorder", so you may want to coordinate this with the Fusion maintainer - maybe do something similar to Audacity and Chromium, where the Fedora package is named "foobar" and the RPM Fusion

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-13 Thread Artur Frenszek-Iwicki
SSR is available in RPM Fusion under the name "simplescreenrecorder", so you may want to coordinate this with the Fusion maintainer - maybe do something similar to Audacity and Chromium, where the Fedora package is named "foobar" and the RPM Fusion one is "foobar-freeworld". A.FI. https://admin.r

Re: Review request: ssr - SimpleScreenRecorder, a screen recorder for Linux

2022-06-13 Thread Per Bothner
On 6/13/22 06:38, Sandro Mani wrote: Now that there is ffmpeg in Fedora, I'd like to add ssr [1], a useful screen recording app similar to RecordMyDesktop back in the days, to the repos. Review is here: https://bugzilla.redhat.com/show_bug.cgi?id=2096304 It's a simple C++/CMake/Qt application

Re: Review request: sfsexp - Small Fast S-Expression Library

2022-06-10 Thread Ian McInerney via devel
I'll take it and review it. I don't have any ones to swap currently. -Ian On Fri, Jun 10, 2022 at 12:09 PM Michael J Gruber wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=2095717 > > This is an optional dependency of notmuch, the mail indexer. sfsexp > enhances notmuch's capabilities cons

Re: Review request: python-jenkins-job-builder - unretire and update to 4.0.0

2022-05-13 Thread Christoph Erhardt
Thanks, Ewoud! I'm happy to return the favour, but it might take me a few days to find the time. This will be my first time reviewing a Fedora packaging request, so I feel I ought to do some more in-depth reading in preparation. Best, Christoph On Thursday, 12 May 2022 11:20:11 CEST Ewoud Kohl

Re: Review request: python-jenkins-job-builder - unretire and update to 4.0.0

2022-05-12 Thread Ewoud Kohl van Wijngaarden
On Thu, May 12, 2022 at 08:00:18AM +0200, Christoph Erhardt wrote: Hi all, I'm willing to revive python-jenkins-job-builder by updating it to the latest release 4.0.0 and backporting an upstream patch. I already have a working Copr build: https://copr.fedorainfracloud.org/coprs/ sicherha/python-

Re: Review request: Go packages required by Hugo

2022-03-09 Thread Mikel Olasagasti
Hi Mike, If you're not in a hurry I can review them in the upcoming days. Kind regards, Mikel Hau idatzi du W. Michael Petullo (m...@flyn.org) erabiltzaileak (2022 mar. 9, az. (04:40)): > > I would like to update Fedora's Hugo package, but the recent versions > depend on Go packages not yet in F

Re: Review request to fix FailsToInstall: mingw-qt6-qtshadertools

2021-12-17 Thread Michel Alexandre Salim
On Thu, Dec 16, 2021 at 09:55:51PM +0100, Sandro Mani wrote: > > On 16.12.21 00:31, Michel Alexandre Salim wrote: > > On Wed, Dec 15, 2021 at 10:58:24PM +0100, Sandro Mani wrote: > > > Hi > > > > > > I'd need mingw-qt6-qtshadertools reviewed: > > > > > > https://bugzilla.redhat.com/show_bug.cgi?

  1   2   3   >