Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2023-12-19 Thread Samer El-Haj-Mahmoud
ete Batard ; Daniel P . Berrangé > ; Gerd Hoffmann ; Samer El-Haj- > Mahmoud > Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: > Signal ReadyToBoot on platform recovery > > On Tue, 19 Dec 2023 at 14:00, gaoliming via groups.io > wrote: > > > > Yes.

Re: [edk2-devel] [edk2-platforms][PATCH 2/8] Platform/RPi: Replace Bcm283x SoC base register address with a PCD

2019-11-18 Thread Samer El-Haj-Mahmoud
inaro.org; phi...@redhat.com; Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/8] Platform/RPi: Replace Bcm283x SoC base register address with a PCD On Thu, Nov 14, 2019 at 04:07:34PM +, Pete Batard wrote: > From: Samer El-Haj-Mahmoud > > Define BCM

Re: [edk2-devel] [edk2-rfc] [RFC] code-first process for UEFI-forum specifications

2020-03-11 Thread Samer El-Haj-Mahmoud
Has there been any progress on this "code-first process" proposal? Any timeline on when we should expect it to be launched? Thanks, --Samer -Original Message- From: devel@edk2.groups.io On Behalf Of Felix Polyudov via Groups.Io Sent: Friday, February 14, 2020 10:30 AM To: r...@edk2.gr

Re: [edk2-devel] [edk2-rfc] [RFC] code-first process for UEFI-forum specifications

2020-03-11 Thread Samer El-Haj-Mahmoud
Thanks Leif. As far as I know, the main feedback I heard is "when will this start?"... So, the sooner the better .. Thanks for taking the lead and driving! -Original Message- From: Leif Lindholm Sent: Wednesday, March 11, 2020 12:03 PM To: Samer El-Haj-Mahmoud Cc:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-19 Thread Samer El-Haj-Mahmoud
Any help from maintainers in reviewing this MdeModulePkg patch please? Thanks, --Samer -Original Message- From: devel@edk2.groups.io On Behalf Of Pankaj Bansal via Groups.Io Sent: Wednesday, February 19, 2020 8:32 AM To: Jian J Wang ; Hao A Wu ; Ray Ni ; Maurice Ma ; Guo Dong ; Benjam

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

2020-03-22 Thread Samer El-Haj-Mahmoud
error reported by acpiview command, as seen on the RPi (see https://github.com/pftf/RPi4/issues/25). Cc: Dandan Bi Cc: Liming Gao Cc: Hao A Wu Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- MdeModulePkg/MdeModulePkg.dec | 3 +++ 1 file changed, 3 insertions

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

2020-03-23 Thread Samer El-Haj-Mahmoud
andan Bi ; Liming Gao ; Hao A Wu ; Leif Lindholm ; Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms On 03/22/20 17:08, Samer El-Haj-Mahmoud wrote: > Set the default value of PcdAcpiExposedTableVersions for

[edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot

2020-03-24 Thread Samer El-Haj-Mahmoud
Enable HTTP Boot (with and without TLS) on RPi4 Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform

Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot

2020-03-24 Thread Samer El-Haj-Mahmoud
Tested with USB NICs (both ASIX AX88772C and Realtek gigabit ethernet). Both work pretty well (tested IPv4 and IPv6). -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel via Groups.Io Sent: Tuesday, March 24, 2020 5:55 PM To: Samer El-Haj-Mahmoud Cc: edk2-devel

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

2020-03-24 Thread Samer El-Haj-Mahmoud
Thanks Laszlo, I will wait for the maintainers to accept the patch, then submit an amended version for ArmVirtQemu. -Original Message- From: Laszlo Ersek Sent: Tuesday, March 24, 2020 7:03 PM To: Samer El-Haj-Mahmoud ; devel@edk2.groups.io; sa...@elhajmahmoud.com Cc: Dandan Bi

Re: [edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot

2020-03-25 Thread Samer El-Haj-Mahmoud
> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, March 25, 2020 5:20 AM > To: Samer El-Haj-Mahmoud > Cc: devel@edk2.groups.io; Samer El-Haj-Mahmoud > ; Leif Lindholm > Subject: Re: [edk2-devel] [[edk2-platform][PATCH 1/1] > Platform/RaspberryP

[edk2-devel] [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi3: Enable HTTP Boot

2020-03-25 Thread Samer El-Haj-Mahmoud
Enable HTTP Boot (with and without TLS) on RPi3 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b

Re: [edk2-devel] [PATCH v2 00/28] Add PEI phase to LS1043ARDB Platform

2020-03-26 Thread Samer El-Haj-Mahmoud
ggar...@nxp.com) ; Michael D > Kinney ; devel@edk2.groups.io; V Sethi > (v.se...@nxp.com) ; Samer El-Haj-Mahmoud mahm...@arm.com>; Jon (j...@solid-run.com) > Subject: [PATCH v2 00/28] Add PEI phase to LS1043ARDB Platform > > From: Pankaj Bansal > > This patch series adds PEI

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

2020-03-26 Thread Samer El-Haj-Mahmoud
Thanks Ard and Laszlo. Leif, Dandan, Liming, Hao, any objection in merging this patch to edk2? > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, March 25, 2020 5:16 AM > To: Samer El-Haj-Mahmoud > Cc: Laszlo Ersek ; devel@edk2.groups.io; > sa...@elhajm

[edk2-devel] [edk2][PATCH v2 0/2] ACPI table defailt for Aarch64

2020-04-10 Thread Samer El-Haj-Mahmoud
Set the default value of PcdAcpiExposedTableVersions for Aarch64 platforms to 0x20 to indicate ACPI 5.0. Samer El-Haj-Mahmoud (2): MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher" Md

[edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

2020-04-10 Thread Samer El-Haj-Mahmoud
error reported by acpiview command, as seen on the RPi (see https://github.com/pftf/RPi4/issues/25). Cc: Dandan Bi Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Ard Biesheuvel Reviewed-by: Dandan Bi

[edk2-devel] [edk2][PATCH v2 2/2] Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher"

2020-04-10 Thread Samer El-Haj-Mahmoud
: Samer El-Haj-Mahmoud Acked-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.dsc | 4 1 file changed, 4 deletions(-) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 5a210a0bac72..1233f1ece484 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc

[edk2-devel] RFC: ASIX USB drivers

2020-04-11 Thread Samer El-Haj-Mahmoud
EDK2 community, (and CCing OptionRomPkg maintainers), ASIX (https://www.asix.com.tw/) has graciously contributed the source code of their latest USB NIC drivers to be up-streamed to TianoCore. The original contribution (ZIP files) is available here: https://github.com/samerhaj/uefi_drivers/tre

[edk2-devel] [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe

2020-04-11 Thread Samer El-Haj-Mahmoud
Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud

[edk2-devel] [edk2-platform][PATCH v1 3/3] Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe

2020-04-11 Thread Samer El-Haj-Mahmoud
Remove the PI specific GraphicsConsoleDxe driver, since RPi3/RPi4 switched to using the common driver in MdeModulePkg. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi

[edk2-devel] [edk2-platform][PATCH v1 2/3] Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe

2020-04-11 Thread Samer El-Haj-Mahmoud
Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud

[edk2-devel] [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe

2020-04-11 Thread Samer El-Haj-Mahmoud
Switch RaspberryPi from using a private GraphicsConsoleDxe to the common GraphicsConsoleDxe in MdeModulePkg. Samer El-Haj-Mahmoud (3): Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe Platform/RaspberryPi:Remove

Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe

2020-04-11 Thread Samer El-Haj-Mahmoud
Thanks Ard... Will take care of it next time. From: devel@edk2.groups.io on behalf of Ard Biesheuvel via groups.io Sent: Saturday, April 11, 2020, 3:45 PM To: Samer El-Haj-Mahmoud Cc: edk2-devel-groups-io; Leif Lindholm; Pete Batard Subject: Re: [edk2-devel

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

2020-04-14 Thread Samer El-Haj-Mahmoud
Thanks Sami for the review Jian, Can we get this patch pushed please? It has been reviewed by Sami, Ard, and Dandan. Thanks, --Samer From: devel@edk2.groups.io On Behalf Of Sami Mujawar via groups.io Sent: Tuesday, April 14, 2020 5:45 AM To: Samer El-Haj-Mahmoud ; devel@edk2.groups.io

[edk2-devel] [edk2-platform][PATCH v2 3/3] Platform/RaspberryPi:Remove RPi GraphicsConsoleDxe

2020-04-14 Thread Samer El-Haj-Mahmoud
Remove the PI specific GraphicsConsoleDxe driver, since RPi3/RPi4 switched to using the common driver in MdeModulePkg. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud

[edk2-devel] [edk2-platform][PATCH v2 2/3] Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe

2020-04-14 Thread Samer El-Haj-Mahmoud
Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El

[edk2-devel] [edk2-platform][PATCH v2 0/3] Platform/RaspberryPi : Switch to common GraphicsConsoleDxe

2020-04-14 Thread Samer El-Haj-Mahmoud
PcdUgaConsumeSupport to FALSE [Ard] Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Samer El-Haj-Mahmoud (3): Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe Platform/RaspberryPi/RPi3: Switch to common GraphicsConsoleDxe Platform/RaspberryPi:Remove RPi

[edk2-devel] [edk2-platform][PATCH v2 1/3] Platform/RaspberryPi/RPi4: Switch to common GraphicsConsoleDxe

2020-04-14 Thread Samer El-Haj-Mahmoud
Switch from the PI specific GraphicsConsoleDxe driver to the common driver in MdeModulePkg. There is no need to carry RPi specific version. This resolves https://github.com/pftf/RPi4/issues/32 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El

[edk2-devel] [edk2-platform][PATCH v1 1/1] * Readme.md: Update supported platforms

2020-04-14 Thread Samer El-Haj-Mahmoud
link) Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Samer El-Haj-Mahmoud --- Readme.md | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Readme.md b/Readme.md index 912a78600a32..8f9522659d7b 100644 --- a/Readme.md +++ b

[edk2-devel] [edk2-platform][PATCH v1 1/1] Maintainers.txt: Update RPi reviewers

2020-04-14 Thread Samer El-Haj-Mahmoud
Add Andrei to the reviewers list for RPi Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pete Batard Signed-off-by: Samer El-Haj-Mahmoud --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 0e50b6fdf36a..1fe73e6cedb2 100644 --- a

Re: [edk2-devel] [edk2-test PATCH] SctPkg: Updated Start Address Alignment code

2020-04-17 Thread Samer El-Haj-Mahmoud
Gaurav, You sent to the old list. Adding the new edk2-devel list > > > -Original Message- > > From: Gaurav Jain > > Sent: Friday, April 17, 2020 2:55 AM > > To: edk2-de...@lists.01.org > > Cc: Eric Jin ; Supreeth Venkatesh > > ; Samer El-Haj-Mahm

Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms

2020-04-18 Thread Samer El-Haj-Mahmoud
Jian, Hao, Can you please push this simple patch? It has been reviewed a while ago and ready to be committed. Thanks, --Samer > -Original Message- > From: devel@edk2.groups.io On Behalf Of Samer El- > Haj-Mahmoud via groups.io > Sent: Friday, April 10, 2020 11:29 AM >

Re: [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-04-19 Thread Samer El-Haj-Mahmoud
Tested-By: Samer El-Haj-Mahmoud I tested on Aarch64 (RPi4) and the command seems to work well. One question: why is the input arguments "host[:port]" and the remote file "http_uri" not treated as a single "http_uri" argument? For example, instead of: fs0:\

[edk2-devel] [edk2-platform][PATCH v1 2/4] Platform/RaspberryPi/RPi4: Fix TFTP dynamic command initialization

2020-04-19 Thread Samer El-Haj-Mahmoud
Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command. This fixes an ASSERT observed in https://github.com/pftf/RPi4/issues/38 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc

[edk2-devel] [edk2-platform][PATCH v1 3/4] Platform/RaspberryPi/RPi3: Enable TFTP command by default

2020-04-19 Thread Samer El-Haj-Mahmoud
Enable the TFTP dynamic shell command by default. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi

[edk2-devel] [edk2-platform][PATCH v1 4/4] Platform/RaspberryPi/RPi4: Enable TFTP command by default

2020-04-19 Thread Samer El-Haj-Mahmoud
Enable the TFTP dynamic shell command by default. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi

[edk2-devel] [edk2-platform][PATCH v1 1/4] Platform/RaspberryPi/RPi3: Fix TFTP dynamic command initialization

2020-04-19 Thread Samer El-Haj-Mahmoud
Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command. This fixes an ASSERT observed in https://github.com/pftf/RPi3/issues/11 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc

[edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

2020-04-19 Thread Samer El-Haj-Mahmoud
Fix an ASSERT with the TFTP dynamic Shell command on the RPi3 and RPi4 when running DEBUG builds. Also, enable the command by default for all builds. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Samer El-Haj-Mahmoud (4): Platform/RaspberryPi/RPi3: Fix TFTP

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

2020-04-19 Thread Samer El-Haj-Mahmoud
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel via groups.io > Sent: Sunday, April 19, 2020 9:34 AM > To: Samer El-Haj-Mahmoud ; > devel@edk2.groups.io > Cc: Leif Lindholm ; Pete Batard ; Andrei > Warkentin (awarken...@vmware.co

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

2020-04-20 Thread Samer El-Haj-Mahmoud
f > Lindholm via groups.io > Sent: Monday, April 20, 2020 7:23 AM > To: Andrei Warkentin (awarken...@vmware.com) > ; Ard Biesheuvel > Cc: Pete Batard ; Samer El-Haj-Mahmoud > ; devel@edk2.groups.io > Subject: Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi > :

Re: [edk2-devel] [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command

2020-04-20 Thread Samer El-Haj-Mahmoud
Thanks Ard! > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel via groups.io > Sent: Monday, April 20, 2020 9:25 AM > To: Samer El-Haj-Mahmoud ; > devel@edk2.groups.io > Cc: Leif Lindholm ; Pete Batard ; Andrei > Warkentin (awarken..

Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

2020-04-20 Thread Samer El-Haj-Mahmoud
smbiosview (and other standard commands) are defined in the UEFI Shell specification, which specifies the profiles/for each command (UEFI Shell Spec 2.2, Table 11). For instance, smbiosview is defined as part of the Debug1 profile. This is why the code registers that command in UefiShellDebug1C

Re: [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-04-21 Thread Samer El-Haj-Mahmoud
27;http' command, similar to what is common in other http CLI clients like curl If (1) is important enough for users, then could we entertain adding (2) in addition to (1). Thanks, --Samer > -Original Message- > From: Vladimir Olovyannikov > Sent: Monday, April 20,

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName

2022-09-28 Thread Samer El-Haj-Mahmoud
Hi Ard, Any luck getting this one merged? Thanks, --Samer > -Original Message- > From: Sunny Wang > Sent: Friday, August 19, 2022 10:47 AM > To: Dimitrije Pavlov ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Jiewen Yao > ; Liming Gao ; Jeff > Booher-Kaeding ;

Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL

2022-10-11 Thread Samer El-Haj-Mahmoud
Reviewed-By: Samer El-Haj-Mahmoud < samer.el-haj-mahm...@arm.com> From: devel@edk2.groups.io on behalf of Sam Kaynor via groups.io Sent: Tuesday, October 11, 2022 1:54:43 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v1 1/1] uefi-sct/

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-07-16 Thread Samer El-Haj-Mahmoud
rkPkg maintainers review correct? Thanks, --Samer > -Original Message- > From: Laszlo Ersek > Sent: Thursday, July 16, 2020 8:20 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan Fu &

[edk2-devel] [edk2-platform][PATCH v1 0/2] Platform/RaspberryPi : Set supported platform Language to English

2020-07-18 Thread Samer El-Haj-Mahmoud
Set the RaspberryPi suppoted Platform Language to English (US). Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud Samer El-Haj-Mahmoud (2): Platforms/RaspberryPi: Set RPi4 Language supported to English Platforms/RaspberryPi

[edk2-devel] [edk2-platform][PATCH v1 1/2] Platforms/RaspberryPi: Set RPi4 Language supported to English

2020-07-18 Thread Samer El-Haj-Mahmoud
Set the supported RPi4 platform language to English (US), and remove French. This fixes https://github.com/pftf/RPi4/issues/35 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 5 - 1

[edk2-devel] [edk2-platform][PATCH v1 2/2] Platforms/RaspberryPi: Set RPi3 Language supported to English

2020-07-18 Thread Samer El-Haj-Mahmoud
Set the supported RPi3 platform language to English (US), and remove French. This fixes https://github.com/pftf/RPi4/issues/35 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc | 5 - 1

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

2020-07-20 Thread Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: Pete Batard > Sent: Monday, July 20, 2020 12:15 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; l...@nuviainc.com; Andrei > Warkentin (awarken...@vmware.com) ; Samer > El-Haj-Mahmoud > Subject:

[edk2-devel] [edk2-platform][PATCH v1 4/7] Platforms/RaspberryPi: SMBIOS Type 4 fixes

2020-07-20 Thread Samer El-Haj-Mahmoud
Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 1 + Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 87 2

[edk2-devel] [edk2-platform][PATCH v1 3/7] Platforms/RaspberryPi: SMBIOS Type 0 fixes

2020-07-20 Thread Samer El-Haj-Mahmoud
: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 6 +- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 17 + 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/Platform/RaspberryPi/Drivers

[edk2-devel] [edk2-platform][PATCH v1 0/7] Platform/RaspberryPi : SMBIOS fixes and cleanup

2020-07-20 Thread Samer El-Haj-Mahmoud
n Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud Samer El-Haj-Mahmoud (7): Platforms/RaspberryPi: Fix NULL AssetTag in SMBIOS Platforms/RaspberryPi: SMBIOS Type 2 and Type 3 fixes Platforms/RaspberryPi: SMBIOS Type 0 fixes Platforms/RaspberryPi: SMBIOS Type 4 fixes Platforms/Raspberry

[edk2-devel] [edk2-platform][PATCH v1 2/7] Platforms/RaspberryPi: SMBIOS Type 2 and Type 3 fixes

2020-07-20 Thread Samer El-Haj-Mahmoud
: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 41 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform

[edk2-devel] [edk2-platform][PATCH v1 5/7] Platforms/RaspberryPi: SMBIOS Type 7 fixes

2020-07-20 Thread Samer El-Haj-Mahmoud
-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 146 ++-- 1 file changed, 133 insertions(+), 13 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b/Platform/RaspberryPi/Drivers

[edk2-devel] [edk2-platform][PATCH v1 1/7] Platforms/RaspberryPi: Fix NULL AssetTag in SMBIOS

2020-07-20 Thread Samer El-Haj-Mahmoud
Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c

[edk2-devel] [edk2-platform][PATCH v1 7/7] Platforms/RaspberryPi: SMBIOS minor cleanup

2020-07-20 Thread Samer El-Haj-Mahmoud
Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 43 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c b

[edk2-devel] [edk2-platform][PATCH v1 6/7] Platforms/RaspberryPi: SMBIOS Memory Types fixes

2020-07-20 Thread Samer El-Haj-Mahmoud
Type 16 handle Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 115 ++-- 1 file changed, 83 insertions(+), 32 deletions(-) diff --git a

[edk2-devel] [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field values format

2020-07-20 Thread Samer El-Haj-Mahmoud
as "0x%lx" instead of "0x%x" to prevent truncating output when printing these QWORD fields. Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Samer El-Haj-Mahmoud --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 14 +++--

[edk2-devel] [edk2-platform][PATCH v1 3/3] Platforms/RaspberryPi: Fix GOP FrameBufferSize returned by SetMode()

2020-07-21 Thread Samer El-Haj-Mahmoud
/pftf/RPi4/issues/73 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/Drivers/

[edk2-devel] [edk2-platform][PATCH v1 0/3] Platform/RaspberryPi : SCT EFI_GRAPHICS_OUTPUT_PROTOCOL fixes

2020-07-21 Thread Samer El-Haj-Mahmoud
This series fixes various failures reported by SCT for EFI_GRAPHICS_OUTPUT_PROTOCOL (https://github.com/pftf/RPi4/issues/73) Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud Samer El-Haj-Mahmoud (3): Platforms/RaspberryPi: Fix

[edk2-devel] [edk2-platform][PATCH v1 1/3] Platforms/RaspberryPi: Fix GOP parameter handling

2020-07-21 Thread Samer El-Haj-Mahmoud
-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c index b880ca827bd6

[edk2-devel] [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Return GOP PixelInformation in QueryMode()

2020-07-21 Thread Samer El-Haj-Mahmoud
Return correct values of PixelInformation in QueryMode(). This fixes the QueryMode_Func failures reported by SCT tests at https://github.com/pftf/RPi4/issues/73 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform

[edk2-devel] [edk2-test][PATCH v1 0/3] uefi-sct/SctPkg: Build Aarch64 with latest EDK2

2020-07-23 Thread Samer El-Haj-Mahmoud
Update the SctPkg build scripts and HowTo to build for AARCH64 with latest EDK2, without depending on UDK2017. This series depends on the change in: https://edk2.groups.io/g/devel/message/60407 Samer El-Haj-Mahmoud (3): uefi-sct/SctPkg: Fix build with latest EDK2 uefi-sct/SctPkg: Add build

[edk2-devel] [edk2-test][PATCH v1 3/3] uefi-sct/SctPkg: Remove obsolete version macros

2020-07-23 Thread Samer El-Haj-Mahmoud
Remove the obsolete EFI_SPECIFICATION_VERSION and TIANO_RELEASE_VERSION macros, which are not passed in as command line arguments anymore. Cc: G Edhaya Chandran Cc: Eric Jin Cc: Irene Park Cc: Heinrich Schuchardt Signed-off-by: Samer El-Haj-Mahmoud --- uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 20

[edk2-devel] [edk2-test][PATCH v1 2/3] uefi-sct/SctPkg: Add build instructions with latest EDK2

2020-07-23 Thread Samer El-Haj-Mahmoud
Add new HowToBuild instructions with latest EDK2, for AARCH64 Linux. Tested with WSL on Windows 10 Build 19041 Cc: G Edhaya Chandran Cc: Eric Jin Cc: Irene Park Cc: Heinrich Schuchardt Signed-off-by: Samer El-Haj-Mahmoud --- uefi-sct/HowToBuild/How to build SCT.txt | 15 +++ 1

[edk2-devel] [edk2-test][PATCH v1 1/3] uefi-sct/SctPkg: Fix build with latest EDK2

2020-07-23 Thread Samer El-Haj-Mahmoud
) - Remove unnecessary EdkCompatibilityPkg reference This patch depends on the change in https://edk2.groups.io/g/devel/message/60407 Cc: G Edhaya Chandran Cc: Eric Jin Cc: Irene Park Cc: Heinrich Schuchardt Signed-off-by: Samer El-Haj-Mahmoud --- uefi-sct/SctPkg/build.sh | 19

Re: [edk2-devel] [PATCH edk2-test 1/1] SctPkg: fix page alignment calculations

2020-07-23 Thread Samer El-Haj-Mahmoud
Acked-by: Samer El-Haj-Mahmoud > -Original Message- > From: Pankaj Bansal > Sent: Saturday, July 4, 2020 11:52 AM > To: devel@edk2.groups.io; Eric Jin ; G Edhaya Chandran > > Cc: Pankaj Bansal ; Paul Yang > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Gaurav Jain

[edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix RPi4 GICC PMU PPI

2020-07-28 Thread Samer El-Haj-Mahmoud
rrect PPI value") reported in https://github.com/pftf/RPi4/issues/74 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi4/RPi4.dsc | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: EFI_RNG_PROTOCOL.GetInfo check size != 0

2020-08-04 Thread Samer El-Haj-Mahmoud
Picking old SCT patches that were missed Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via Groups.Io > Sent: Saturday, December 28, 2019 10:37 AM > To: EDK II Development > Cc: Eric Jin ;

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

2020-08-04 Thread Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via groups.io > Sent: Monday, July 27, 2020 1:53 PM > To: EDK II Development > Cc: Eric Jin ; G Edhaya Chandran > ; Heinrich Schuchardt > Sub

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: typo Verity in TimeServicesBBTestFunction

2020-08-04 Thread Samer El-Haj-Mahmoud
Picking up old SCT patches that were missed Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heinrich > Schuchardt via Groups.Io > Sent: Sunday, December 8, 2019 10:51 AM > To: EDK II Development > Cc: Eric Jin ;

Re: [edk2-devel] [PATCH] Check return status on calls to GetTime()

2020-08-04 Thread Samer El-Haj-Mahmoud
Reviewed-by: Samer El-Haj-Mahmoud > -Original Message- > From: Grant Likely > Sent: Friday, July 31, 2020 1:20 PM > To: devel@edk2.groups.io > Cc: nd ; Grant Likely ; G Edhaya > Chandran ; Heinrich Schuchardt > ; Samer El-Haj-Mahmoud mahm...@arm.com> > Su

Re: [edk2-devel] [PATCH edk2-test 1/1] SctPkg: fix page alignment calculations

2020-08-04 Thread Samer El-Haj-Mahmoud
I verified that this works on multiple platforms Tested-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Samer > El-Haj-Mahmoud via groups.io > Sent: Thursday, July 23, 2020 10:33 PM > To: Pankaj Bansal ; devel@edk2.groups.io;

[edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Fix GUID of EfiCompliant test

2020-08-04 Thread Samer El-Haj-Mahmoud
correct in the code (gEfiCompliantBbTestPlatformAssertionGuid012), but not in Guid_uefi.h, causing a disconnect between the data file and the code, which resulted in the test case being omitted from SCT. Cc: G Edhaya Chandran Cc: Eric Jin Signed-off-by: Samer El-Haj-Mahmoud --- uefi-sct/SctPkg

Re: [edk2-devel] [PATCH] Check return status on calls to GetTime()

2020-08-06 Thread Samer El-Haj-Mahmoud
nal Message- > From: Samer El-Haj-Mahmoud > Sent: Tuesday, August 4, 2020 7:27 AM > To: Grant Likely ; devel@edk2.groups.io > Cc: nd ; G Edhaya Chandran ; > Heinrich Schuchardt ; Samer El-Haj-Mahmoud > > Subject: RE: [PATCH] Check return status on calls to GetTime() >

Re: [edk2-devel] [Wiki][Patch V2] Add EDK II Code First Process Wiki Page

2020-08-10 Thread Samer El-Haj-Mahmoud
Mike, Looks good as a starting point! Acked-by: Samer El-Haj-Mahmoud I do have a few questions on this sentence: "Specification text changes are held within the affected source repository, using the GitHub flavor of markdown, in a file (or split across several files) with .md s

Re: [edk2-devel] [edk2-platform][PATCH v1 0/7] Platform/RaspberryPi : SMBIOS fixes and cleanup

2020-08-11 Thread Samer El-Haj-Mahmoud
Reminder for review of this series Thanks, --Samer > -Original Message- > From: devel@edk2.groups.io On Behalf Of Samer > El-Haj-Mahmoud via groups.io > Sent: Monday, July 20, 2020 2:17 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Pete Batard ; Andrei &g

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix RPi4 GICC PMU PPI

2020-08-11 Thread Samer El-Haj-Mahmoud
ups.io On Behalf Of Pete > Batard via groups.io > Sent: Monday, August 3, 2020 1:12 PM > To: devel@edk2.groups.io; Samer El-Haj-Mahmoud mahm...@arm.com> > Cc: Leif Lindholm ; Andrei Warkentin > (awarken...@vmware.com) ; Ard Biesheuvel > > Subject: Re: [edk2-devel

[edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix DBG2 UART namespace reference

2020-08-13 Thread Samer El-Haj-Mahmoud
The UART namespace reference in DBG2 is incorrect. Fix to point to the correct name. This fixes the certification failure reported by FWTS tests at: https://github.com/pftf/RPi4/issues/69 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj

[edk2-devel] [edk2-platform][PATCH v1 0/3] Platforms/RaspberryPi: Fix ComponentName2 SCT errors

2020-08-15 Thread Samer El-Haj-Mahmoud
Fix SCT errors on ComponentName2 protocol for the RPi drivers: DisplayDxe, BcmGenetDxe, and DwUsbHostDxe. Samer El-Haj-Mahmoud (3): Platforms/RaspberryPi: Fix DisplayDxe ComponentName2 error checking Platforms/RaspberryPi: Fix DwUsbHostDxe ComponentName2 error checking Platforms

[edk2-devel] [edk2-platform][PATCH v1 1/3] Platforms/RaspberryPi: Fix DisplayDxe ComponentName2 error checking

2020-08-15 Thread Samer El-Haj-Mahmoud
Fix input param error checking for the DisplayDxe ComponentName2 protocol. This fixes https://github.com/pftf/RPi4/issues/84 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/DisplayDxe

[edk2-devel] [edk2-platform][PATCH v1 2/3] Platforms/RaspberryPi: Fix DwUsbHostDxe ComponentName2 error checking

2020-08-15 Thread Samer El-Haj-Mahmoud
Fix input param error checking for the DwUsbHostDxe ComponentName2 protocol. This fixes https://github.com/pftf/RPi4/issues/86 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/DwUsbHostDxe

[edk2-devel] [edk2-platform][PATCH v1 3/3] Platforms/RaspberryPi: Fix BcmGenetDxe ComponentName2 error checking

2020-08-15 Thread Samer El-Haj-Mahmoud
Fix input param error checking for the BcmGenetDxe ComponentName2 protocol. This fixes https://github.com/pftf/RPi4/issues/85 Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Signed-off-by: Samer El-Haj-Mahmoud --- Silicon/Broadcom/Drivers/Net/BcmGenetDxe

Re: [edk2-devel] [edk2-platform][PATCH v1 1/3] Platforms/RaspberryPi: Fix DisplayDxe ComponentName2 error checking

2020-08-17 Thread Samer El-Haj-Mahmoud
Thanks Ard and Pete. I did use the cover letter, but forgot to add the CC https://edk2.groups.io/g/devel/message/64301 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel via groups.io > Sent: Monday, August 17, 2020 9:55 AM > To: Samer

[edk2-devel] [edk2-test][PATCH v1 0/4] uefi-sct/SctPkg: Add SCT Documents

2020-08-25 Thread Samer El-Haj-Mahmoud
Since UEFI Forum is no longer maintaining SCT, the documents, along with their source (word format), are being contributed to the edk2-test project for community ownership and maintenance. Cc: G Edhaya Chandran Cc: Eric Jin Signed-off-by: Samer El-Haj-Mahmoud Samer El-Haj-Mahmoud (4): uefi

[edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix build error in DisplayDxe

2020-08-26 Thread Samer El-Haj-Mahmoud
: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c b/Platform/RaspberryPi/Drivers/DisplayDxe/DisplayDxe.c index

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-26 Thread Samer El-Haj-Mahmoud
I agree with Andrew. I also found Laszlo's "unkempt guide" very useful. In addition, there is a short page by Peter Batard that adds more details on the commits validation, patchset generation, and e-mail submission: https://gist.github.com/pbatard/ec1c9d1dd6e7144b07a09b057b1735a8 > -Origi

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

2020-06-01 Thread Samer El-Haj-Mahmoud
+Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SCT patches. Thanks, --Samer > -Original Message- > From: devel@edk2.groups.io On Behalf Of Irene > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park ; > eric...

[edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi/RPi4: Add Asset Tag support

2020-06-04 Thread Samer El-Haj-Mahmoud
tin Cc: Rui Lopes Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf | 2 ++ Platform/RaspberryPi/Include/ConfigVars.h| 7 ++ Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 14

[edk2-devel] [edk2-platform][PATCH v3 4/6] Platform/RaspberryPi: Switch RPi3 USB NIC driver to Ax88772c

2020-06-08 Thread Samer El-Haj-Mahmoud
Switch the ASIX USB NIC driver used in the RPi3 to the new Ax88772c. Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Cc: Leif Lindholm Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- 2 files changed, 2

[edk2-devel] [edk2-platform][PATCH v3 1/6] Drivers/ASIX: Create ASIX package

2020-06-08 Thread Samer El-Haj-Mahmoud
Create a new ASIX package for build verification of ASIX USB drivers. Cc: Ray Ni Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Samer El-Haj-Mahmoud --- Drivers/ASIX/Asix.dec | 30 + Drivers/ASIX/Asix.dsc | 67 2 files changed, 97

[edk2-devel] [edk2-platform][PATCH v3 5/6] Platform/HiSilicon: Switch HiKey USB NIC driver to Ax88772c

2020-06-08 Thread Samer El-Haj-Mahmoud
Switch the ASIX USB NIC driver used in HiKey to the new Ax88772c. Cc: Ard Biesheuvel Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/Hisilicon/HiKey/HiKey.dsc | 2 +- Platform/Hisilicon/HiKey/HiKey.fdf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-platform][PATCH v3 0/6] Update ASIX USB Networking drivers

2020-06-08 Thread Samer El-Haj-Mahmoud
al ASIX provided code [Leif] Cc: Ray Ni Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud Samer El-Haj-Mahmoud (6): Drivers/ASIX: Create ASIX drivers package Drivers/ASIX: Add ASIX Ax88179 driver Driver

[edk2-devel] [edk2-platform][PATCH v2 1/1] Platforms/RaspberryPi: Add Asset Tag support

2020-06-08 Thread Samer El-Haj-Mahmoud
d and Name="AssetTag". For example: Shell> setvar AssetTag -guid CD7CC258-31DB-22E6-9F22-63B0B8EED6B5 -bs -rt -nv =L"ABC123" =0x This resolves this Github issue: https://github.com/pftf/RPi4/issues/54 Signed-off-by: Samer El-Haj-Mahmoud Reviewed-by: Andrei Warkentin

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi/RPi4: Add Asset Tag support

2020-06-08 Thread Samer El-Haj-Mahmoud
Thanks Andrei. I submitted a v2 with the commit message changes. I will also send a follow-up patch to add examples for RPi3/4 config scripting using the Shell From: devel@edk2.groups.io On Behalf Of Andrei Warkentin via groups.io Sent: Monday, June 8, 2020 11:53 AM To: Samer El-Haj-Mahmoud

[edk2-devel] [edk2-platform][PATCH v1 1/1] Drivers/Realtek: Add Realtek USB UNDI driver

2020-06-11 Thread Samer El-Haj-Mahmoud
/samerhaj/uefi_drivers/blob/master/UsbNetworking/ Realtek/zip/binary/RtkUsbUndiDxe.2.029.2020.04.14_signed_ARM.zip Cc: Ray Ni Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Samer El-Haj-Mahmoud --- Drivers/Realtek/Bus/Usb/UsbNetworking/Aarch64/RtkUsbUndiDxe.inf | 26

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Drivers/Realtek: Add Realtek USB UNDI driver

2020-06-11 Thread Samer El-Haj-Mahmoud
Ray, > -Original Message- > From: Ni, Ray > Sent: Thursday, June 11, 2020 11:52 PM > To: devel@edk2.groups.io; Samer El-Haj-Mahmoud mahm...@arm.com> > Cc: Leif Lindholm ; Ard Biesheuvel > ; Kinney, Michael D > Subject: RE: [edk2-devel] [edk2-platform][PATCH

[edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Remove DebugShowUEFIExit

2020-06-11 Thread Samer El-Haj-Mahmoud
ng the RPi PlatformBootManager to be more in-line with the ArmPkg version. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RaspberryPi.dec | 1 - Platform/Raspbe

[edk2-devel] [edk2-non-osi][PATCH v2 1/1] Drivers/Realtek: Add Realtek USB UNDI driver

2020-06-11 Thread Samer El-Haj-Mahmoud
/samerhaj/uefi_drivers/blob/master/UsbNetworking/ Realtek/zip/binary/RtkUsbUndiDxe.2.029.2020.04.14_signed_ARM.zip Cc: Ray Ni Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Samer El-Haj-Mahmoud --- Drivers/Realtek/Bus/Usb/UsbNetworking/Aarch64/RtkUsbUndiDxe.inf | 26

  1   2   3   >