Re: [edk2-devel] [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: Use SetRedfishSettingsObjectsUri

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Friday, March 22, 2024 10:41 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [edk2-redfish-client][PATCH V5 2/2] RedfishClientPkg/FeatureDriver: > Use SetRe

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 1/3] RedfishClientPkg: fix nodes count in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 1/3] RedfishCli

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 2/3] RedfishClientPkg: fix the last field processing in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 2/3] RedfishClie

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 3/3] RedfishClientPkg: fix the first node processing in GetRedpathNodeByIndex()

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, March 23, 2024 8:01 PM > To: devel@edk2.groups.io > Cc: Mike Maslenkin ; Abner Chang > ; Igor Kulchytskyy ; Nickle Wang > > Subject: [edk2-redfish-client][RFC PATCH 3/3] RedfishCli

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

Thanks for your reminder, Abner. I verify this patch series on my system, and I don't see any issue. Hi @Mike Maslenkin, please add Abner and my reviewed-by to the commit messages. And we can merge the pull request. Thanks, Nickle > -Original Message

Re: [edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

Hi Abner, Could we change "DescriptionStr" below to something like "XuefiString", so people don't think it is a regular English string of HII statement? > + EFI_STRING_ID Description; // String > token of this question. > + CHAR16

Re: [edk2-devel] [PATCH V2 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config language searching optimization

Per offline discussion with Abner, this will be addressed by separated patch since there is no function impact to performance improvements. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.

Re: [edk2-devel] [PATCH V2 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG macro

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 2/6] RedfishPkg/RedfishDebugLib: Introduce Redfish DEBUG > macro >

Re: [edk2-devel] [PATCH V2 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add RefishDebugLib support

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add > RefishDebugLib suppo

Re: [edk2-devel] [PATCH V2 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII string is deleted unexpectedly

Thanks for addressing this issue. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > Subject: [PATCH V2 4/6] RedfishPkg/RedfishPlatformCon

Re: [edk2-devel] [PATCH V2 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang > Subject: [PATCH V2 5/6] EmulatorPkg/Redfish: Use edk2 Redfish debug PCDs > > External email: Use caution

Re: [edk2-devel] [PATCH V2 6/6] RedfishPkg/RedfishPlatformConfigDxe: support menu path report

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy > Subject: [edk2-devel] [PATCH V2 6/6] Redfis

Re: [edk2-devel] [PATCH V2 0/6] [PATCH V2 0/5] Config language searching algorithm enhancement and the bug fixes

I have tested this patch series on my system and got a lot of performance improvements too. Great work, Abner! Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Tuesday, March 26, 2024 11:15 PM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy > S

Re: [edk2-devel] [edk2-redfish-client][RFC PATCH 0/3] RedfishClientPkg: fix GetRedpathNodeByIndex()

Thanks, Mike! I merged this pull request. Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Wednesday, March 27, 2024 5:19 AM > To: Nickle Wang > Cc: Chang, Abner ; devel@edk2.groups.io; Igor > Kulchytskyy > Subject: Re: [edk2-redfish-client][RFC PATCH 0/3] RedfishCl

[edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

Introduce SecureBoot driver to support /redfish/v1/Systems/SYS/SecureBoot resource. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishClientComponents.dsc.inc | 2 + RedfishClientPkg/RedfishClientLibs.dsc.inc| 4 + .../SecureBoot

[edk2-devel] [edk2-redfish-client][PATCH v2 2/2] RedfishClientPkg/Features: release resources

-Release Etag and PendingSettingUri resources. -Update function header for GetHttpResponseEtag() and GetHttpResponseLocation(). Caller has to release returned memory buffer from these two functions. -Fix typo. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez ---

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/Features: Variable used before being initialized

Private->Uri is initialized after calling SetRedfishSettingsObjectsUri() but it is used in SetRedfishSettingsObjectsUri function. Use input parameter "Uri" instead. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/Features: Variable used before being initialized

Thanks for your review, Abner! I merged this change. Regards, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, April 2, 2024 1:04 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re: [edk2-de

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 1/2] RedfishClientPkg/Features: support Redfish Secure Boot

Thanks for your review, Abner! The reason why I keep HPE copyright statement is because I create this feature driver by copying existing one and modifying it. Since I still leverage some functions contributed by HPE, I think I am supposed to keep HPE copyright statement. Regards, Nickle > ---

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

-Introduce RedfishBootstrapAccountDxe to delete bootstrap account from /redfish/v1/AccountService/Accounts after BIOS finished all Redfish jobs. The bootstrap account won't be available to other application. So deleting bootstrap account helps to release resource at BMC. - After bootstrap account i

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Igor, Abner, Thanks for your review. Please allow me to answer your questions together. > 1. We suppose acquire the credential before we start to communicate with > Redfish. Will Redfish credential driver create another bootstrap account here > after provisioning? No, according to the Redfis

[edk2-devel] [PATCH] RedfishPkg: Rename x-uefi-redfish to x-UEFI-redfish

Rename x-uefi-redfish to x-UEFI-redfish to match the format of UEFI configuration namespace prefix. RFC: https://edk2.groups.io/g/rfc/message/849 Signed-off-by: Jeff Brasen Co-authored-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPkg.dec

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: rename x-uefi-redfish to x-UEFI-redfish

Rename x-uefi-redfish to x-UEFI-redfish to match the format of UEFI configuration namespace prefix. RFC: https://edk2.groups.io/g/rfc/message/849 Signed-off-by: Jeff Brasen Co-authored-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/

[edk2-devel] [edk2-redfish-client][PATCH] Tool/Redfish-Profile-Simulator: fix Werkzeug security issue

Upgrade Werkzeug to version 3.0.3 to address CVE-2024-34069 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- Tools/Redfish-Profile-Simulator/redfishProfileSimulator.py | 7 --- Tools/Redfish-Profile-Simulator/requirements.txt | 6 ++ 2 fil

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Hi Nhi, This task is on my list but with lower priority. I will try to provide version 2 patch for review here by the end of this week. Thanks, Nickle > -Original Message- > From: Nhi Pham > Sent: Monday, May 13, 2024 5:02 PM > To: devel@edk2.groups.io; abner.ch...@amd.com; Nickle Wan

[edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

-Introduce RedfishBootstrapAccountDxe to delete bootstrap account from /redfish/v1/AccountService/Accounts after BIOS finished all Redfish jobs. The bootstrap account won't be available to other application. So deleting bootstrap account helps to release resource at BMC. - After bootstrap account i

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Abner, > Ok, then I don't have the problem with invoking GetAuthInfo again. However, I > will suggest to add more description in GetAuthInfo function header, mention > that > we will keep the auth info in EFI variable until exist boot service. > Also, give some more descriptions on the code yo

[edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file for OEM net function

Add net function definitions for OEM/Non-IPMI group request and response Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Abdul Lateef Attar Cc: Nick Ramirez --- MdePkg/Include/IndustryStandard/IpmiNetFnOem.h | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 MdePkg/I

[edk2-devel] [edk2-platforms][PATCH v2] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4773 This change implements the blob transfer protocol used in OpenBmc documented here: https://github.com/openbmc/phosphor-ipmi-blobs Signed-off-by: Nick Ramirez Co-authored-by: Nickle Wang Cc: Abner Chang Cc: Abdul Lateef Attar Cc: Tinh Ngu

Re: [edk2-devel] [edk2-platforms][PATCH] ManageabilityPkg: add support for the phosphor ipmi blob transfer protocol

Hi Nhi, Version 2 patch files are sent for review here: https://edk2.groups.io/g/devel/message/118914 and https://edk2.groups.io/g/devel/message/118922 For your convenience, below are two pull requests if you would like to test them. 1) https://github.com/tianocore/edk2/pull/5660 2) https://g

Re: [edk2-devel] [PATCH] MdePkg: Add Ipmi definitions header file for OEM net function

kle, > Do you have the corresponding PR for this? I will merge it after hard freeze. > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Nickle > > Wang via groups.io > > Sent: Wednesday, May 15, 2024 4:50 PM > >

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Igor, Abner, > Maybe we should consider moving RedfishBootstrapAccountDxe driver to > RedfishPkg and have some register mechanism which will be used by interested > drivers to notify that they finished their job and after that > RedfishBootstrapAccountDxe driver would delete an account. You

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

> RedfishFeatureCore could be one of the Redfish clients, delete the credential > from > Redfish account service in RedfishFeatureCore lifecycle may impact other > Redfish > clients that still need the communication with Redfish service, right? When all Redfish clients are managed by RedfishFeat

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: introduce RedfishBootstrapAccountDxe

Hi Igor, Thanks for your idea. This sounds feasible to me. Let me try to test it on my system. Regards, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, May 16, 2024 7:34 PM > To: Nickle Wang ; Chang, Abner > ; devel@edk2.groups.io > Cc: Nick Ramirez > Subject: R

Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

> Should the following change be made to make sure RegularExpressionDxe is > loaded before RedfishPlatformConfigDxe? It is ok that RegularExpressionDxe is loaded after RedfishPlatformConfigDxe because EfiCreateProtocolNotifyEvent() is used to get Regular expression protocol. And I don't have obj

Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

Hi @Rebecca Cran, I create pull request here to downgrade the message level to DEBUG_INFO: https://github.com/tianocore/edk2/pull/5897 Regards, Nickle > -Original Message- > From: Rebecca Cran > Sent: Wednesday, July 10, 2024 2:48 AM > To: Nickle Wan

Re: [edk2-devel] Redfishlib: How does it work?

1. We are moving from RedfishLib to Redfish http protocol (gEdkIIRedfishHttpProtocolGuid). I would recommend you to use Redfish http protocol for Redfish communication. 2. Redfish config handler protocol is installed by Redfish application. It will be called by RedfishConfigHandler driver when

[edk2-devel] [PATCH] Maintainers.txt: Update email address

Update Nickle's email address from csie.io to nvidia.com for those packages which are reviewed by Nickle. Per suggestion from Abner, change Nickle from reviewer to maintainer for RedfishPkg. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Abner Chang Signed-off-by: Nickle Wang ---

[edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix JsonLib build failure

VS2019 reports build failure: "warning C4701: potentially uninitialized local variable 'Ucs2Str' used". Initial Ucs2Str to NULL at the beginning of function. Cc: Abner Chang Cc: Nick Ramirez Signed-off-by: Nickle Wang --- RedfishPkg/Library/JsonLib/JsonLib.c | 2 ++ 1 file changed, 2 insertion

[edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

This library follows Redfish Host Interface specification and use IPMI command to get bootstrap account credential(NetFn 2Ch, Command 02h) from BMC. RedfishHostInterfaceDxe will use this credential for the following communication between BIOS and BMC. Cc: Abner Chang Cc: Nick Ramirez Signed-off-

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

Thanks for your review comments, Abner! I will update new version patch later. The CI build error will be handled together. > please add Igor as reviewer too Sure! > + *UserId = AllocateZeroPool (sizeof (CHAR8) * USERNAME_MAX_SIZE); > + if [Chang, Abner] Allocation memory with the size (USER

Re: [edk2-devel] [PATCH 0/5] RedfishClientPkg: fix issues with local variables.

Hi Mike, > I didn't find any codyng-style issues in uncrustify output. I fetch your branch and run uncrustify tool to fix error in vs code editor. I push the fix to your branch at this commit for your reference: https://github.com/ghbaccount/edk2-redfish-client/commit/f22209f7bd5946168326a31970

Re: [edk2-devel] [PATCH 0/5] RedfishClientPkg: fix issues with local variables.

vial spelling fixes. Do I need to > resend v.2 to > the list? > > Regards, > Mike. > > On Mon, Aug 28, 2023 at 12:03 PM Nickle Wang via groups.io > wrote: > > > > Hi Mike, > > > > > I didn't find any codyng-style issues in uncrustify output. &g

Re: [edk2-devel] [PATCH v2 1/6] RedfishClientPkg: fix crash on access to uninialized list variable.

Reviewed-by: Nickle Wang @abner.ch...@amd.com, I am thinking that we may need to provide allocation function for CS structure so caller does not need to handle linked-list initialization like this one, or other stuff requies understanding to CS structure implement

Re: [edk2-devel] [PATCH v2 2/6] RedfishClientPkg: fix access to uninitialized variable

Thanks for fixing this issue, Mike. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 2

Re: [edk2-devel] [PATCH v2 3/6] RedfishClientPkg: fix leak of allocated Etag data

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 3/6] RedfishClientPkg: fix leak of a

Re: [edk2-devel] [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables write.

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 4/6] RedfishClientPkg: fix memory le

Re: [edk2-devel] [PATCH v2 5/6] RedfishClientPkg: fix misprints in Readme.md

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 5/6] RedfishClientPkg: fix misprints

Re: [edk2-devel] [PATCH v2 6/6] RedfishClientPkg: spelling fixes

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, August 29, 2023 4:01 PM > To: devel@edk2.groups.io > Cc: abner.ch...@amd.com; Nickle Wang ; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH v2 6/6] RedfishClientPkg: spelling fixe

[edk2-devel] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

StatementValue->Buffer is converted from ASCII to Unicode by caller already so we don't have to convert it again. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe.c| 11 +-- 1 file changed, 5 inse

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

Hi Igor, Version 2 is here: https://edk2.groups.io/g/devel/message/108516 Please help me to review this while you have chance. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Thursday, August 3, 2023 9:27 PM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Abner Chan

[edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg: update Readme.md

Update readme for below topics: - The call flow of BIOS Redfish provisioning scenario. - The call flow of BIOS Redfish pending settings scenario. - The call flow of Redfish feature driver dispatch. - Redfish foundation driver stack design. - The design of Redfish Platform Config Protocol. - The des

[edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

JsonObjectGetValue() cannot find corresponding JSON value when the EDKII_JSON_VALUE object is created by another UEFI driver. This is because "hashtable_seed" is initialized by current time while JsonLib is loaded. So, "hashtable_seed" will be different in each individual UEFI driver. Signed-off-b

[edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Return unsupported HTTP status code to caller so caller can handle HTTP error status code. Current implementation only return EFI error to caller. Without knowing the HTTP status code, caller has trouble to handle HTTP request failure. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchyts

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Hi Mike, Sorry for my late response. Version2 is here: https://edk2.groups.io/g/devel/message/108778 Please help me to review it while you have chance. Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Thursday, August 3, 2023 6:16 PM > To: Nickle Wang > Cc: devel@ed

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

- > From: devel@edk2.groups.io On Behalf Of Nickle Wang > via groups.io > Sent: Monday, September 18, 2023 9:13 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy ; > Nick Ramirez ; Mike Maslenkin > > Subject: [edk2-devel] [PATCH v2] RedfishPkg/Redfis

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

Thanks, Mike! I will add your acked-by to commit message and merge it. Regards, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, September 19, 2023 9:54 PM > To: Nickle Wang > Cc: devel@edk2.groups.io; Abner Chang ; Igor > Kulchytskyy ; Nick Ramirez > Subject: Re: [e

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Igor, According to my understanding to jansson implementation, json_object_seed() is only called in three places. Two of them are in test code and we don't use them in EDK2. The only chance to call json_object_seed() is in json_object(). So, it is called when driver create new JSON object an

[edk2-devel] [PATCH v2] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

JsonObjectGetValue() cannot find corresponding JSON value when the EDKII_JSON_VALUE object is created by another UEFI driver. This is because "hashtable_seed" is initialized by current time while JsonLib is loaded. So, "hashtable_seed" will be different in each individual UEFI driver. Signed-off-b

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: fix JsonObjectGetValue issue

Hi Abner, I add suggested comment in version 2: https://edk2.groups.io/g/devel/message/108942 Thanks, Nickle > -Original Message- > From: Chang, Abner > Sent: Thursday, September 21, 2023 10:20 AM > To: Igor Kulchytskyy ; Nickle Wang ; > devel@edk2.groups.io > Cc: Nick Ramirez > Subje

[edk2-devel] [edk2-redfish-client][PATCH v2] RedfishClientPkg: update Readme.md

Update readme for below topics: - The call flow of BIOS Redfish provisioning scenario. - The call flow of BIOS Redfish pending settings scenario. - The call flow of Redfish feature driver dispatch. - Redfish foundation driver stack design. - The design of Redfish Platform Config Protocol. - The des

Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

Patch set Reviewed-by: Nickle Wang mailto:nick...@nvidia.com>> Hi @Mike Maslenkin, could you please add Abner and my Reviewed-by to two commit messages in this PR? https://github.com/tianocore/edk2-redfish-client/pull/53 And then I will merge this pull req

Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage

Sorry for my late response. > Do we need pack(1) for this structure? We can remove pack directive if we > don't > need to have packed structure members. @nick...@nvidia.com, could you > please confirm this? I see the use of "pack(1)" in EDK2 DriverSample.h. I think we can keep it. Reviewed-by

Re: [edk2-devel] [PATCH 5/9] RedfishClientPkg: reduce identation level by adding early return

Sorry for the delay review. I go through the changes, and it looks good to me. Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Monday, October 2, 2023 11:10 AM > To: Mike Maslenkin ; devel@edk2.groups.io; Nickle > Wang > Cc: ig...@ami.com >

Re: [edk2-devel] [PATCH] RedfishPkg: Use base version SortLib for the specific modules

Reviewed-by: Nickle Wang Regards, Nickle > -Original Message- > From: abner.ch...@amd.com > Sent: Wednesday, October 11, 2023 11:41 AM > To: devel@edk2.groups.io > Cc: Nickle Wang ; Igor Kulchytskyy ; Nhi > Pham > Subject: [PATCH] RedfishPkg: Use base version SortLib for the specific

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

Hi Igor, Thank you for your help to review my changes. > And it will be blocked by our IPMI call. I see your point. So, BIOS should never be the person to shutdown credential service because BIOS always get executed prior to OS, right? > Should it be configured with some PCD? Maybe user may

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

to OS through EFI variable with disabling the bootstrap credential at exit boot service. Abner > RedfishCredentialGetAuthInfo and then use those cashed credentials on > subsequential calls? > It will also may save a boot time, since there is no need to send IPMI > command. > >

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialLib: IPMI implementation

cated, otherwise we can deliver the credential to OS through EFI variable with disabling the bootstrap credential at exit boot service. Abner > RedfishCredentialGetAuthInfo and then use those cashed credentials on > subsequential calls? > It will also may save a boot time, since there is

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: Fix memory free issue

Reviewed-by: Nickle Wang From: devel@edk2.groups.io on behalf of Chang, Abner via groups.io Sent: Saturday, October 29, 2022 11:59 AM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: Fix

[edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC build error

Fix below GCC build error: 1) "Head" dereference issue. 2) "BooleanArrayBuffer" uninitialized variable issue. 3) Multiple definition of mRedfishVariableGuid. 4) Multiple definition of medfishResourceConfigProtocolHandle. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick R

[edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Fix GCC build error on AARCH64 system. Signed-off-by: Nickle Wang Cc: Jian J Wang Cc: Liming Gao Cc: Nick Ramirez --- .../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 5 + 1 file changed, 5 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefi

[edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix typo

Fix typo in RedfishPlatformConfigImpl.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe

[edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo

Fix typo in RedfishPlatformConfigImpl.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

be simpler to only check for 32-bit archs and assume all others are 64-bit. #if defined (MDE_CPU_IA32) || defined (MDE_CPU_ARM) || defined (MDE_CPU_EBC) #define SIZEOF_VOIDP 4 #else #define SIZEOF_VOIDP 8 #endif Thanks, Mike > -Original Message- > From: devel@edk2.groups.io

[edk2-devel] [PATCH V2] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Fix GCC build error on AARCH64 system. Signed-off-by: Nickle Wang Cc: Jian J Wang Cc: Liming Gao Cc: Nick Ramirez --- .../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Universal/RegularExpressionD

[edk2-devel] [PATCH V3] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Fix GCC build error on AARCH64 system. Signed-off-by: Nickle Wang Cc: Jian J Wang Cc: Liming Gao Cc: Michael D Kinney Cc: Nick Ramirez --- .../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Univer

Re: [edk2-devel] [PATCH 1/1] RedfishPkg: Fix typos of the .inc filenames

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: Chang, Abner Sent: Friday, December 2, 2022 7:36 AM To: Rebecca Cran ; devel@edk2.groups.io; Nickle Wang Cc: Igor Kulchytskyy Subject: RE: [PATCH 1/1] RedfishPkg: Fix typos of the .inc filenames External email: Use c

Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file

Reviewed-by: Nickle Wang Regards, Nickle From: devel@edk2.groups.io On Behalf Of Igor Kulchytskyy via groups.io Sent: Tuesday, December 6, 2022 10:32 PM To: Chang, Abner ; Michael D Kinney ; devel@edk2.groups.io Cc: Nickle Wang Subject: Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlap

[edk2-devel] [edk2-staging][PATCH 0/3] Add new interfaces to Redfish protocol

Introduce two new iterfaces to Redfish Platform Config Protocol: - GetAttribute() returns attribute details from HII question. - GetDefaultValue() returns default value of attribute. They are used to generate BIOS attribute registry. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytsk

[edk2-devel] [edk2-staging][PATCH 1/3] edk2-staging/RedfishPkg: Add interface to get question default value

Implement GetQuestionDefault() in HiiUtilityLib. Caller can get question default value from this interface. GetQuestionDefault() is created and modifed from SetupBrowserDxe\Setup.c under MdeModulePkg. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- Redfish

[edk2-devel] [edk2-staging][PATCH 2/3] edk2-staging/RedfishPkg: Introduce new interfaces to Redfish protocol

Add two new iterfaces to Redfish Platform Config Protocol. GetAttribute() return attribute details and GetDefaultValue() get default value of attribute. These two interfaces are used to generate BIOS Attribute Registry Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ram

[edk2-devel] [edk2-staging][PATCH 3/3] edk2-staging/RedfishPkg: Add new interfaces to Redfish library

Add two new iterfaces to Redfish Platform Config Library in order to support GetAttribute() and GetDefaultValue() interfaces. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Library/RedfishPlatformConfigLib.h| 44 .../RedfishPlatfo

[edk2-devel] [edk2-staging][PATCH 0/3] Introduce resource addendum protocol

Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish feature driver. Feature driver uses this protocol to query OEM resource from platform in order to support Redfish OEM property. This protocol is also used to get addendum data that is required by BMC to manage Redfish BIOS service. Si

[edk2-devel] [edk2-staging][PATCH 1/3] edk2-staging/RedfishClientPkg: Add Redfish Resource Addendum Protocol

Introduce Redfish Resource Addendum Protocol to Redfish feature driver. Feature driver uses this protocol to query OEM resource from platform in order to support Redfish OEM property. This protocol is also used to get addendum data that is required by BMC to manage Redfish BIOS service. Signed-off

[edk2-devel] [edk2-staging][PATCH 2/3] edk2-staging/RedfishClientPkg: Add Redfish Resource Addendum Library

Implement RedfishAddendumLib to support Redfish Resource Addendum Protocol. Feature driver calls this library to get addendum data before providing data to Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Include/Library/RedfishAddendum

[edk2-devel] [edk2-staging][PATCH 3/3] edk2-staging/RedfishClientPkg: Utilize RedfishAddendumLib

Bios feature driver utilizes RedfishAddendumLib and get additional data before sending BIOS attributes to Redfish service. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 100 ++ .../Features/

Re: [edk2-devel] [PATCH 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

Hi Abner, @@ -119,7 +123,7 @@ RedfishCreateSmbiosTable42 ( } else { NewProtocolRecords = ReallocatePool (CurrentProtocolsDataLength, NewProtocolsDataLength, (VOID *)ProtocolRecords); if (NewProtocolRecords == NULL) { -DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory fo

Re: [edk2-devel] [PATCH 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:17 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use cauti

Re: [edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

Thanks for addressing my comment. Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:51 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platfor

Re: [edk2-devel] [PATCH V2 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Monday, December 19, 2022 10:52 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use ca

Re: [edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

al Message- From: devel@edk2.groups.io On Behalf Of Nickle Wang via groups.io Sent: Monday, December 19, 2022 11:11 PM To: abner.ch...@amd.com; devel@edk2.groups.io Cc: Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH V2 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

Re: [edk2-devel] [PATCH V3 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification

Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: abner.ch...@amd.com Sent: Tuesday, December 20, 2022 2:41 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V3 1/2] RedfishPkg/RedfishHostInterface: Platform Redfish HI notification External

Re: [edk2-devel] [PATCH V3 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Tuesday, December 20, 2022 2:42 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V3 2/2] EmulatorPkg/RedfishHostInterface: Add NULL function External email: Use ca

Re: [edk2-devel] [PATCH 3/3] RedfishPkg/Include: Redfish USB Interface V2 update

Hi Abner, Could you please also fix the typo in USB_INTERFACE_DEVICE_DESCRIPTOR_V2 structure together? There is typo at line 43: https://github.com/tianocore/edk2/blob/a086f4a63bc0295b0b02f8ee76381c6b437122bf/RedfishPkg/Include/IndustryStandard/RedfishHostInterface.h#L43 UINT8 SecialNumbe

Re: [edk2-devel] [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update

Reviewed-by: Nickle Wang Regards, Nickle -Original Message- From: abner.ch...@amd.com Sent: Wednesday, December 28, 2022 1:14 PM To: devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [PATCH V2 3/3] RedfishPkg/Include: Redfish USB Interface V2 update External email: Use

[edk2-devel] [PATCH v2 0/5] Introduce EDKII Redfish Platform Config Protocol

Introduce EDKII Redfish Platform Config Protocol and corresponding libraries. This protocol is the interface between UEFI platform configuration and Redfish property. It could handle different firmware implementation and the implementation here is to map EDK2 HII questions to the properties defin

[edk2-devel] [PATCH v2 1/5] RedfishPkg: introduce EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

EDKII Redfish Platform Config Protocol defines the protocol interfaces that abstracts the platform configuration format and storage from EDK2 Redfish Feature driver. This protocol provides the interfaces to get and set platform configuration with the format and configuration storage agnostic to the

[edk2-devel] [PATCH v2 4/5] RedfishPkg: Helper library of EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL

This is the helper library for using EDKII_REDFISH_PLATFORM_CONFIG_PROTOCOL. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPkg.dec | 5 + .../RedfishPlatformConfigLib.inf | 41 +++ .../Library/Redfish

[edk2-devel] [PATCH v2 5/5] RedfishPkg: Add Redfish Platform Config Protocol to RedfishPkg

Add RedfishPlatformConfigDxe driver and corresponding library to RedfishPkg. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/RedfishComponents.dsc.inc | 3 +++ RedfishPkg/RedfishLibs.dsc.inc | 2 ++ RedfishPkg/Red

[edk2-devel] [PATCH 1/1] MdeModulePkg/RegularExpressionDxe: Fix Arm build error

Fix Arm CI build error: - ArmPkg/Library/CompilerIntrinsicsLib/memset.c:39:1: warning: type of ‘memset’ does not match original declaration [-Wlto-type-mismatch] MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c:123:1: note: type ‘char’ should match type ‘int’ - multiple definition of

<    1   2   3   4   5   6   >