StatementValue->Buffer is converted from ASCII to Unicode by caller already so we don't have to convert it again.
Signed-off-by: Nickle Wang <nick...@nvidia.com> Cc: Abner Chang <abner.ch...@amd.com> Cc: Igor Kulchytskyy <ig...@ami.com> Cc: Nick Ramirez <nrami...@nvidia.com> --- .../RedfishPlatformConfigDxe.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index f2a8e77d9b00..30d2ef351eca 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -1660,12 +1660,11 @@ RedfishPlatformConfigSetStatementCommon ( // in string format from HII point of view. Do a patch here. // if ((TargetStatement->HiiStatement->Operand == EFI_IFR_ONE_OF_OP) && (StatementValue->Type == EFI_IFR_TYPE_STRING)) { - TempBuffer = StrToUnicodeStr ((CHAR8 *)StatementValue->Buffer); - if (TempBuffer == NULL) { - return EFI_OUT_OF_RESOURCES; - } - - FreePool (StatementValue->Buffer); + // + // Keep input buffer to TempBuffer because StatementValue will be + // assigned in HiiStringToOneOfOptionValue(). + // + TempBuffer = (EFI_STRING)StatementValue->Buffer; StatementValue->Buffer = NULL; StatementValue->BufferLen = 0; -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108516): https://edk2.groups.io/g/devel/message/108516 Mute This Topic: https://groups.io/mt/101310452/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-